michaelweghorn (Michael Weghorn)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Aug 21 2017, 7:57 PM (91 w, 6 d)
Availability
Available

Recent Activity

Wed, May 22

michaelweghorn added a comment to D20197: Fix desktop link to file or directory.

Thanks, I've learned that QFileDialog only creates a well behaving directory chooser, if the QFileDialog::ShowDirsOnly option is set to true _after_ having set the fileMode to QFileDialog::Directory. If you do it the other way around, it doesn't add directories to the selection.

Wed, May 22, 6:23 AM · Frameworks

Sat, Apr 27

michaelweghorn requested review of D20868: Support '#page=<pagenum>' fragment to open at page <pagenum>.
Sat, Apr 27, 2:07 PM · Okular

Apr 15 2019

michaelweghorn added a comment to D18179: PDF: Implement scaling options for non-rasterized printing.

OK, let's go for it!

@michaelweghorn I hope you know this means you're on the hook to fix any bugs that crop up, right? :)

Apr 15 2019, 6:26 AM · Okular

Apr 4 2019

michaelweghorn updated the diff for D18179: PDF: Implement scaling options for non-rasterized printing.

Changes in this revision:

Apr 4 2019, 7:44 AM · Okular

Apr 3 2019

michaelweghorn added a comment to D18179: PDF: Implement scaling options for non-rasterized printing.

Never mind, removing the dependency made it work. Stupid Arc. :( Testing now...

Apr 3 2019, 4:31 PM · Okular
michaelweghorn added a comment to D10974: Add option to ignore print margins for non-PDF generators.

Do you really not have commit access yet? You should apply. :) https://techbase.kde.org/Contribute/Get_a_Contributor_Account

Meanwhile, I'll land this for you.

Apr 3 2019, 4:29 PM · Okular
michaelweghorn removed a dependency for D18179: PDF: Implement scaling options for non-rasterized printing: D10974: Add option to ignore print margins for non-PDF generators.
Apr 3 2019, 4:25 PM · Okular
michaelweghorn removed a dependent revision for D10974: Add option to ignore print margins for non-PDF generators: D18179: PDF: Implement scaling options for non-rasterized printing.
Apr 3 2019, 4:25 PM · Okular
michaelweghorn added a comment to D10974: Add option to ignore print margins for non-PDF generators.

If someone wants to test it and approve it and Michael says he'll fix any bug that arises from here i'm happy enough

Apr 3 2019, 6:17 AM · Okular

Apr 2 2019

michaelweghorn added a comment to D10974: Add option to ignore print margins for non-PDF generators.
I'm still not thrilled about the {nav Force Rasterization} situation (I think it should be implicitly turned on when the user chooses an option that requires it) but the combobox is good.
Apr 2 2019, 8:56 PM · Okular
michaelweghorn added a comment to D10974: Add option to ignore print margins for non-PDF generators.

Is there anything I can still do right now or do I just need to wait for the review?

Apr 2 2019, 7:11 AM · Okular

Feb 14 2019

michaelweghorn added a comment to D18744: Add action in Edit menu to select the text on current page.

The test plan still says that Ctrl+P will select the page ("or press combination of CTRL and P to select the entire page"). As far as I understand the previous comments, this is Alt+P now, isn't it? (I didn't do any tests.) Can you update the description accordingly?

Feb 14 2019, 9:35 PM · Documentation, Okular
michaelweghorn added a comment to D18744: Add action in Edit menu to select the text on current page.

The test plan still says that Ctrl+P will select the page ("or press combination of CTRL and P to select the entire page"). As far as I understand the previous comments, this is Alt+P now, isn't it? (I didn't do any tests.) Can you update the description accordingly?

Feb 14 2019, 9:34 PM · Documentation, Okular

Feb 2 2019

michaelweghorn added a comment to D18648: Show more information on CUPS auth dialog.

Thanks a lot! I'll take a look at these links.

Feb 2 2019, 12:36 AM
michaelweghorn requested review of D18659: Add .arcconfig.
Feb 2 2019, 12:32 AM
michaelweghorn reopened D18648: Show more information on CUPS auth dialog.

(accidently closed the revision, so reopending it now)

Feb 2 2019, 12:26 AM
michaelweghorn closed D18648: Show more information on CUPS auth dialog.

Thanks for the super-quick review!

Feb 2 2019, 12:25 AM

Feb 1 2019

michaelweghorn requested review of D18648: Show more information on CUPS auth dialog.
Feb 1 2019, 5:02 PM

Jan 17 2019

michaelweghorn added a comment to D18179: PDF: Implement scaling options for non-rasterized printing.

The only way i can think of is making the long form not havve default values

https://paste.kde.org/p55lx6vrh

Jan 17 2019, 1:09 PM · Okular
michaelweghorn updated the diff for D18179: PDF: Implement scaling options for non-rasterized printing.

Changes in this revision:

Jan 17 2019, 1:08 PM · Okular
michaelweghorn added a comment to D10974: Add option to ignore print margins for non-PDF generators.

I don't really have the time to spend print stuff to check if this does what it says it does, so i'm just doing code review from the pure formal way.

Jan 17 2019, 10:17 AM · Okular
michaelweghorn updated the diff for D10974: Add option to ignore print margins for non-PDF generators.

Adapted according to Albert's feedback:

Jan 17 2019, 10:15 AM · Okular

Jan 16 2019

michaelweghorn added a comment to D18179: PDF: Implement scaling options for non-rasterized printing.

If you have any other idea on how to avoid that issue with the printFiles() methods, I'd be thankful to hear about this.

Jan 16 2019, 11:21 AM · Okular
michaelweghorn added a comment to D18179: PDF: Implement scaling options for non-rasterized printing.

We would need a @since marker for the enum and for the new methods and a
// TODO merge with function above when a BIC change happens somehwere else
would also make sense

Jan 16 2019, 11:20 AM · Okular
michaelweghorn updated the diff for D18179: PDF: Implement scaling options for non-rasterized printing.
  • Adapt order of ScaleMode enum values as implicitly suggested in Albert's comment (I missed that at first)
Jan 16 2019, 11:16 AM · Okular
michaelweghorn updated the diff for D18179: PDF: Implement scaling options for non-rasterized printing.

Changes in this revision:

Jan 16 2019, 11:14 AM · Okular
michaelweghorn updated the diff for D10974: Add option to ignore print margins for non-PDF generators.

Changes in this revision:

Jan 16 2019, 10:19 AM · Okular

Jan 15 2019

michaelweghorn added a comment to D18179: PDF: Implement scaling options for non-rasterized printing.

Thanks for the feedback and info. I've update the change accordingly now.

Jan 15 2019, 12:35 PM · Okular
michaelweghorn updated the diff for D18179: PDF: Implement scaling options for non-rasterized printing.

Undo accidental whitespace changes

Jan 15 2019, 12:33 PM · Okular
michaelweghorn updated the diff for D18179: PDF: Implement scaling options for non-rasterized printing.

Implement improvements suggested by Albert:

Jan 15 2019, 12:30 PM · Okular
michaelweghorn updated the summary of D10974: Add option to ignore print margins for non-PDF generators.
Jan 15 2019, 10:45 AM · Okular
michaelweghorn added inline comments to D10974: Add option to ignore print margins for non-PDF generators.
Jan 15 2019, 10:43 AM · Okular
michaelweghorn updated the diff for D10974: Add option to ignore print margins for non-PDF generators.

Adapt according to Albert's feedback:

Jan 15 2019, 10:36 AM · Okular

Jan 12 2019

michaelweghorn added a comment to D18179: PDF: Implement scaling options for non-rasterized printing.

Maybe an enum is better than a bool so if in the future more scaling options are implemented we don't need to change the signature again?

Jan 12 2019, 12:54 PM · Okular

Jan 11 2019

michaelweghorn added a comment to D18118: Presentation mode: go to previous page when left-clicking on left half of the page.

OK, I understand. I don't have any strong opinion on this then.

Jan 11 2019, 10:42 AM · Okular
michaelweghorn added a comment to D10974: Add option to ignore print margins for non-PDF generators.

I agree that the current UI that makes you click "Force Rasterization" first is not ideal. Kudos if you find a technically acceptable way to improve that! :)

Jan 11 2019, 10:37 AM · Okular
michaelweghorn added a dependency for D18179: PDF: Implement scaling options for non-rasterized printing: D10974: Add option to ignore print margins for non-PDF generators.
Jan 11 2019, 10:34 AM · Okular
michaelweghorn added a dependent revision for D10974: Add option to ignore print margins for non-PDF generators: D18179: PDF: Implement scaling options for non-rasterized printing.
Jan 11 2019, 10:34 AM · Okular
michaelweghorn requested review of D18179: PDF: Implement scaling options for non-rasterized printing.
Jan 11 2019, 10:32 AM · Okular
michaelweghorn updated the diff for D10974: Add option to ignore print margins for non-PDF generators.

Changes in this version:

Jan 11 2019, 10:21 AM · Okular
michaelweghorn added a comment to D18118: Presentation mode: go to previous page when left-clicking on left half of the page.

Do you speak for both mouse clicks and touch screen 'clicks'? Because the original wish is really only about touch screens, and the effects of this patch on mouse clicks was at least partially caused by my laziness (it's currently easier to treat them both the same).

Jan 11 2019, 8:39 AM · Okular
michaelweghorn added a comment to D18118: Presentation mode: go to previous page when left-clicking on left half of the page.

I'd also prefer to leave the current behaviour of a left-click as it is, regardless of the exact position. That is also in line with what e.g. LibreOffice Impress does. Allowing to go back by doing a single-finger swipe sounds great.

Jan 11 2019, 7:35 AM · Okular

Jan 8 2019

michaelweghorn added a comment to D7949: Allow to print pdf doc directly into a QPrinter.

Thanks for the explanation!

Jan 8 2019, 9:29 PM · Okular

Jan 5 2019

michaelweghorn added a comment to D7949: Allow to print pdf doc directly into a QPrinter.

I find the approach interesting at least. However, I currently don't know enough of the different Poppler backends to really assess the situation properly. My thought was that it might possibly make sense to add an experimental option to enable this and https://git.reviewboard.kde.org/r/130235/ if the Arthur backend has general advantages over Splash and there was the plan to get it "production-ready". Can anybody quickly explain what the situation and plan with those backends is or is that too complex?

Jan 5 2019, 6:52 PM · Okular

Jan 4 2019

michaelweghorn added a comment to D10974: Add option to ignore print margins for non-PDF generators.

Is this even still necessary now that we have D7962? The new scaling combobox has an option to "Fit to full page" which ignores the margins (To respect them, you use "Fit to Printable area")

Jan 4 2019, 11:23 AM · Okular

Dec 25 2018

michaelweghorn added a comment to D10974: Add option to ignore print margins for non-PDF generators.

D7962 just landed! :)

Dec 25 2018, 10:11 PM · Okular

Sep 21 2018

michaelweghorn abandoned D9336: Change default mouse mode to TextSelect.

Thanks for your helpful feedback. Given the last comments, I agree that having text selection mode is probably not particularly useful for touch displays. I'm thus abandoning this change.

Sep 21 2018, 9:51 PM · Okular
michaelweghorn added a comment to D9336: Change default mouse mode to TextSelect.

Doesn't this make Okular much less touch-friendly by default?

Sep 21 2018, 5:57 AM · Okular

Jul 20 2018

michaelweghorn added inline comments to D7962: Implement several new print scaling options.
Jul 20 2018, 3:10 PM · Okular
michaelweghorn added a comment to D7962: Implement several new print scaling options.

While testing, the options did not seem to have any effect for me; changing them did not affect the printout.

Jul 20 2018, 3:08 PM · Okular
michaelweghorn added a comment to D10974: Add option to ignore print margins for non-PDF generators.

[...] Unless there's any objection to this, I'll try to have a closer look at this sometime next week (also after looking more closely at Oliver's updated printing-related changes D7949 and D7962).

Jul 20 2018, 2:38 PM · Okular
michaelweghorn added inline comments to D7949: Allow to print pdf doc directly into a QPrinter.
Jul 20 2018, 2:19 PM · Okular
michaelweghorn added a comment to D7949: Allow to print pdf doc directly into a QPrinter.

The patch should not influence the behavior of rasterized printing. The code used QPrinter with the poppler splash backend before, and it should still do that.

Jul 20 2018, 2:17 PM · Okular

Jul 10 2018

michaelweghorn added a comment to D10974: Add option to ignore print margins for non-PDF generators.

@arthurpeters: Thanks for your ideas on this. For now, I'd like to stick with the two options that have been discussed so far in this change (see reasoning in D10974#217969) and suggest to handle potential further improvements separately.

Jul 10 2018, 11:07 PM · Okular
michaelweghorn added a comment to D7949: Allow to print pdf doc directly into a QPrinter.

In general, I really like the idea of providing this new option.

Jul 10 2018, 10:54 PM · Okular

Jun 29 2018

michaelweghorn added a comment to D10974: Add option to ignore print margins for non-PDF generators.

I might have missed something, but I'm not yet sure what the "correct" wording for the two options in the radio button or combobox would be. :-)

Jun 29 2018, 4:22 PM · Okular

Jun 7 2018

michaelweghorn added a comment to D10974: Add option to ignore print margins for non-PDF generators.

@aacid , @ngraham : Any chance we can reach a concensus here?
I personally don't have a strong opinion on what the best term to use in the dialog is and could live with all suggestions made so far.
Looking at the Firefox screenshot, the option "Ignore print margins and scale to full page" came to my mind in addition (which is quite long, but might be clear on what is happening?).

Jun 7 2018, 5:02 PM · Okular

May 25 2018

michaelweghorn added a comment to D10974: Add option to ignore print margins for non-PDF generators.

I'm not really sure by myself yet, but does it help to say "print area" instead of "printable area" (i.e. "Fit to print area") to take into account that the margins being used are not necessarily the hardware margins of the printer (which define the "printable area")? Would it be clear for users what this refers to?

May 25 2018, 8:27 PM · Okular
michaelweghorn added a comment to D10974: Add option to ignore print margins for non-PDF generators.

[...]
Another option is to use a radio button:

Scaling: (o) None
         ( ) Auto-fit within printable area

[...]

May 25 2018, 8:20 PM · Okular

May 24 2018

michaelweghorn added a comment to D10974: Add option to ignore print margins for non-PDF generators.

@aacid: What's the right way to properly indicate that an important part of this
was actually done by you (add you in the copyright, mention in the commit message,...)?

Just add a line to the commit message and it's fine for me

May 24 2018, 7:05 PM · Okular
michaelweghorn added a comment to D10974: Add option to ignore print margins for non-PDF generators.

From a user perspective, I'm not sure I would know what "Ignore printer margins" means. What's a printer margin? If I turn this on or off, what will happen? It's not very clear at the moment, IMHO.

May 24 2018, 7:04 PM · Okular
michaelweghorn added a comment to D10974: Add option to ignore print margins for non-PDF generators.

[....]
(Side note: I missed this at first, since values for the margins in the Qt print
dialog currently don't seem to be initialized with the PPD default values.)

May 24 2018, 5:04 PM · Okular
michaelweghorn updated the diff for D10974: Add option to ignore print margins for non-PDF generators.

Changes to previous version:

May 24 2018, 2:49 PM · Okular

May 18 2018

michaelweghorn added a comment to D10974: Add option to ignore print margins for non-PDF generators.

[...]
The feature it's not really "Fit to printable area", it's more "Take Margins into account" or if we negate it "Ignore printer margins", because "printable area" is the area of the page where the printer can print, but what we're doing here is ignore the printer margins, that default to the printable area but the user can change at will.

What do you think?

May 18 2018, 11:03 PM · Okular

Apr 19 2018

michaelweghorn removed a watcher for Okular: michaelweghorn.
Apr 19 2018, 6:45 AM

Mar 9 2018

michaelweghorn updated the test plan for D10974: Add option to ignore print margins for non-PDF generators.
Mar 9 2018, 3:49 PM · Okular
michaelweghorn updated the diff for D10974: Add option to ignore print margins for non-PDF generators.

(Don't) Set margins based on QPrinter::fullPage()

Mar 9 2018, 3:46 PM · Okular

Mar 4 2018

michaelweghorn added a comment to D10974: Add option to ignore print margins for non-PDF generators.

so you worded point 4 and point 6 (second point 5) differently "the document is not scaled at all now." vs "The document is scaled to the full page size", i would not expect Force Rasterize to cause different behaviour.

Is it just that you wrote it differently or does Force Rasterize actually change the behaviour of "Fit to printable area"?

Mar 4 2018, 7:49 AM · Okular

Mar 2 2018

michaelweghorn added a comment to D10974: Add option to ignore print margins for non-PDF generators.

Once https://phabricator.kde.org/D7962 should make it to Okular, it might make sense to reconsider using the combobox for the scaling options that this adds for the PDF generator case (or how to properly merge the two approaches for the QPrinter and the lpr approaches).

Mar 2 2018, 5:00 PM · Okular
michaelweghorn added a comment to D10974: Add option to ignore print margins for non-PDF generators.

In general, this option is not only relevant for the PDF generator, but (as Albert mentioned on the bug report) for all generators that use FilePrinter.
This change currently only addresses the PDF case.

Mar 2 2018, 4:56 PM · Okular
michaelweghorn requested review of D10974: Add option to ignore print margins for non-PDF generators.
Mar 2 2018, 4:47 PM · Okular

Jan 21 2018

michaelweghorn added a comment to D10007: Fix Build with Purpose.

As mentioned in https://bugs.kde.org/show_bug.cgi?id=389224#c2 , there is the following new commit for Purpose that should fix the build when the "old" name is used for the dependency: https://cgit.kde.org/purpose.git/commit/?id=20a304236100b29014403a894cbda2d93ab28e41

Jan 21 2018, 11:30 PM · Okular

Dec 16 2017

michaelweghorn added a comment to D9328: Add support for cancellable image rendering and text extraction.
In D9328#179915, @aacid wrote:

@michaelweghorn can you give it a try with the new version of the patch? This should make it better.

Dec 16 2017, 9:44 AM · Okular

Dec 15 2017

michaelweghorn added a comment to D9328: Add support for cancellable image rendering and text extraction.

I tested this a bit and find it really nice that rendering of the actual page (rather than the thumbnail) usually starts at once when re-rendering is needed (e.g. when zoom level is changed).
Also, closing Okular now works fast, even if rendering is still in progress. (The shell prompt is shown almost immediately after closing Okular when it was started from the command line.)

Dec 15 2017, 2:26 PM · Okular
michaelweghorn added a comment to D9341: Port kprinter4 to Qt 5/KDE 5.

The 2 suggested improvements are now implemented.

Dec 15 2017, 8:58 AM
michaelweghorn updated the diff for D9341: Port kprinter4 to Qt 5/KDE 5.

Rename to "kprinter5", update includes

Dec 15 2017, 8:51 AM
michaelweghorn created D9341: Port kprinter4 to Qt 5/KDE 5.
Dec 15 2017, 6:48 AM

Dec 14 2017

michaelweghorn created D9336: Change default mouse mode to TextSelect.
Dec 14 2017, 6:10 PM · Okular

Dec 6 2017

michaelweghorn added a watcher for Okular: michaelweghorn.
Dec 6 2017, 1:28 PM
michaelweghorn added a comment to T4151: Finish and merge the dont-use-docdata-for-annots-and-forms branch.
In T4151#116690, @aacid wrote:
Dec 6 2017, 1:27 PM · Okular

Nov 13 2017

michaelweghorn added a comment to D8642: Rework saving of annotations and form data.
In D8642#167020, @aacid wrote:

Open pdf file, add anotation, close app
You get dialog about losing changes, check that save, discard, cancel all do what they say

This works as described. One additional thought on that:
Some users may want to save the modified version to a new file instead of overwriting the existing one. While this is already possible via "File" -> "Save As" (or Ctrl+Shift+S), I think it might be helpful to add an additional button "Save as" in that dialog as well. This would also help avoid users accidently overwriting the original file. (Evince, for example only offers a "Save As" option and users switching between the two programs might not be aware of the difference at once.)

I disagree, does libreoffice suggest "Save As" when you do open an existing file, do some changes and close the app? Do you know of any program that does offer "Save As" in that situation?

Nov 13 2017, 9:25 AM · Okular

Nov 8 2017

michaelweghorn added a comment to D8642: Rework saving of annotations and form data.

Open pdf file, add anotation, close app
You get dialog about losing changes, check that save, discard, cancel all do what they say

Nov 8 2017, 7:57 AM · Okular

Oct 17 2017

michaelweghorn added a comment to D7949: Allow to print pdf doc directly into a QPrinter.

Background: [...] and we plan to have some features implemented in the print dialog (for Qt/Okular).

Can I learn more about this somewhere?

Oct 17 2017, 4:39 PM · Okular

Oct 12 2017

michaelweghorn added a comment to D7949: Allow to print pdf doc directly into a QPrinter.
large filesize (5x), because of letters being vectors instead of fonts

Yeah, I know about this one. There's nothing really do be done about this on the Okular side, this is Qt's doing.
On the other hand one could argue that this is what "printing to a file" actually means: you lose all semantic
information like letters, annotations, tags, etc.

Oct 12 2017, 5:34 PM · Okular