Change default mouse mode to TextSelect
AbandonedPublic

Authored by michaelweghorn on Dec 14 2017, 6:10 PM.

Details

Reviewers
None
Group Reviewers
Okular
Summary

Since commit 6d7403ff13871b068a121cd0afbb1ee1157ff375,
clicking hyperlink is also possible in text selection mode.

Thus, TextSelect now combines the advantages of
being able to select text and navigating.

Test Plan
  • Delete existing Okular configuration (since user-specific mode may be saved there from last usage): rm -f ~/.config/okular*
  • open a PDF document containing a hyperlink
  • verify that the text selection mode is activated and both, clicking hyperlinks and selecting text works

Diff Detail

Repository
R223 Okular
Branch
michaelweghorn/textModeAsDefault
Lint
No Linters Available
Unit
No Unit Test Coverage
michaelweghorn created this revision.Dec 14 2017, 6:10 PM
Restricted Application added a project: Okular. · View Herald TranscriptDec 14 2017, 6:10 PM
michaelweghorn requested review of this revision.Dec 14 2017, 6:10 PM

Doesn't this make Okular much less touch-friendly by default?

Restricted Application added a subscriber: okular-devel. · View Herald TranscriptSep 20 2018, 8:32 PM

Doesn't this make Okular much less touch-friendly by default?

Possibly. I did not have this in mind when creating this revision. How can I test this without a touch screen? Is using just the left mouse button on a "normal" computer a proper way to simulate this?

sander added a subscriber: sander.Sep 21 2018, 9:02 AM

Doesn't this make Okular much less touch-friendly by default?

Yes it does. For example, pinch-to-zoom and pinch-to-rotate is not really usable in text-selection mode.

Given that choosing a tool is persistent across closing and opening Okular, I'd suggest to not apply this patch. People that want text selection as their default only have to switch to it once.

Doesn't this make Okular much less touch-friendly by default?

Possibly. I did not have this in mind when creating this revision. How can I test this without a touch screen? Is using just the left mouse button on a "normal" computer a proper way to simulate this?

Right.

michaelweghorn abandoned this revision.Sep 21 2018, 9:51 PM

Thanks for your helpful feedback. Given the last comments, I agree that having text selection mode is probably not particularly useful for touch displays. I'm thus abandoning this change.

Thanks anyway Michael!