- Queries
- All Stories
- Search
- Advanced Search
All Stories
Jan 20 2020
Wow, such a huge UI improvement.
It seemed to
bump?
Address some review comments (more to come in a bit)
setRecursiveFilteringEnabled() method provided for backward compatibility should be empty
Clearly 2 separate changes and too long line on the commit message. Please split when landing.
Thanks!
Reverb and chorus would remain active and you would leak memory. For details, see the link I mentioned above.
LGTM
Only use QRegularExpression::CaseInsensitiveOption where needed
How about this?
Add copyright mention, add icon for added terminal emulator
FTR, there's no way the quickseledctdialogtest could have passed locally; so it looks like I messed/mixed things up with the other diff (KRecursive* port), I must have ran ctest without remember to run make in the build dir when I switched branches, stooopid. Sorry about the trouble.
Avoid indentation level