Differential D26564

Clean kbuildsycoca4 support
Needs ReviewPublic
Actions

Authored by meven on Jan 10 2020, 4:50 PM.

Details

Reviewers
ervin
hein
Group Reviewers
Frameworks

Diff Detail

Repository
R241 KIO
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20901
Build 20919: arc lint + arc unit
meven created this revision.Jan 10 2020, 4:50 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 10 2020, 4:50 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
meven requested review of this revision.Jan 10 2020, 4:50 PM
dfaure added a reviewer: hein.Jan 12 2020, 10:56 AM
dfaure added a subscriber: dfaure.

Code added by Eike Hein in commit ee5303a337876914, let's get his input.

ervin added a comment.Jan 20 2020, 12:55 PM

I'm wondering if that's the right point in time for this. Wouldn't it be better once we branched KF6? There are still people transitioning from 4 to 5 out there I guess. I admit I'm unsure, they had a long time to transition already.

meven added a comment.Jan 20 2020, 6:29 PM

It seemed to

In D26564#597474, @ervin wrote:

I'm wondering if that's the right point in time for this. Wouldn't it be better once we branched KF6? There are still people transitioning from 4 to 5 out there I guess. I admit I'm unsure, they had a long time to transition already.

4 years and a half years felt as sufficient to me.
I wouldn't mind adding this to the Waiting on KF6 Branching

hein added a comment.Jan 24 2020, 8:59 PM

Let's wait until branching, there's still some KDE 4 apps people use.

Revision Contents
Changeset List

Diff 73210

View Options

src/widgets/kbuildsycocaprogressdialog.cpp

Loading...