SGOrava (Juraj Oravec)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Feb 13 2018, 5:14 PM (110 w, 5 d)
Availability
Available

Recent Activity

Sun, Mar 22

SGOrava added a comment to D28198: QFile is open but not closed.

According to documentation it should be closed by Qt.
https://doc.qt.io/qt-5/qfile.html#dtor.QFile

Sun, Mar 22, 11:30 AM · Falkon

Tue, Mar 3

SGOrava requested changes to D27791: BUG: 408312.
Tue, Mar 3, 5:43 PM · Falkon
SGOrava added a comment to D27791: BUG: 408312.

Thank you for your contribution.

Tue, Mar 3, 4:52 PM · Falkon

Feb 16 2020

SGOrava updated the diff for D27431: Bind mouse Back&Forward buttons to Undo&Redo action.
  • Use eventFilter for Back&Forward mouse buttons
Feb 16 2020, 12:21 PM
SGOrava requested review of D27431: Bind mouse Back&Forward buttons to Undo&Redo action.
Feb 16 2020, 11:02 AM

Feb 15 2020

SGOrava committed R875:e4b468e233db: Prompt user when KWallet is disabled (authored by puneethchanda).
Prompt user when KWallet is disabled
Feb 15 2020, 3:19 PM
SGOrava closed D26932: Prompt user when KWallet is disabled.
Feb 15 2020, 3:19 PM · Falkon
SGOrava committed R875:0e25b116cb7d: SearchBar - Show number of matches found on page search (authored by SGOrava).
SearchBar - Show number of matches found on page search
Feb 15 2020, 2:32 PM
SGOrava closed D27095: SearchBar - Show number of matches found on page search.
Feb 15 2020, 2:32 PM · Falkon
SGOrava updated the diff for D27095: SearchBar - Show number of matches found on page search.
  • Revert "searchToolbar: Add placeholder for resultInfo in the ui file"
Feb 15 2020, 2:26 PM · Falkon

Feb 9 2020

SGOrava added inline comments to D27095: SearchBar - Show number of matches found on page search.
Feb 9 2020, 2:14 PM · Falkon

Feb 7 2020

SGOrava updated the diff for D27095: SearchBar - Show number of matches found on page search.
  • searchToolbar: Add placeholder for resultInfo in the ui file
  • Fix code style and remove unneeded code as requested
Feb 7 2020, 5:48 PM · Falkon
SGOrava accepted D26932: Prompt user when KWallet is disabled.

OK

Feb 7 2020, 5:17 PM · Falkon

Feb 3 2020

SGOrava added inline comments to D27095: SearchBar - Show number of matches found on page search.
Feb 3 2020, 3:20 PM · Falkon

Feb 2 2020

SGOrava added inline comments to D27095: SearchBar - Show number of matches found on page search.
Feb 2 2020, 5:19 PM · Falkon
SGOrava committed R875:9eaffd1208f7: Autotests Qml - fix compilation with Qt 5.9 (authored by SGOrava).
Autotests Qml - fix compilation with Qt 5.9
Feb 2 2020, 5:18 PM
SGOrava closed D27102: Autotests Qml - fix compilation with Qt 5.9.
Feb 2 2020, 5:18 PM · Falkon
SGOrava requested review of D27102: Autotests Qml - fix compilation with Qt 5.9.
Feb 2 2020, 4:02 PM · Falkon

Feb 1 2020

SGOrava requested review of D27095: SearchBar - Show number of matches found on page search.
Feb 1 2020, 10:11 PM · Falkon
SGOrava committed R875:4b7a38680b78: Speeddial: decode initialScript data as Utf8 (authored by SGOrava).
Speeddial: decode initialScript data as Utf8
Feb 1 2020, 9:37 AM
SGOrava closed D27081: Speeddial: decode initialScript data as Utf8.
Feb 1 2020, 9:37 AM · Falkon
SGOrava updated the summary of D27081: Speeddial: decode initialScript data as Utf8.
Feb 1 2020, 1:41 AM · Falkon
SGOrava requested review of D27081: Speeddial: decode initialScript data as Utf8.
Feb 1 2020, 1:38 AM · Falkon

Jan 28 2020

SGOrava added a comment to D26932: Prompt user when KWallet is disabled.

That is what you think from user perspective.
But if there is ever any bug which triggers those functions without a break a 1000 times, users will be mad.

Jan 28 2020, 2:01 PM · Falkon

Jan 27 2020

SGOrava added a comment to D26932: Prompt user when KWallet is disabled.

+ as drisca suggested, it would be great to add some stopper for notifications to show only once.
You may see it as "it will show only when there is a problem", well trust him with this, there will be some users who will be spammed with notifications.
I apologize I did not thought about this.

Jan 27 2020, 6:26 PM · Falkon
SGOrava requested changes to D26932: Prompt user when KWallet is disabled.

Can you return original blank lines ?
The spacing between lines is there to make it easier to read.

Jan 27 2020, 6:07 PM · Falkon
SGOrava added a comment to D26932: Prompt user when KWallet is disabled.

I am not that sure about it, you see I am more of a programmer than a designer,
iirc the messagebox will block Falkon until you press it so it is a bit annoying.
Maybe using falkon notifications sounds better.

Jan 27 2020, 5:38 PM · Falkon
SGOrava added inline comments to D26932: Prompt user when KWallet is disabled.
Jan 27 2020, 4:20 PM · Falkon
SGOrava added a comment to D26932: Prompt user when KWallet is disabled.

I am against this patch.
In my eyes I expect it to just work and to not bother me.
I would welcome notification when it for some reason failed, because that would have some value for users.

Jan 27 2020, 9:01 AM · Falkon

Jan 24 2020

SGOrava committed R875:1cecd14fd069: Fix crash when KWallet is not available. (authored by puneethchanda).
Fix crash when KWallet is not available.
Jan 24 2020, 1:15 PM
SGOrava closed D26872: Fix crash when KWallet is not available..
Jan 24 2020, 1:15 PM · Falkon
SGOrava accepted D26872: Fix crash when KWallet is not available..
Jan 24 2020, 1:09 PM · Falkon

Jan 23 2020

SGOrava added a comment to D26872: Fix crash when KWallet is not available..

That's not true. If initialize fails then it doesn't make any sense to keep using the wallet as it is in "inconsistent" state.

Jan 23 2020, 5:12 PM · Falkon
SGOrava added a comment to D26872: Fix crash when KWallet is not available..

In such case it should be totally rethought since the false can be triggered also by not having write permissions.
So i think we should in such case introduce new internal variable to check if we can write into Falkon folder.
Also at first run, we should probably always return true for migration thing, but need to make sure we are in Falkon folder.

Jan 23 2020, 5:04 PM · Falkon
SGOrava added a comment to D26872: Fix crash when KWallet is not available..

Looks fine to me.

Jan 23 2020, 4:23 PM · Falkon
SGOrava added a comment to D26872: Fix crash when KWallet is not available..

@drosca Even in destructor ?

Jan 23 2020, 3:41 PM · Falkon
SGOrava added a comment to D26872: Fix crash when KWallet is not available..

To be more precise I think the condition should be in these methids

  • addEntry
  • updateEntry
  • updateLastUsed
  • removeEntry
  • removeAll
Jan 23 2020, 3:38 PM · Falkon
SGOrava added a comment to D26872: Fix crash when KWallet is not available..

Than you can add the condition into all methods.

Jan 23 2020, 3:35 PM · Falkon
SGOrava added inline comments to D26872: Fix crash when KWallet is not available..
Jan 23 2020, 3:23 PM · Falkon
SGOrava added inline comments to D26872: Fix crash when KWallet is not available..
Jan 23 2020, 3:12 PM · Falkon

Jan 22 2020

SGOrava closed D23964: [KTextEditor] Port away from other deprecated methods in Qt 5.14.
Jan 22 2020, 9:45 PM
SGOrava reopened D23964: [KTextEditor] Port away from other deprecated methods in Qt 5.14.
Jan 22 2020, 9:34 PM
SGOrava added inline comments to D23964: [KTextEditor] Port away from other deprecated methods in Qt 5.14.
Jan 22 2020, 9:33 PM
SGOrava abandoned D26793: Exclude the KSharedConfig::openStateConfig from the sip parser.

Done in https://phabricator.kde.org/D26815

Jan 22 2020, 7:00 PM · Frameworks

Jan 21 2020

SGOrava committed R875:90664879c511: Option for internal PDFium-based viewer on Qt 5.13+ (authored by alukichev).
Option for internal PDFium-based viewer on Qt 5.13+
Jan 21 2020, 8:00 PM
SGOrava closed D26753: Option for internal PDFium-based viewer on Qt 5.13+.
Jan 21 2020, 8:00 PM · Falkon
SGOrava added a comment to D26753: Option for internal PDFium-based viewer on Qt 5.13+.

I would need your name and email which I can use to commit it for you.
(I can guess, but I want to be sure)
Thank you.

Jan 21 2020, 7:48 PM · Falkon
SGOrava added a comment to D26753: Option for internal PDFium-based viewer on Qt 5.13+.

Do you have commit / push rights ?

Jan 21 2020, 7:37 PM · Falkon
SGOrava accepted D26753: Option for internal PDFium-based viewer on Qt 5.13+.

Thank you for the fix.
Now it looks and works fine.

Jan 21 2020, 7:37 PM · Falkon
SGOrava added a comment to D26753: Option for internal PDFium-based viewer on Qt 5.13+.

OK, works almost fine, only the checkbox disabled state is not triggered at the first launch of preferences dialog.

Jan 21 2020, 7:11 PM · Falkon
SGOrava added a comment to D26753: Option for internal PDFium-based viewer on Qt 5.13+.

How about "(requires Pepper)" in the checkbox caption or a "This requires the option \"Allow Pepper Plugins (Flash)\" to be enabled" tooltip?

Jan 21 2020, 6:26 PM · Falkon
SGOrava added a comment to D26753: Option for internal PDFium-based viewer on Qt 5.13+.

I know that.
I still believe we need to do something to make it more obvious or we would just push this work for later date.

Jan 21 2020, 6:14 PM · Falkon

Jan 20 2020

SGOrava added a comment to D26753: Option for internal PDFium-based viewer on Qt 5.13+.

So I tested it and it works as intended.
What I see as a problem is that this patch does not honour the relationship between PDF viewer and Pepper plugins.
So if you disable pepper plugins PDF viewer would also be gone and users would complain.

Jan 20 2020, 7:54 PM · Falkon
SGOrava committed R875:2a0f0924362a: Handle web push notifications with Falkon notification system (authored by SGOrava).
Handle web push notifications with Falkon notification system
Jan 20 2020, 7:40 PM
SGOrava closed D26452: Handle web push notifications with Falkon notification system.
Jan 20 2020, 7:40 PM · Falkon
SGOrava added a reviewer for D26793: Exclude the KSharedConfig::openStateConfig from the sip parser: Frameworks.
Jan 20 2020, 6:20 PM · Frameworks
SGOrava added a comment to D26452: Handle web push notifications with Falkon notification system.

If there aren't any objections I will land this patch tonight.
It provides the same basic functionality as QtWebEngine default bubble.

Jan 20 2020, 2:43 PM · Falkon
SGOrava requested review of D26793: Exclude the KSharedConfig::openStateConfig from the sip parser.
Jan 20 2020, 12:53 PM · Frameworks

Jan 19 2020

SGOrava added a comment to D26755: [WIP] KMessageWidget: Set widget height on resize event.

it would, but I am not such great guru.
I tried few ways to change the behaviour but it was even worse,
and since this is used in many programs I do not want to break them.

Jan 19 2020, 2:59 PM · Frameworks
SGOrava added a comment to D26755: [WIP] KMessageWidget: Set widget height on resize event.

This is the test I used to check the validity of my change, it kind of always fails.
I only hope someone can fix this widget at least for KF6.

Jan 19 2020, 1:01 PM · Frameworks
SGOrava updated the diff for D26755: [WIP] KMessageWidget: Set widget height on resize event.
  • KMessageWidget: Add resize autotest
Jan 19 2020, 1:00 PM · Frameworks
SGOrava added a comment to D26755: [WIP] KMessageWidget: Set widget height on resize event.

It looks good.
But I wrote a test as you suggested which still fails.
The test creates parent widget and puts the kmesagewidget and qlistwidget in it in vertical order (as in my test app)
and than it resizes the parent widget and compares the height (the available macros in *autotest.cpp)

Jan 19 2020, 12:37 PM · Frameworks
SGOrava retitled D26755: [WIP] KMessageWidget: Set widget height on resize event from KMessageWidget: Set widget height on resize event to [WIP] KMessageWidget: Set widget height on resize event.
Jan 19 2020, 11:41 AM · Frameworks
SGOrava added a comment to D26755: [WIP] KMessageWidget: Set widget height on resize event.

No, my tests say no.
This does not update sizeHint which can cause some issue later.
It sure looks nice in my test app but it is wrong in the core.
This is not the right solution.

Jan 19 2020, 11:36 AM · Frameworks
SGOrava added a comment to D26755: [WIP] KMessageWidget: Set widget height on resize event.

OK, I will try to write a test for it.
This change looks like it lacks some things to make it work properly in some cases.
I am not sure if I am the right person to fiddle with this code (but it is broken...)

Jan 19 2020, 9:13 AM · Frameworks
SGOrava added a comment to D26753: Option for internal PDFium-based viewer on Qt 5.13+.

So it is even more complicated with this PDF viewer than I thought.
Thank you for making the option.

Jan 19 2020, 9:09 AM · Falkon
SGOrava added a comment to D26753: Option for internal PDFium-based viewer on Qt 5.13+.

It should be optional, many people would like to have internal PDF viewer.

Jan 19 2020, 8:19 AM · Falkon

Jan 18 2020

SGOrava updated the summary of D26755: [WIP] KMessageWidget: Set widget height on resize event.
Jan 18 2020, 8:59 PM · Frameworks
SGOrava requested review of D26755: [WIP] KMessageWidget: Set widget height on resize event.
Jan 18 2020, 8:52 PM · Frameworks
SGOrava added a comment to D26753: Option for internal PDFium-based viewer on Qt 5.13+.

It can be disabled, it is done as "plugin" in a similar way as flash player.
It can be disabled by unchecking simple checkbox at:
(Preferences > Browsing > [ ] Allow Pepper Pluginf (Flash player)).

Jan 18 2020, 6:52 PM · Falkon

Jan 6 2020

SGOrava committed R875:903c29cb097b: GreaseMonkey: Use QTWEBENGINEWIDGETS_VERSION to check for the current version (authored by SGOrava).
GreaseMonkey: Use QTWEBENGINEWIDGETS_VERSION to check for the current version
Jan 6 2020, 10:46 AM
SGOrava requested review of D26452: Handle web push notifications with Falkon notification system.
Jan 6 2020, 9:33 AM · Falkon

Jan 5 2020

SGOrava committed R875:6974f8c25446: GreaseMonkey: Fix detecting *.user.js urls (authored by SGOrava).
GreaseMonkey: Fix detecting *.user.js urls
Jan 5 2020, 6:40 PM
SGOrava closed D26436: GreaseMonkey: Fix detecting *.user.js urls.
Jan 5 2020, 6:40 PM · Falkon
SGOrava updated the diff for D26436: GreaseMonkey: Fix detecting *.user.js urls.
  • GreaseMonkey: Fix navigation type check for lower qt version than 5.14
Jan 5 2020, 4:49 PM · Falkon
SGOrava added a comment to D26436: GreaseMonkey: Fix detecting *.user.js urls.

Wait a bit, this works only for Qt 5.14.

Jan 5 2020, 4:41 PM · Falkon
SGOrava requested review of D26436: GreaseMonkey: Fix detecting *.user.js urls.
Jan 5 2020, 3:44 PM · Falkon

Jan 1 2020

SGOrava committed R875:c934e40440ea: Use QString::chopped() only for Qt 5.10+ (authored by SGOrava).
Use QString::chopped() only for Qt 5.10+
Jan 1 2020, 11:12 AM

Dec 31 2019

SGOrava committed R875:d45e51a4e5d6: Port from deprecated QDir::operator=(const QString&) > QDir::setPath() (authored by SGOrava).
Port from deprecated QDir::operator=(const QString&) > QDir::setPath()
Dec 31 2019, 6:42 PM
SGOrava committed R875:14719b3ec30c: Port from deprecated QPalette::background() > QPalette::window() (authored by SGOrava).
Port from deprecated QPalette::background() > QPalette::window()
Dec 31 2019, 5:54 PM
SGOrava committed R875:03b2880f8b1f: Port from deprecated QPalette::foreground() > QPalette::windowText() (authored by SGOrava).
Port from deprecated QPalette::foreground() > QPalette::windowText()
Dec 31 2019, 5:37 PM
SGOrava committed R875:de200c77c43d: Port from deprecated QFontMetrics::width() > QFontMetrics::horizontalAdvance() (authored by SGOrava).
Port from deprecated QFontMetrics::width() > QFontMetrics::horizontalAdvance()
Dec 31 2019, 2:42 PM
SGOrava committed R875:168f61c60206: Port from deprecated QListWidget::setItemHidden() > QListWidgetItem::setHidden() (authored by SGOrava).
Port from deprecated QListWidget::setItemHidden() > QListWidgetItem::setHidden()
Dec 31 2019, 11:17 AM
SGOrava committed R875:6c56304aed4d: Port from deprecated QLineEdit::getTextMargins() > QLineEdit::textMargins() (authored by SGOrava).
Port from deprecated QLineEdit::getTextMargins() > QLineEdit::textMargins()
Dec 31 2019, 11:05 AM
SGOrava committed R875:cf6a0b46efb5: Port from QListWidget::setItemSelected > QListWidgetItem::setSelected (authored by SGOrava).
Port from QListWidget::setItemSelected > QListWidgetItem::setSelected
Dec 31 2019, 10:37 AM
SGOrava committed R875:7a1558e17336: Port from deprecated QTreeView::sortByColumn(int) (authored by SGOrava).
Port from deprecated QTreeView::sortByColumn(int)
Dec 31 2019, 9:52 AM
SGOrava committed R875:b82752a31e2c: Port from deprecated QTableView::sortByColumn(int) (authored by SGOrava).
Port from deprecated QTableView::sortByColumn(int)
Dec 31 2019, 9:52 AM

Dec 30 2019

SGOrava committed R875:018b8d1a2840: adblock: port foreach -> range-based for (authored by SGOrava).
adblock: port foreach -> range-based for
Dec 30 2019, 8:46 PM
SGOrava committed R875:e34933b5d7f3: app: port foreach -> range-based for (authored by SGOrava).
app: port foreach -> range-based for
Dec 30 2019, 8:29 PM
SGOrava committed R875:ef48b4725eb8: tools: port foreach -> range-based for (authored by SGOrava).
tools: port foreach -> range-based for
Dec 30 2019, 8:21 PM
SGOrava committed R875:7f654409c550: webengine: port foreach -> range-based for (authored by SGOrava).
webengine: port foreach -> range-based for
Dec 30 2019, 8:07 PM
SGOrava committed R875:9b6f187282ce: network: port foreach -> range-based for (authored by SGOrava).
network: port foreach -> range-based for
Dec 30 2019, 7:59 PM
SGOrava committed R875:991e0b952ea6: navigation: port foreach -> range-based for (authored by SGOrava).
navigation: port foreach -> range-based for
Dec 30 2019, 7:51 PM
SGOrava committed R875:aa039b8579d5: session: port foreach -> range-based for (authored by SGOrava).
session: port foreach -> range-based for
Dec 30 2019, 7:41 PM
SGOrava committed R875:da73eb5c7707: sidebar: port foreach -> range-based for (authored by SGOrava).
sidebar: port foreach -> range-based for
Dec 30 2019, 7:36 PM
SGOrava committed R875:1a3f88714532: tabwidget: port foreach -> range-based for (authored by SGOrava).
tabwidget: port foreach -> range-based for
Dec 30 2019, 7:31 PM
SGOrava committed R875:f02cb62b7b3c: plugins: port foreach -> range-based for (authored by SGOrava).
plugins: port foreach -> range-based for
Dec 30 2019, 7:25 PM
SGOrava committed R875:5efc0e8d9d3e: opensearch: port foreach -> range-based for (authored by SGOrava).
opensearch: port foreach -> range-based for
Dec 30 2019, 7:15 PM
SGOrava committed R875:c4b6ae90198a: bookmarks: port foreach -> range-based for (authored by SGOrava).
bookmarks: port foreach -> range-based for
Dec 30 2019, 6:51 PM
SGOrava committed R875:40c06eaaaed7: autofill: port foreach -> range-based for (authored by SGOrava).
autofill: port foreach -> range-based for
Dec 30 2019, 6:51 PM