Center only during drawing, not the hit rects
ClosedPublic

Authored by mart on Mon, Jan 20, 10:53 AM.

Details

Summary

center only the drawing of the components but never modify the
subcontrolrects (and hit targets)

BUG: 416348
FIXED-IN: 5.18.0

Test Plan

now the handle activates immediately without one single pixel
margin

Diff Detail

Repository
R31 Breeze
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Mon, Jan 20, 10:53 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMon, Jan 20, 10:53 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart requested review of this revision.Mon, Jan 20, 10:53 AM
mart retitled this revision from center only when to draw, not the hit rects to Center only during drawing, not the hit rects.
ngraham edited the summary of this revision. (Show Details)Mon, Jan 20, 3:49 PM
ngraham added a subscriber: ngraham.

Works for me. Probably 5.18 material.

ndavis accepted this revision.Mon, Jan 20, 4:30 PM

LGTM

This revision is now accepted and ready to land.Mon, Jan 20, 4:30 PM
This revision was automatically updated to reflect the committed changes.
mart added a comment.Tue, Jan 21, 8:57 AM

In master and 5.18

Thanks for the fix.
On a different topics, I have found a couple more places where the separators look weird. See:


or

In the second screenshot it is barely visible, but that makes it look even more like a bug.
In my opinion we should revisit the heuristics for showing this separators, limiting it to actual sunken, non-transparent scroll areas, as opposed to standalone scrollbars.
opinions ? (about the two screenshots above ? About the solution ?)

Thanks for the fix.
On a different topics, I have found a couple more places where the separators look weird. See:


or

In the second screenshot it is barely visible, but that makes it look even more like a bug.
In my opinion we should revisit the heuristics for showing this separators, limiting it to actual sunken, non-transparent scroll areas, as opposed to standalone scrollbars.
opinions ? (about the two screenshots above ? About the solution ?)

That seems like a good idea.

There's some weirdness in System Settings too. However all of this just exposes when we have a scrollable view that should be reformatted to show everything without needing to be scrollable (e.g. Okular's settings window; see https://bugs.kde.org/show_bug.cgi?id=397678), or when the scrollable part of a view should be touching the edges of its invisible frame but isn't. We should fix those.