[App Style KCM] Use QtQuick NewStuff dialogs
ClosedPublic

Authored by gikari on Jan 16 2020, 8:45 PM.

Details

Summary

Make the dialogs consistent with others KCMs by using QtQuick versions.

Test Plan

Test dialogs for GTK themes installation.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
gikari created this revision.Jan 16 2020, 8:45 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 16 2020, 8:45 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gikari requested review of this revision.Jan 16 2020, 8:45 PM

Even better would be if we can use the new QML dialogs too. See D26544

Even better would be if we can use the new QML dialogs too. See D26544

Does this count as a new feature, i.e is this QML change will be in 5.18?

No I see it as a consistency/polish/bugfix thing. The rest of the KCMs got ported to use the new dialog for Plasma 5.18; it would be a bit weird if this one didn't get the same treatment.

gikari planned changes to this revision.Jan 16 2020, 8:55 PM

Ok, then.

gikari updated this revision to Diff 73755.Jan 17 2020, 11:18 AM

Port dialogs to QtQuick

gikari retitled this revision from [App Style KCM] Port GTK GHNS dialogs from exec() to [App Style KCM] Use QtQuick NewStuff dialogs.Jan 17 2020, 11:19 AM
gikari edited the summary of this revision. (Show Details)
ngraham accepted this revision.Jan 17 2020, 1:27 PM

Looks good, and this should go on the plasma/5.18 branch to make sure it gets into Plasma 5.18 so this KCM isn't the odd one out.

However it contains new and changed strings so I have requested a string freeze exception to make this possible. I'll let you know if and when it's accepted so this patch can land. Until then, please do not land it.

Thanks again!

This revision is now accepted and ready to land.Jan 17 2020, 1:27 PM

No objections to breaking string freeze from the Ukrainian team.

No objection from Catalan translation team.

No objections so far. Sounds like you can land this on the 5.18 branch.

This revision was automatically updated to reflect the committed changes.