Query: Advanced Search

	Include stories about projects I am a member of.

In D7581#433294, @ngraham wrote:

At this point, the patch will need to be rebased since a lot has happened since August of 2017 (!). Either @hetzenecker will need to return and finish the work, or another interested party will need to take it over.

Anything left for this to be merged? Sure would be nice to have for 19.04.

Optionalise clang-tidy

Try to fix build with MARBLE_NO_WEBKITWIDGETS

Avoid overwriting Qt5_FOUND with Qt5DBus or Qt5WebEngine disabled

drop unrelated commit

Fix unnecessary cmake warnings (Qt5_FOUND to FALSE), use QT_REQUIRED_VERSION

Add missing QStandardPaths to fix build

This occurred after switching to ninja by default, maybe related. But I hadn't built amarok before that in a while.

-c /var/tmp/portage/media-sound/amarok-9999/work/amarok-9999/src/main.cpp
/var/tmp/portage/media-sound/amarok-9999/work/amarok-9999/src/main.cpp:101:162: warning: macro "__DATE__" might prevent reproducible builds [-Wdate-time]
                           ki18n( "IRC:\nirc.freenode.net - #amarok, #amarok.de, #amarok.es, #amarok.fr\n\nFeedback:\namarok@kde.org\n\n(Build Date: %1)" ).subs( __DATE__ ).toString(),
                                                                                                                                                                  ^~~~~~~~
/var/tmp/portage/media-sound/amarok-9999/work/amarok-9999/src/main.cpp: In function ‘int main(int, char**)’:
/var/tmp/portage/media-sound/amarok-9999/work/amarok-9999/src/main.cpp:74:40: error: ‘QStandardPaths’ has not been declared
         const QString targetBasePath = QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation) + QStringLiteral("/amarok/");
                                        ^~~~~~~~~~~~~~
/var/tmp/portage/media-sound/amarok-9999/work/amarok-9999/src/main.cpp:74:73: error: ‘QStandardPaths’ has not been declared
         const QString targetBasePath = QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation) + QStringLiteral("/amarok/");
                                                                         ^~~~~~~~~~~~~~
/var/tmp/portage/media-sound/amarok-9999/work/amarok-9999/src/main.cpp:361:82: note: #pragma message: PORT KF5: This *if* should be moved to activateRequested() slot
 #pragma message("PORT KF5: This *if* should be moved to activateRequested() slot")
                                                                                  ^

Qt5OpenGL is only required with optional AvogadroLibs support

In D18312#396212, @aacid wrote:

tools/moleculeview.cpp seems to use some QGL stuff

Also there's a Qt5::OpenGL in src/ so it means it should also search for it, no?

For the record, I would have been in support of this. ;)

Switch to tidy-html5 and use tidybuffio.h instead of buffio.h

The header was renamed in 2015 which ended up in a release 5.0.0 in September - I think that's long enough. ;)

Drop unused dependencies

Re-add accidentally removed test for QCA, KF5Wallet is optional

Yes, this is necessary to successfully build on Gentoo as well.

In D17903#386231, @danders wrote:

Could yo remove lines 178-181 too?

Fix build with QCA disabled

Fix building against exiv2-0.27

Abandoned in favor of better D17872

In D17872#383971, @bruns wrote:

See D17873

Still failed to build with the following error, which is why I had to enable exceptions in my patch to make it work:

Drop obsolete includes and macro

Fix building against exiv2-0.27

Drop another excess line change

Also, maybe now it is time to raise minimum exiv2 to (at least) 0.25? This was reverted in 6c196e4 three years ago.

Invert conditionals to reduce diff.

Simplify version check to keep cmake at 3.0.0

PS: Backportable to 4.1 branch replacing a single hunk:

diff --git a/libs/ui/kisexiv2/kis_exiv2.h b/libs/ui/kisexiv2/kis_exiv2.h
index 9343265f1e..6b66aa7852 100644
--- a/libs/ui/kisexiv2/kis_exiv2.h
+++ b/libs/ui/kisexiv2/kis_exiv2.h
@@ -21,7 +21,7 @@

Upstream advises to include exiv2/exiv2.hpp over exiv2/version.hpp

Use KF5_MIN_VERSION instead of KF5_VERSION

Alternatively we could use KF5_REQUIRED_VERSION, similar to what is used for Qt.

In D12761#367223, @arojas wrote:

@asturmlechner can you post that in a new review request? I'll abandon this one.

This needs much more work unfortunately. The existing changeset also appears to be broken with oauth support, so I'm going to pull it.

krita_qimageio.desktop: Fix MimeType separators

Merge branch 'Plasma/5.14'

openconnect: add missing dependency Qt5Xml

In D16073#340107, @alexeymin wrote:

If it fixes build error .../vpn/openconnect/openconnectauth.cpp:38:10: fatal error: QDomDocument: No such file or directory then fine...

Only pull in Qt5Xml if OpenConnect is requested.

(there are also some missing deps that are implicitly linked, but that is for another review)

Make KF5Archive exclusive to BUILD_TESTING as well

In D16012#338544, @kfunk wrote:

To 5.3 branch, please.

Advanced Search
Use Results
Edit Query
Hide Query

Mar 17 2019

Mar 5 2019

Mar 4 2019

Feb 2 2019

Jan 24 2019

Jan 19 2019

Jan 18 2019

Jan 17 2019

Jan 14 2019

Jan 10 2019

Jan 9 2019

Jan 4 2019

Jan 1 2019

Dec 30 2018

Dec 29 2018

Dec 28 2018

Dec 27 2018

Dec 26 2018

Dec 25 2018

Dec 23 2018

Dec 20 2018

Dec 19 2018

Nov 28 2018

Nov 27 2018

Nov 18 2018

Nov 16 2018

Nov 14 2018

Nov 13 2018

Oct 15 2018

Oct 9 2018

Oct 8 2018

Oct 7 2018

Advanced SearchUse ResultsEdit QueryHide Query