asturmlechner (Andreas Sturmlechner)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Mar 24 2016, 9:08 PM (152 w, 10 h)
Availability
Available

Recent Activity

Sat, Feb 2

asturmlechner committed R181:f319fef25c65: Fix unnecessary cmake warnings (Qt5_FOUND to FALSE), use QT_REQUIRED_VERSION (authored by asturmlechner).
Fix unnecessary cmake warnings (Qt5_FOUND to FALSE), use QT_REQUIRED_VERSION
Sat, Feb 2, 9:19 PM
asturmlechner closed D18671: Fix unnecessary cmake warnings (Qt5_FOUND to FALSE), use QT_REQUIRED_VERSION.
Sat, Feb 2, 9:19 PM
asturmlechner updated the summary of D18671: Fix unnecessary cmake warnings (Qt5_FOUND to FALSE), use QT_REQUIRED_VERSION.
Sat, Feb 2, 9:19 PM
asturmlechner committed R181:c84422b41f6d: Add missing QStandardPaths to fix build (authored by asturmlechner).
Add missing QStandardPaths to fix build
Sat, Feb 2, 8:55 PM
asturmlechner closed D18674: Add missing QStandardPaths to fix build.
Sat, Feb 2, 8:55 PM
asturmlechner added a comment to D18674: Add missing QStandardPaths to fix build.

This occurred after switching to ninja by default, maybe related. But I hadn't built amarok before that in a while.

Sat, Feb 2, 8:51 PM
asturmlechner added a comment to D18674: Add missing QStandardPaths to fix build.
-c /var/tmp/portage/media-sound/amarok-9999/work/amarok-9999/src/main.cpp
/var/tmp/portage/media-sound/amarok-9999/work/amarok-9999/src/main.cpp:101:162: warning: macro "__DATE__" might prevent reproducible builds [-Wdate-time]
                           ki18n( "IRC:\nirc.freenode.net - #amarok, #amarok.de, #amarok.es, #amarok.fr\n\nFeedback:\namarok@kde.org\n\n(Build Date: %1)" ).subs( __DATE__ ).toString(),
                                                                                                                                                                  ^~~~~~~~
/var/tmp/portage/media-sound/amarok-9999/work/amarok-9999/src/main.cpp: In function ‘int main(int, char**)’:
/var/tmp/portage/media-sound/amarok-9999/work/amarok-9999/src/main.cpp:74:40: error: ‘QStandardPaths’ has not been declared
         const QString targetBasePath = QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation) + QStringLiteral("/amarok/");
                                        ^~~~~~~~~~~~~~
/var/tmp/portage/media-sound/amarok-9999/work/amarok-9999/src/main.cpp:74:73: error: ‘QStandardPaths’ has not been declared
         const QString targetBasePath = QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation) + QStringLiteral("/amarok/");
                                                                         ^~~~~~~~~~~~~~
/var/tmp/portage/media-sound/amarok-9999/work/amarok-9999/src/main.cpp:361:82: note: #pragma message: PORT KF5: This *if* should be moved to activateRequested() slot
 #pragma message("PORT KF5: This *if* should be moved to activateRequested() slot")
                                                                                  ^
Sat, Feb 2, 8:47 PM
asturmlechner requested review of D18674: Add missing QStandardPaths to fix build.
Sat, Feb 2, 4:17 PM
asturmlechner requested review of D18671: Fix unnecessary cmake warnings (Qt5_FOUND to FALSE), use QT_REQUIRED_VERSION.
Sat, Feb 2, 3:16 PM

Thu, Jan 24

asturmlechner committed R326:b7a4b5764d04: Qt5OpenGL is only required with optional AvogadroLibs support (authored by asturmlechner).
Qt5OpenGL is only required with optional AvogadroLibs support
Thu, Jan 24, 5:41 PM
asturmlechner closed D18312: Qt5OpenGL is only required with optional AvogadroLibs support.
Thu, Jan 24, 5:41 PM · KDE Edu
asturmlechner retitled D18312: Qt5OpenGL is only required with optional AvogadroLibs support from Qt5OpenGL is only required in optional compoundviewer to Qt5OpenGL is only required with optional AvogadroLibs support.
Thu, Jan 24, 5:35 PM · KDE Edu

Jan 19 2019

asturmlechner added a comment to D18312: Qt5OpenGL is only required with optional AvogadroLibs support.

tools/moleculeview.cpp seems to use some QGL stuff

Also there's a Qt5::OpenGL in src/ so it means it should also search for it, no?

Jan 19 2019, 10:46 AM · KDE Edu

Jan 18 2019

asturmlechner added a comment to D18361: libkworkspace: Allow standalone build.

For the record, I would have been in support of this. ;)

Jan 18 2019, 2:24 PM · Plasma

Jan 17 2019

asturmlechner requested review of D18312: Qt5OpenGL is only required with optional AvogadroLibs support.
Jan 17 2019, 10:27 AM · KDE Edu

Jan 14 2019

asturmlechner added inline comments to D14147: Port from GConf to GSettings.
Jan 14 2019, 7:34 PM · Plasma

Jan 10 2019

asturmlechner committed R226:63b6a7435646: Switch to tidy-html5 and use tidybuffio.h instead of buffio.h (authored by asturmlechner).
Switch to tidy-html5 and use tidybuffio.h instead of buffio.h
Jan 10 2019, 9:22 PM
asturmlechner closed D16982: Switch to tidy-html5 and use tidybuffio.h instead of buffio.h.
Jan 10 2019, 9:07 PM
asturmlechner added a comment to D16982: Switch to tidy-html5 and use tidybuffio.h instead of buffio.h.

The header was renamed in 2015 which ended up in a release 5.0.0 in September - I think that's long enough. ;)

Jan 10 2019, 6:24 PM
asturmlechner added a reviewer for D16982: Switch to tidy-html5 and use tidybuffio.h instead of buffio.h: kossebau.
Jan 10 2019, 5:40 PM

Jan 9 2019

asturmlechner requested review of D18143: Try to fix build with MARBLE_NO_WEBKITWIDGETS.
Jan 9 2019, 10:34 PM · KDE Edu, Marble
asturmlechner requested review of D18141: Avoid overwriting Qt5_FOUND with Qt5DBus or Qt5WebEngine disabled.
Jan 9 2019, 10:30 PM · KDE Edu, Marble

Jan 4 2019

asturmlechner committed R1026:5924e3ad82b5: Drop unused dependencies (authored by asturmlechner).
Drop unused dependencies
Jan 4 2019, 9:53 PM
asturmlechner closed D17903: Drop unused dependencies.
Jan 4 2019, 9:53 PM
asturmlechner committed R1026:4f00f651f78d: Re-add accidentally removed test for QCA, KF5Wallet is optional (authored by asturmlechner).
Re-add accidentally removed test for QCA, KF5Wallet is optional
Jan 4 2019, 9:52 PM
asturmlechner closed D17902: Re-add accidentally removed test for QCA, KF5Wallet is optional.
Jan 4 2019, 9:52 PM
asturmlechner added a comment to D17873: Compile more files with enabled exceptions, required for exiv2 0.27.

Yes, this is necessary to successfully build on Gentoo as well.

Jan 4 2019, 6:42 PM · Gwenview
asturmlechner added a comment to D17903: Drop unused dependencies.

Could yo remove lines 178-181 too?

Jan 4 2019, 6:41 PM

Jan 1 2019

asturmlechner requested review of D17903: Drop unused dependencies.
Jan 1 2019, 7:18 PM
asturmlechner updated the diff for D17902: Re-add accidentally removed test for QCA, KF5Wallet is optional.

Fix build with QCA disabled

Jan 1 2019, 7:08 PM
asturmlechner requested review of D17902: Re-add accidentally removed test for QCA, KF5Wallet is optional.
Jan 1 2019, 6:56 PM

Dec 30 2018

asturmlechner closed D17799: Fix building against exiv2-0.27.
Dec 30 2018, 3:39 PM
asturmlechner committed R378:d1be9298c7f2: Fix building against exiv2-0.27 (authored by asturmlechner).
Fix building against exiv2-0.27
Dec 30 2018, 3:39 PM
asturmlechner abandoned D17869: Fix build with exiv2-0.27.

Abandoned in favor of better D17872

Dec 30 2018, 3:19 PM · Gwenview
asturmlechner added a comment to D17872: Use forward declaration for Exiv2::Image, port to std::unique_ptr.

See D17873

Dec 30 2018, 3:14 PM · Gwenview
asturmlechner added a comment to D17872: Use forward declaration for Exiv2::Image, port to std::unique_ptr.

Still failed to build with the following error, which is why I had to enable exceptions in my patch to make it work:

Dec 30 2018, 3:08 PM · Gwenview
asturmlechner updated the summary of D17799: Fix building against exiv2-0.27.
Dec 30 2018, 1:17 PM
asturmlechner updated the summary of D17869: Fix build with exiv2-0.27.
Dec 30 2018, 1:11 PM · Gwenview
asturmlechner requested review of D17869: Fix build with exiv2-0.27.
Dec 30 2018, 1:09 PM · Gwenview

Dec 29 2018

asturmlechner updated the diff for D17799: Fix building against exiv2-0.27.

Drop obsolete includes and macro

Dec 29 2018, 7:52 PM

Dec 28 2018

asturmlechner committed R37:6b6758bb37da: Fix building against exiv2-0.27 (authored by asturmlechner).
Fix building against exiv2-0.27
Dec 28 2018, 5:36 PM
asturmlechner closed D17810: Fix building against exiv2-0.27.
Dec 28 2018, 5:36 PM · Krita
asturmlechner updated the diff for D17810: Fix building against exiv2-0.27.

Drop another excess line change

Dec 28 2018, 2:14 AM · Krita
asturmlechner updated the diff for D17810: Fix building against exiv2-0.27.

More fixes

Dec 28 2018, 2:06 AM · Krita
asturmlechner added inline comments to D17810: Fix building against exiv2-0.27.
Dec 28 2018, 1:18 AM · Krita
asturmlechner added inline comments to D17810: Fix building against exiv2-0.27.
Dec 28 2018, 1:15 AM · Krita

Dec 27 2018

asturmlechner added a comment to D17799: Fix building against exiv2-0.27.

Also, maybe now it is time to raise minimum exiv2 to (at least) 0.25? This was reverted in 6c196e4 three years ago.

Dec 27 2018, 11:38 PM
asturmlechner added a reviewer for D17799: Fix building against exiv2-0.27: aacid.
Dec 27 2018, 11:37 PM
asturmlechner updated the diff for D17810: Fix building against exiv2-0.27.

Invert conditionals to reduce diff.

Dec 27 2018, 11:23 PM · Krita
asturmlechner updated the summary of D17799: Fix building against exiv2-0.27.
Dec 27 2018, 12:25 AM
asturmlechner updated the diff for D17799: Fix building against exiv2-0.27.

Simplify version check to keep cmake at 3.0.0

Dec 27 2018, 12:21 AM

Dec 26 2018

asturmlechner added a comment to D17810: Fix building against exiv2-0.27.

PS: Backportable to 4.1 branch replacing a single hunk:

diff --git a/libs/ui/kisexiv2/kis_exiv2.h b/libs/ui/kisexiv2/kis_exiv2.h
index 9343265f1e..6b66aa7852 100644
--- a/libs/ui/kisexiv2/kis_exiv2.h
+++ b/libs/ui/kisexiv2/kis_exiv2.h
@@ -21,7 +21,7 @@
Dec 26 2018, 3:56 PM · Krita
asturmlechner requested review of D17810: Fix building against exiv2-0.27.
Dec 26 2018, 3:23 PM · Krita

Dec 25 2018

asturmlechner updated the diff for D17799: Fix building against exiv2-0.27.

Upstream advises to include exiv2/exiv2.hpp over exiv2/version.hpp

Dec 25 2018, 6:35 PM
asturmlechner updated the diff for D17799: Fix building against exiv2-0.27.

Missed updating .pc

Dec 25 2018, 6:02 PM
asturmlechner requested review of D17799: Fix building against exiv2-0.27.
Dec 25 2018, 5:39 PM

Dec 23 2018

asturmlechner added a reviewer for D16982: Switch to tidy-html5 and use tidybuffio.h instead of buffio.h: dfaure.
Dec 23 2018, 4:18 PM

Dec 20 2018

asturmlechner committed R42:f5af0d469041: Use KF5_MIN_VERSION instead of KF5_VERSION (authored by asturmlechner).
Use KF5_MIN_VERSION instead of KF5_VERSION
Dec 20 2018, 8:28 PM
asturmlechner closed D17684: Use KF5_MIN_VERSION instead of KF5_VERSION.
Dec 20 2018, 8:28 PM · KDE PIM

Dec 19 2018

asturmlechner updated the diff for D17684: Use KF5_MIN_VERSION instead of KF5_VERSION.

Update after review

Dec 19 2018, 7:44 PM · KDE PIM
asturmlechner added inline comments to D17684: Use KF5_MIN_VERSION instead of KF5_VERSION.
Dec 19 2018, 1:52 PM · KDE PIM
asturmlechner updated the summary of D17684: Use KF5_MIN_VERSION instead of KF5_VERSION.
Dec 19 2018, 1:50 PM · KDE PIM
asturmlechner added a comment to D17684: Use KF5_MIN_VERSION instead of KF5_VERSION.

Alternatively we could use KF5_REQUIRED_VERSION, similar to what is used for Qt.

Dec 19 2018, 1:33 PM · KDE PIM
asturmlechner requested review of D17684: Use KF5_MIN_VERSION instead of KF5_VERSION.
Dec 19 2018, 1:23 PM · KDE PIM

Nov 28 2018

asturmlechner added a comment to D12761: Allow building kio-nfs against standalone libtirpc.

@asturmlechner can you post that in a new review request? I'll abandon this one.

Nov 28 2018, 7:42 AM · Frameworks, Dolphin
asturmlechner requested review of D17205: Build kio_nfs against standalone libtirpc.
Nov 28 2018, 7:41 AM · Frameworks, Dolphin

Nov 27 2018

asturmlechner added inline comments to D12761: Allow building kio-nfs against standalone libtirpc.
Nov 27 2018, 11:28 PM · Frameworks, Dolphin
Restricted Application added projects to D12761: Allow building kio-nfs against standalone libtirpc: Dolphin, Frameworks.
Nov 27 2018, 10:17 PM · Frameworks, Dolphin

Nov 18 2018

asturmlechner requested review of D16982: Switch to tidy-html5 and use tidybuffio.h instead of buffio.h.
Nov 18 2018, 5:44 PM

Nov 16 2018

asturmlechner abandoned D16870: Move required KF5KDELibs4Support dependency to conditional kolab resource.

This needs much more work unfortunately. The existing changeset also appears to be broken with oauth support, so I'm going to pull it.

Nov 16 2018, 10:33 PM · KDE PIM

Nov 14 2018

asturmlechner added inline comments to D16870: Move required KF5KDELibs4Support dependency to conditional kolab resource.
Nov 14 2018, 12:28 AM · KDE PIM

Nov 13 2018

asturmlechner added a reviewer for D16870: Move required KF5KDELibs4Support dependency to conditional kolab resource: mlaurent.
Nov 13 2018, 8:02 PM · KDE PIM
asturmlechner requested review of D16870: Move required KF5KDELibs4Support dependency to conditional kolab resource.
Nov 13 2018, 7:56 PM · KDE PIM

Oct 15 2018

asturmlechner committed R37:d267979af952: krita_qimageio.desktop: Fix MimeType separators (authored by asturmlechner).
krita_qimageio.desktop: Fix MimeType separators
Oct 15 2018, 4:43 PM
asturmlechner closed D16222: krita_qimageio.desktop: Fix MimeType separators.
Oct 15 2018, 4:43 PM · Krita
asturmlechner requested review of D16222: krita_qimageio.desktop: Fix MimeType separators.
Oct 15 2018, 12:03 PM · Krita

Oct 9 2018

asturmlechner committed R116:b079d5a790b2: Merge branch 'Plasma/5.14' (authored by asturmlechner).
Merge branch 'Plasma/5.14'
Oct 9 2018, 7:40 PM
asturmlechner committed R116:6919a84c70d8: openconnect: add missing dependency Qt5Xml (authored by asturmlechner).
openconnect: add missing dependency Qt5Xml
Oct 9 2018, 7:37 PM
asturmlechner closed D16073: openconnect: add missing dependency Qt5Xml.
Oct 9 2018, 7:37 PM · Plasma
asturmlechner added a comment to D16073: openconnect: add missing dependency Qt5Xml.

If it fixes build error .../vpn/openconnect/openconnectauth.cpp:38:10: fatal error: QDomDocument: No such file or directory then fine...

Oct 9 2018, 7:31 PM · Plasma
asturmlechner updated the diff for D16073: openconnect: add missing dependency Qt5Xml.

Only pull in Qt5Xml if OpenConnect is requested.

Oct 9 2018, 2:18 PM · Plasma
asturmlechner requested review of D16073: openconnect: add missing dependency Qt5Xml.
Oct 9 2018, 2:12 PM · Plasma

Oct 8 2018

asturmlechner added a comment to D16012: Make Qt5Test optional.

(there are also some missing deps that are implicitly linked, but that is for another review)

Oct 8 2018, 6:37 AM · KDevelop

Oct 7 2018

asturmlechner updated the diff for D16012: Make Qt5Test optional.

Make KF5Archive exclusive to BUILD_TESTING as well

Oct 7 2018, 10:29 PM · KDevelop
asturmlechner added a comment to D16012: Make Qt5Test optional.

To 5.3 branch, please.

Oct 7 2018, 7:46 PM · KDevelop
asturmlechner added a reviewer for D16012: Make Qt5Test optional: KDevelop.
Oct 7 2018, 12:47 PM · KDevelop
asturmlechner requested review of D16012: Make Qt5Test optional.
Oct 7 2018, 12:46 PM · KDevelop

Sep 14 2018

asturmlechner committed R396:b99310d021db: Drop unused dependencies, add implicit (authored by asturmlechner).
Drop unused dependencies, add implicit
Sep 14 2018, 2:48 PM
asturmlechner closed D15460: Drop unused dependencies, add implicit.
Sep 14 2018, 2:48 PM
asturmlechner committed R407:4c890e43ab57: Fix dependencies: add implicit, drop unused (authored by asturmlechner).
Fix dependencies: add implicit, drop unused
Sep 14 2018, 2:45 PM
asturmlechner closed D15459: Fix dependencies: add implicit, drop unused.
Sep 14 2018, 2:42 PM
asturmlechner committed R422:e3ca875e15e4: Drop unused dependencies (authored by asturmlechner).
Drop unused dependencies
Sep 14 2018, 2:40 PM
asturmlechner committed R422:d51951fcbb3f: Drop unused dependencies (authored by asturmlechner).
Drop unused dependencies
Sep 14 2018, 2:39 PM
asturmlechner closed D15457: Drop unused dependencies.
Sep 14 2018, 2:39 PM

Sep 12 2018

asturmlechner committed R119:cc47b95094a3: Add translucent background attribute to desktop icon popup menu (authored by anemeth).
Add translucent background attribute to desktop icon popup menu
Sep 12 2018, 9:50 PM
asturmlechner closed D15435: Add translucent background attribute to desktop icon popup menu.
Sep 12 2018, 9:50 PM · Plasma
asturmlechner abandoned D15148: Fix build with libraw 0.19.

Thanks, should have pulled before update...

Sep 12 2018, 5:39 PM · Krita
asturmlechner updated the diff for D15148: Fix build with libraw 0.19.

Update with changes in D15132

Sep 12 2018, 5:33 PM · Krita
asturmlechner updated the diff for D15460: Drop unused dependencies, add implicit.

Drop Qt5Svg as well.

Sep 12 2018, 4:48 PM
asturmlechner requested review of D15460: Drop unused dependencies, add implicit.
Sep 12 2018, 4:43 PM