asturmlechner (Andreas Sturmlechner)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Mar 24 2016, 9:08 PM (172 w, 4 d)
Availability
Available

Recent Activity

Yesterday

asturmlechner added a comment to D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop.

I'll have to do this downstream, anyway...

Mon, Jul 15, 6:32 PM · Plasma

Sun, Jul 14

asturmlechner committed R336:2c6ca95fae59: Make Qt5X11Extras optional (authored by asturmlechner).
Make Qt5X11Extras optional
Sun, Jul 14, 9:47 AM
asturmlechner closed D22389: Make Qt5X11Extras optional.
Sun, Jul 14, 9:47 AM · KDE Edu

Sat, Jul 13

asturmlechner updated the diff for D22389: Make Qt5X11Extras optional.

update README.md

Sat, Jul 13, 3:01 PM · KDE Edu

Thu, Jul 11

asturmlechner added inline comments to D22389: Make Qt5X11Extras optional.
Thu, Jul 11, 6:35 AM · KDE Edu
asturmlechner updated the summary of D22389: Make Qt5X11Extras optional.
Thu, Jul 11, 12:12 AM · KDE Edu
asturmlechner requested review of D22389: Make Qt5X11Extras optional.
Thu, Jul 11, 12:11 AM · KDE Edu

Wed, Jul 10

asturmlechner abandoned D22313: cmake: fix KTOUCH_BUILD_WITH_X11 condition.

Okay then... I do have commit access, fyi.

Wed, Jul 10, 8:06 PM · KDE Edu
asturmlechner added a comment to D22164: Enable PHONON_BUILD_PHONON4QT5 by default.

Currently debating throwing out Qt4 altogether.

Wed, Jul 10, 8:04 AM

Sun, Jul 7

asturmlechner requested review of D22313: cmake: fix KTOUCH_BUILD_WITH_X11 condition.
Sun, Jul 7, 9:05 PM · KDE Edu

Thu, Jul 4

asturmlechner committed R119:4dcd1588c1cf: doc: Some different phrasing, one instance of s/KDE/Plasma/ (authored by asturmlechner).
doc: Some different phrasing, one instance of s/KDE/Plasma/
Thu, Jul 4, 5:51 PM
asturmlechner closed D22214: doc: Some different phrasing, one instance of s/KDE/Plasma/.
Thu, Jul 4, 5:51 PM · Documentation, Plasma

Tue, Jul 2

asturmlechner requested review of D22214: doc: Some different phrasing, one instance of s/KDE/Plasma/.
Tue, Jul 2, 2:58 PM · Documentation, Plasma
asturmlechner updated subscribers of D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop.
Tue, Jul 2, 11:02 AM · Plasma
asturmlechner added a comment to D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop.

Well, what's the current situation - SDDM have made the decision on their part to append that tech-garbage for Wayland sessions, users end up with:

  • Plasma
  • Plasma (Wayland)
Tue, Jul 2, 10:57 AM · Plasma
asturmlechner requested review of D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop.
Tue, Jul 2, 8:57 AM · Plasma

Sun, Jun 30

asturmlechner added a comment to D22164: Enable PHONON_BUILD_PHONON4QT5 by default.

As a distro packager, in no way would I already build this one without explicitly setting the option already. Of course, it should end up in the changelog.

Sun, Jun 30, 6:48 PM

Fri, Jun 28

asturmlechner closed D22117: Add missing KF5WidgetsAddons and header to fix build.
Fri, Jun 28, 6:26 PM · Gwenview
asturmlechner committed R260:dbc8aad73033: Add missing KF5WidgetsAddons and header to fix build (authored by asturmlechner).
Add missing KF5WidgetsAddons and header to fix build
Fri, Jun 28, 6:26 PM

Thu, Jun 27

asturmlechner requested review of D22117: Add missing KF5WidgetsAddons and header to fix build.
Thu, Jun 27, 10:45 AM · Gwenview

Thu, Jun 20

asturmlechner committed R432:a617e2783370: Merge branch 'Applications/19.04' (authored by asturmlechner).
Merge branch 'Applications/19.04'
Thu, Jun 20, 12:54 PM
asturmlechner committed R432:e2406a148fb8: Drop unused KF5DocTools, add missing KF5Completion (authored by asturmlechner).
Drop unused KF5DocTools, add missing KF5Completion
Thu, Jun 20, 12:54 PM
asturmlechner closed D21921: Drop unused KF5DocTools, add missing KF5Completion.
Thu, Jun 20, 12:52 PM
asturmlechner added reviewers for D21921: Drop unused KF5DocTools, add missing KF5Completion: ngraham, cfeck.
Thu, Jun 20, 10:16 AM
asturmlechner requested review of D21921: Drop unused KF5DocTools, add missing KF5Completion.
Thu, Jun 20, 10:12 AM

Tue, Jun 18

asturmlechner added a comment to D19011: Thunderbolt KCM and KDED module.

and we should lobby distros to ship with the new repo/package.

Tue, Jun 18, 7:39 PM · Plasma

Jun 14 2019

asturmlechner added a comment to D21400: Downgrade KDEWebKit from Tier 3 to Porting Aids.

This should probably also be posted on release-team ML.

Jun 14 2019, 6:25 AM · Frameworks

Jun 1 2019

asturmlechner committed R1045:fb52c8778157: Drop unused deps and don't rely on implicit deps (authored by asturmlechner).
Drop unused deps and don't rely on implicit deps
Jun 1 2019, 3:07 PM
asturmlechner closed D21270: Drop unused deps and don't rely on implicit deps.
Jun 1 2019, 3:07 PM

May 19 2019

asturmlechner committed R470:8ed1e460b4ce: Fix build against ICU 64.1 and later (authored by asturmlechner).
Fix build against ICU 64.1 and later
May 19 2019, 1:08 PM
asturmlechner closed D21103: Fix build against ICU 64.1 and later.
May 19 2019, 1:08 PM

May 18 2019

asturmlechner updated the diff for D21270: Drop unused deps and don't rely on implicit deps.

Drop X11 cruft as well

May 18 2019, 11:22 AM
asturmlechner requested review of D21270: Drop unused deps and don't rely on implicit deps.
May 18 2019, 11:15 AM

May 15 2019

asturmlechner committed R260:4d6f113978fd: Merge branch 'Applications/19.04' (authored by asturmlechner).
Merge branch 'Applications/19.04'
May 15 2019, 8:52 PM
asturmlechner committed R260:172560b84546: Fix build with exiv2-0.27.1 (authored by asturmlechner).
Fix build with exiv2-0.27.1
May 15 2019, 8:40 PM
asturmlechner closed D21148: Fix build with exiv2-0.27.1.
May 15 2019, 8:40 PM · Gwenview

May 14 2019

asturmlechner added a comment to D21103: Fix build against ICU 64.1 and later.

At least with ICU 63 there is no problem with the change, I can't test with older versions. The same thing had to be also done for xmlsec, for reference: https://github.com/lsh123/xmlsec/pull/249

May 14 2019, 9:33 AM
asturmlechner added a comment to D21148: Fix build with exiv2-0.27.1.

Does this break anything for the older exiv releases?

May 14 2019, 8:59 AM · Gwenview

May 12 2019

asturmlechner updated the summary of D21148: Fix build with exiv2-0.27.1.
May 12 2019, 6:48 AM · Gwenview
asturmlechner requested review of D21148: Fix build with exiv2-0.27.1.
May 12 2019, 6:47 AM · Gwenview

May 11 2019

asturmlechner added a comment to D698: Port from WebKit to WebEngine..

I guess this can be closed?

May 11 2019, 5:52 PM · KDE Edu, Marble

May 9 2019

asturmlechner added a reviewer for D21103: Fix build against ICU 64.1 and later: rstephenson.
May 9 2019, 7:33 PM
asturmlechner updated the summary of D21103: Fix build against ICU 64.1 and later.
May 9 2019, 7:25 PM
asturmlechner requested review of D21103: Fix build against ICU 64.1 and later.
May 9 2019, 7:24 PM

May 5 2019

asturmlechner committed R480:60c8a15e726f: cmake: Remove unused MacroUtils.cmake module (authored by asturmlechner).
cmake: Remove unused MacroUtils.cmake module
May 5 2019, 2:37 PM
asturmlechner closed D20713: Cleanup CMakeLists.txt and drop use of custom macros.
May 5 2019, 2:37 PM
asturmlechner committed R480:5eddfd73850b: Use FeatureSummary instead of local MacroUtils.cmake (authored by asturmlechner).
Use FeatureSummary instead of local MacroUtils.cmake
May 5 2019, 2:37 PM
asturmlechner committed R480:f4da4e381677: Drop use of DETECT_LIBKVKONTAKTE (authored by asturmlechner).
Drop use of DETECT_LIBKVKONTAKTE
May 5 2019, 2:37 PM
asturmlechner committed R480:670a6474e399: cmake: Remove MacroLocalLibs.cmake module (authored by asturmlechner).
cmake: Remove MacroLocalLibs.cmake module
May 5 2019, 2:37 PM
asturmlechner committed R480:50b26ca4dca3: Drop use of DETECT_LIBMEDIAWIKI (authored by asturmlechner).
Drop use of DETECT_LIBMEDIAWIKI
May 5 2019, 2:37 PM
asturmlechner committed R480:76dca8e8459f: Simplify optional Qt5/KF5 deps, drop ENABLE_KIO (authored by asturmlechner).
Simplify optional Qt5/KF5 deps, drop ENABLE_KIO
May 5 2019, 2:37 PM
asturmlechner committed R480:a723de2fe494: Drop use of DETECT_LIBKIPI macro and move relevant part to CMakeLists.txt (authored by asturmlechner).
Drop use of DETECT_LIBKIPI macro and move relevant part to CMakeLists.txt
May 5 2019, 2:37 PM
asturmlechner committed R480:c14ba77c61f3: Raise KF5_MIN_VERSION to 5.18.0 and use for ECM (authored by asturmlechner).
Raise KF5_MIN_VERSION to 5.18.0 and use for ECM
May 5 2019, 2:37 PM

May 4 2019

asturmlechner committed R318:4f232fb82f23: Fix create_symlink path to DESTDIR instead of root file system (authored by arfrever).
Fix create_symlink path to DESTDIR instead of root file system
May 4 2019, 11:45 AM
asturmlechner closed D21011: Fix create_symlink path to DESTDIR instead of root file system.
May 4 2019, 11:45 AM · Dolphin
asturmlechner added inline comments to D19310: Port to KGlobalAccel.
May 4 2019, 11:43 AM · Spectacle
asturmlechner added a comment to D20229: Re-implement Meta-E global launch shortcut using KGlobalAccel.

Review submitted: https://phabricator.kde.org/D21011

May 4 2019, 11:35 AM · Dolphin
asturmlechner requested review of D21011: Fix create_symlink path to DESTDIR instead of root file system.
May 4 2019, 11:34 AM · Dolphin
asturmlechner added a comment to D20229: Re-implement Meta-E global launch shortcut using KGlobalAccel.

@asturmlechner Is Spectacle also affected then? This cmake code was copied from there.

May 4 2019, 11:23 AM · Dolphin

May 3 2019

asturmlechner added a comment to D20229: Re-implement Meta-E global launch shortcut using KGlobalAccel.

This fix just got sent my way:

May 3 2019, 11:52 PM · Dolphin

May 2 2019

asturmlechner added a comment to D20229: Re-implement Meta-E global launch shortcut using KGlobalAccel.

Hmm, can you help me understand why this change breaks in a sandboxed environment?

May 2 2019, 8:36 AM · Dolphin

May 1 2019

asturmlechner added inline comments to D20229: Re-implement Meta-E global launch shortcut using KGlobalAccel.
May 1 2019, 6:59 PM · Dolphin

Apr 26 2019

asturmlechner added a comment to D20713: Cleanup CMakeLists.txt and drop use of custom macros.

It compiles here (including vkontakte)

TBH i don't know enough about the logic behind all the code your changing

Thanks for testing. The commits really do only what they tell, to make it look more like a regular kde-apps project. 'New' lines in CMakeLists.txt are only those parts copied (not otherwise changed) from DETECT_* macros that are relevant to kipi-plugins standalone building, all the other stuff was for building it as part of some 'Digikam SC' bundle.

Apr 26 2019, 2:23 PM

Apr 21 2019

asturmlechner requested review of D20713: Cleanup CMakeLists.txt and drop use of custom macros.
Apr 21 2019, 3:02 PM

Apr 7 2019

asturmlechner committed R108:6e1655e3cce0: Fix plugins/qpa build with Qt 5.13 (authored by Jimi Huotari <chiitoo@gentoo.org>).
Fix plugins/qpa build with Qt 5.13
Apr 7 2019, 7:10 PM

Apr 6 2019

asturmlechner added a comment to D20239: Fix plugins/qpa build with Qt 5.13.
In D20239#443172, @apol wrote:

This patch should go to the stable branch too.

Apr 6 2019, 9:57 PM · KWin

Apr 3 2019

asturmlechner committed R108:3cc39ba35eb2: Fix plugins/qpa build with Qt 5.13 (authored by Jimi Huotari <chiitoo@gentoo.org>).
Fix plugins/qpa build with Qt 5.13
Apr 3 2019, 11:20 PM
asturmlechner closed D20239: Fix plugins/qpa build with Qt 5.13.
Apr 3 2019, 11:18 PM · KWin
asturmlechner added a reviewer for D20239: Fix plugins/qpa build with Qt 5.13: KWin.
Apr 3 2019, 10:42 PM · KWin
asturmlechner updated subscribers of D20239: Fix plugins/qpa build with Qt 5.13.
Apr 3 2019, 10:41 PM · KWin
asturmlechner requested review of D20239: Fix plugins/qpa build with Qt 5.13.
Apr 3 2019, 10:39 PM · KWin
asturmlechner added a comment to D8626: DDCUtil: Improved DDCUtil support for brightness control over DDC/CI channel for supported monitors.

Hm, any reason why this is still pending?

Apr 3 2019, 6:57 PM · Plasma
asturmlechner added a comment to D20228: unbreak build by moving away from deprecated exec_program.

Builds fine for me!

Apr 3 2019, 2:19 PM

Mar 17 2019

asturmlechner added a comment to D7581: HiDPI Support for Gwenview.

At this point, the patch will need to be rebased since a lot has happened since August of 2017 (!). Either @hetzenecker will need to return and finish the work, or another interested party will need to take it over.

Mar 17 2019, 11:33 PM · Gwenview
asturmlechner added a comment to D7581: HiDPI Support for Gwenview.

Anything left for this to be merged? Sure would be nice to have for 19.04.

Mar 17 2019, 7:14 PM · Gwenview

Mar 5 2019

asturmlechner committed R983:161ed4b30667: Optionalise clang-tidy (authored by asturmlechner).
Optionalise clang-tidy
Mar 5 2019, 12:19 AM
asturmlechner closed D19507: Optionalise clang-tidy.
Mar 5 2019, 12:19 AM

Mar 4 2019

asturmlechner added a reviewer for D13231: fix build against OpenSSL 1.1: Kopete.
Mar 4 2019, 10:54 PM · Kopete
asturmlechner requested review of D19531: Fix dead link to Gentoo Wiki.
Mar 4 2019, 10:13 PM
asturmlechner committed R34:b65bfce8256a: Try to fix build with MARBLE_NO_WEBKITWIDGETS (authored by asturmlechner).
Try to fix build with MARBLE_NO_WEBKITWIDGETS
Mar 4 2019, 7:03 PM
asturmlechner closed D18143: Try to fix build with MARBLE_NO_WEBKITWIDGETS.
Mar 4 2019, 7:03 PM · KDE Edu, Marble
asturmlechner committed R34:599e962f7088: Avoid overwriting Qt5_FOUND with Qt5DBus or Qt5WebEngine disabled (authored by asturmlechner).
Avoid overwriting Qt5_FOUND with Qt5DBus or Qt5WebEngine disabled
Mar 4 2019, 7:00 PM
asturmlechner closed D18141: Avoid overwriting Qt5_FOUND with Qt5DBus or Qt5WebEngine disabled.
Mar 4 2019, 6:59 PM · KDE Edu, Marble
asturmlechner requested review of D19522: Set minimum Qt5 and KF5 versions and cleanup ifdefs.
Mar 4 2019, 6:29 PM
asturmlechner updated the summary of D19521: Switch from UsePkgConfig to FindPkgConfig.
Mar 4 2019, 6:23 PM
asturmlechner updated the diff for D19521: Switch from UsePkgConfig to FindPkgConfig.

drop unrelated commit

Mar 4 2019, 6:23 PM
asturmlechner requested review of D19521: Switch from UsePkgConfig to FindPkgConfig.
Mar 4 2019, 6:17 PM
asturmlechner requested review of D19507: Optionalise clang-tidy.
Mar 4 2019, 10:30 AM

Feb 2 2019

asturmlechner committed R181:f319fef25c65: Fix unnecessary cmake warnings (Qt5_FOUND to FALSE), use QT_REQUIRED_VERSION (authored by asturmlechner).
Fix unnecessary cmake warnings (Qt5_FOUND to FALSE), use QT_REQUIRED_VERSION
Feb 2 2019, 9:19 PM
asturmlechner closed D18671: Fix unnecessary cmake warnings (Qt5_FOUND to FALSE), use QT_REQUIRED_VERSION.
Feb 2 2019, 9:19 PM
asturmlechner updated the summary of D18671: Fix unnecessary cmake warnings (Qt5_FOUND to FALSE), use QT_REQUIRED_VERSION.
Feb 2 2019, 9:19 PM
asturmlechner committed R181:c84422b41f6d: Add missing QStandardPaths to fix build (authored by asturmlechner).
Add missing QStandardPaths to fix build
Feb 2 2019, 8:55 PM
asturmlechner closed D18674: Add missing QStandardPaths to fix build.
Feb 2 2019, 8:55 PM
asturmlechner added a comment to D18674: Add missing QStandardPaths to fix build.

This occurred after switching to ninja by default, maybe related. But I hadn't built amarok before that in a while.

Feb 2 2019, 8:51 PM
asturmlechner added a comment to D18674: Add missing QStandardPaths to fix build.
-c /var/tmp/portage/media-sound/amarok-9999/work/amarok-9999/src/main.cpp
/var/tmp/portage/media-sound/amarok-9999/work/amarok-9999/src/main.cpp:101:162: warning: macro "__DATE__" might prevent reproducible builds [-Wdate-time]
                           ki18n( "IRC:\nirc.freenode.net - #amarok, #amarok.de, #amarok.es, #amarok.fr\n\nFeedback:\namarok@kde.org\n\n(Build Date: %1)" ).subs( __DATE__ ).toString(),
                                                                                                                                                                  ^~~~~~~~
/var/tmp/portage/media-sound/amarok-9999/work/amarok-9999/src/main.cpp: In function ‘int main(int, char**)’:
/var/tmp/portage/media-sound/amarok-9999/work/amarok-9999/src/main.cpp:74:40: error: ‘QStandardPaths’ has not been declared
         const QString targetBasePath = QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation) + QStringLiteral("/amarok/");
                                        ^~~~~~~~~~~~~~
/var/tmp/portage/media-sound/amarok-9999/work/amarok-9999/src/main.cpp:74:73: error: ‘QStandardPaths’ has not been declared
         const QString targetBasePath = QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation) + QStringLiteral("/amarok/");
                                                                         ^~~~~~~~~~~~~~
/var/tmp/portage/media-sound/amarok-9999/work/amarok-9999/src/main.cpp:361:82: note: #pragma message: PORT KF5: This *if* should be moved to activateRequested() slot
 #pragma message("PORT KF5: This *if* should be moved to activateRequested() slot")
                                                                                  ^
Feb 2 2019, 8:47 PM
asturmlechner requested review of D18674: Add missing QStandardPaths to fix build.
Feb 2 2019, 4:17 PM
asturmlechner requested review of D18671: Fix unnecessary cmake warnings (Qt5_FOUND to FALSE), use QT_REQUIRED_VERSION.
Feb 2 2019, 3:16 PM

Jan 24 2019

asturmlechner committed R326:b7a4b5764d04: Qt5OpenGL is only required with optional AvogadroLibs support (authored by asturmlechner).
Qt5OpenGL is only required with optional AvogadroLibs support
Jan 24 2019, 5:41 PM
asturmlechner closed D18312: Qt5OpenGL is only required with optional AvogadroLibs support.
Jan 24 2019, 5:41 PM · KDE Edu
asturmlechner retitled D18312: Qt5OpenGL is only required with optional AvogadroLibs support from Qt5OpenGL is only required in optional compoundviewer to Qt5OpenGL is only required with optional AvogadroLibs support.
Jan 24 2019, 5:35 PM · KDE Edu