asturmlechner (Andreas Sturmlechner)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Mar 24 2016, 9:08 PM (219 w, 2 d)
Availability
Available

Recent Activity

Sun, May 31

asturmlechner committed R626:44e2a35ebb16: Fix build with Qt 5.15 (missing QPainterPath include) (authored by asturmlechner).
Fix build with Qt 5.15 (missing QPainterPath include)
Sun, May 31, 9:39 PM

Sun, May 24

asturmlechner added a comment to T12157: KXmlRpcClient deprecation + removal.

It probably makes no sense to be part of Release Service any longer then.

Sun, May 24, 10:57 PM · KF6
asturmlechner added a comment to T11539: Port Okular away from KHTML.
Sun, May 24, 10:54 PM · Okular, KF6

May 7 2020

asturmlechner added a comment to D29514: Add FindXorgServer.cmake and use it for touchpad KCM.

Hmm, on my system, the file is located at /usr/src/xserver/include/xserver-properties.h, and this doesn't seen to find it:

Where is synaptics-properties.h located on your system, if you even have been building touchpad kcm so far?

It's in /usr/include/xorg.

I must confess I've never actually been able to build it, so I appreciate your efforts here to fix that.

In that case yes it must have failed so far during build, now cmake will warn you already. It is now the same as with Evdev, Libinput and Synaptics, if you don't have them in system paths you would have to somehow feed the alternative paths to cmake.

May 7 2020, 8:17 PM · Plasma
asturmlechner added a comment to D29514: Add FindXorgServer.cmake and use it for touchpad KCM.

Hmm, on my system, the file is located at /usr/src/xserver/include/xserver-properties.h, and this doesn't seen to find it:

May 7 2020, 8:05 PM · Plasma
asturmlechner committed R119:82e7a6b68d81: Add FindXorgServer.cmake and use it for touchpad KCM (authored by asturmlechner).
Add FindXorgServer.cmake and use it for touchpad KCM
May 7 2020, 7:19 PM
asturmlechner closed D29514: Add FindXorgServer.cmake and use it for touchpad KCM.
May 7 2020, 7:19 PM · Plasma
asturmlechner requested review of D29514: Add FindXorgServer.cmake and use it for touchpad KCM.
May 7 2020, 6:25 PM · Plasma

Apr 28 2020

asturmlechner added a reverting change for R871:064c400c4400: Make it compile with qt5.15: R871:9b0ced51506c: Revert "Make it compile with qt5.15".
Apr 28 2020, 9:29 PM
asturmlechner committed R871:9b0ced51506c: Revert "Make it compile with qt5.15" (authored by asturmlechner).
Revert "Make it compile with qt5.15"
Apr 28 2020, 9:29 PM

Apr 26 2020

asturmlechner added a comment to D29119: Dolphin: Implement package kit for deb/rpm/pacman service packages.

Does PackageKit work on Windows/MacOS? I don't think so. We should probably run this code only on Unix, no?

Apr 26 2020, 11:45 PM · Dolphin
asturmlechner committed R119:2e8a98a51107: synapticstouchpad.cpp: Drop synaptics-properties.h parent dir from include (authored by asturmlechner).
synapticstouchpad.cpp: Drop synaptics-properties.h parent dir from include
Apr 26 2020, 9:34 PM
asturmlechner closed D29215: synapticstouchpad.cpp: Drop synaptics-properties.h parent dir from include.
Apr 26 2020, 9:34 PM · Plasma
asturmlechner requested review of D29215: synapticstouchpad.cpp: Drop synaptics-properties.h parent dir from include.
Apr 26 2020, 8:45 PM · Plasma
asturmlechner committed R108:1e70f0809323: kwinscreenedges: Fix build (missing main.ui in… (authored by asturmlechner).
kwinscreenedges: Fix build (missing main.ui in…
Apr 26 2020, 6:22 PM
asturmlechner closed D29212: kwinscreenedges: Fix build (missing main.ui in kcm_kwintouchscreenedges_PART_SRCS).
Apr 26 2020, 6:17 PM · KWin
asturmlechner requested review of D29212: kwinscreenedges: Fix build (missing main.ui in kcm_kwintouchscreenedges_PART_SRCS).
Apr 26 2020, 6:06 PM · KWin

Apr 23 2020

asturmlechner added a comment to D28789: Fix crash due to changes in KBookmarkMenu.

This commit is missing in release/20.04 branch.

Apr 23 2020, 1:37 PM
asturmlechner added a comment to D28775: [KJots] Fix bookmarks actions.

Without ifdefs this is effectively raising minimum KF5 dependency to >=5.69:

Apr 23 2020, 10:44 AM · KDE PIM

Apr 21 2020

asturmlechner committed R440:b2c4b841937e: Fix build with Qt-5.15 (missing header) (authored by asturmlechner).
Fix build with Qt-5.15 (missing header)
Apr 21 2020, 6:17 PM
asturmlechner closed D29039: Fix build with Qt-5.15 (missing header).
Apr 21 2020, 6:17 PM
asturmlechner committed R7:f88c73cf278d: Fix build with Qt 5.15 (missing header) (authored by asturmlechner).
Fix build with Qt 5.15 (missing header)
Apr 21 2020, 8:58 AM
asturmlechner closed D29038: Fix build with Qt 5.15 (missing header).
Apr 21 2020, 8:58 AM
asturmlechner requested review of D29039: Fix build with Qt-5.15 (missing header).
Apr 21 2020, 8:43 AM
asturmlechner requested review of D29038: Fix build with Qt 5.15 (missing header).
Apr 21 2020, 8:40 AM

Apr 17 2020

asturmlechner added a comment to D28911: Adapt the code to KBookmarkMenu-5.69 changes.

This should also go to 1.7.

Apr 17 2020, 7:23 PM
asturmlechner added a comment to D28920: Adapt to changes in KBookmarks >= 5.69.

This should be in release/20.04 branch as well *imo*.

Apr 17 2020, 7:15 PM

Apr 14 2020

asturmlechner added a comment to D28242: Fix 'Audio Setup'.

In downstream I've simply removed that menu item for now.

Apr 14 2020, 1:39 PM

Apr 12 2020

asturmlechner added a comment to D28677: Make PipeWire, GBM and Epoxy libs as required dependencies.

Thanks for keeping pipewire optional, this is in line with how we have been packaging xdg-desktop-portal-kde in Gentoo so far, we had just been conditionally disabling the cmake finding of these 3 libraries to do it, and will switch over to using the new option then.

Apr 12 2020, 3:11 PM · Plasma

Mar 25 2020

asturmlechner updated the diff for D28284: Add FindMariaDB.cmake module and use it if MySQL is not found.

re-add accidentally removed required includes to FindMySQLe.cmake

Mar 25 2020, 8:06 PM · Amarok
asturmlechner updated the summary of D28284: Add FindMariaDB.cmake module and use it if MySQL is not found.
Mar 25 2020, 6:39 PM · Amarok
asturmlechner updated the diff for D28284: Add FindMariaDB.cmake module and use it if MySQL is not found.

updated for the case when mysqle is shipped with mariadb

Mar 25 2020, 6:36 PM · Amarok
asturmlechner accepted D27330: Fix DESTDIR usage.

Works for me!

Mar 25 2020, 6:25 PM
asturmlechner committed R540:4d59b59d9cee: Switch from UsePkgConfig to FindPkgConfig (authored by asturmlechner).
Switch from UsePkgConfig to FindPkgConfig
Mar 25 2020, 6:16 PM
asturmlechner closed D19521: Switch from UsePkgConfig to FindPkgConfig.
Mar 25 2020, 6:16 PM
asturmlechner committed R540:737d407a90cf: Set minimum Qt5 and KF5 versions and cleanup ifdefs (authored by asturmlechner).
Set minimum Qt5 and KF5 versions and cleanup ifdefs
Mar 25 2020, 6:12 PM
asturmlechner closed D19522: Set minimum Qt5 and KF5 versions and cleanup ifdefs.
Mar 25 2020, 6:12 PM
Restricted Application added a project to D24817: Restore scripting functionalities and Qt bindings.: Amarok.
Mar 25 2020, 6:05 PM · Amarok
asturmlechner added a comment to D27949: Conclude porting of Last.fm to Amarok KF5.

scrobble it does 👍

Mar 25 2020, 4:34 PM · Amarok
asturmlechner requested review of D28284: Add FindMariaDB.cmake module and use it if MySQL is not found.
Mar 25 2020, 3:43 PM · Amarok
asturmlechner added a comment to D28165: Fix compatibility with modern MySQL.

Waiting for @wbauer to confirm it works as well - btw, does openSUSE still provide mysqle to test -DWITH_MYSQL_EMBEDDED=on?

Mar 25 2020, 3:19 PM · Amarok
asturmlechner accepted D28165: Fix compatibility with modern MySQL.

Please test again, and thanks a lot for the review so far.

Mar 25 2020, 11:52 AM · Amarok
asturmlechner added a comment to D28165: Fix compatibility with modern MySQL.

The content of my /usr/include/mysql/mysql_version.h (which is just a symlink to mariadb_version.h):

Mar 25 2020, 1:15 AM · Amarok

Mar 24 2020

asturmlechner added a comment to D24805: Revert "CMakeLists.txt: use ccache if present".

Is there really any reason to fully revert? Why not just make it not the default per the above comment.

Mar 24 2020, 4:28 PM · Konsole
asturmlechner added a comment to D28242: Fix 'Audio Setup'.

Same check should imo also be added for phononsettings. This is shipped with phonon package, but kmix only indirectly pulls in that via knotifications, where it is optional.

Mar 24 2020, 4:06 PM
asturmlechner added a comment to D28165: Fix compatibility with modern MySQL.

Confirming successful build here as well.

Mar 24 2020, 2:48 PM · Amarok
asturmlechner added a reverting change for R319:007c2a085238: CMakeLists.txt: use ccache if present: D24805: Revert "CMakeLists.txt: use ccache if present".
Mar 24 2020, 10:59 AM
asturmlechner added a reverted change for D24805: Revert "CMakeLists.txt: use ccache if present": R319:007c2a085238: CMakeLists.txt: use ccache if present.
Mar 24 2020, 10:59 AM · Konsole
asturmlechner added a comment to D28165: Fix compatibility with modern MySQL.

That diff now looks like a diff in top of your previous diff.

Mar 24 2020, 12:27 AM · Amarok

Mar 23 2020

asturmlechner updated the summary of D24805: Revert "CMakeLists.txt: use ccache if present".
Mar 23 2020, 11:59 PM · Konsole
asturmlechner updated the diff for D24805: Revert "CMakeLists.txt: use ccache if present".

reverting after the original change did not go through review anyway.

Mar 23 2020, 11:45 PM · Konsole
asturmlechner added a comment to D24805: Revert "CMakeLists.txt: use ccache if present".

And here we have a sandbox error: https://forums.gentoo.org/viewtopic-t-1110252.html

Mar 23 2020, 10:53 PM · Konsole
asturmlechner added a comment to D27656: Adapt to new KAccounts plugin system.

This change should have raised minimum KACCOUNTS_MIN_VERSION as it breaks with 19.12.3 and below.

Mar 23 2020, 9:33 PM

Mar 12 2020

asturmlechner committed R1050:61d9d7eb0f0d: Fix install basket.xml to XDG_MIME_INSTALL_DIR (authored by asturmlechner).
Fix install basket.xml to XDG_MIME_INSTALL_DIR
Mar 12 2020, 2:21 PM
asturmlechner closed D27991: Fix install basket.xml to XDG_MIME_INSTALL_DIR.
Mar 12 2020, 2:20 PM

Mar 11 2020

asturmlechner requested review of D27991: Fix install basket.xml to XDG_MIME_INSTALL_DIR.
Mar 11 2020, 6:15 PM

Mar 5 2020

asturmlechner committed R320:1029148d9ca7: Build kio_nfs against standalone libtirpc (authored by asturmlechner).
Build kio_nfs against standalone libtirpc
Mar 5 2020, 12:07 AM
asturmlechner committed R320:9f1b9eb8b302: Add FindTIRPC.cmake (authored by cgiboudeaux).
Add FindTIRPC.cmake
Mar 5 2020, 12:07 AM
asturmlechner closed D17205: Build kio_nfs against standalone libtirpc.
Mar 5 2020, 12:07 AM · Frameworks, Dolphin

Jan 19 2020

asturmlechner added a comment to D26306: Define more documentation search paths (also custom).

Thanks for that, works for me!

Jan 19 2020, 7:24 PM · Documentation, Frameworks
asturmlechner added a comment to D26558: Port to fluidsynth 2.0.0 API.

What consequence is there for using minuet with fluidsynth-2 without this patch? So far it had built and linked to it without issues.

Jan 19 2020, 6:57 PM · KDE Edu, Minuet

Jan 12 2020

asturmlechner committed R252:08b1eabe3f54: Drop unused dependency (authored by asturmlechner).
Drop unused dependency
Jan 12 2020, 12:44 AM
asturmlechner closed D26596: Drop unused dependency.
Jan 12 2020, 12:44 AM · Frameworks
asturmlechner committed R252:fd0204ade2a6: Drop HAVE_X11 remnants (authored by asturmlechner).
Drop HAVE_X11 remnants
Jan 12 2020, 12:43 AM
asturmlechner closed D26597: Drop HAVE_X11 remnants.
Jan 12 2020, 12:43 AM · Frameworks
asturmlechner requested review of D26597: Drop HAVE_X11 remnants.
Jan 12 2020, 12:28 AM · Frameworks
asturmlechner requested review of D26596: Drop unused dependency.
Jan 12 2020, 12:28 AM · Frameworks

Dec 31 2019

asturmlechner added a comment to D26306: Define more documentation search paths (also custom).

Thanks for that, works for me!

Dec 31 2019, 7:39 PM · Documentation, Frameworks

Dec 25 2019

asturmlechner added a comment to D26050: Fix build with poppler 82.

Maybe we can drop 62, but not 72.

If this is for master I don't see why we could keep anything pre-0.79. Distros already have to patch the hell out of 3.1.0 which has led to diverging code because several changes are conflicting. That one needs a point release to settle that.

And meanwhile master needs a fix for 0.83 too.

What about releasing Calligra as a part of the Release Service (a release every 4 months with some Bugfix release between)? The latest release was almost 2 years ago, and we have more than 500 commits in master.

Dec 25 2019, 11:38 PM · Calligra: 3.0
asturmlechner added a comment to D26050: Fix build with poppler 82.

Maybe we can drop 62, but not 72.

Dec 25 2019, 9:55 PM · Calligra: 3.0

Dec 8 2019

asturmlechner added a reviewer for D25812: ECMFindQMLModule.cmake.in: Add ECM_DISABLE_QMLPLUGINDUMP to avoid sandbox violations: Frameworks.
Dec 8 2019, 3:32 PM · Build System, Frameworks
asturmlechner requested review of D25812: ECMFindQMLModule.cmake.in: Add ECM_DISABLE_QMLPLUGINDUMP to avoid sandbox violations.
Dec 8 2019, 3:29 PM · Build System, Frameworks
asturmlechner committed R495:8d7123896b98: Use standard ECMQMLModules (authored by asturmlechner).
Use standard ECMQMLModules
Dec 8 2019, 2:44 PM
asturmlechner closed D25809: Use standard ECMQMLModules.
Dec 8 2019, 2:44 PM · Frameworks
asturmlechner requested review of D25809: Use standard ECMQMLModules.
Dec 8 2019, 2:34 PM · Frameworks

Nov 21 2019

asturmlechner added a comment to T12083: Make DBus dependencies optional.

If this is acceptable I would not limit it to !LINUX; minimum dependencies may as well be desirable for those users.

Nov 21 2019, 11:12 AM · KF6

Nov 9 2019

asturmlechner added a comment to D24805: Revert "CMakeLists.txt: use ccache if present".

What do we do here then going further, am I supposed to apply a downstream patch for konsole 19.12.x?

Nov 9 2019, 12:54 PM · Konsole
asturmlechner added a comment to D25228: Bump version of KPeople.

Is it really necessary to split KF5 dependencies in two parts here? I don't see this being done anywhere else, KF5_MIN_VERSION is always global. Likewise, the Qt5 line change is simply unnecessary.

Nov 9 2019, 12:51 PM

Nov 6 2019

asturmlechner added a comment to D25162: Fix build with Qt 5.14+.

That fix is already in master: https://phabricator.kde.org/R375:90ebe8e37b8699ef26c10fb2928cf673cad04a06

Nov 6 2019, 12:06 AM

Oct 20 2019

asturmlechner added a comment to D24805: Revert "CMakeLists.txt: use ccache if present".

Do you have an example where having ccache on by default would cause a problem? When I asked what makes Konsole different from Mesa, libinput, etc, I was expecting to see an example.

ccache is nothing new, you can imagine it will be a hot topic on a source-based distribution, so we have years of experience with it. Issues are mostly sandbox violations as are typically used for packaging builds, but also build errors, so much that on bug reports it is regularly demanded to rebuild without ccache.

Oct 20 2019, 6:44 PM · Konsole
asturmlechner added a comment to D24805: Revert "CMakeLists.txt: use ccache if present".

E.g. recently I created this task.

Oct 20 2019, 5:38 PM · Konsole
asturmlechner added a comment to D24805: Revert "CMakeLists.txt: use ccache if present".

And packaging is disabling it.

Ok, so, I think there's some confusion between us. You're talking about "packaging" however here you want to make a commit into Konsole sources, i.e. to have influence on both packaging and building.

Oct 20 2019, 5:25 PM · Konsole
asturmlechner added a comment to D24805: Revert "CMakeLists.txt: use ccache if present".

Basically, any Meson-based project has ccache autodetection.

Oct 20 2019, 5:04 PM · Konsole
asturmlechner added a comment to D24805: Revert "CMakeLists.txt: use ccache if present".

ccache should never be enabled by default for packaging builds.

Why?

Oct 20 2019, 4:04 PM · Konsole
asturmlechner requested review of D24805: Revert "CMakeLists.txt: use ccache if present".
Oct 20 2019, 3:38 PM · Konsole

Oct 16 2019

asturmlechner committed R492:e5a3984ed26b: Fix build with KDE Frameworks 5.63 (authored by Lars Wendler <polynomial-c@gentoo.org>).
Fix build with KDE Frameworks 5.63
Oct 16 2019, 8:42 PM
asturmlechner committed R120:7f0ce07be5f7: Fix Name conflict between plasma.desktop and plasmawayland.desktop (authored by asturmlechner).
Fix Name conflict between plasma.desktop and plasmawayland.desktop
Oct 16 2019, 12:41 PM
asturmlechner closed D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop.
Oct 16 2019, 12:40 PM · Plasma

Oct 15 2019

asturmlechner updated the summary of D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop.
Oct 15 2019, 4:28 PM · Plasma
asturmlechner added a comment to D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop.
  1. A period where both X and wayland say "Plasma".

    1 is super super bad. Which means we need to patch one of the Plasma entries first. I would block this happening.

It is the status quo for everyone using a DM other than SDDM on <unaware-distro>, so any decision here is going to be an improvement.

Oct 15 2019, 3:47 PM · Plasma
asturmlechner updated the diff for D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop.

Switch back to Plasma (Wayland)

Oct 15 2019, 3:33 PM · Plasma
asturmlechner added a comment to D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop.

"Plasma on Xorg" is a yucky string to display to users.

well, it is what Gnome apparently does, so at least it would have lead to some uniformity. But no strong opinion here.

IMO it would be preferable to display "Plasma on Wayland (Wayland) for a limited period of time while the Plasma and SDDM versions aren't yet aligned.

...except I wasn't sure if you could call Plasma running "on" Wayland in the same sense as it is running "on" Xorg.

Oct 15 2019, 3:20 PM · Plasma

Sep 12 2019

asturmlechner added a comment to D23883: libkworkspace: Install sessionmanagementbackend.h with other headers.

copy that for Gentoo.

Sep 12 2019, 7:33 AM · Plasma

Sep 10 2019

asturmlechner added a watcher for KF6: asturmlechner.
Sep 10 2019, 10:58 AM

Aug 26 2019

asturmlechner committed R238:0c073ecebbb1: KF5DocToolsMacros.cmake: Use non-deprecated KDEInstallDirs variables (authored by asturmlechner).
KF5DocToolsMacros.cmake: Use non-deprecated KDEInstallDirs variables
Aug 26 2019, 1:02 PM
asturmlechner closed D23229: KF5DocToolsMacros.cmake: Use non-deprecated KDEInstallDirs variables.
Aug 26 2019, 1:02 PM · Documentation, Frameworks

Aug 17 2019

asturmlechner updated the diff for D23229: KF5DocToolsMacros.cmake: Use non-deprecated KDEInstallDirs variables.

Use deprecated variables as fallback if defined

Aug 17 2019, 9:49 PM · Documentation, Frameworks
asturmlechner added a reviewer for D23229: KF5DocToolsMacros.cmake: Use non-deprecated KDEInstallDirs variables: Frameworks.
Aug 17 2019, 9:07 PM · Documentation, Frameworks
asturmlechner requested review of D23229: KF5DocToolsMacros.cmake: Use non-deprecated KDEInstallDirs variables.
Aug 17 2019, 9:05 PM · Documentation, Frameworks

Aug 16 2019

asturmlechner added a comment to D23204: Restore backward compatibility for the version header.

works for me, calligraplan builds fine after this change!

Aug 16 2019, 4:21 PM · KDE PIM