asturmlechner (Andreas Sturmlechner)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Mar 24 2016, 9:08 PM (189 w, 6 d)
Availability
Available

Recent Activity

Sat, Nov 9

asturmlechner added a comment to D24805: Add ENABLE_CCACHE option (default=off).

What do we do here then going further, am I supposed to apply a downstream patch for konsole 19.12.x?

Sat, Nov 9, 12:54 PM · Konsole
asturmlechner added a comment to D25228: Bump version of KPeople.

Is it really necessary to split KF5 dependencies in two parts here? I don't see this being done anywhere else, KF5_MIN_VERSION is always global. Likewise, the Qt5 line change is simply unnecessary.

Sat, Nov 9, 12:51 PM

Wed, Nov 6

asturmlechner added a comment to D25162: Fix build with Qt 5.14+.

That fix is already in master: https://phabricator.kde.org/R375:90ebe8e37b8699ef26c10fb2928cf673cad04a06

Wed, Nov 6, 12:06 AM

Sun, Oct 20

asturmlechner added a comment to D24805: Add ENABLE_CCACHE option (default=off).

Do you have an example where having ccache on by default would cause a problem? When I asked what makes Konsole different from Mesa, libinput, etc, I was expecting to see an example.

ccache is nothing new, you can imagine it will be a hot topic on a source-based distribution, so we have years of experience with it. Issues are mostly sandbox violations as are typically used for packaging builds, but also build errors, so much that on bug reports it is regularly demanded to rebuild without ccache.

Sun, Oct 20, 6:44 PM · Konsole
asturmlechner added a comment to D24805: Add ENABLE_CCACHE option (default=off).

E.g. recently I created this task.

Sun, Oct 20, 5:38 PM · Konsole
asturmlechner added a comment to D24805: Add ENABLE_CCACHE option (default=off).

And packaging is disabling it.

Ok, so, I think there's some confusion between us. You're talking about "packaging" however here you want to make a commit into Konsole sources, i.e. to have influence on both packaging and building.

Sun, Oct 20, 5:25 PM · Konsole
asturmlechner added a comment to D24805: Add ENABLE_CCACHE option (default=off).

Basically, any Meson-based project has ccache autodetection.

Sun, Oct 20, 5:04 PM · Konsole
asturmlechner added a comment to D24805: Add ENABLE_CCACHE option (default=off).

ccache should never be enabled by default for packaging builds.

Why?

Sun, Oct 20, 4:04 PM · Konsole
asturmlechner requested review of D24805: Add ENABLE_CCACHE option (default=off).
Sun, Oct 20, 3:38 PM · Konsole

Wed, Oct 16

asturmlechner committed R492:e5a3984ed26b: Fix build with KDE Frameworks 5.63 (authored by Lars Wendler <polynomial-c@gentoo.org>).
Fix build with KDE Frameworks 5.63
Wed, Oct 16, 8:42 PM
asturmlechner committed R120:7f0ce07be5f7: Fix Name conflict between plasma.desktop and plasmawayland.desktop (authored by asturmlechner).
Fix Name conflict between plasma.desktop and plasmawayland.desktop
Wed, Oct 16, 12:41 PM
asturmlechner closed D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop.
Wed, Oct 16, 12:40 PM · Plasma

Oct 15 2019

asturmlechner updated the summary of D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop.
Oct 15 2019, 4:28 PM · Plasma
asturmlechner added a comment to D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop.
  1. A period where both X and wayland say "Plasma".

    1 is super super bad. Which means we need to patch one of the Plasma entries first. I would block this happening.

It is the status quo for everyone using a DM other than SDDM on <unaware-distro>, so any decision here is going to be an improvement.

Oct 15 2019, 3:47 PM · Plasma
asturmlechner updated the diff for D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop.

Switch back to Plasma (Wayland)

Oct 15 2019, 3:33 PM · Plasma
asturmlechner added a comment to D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop.

"Plasma on Xorg" is a yucky string to display to users.

well, it is what Gnome apparently does, so at least it would have lead to some uniformity. But no strong opinion here.

IMO it would be preferable to display "Plasma on Wayland (Wayland) for a limited period of time while the Plasma and SDDM versions aren't yet aligned.

...except I wasn't sure if you could call Plasma running "on" Wayland in the same sense as it is running "on" Xorg.

Oct 15 2019, 3:20 PM · Plasma

Sep 12 2019

asturmlechner added a comment to D23883: libkworkspace: Install sessionmanagementbackend.h with other headers.

copy that for Gentoo.

Sep 12 2019, 7:33 AM · Plasma

Sep 10 2019

asturmlechner added a watcher for KF6: asturmlechner.
Sep 10 2019, 10:58 AM

Aug 26 2019

asturmlechner committed R238:0c073ecebbb1: KF5DocToolsMacros.cmake: Use non-deprecated KDEInstallDirs variables (authored by asturmlechner).
KF5DocToolsMacros.cmake: Use non-deprecated KDEInstallDirs variables
Aug 26 2019, 1:02 PM
asturmlechner closed D23229: KF5DocToolsMacros.cmake: Use non-deprecated KDEInstallDirs variables.
Aug 26 2019, 1:02 PM · Documentation, Frameworks

Aug 17 2019

asturmlechner updated the diff for D23229: KF5DocToolsMacros.cmake: Use non-deprecated KDEInstallDirs variables.

Use deprecated variables as fallback if defined

Aug 17 2019, 9:49 PM · Documentation, Frameworks
asturmlechner added a reviewer for D23229: KF5DocToolsMacros.cmake: Use non-deprecated KDEInstallDirs variables: Frameworks.
Aug 17 2019, 9:07 PM · Documentation, Frameworks
asturmlechner requested review of D23229: KF5DocToolsMacros.cmake: Use non-deprecated KDEInstallDirs variables.
Aug 17 2019, 9:05 PM · Documentation, Frameworks

Aug 16 2019

asturmlechner added a comment to D23204: Restore backward compatibility for the version header.

works for me, calligraplan builds fine after this change!

Aug 16 2019, 4:21 PM · KDE PIM
asturmlechner abandoned D23202: Fix headers for >=KCalCore-5.12.0.
Aug 16 2019, 4:21 PM · Calligra: 3.0
asturmlechner added a comment to D23202: Fix headers for >=KCalCore-5.12.0.

This isn't wrong, but I'm surprised it's needed, we explicitly install headers in the old location too, for compatibility?

Aug 16 2019, 3:49 PM · Calligra: 3.0
asturmlechner requested review of D23202: Fix headers for >=KCalCore-5.12.0.
Aug 16 2019, 2:29 PM · Calligra: 3.0

Aug 14 2019

asturmlechner committed R116:a7eb3cb599fb: Add missing headers with DISABLE_MODEMMANAGER_SUPPORT=ON (authored by asturmlechner).
Add missing headers with DISABLE_MODEMMANAGER_SUPPORT=ON
Aug 14 2019, 10:04 AM
asturmlechner closed D23148: Add missing headers with DISABLE_MODEMMANAGER_SUPPORT=ON.
Aug 14 2019, 10:03 AM · Plasma
asturmlechner retitled D23148: Add missing headers with DISABLE_MODEMMANAGER_SUPPORT=ON from Add missing headers to Add missing headers with DISABLE_MODEMMANAGER_SUPPORT=ON.
Aug 14 2019, 9:44 AM · Plasma
asturmlechner requested review of D23148: Add missing headers with DISABLE_MODEMMANAGER_SUPPORT=ON.
Aug 14 2019, 9:26 AM · Plasma

Aug 10 2019

asturmlechner committed R437:1b5daefe5482: Merge branch 'Applications/19.08' (authored by asturmlechner).
Merge branch 'Applications/19.08'
Aug 10 2019, 9:09 AM
asturmlechner committed R437:62be4e43fd5a: Add missing QHash (authored by asturmlechner).
Add missing QHash
Aug 10 2019, 9:05 AM
asturmlechner closed D23059: Add missing QHash.
Aug 10 2019, 9:05 AM

Aug 9 2019

asturmlechner added a reviewer for D23059: Add missing QHash: lbeltrame.
Aug 9 2019, 7:27 PM
asturmlechner added a reviewer for D23059: Add missing QHash: KDE Applications.
Aug 9 2019, 7:24 PM
asturmlechner requested review of D23059: Add missing QHash.
Aug 9 2019, 7:23 PM
asturmlechner committed R473:95cfe51a23a2: Merge branch '5.1' (authored by asturmlechner).
Merge branch '5.1'
Aug 9 2019, 7:10 PM
asturmlechner committed R473:909215cc912d: Add missing QVector (authored by asturmlechner).
Add missing QVector
Aug 9 2019, 7:00 PM

Jul 29 2019

asturmlechner requested review of D22815: Fix finding (KF5)Plasma.
Jul 29 2019, 8:02 PM

Jul 24 2019

asturmlechner added inline comments to D22721: Clean up Kate addons CMake scripts..
Jul 24 2019, 6:38 PM · Kate
asturmlechner added inline comments to D22721: Clean up Kate addons CMake scripts..
Jul 24 2019, 5:22 PM · Kate

Jul 21 2019

asturmlechner updated the diff for D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop.

drop translations, rename to 'Plasma on Xorg'

Jul 21 2019, 7:56 AM · Plasma

Jul 20 2019

asturmlechner added a comment to D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop.

FWIW, Gnome appear to be calling theirs 'Gnome on Xorg' (and likewise, just 'Gnome' for the wayland session).

Jul 20 2019, 6:03 PM · Plasma

Jul 15 2019

asturmlechner added a comment to D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop.

I'll have to do this downstream, anyway...

Jul 15 2019, 6:32 PM · Plasma

Jul 14 2019

asturmlechner committed R336:2c6ca95fae59: Make Qt5X11Extras optional (authored by asturmlechner).
Make Qt5X11Extras optional
Jul 14 2019, 9:47 AM
asturmlechner closed D22389: Make Qt5X11Extras optional.
Jul 14 2019, 9:47 AM · KDE Edu

Jul 13 2019

asturmlechner updated the diff for D22389: Make Qt5X11Extras optional.

update README.md

Jul 13 2019, 3:01 PM · KDE Edu

Jul 11 2019

asturmlechner added inline comments to D22389: Make Qt5X11Extras optional.
Jul 11 2019, 6:35 AM · KDE Edu
asturmlechner updated the summary of D22389: Make Qt5X11Extras optional.
Jul 11 2019, 12:12 AM · KDE Edu
asturmlechner requested review of D22389: Make Qt5X11Extras optional.
Jul 11 2019, 12:11 AM · KDE Edu

Jul 10 2019

asturmlechner abandoned D22313: cmake: fix KTOUCH_BUILD_WITH_X11 condition.

Okay then... I do have commit access, fyi.

Jul 10 2019, 8:06 PM · KDE Edu
asturmlechner added a comment to D22164: Enable PHONON_BUILD_PHONON4QT5 by default.

Currently debating throwing out Qt4 altogether.

Jul 10 2019, 8:04 AM

Jul 7 2019

asturmlechner requested review of D22313: cmake: fix KTOUCH_BUILD_WITH_X11 condition.
Jul 7 2019, 9:05 PM · KDE Edu

Jul 4 2019

asturmlechner committed R119:4dcd1588c1cf: doc: Some different phrasing, one instance of s/KDE/Plasma/ (authored by asturmlechner).
doc: Some different phrasing, one instance of s/KDE/Plasma/
Jul 4 2019, 5:51 PM
asturmlechner closed D22214: doc: Some different phrasing, one instance of s/KDE/Plasma/.
Jul 4 2019, 5:51 PM · Documentation, Plasma

Jul 2 2019

asturmlechner requested review of D22214: doc: Some different phrasing, one instance of s/KDE/Plasma/.
Jul 2 2019, 2:58 PM · Documentation, Plasma
asturmlechner updated subscribers of D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop.
Jul 2 2019, 11:02 AM · Plasma
asturmlechner added a comment to D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop.

Well, what's the current situation - SDDM have made the decision on their part to append that tech-garbage for Wayland sessions, users end up with:

  • Plasma
  • Plasma (Wayland)
Jul 2 2019, 10:57 AM · Plasma
asturmlechner requested review of D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop.
Jul 2 2019, 8:57 AM · Plasma

Jun 30 2019

asturmlechner added a comment to D22164: Enable PHONON_BUILD_PHONON4QT5 by default.

As a distro packager, in no way would I already build this one without explicitly setting the option already. Of course, it should end up in the changelog.

Jun 30 2019, 6:48 PM

Jun 28 2019

asturmlechner closed D22117: Add missing KF5WidgetsAddons and header to fix build.
Jun 28 2019, 6:26 PM · Gwenview
asturmlechner committed R260:dbc8aad73033: Add missing KF5WidgetsAddons and header to fix build (authored by asturmlechner).
Add missing KF5WidgetsAddons and header to fix build
Jun 28 2019, 6:26 PM

Jun 27 2019

asturmlechner requested review of D22117: Add missing KF5WidgetsAddons and header to fix build.
Jun 27 2019, 10:45 AM · Gwenview

Jun 20 2019

asturmlechner committed R432:a617e2783370: Merge branch 'Applications/19.04' (authored by asturmlechner).
Merge branch 'Applications/19.04'
Jun 20 2019, 12:54 PM
asturmlechner committed R432:e2406a148fb8: Drop unused KF5DocTools, add missing KF5Completion (authored by asturmlechner).
Drop unused KF5DocTools, add missing KF5Completion
Jun 20 2019, 12:54 PM
asturmlechner closed D21921: Drop unused KF5DocTools, add missing KF5Completion.
Jun 20 2019, 12:52 PM
asturmlechner added reviewers for D21921: Drop unused KF5DocTools, add missing KF5Completion: ngraham, cfeck.
Jun 20 2019, 10:16 AM
asturmlechner requested review of D21921: Drop unused KF5DocTools, add missing KF5Completion.
Jun 20 2019, 10:12 AM

Jun 18 2019

asturmlechner added a comment to D19011: Thunderbolt KCM and KDED module.

and we should lobby distros to ship with the new repo/package.

Jun 18 2019, 7:39 PM · Plasma

Jun 14 2019

asturmlechner added a comment to D21400: Downgrade KDEWebKit from Tier 3 to Porting Aids.

This should probably also be posted on release-team ML.

Jun 14 2019, 6:25 AM · Frameworks

Jun 1 2019

asturmlechner committed R1045:fb52c8778157: Drop unused deps and don't rely on implicit deps (authored by asturmlechner).
Drop unused deps and don't rely on implicit deps
Jun 1 2019, 3:07 PM
asturmlechner closed D21270: Drop unused deps and don't rely on implicit deps.
Jun 1 2019, 3:07 PM

May 19 2019

asturmlechner committed R470:8ed1e460b4ce: Fix build against ICU 64.1 and later (authored by asturmlechner).
Fix build against ICU 64.1 and later
May 19 2019, 1:08 PM
asturmlechner closed D21103: Fix build against ICU 64.1 and later.
May 19 2019, 1:08 PM

May 18 2019

asturmlechner updated the diff for D21270: Drop unused deps and don't rely on implicit deps.

Drop X11 cruft as well

May 18 2019, 11:22 AM
asturmlechner requested review of D21270: Drop unused deps and don't rely on implicit deps.
May 18 2019, 11:15 AM

May 15 2019

asturmlechner committed R260:4d6f113978fd: Merge branch 'Applications/19.04' (authored by asturmlechner).
Merge branch 'Applications/19.04'
May 15 2019, 8:52 PM
asturmlechner committed R260:172560b84546: Fix build with exiv2-0.27.1 (authored by asturmlechner).
Fix build with exiv2-0.27.1
May 15 2019, 8:40 PM
asturmlechner closed D21148: Fix build with exiv2-0.27.1.
May 15 2019, 8:40 PM · Gwenview

May 14 2019

asturmlechner added a comment to D21103: Fix build against ICU 64.1 and later.

At least with ICU 63 there is no problem with the change, I can't test with older versions. The same thing had to be also done for xmlsec, for reference: https://github.com/lsh123/xmlsec/pull/249

May 14 2019, 9:33 AM
asturmlechner added a comment to D21148: Fix build with exiv2-0.27.1.

Does this break anything for the older exiv releases?

May 14 2019, 8:59 AM · Gwenview

May 12 2019

asturmlechner updated the summary of D21148: Fix build with exiv2-0.27.1.
May 12 2019, 6:48 AM · Gwenview
asturmlechner requested review of D21148: Fix build with exiv2-0.27.1.
May 12 2019, 6:47 AM · Gwenview

May 11 2019

asturmlechner added a comment to D698: Port from WebKit to WebEngine..

I guess this can be closed?

May 11 2019, 5:52 PM · KDE Edu, Marble

May 9 2019

asturmlechner added a reviewer for D21103: Fix build against ICU 64.1 and later: rstephenson.
May 9 2019, 7:33 PM
asturmlechner updated the summary of D21103: Fix build against ICU 64.1 and later.
May 9 2019, 7:25 PM
asturmlechner requested review of D21103: Fix build against ICU 64.1 and later.
May 9 2019, 7:24 PM

May 5 2019

asturmlechner committed R480:60c8a15e726f: cmake: Remove unused MacroUtils.cmake module (authored by asturmlechner).
cmake: Remove unused MacroUtils.cmake module
May 5 2019, 2:37 PM
asturmlechner closed D20713: Cleanup CMakeLists.txt and drop use of custom macros.
May 5 2019, 2:37 PM
asturmlechner committed R480:5eddfd73850b: Use FeatureSummary instead of local MacroUtils.cmake (authored by asturmlechner).
Use FeatureSummary instead of local MacroUtils.cmake
May 5 2019, 2:37 PM
asturmlechner committed R480:f4da4e381677: Drop use of DETECT_LIBKVKONTAKTE (authored by asturmlechner).
Drop use of DETECT_LIBKVKONTAKTE
May 5 2019, 2:37 PM
asturmlechner committed R480:670a6474e399: cmake: Remove MacroLocalLibs.cmake module (authored by asturmlechner).
cmake: Remove MacroLocalLibs.cmake module
May 5 2019, 2:37 PM
asturmlechner committed R480:50b26ca4dca3: Drop use of DETECT_LIBMEDIAWIKI (authored by asturmlechner).
Drop use of DETECT_LIBMEDIAWIKI
May 5 2019, 2:37 PM
asturmlechner committed R480:76dca8e8459f: Simplify optional Qt5/KF5 deps, drop ENABLE_KIO (authored by asturmlechner).
Simplify optional Qt5/KF5 deps, drop ENABLE_KIO
May 5 2019, 2:37 PM
asturmlechner committed R480:a723de2fe494: Drop use of DETECT_LIBKIPI macro and move relevant part to CMakeLists.txt (authored by asturmlechner).
Drop use of DETECT_LIBKIPI macro and move relevant part to CMakeLists.txt
May 5 2019, 2:37 PM
asturmlechner committed R480:c14ba77c61f3: Raise KF5_MIN_VERSION to 5.18.0 and use for ECM (authored by asturmlechner).
Raise KF5_MIN_VERSION to 5.18.0 and use for ECM
May 5 2019, 2:37 PM

May 4 2019

asturmlechner committed R318:4f232fb82f23: Fix create_symlink path to DESTDIR instead of root file system (authored by arfrever).
Fix create_symlink path to DESTDIR instead of root file system
May 4 2019, 11:45 AM
asturmlechner closed D21011: Fix create_symlink path to DESTDIR instead of root file system.
May 4 2019, 11:45 AM · Dolphin
asturmlechner added inline comments to D19310: Port to KGlobalAccel.
May 4 2019, 11:43 AM · Spectacle