asturmlechner (Andreas Sturmlechner)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Mar 24 2016, 9:08 PM (164 w, 5 d)
Availability
Available

Recent Activity

Sun, May 19

asturmlechner committed R470:8ed1e460b4ce: Fix build against ICU 64.1 and later (authored by asturmlechner).
Fix build against ICU 64.1 and later
Sun, May 19, 1:08 PM
asturmlechner closed D21103: Fix build against ICU 64.1 and later.
Sun, May 19, 1:08 PM

Sat, May 18

asturmlechner updated the diff for D21270: Drop unused deps and don't rely on implicit deps.

Drop X11 cruft as well

Sat, May 18, 11:22 AM
asturmlechner requested review of D21270: Drop unused deps and don't rely on implicit deps.
Sat, May 18, 11:15 AM

Wed, May 15

asturmlechner committed R260:4d6f113978fd: Merge branch 'Applications/19.04' (authored by asturmlechner).
Merge branch 'Applications/19.04'
Wed, May 15, 8:52 PM
asturmlechner committed R260:172560b84546: Fix build with exiv2-0.27.1 (authored by asturmlechner).
Fix build with exiv2-0.27.1
Wed, May 15, 8:40 PM
asturmlechner closed D21148: Fix build with exiv2-0.27.1.
Wed, May 15, 8:40 PM · Gwenview

Tue, May 14

asturmlechner added a comment to D21103: Fix build against ICU 64.1 and later.

At least with ICU 63 there is no problem with the change, I can't test with older versions. The same thing had to be also done for xmlsec, for reference: https://github.com/lsh123/xmlsec/pull/249

Tue, May 14, 9:33 AM
asturmlechner added a comment to D21148: Fix build with exiv2-0.27.1.

Does this break anything for the older exiv releases?

Tue, May 14, 8:59 AM · Gwenview

Sun, May 12

asturmlechner updated the summary of D21148: Fix build with exiv2-0.27.1.
Sun, May 12, 6:48 AM · Gwenview
asturmlechner requested review of D21148: Fix build with exiv2-0.27.1.
Sun, May 12, 6:47 AM · Gwenview

Sat, May 11

asturmlechner added a comment to D698: Port from WebKit to WebEngine..

I guess this can be closed?

Sat, May 11, 5:52 PM · KDE Edu, Marble

Thu, May 9

asturmlechner added a reviewer for D21103: Fix build against ICU 64.1 and later: rstephenson.
Thu, May 9, 7:33 PM
asturmlechner updated the summary of D21103: Fix build against ICU 64.1 and later.
Thu, May 9, 7:25 PM
asturmlechner requested review of D21103: Fix build against ICU 64.1 and later.
Thu, May 9, 7:24 PM

Sun, May 5

asturmlechner committed R480:60c8a15e726f: cmake: Remove unused MacroUtils.cmake module (authored by asturmlechner).
cmake: Remove unused MacroUtils.cmake module
Sun, May 5, 2:37 PM
asturmlechner closed D20713: Cleanup CMakeLists.txt and drop use of custom macros.
Sun, May 5, 2:37 PM
asturmlechner committed R480:5eddfd73850b: Use FeatureSummary instead of local MacroUtils.cmake (authored by asturmlechner).
Use FeatureSummary instead of local MacroUtils.cmake
Sun, May 5, 2:37 PM
asturmlechner committed R480:f4da4e381677: Drop use of DETECT_LIBKVKONTAKTE (authored by asturmlechner).
Drop use of DETECT_LIBKVKONTAKTE
Sun, May 5, 2:37 PM
asturmlechner committed R480:670a6474e399: cmake: Remove MacroLocalLibs.cmake module (authored by asturmlechner).
cmake: Remove MacroLocalLibs.cmake module
Sun, May 5, 2:37 PM
asturmlechner committed R480:50b26ca4dca3: Drop use of DETECT_LIBMEDIAWIKI (authored by asturmlechner).
Drop use of DETECT_LIBMEDIAWIKI
Sun, May 5, 2:37 PM
asturmlechner committed R480:76dca8e8459f: Simplify optional Qt5/KF5 deps, drop ENABLE_KIO (authored by asturmlechner).
Simplify optional Qt5/KF5 deps, drop ENABLE_KIO
Sun, May 5, 2:37 PM
asturmlechner committed R480:a723de2fe494: Drop use of DETECT_LIBKIPI macro and move relevant part to CMakeLists.txt (authored by asturmlechner).
Drop use of DETECT_LIBKIPI macro and move relevant part to CMakeLists.txt
Sun, May 5, 2:37 PM
asturmlechner committed R480:c14ba77c61f3: Raise KF5_MIN_VERSION to 5.18.0 and use for ECM (authored by asturmlechner).
Raise KF5_MIN_VERSION to 5.18.0 and use for ECM
Sun, May 5, 2:37 PM

Sat, May 4

asturmlechner committed R318:4f232fb82f23: Fix create_symlink path to DESTDIR instead of root file system (authored by arfrever).
Fix create_symlink path to DESTDIR instead of root file system
Sat, May 4, 11:45 AM
asturmlechner closed D21011: Fix create_symlink path to DESTDIR instead of root file system.
Sat, May 4, 11:45 AM · Dolphin
asturmlechner added inline comments to D19310: [WIP] Port to KGlobalAccel.
Sat, May 4, 11:43 AM · Spectacle
asturmlechner added a comment to D20229: Re-implement Meta-E global launch shortcut using KGlobalAccel.

Review submitted: https://phabricator.kde.org/D21011

Sat, May 4, 11:35 AM · Dolphin
asturmlechner requested review of D21011: Fix create_symlink path to DESTDIR instead of root file system.
Sat, May 4, 11:34 AM · Dolphin
asturmlechner added a comment to D20229: Re-implement Meta-E global launch shortcut using KGlobalAccel.

@asturmlechner Is Spectacle also affected then? This cmake code was copied from there.

Sat, May 4, 11:23 AM · Dolphin

Fri, May 3

asturmlechner added a comment to D20229: Re-implement Meta-E global launch shortcut using KGlobalAccel.

This fix just got sent my way:

Fri, May 3, 11:52 PM · Dolphin

Thu, May 2

asturmlechner added a comment to D20229: Re-implement Meta-E global launch shortcut using KGlobalAccel.

Hmm, can you help me understand why this change breaks in a sandboxed environment?

Thu, May 2, 8:36 AM · Dolphin

Wed, May 1

asturmlechner added inline comments to D20229: Re-implement Meta-E global launch shortcut using KGlobalAccel.
Wed, May 1, 6:59 PM · Dolphin

Fri, Apr 26

asturmlechner added a comment to D20713: Cleanup CMakeLists.txt and drop use of custom macros.

It compiles here (including vkontakte)

TBH i don't know enough about the logic behind all the code your changing

Thanks for testing. The commits really do only what they tell, to make it look more like a regular kde-apps project. 'New' lines in CMakeLists.txt are only those parts copied (not otherwise changed) from DETECT_* macros that are relevant to kipi-plugins standalone building, all the other stuff was for building it as part of some 'Digikam SC' bundle.

Fri, Apr 26, 2:23 PM

Apr 21 2019

asturmlechner requested review of D20713: Cleanup CMakeLists.txt and drop use of custom macros.
Apr 21 2019, 3:02 PM

Apr 7 2019

asturmlechner committed R108:6e1655e3cce0: Fix plugins/qpa build with Qt 5.13 (authored by Jimi Huotari <chiitoo@gentoo.org>).
Fix plugins/qpa build with Qt 5.13
Apr 7 2019, 7:10 PM

Apr 6 2019

asturmlechner added a comment to D20239: Fix plugins/qpa build with Qt 5.13.
In D20239#443172, @apol wrote:

This patch should go to the stable branch too.

Apr 6 2019, 9:57 PM · KWin

Apr 3 2019

asturmlechner committed R108:3cc39ba35eb2: Fix plugins/qpa build with Qt 5.13 (authored by Jimi Huotari <chiitoo@gentoo.org>).
Fix plugins/qpa build with Qt 5.13
Apr 3 2019, 11:20 PM
asturmlechner closed D20239: Fix plugins/qpa build with Qt 5.13.
Apr 3 2019, 11:18 PM · KWin
asturmlechner added a reviewer for D20239: Fix plugins/qpa build with Qt 5.13: KWin.
Apr 3 2019, 10:42 PM · KWin
asturmlechner updated subscribers of D20239: Fix plugins/qpa build with Qt 5.13.
Apr 3 2019, 10:41 PM · KWin
asturmlechner requested review of D20239: Fix plugins/qpa build with Qt 5.13.
Apr 3 2019, 10:39 PM · KWin
asturmlechner added a comment to D8626: DDCUtil: Improved DDCUtil support for brightness control over DDC/CI channel for supported monitors.

Hm, any reason why this is still pending?

Apr 3 2019, 6:57 PM · Plasma
asturmlechner added a comment to D20228: unbreak build by moving away from deprecated exec_program.

Builds fine for me!

Apr 3 2019, 2:19 PM

Mar 17 2019

asturmlechner added a comment to D7581: HiDPI Support for Gwenview.

At this point, the patch will need to be rebased since a lot has happened since August of 2017 (!). Either @hetzenecker will need to return and finish the work, or another interested party will need to take it over.

Mar 17 2019, 11:33 PM · Gwenview
asturmlechner added a comment to D7581: HiDPI Support for Gwenview.

Anything left for this to be merged? Sure would be nice to have for 19.04.

Mar 17 2019, 7:14 PM · Gwenview

Mar 5 2019

asturmlechner committed R983:161ed4b30667: Optionalise clang-tidy (authored by asturmlechner).
Optionalise clang-tidy
Mar 5 2019, 12:19 AM
asturmlechner closed D19507: Optionalise clang-tidy.
Mar 5 2019, 12:19 AM

Mar 4 2019

asturmlechner added a reviewer for D13231: fix build against OpenSSL 1.1: Kopete.
Mar 4 2019, 10:54 PM · Kopete
asturmlechner requested review of D19531: Fix dead link to Gentoo Wiki.
Mar 4 2019, 10:13 PM
asturmlechner committed R34:b65bfce8256a: Try to fix build with MARBLE_NO_WEBKITWIDGETS (authored by asturmlechner).
Try to fix build with MARBLE_NO_WEBKITWIDGETS
Mar 4 2019, 7:03 PM
asturmlechner closed D18143: Try to fix build with MARBLE_NO_WEBKITWIDGETS.
Mar 4 2019, 7:03 PM · KDE Edu, Marble
asturmlechner committed R34:599e962f7088: Avoid overwriting Qt5_FOUND with Qt5DBus or Qt5WebEngine disabled (authored by asturmlechner).
Avoid overwriting Qt5_FOUND with Qt5DBus or Qt5WebEngine disabled
Mar 4 2019, 7:00 PM
asturmlechner closed D18141: Avoid overwriting Qt5_FOUND with Qt5DBus or Qt5WebEngine disabled.
Mar 4 2019, 6:59 PM · KDE Edu, Marble
asturmlechner requested review of D19522: Set minimum Qt5 and KF5 versions and cleanup ifdefs.
Mar 4 2019, 6:29 PM
asturmlechner updated the summary of D19521: Switch from UsePkgConfig to FindPkgConfig.
Mar 4 2019, 6:23 PM
asturmlechner updated the diff for D19521: Switch from UsePkgConfig to FindPkgConfig.

drop unrelated commit

Mar 4 2019, 6:23 PM
asturmlechner requested review of D19521: Switch from UsePkgConfig to FindPkgConfig.
Mar 4 2019, 6:17 PM
asturmlechner requested review of D19507: Optionalise clang-tidy.
Mar 4 2019, 10:30 AM

Feb 2 2019

asturmlechner committed R181:f319fef25c65: Fix unnecessary cmake warnings (Qt5_FOUND to FALSE), use QT_REQUIRED_VERSION (authored by asturmlechner).
Fix unnecessary cmake warnings (Qt5_FOUND to FALSE), use QT_REQUIRED_VERSION
Feb 2 2019, 9:19 PM
asturmlechner closed D18671: Fix unnecessary cmake warnings (Qt5_FOUND to FALSE), use QT_REQUIRED_VERSION.
Feb 2 2019, 9:19 PM
asturmlechner updated the summary of D18671: Fix unnecessary cmake warnings (Qt5_FOUND to FALSE), use QT_REQUIRED_VERSION.
Feb 2 2019, 9:19 PM
asturmlechner committed R181:c84422b41f6d: Add missing QStandardPaths to fix build (authored by asturmlechner).
Add missing QStandardPaths to fix build
Feb 2 2019, 8:55 PM
asturmlechner closed D18674: Add missing QStandardPaths to fix build.
Feb 2 2019, 8:55 PM
asturmlechner added a comment to D18674: Add missing QStandardPaths to fix build.

This occurred after switching to ninja by default, maybe related. But I hadn't built amarok before that in a while.

Feb 2 2019, 8:51 PM
asturmlechner added a comment to D18674: Add missing QStandardPaths to fix build.
-c /var/tmp/portage/media-sound/amarok-9999/work/amarok-9999/src/main.cpp
/var/tmp/portage/media-sound/amarok-9999/work/amarok-9999/src/main.cpp:101:162: warning: macro "__DATE__" might prevent reproducible builds [-Wdate-time]
                           ki18n( "IRC:\nirc.freenode.net - #amarok, #amarok.de, #amarok.es, #amarok.fr\n\nFeedback:\namarok@kde.org\n\n(Build Date: %1)" ).subs( __DATE__ ).toString(),
                                                                                                                                                                  ^~~~~~~~
/var/tmp/portage/media-sound/amarok-9999/work/amarok-9999/src/main.cpp: In function ‘int main(int, char**)’:
/var/tmp/portage/media-sound/amarok-9999/work/amarok-9999/src/main.cpp:74:40: error: ‘QStandardPaths’ has not been declared
         const QString targetBasePath = QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation) + QStringLiteral("/amarok/");
                                        ^~~~~~~~~~~~~~
/var/tmp/portage/media-sound/amarok-9999/work/amarok-9999/src/main.cpp:74:73: error: ‘QStandardPaths’ has not been declared
         const QString targetBasePath = QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation) + QStringLiteral("/amarok/");
                                                                         ^~~~~~~~~~~~~~
/var/tmp/portage/media-sound/amarok-9999/work/amarok-9999/src/main.cpp:361:82: note: #pragma message: PORT KF5: This *if* should be moved to activateRequested() slot
 #pragma message("PORT KF5: This *if* should be moved to activateRequested() slot")
                                                                                  ^
Feb 2 2019, 8:47 PM
asturmlechner requested review of D18674: Add missing QStandardPaths to fix build.
Feb 2 2019, 4:17 PM
asturmlechner requested review of D18671: Fix unnecessary cmake warnings (Qt5_FOUND to FALSE), use QT_REQUIRED_VERSION.
Feb 2 2019, 3:16 PM

Jan 24 2019

asturmlechner committed R326:b7a4b5764d04: Qt5OpenGL is only required with optional AvogadroLibs support (authored by asturmlechner).
Qt5OpenGL is only required with optional AvogadroLibs support
Jan 24 2019, 5:41 PM
asturmlechner closed D18312: Qt5OpenGL is only required with optional AvogadroLibs support.
Jan 24 2019, 5:41 PM · KDE Edu
asturmlechner retitled D18312: Qt5OpenGL is only required with optional AvogadroLibs support from Qt5OpenGL is only required in optional compoundviewer to Qt5OpenGL is only required with optional AvogadroLibs support.
Jan 24 2019, 5:35 PM · KDE Edu

Jan 19 2019

asturmlechner added a comment to D18312: Qt5OpenGL is only required with optional AvogadroLibs support.

tools/moleculeview.cpp seems to use some QGL stuff

Also there's a Qt5::OpenGL in src/ so it means it should also search for it, no?

Jan 19 2019, 10:46 AM · KDE Edu

Jan 18 2019

asturmlechner added a comment to D18361: libkworkspace: Allow standalone build.

For the record, I would have been in support of this. ;)

Jan 18 2019, 2:24 PM · Plasma

Jan 17 2019

asturmlechner requested review of D18312: Qt5OpenGL is only required with optional AvogadroLibs support.
Jan 17 2019, 10:27 AM · KDE Edu

Jan 14 2019

asturmlechner added inline comments to D14147: Port from GConf to GSettings.
Jan 14 2019, 7:34 PM · Plasma

Jan 10 2019

asturmlechner committed R226:63b6a7435646: Switch to tidy-html5 and use tidybuffio.h instead of buffio.h (authored by asturmlechner).
Switch to tidy-html5 and use tidybuffio.h instead of buffio.h
Jan 10 2019, 9:22 PM
asturmlechner closed D16982: Switch to tidy-html5 and use tidybuffio.h instead of buffio.h.
Jan 10 2019, 9:07 PM
asturmlechner added a comment to D16982: Switch to tidy-html5 and use tidybuffio.h instead of buffio.h.

The header was renamed in 2015 which ended up in a release 5.0.0 in September - I think that's long enough. ;)

Jan 10 2019, 6:24 PM
asturmlechner added a reviewer for D16982: Switch to tidy-html5 and use tidybuffio.h instead of buffio.h: kossebau.
Jan 10 2019, 5:40 PM

Jan 9 2019

asturmlechner requested review of D18143: Try to fix build with MARBLE_NO_WEBKITWIDGETS.
Jan 9 2019, 10:34 PM · KDE Edu, Marble
asturmlechner requested review of D18141: Avoid overwriting Qt5_FOUND with Qt5DBus or Qt5WebEngine disabled.
Jan 9 2019, 10:30 PM · KDE Edu, Marble

Jan 4 2019

asturmlechner committed R1026:5924e3ad82b5: Drop unused dependencies (authored by asturmlechner).
Drop unused dependencies
Jan 4 2019, 9:53 PM
asturmlechner closed D17903: Drop unused dependencies.
Jan 4 2019, 9:53 PM
asturmlechner committed R1026:4f00f651f78d: Re-add accidentally removed test for QCA, KF5Wallet is optional (authored by asturmlechner).
Re-add accidentally removed test for QCA, KF5Wallet is optional
Jan 4 2019, 9:52 PM
asturmlechner closed D17902: Re-add accidentally removed test for QCA, KF5Wallet is optional.
Jan 4 2019, 9:52 PM
asturmlechner added a comment to D17873: Compile more files with enabled exceptions, required for exiv2 0.27.

Yes, this is necessary to successfully build on Gentoo as well.

Jan 4 2019, 6:42 PM · Gwenview
asturmlechner added a comment to D17903: Drop unused dependencies.

Could yo remove lines 178-181 too?

Jan 4 2019, 6:41 PM

Jan 1 2019

asturmlechner requested review of D17903: Drop unused dependencies.
Jan 1 2019, 7:18 PM
asturmlechner updated the diff for D17902: Re-add accidentally removed test for QCA, KF5Wallet is optional.

Fix build with QCA disabled

Jan 1 2019, 7:08 PM
asturmlechner requested review of D17902: Re-add accidentally removed test for QCA, KF5Wallet is optional.
Jan 1 2019, 6:56 PM

Dec 30 2018

asturmlechner closed D17799: Fix building against exiv2-0.27.
Dec 30 2018, 3:39 PM
asturmlechner committed R378:d1be9298c7f2: Fix building against exiv2-0.27 (authored by asturmlechner).
Fix building against exiv2-0.27
Dec 30 2018, 3:39 PM
asturmlechner abandoned D17869: Fix build with exiv2-0.27.

Abandoned in favor of better D17872

Dec 30 2018, 3:19 PM · Gwenview
asturmlechner added a comment to D17872: Use forward declaration for Exiv2::Image, port to std::unique_ptr.

See D17873

Dec 30 2018, 3:14 PM · Gwenview
asturmlechner added a comment to D17872: Use forward declaration for Exiv2::Image, port to std::unique_ptr.

Still failed to build with the following error, which is why I had to enable exceptions in my patch to make it work:

Dec 30 2018, 3:08 PM · Gwenview
asturmlechner updated the summary of D17799: Fix building against exiv2-0.27.
Dec 30 2018, 1:17 PM
asturmlechner updated the summary of D17869: Fix build with exiv2-0.27.
Dec 30 2018, 1:11 PM · Gwenview
asturmlechner requested review of D17869: Fix build with exiv2-0.27.
Dec 30 2018, 1:09 PM · Gwenview

Dec 29 2018

asturmlechner updated the diff for D17799: Fix building against exiv2-0.27.

Drop obsolete includes and macro

Dec 29 2018, 7:52 PM

Dec 28 2018

asturmlechner committed R37:6b6758bb37da: Fix building against exiv2-0.27 (authored by asturmlechner).
Fix building against exiv2-0.27
Dec 28 2018, 5:36 PM