asturmlechner (Andreas Sturmlechner)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Mar 24 2016, 9:08 PM (141 w, 5 d)
Availability
Available

Recent Activity

Wed, Nov 28

asturmlechner added a comment to D12761: Allow building kio-nfs against standalone libtirpc.

@asturmlechner can you post that in a new review request? I'll abandon this one.

Wed, Nov 28, 7:42 AM · Frameworks, Dolphin
asturmlechner requested review of D17205: Build kio_nfs against standalone libtirpc.
Wed, Nov 28, 7:41 AM · Frameworks, Dolphin

Tue, Nov 27

asturmlechner added inline comments to D12761: Allow building kio-nfs against standalone libtirpc.
Tue, Nov 27, 11:28 PM · Frameworks, Dolphin
Restricted Application added projects to D12761: Allow building kio-nfs against standalone libtirpc: Dolphin, Frameworks.
Tue, Nov 27, 10:17 PM · Frameworks, Dolphin

Sun, Nov 18

asturmlechner requested review of D16982: Switch to tidy-html5 and use tidybuffio.h instead of buffio.h.
Sun, Nov 18, 5:44 PM

Fri, Nov 16

asturmlechner abandoned D16870: Move required KF5KDELibs4Support dependency to conditional kolab resource.

This needs much more work unfortunately. The existing changeset also appears to be broken with oauth support, so I'm going to pull it.

Fri, Nov 16, 10:33 PM · KDE PIM

Wed, Nov 14

asturmlechner added inline comments to D16870: Move required KF5KDELibs4Support dependency to conditional kolab resource.
Wed, Nov 14, 12:28 AM · KDE PIM

Tue, Nov 13

asturmlechner added a reviewer for D16870: Move required KF5KDELibs4Support dependency to conditional kolab resource: mlaurent.
Tue, Nov 13, 8:02 PM · KDE PIM
asturmlechner requested review of D16870: Move required KF5KDELibs4Support dependency to conditional kolab resource.
Tue, Nov 13, 7:56 PM · KDE PIM

Oct 15 2018

asturmlechner committed R37:d267979af952: krita_qimageio.desktop: Fix MimeType separators (authored by asturmlechner).
krita_qimageio.desktop: Fix MimeType separators
Oct 15 2018, 4:43 PM
asturmlechner closed D16222: krita_qimageio.desktop: Fix MimeType separators.
Oct 15 2018, 4:43 PM · Krita
asturmlechner requested review of D16222: krita_qimageio.desktop: Fix MimeType separators.
Oct 15 2018, 12:03 PM · Krita

Oct 9 2018

asturmlechner committed R116:b079d5a790b2: Merge branch 'Plasma/5.14' (authored by asturmlechner).
Merge branch 'Plasma/5.14'
Oct 9 2018, 7:40 PM
asturmlechner committed R116:6919a84c70d8: openconnect: add missing dependency Qt5Xml (authored by asturmlechner).
openconnect: add missing dependency Qt5Xml
Oct 9 2018, 7:37 PM
asturmlechner closed D16073: openconnect: add missing dependency Qt5Xml.
Oct 9 2018, 7:37 PM · Plasma
asturmlechner added a comment to D16073: openconnect: add missing dependency Qt5Xml.

If it fixes build error .../vpn/openconnect/openconnectauth.cpp:38:10: fatal error: QDomDocument: No such file or directory then fine...

Oct 9 2018, 7:31 PM · Plasma
asturmlechner updated the diff for D16073: openconnect: add missing dependency Qt5Xml.

Only pull in Qt5Xml if OpenConnect is requested.

Oct 9 2018, 2:18 PM · Plasma
asturmlechner requested review of D16073: openconnect: add missing dependency Qt5Xml.
Oct 9 2018, 2:12 PM · Plasma

Oct 8 2018

asturmlechner added a comment to D16012: Make Qt5Test optional.

(there are also some missing deps that are implicitly linked, but that is for another review)

Oct 8 2018, 6:37 AM · KDevelop

Oct 7 2018

asturmlechner updated the diff for D16012: Make Qt5Test optional.

Make KF5Archive exclusive to BUILD_TESTING as well

Oct 7 2018, 10:29 PM · KDevelop
asturmlechner added a comment to D16012: Make Qt5Test optional.

To 5.3 branch, please.

Oct 7 2018, 7:46 PM · KDevelop
asturmlechner added a reviewer for D16012: Make Qt5Test optional: KDevelop.
Oct 7 2018, 12:47 PM · KDevelop
asturmlechner requested review of D16012: Make Qt5Test optional.
Oct 7 2018, 12:46 PM · KDevelop

Sep 14 2018

asturmlechner committed R396:b99310d021db: Drop unused dependencies, add implicit (authored by asturmlechner).
Drop unused dependencies, add implicit
Sep 14 2018, 2:48 PM
asturmlechner closed D15460: Drop unused dependencies, add implicit.
Sep 14 2018, 2:48 PM
asturmlechner committed R407:4c890e43ab57: Fix dependencies: add implicit, drop unused (authored by asturmlechner).
Fix dependencies: add implicit, drop unused
Sep 14 2018, 2:45 PM
asturmlechner closed D15459: Fix dependencies: add implicit, drop unused.
Sep 14 2018, 2:42 PM
asturmlechner committed R422:e3ca875e15e4: Drop unused dependencies (authored by asturmlechner).
Drop unused dependencies
Sep 14 2018, 2:40 PM
asturmlechner committed R422:d51951fcbb3f: Drop unused dependencies (authored by asturmlechner).
Drop unused dependencies
Sep 14 2018, 2:39 PM
asturmlechner closed D15457: Drop unused dependencies.
Sep 14 2018, 2:39 PM

Sep 12 2018

asturmlechner committed R119:cc47b95094a3: Add translucent background attribute to desktop icon popup menu (authored by anemeth).
Add translucent background attribute to desktop icon popup menu
Sep 12 2018, 9:50 PM
asturmlechner closed D15435: Add translucent background attribute to desktop icon popup menu.
Sep 12 2018, 9:50 PM · Plasma
asturmlechner abandoned D15148: Fix build with libraw 0.19.

Thanks, should have pulled before update...

Sep 12 2018, 5:39 PM · Krita
asturmlechner updated the diff for D15148: Fix build with libraw 0.19.

Update with changes in D15132

Sep 12 2018, 5:33 PM · Krita
asturmlechner updated the diff for D15460: Drop unused dependencies, add implicit.

Drop Qt5Svg as well.

Sep 12 2018, 4:48 PM
asturmlechner requested review of D15460: Drop unused dependencies, add implicit.
Sep 12 2018, 4:43 PM
asturmlechner requested review of D15459: Fix dependencies: add implicit, drop unused.
Sep 12 2018, 4:24 PM
asturmlechner requested review of D15457: Drop unused dependencies.
Sep 12 2018, 3:57 PM
asturmlechner committed R469:ee384e04e7c0: Fix build with SKG_DESIGNER=OFF (authored by asturmlechner).
Fix build with SKG_DESIGNER=OFF
Sep 12 2018, 12:18 PM
asturmlechner closed D15282: Fix build with SKG_DESIGNER=OFF.
Sep 12 2018, 12:18 PM
asturmlechner added a reviewer for D15282: Fix build with SKG_DESIGNER=OFF: smankowski.
Sep 12 2018, 10:57 AM

Sep 7 2018

asturmlechner added a comment to D15148: Fix build with libraw 0.19.

I think we already pushed this, didn't we?

Sep 7 2018, 8:39 AM · Krita

Sep 5 2018

asturmlechner updated the diff for D15282: Fix build with SKG_DESIGNER=OFF.

Fixed another instance of unconditional dependency.

Sep 5 2018, 7:15 AM
asturmlechner requested review of D15282: Fix build with SKG_DESIGNER=OFF.
Sep 5 2018, 7:05 AM

Aug 29 2018

asturmlechner updated the summary of D15148: Fix build with libraw 0.19.
Aug 29 2018, 4:00 PM · Krita
asturmlechner requested review of D15148: Fix build with libraw 0.19.
Aug 29 2018, 3:54 PM · Krita
asturmlechner updated subscribers of D15132: Fix build with libraw 0.19.

Thanks, this works fine for me!

Aug 29 2018, 10:18 AM

Aug 15 2018

asturmlechner added a comment to D12761: Allow building kio-nfs against standalone libtirpc.

ping, is this ready to merge?

Aug 15 2018, 3:47 PM · Frameworks, Dolphin

Jul 18 2018

asturmlechner added a comment to D8267: Correcting symlinks between col- and row-resize and split_v and _h cursors.

ping - could we get this in for 5.14?

Jul 18 2018, 7:47 PM · Plasma

Jul 14 2018

asturmlechner added a comment to D14066: Find KF5I18n in the top-level CMakeLists.txt.

I confirm necessity w/ >=KF-5.48 and that the fix is working.

Jul 14 2018, 11:26 AM

Jul 7 2018

asturmlechner committed R434:df62c257844b: Merge branch 'Applications/18.04' (authored by asturmlechner).
Merge branch 'Applications/18.04'
Jul 7 2018, 10:08 PM
asturmlechner committed R434:5995be5d2b4e: Fix pipes plugin build (missing moc include) (authored by asturmlechner).
Fix pipes plugin build (missing moc include)
Jul 7 2018, 10:01 PM
asturmlechner closed D13928: Fix pipes plugin build (missing moc include).
Jul 7 2018, 10:01 PM · Kopete
asturmlechner added a reviewer for D13928: Fix pipes plugin build (missing moc include): aacid.

It would be nice to get it fixed for 18.04.3.

Jul 7 2018, 3:09 PM · Kopete
asturmlechner requested review of D13928: Fix pipes plugin build (missing moc include).
Jul 7 2018, 9:55 AM · Kopete

Jun 26 2018

asturmlechner committed R626:237912b291dc: Switch from ENABLE_TEST to the ECM/CMake standard BUILD_TESTING (authored by asturmlechner).
Switch from ENABLE_TEST to the ECM/CMake standard BUILD_TESTING
Jun 26 2018, 4:21 PM
asturmlechner closed D13741: Switch from ENABLE_TEST to the ECM/CMake standard BUILD_TESTING.
Jun 26 2018, 4:21 PM
asturmlechner requested review of D13741: Switch from ENABLE_TEST to the ECM/CMake standard BUILD_TESTING.
Jun 26 2018, 4:17 PM

Jun 18 2018

asturmlechner added a comment to D13585: Use LIB_SUFFIX for lmdb libdir rather than hardcode lib.

The problem with that is cmake picking the wrong dir (first in order is lib, while it should be e.g. lib64).

Jun 18 2018, 5:30 AM · Baloo, Frameworks

Jun 17 2018

asturmlechner added a comment to D13585: Use LIB_SUFFIX for lmdb libdir rather than hardcode lib.

Not convinved it is the best way but it is some way to make it point to the desired multiarch libdir rather than make it choose a random one.

Jun 17 2018, 9:15 PM · Baloo, Frameworks
asturmlechner added a reviewer for D13585: Use LIB_SUFFIX for lmdb libdir rather than hardcode lib: Baloo.
Jun 17 2018, 9:14 PM · Baloo, Frameworks
asturmlechner requested review of D13585: Use LIB_SUFFIX for lmdb libdir rather than hardcode lib.
Jun 17 2018, 9:13 PM · Baloo, Frameworks
asturmlechner committed R746:67246a4a2c52: Fix build with Qt 5.11.0_beta3 (no more qt5_use_modules) (authored by asturmlechner).
Fix build with Qt 5.11.0_beta3 (no more qt5_use_modules)
Jun 17 2018, 8:05 PM
asturmlechner closed D13545: Fix build with Qt 5.11.0_beta3 (no more qt5_use_modules).
Jun 17 2018, 8:05 PM

Jun 14 2018

asturmlechner requested review of D13546: Raise to KF5 >= 5.37 and drop Boost fallback.
Jun 14 2018, 5:59 PM
asturmlechner added a reviewer for D13545: Fix build with Qt 5.11.0_beta3 (no more qt5_use_modules): rthomsen.
Jun 14 2018, 5:48 PM
asturmlechner requested review of D13545: Fix build with Qt 5.11.0_beta3 (no more qt5_use_modules).
Jun 14 2018, 5:47 PM
asturmlechner committed R484:de3110c59874: Fix configure with Qt-5.11.0_beta3 (no more qt5_use_modules) (authored by asturmlechner).
Fix configure with Qt-5.11.0_beta3 (no more qt5_use_modules)
Jun 14 2018, 7:56 AM
asturmlechner closed D13489: Fix configure with Qt-5.11.0_beta3 (no more qt5_use_modules).
Jun 14 2018, 7:52 AM · KDE Edu

Jun 13 2018

asturmlechner added a reviewer for D13489: Fix configure with Qt-5.11.0_beta3 (no more qt5_use_modules): KDE Edu.
Jun 13 2018, 5:31 PM · KDE Edu

Jun 12 2018

asturmlechner committed R845:42723bb3cb70: Make dependency on KF5NetworkManagerQt optional (authored by arfrever).
Make dependency on KF5NetworkManagerQt optional
Jun 12 2018, 8:09 AM
asturmlechner closed D13255: Make dependency on KF5NetworkManagerQt optional.
Jun 12 2018, 8:09 AM · Plasma
asturmlechner requested review of D13489: Fix configure with Qt-5.11.0_beta3 (no more qt5_use_modules).
Jun 12 2018, 7:13 AM · KDE Edu

Jun 11 2018

asturmlechner updated the diff for D13255: Make dependency on KF5NetworkManagerQt optional.

Use Q_UNUSED

Jun 11 2018, 6:16 AM · Plasma

Jun 9 2018

asturmlechner updated the diff for D13255: Make dependency on KF5NetworkManagerQt optional.

Update addressing 2/3 points raised

Jun 9 2018, 6:10 PM · Plasma
asturmlechner added a comment to D12696: Use the new uds implementation.

No crash in my case, but this commit makes links with sftp:/ inaccessible.

Jun 9 2018, 4:15 PM · Frameworks

Jun 6 2018

asturmlechner committed R486:e854f357f403: Make Qt5Network conditional on BUILD_TESTS (authored by asturmlechner).
Make Qt5Network conditional on BUILD_TESTS
Jun 6 2018, 9:21 AM
asturmlechner closed D12129: Make Qt5Network conditional on BUILD_TESTS.
Jun 6 2018, 9:21 AM

Jun 3 2018

asturmlechner added a comment to D12129: Make Qt5Network conditional on BUILD_TESTS.

With split packaging yes.

Jun 3 2018, 12:02 AM

Jun 2 2018

asturmlechner added reviewers for D12129: Make Qt5Network conditional on BUILD_TESTS: sitter, rjvbb.
Jun 2 2018, 3:49 PM

Jun 1 2018

asturmlechner abandoned D7811: Put effectModelTest behind BUILD_TESTING conditional.

Glad this was apparently accepted when done by someone else... https://phabricator.kde.org/D13163

Jun 1 2018, 6:20 PM · KWin

May 31 2018

asturmlechner added a comment to D13255: Make dependency on KF5NetworkManagerQt optional.

(this is me forwarding a Gentoo user contribution)

May 31 2018, 9:23 PM · Plasma
asturmlechner requested review of D13255: Make dependency on KF5NetworkManagerQt optional.
May 31 2018, 9:23 PM · Plasma

May 29 2018

asturmlechner committed R856:9a4e032c04fd: Respect libdir for Firefox native messaging host manifest (authored by arfrever).
Respect libdir for Firefox native messaging host manifest
May 29 2018, 7:58 AM
asturmlechner closed D13188: Respect libdir for Firefox native messaging host manifest.
May 29 2018, 7:58 AM · Plasma
asturmlechner requested review of D13188: Respect libdir for Firefox native messaging host manifest.
May 29 2018, 7:40 AM · Plasma

May 18 2018

asturmlechner committed R318:8e6f4eecd318: Make target_link_libraries for kdeinit_dolphin PRIVATE (authored by almiller).
Make target_link_libraries for kdeinit_dolphin PRIVATE
May 18 2018, 10:37 PM
asturmlechner closed D12931: Make target_link_libraries for kdeinit_dolphin PRIVATE.
May 18 2018, 10:36 PM · Dolphin
asturmlechner committed R318:b607091c3982: Remove main.cpp from dolphinstatic_SRCS (authored by almiller).
Remove main.cpp from dolphinstatic_SRCS
May 18 2018, 10:36 PM
asturmlechner closed D12929: Remove main.cpp from dolphinstatic_SRCS.
May 18 2018, 10:36 PM · Dolphin

May 16 2018

asturmlechner added a comment to D12761: Allow building kio-nfs against standalone libtirpc.

Works fine for me with libtirpc!

May 16 2018, 8:30 PM · Frameworks, Dolphin
asturmlechner added a reviewer for D12931: Make target_link_libraries for kdeinit_dolphin PRIVATE: Dolphin.
May 16 2018, 8:06 PM · Dolphin
asturmlechner added a reviewer for D12929: Remove main.cpp from dolphinstatic_SRCS: Dolphin.
May 16 2018, 8:06 PM · Dolphin

May 4 2018

asturmlechner added a comment to R181:9d0e6bdc5695: Make building unit tests optional and default-disabled (option WITH_TESTS)..

When you put it like that, yes you're right, The other option I can think of is moving find_package(GoogleMock) to the root CMakeLists.txt and making it non-required, adding tests subdir only if it is found (in addition to BUILD_TESTING=ON. That makes missing gmock non-fatal to users and continues to run the tests on CI with default settings.

May 4 2018, 8:12 PM
asturmlechner added a comment to R181:9d0e6bdc5695: Make building unit tests optional and default-disabled (option WITH_TESTS)..

This is a bit redundant; BUILD_TESTING is defined in KDECMakeSettings.cmake and already used by amarok anyway; you may as well document this variable in building_amarok2_in_home, as it is done in many other KDE projects.

May 4 2018, 8:00 PM

Apr 26 2018

asturmlechner committed R124:e44afadcb39f: Fix build with Qt 5.11 (missing QStyle) (authored by asturmlechner).
Fix build with Qt 5.11 (missing QStyle)
Apr 26 2018, 8:21 PM
asturmlechner closed D12547: Fix build with Qt 5.11 (missing QStyle).
Apr 26 2018, 8:20 PM · Plasma
asturmlechner requested review of D12547: Fix build with Qt 5.11 (missing QStyle).
Apr 26 2018, 8:13 PM · Plasma

Apr 25 2018

asturmlechner committed R321:093e6715c6fe: Fix build with Qt 5.11 (missing QDoubleValidator) (authored by asturmlechner).
Fix build with Qt 5.11 (missing QDoubleValidator)
Apr 25 2018, 9:13 PM
asturmlechner closed D12525: Fix build with Qt 5.11 (missing QDoubleValidator).
Apr 25 2018, 9:13 PM · KDE Edu