Differential D17684

Use KF5_MIN_VERSION instead of KF5_VERSION
ClosedPublic
Actions

Authored by asturmlechner on Dec 19 2018, 1:23 PM.

Details

Reviewers
dvratil
Group Reviewers
KDE PIM
Commits
R42:f5af0d469041: Use KF5_MIN_VERSION instead of KF5_VERSION
Summary

KF5_VERSION is overridden by first KF5 find_package version found result, which may be higher
than other installed Frameworks versions at the time, leading to cmake error.

Diff Detail

Repository
R42 Akonadi Search
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6190
Build 6208: arc lint + arc unit
asturmlechner created this revision.Dec 19 2018, 1:23 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptDec 19 2018, 1:23 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
asturmlechner requested review of this revision.Dec 19 2018, 1:23 PM
asturmlechner added a comment.Dec 19 2018, 1:33 PM

Alternatively we could use KF5_REQUIRED_VERSION, similar to what is used for Qt.

The same issue is present in other PIM packages.

asturmlechner edited the summary of this revision. (Show Details)Dec 19 2018, 1:50 PM
asturmlechner added inline comments.
CMakeLists.txt
60

while at it, any objection to me moving those two lines into the first KF5 find_package modules call?

dvratil accepted this revision.Dec 19 2018, 4:46 PM
dvratil added a subscriber: dvratil.

👍 Move the find_package calls as well.

This revision is now accepted and ready to land.Dec 19 2018, 4:46 PM
asturmlechner updated this revision to Diff 47866.Dec 19 2018, 7:44 PM

Update after review

asturmlechner closed this revision.Dec 20 2018, 8:27 PM

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (10 lines)

Diff 47866

View Options

CMakeLists.txt

Loading...