Build kio_nfs against standalone libtirpc

Authored by asturmlechner on Nov 28 2018, 7:41 AM.



Since glibc-2.26, cmake skipped over nfs when standalone tirpc
was installed in tirpc subdir (as done by Debian, Fedora, Arch, Gentoo...)

Use FindTIRPC and make kio_nfs optional that way
FindTIRPC taken from

Test Plan

Built with libtirpc successfully.

Diff Detail

R320 KIO Extras
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
asturmlechner created this revision.Nov 28 2018, 7:41 AM
Restricted Application added projects: Dolphin, Frameworks. · View Herald TranscriptNov 28 2018, 7:41 AM
Restricted Application added subscribers: kfm-devel, kde-frameworks-devel. · View Herald Transcript
asturmlechner requested review of this revision.Nov 28 2018, 7:41 AM
sitter added a subscriber: sitter.Nov 28 2018, 9:17 AM


I do wonder if we should support ntirpc too though. At a glance it's largely the same finder s/tirpc/ntirpc/. Admittedly I do not know why there are two libs and both seem to actively get commits.


I think we need CheckCXXSymbolExists here. Since we use and link from C++, whether or not the symbols can be found and linked from C is of no importance.


As you are in the code already, maybe replace this abomination with a configure_file? 😉

sitter accepted this revision.Feb 26 2020, 11:23 AM

Fine by me to land as-is, it can't be worse than what the current state of afairs in master is... which is to say in master nothing is working for me :'<

This revision is now accepted and ready to land.Feb 26 2020, 11:23 AM
This revision was automatically updated to reflect the committed changes.