Build kio_nfs against standalone libtirpc
Needs ReviewPublic

Authored by asturmlechner on Wed, Nov 28, 7:41 AM.

Details

Reviewers
dfaure
rdieter
Group Reviewers
Dolphin
Summary

Since glibc-2.26, cmake skipped over nfs when standalone tirpc
was installed in tirpc subdir (as done by Debian, Fedora, Arch, Gentoo...)

Use FindTIRPC and make kio_nfs optional that way
FindTIRPC taken from https://phabricator.kde.org/D12761

Test Plan

Built with libtirpc successfully.

Diff Detail

Repository
R320 KIO Extras
Branch
kio_nfs
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5459
Build 5477: arc lint + arc unit
asturmlechner created this revision.Wed, Nov 28, 7:41 AM
Restricted Application added projects: Dolphin, Frameworks. · View Herald TranscriptWed, Nov 28, 7:41 AM
Restricted Application added subscribers: kfm-devel, kde-frameworks-devel. · View Herald Transcript
asturmlechner requested review of this revision.Wed, Nov 28, 7:41 AM
sitter added a subscriber: sitter.Wed, Nov 28, 9:17 AM

LGTM

I do wonder if we should support ntirpc too though. At a glance it's largely the same finder s/tirpc/ntirpc/. Admittedly I do not know why there are two libs and both seem to actively get commits.

nfs/CMakeLists.txt
2

I think we need CheckCXXSymbolExists here. Since we use and link from C++, whether or not the symbols can be found and linked from C is of no importance.

15–26

As you are in the code already, maybe replace this abomination with a configure_file? 😉