kfunk (Kevin Funk)
Software Engineer

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Jun 12 2015, 1:04 PM (165 w, 5 d)
Availability
Available

Recent Activity

Today

kfunk accepted D14742: TestKTextEditorPluginIntegration: add QEXPECT_FAIL for mainwindow yet alive.
Wed, Aug 15, 9:19 AM · KDevelop
kfunk added a comment to D14750: Fix problems with output filters in StandardOutputView plugin.

If these changes pass the review, I'd like to also make a little refactoring to this code consisting of using one QMap with structs containing pointers to corresponding view, filter and proxy model instead of 3 QMaps with the same keys in current code. Did I get it right that I should do these changes in separate patch?

Wed, Aug 15, 9:06 AM · KDevelop

Mon, Jul 30

kfunk accepted D14492: Use API style foo() or createFoo(), not getFoo().

Well, why not ;)

Mon, Jul 30, 9:11 PM · KDevelop

Fri, Jul 20

kfunk accepted D14235: Fix QStringBuilder taking reference to temporary due to auto.

This does fix https://bugs.kde.org/show_bug.cgi?id=394055, doesn't it? If so please reference it in the commit message.

Fri, Jul 20, 9:46 AM · KDevelop

Thu, Jul 19

kfunk committed R32:319a0152dd0d: Merge remote-tracking branch 'origin/5.2' (authored by kfunk).
Merge remote-tracking branch 'origin/5.2'
Thu, Jul 19, 5:40 AM
kfunk committed R32:8d14c3216b51: Port away from deprecated KIO::UDSEntry::insert() (authored by kossebau).
Port away from deprecated KIO::UDSEntry::insert()
Thu, Jul 19, 5:39 AM
kfunk closed D14203: Port away from deprecated KIO::UDSEntry::insert().
Thu, Jul 19, 5:39 AM · KDevelop
kfunk accepted D14203: Port away from deprecated KIO::UDSEntry::insert().
Thu, Jul 19, 5:34 AM · KDevelop
kfunk accepted D14220: Fix a typo in the Settings dialog of Heaptrack plugin.
Thu, Jul 19, 5:30 AM · KDevelop

Wed, Jul 18

kfunk accepted D14205: Drop code variants for Qt < 5.5.
Wed, Jul 18, 1:22 PM · KDevelop
kfunk accepted D14206: Add more strict QT definitions.
Wed, Jul 18, 1:22 PM · KDevelop
kfunk accepted D13900: Disable class-memaccess compiler warnings where not wanted.

Though for qtcreator-libs/ I'd probably disable the warning at the build system level, for that particular library. As we don't want to modify 3rdparty code, ideally.

Wed, Jul 18, 9:01 AM · KDevelop

Jul 11 2018

kfunk accepted D14032: make syntax highlighting examples more valid C/C++.
Jul 11 2018, 7:18 AM · KDevelop

Jul 9 2018

kfunk accepted D13938: Generate code that uses nullptr & override.
Jul 9 2018, 7:16 AM · KDevelop

Jul 6 2018

kfunk added a comment to D13900: Disable class-memaccess compiler warnings where not wanted.

What was the exact warning message to begin with? Can't this be fixed differently (i.e. without using the PP)?

Jul 6 2018, 7:53 AM · KDevelop

Jul 2 2018

kfunk accepted D6060: platform-specific document switcher default shortcuts.
Jul 2 2018, 8:30 AM · KDevelop
kfunk accepted D13832: Fix mtime for tar command and use numeric user/group.
Jul 2 2018, 8:29 AM · KDevelop

Jun 14 2018

kfunk committed R32:6adb73faa652: Merge remote-tracking branch 'origin/5.2' (authored by kfunk).
Merge remote-tracking branch 'origin/5.2'
Jun 14 2018, 12:28 PM
kfunk accepted D13518: Speedup nsis generation by using nsis.
Jun 14 2018, 11:50 AM

Jun 8 2018

kfunk committed R14:375b9db89edb: Minor: Remove dead code (authored by kfunk).
Minor: Remove dead code
Jun 8 2018, 2:50 PM

Jun 7 2018

kfunk committed R877:e7c192a56dbd: ruqola: No longer depends on KIO (authored by kfunk).
ruqola: No longer depends on KIO
Jun 7 2018, 12:00 PM
kfunk committed R865:453949ec4a16: Minor: Respect KDE HIG for strings (authored by kfunk).
Minor: Respect KDE HIG for strings
Jun 7 2018, 9:51 AM
kfunk committed R865:384dc9366e23: Minor: Fix typo: Annoucement (authored by kfunk).
Minor: Fix typo: Annoucement
Jun 7 2018, 9:46 AM
kfunk committed R865:77a63e370a3f: Minor: Respect KDE HIG for strings (authored by kfunk).
Minor: Respect KDE HIG for strings
Jun 7 2018, 9:46 AM
kfunk committed R865:ec1e772e0640: Minor: Fix indentation (authored by kfunk).
Minor: Fix indentation
Jun 7 2018, 9:46 AM
kfunk committed R865:5f7ef5820394: MessageLine: Several improvements to key handling (authored by kfunk).
MessageLine: Several improvements to key handling
Jun 7 2018, 9:14 AM
kfunk committed R865:c8479ee11e59: MessageLine: Highlight current item in popup (authored by kfunk).
MessageLine: Highlight current item in popup
Jun 7 2018, 9:14 AM

Jun 6 2018

kfunk committed R32:7945dcf754f3: Merge remote-tracking branch 'origin/5.2' (authored by kfunk).
Merge remote-tracking branch 'origin/5.2'
Jun 6 2018, 8:17 PM
kfunk committed R32:27f2d0ca0106: Add KDEVPLATFORMSHELL_EXPORT annotations to ProblemStoreNode classes. (authored by arrowd).
Add KDEVPLATFORMSHELL_EXPORT annotations to ProblemStoreNode classes.
Jun 6 2018, 8:17 PM
kfunk closed D13387: Add KDEVPLATFORMSHELL_EXPORT annotations to ProblemStoreNode classes..
Jun 6 2018, 8:17 PM · KDevelop
kfunk accepted D13387: Add KDEVPLATFORMSHELL_EXPORT annotations to ProblemStoreNode classes..
Jun 6 2018, 8:14 PM · KDevelop

May 22 2018

kfunk committed R165:8a1ba5153ea5: Fix compilation error (authored by kfunk).
Fix compilation error
May 22 2018, 9:17 AM
kfunk committed R32:13a71cea4596: Merge remote-tracking branch 'origin/5.2' (authored by kfunk).
Merge remote-tracking branch 'origin/5.2'
May 22 2018, 8:46 AM
kfunk committed R52:16189cc3cddd: Merge remote-tracking branch 'origin/5.2' (authored by kfunk).
Merge remote-tracking branch 'origin/5.2'
May 22 2018, 8:33 AM
kfunk committed R53:6295c706de73: Merge remote-tracking branch 'origin/5.2' (authored by kfunk).
Merge remote-tracking branch 'origin/5.2'
May 22 2018, 8:30 AM

May 17 2018

kfunk committed R32:8de5aefd2bbd: Merge remote-tracking branch 'origin/5.2' (authored by kfunk).
Merge remote-tracking branch 'origin/5.2'
May 17 2018, 1:07 PM
kfunk committed R32:e960b70b6849: clang: Fix severe memory leak in comment parser (authored by kfunk).
clang: Fix severe memory leak in comment parser
May 17 2018, 9:33 AM
kfunk committed R32:8f29501a5cf6: Merge remote-tracking branch 'origin/5.2' (authored by kfunk).
Merge remote-tracking branch 'origin/5.2'
May 17 2018, 8:58 AM
kfunk committed R32:4b0201a7cfa3: Minor: Fix -Wunused-lambda-capture warning (authored by kfunk).
Minor: Fix -Wunused-lambda-capture warning
May 17 2018, 8:57 AM
kfunk committed R32:4fd9a30888bd: Update copyright year (authored by kfunk).
Update copyright year
May 17 2018, 8:42 AM
kfunk committed R32:dadd168e1341: clang-tidy: modernize-use-default-member-init run (authored by kfunk).
clang-tidy: modernize-use-default-member-init run
May 17 2018, 8:42 AM
kfunk committed R32:38a6a5d78459: clang: Factor out bench function into own file (authored by kfunk).
clang: Factor out bench function into own file
May 17 2018, 8:23 AM
kfunk committed R32:989e9cd47ffc: clang Fix test_duchain:testComments (authored by kfunk).
clang Fix test_duchain:testComments
May 17 2018, 8:02 AM
kfunk committed R32:0ee5d4fad9ab: Merge remote-tracking branch 'origin/5.2' into HEAD (authored by kfunk).
Merge remote-tracking branch 'origin/5.2' into HEAD
May 17 2018, 7:23 AM
kfunk committed R52:84d26a02fc0d: CMake: Fix version setup (authored by kfunk).
CMake: Fix version setup
May 17 2018, 6:38 AM
kfunk committed R52:cec37013b3f5: Merge remote-tracking branch 'origin/5.2' (authored by kfunk).
Merge remote-tracking branch 'origin/5.2'
May 17 2018, 6:29 AM

May 16 2018

kfunk committed R32:06cbebf36cfa: KDevelop : support whitespace between the '#' and 'include' (or 'import') (authored by rjvbb).
KDevelop : support whitespace between the '#' and 'include' (or 'import')
May 16 2018, 8:20 AM
kfunk closed D12903: KDevelop : support whitespace between the '#' and 'include' (or 'import').
May 16 2018, 8:20 AM · KDevelop
kfunk accepted D12903: KDevelop : support whitespace between the '#' and 'include' (or 'import').

LGTM

May 16 2018, 7:26 AM · KDevelop

May 8 2018

kfunk committed R32:ee5e92458a0d: FindClang: More minor fixes (authored by kfunk).
FindClang: More minor fixes
May 8 2018, 11:39 AM
kfunk committed R32:36bd5b406ad9: test_problems: Add some debugging aid (authored by kfunk).
test_problems: Add some debugging aid
May 8 2018, 11:39 AM
kfunk committed R32:09c0504fe5bf: clang: Do not create GLOBAL IMPORTED targets (authored by kfunk).
clang: Do not create GLOBAL IMPORTED targets
May 8 2018, 7:36 AM
kfunk committed R32:219ae842ff0b: clang: CLANG_LIBCLANG_LIB is no more (authored by kfunk).
clang: CLANG_LIBCLANG_LIB is no more
May 8 2018, 6:50 AM
kfunk committed R32:4612688184ca: clang: Force linking against full lib path (authored by kfunk).
clang: Force linking against full lib path
May 8 2018, 6:47 AM
kfunk committed R32:a278fffd13c0: test_docker: Dont crash when docker unavailable (authored by kfunk).
test_docker: Dont crash when docker unavailable
May 8 2018, 6:47 AM
kfunk committed R32:2f324baaf220: test_docker: Needs KDevGenericManager (authored by kfunk).
test_docker: Needs KDevGenericManager
May 8 2018, 6:47 AM
kfunk added a comment to R32:ab2fcd3b2789: shell: Display generic project managers again.

Thanks for noticing, Max!

May 8 2018, 3:58 AM

Apr 27 2018

kfunk committed R286:b680861aa2ed: extractors: Hide warnings from system headers (authored by kfunk).
extractors: Hide warnings from system headers
Apr 27 2018, 6:04 AM
kfunk closed D9408: extractors: Hide warnings from system headers.
Apr 27 2018, 6:04 AM · Baloo, Frameworks
kfunk updated the diff for D9408: extractors: Hide warnings from system headers.

Add PRIVATE

Apr 27 2018, 5:11 AM · Baloo, Frameworks

Apr 26 2018

kfunk raised a concern with R286:037208a787e0: ffmpegextractor: Silence deprecation warnings.

Concern by @jriddell on kde-frameworks ML:

Apr 26 2018, 6:31 AM
kfunk added a reviewer for D9408: extractors: Hide warnings from system headers: mgallien.
Apr 26 2018, 6:28 AM · Baloo, Frameworks
kfunk updated the diff for D9408: extractors: Hide warnings from system headers.

Rebased

Apr 26 2018, 6:28 AM · Baloo, Frameworks
kfunk committed R206:f1526b4c2335: Minor: Fix string, respect KDE HIG (authored by kfunk).
Minor: Fix string, respect KDE HIG
Apr 26 2018, 6:06 AM
kfunk committed R81:7c90b64f8a3c: Minor: Fix string, respect KDE HIG (authored by kfunk).
Minor: Fix string, respect KDE HIG
Apr 26 2018, 6:04 AM

Apr 24 2018

kfunk committed R877:f8f7afe25479: nsis: Clear cache after install (authored by kfunk).
nsis: Clear cache after install
Apr 24 2018, 7:36 AM
kfunk committed R877:31981621b446: kdev-python: Needs python dlls (authored by kfunk).
kdev-python: Needs python dlls
Apr 24 2018, 7:36 AM
kfunk committed R877:e34cf4cb730e: Revert "Akonadiconsole: temporarily disable some deps we can't compile yet" (authored by kfunk).
Revert "Akonadiconsole: temporarily disable some deps we can't compile yet"
Apr 24 2018, 7:36 AM
kfunk added a reverting change for R877:0a43d3a32b39: Akonadiconsole: temporarily disable some deps we can't compile yet: R877:e34cf4cb730e: Revert "Akonadiconsole: temporarily disable some deps we can't compile yet".
Apr 24 2018, 7:36 AM
kfunk committed R138:9f8fd346e340: Fix some typos (authored by kfunk).
Fix some typos
Apr 24 2018, 6:44 AM

Apr 23 2018

kfunk committed R436:fd046f011dc6: clang-tidy: modernize-use-nullptr (authored by kfunk).
clang-tidy: modernize-use-nullptr
Apr 23 2018, 8:55 PM
kfunk committed R436:58022184d56d: clang-tidy: modernize-use-override run (authored by kfunk).
clang-tidy: modernize-use-override run
Apr 23 2018, 8:55 PM
kfunk committed R436:dfe28778d5da: CMake: Fix AUTOMOC warnings (authored by kfunk).
CMake: Fix AUTOMOC warnings
Apr 23 2018, 8:45 PM

Apr 19 2018

kfunk committed R204:bb36f84e8075: mainwidget: Add space after "Search..." (authored by kfunk).
mainwidget: Add space after "Search..."
Apr 19 2018, 12:22 PM
kfunk committed R206:d9798b0350aa: kmmainwidget: Add space after "Search..." (authored by kfunk).
kmmainwidget: Add space after "Search..."
Apr 19 2018, 12:21 PM
kfunk committed R32:16e020808ae5: Also handle -std=gnu++... as C++ (authored by mwolff).
Also handle -std=gnu++... as C++
Apr 19 2018, 7:06 AM

Apr 18 2018

kfunk added a comment to D12279: shell: Display generic project managers again.

Fixes things for me.

Please to 5.2 branch.

@brauch @kfunk This fixes a regression introduced by 3a74e103e03afea5946e96d12540ce32cb2f67bc part of 5.2.2. So IMHO would be good to move the tag and include this patch as well for the release.

Apr 18 2018, 12:56 PM
kfunk committed R32:ab2fcd3b2789: shell: Display generic project managers again (authored by mschwarz).
shell: Display generic project managers again
Apr 18 2018, 12:55 PM
kfunk closed D12279: shell: Display generic project managers again.
Apr 18 2018, 12:55 PM

Apr 17 2018

kfunk committed R983:f1169ea84993: Fix compilation under Windows/MSVC (authored by kfunk).
Fix compilation under Windows/MSVC
Apr 17 2018, 9:12 AM
kfunk committed R983:41343dd9422e: Disable CC integration properly, fix compile error (authored by kfunk).
Disable CC integration properly, fix compile error
Apr 17 2018, 9:01 AM
kfunk committed R983:ec977ac6c5c4: Do not build ccInstHelper.cpp for now (authored by kfunk).
Do not build ccInstHelper.cpp for now
Apr 17 2018, 8:58 AM
kfunk committed R983:24c3744fe1af: clang-tidy: modernize-use-nullptr run (authored by kfunk).
clang-tidy: modernize-use-nullptr run
Apr 17 2018, 8:54 AM
kfunk committed R983:14fe4c575c99: Only pass -Wno-comment in case compiler is Clang (authored by kfunk).
Only pass -Wno-comment in case compiler is Clang
Apr 17 2018, 8:52 AM
kfunk committed R983:df4d12846c13: Add basic .gitignore (authored by kfunk).
Add basic .gitignore
Apr 17 2018, 8:50 AM
kfunk committed R983:cfe1d9d33bfc: clang-tidy: modernize-use-override run (authored by kfunk).
clang-tidy: modernize-use-override run
Apr 17 2018, 8:50 AM
kfunk committed R877:d828b0514bd1: Add package for kdiff3 (authored by kfunk).
Add package for kdiff3
Apr 17 2018, 8:47 AM
kfunk committed R42:7d340ec4b163: Make compile under MSVC (authored by kfunk).
Make compile under MSVC
Apr 17 2018, 8:27 AM
kfunk committed R877:48637c4ec208: kmailtransport needs ksmtp (authored by kfunk).
kmailtransport needs ksmtp
Apr 17 2018, 7:19 AM
kfunk committed R877:d9bf2df2a9d4: kholidays is now a tier1 framework (authored by kfunk).
kholidays is now a tier1 framework
Apr 17 2018, 7:14 AM
kfunk committed R877:05a3ebc9b755: kdsoap: Update to new 1.7.0 release (authored by kfunk).
kdsoap: Update to new 1.7.0 release
Apr 17 2018, 6:26 AM

Apr 11 2018

kfunk committed R244:53f44072c70a: Fix compiler warning under Clang (authored by kfunk).
Fix compiler warning under Clang
Apr 11 2018, 6:39 PM
kfunk closed D12112: Fix compiler warning under Clang.
Apr 11 2018, 6:39 PM · Frameworks
kfunk updated the diff for D12112: Fix compiler warning under Clang.

Address concerns. I knew why I put this up for review. /me grabs another coffee...

Apr 11 2018, 2:15 PM · Frameworks
kfunk requested review of D12112: Fix compiler warning under Clang.
Apr 11 2018, 1:02 PM · Frameworks
kfunk committed R39:40d801599549: clang-tidy: modernize-use-default-member-init run (authored by kfunk).
clang-tidy: modernize-use-default-member-init run
Apr 11 2018, 7:44 AM
kfunk closed D11610: clang-tidy: modernize-use-default-member-init run.
Apr 11 2018, 7:44 AM · Frameworks, Kate
kfunk accepted D12100: allow elisa to be built from the stable 0.1 branch and default to it.
Apr 11 2018, 6:45 AM

Apr 10 2018

kfunk accepted D11948: [KFileWidget] Hardcode example user name.

Makes sense to me. Go for it.

Apr 10 2018, 4:17 PM · Frameworks
kfunk committed R32:a98b60b03d79: Port away from deprecated KDeclarative API (authored by kfunk).
Port away from deprecated KDeclarative API
Apr 10 2018, 6:35 AM