kfunk (Kevin Funk)
Software Engineer

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jun 12 2015, 1:04 PM (258 w, 3 d)
Availability
Available

Recent Activity

Mon, May 18

kfunk committed R865:d2dce677cb0b: Make compile against Qt 5.12 (authored by kfunk).
Make compile against Qt 5.12
Mon, May 18, 6:17 AM

Tue, May 5

kfunk committed R165:d4fff010615e: Merge remote-tracking branch 'origin/release/20.04' (authored by kfunk).
Merge remote-tracking branch 'origin/release/20.04'
Tue, May 5, 6:35 AM
kfunk committed R165:c06e40974f26: Windows: Handle QLocalSocket behavior gracefully (authored by kfunk).
Windows: Handle QLocalSocket behavior gracefully
Tue, May 5, 6:34 AM
kfunk closed D29266: Windows: Handle QLocalSocket behavior gracefully.
Tue, May 5, 6:34 AM · KDE PIM

Thu, Apr 30

kfunk committed R877:5aef9c0107c6: kdesignerplugin: kdewebkit & kplotting dep are no longer needed (authored by kfunk).
kdesignerplugin: kdewebkit & kplotting dep are no longer needed
Thu, Apr 30, 12:41 PM
kfunk committed R877:1e7983808831: Akonadi: Trigger rebuild (authored by kfunk).
Akonadi: Trigger rebuild
Thu, Apr 30, 12:18 PM
kfunk committed R993:6b98e6309775: Add more akonadi pkgs to cache (authored by kfunk).
Add more akonadi pkgs to cache
Thu, Apr 30, 9:00 AM

Wed, Apr 29

kfunk committed R877:7a46f8863739: Add Akonadi patch (authored by kfunk).
Add Akonadi patch
Wed, Apr 29, 11:46 AM
kfunk updated the diff for D29266: Windows: Handle QLocalSocket behavior gracefully.

Update Diff text, too

Wed, Apr 29, 11:34 AM · KDE PIM
kfunk added a comment to D29266: Windows: Handle QLocalSocket behavior gracefully.

QSignalBlocker ?

Wed, Apr 29, 10:38 AM · KDE PIM
kfunk updated the diff for D29266: Windows: Handle QLocalSocket behavior gracefully.

Fix typos, add kudos for David ;)

Wed, Apr 29, 10:01 AM · KDE PIM
kfunk added a comment to D29266: Windows: Handle QLocalSocket behavior gracefully.

Uhm, sorry, totally forgot to mention that you actually came up with that idea to begin with. Will add that when pushing!

Wed, Apr 29, 9:03 AM · KDE PIM

Tue, Apr 28

kfunk added reviewers for D29266: Windows: Handle QLocalSocket behavior gracefully: dfaure, mlaurent.
Tue, Apr 28, 7:14 PM · KDE PIM
kfunk requested review of D29266: Windows: Handle QLocalSocket behavior gracefully.
Tue, Apr 28, 7:14 PM · KDE PIM
kfunk committed R877:153e845142ad: akonadi-contacts: Reapply patch (authored by kfunk).
akonadi-contacts: Reapply patch
Tue, Apr 28, 12:50 PM
kfunk committed R865:7b9dd4d3ec2f: Fix build (authored by kfunk).
Fix build
Tue, Apr 28, 10:53 AM

Mon, Apr 27

kfunk committed R877:079c827e9f2a: akonadi: Allow to build w/o kdesignerplugin (authored by kfunk).
akonadi: Allow to build w/o kdesignerplugin
Mon, Apr 27, 1:15 PM

Apr 20 2020

kfunk committed R877:7bda7544fb23: libkdepim: Needs kcmutils (authored by kfunk).
libkdepim: Needs kcmutils
Apr 20 2020, 1:43 PM

Apr 17 2020

kfunk committed R199:e87e64897c0a: Always make libkdepim a required depencency (authored by kfunk).
Always make libkdepim a required depencency
Apr 17 2020, 1:43 PM
kfunk committed R877:609433bbba7e: libkdepim: Fix option name, now useAkonadiSearch (authored by kfunk).
libkdepim: Fix option name, now useAkonadiSearch
Apr 17 2020, 1:37 PM
kfunk committed R199:8105b2e5f9cd: Always make libkdepim a required depencency (authored by kfunk).
Always make libkdepim a required depencency
Apr 17 2020, 1:19 PM
kfunk committed R199:ab01f1847986: Fix MSVC build (authored by kfunk).
Fix MSVC build
Apr 17 2020, 12:33 PM
kfunk committed R877:e1822663abde: akonadiconsole: Align deps with upstream CMakeLists.txt (authored by kfunk).
akonadiconsole: Align deps with upstream CMakeLists.txt
Apr 17 2020, 11:49 AM
kfunk committed R877:063d58ac372a: libkdepim: Make akonadi-search dep optional (authored by kfunk).
libkdepim: Make akonadi-search dep optional
Apr 17 2020, 11:49 AM
kfunk committed R459:d708e279ea27: Merge remote-tracking branch 'origin/release/20.04' (authored by kfunk).
Merge remote-tracking branch 'origin/release/20.04'
Apr 17 2020, 11:39 AM
kfunk committed R459:f2cf87b6d976: Merge remote-tracking branch 'origin/release/19.12' into release/20.04 (authored by kfunk).
Merge remote-tracking branch 'origin/release/19.12' into release/20.04
Apr 17 2020, 11:37 AM
kfunk committed R459:32a33fd26833: Revert "Fix windows build" (authored by kfunk).
Revert "Fix windows build"
Apr 17 2020, 11:20 AM
kfunk added a reverting change for R459:2f552ac57377: Fix windows build: R459:32a33fd26833: Revert "Fix windows build".
Apr 17 2020, 11:20 AM
kfunk closed D28759: Akonadi-contacts: define BUILD_TESTING in order that CONTACTEDITOR_TESTS_EXPORT is properly defined.
Apr 17 2020, 11:20 AM · KDE PIM
kfunk commandeered D28759: Akonadi-contacts: define BUILD_TESTING in order that CONTACTEDITOR_TESTS_EXPORT is properly defined.
Apr 17 2020, 11:19 AM · KDE PIM
kfunk updated the diff for D28759: Akonadi-contacts: define BUILD_TESTING in order that CONTACTEDITOR_TESTS_EXPORT is properly defined.

Commit message:

Apr 17 2020, 10:25 AM · KDE PIM
kfunk updated the diff for D28759: Akonadi-contacts: define BUILD_TESTING in order that CONTACTEDITOR_TESTS_EXPORT is properly defined.

Revert original patch causing the breakage

Apr 17 2020, 9:57 AM · KDE PIM

Mar 25 2020

kfunk committed R865:bb545f924791: cmake: Needs KUserFeedback 0.9.90 (authored by kfunk).
cmake: Needs KUserFeedback 0.9.90
Mar 25 2020, 6:41 AM

Mar 9 2020

kfunk committed R865:aef09481fbb7: Make compile with older Qt 5.12 again (authored by kfunk).
Make compile with older Qt 5.12 again
Mar 9 2020, 10:43 AM

Feb 14 2020

kfunk accepted D27387: Re-enable auto-reconnect, after fixing logout..

Looks good to me, but didn't test.

Feb 14 2020, 7:45 AM

Feb 12 2020

kfunk committed R865:7929384beb80: Do not create User class on heap (authored by kfunk).
Do not create User class on heap
Feb 12 2020, 9:15 PM
kfunk closed D27349: Do not create User class on heap.
Feb 12 2020, 9:15 PM
kfunk requested review of D27349: Do not create User class on heap.
Feb 12 2020, 3:28 PM
kfunk committed R865:d598cc543659: Minor: Fix a few -Wunused-lambda-capture (authored by kfunk).
Minor: Fix a few -Wunused-lambda-capture
Feb 12 2020, 3:28 PM
kfunk committed R865:5032df9a6c81: message: Never turn an Image into NormalText (authored by kfunk).
message: Never turn an Image into NormalText
Feb 12 2020, 11:43 AM
kfunk closed D27341: message: Never turn an Image into NormalText.
Feb 12 2020, 11:43 AM
kfunk committed R865:ac8aa3f5ca11: Fix memory leak (authored by kfunk).
Fix memory leak
Feb 12 2020, 9:56 AM
kfunk added a reviewer for D27341: message: Never turn an Image into NormalText: dfaure.

Note: This seems to fix the Gify previews in both ruqola + ruqolaqml.

Feb 12 2020, 9:29 AM
kfunk committed R865:7498bf03e011: reaction: Fix tenses (authored by kfunk).
reaction: Fix tenses
Feb 12 2020, 8:58 AM
kfunk updated the diff for D27341: message: Never turn an Image into NormalText.

Fix tests

Feb 12 2020, 8:51 AM
kfunk added a reviewer for D27341: message: Never turn an Image into NormalText: mlaurent.
Feb 12 2020, 8:44 AM
kfunk committed R865:93968a0f1cf8: qml: Fix missing negation (authored by kfunk).
qml: Fix missing negation
Feb 12 2020, 8:44 AM
kfunk requested review of D27341: message: Never turn an Image into NormalText.
Feb 12 2020, 8:43 AM
kfunk committed R865:500c8e32892e: RocketChatAccount: Try to reduce delegating funcs (authored by kfunk).
RocketChatAccount: Try to reduce delegating funcs
Feb 12 2020, 7:26 AM
kfunk closed D27317: RocketChatAccount: Try to reduce delegating funcs.
Feb 12 2020, 7:26 AM

Feb 11 2020

kfunk committed R865:a4d140a85569: qml: Remove unused PersonsListView (authored by kfunk).
qml: Remove unused PersonsListView
Feb 11 2020, 2:01 PM
kfunk committed R865:fc201826cf02: qml: Greatly simplify MessageMenu (authored by kfunk).
qml: Greatly simplify MessageMenu
Feb 11 2020, 2:01 PM
kfunk committed R865:299c18a2c690: qml: Fix a few typos in file names, ids (authored by kfunk).
qml: Fix a few typos in file names, ids
Feb 11 2020, 2:01 PM
kfunk committed R865:5a55d811049b: qml: Use ClickableLabel more (authored by kfunk).
qml: Use ClickableLabel more
Feb 11 2020, 2:01 PM
kfunk committed R865:1c6e26504d0f: qml: Introduce Button.qml (authored by kfunk).
qml: Introduce Button.qml
Feb 11 2020, 2:01 PM
kfunk committed R865:6027172a24b7: Minor: Fix redundant init of member (authored by kfunk).
Minor: Fix redundant init of member
Feb 11 2020, 11:44 AM
kfunk committed R865:a62aae06ed54: Modernize code: Use override where possible (authored by kfunk).
Modernize code: Use override where possible
Feb 11 2020, 11:44 AM
kfunk committed R865:1d7c00c876b7: qml: Fix warning about anchors in layouts (authored by kfunk).
qml: Fix warning about anchors in layouts
Feb 11 2020, 11:44 AM
kfunk requested review of D27317: RocketChatAccount: Try to reduce delegating funcs.
Feb 11 2020, 11:44 AM
kfunk committed R865:ba76b1b27af0: qml: Use disabledTextColor instead of opacity 0.5 (authored by kfunk).
qml: Use disabledTextColor instead of opacity 0.5
Feb 11 2020, 8:22 AM
kfunk committed R865:d2f8a9eeb868: Change message background on mouse hover (authored by alessandro).
Change message background on mouse hover
Feb 11 2020, 8:04 AM
kfunk closed D27248: Change message background on mouse hover.
Feb 11 2020, 8:04 AM
kfunk accepted D27248: Change message background on mouse hover.
Feb 11 2020, 8:02 AM

Feb 10 2020

kfunk committed R865:1bcf8e0cbdbf: qml: Introduce ClickableLabel (authored by kfunk).
qml: Introduce ClickableLabel
Feb 10 2020, 8:34 PM
kfunk committed R865:5cea60083604: qml: UserMessage: Improve look of username/alias (authored by kfunk).
qml: UserMessage: Improve look of username/alias
Feb 10 2020, 8:34 PM
kfunk committed R865:40897806c7c1: cmake: Use find_package(... CONFIG) more (authored by kfunk).
cmake: Use find_package(... CONFIG) more
Feb 10 2020, 8:34 PM
kfunk added a comment to D27248: Change message background on mouse hover.

Okay, could you please rebase that patch? No longer applies.

Feb 10 2020, 7:27 PM
kfunk committed R865:f305535cb004: cmake: Prefer using #cmakedefine01 (authored by kfunk).
cmake: Prefer using #cmakedefine01
Feb 10 2020, 7:15 PM
kfunk committed R865:b7cb605efe27: cmake: Simplify CMake code a bit (authored by kfunk).
cmake: Simplify CMake code a bit
Feb 10 2020, 7:15 PM
kfunk committed R865:648065164873: Minor: Fix warning about redundant 'static' (authored by kfunk).
Minor: Fix warning about redundant 'static'
Feb 10 2020, 7:15 PM
kfunk committed R865:ccde003a3e83: Improve markdownToRichText (authored by kfunk).
Improve markdownToRichText
Feb 10 2020, 3:10 PM
kfunk closed D27286: Improve markdownToRichText.
Feb 10 2020, 3:10 PM
kfunk committed R865:4d85cfe2ca66: Update .gitignore (authored by kfunk).
Update .gitignore
Feb 10 2020, 2:45 PM
kfunk updated the diff for D27286: Improve markdownToRichText.

Fix another typo...

Feb 10 2020, 2:44 PM
kfunk updated the diff for D27286: Improve markdownToRichText.

Improve naming in test

Feb 10 2020, 2:34 PM
kfunk updated the diff for D27286: Improve markdownToRichText.

Typo fix

Feb 10 2020, 2:32 PM
kfunk added a reviewer for D27286: Improve markdownToRichText: dfaure.
Feb 10 2020, 2:29 PM
kfunk added a reviewer for D27286: Improve markdownToRichText: mlaurent.

Not sure I like this change myself but it fixes support for [](). Other ideas welcome.

Feb 10 2020, 2:27 PM
kfunk requested review of D27286: Improve markdownToRichText.
Feb 10 2020, 2:26 PM
kfunk committed R865:af1ae039d2f3: qml: RoomsView: Dont always follow highlight (authored by kfunk).
qml: RoomsView: Dont always follow highlight
Feb 10 2020, 9:48 AM
kfunk committed R865:e18f3457a59b: Remove extra vertical space from FancyMessageDelegate, message items include… (authored by alessandro).
Remove extra vertical space from FancyMessageDelegate, message items include…
Feb 10 2020, 7:53 AM
kfunk closed D27256: Remove extra vertical space from FancyMessageDelegate, message items include their own margins now.
Feb 10 2020, 7:53 AM
kfunk accepted D27256: Remove extra vertical space from FancyMessageDelegate, message items include their own margins now.
Feb 10 2020, 7:53 AM
kfunk committed R865:8357b7c85ce8: Adjust message layout (authored by alessandro).
Adjust message layout
Feb 10 2020, 7:49 AM
kfunk closed D27254: Adjust message layout.
Feb 10 2020, 7:49 AM
kfunk accepted D27254: Adjust message layout.
Feb 10 2020, 7:48 AM
kfunk committed R865:89192d6b942d: Remove Layout/anchor properties from AvatarImage definition and use as needed… (authored by alessandro).
Remove Layout/anchor properties from AvatarImage definition and use as needed…
Feb 10 2020, 7:44 AM
kfunk closed D27253: Remove Layout/anchor properties from AvatarImage definition and use as needed on instances instead.
Feb 10 2020, 7:44 AM
kfunk accepted D27253: Remove Layout/anchor properties from AvatarImage definition and use as needed on instances instead.
Feb 10 2020, 7:44 AM
kfunk committed R865:44d570888415: Make reaction popup transparent when necessary instead of hiding it so the… (authored by alessandro).
Make reaction popup transparent when necessary instead of hiding it so the…
Feb 10 2020, 7:42 AM
kfunk closed D27249: Make reaction popup transparent when necessary instead of hiding it so the layout doesn't change when it's shown.
Feb 10 2020, 7:42 AM
kfunk accepted D27249: Make reaction popup transparent when necessary instead of hiding it so the layout doesn't change when it's shown.
Feb 10 2020, 7:42 AM
kfunk added a comment to D27229: Update message items.

One issue: When hovering through the the chat window the width of the message text is altered, looks a bit cumbersome. maybe it makes sense to just overlay the icon over the message text like RC does?

Feb 10 2020, 7:42 AM
kfunk requested changes to D27248: Change message background on mouse hover.
Feb 10 2020, 7:38 AM
kfunk added a comment to D27244: Make MessageBase an Item instead of a ColumnLayout.

See https://phabricator.kde.org/D27229 (duplicate) for further comments.

Feb 10 2020, 7:31 AM
kfunk committed R865:2176d37b1dd9: Make MessageBase an Item instead of a ColumnLayout (authored by alessandro).
Make MessageBase an Item instead of a ColumnLayout
Feb 10 2020, 7:30 AM
kfunk closed D27244: Make MessageBase an Item instead of a ColumnLayout.
Feb 10 2020, 7:30 AM
kfunk added a comment to D27229: Update message items.

Superseded by https://phabricator.kde.org/D27229

Feb 10 2020, 7:30 AM
kfunk added a comment to D27229: Update message items.

Show reaction button only when hovering on a message

Feb 10 2020, 7:28 AM

Feb 7 2020

kfunk committed R865:9dd0a0a4dd14: qml: MessageLine: Try harder catch key events (authored by kfunk).
qml: MessageLine: Try harder catch key events
Feb 7 2020, 12:04 PM