kfunk (Kevin Funk)
Software Engineer

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Jun 12 2015, 1:04 PM (102 w, 3 d)
Availability
Available

Recent Activity

Today

kfunk accepted D6012: Add asserts to some TokenStreamBase methods, protect against out-of-bounds.

+1, but please add the other asserts, too

Mon, May 29, 3:15 PM
kfunk planned changes to D6005: Properly support clang/gcc as KDECOMPILER.

Does msvc20xx-clang work?

Mon, May 29, 10:14 AM
kfunk requested changes to D5865: Add missing KDE_ENABLE_NAMED_OPERATORS function.

Can't go in as-is, as it breaks compilation on MSVC 2015.

Mon, May 29, 10:07 AM · Build System, Frameworks
kfunk committed R32:b810eee06655: appimage: Build with RelWithDebInfo (authored by kfunk).
appimage: Build with RelWithDebInfo
Mon, May 29, 9:20 AM
kfunk added a reviewer for D6005: Properly support clang/gcc as KDECOMPILER: vonreth.
Mon, May 29, 8:01 AM
kfunk added a comment to D6005: Properly support clang/gcc as KDECOMPILER.

There are a couple of uses of supportsClang in craft.git, wondering if we should just try to get rid off them. Opinions?

Mon, May 29, 8:01 AM
kfunk created D6005: Properly support clang/gcc as KDECOMPILER.
Mon, May 29, 7:58 AM
kfunk committed R138:f3bc0e035fd9: libofx: Simplify check against MSVC compiler (authored by kfunk).
libofx: Simplify check against MSVC compiler
Mon, May 29, 7:25 AM
kfunk committed R138:992d11398493: portage: Enable Frameworks 5.34 (authored by kfunk).
portage: Enable Frameworks 5.34
Mon, May 29, 7:24 AM
kfunk added a comment to D4665: Fix project tree state not being saved.

@bevendorff Your patch seems to cause a bug in KDevelop: https://bugs.kde.org/show_bug.cgi?id=379433 -- care to have a look and fixup your patch?

Mon, May 29, 6:56 AM
kfunk accepted D5995: Fix CompilerFilterStrategy::errorInLine() to handle paths with whitespace.
Mon, May 29, 6:50 AM

Sat, May 27

kfunk committed R138:1d0da3453661: Fix libofx package under MSVC (authored by kfunk).
Fix libofx package under MSVC
Sat, May 27, 8:34 AM

Wed, May 24

kfunk accepted D5959: Simplify _fixCmakeImageDir by using utils code and also handle fixup for QtSDK enabled..
Wed, May 24, 2:35 PM
kfunk closed T3538: Add Breeze Style to AppImage as "Resolved".
Wed, May 24, 1:32 PM · KDevelop
kfunk closed T3538: Add Breeze Style to AppImage, a subtask of T3536: KDevelop AppImage work, as "Resolved".
Wed, May 24, 1:32 PM · KDevelop
kfunk added a comment to T3538: Add Breeze Style to AppImage.

That seems to work on my machine, it'll actually use the Breeze style automatically.

Wed, May 24, 1:32 PM · KDevelop
kfunk added a comment to T3538: Add Breeze Style to AppImage.

https://cgit.kde.org/kdevelop.git/commit/?id=1184a5b46bf9ee3c01a12099a8d7d01b1bf4bcba

Wed, May 24, 1:31 PM · KDevelop
kfunk committed R32:1184a5b46bf9: appimage: Package breeze widget style (authored by kfunk).
appimage: Package breeze widget style
Wed, May 24, 1:29 PM
kfunk committed R32:37003449acf3: appimage: More fixes (authored by kfunk).
appimage: More fixes
Wed, May 24, 1:29 PM
kfunk claimed T3538: Add Breeze Style to AppImage.
Wed, May 24, 12:53 PM · KDevelop
kfunk committed R32:de7808727c74: appimage: Install packages for spelling engines (authored by kfunk).
appimage: Install packages for spelling engines
Wed, May 24, 12:29 PM
kfunk closed T4100: Add sonnet plugins to AppImage as "Resolved" by committing R32:de7808727c74: appimage: Install packages for spelling engines.
Wed, May 24, 12:29 PM · KDevelop
kfunk closed T4100: Add sonnet plugins to AppImage, a subtask of T3536: KDevelop AppImage work, as "Resolved".
Wed, May 24, 12:29 PM · KDevelop
kfunk committed R32:002ecf22408d: appimage: Run install_colorschemes.sh in correct dir (authored by kfunk).
appimage: Run install_colorschemes.sh in correct dir
Wed, May 24, 11:53 AM
kfunk committed R32:ced44a11fa17: appimage: Run .sh script from correct dir (authored by kfunk).
appimage: Run .sh script from correct dir
Wed, May 24, 11:22 AM
kfunk claimed T4100: Add sonnet plugins to AppImage.
Wed, May 24, 10:43 AM · KDevelop
kfunk committed R111:bb556d8cea2f: Fix compilation on CentOS 6 (authored by kfunk).
Fix compilation on CentOS 6
Wed, May 24, 10:39 AM
kfunk closed D5955: Fix compilation on CentOS 6 by committing R111:bb556d8cea2f: Fix compilation on CentOS 6.
Wed, May 24, 10:39 AM · Plasma
kfunk updated the diff for D5955: Fix compilation on CentOS 6.

Conditionally link to librt

Wed, May 24, 10:35 AM · Plasma
kfunk added a comment to D5955: Fix compilation on CentOS 6.

Alright, I now see why this is no longer required under Linux: https://stackoverflow.com/a/32649327/592636

Wed, May 24, 10:26 AM · Plasma
kfunk committed R32:6c7f7901fc80: appimage: Also install color schemes (authored by kfunk).
appimage: Also install color schemes
Wed, May 24, 9:45 AM
kfunk committed R32:795ea4a61b68: appimage: Minor cosmetics (authored by kfunk).
appimage: Minor cosmetics
Wed, May 24, 9:45 AM
kfunk committed R32:5503a383ab6b: appimage: Make script executable (authored by kfunk).
appimage: Make script executable
Wed, May 24, 9:05 AM
kfunk committed R32:209880b18664: appimage: Package libkf5sysguard (authored by kfunk).
appimage: Package libkf5sysguard
Wed, May 24, 9:05 AM
kfunk closed T5878: Package KF5SysGuard as "Resolved" by committing R32:209880b18664: appimage: Package libkf5sysguard.
Wed, May 24, 9:05 AM · KDevelop
kfunk closed T5878: Package KF5SysGuard, a subtask of T3536: KDevelop AppImage work, as "Resolved".
Wed, May 24, 9:04 AM · KDevelop
kfunk added a reviewer for D5955: Fix compilation on CentOS 6: jriddell.
Wed, May 24, 9:01 AM · Plasma
kfunk created D5955: Fix compilation on CentOS 6.
Wed, May 24, 9:00 AM · Plasma
kfunk committed R32:caefbf310155: appimage: Use ninja by default (authored by kfunk).
appimage: Use ninja by default
Wed, May 24, 7:59 AM
kfunk committed R32:787f1f943749: appimage: Don't reclone AppImage repo each time (authored by kfunk).
appimage: Don't reclone AppImage repo each time
Wed, May 24, 7:59 AM
kfunk committed R32:1ed15d49ef2e: appimage: Install ninja (authored by kfunk).
appimage: Install ninja
Wed, May 24, 7:56 AM
kfunk committed R32:74353ce9b86d: appimage: Install unzip (authored by kfunk).
appimage: Install unzip
Wed, May 24, 7:42 AM

Tue, May 23

kfunk committed R138:8381db60577a: kdecoration is released as part of plasma (authored by vonreth).
kdecoration is released as part of plasma
Tue, May 23, 10:23 PM
kfunk committed R51:a16f846cd5ca: Move cmake_minimum_required() to top (authored by kfunk).
Move cmake_minimum_required() to top
Tue, May 23, 9:40 PM
kfunk committed R138:a08f44deb182: kdevelop: Update to 5.1.1 (authored by kfunk).
kdevelop: Update to 5.1.1
Tue, May 23, 8:13 PM
kfunk committed R33:c222f9a33653: Remove the last '\n' when copying from an output view (authored by apol).
Remove the last '\n' when copying from an output view
Tue, May 23, 3:06 PM

Mon, May 22

kfunk added a comment to D5938: Always copy qt plugins and qml when creating NSIS installer.

NullsoftInstallerPackager is not the right place either. This should be done for every packager.

Mon, May 22, 4:09 PM
kfunk committed R33:c24dcef15327: Display local paths as paths rather than as file:/// urls (authored by apol).
Display local paths as paths rather than as file:/// urls
Mon, May 22, 3:07 PM

Mon, May 15

kfunk added a comment to D5865: Add missing KDE_ENABLE_NAMED_OPERATORS function.

LGTM in general. I'll hope to find some time to test on Window, wouldn't want this to be merged before that.

Mon, May 15, 2:51 PM · Build System, Frameworks

Fri, May 12

kfunk accepted D5817: Fix duchain unit tests..

Should this go into 5.1 branch?

Fri, May 12, 9:34 AM

Thu, May 11

kfunk committed R260:ba52d00ee8de: Support Apple OS X' image/x-icns (authored by kfunk).
Support Apple OS X' image/x-icns
Thu, May 11, 9:03 AM
kfunk closed D5789: Support Apple OS X' image/x-icns by committing R260:ba52d00ee8de: Support Apple OS X' image/x-icns.
Thu, May 11, 9:03 AM
kfunk added a comment to D5789: Support Apple OS X' image/x-icns.
In D5789#108405, @kfunk wrote:

Any other places I need to update?

I don't think so; the association now is valid for both.

It is worth noting that some subformats of icns can't be opened by that Qt plugin (tested trying to find some examples, hit http://www.iconarchive.com/tag/mac-icns), but of course it's not a problem for this review.

I'm fine with master; not sure that it could go to 17.04, though (it fixes gwenview not automatically associated to this file in dolphin, konqueror, etc, but not a critical issue, you can always browse the file from gwenview). Thoughts?

Thu, May 11, 9:02 AM

Wed, May 10

kfunk accepted D5666: Default to disabled debug log on Q_LOGGING_CATEGORY calls.
Wed, May 10, 2:10 PM
kfunk accepted D5663: Install a categories file for KDebugSettings.
Wed, May 10, 2:08 PM
kfunk requested changes to D5794: Copy text from NavigationWidget when selecting.

+1 on the incentive. I had that somewhere on my TODO list...

Wed, May 10, 12:56 PM

Tue, May 9

kfunk updated the diff for D5791: Allow to disable blinking cursor completely.

Allow 0, but otherwise keep the lower bound of 200

Tue, May 9, 10:37 PM · Plasma
kfunk added reviewers for D5791: Allow to disable blinking cursor completely: mck182, graesslin.
Tue, May 9, 10:25 PM · Plasma
kfunk added a comment to D5791: Allow to disable blinking cursor completely.

This is so trivial, yet I saw the demand for being able to disable the blinking cursor several times...

Tue, May 9, 10:24 PM · Plasma
kfunk created D5791: Allow to disable blinking cursor completely.
Tue, May 9, 10:23 PM · Plasma
kfunk added a comment to D5789: Support Apple OS X' image/x-icns.

Any other places I need to update?

Tue, May 9, 4:39 PM
kfunk added reviewers for D5789: Support Apple OS X' image/x-icns: ltoscano, sandsmark.
Tue, May 9, 4:39 PM
kfunk created D5789: Support Apple OS X' image/x-icns.
Tue, May 9, 4:38 PM
kfunk committed R33:94c12345276a: EnvironmentConfigureButton: Some sane default size for the dialog (authored by kfunk).
EnvironmentConfigureButton: Some sane default size for the dialog
Tue, May 9, 4:31 PM
kfunk committed R45:4e01b09d1d09: Make sure KF5_FOUND is FALSE when not all components are available (authored by kfunk).
Make sure KF5_FOUND is FALSE when not all components are available
Tue, May 9, 4:15 PM
kfunk added a comment to D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem()..

Okay, then maybe support for the current FreeBSD version is not implemented? I have no idea about FreeBSD, to be honest. But it looks like using this API, and implementing the proper support in QStorageInfo internals would be the appropriate place.

Tue, May 9, 1:48 PM · Frameworks
kfunk committed R33:6803406edacc: Improve some include guards to match file names (authored by kossebau).
Improve some include guards to match file names
Tue, May 9, 10:51 AM
kfunk committed R33:910deab083f8: End CMakeLists.txt files with a newline (authored by kossebau).
End CMakeLists.txt files with a newline
Tue, May 9, 10:51 AM
kfunk committed R32:c1c79f5684f2: Move print from int to unsigned int (authored by patrickelectric).
Move print from int to unsigned int
Tue, May 9, 10:50 AM
kfunk committed R33:7d6e9bae579b: Use https://www.google.com instead of http://www.google.de in google selection… (authored by geetamc).
Use https://www.google.com instead of http://www.google.de in google selection…
Tue, May 9, 10:49 AM
kfunk added a comment to D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem()..

What about http://doc.qt.io/qt-5/qstorageinfo.html#fileSystemType?

Tue, May 9, 10:41 AM · Frameworks

Mon, May 8

kfunk accepted D5766: Change default pkgconfig install path for FreeBSD.

Well, for me that looks good now

Mon, May 8, 6:10 PM · Build System, Frameworks
kfunk accepted D5621: Install xdg mimetype definitions for OpenCL C & CUDA C.
Mon, May 8, 5:51 PM
kfunk committed R37:c0ce7240c790: clang-tidy: Use override where needed (authored by kfunk).
clang-tidy: Use override where needed
Mon, May 8, 3:58 PM
kfunk requested changes to D5766: Change default pkgconfig install path for FreeBSD.
Mon, May 8, 3:27 PM · Build System, Frameworks
kfunk added inline comments to D5766: Change default pkgconfig install path for FreeBSD.
Mon, May 8, 3:25 PM · Build System, Frameworks
kfunk requested changes to D5753: Expose a method to open projects to dbus.

Please use one of the static methods to construct the QUrl, e.g. QUrl::fromUserInput. More explicit.

Mon, May 8, 8:02 AM
kfunk updated subscribers of D5754: Make it possible to open directories from the command line.

LGTM to me in general.

Mon, May 8, 8:00 AM

Tue, May 2

kfunk committed R32:af12015148f8: Merge remote-tracking branch 'origin/5.1' (authored by kfunk).
Merge remote-tracking branch 'origin/5.1'
Tue, May 2, 10:42 PM
kfunk committed R32:6f26b8ea98b8: Fix build for MinGW (authored by kfunk).
Fix build for MinGW
Tue, May 2, 10:40 PM
kfunk accepted D5691: Cleanup 7zip bootstrap.
Tue, May 2, 10:35 PM
kfunk accepted D5690: Annotation bar tooltips: align labels and content, make labels bold.

Phew, complex. But looks fine.

Tue, May 2, 10:03 PM
kfunk accepted D5642: Use 7zip to extract tar files on platforms that support symlinks.
Tue, May 2, 3:41 PM
kfunk added a comment to D5642: Use 7zip to extract tar files on platforms that support symlinks.

Phew, and I still don't like the new string substitution syntax (f-strings?). Will have to get used to it I guess... :)

Tue, May 2, 3:41 PM
kfunk added a comment to D5690: Annotation bar tooltips: align labels and content, make labels bold.

LGTM in general. One issue I can see: Won't work with Right-To-Left languages. Any idea how to properly support them without putting the whole HTML table into i18n(...)...?

Tue, May 2, 2:43 PM
kfunk requested changes to D5642: Use 7zip to extract tar files on platforms that support symlinks.
Tue, May 2, 12:07 PM
kfunk accepted D5640: Improve purpose text for heaptrack/cppcheck deps, use "Recommended".
Tue, May 2, 12:00 PM
kfunk committed R32:07956883951e: Merge remote-tracking branch 'origin/5.1' (authored by kfunk).
Merge remote-tracking branch 'origin/5.1'
Tue, May 2, 11:42 AM
kfunk committed R33:59c652c525b3: Merge remote-tracking branch 'origin/5.1' (authored by kfunk).
Merge remote-tracking branch 'origin/5.1'
Tue, May 2, 11:18 AM
kfunk committed R32:58816635fb31: Use proper icon for batch edit button (authored by kfunk).
Use proper icon for batch edit button
Tue, May 2, 10:57 AM
kfunk committed R32:8d2e18fd889a: Custom defines/includes: Use plain text batch edit (authored by kfunk).
Custom defines/includes: Use plain text batch edit
Tue, May 2, 10:54 AM

Apr 28 2017

kfunk requested changes to D5632: Look for Cppcheck & heaptrack as RUNTIME dependencies.

Uh, careful here. This suggests those binaries are *required* at runtime.

Apr 28 2017, 12:23 PM
kfunk added inline comments to D5485: The OpenCL language is actually called OpenCL C.
Apr 28 2017, 7:36 AM
kfunk committed R32:d27fd44324e6: The OpenCL language is actually called OpenCL C (authored by aaronpuchert).
The OpenCL language is actually called OpenCL C
Apr 28 2017, 7:36 AM

Apr 27 2017

kfunk committed R56:a28c4dd0e1df: KF5: Don't depend on kdeversion.h (authored by kfunk).
KF5: Don't depend on kdeversion.h
Apr 27 2017, 8:40 AM
kfunk added a reviewer for D5609: CMake - fix bug with dropping changed settings for existing build directory: apol.
Apr 27 2017, 8:20 AM
kfunk requested changes to D5491: Improve detection of builtin defines from compiler command.

Waiting for tests for GCC

Apr 27 2017, 8:20 AM
kfunk accepted D5536: Appwizard: fix broken disconnect in ProjectVcsPage.
Apr 27 2017, 8:19 AM
kfunk accepted D5533: Use openDeclaration(Identifier) in QMLJS plugin.

In the meantime, https://phabricator.kde.org/R33:76765692538d3af40374b0c9ae63eb6eb41c53c0 has been reverted. Good to go now?

Apr 27 2017, 8:17 AM
kfunk added inline comments to R33:97a5312772c2: Add openDeclaration(Identifier) overload to AbstractDeclarationBuilder.
Apr 27 2017, 8:15 AM