kfunk (Kevin Funk)
Software Engineer

Projects (6)

User Details

User Since
Jun 12 2015, 1:04 PM (93 w, 1 d)

Recent Activity

Yesterday

kfunk committed R33:f219bf371afc: QtWebKit documentation regression fixes (authored by igorkushnir).
QtWebKit documentation regression fixes
Fri, Mar 24, 4:18 PM
kfunk closed D5129: QtWebKit documentation regression fixes by committing R33:f219bf371afc: QtWebKit documentation regression fixes (authored by igorkushnir).
Fri, Mar 24, 4:18 PM
kfunk committed R33:7805b4d7ba64: Fix compilation (authored by kfunk).
Fix compilation
Fri, Mar 24, 2:52 PM

Thu, Mar 23

kfunk accepted D5161: Use {} as default value for zero-set flags, not nullptr.

If it makes you happy... :)

Thu, Mar 23, 9:39 PM
kfunk accepted D5159: Remove unused Qt::WindowFlags parameters from internal API.

I know why you did that! ;)

Thu, Mar 23, 9:38 PM
kfunk added inline comments to D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD.
Thu, Mar 23, 4:22 PM · Frameworks
kfunk accepted D5155: Load Template From File dialogs: fix wrong filter strings usage.

LGTM, gotta test on Windows...

Thu, Mar 23, 3:19 PM
kfunk committed R218:583d0c24bcbf: Fix -Wdocumentation warnings (authored by kfunk).
Fix -Wdocumentation warnings
Thu, Mar 23, 9:12 AM
kfunk committed R218:8306ee894ba8: Include KDECompilerSettings with NO_POLICY_SCOPE (authored by kfunk).
Include KDECompilerSettings with NO_POLICY_SCOPE
Thu, Mar 23, 9:12 AM
kfunk committed R60:3e3424faf7c1: Include KDECompilerSettings with NO_POLICY_SCOPE (authored by kfunk).
Include KDECompilerSettings with NO_POLICY_SCOPE
Thu, Mar 23, 9:10 AM
kfunk committed R33:6f7b8ab84ee5: Merge remote-tracking branch 'origin/5.1' (authored by kfunk).
Merge remote-tracking branch 'origin/5.1'
Thu, Mar 23, 9:01 AM
kfunk committed R33:9350ac3bfd64: subversion: Fix naming scheme for tests (authored by kfunk).
subversion: Fix naming scheme for tests
Thu, Mar 23, 8:58 AM
kfunk committed R33:77bee640b0a4: sessioncontroller: Fix memory leaks (authored by kfunk).
sessioncontroller: Fix memory leaks
Thu, Mar 23, 8:58 AM
kfunk committed R33:879d1e58a930: svnrecursiveadd: Speed up test (authored by kfunk).
svnrecursiveadd: Speed up test
Thu, Mar 23, 8:58 AM
kfunk added a comment to T5733: Better CUDA Support.

One thing to keep in mind: you can make KDevelop print how clang is invoked by setting this env var: KDEV_CLANG_DISPLAY_ARGS=1 I'm not sure why libclang does not use the implicitly included headers automatically.

Thu, Mar 23, 8:31 AM · KDevelop
kfunk updated subscribers of T5733: Better CUDA Support.
Thu, Mar 23, 8:29 AM · KDevelop

Wed, Mar 22

kfunk committed R32:84d4fbabe7b1: appdata: Add update_contact (authored by kfunk).
appdata: Add update_contact
Wed, Mar 22, 11:58 PM
kfunk committed R32:7f16950151a3: appdata: Fix summary more (authored by kfunk).
appdata: Fix summary more
Wed, Mar 22, 11:54 PM
kfunk committed R32:c9d7a8fc5acf: appdata: Fix summary (authored by kfunk).
appdata: Fix summary
Wed, Mar 22, 11:49 PM
kfunk added a comment to D5136: Introduce fetch-translations build command.
In D5136#96878, @aacid wrote:

I'm not sure addign a dependency for releaseme in ki18n is a good idea to be honest.

This very "only works for KDE-based applications", a third-party using k18n has no interest in this at all.

Maybe it would make more sense in some of the *KDE* files ECM has?

Wed, Mar 22, 10:42 PM · Frameworks
kfunk accepted D5135: Find/Replace in files: Do not wrap content of tooltip for an output line.

I have a deja vu here.

Wed, Mar 22, 7:22 PM
kfunk requested changes to D5136: Introduce fetch-translations build command.
Wed, Mar 22, 7:14 PM · Frameworks
kfunk added inline comments to D5136: Introduce fetch-translations build command.
Wed, Mar 22, 7:14 PM · Frameworks
kfunk added a reviewer for D5129: QtWebKit documentation regression fixes: apol.
Wed, Mar 22, 4:02 PM
kfunk added a comment to D5129: QtWebKit documentation regression fixes.

By the way, is building with QtWebKit supported if there are both QtWebKit and QtWebEngine installed? I had to change CMakeLits.txt to force-use QtWebKit:

-find_package(Qt5WebEngineWidgets)
-if(TARGET Qt5::WebEngineWidgets)
+#find_package(Qt5WebEngineWidgets)
+if(0)
Wed, Mar 22, 4:02 PM
kfunk created T5725: Make it easier to run the AppImage through debugger.
Wed, Mar 22, 3:36 PM · KDevelop
kfunk accepted D5129: QtWebKit documentation regression fixes.
Wed, Mar 22, 3:32 PM
kfunk committed R245:9d37cd49fdd5: Minor: Fix API doc (authored by kfunk).
Minor: Fix API doc
Wed, Mar 22, 9:59 AM
kfunk added a comment to D3040: Allow scaling documentation view (BUG 285162).

This branch is based on a very old KDevPlatform revision. There are conflicts when rebasing on master. Should I rebase on master and update this review request? Or maybe rebase on some other branch?

Wed, Mar 22, 9:17 AM
kfunk added a comment to D5123: Try to fix call to KXMLGuiWindow::setupGUI.
In D5123#96602, @dfaure wrote:

createGUI(part) takes care of loading ui_standards.rc, see the bit of code I pointed to in my last comment.

Wed, Mar 22, 8:26 AM
kfunk accepted D5125: Fix compile warnings with clang.

Files in kdev-pg/AS* are thirdparty code, maybe we should rather try syncing the source files from upstream & check whether they've fixed the issue already?

Wed, Mar 22, 8:21 AM
kfunk added a comment to D5123: Try to fix call to KXMLGuiWindow::setupGUI.
In D5123#96600, @dfaure wrote:

This looks like ui_standards.rc isn't loaded.

Wed, Mar 22, 8:18 AM

Tue, Mar 21

kfunk updated the summary of D5123: Try to fix call to KXMLGuiWindow::setupGUI.
Tue, Mar 21, 11:29 PM
kfunk added a comment to D5122: This patch fixes bug 374144, Basically it allows users to install via a custom root installation command.

Since I am new to submitting patches would you please tell me when updating diff should I upload the diff representing the latest changes or one that represents the whole patch?

Tue, Mar 21, 10:56 PM · KDevelop
kfunk added a comment to D5123: Try to fix call to KXMLGuiWindow::setupGUI.

CC'd David & Laurent: Do you guys have an idea what could be wrong here? Looks like kdevelopui.rc from kdevelop.git/app is not obeyed anymore after this change. Why?

Tue, Mar 21, 10:44 PM
kfunk updated the summary of D5123: Try to fix call to KXMLGuiWindow::setupGUI.
Tue, Mar 21, 10:39 PM
kfunk added reviewers for D5123: Try to fix call to KXMLGuiWindow::setupGUI: dfaure, mlaurent.
Tue, Mar 21, 10:18 PM
kfunk planned changes to D5123: Try to fix call to KXMLGuiWindow::setupGUI.

Does anyone have an idea why this is happening? I just debugged this for a few hours but couldn't figure it out. KXMLGui is black magic to me...

Tue, Mar 21, 10:16 PM
kfunk updated the summary of D5123: Try to fix call to KXMLGuiWindow::setupGUI.
Tue, Mar 21, 10:15 PM
kfunk created D5123: Try to fix call to KXMLGuiWindow::setupGUI.
Tue, Mar 21, 10:14 PM
kfunk committed R32:9568de318eab: cppcheck: Fix .rc file (authored by kfunk).
cppcheck: Fix .rc file
Tue, Mar 21, 10:06 PM
kfunk committed R32:2844b8a7a0cc: Fix memory leak (authored by kfunk).
Fix memory leak
Tue, Mar 21, 10:05 PM
kfunk added a comment to D5122: This patch fixes bug 374144, Basically it allows users to install via a custom root installation command.

My build fails right now after a git pull

kdevelop/languages/clang/duchain/macronavigationcontext.cpp:58:28: error: ‘prefix’ was not declared in this scope
Tue, Mar 21, 7:03 PM · KDevelop
kfunk committed R53:36858a5f9a4c: Fix strings, respect KDE HIG (authored by kfunk).
Fix strings, respect KDE HIG
Tue, Mar 21, 6:52 PM
kfunk committed R33:66a00d353caf: shell: Fix various memory leaks (authored by kfunk).
shell: Fix various memory leaks
Tue, Mar 21, 6:42 PM
kfunk committed R33:53cb48fc5216: shell: Fix the tons of memory leaks from settings (authored by kfunk).
shell: Fix the tons of memory leaks from settings
Tue, Mar 21, 6:42 PM
kfunk committed R33:6e7cc99d976b: EnvironmentWidget: Use QPlainTextEdit (authored by kfunk).
EnvironmentWidget: Use QPlainTextEdit
Tue, Mar 21, 6:09 PM
kfunk requested changes to D5122: This patch fixes bug 374144, Basically it allows users to install via a custom root installation command.
Tue, Mar 21, 5:50 PM · KDevelop
kfunk accepted D5041: Port away from QtWebKit to QtWebEngine.

We'll probably need to tweak the CMake code a bit more.

Tue, Mar 21, 2:47 PM
kfunk added a comment to D5041: Port away from QtWebKit to QtWebEngine.
In D5041#96472, @apol wrote:

@mwolff I think it's fine like this, I wouldn't want people compiling against qtwebkit because they forgot to pull a dependency, it should be a conscious decision.

Tue, Mar 21, 7:59 AM
kfunk added inline comments to D5041: Port away from QtWebKit to QtWebEngine.
Tue, Mar 21, 7:57 AM

Mon, Mar 20

kfunk added a comment to D3987: Use nullptr in all Frameworks (just diff in KIO shown here).
In D3987#95858, @kfunk wrote:

Closing. This Diff refactored the code technically correct.

Technically correct, as in: it builds.
But semantically it is incorrect and a regression when it comes to flags, especially as high level languages are made for humans in the first line, not compilers ;)

Mon, Mar 20, 7:13 PM · Frameworks

Sun, Mar 19

kfunk committed R33:cf29d485dcd7: Push uncommitted changes, sorry (authored by kfunk).
Push uncommitted changes, sorry
Sun, Mar 19, 9:59 PM
kfunk committed R32:8dddd7432a67: Merge remote-tracking branch 'origin/5.1' (authored by kfunk).
Merge remote-tracking branch 'origin/5.1'
Sun, Mar 19, 9:58 PM
kfunk committed R32:4cca98271719: ninjabuilder: Fix crash inside ~NinjaJob (authored by kfunk).
ninjabuilder: Fix crash inside ~NinjaJob
Sun, Mar 19, 8:28 PM
kfunk committed R53:61ecb4c76646: Fix strings, respect KDE HIG (authored by kfunk).
Fix strings, respect KDE HIG
Sun, Mar 19, 7:08 PM
kfunk committed R58:7b41b460e01d: Update .gitignore (authored by kfunk).
Update .gitignore
Sun, Mar 19, 7:04 PM
kfunk committed R58:ab7e58b1989b: Adapt to kdevplatform duchain API changes (authored by kfunk).
Adapt to kdevplatform duchain API changes
Sun, Mar 19, 7:04 PM
kfunk added a comment to D5108: Fix setPen call.

Thanks for the quick fix!

Sun, Mar 19, 7:04 PM · Frameworks
kfunk accepted D5108: Fix setPen call.
Sun, Mar 19, 7:03 PM · Frameworks
kfunk committed R52:a52edfe1dd65: Adapt to kdevplatform duchain API changes (authored by kfunk).
Adapt to kdevplatform duchain API changes
Sun, Mar 19, 7:00 PM
kfunk committed R52:7c73a71cc5b2: phpdocs: Use php icon for plugin (authored by kfunk).
phpdocs: Use php icon for plugin
Sun, Mar 19, 7:00 PM
kfunk committed R53:81c997b195cb: Adapt to kdevplatform duchain API changes (authored by kfunk).
Adapt to kdevplatform duchain API changes
Sun, Mar 19, 7:00 PM
kfunk committed R33:52cd6937057e: Pimpl DUChain navigation classes (authored by kfunk).
Pimpl DUChain navigation classes
Sun, Mar 19, 6:55 PM
kfunk closed D723: Pimpl DUChain navigation classes by committing R33:52cd6937057e: Pimpl DUChain navigation classes.
Sun, Mar 19, 6:55 PM
kfunk committed R33:6891324acd0e: OpenProjectPage: Fix deprecation warning (authored by kfunk).
OpenProjectPage: Fix deprecation warning
Sun, Mar 19, 6:55 PM
kfunk committed R33:49e04b2ffa4a: Minor: Remove unnecessary return statement (authored by kfunk).
Minor: Remove unnecessary return statement
Sun, Mar 19, 6:55 PM
kfunk committed R32:00e0613aa592: Adapt to kdevplatform duchain API changes (authored by kfunk).
Adapt to kdevplatform duchain API changes
Sun, Mar 19, 6:53 PM
kfunk updated subscribers of R39:b92f53644133: save a lot of allocation for setPen.
Sun, Mar 19, 6:19 PM
kfunk raised a concern with R39:b92f53644133: save a lot of allocation for setPen.
Sun, Mar 19, 6:19 PM
kfunk abandoned D2437: WIP: Make KWallet optional.

Closing as I have no intent to further work on this patch.

Sun, Mar 19, 4:51 PM
kfunk closed T5466: CI: Fix symbol clashes between llvm used by mesa and the custom one used by KDevelop as "Resolved".

Closing as resolved then.

Sun, Mar 19, 4:37 PM · KDevelop, build.kde.org
kfunk committed R32:056932ba0285: test_files: Skip test.cl when mimetype unknown (authored by kfunk).
test_files: Skip test.cl when mimetype unknown
Sun, Mar 19, 3:20 PM
kfunk raised a concern with R32:64d7d49ed3a2: Add basic support for CUDA parsing.

Breaks unit tests:

Sun, Mar 19, 3:12 PM
kfunk requested changes to D5042: Port away from QtWebKit into QtWebEngine.
In D5042#95988, @apol wrote:

Then please, let me submit this change and as soon as there's something we can share with Kontact I'll do the port myself.

Sun, Mar 19, 11:37 AM
kfunk committed R32:23387fff934a: clang-tidy: performance-unnecessary-value-param (authored by kfunk).
clang-tidy: performance-unnecessary-value-param
Sun, Mar 19, 10:53 AM
kfunk committed R32:439b860e346c: stringhelpers: Refactor slightly, prefer const-ref (authored by kfunk).
stringhelpers: Refactor slightly, prefer const-ref
Sun, Mar 19, 10:53 AM
kfunk added a comment to D4095: Refactor to embrace a cmake server import backend.

The revision is still pending acceptance by Kevin, which is why you can't close it.
Removing him as a Reviewer should fix this - which i've just done.

Sun, Mar 19, 9:46 AM · KDevelop

Sat, Mar 18

kfunk committed R32:545949e3597b: clang: Use text/x-opencl-src again (authored by kfunk).
clang: Use text/x-opencl-src again
Sat, Mar 18, 5:41 PM
kfunk committed R32:37b675e95f35: appimage: Package kate, refactor recipe (authored by kfunk).
appimage: Package kate, refactor recipe
Sat, Mar 18, 5:01 PM
kfunk closed T3826: Ship Snippets plugin (needs Kate installed) as "Resolved" by committing R32:37b675e95f35: appimage: Package kate, refactor recipe.
Sat, Mar 18, 5:01 PM · KDevelop
kfunk closed T3826: Ship Snippets plugin (needs Kate installed), a subtask of T3536: KDevelop AppImage work, as "Resolved".
Sat, Mar 18, 5:01 PM · KDevelop
kfunk accepted D5098: Search tool: no big fonts and less cursive in output view.

Can we git rid off the excessive line spacing, too? Can we enable the uniform row heights property on the view then?

Sat, Mar 18, 4:49 PM
kfunk claimed T3826: Ship Snippets plugin (needs Kate installed).
Sat, Mar 18, 1:28 PM · KDevelop
kfunk added a comment to D3987: Use nullptr in all Frameworks (just diff in KIO shown here).

Closing. This Diff refactored the code technically correct.

Sat, Mar 18, 12:22 PM · Frameworks
kfunk closed D3850: Pass -fno-operator-names when supported.

Closing. Please just strip the flag from CMake flags if you're using a library making use of alternative tokens.

Sat, Mar 18, 12:20 PM
kfunk added a comment to D4095: Refactor to embrace a cmake server import backend.

Please close this.

Sat, Mar 18, 12:13 PM · KDevelop
kfunk committed R33:d38d7d3a9072: Don't use qCWarning in public header (authored by kfunk).
Don't use qCWarning in public header
Sat, Mar 18, 12:12 PM
kfunk committed R33:70bc8a1fa68a: Fix compilation (authored by kfunk).
Fix compilation
Sat, Mar 18, 12:02 PM
kfunk committed R33:bda72ef18e64: Use more categorized logging (authored by kfunk).
Use more categorized logging
Sat, Mar 18, 12:02 PM
kfunk accepted D5089: KDE compiler settings fail to consider AppleClang.

LGTM

Sat, Mar 18, 11:50 AM · Frameworks, Build System
kfunk committed R32:2db569f1e0b0: Add missing file, sorry (authored by kfunk).
Add missing file, sorry
Sat, Mar 18, 2:19 AM
kfunk committed R32:6815b74075b0: release-scripts: Use VERSION.inc in other script (authored by kfunk).
release-scripts: Use VERSION.inc in other script
Sat, Mar 18, 2:18 AM
kfunk committed R32:cfdf11214a36: release-scripts: Add change log generation script (authored by kfunk).
release-scripts: Add change log generation script
Sat, Mar 18, 2:16 AM
kfunk committed R32:e840cc65c295: Port update-version.sh to bash, refactor slightly (authored by kfunk).
Port update-version.sh to bash, refactor slightly
Sat, Mar 18, 2:16 AM
kfunk added a reverting commit for R32:2a6ced5df0c1: Reformat file properly: R32:e8f21880252e: Revert "Reformat file properly".
Sat, Mar 18, 2:16 AM
kfunk committed R32:e8f21880252e: Revert "Reformat file properly" (authored by kfunk).
Revert "Reformat file properly"
Sat, Mar 18, 2:16 AM
kfunk committed R32:2a6ced5df0c1: Reformat file properly (authored by kfunk).
Reformat file properly
Sat, Mar 18, 12:46 AM

Fri, Mar 17

kfunk accepted D5072: Add basic support for CUDA parsing.

Nice! :)

Fri, Mar 17, 7:05 PM
kfunk requested changes to D5089: KDE compiler settings fail to consider AppleClang.
Fri, Mar 17, 7:02 PM · Frameworks, Build System