kfunk (Kevin Funk)
Software Engineer

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jun 12 2015, 1:04 PM (127 w, 1 d)
Availability
Available

Recent Activity

Fri, Nov 17

kfunk accepted D8872: Use software backend for welcome page.

LGTM, thanks a lot!

Fri, Nov 17, 6:55 PM
kfunk requested changes to D8872: Use software backend for welcome page.
Fri, Nov 17, 6:36 PM
kfunk accepted D8872: Use software backend for welcome page.

I like the idea.

Fri, Nov 17, 6:36 PM
kfunk committed R32:8ba5f3bf7472: Merge remote-tracking branch 'origin/5.2' (authored by kfunk).
Merge remote-tracking branch 'origin/5.2'
Fri, Nov 17, 1:00 PM
kfunk added a comment to D8852: Fix crash deep inside VcsOverlayProxyModel::data().
In D8852#168856, @apol wrote:

What's the crash?

Fri, Nov 17, 12:09 PM
kfunk abandoned D8217: projectmanagerview: Don't collapse children.
Fri, Nov 17, 10:20 AM
kfunk added a comment to D8217: projectmanagerview: Don't collapse children.

I would miss the option to hide the build order child view. I almost never need it as even with many projects open (and I very often have that) most of the time I just need to build one project/target. Cross-project builds are almost never done.

So right now the build order view only adds visual noise and (more important) steals vertical space on small screens. So not happy with the second line of the patch.

Fri, Nov 17, 10:20 AM
kfunk committed R32:37a11f9cea1c: projectmanagerview: Don't collapse tree view (authored by kfunk).
projectmanagerview: Don't collapse tree view
Fri, Nov 17, 10:11 AM
kfunk committed R32:13edc8951406: Build on Qt <5.6 again (authored by kfunk).
Build on Qt <5.6 again
Fri, Nov 17, 10:11 AM
kfunk committed R32:a767101302da: Minor: Fix compiler warning (authored by kfunk).
Minor: Fix compiler warning
Fri, Nov 17, 10:11 AM
kfunk committed R32:44e45cf9e10e: Minor: Fix typo (authored by kfunk).
Minor: Fix typo
Fri, Nov 17, 8:56 AM
kfunk committed R32:7395c5154400: Merge remote-tracking branch 'origin/5.2' (authored by kfunk).
Merge remote-tracking branch 'origin/5.2'
Fri, Nov 17, 8:50 AM

Thu, Nov 16

kfunk accepted D8857: work around clang bug 35333: don't crash when switching git branches.

Also fixes^Wworks-around https://bugs.kde.org/show_bug.cgi?id=358205 -- needs BUG: and FIXED-IN:

Thu, Nov 16, 11:19 PM
kfunk committed R32:23f406b6eaa5: Merge remote-tracking branch 'origin/5.2' (authored by kfunk).
Merge remote-tracking branch 'origin/5.2'
Thu, Nov 16, 11:12 PM
kfunk committed R32:010e9ba4bf1a: problemtreeview: Improve context menu (authored by kfunk).
problemtreeview: Improve context menu
Thu, Nov 16, 11:11 PM
kfunk committed R32:56263bc4308a: app: Use categorized logging everywhere (authored by kfunk).
app: Use categorized logging everywhere
Thu, Nov 16, 9:10 PM
kfunk requested changes to D8492: Make SourceFormatter plugins enablable, hide actions with no plugins.

Not yet done is to hide the source formatting settings page from the application settings dialog in case no formatters are available.

Thu, Nov 16, 5:23 PM
kfunk updated subscribers of D8852: Fix crash deep inside VcsOverlayProxyModel::data().
Thu, Nov 16, 5:06 PM
kfunk added a reviewer for D8852: Fix crash deep inside VcsOverlayProxyModel::data(): apol.

@apol May I ask you to review 6 years old code of yours? :D -- why was ProjectChangesModel lazy-initialized?

Thu, Nov 16, 4:55 PM
kfunk created D8852: Fix crash deep inside VcsOverlayProxyModel::data().
Thu, Nov 16, 4:54 PM
kfunk committed R32:d01702dffe58: app: Improve --project handling (authored by kfunk).
app: Improve --project handling
Thu, Nov 16, 4:36 PM
kfunk closed D8842: app: Improve --project handling.
Thu, Nov 16, 4:36 PM
kfunk committed R32:fd2d83c0f0b1: appimage: Use Qt 5.9.1 from new docker image (authored by kfunk).
appimage: Use Qt 5.9.1 from new docker image
Thu, Nov 16, 4:09 PM
kfunk committed R32:6bec34d76b3d: appimage: Update Dockerfile (authored by kfunk).
appimage: Update Dockerfile
Thu, Nov 16, 4:05 PM
kfunk added a comment to D8842: app: Improve --project handling.

;=) Actually I wanted that kdevelop just opened the project in the current working dir, if any if I start it without arguments ;=)

Thu, Nov 16, 1:58 PM
kfunk updated the diff for D8842: app: Improve --project handling.

Code cleanup, rebase

Thu, Nov 16, 1:47 PM
kfunk added a comment to D8842: app: Improve --project handling.

@cullmann kdevelop -p DIR -- That's something you wanted to have, right? In case you ever wanted to look at KDevelop again :)

Thu, Nov 16, 1:35 PM
kfunk updated subscribers of D8842: app: Improve --project handling.
Thu, Nov 16, 1:34 PM
kfunk updated the diff for D8842: app: Improve --project handling.

Add new feature:

kdevelop -p DIR
Thu, Nov 16, 1:33 PM
kfunk added a reviewer for D8842: app: Improve --project handling: dfaure.
Thu, Nov 16, 1:15 PM
kfunk created D8842: app: Improve --project handling.
Thu, Nov 16, 1:14 PM
kfunk committed R58:304b4fe566b4: Make compile on FreeBSD (authored by kfunk).
Make compile on FreeBSD
Thu, Nov 16, 9:35 AM
kfunk committed R32:17d91fb2920f: Merge remote-tracking branch 'origin/5.2' (authored by kfunk).
Merge remote-tracking branch 'origin/5.2'
Thu, Nov 16, 9:28 AM
kfunk accepted D8830: Register kdevelop as handler for repo urls, add --fetch argument.

Nice idea indeed!

Thu, Nov 16, 8:52 AM
kfunk committed R32:c92a8f17a7bd: Move QtSingleApplication to own dir in 3rdparty/ (authored by kfunk).
Move QtSingleApplication to own dir in 3rdparty/
Thu, Nov 16, 8:50 AM
kfunk committed R32:1cf0f6b4dbea: test_definesandincludes: Speedup test (authored by kfunk).
test_definesandincludes: Speedup test
Thu, Nov 16, 8:46 AM
kfunk committed R32:7e25d7b9eb17: test_lldbformatters: Skip test if lldb-mi not found (authored by kfunk).
test_lldbformatters: Skip test if lldb-mi not found
Thu, Nov 16, 12:17 AM
kfunk committed R32:f57b4609960a: appimage: Bump KF5 version to 5.37.0 (authored by kfunk).
appimage: Bump KF5 version to 5.37.0
Thu, Nov 16, 12:07 AM
kfunk committed R32:021cac878711: Fix in-source build of release tarball (authored by kfunk).
Fix in-source build of release tarball
Thu, Nov 16, 12:03 AM

Wed, Nov 15

kfunk committed R32:1dbef93c2c91: test_lldb: Skip test if lldb-mi not found (authored by kfunk).
test_lldb: Skip test if lldb-mi not found
Wed, Nov 15, 11:41 PM
kfunk committed R32:638e8f0c2202: Minor: Fix coding style (authored by kfunk).
Minor: Fix coding style
Wed, Nov 15, 11:41 PM
kfunk committed R32:c345009335d3: Minor: Fix coding style (authored by kfunk).
Minor: Fix coding style
Wed, Nov 15, 11:41 PM
kfunk committed R111:17b234284625: Modernize: Use nullptr where possible (authored by kfunk).
Modernize: Use nullptr where possible
Wed, Nov 15, 11:41 PM
kfunk committed R111:ea4f67022cde: Modernize: Q_DECL_OVERRIDE -> override (authored by kfunk).
Modernize: Q_DECL_OVERRIDE -> override
Wed, Nov 15, 11:41 PM
kfunk committed R111:c15ce63205b1: Modernize: Use override everywhere (authored by kfunk).
Modernize: Use override everywhere
Wed, Nov 15, 11:41 PM
kfunk added a comment to D8831: gcclikecompiler: Fix execution of compiler qprocess under windows.

Thanks a lot for these patches!

Wed, Nov 15, 10:36 PM
kfunk committed R32:6ae542fbea99: gcclikecompiler: Fix execution of compiler qprocess under windows (authored by geetamc).
gcclikecompiler: Fix execution of compiler qprocess under windows
Wed, Nov 15, 10:36 PM
kfunk closed D8831: gcclikecompiler: Fix execution of compiler qprocess under windows.
Wed, Nov 15, 10:36 PM
kfunk accepted D8831: gcclikecompiler: Fix execution of compiler qprocess under windows.

Makes sense to me.

Wed, Nov 15, 10:16 PM

Tue, Nov 14

kfunk committed R32:e571ebd842df: Merge remote-tracking branch 'origin/5.2' (authored by kfunk).
Merge remote-tracking branch 'origin/5.2'
Tue, Nov 14, 12:38 PM
kfunk committed R32:ff72bc3266a2: abstractnavigationwidget: Add missing DUChain lock (authored by kfunk).
abstractnavigationwidget: Add missing DUChain lock
Tue, Nov 14, 12:38 PM
kfunk committed R32:4db1ad101728: abstractnavigationwidget: Add missing DUChain lock (authored by kfunk).
abstractnavigationwidget: Add missing DUChain lock
Tue, Nov 14, 12:37 PM
kfunk added a reviewer for D8810: Do not look for kioslave binary in applicationDirPath on *nix (#386859): cullmann.
Tue, Nov 14, 11:18 AM · Frameworks
kfunk requested changes to D8810: Do not look for kioslave binary in applicationDirPath on *nix (#386859).

Just chiming in here, without having a final solution for your problem: This search path has been added for a reason -- to find a kioslave.exe next to the application binary in application bundles on macOS/Windows.

Tue, Nov 14, 11:18 AM · Frameworks

Mon, Nov 13

kfunk committed R32:22cb89451646: custom-dai: Don't crash when batch editing (authored by kfunk).
custom-dai: Don't crash when batch editing
Mon, Nov 13, 9:05 AM
kfunk committed R32:7c7180a8ab66: debuggercommon: Fix build on Windows (authored by kfunk).
debuggercommon: Fix build on Windows
Mon, Nov 13, 8:50 AM
kfunk committed R32:c0e455fd1af1: cmake: Remove check for older CMake (authored by kfunk).
cmake: Remove check for older CMake
Mon, Nov 13, 8:10 AM
kfunk committed R55:b2e1ed602c53: Modernize: Use nullptr where possible (authored by kfunk).
Modernize: Use nullptr where possible
Mon, Nov 13, 8:08 AM
kfunk committed R55:c3724fedf65d: Modernize: Use override where possible (authored by kfunk).
Modernize: Use override where possible
Mon, Nov 13, 8:08 AM
kfunk committed R55:3f9f5fa871b1: Port to CMake AUTOMOC (authored by kfunk).
Port to CMake AUTOMOC
Mon, Nov 13, 8:08 AM

Sun, Nov 12

kfunk accepted D8766: In action title use "Revision Id" when talking about revision number etc..
Sun, Nov 12, 9:33 PM

Mon, Nov 6

kfunk added a comment to D8577: Fix: Missing dependencies for ktexeditor autotests.

Could you just remove the problematic includes and try to compile without the dependency, IMHO I see no use of QtScript stuff.

Mon, Nov 6, 11:01 AM · Frameworks, Kate
kfunk committed R39:631b1447c97f: autotests: Remove dep on Qt5::Script again (authored by kfunk).
autotests: Remove dep on Qt5::Script again
Mon, Nov 6, 11:01 AM

Sat, Nov 4

kfunk added a comment to D8317: Don't try to guess the language from given arguments.

@aaronpuchert Apparently this Diff here is causing problems in the QML/JS plugin: https://bugs.kde.org/show_bug.cgi?id=386388 -- please check.

Sat, Nov 4, 5:13 PM

Thu, Nov 2

kfunk added inline comments to D8544: KTextEditor : avoiding QML crashes.
Thu, Nov 2, 12:35 PM · Frameworks, KTextEditor, Kate

Mon, Oct 30

kfunk accepted D8512: kdevplatform: less auto-casting from/to ascii & from bytearray.
Mon, Oct 30, 12:23 PM

Sat, Oct 28

kfunk added a comment to D8523: Use native separators while copying filename to clipboard.

@geetamc Note: Please fixup your user name to in Git (git config user.name).

Sat, Oct 28, 4:44 PM
kfunk committed R32:9d6aa08f7e59: Use native separators while copying filename to clipboard (authored by geetamc).
Use native separators while copying filename to clipboard
Sat, Oct 28, 4:42 PM
kfunk closed D8523: Use native separators while copying filename to clipboard.
Sat, Oct 28, 4:42 PM
kfunk committed R32:4371a57c4480: duchain: Improve debug output slightly (authored by kfunk).
duchain: Improve debug output slightly
Sat, Oct 28, 4:42 PM
kfunk accepted D8523: Use native separators while copying filename to clipboard.
Sat, Oct 28, 4:41 PM
kfunk committed R111:a69ae0f7df00: Minor: Fix compiler warning (authored by kfunk).
Minor: Fix compiler warning
Sat, Oct 28, 9:42 AM

Fri, Oct 27

kfunk committed R32:863962708473: Merge remote-tracking branch 'origin/5.2' (authored by kfunk).
Merge remote-tracking branch 'origin/5.2'
Fri, Oct 27, 7:34 PM
kfunk accepted D8508: Make kdev{debuggercommon, gdb, lldb} compile under Windows..
Fri, Oct 27, 7:22 PM
kfunk accepted D8437: KWidgetsAddons : more compact password dialog.

Looks like it :)

Fri, Oct 27, 8:37 AM · Frameworks
kfunk added a comment to D8512: kdevplatform: less auto-casting from/to ascii & from bytearray.

LGTM (only had a relatively quick look)

Fri, Oct 27, 8:34 AM
kfunk added a reviewer for D8511: Fix Clang -Wpedantic warning: rjvbb.

Can't test this myself, so I'm putting this up for review.

Fri, Oct 27, 7:11 AM
kfunk created D8511: Fix Clang -Wpedantic warning.
Fri, Oct 27, 7:11 AM
kfunk committed R495:f188c07dc555: Modernize: Use override keyword consistently (authored by kfunk).
Modernize: Use override keyword consistently
Fri, Oct 27, 7:06 AM
kfunk committed R495:cab264abb41c: Make compile under MSVC (authored by kfunk).
Make compile under MSVC
Fri, Oct 27, 7:03 AM
kfunk committed R495:dff61a426752: Port Q_NULLPTR to nullptr (authored by kfunk).
Port Q_NULLPTR to nullptr
Fri, Oct 27, 7:03 AM
kfunk closed D8467: Make compile under MSVC.
Fri, Oct 27, 7:03 AM
kfunk added a comment to D8411: add qtwebkit dependency to kmymoney blueprint.

Applied in https://commits.kde.org/craft-blueprints-kde/d1afda15a85ba44a4790e3463dfcfaa00870a1d6

For some reason arcanist replaces the author of the change...

Fri, Oct 27, 6:58 AM · Craft
kfunk accepted D8508: Make kdev{debuggercommon, gdb, lldb} compile under Windows..

Rest LGTM, very nice Gleb! You rock :)

Fri, Oct 27, 6:57 AM

Thu, Oct 26

kfunk added a comment to D8467: Make compile under MSVC.

@apol Ping?

Thu, Oct 26, 12:21 PM
kfunk committed R32:dc4f36e9763c: Merge remote-tracking branch 'origin/5.2' (authored by kfunk).
Merge remote-tracking branch 'origin/5.2'
Thu, Oct 26, 9:03 AM

Wed, Oct 25

kfunk committed R94:86f1a587614b: Minor: Respect KDE HIG for strings (authored by kfunk).
Minor: Respect KDE HIG for strings
Wed, Oct 25, 1:12 PM
kfunk committed R495:746d6a292ca4: Modernize: Use nullptr everywhere (authored by kfunk).
Modernize: Use nullptr everywhere
Wed, Oct 25, 11:50 AM
kfunk added reviewers for D8467: Make compile under MSVC: apol, bcooksley.
Wed, Oct 25, 10:38 AM
kfunk created D8467: Make compile under MSVC.
Wed, Oct 25, 10:38 AM

Tue, Oct 24

kfunk requested changes to D8437: KWidgetsAddons : more compact password dialog.
Tue, Oct 24, 9:24 PM · Frameworks
kfunk added a comment to D8448: Do not emit statechanged when state has not changed.

Thanks a lot for the patch!

Tue, Oct 24, 4:27 PM
kfunk committed R68:8d7c15e54147: Do not emit statechanged when state has not changed (authored by wcancino).
Do not emit statechanged when state has not changed
Tue, Oct 24, 4:26 PM
kfunk closed D8448: Do not emit statechanged when state has not changed.
Tue, Oct 24, 4:26 PM
kfunk added a comment to D5425: Allow disabling the git plugin with a kdevgit.disabled git config option.

@mwolff Hmm, I think this feature could be useful at times. Being able to disable the Git plugin on a per-repo basis (and stored in Git's very own settings) sounds useful to me.

Tue, Oct 24, 8:58 AM
kfunk requested changes to D7401: Solid/Mac : fleshing out the skeleton IOKit backend (WIP).
Tue, Oct 24, 8:53 AM · Frameworks

Mon, Oct 23

kfunk added inline comments to D8411: add qtwebkit dependency to kmymoney blueprint.
Mon, Oct 23, 1:20 PM · Craft
kfunk added inline comments to D7401: Solid/Mac : fleshing out the skeleton IOKit backend (WIP).
Mon, Oct 23, 11:14 AM · Frameworks
kfunk requested changes to D7401: Solid/Mac : fleshing out the skeleton IOKit backend (WIP).

This definitely needs another revision. Please fix the outstanding issues.

Mon, Oct 23, 11:13 AM · Frameworks

Fri, Oct 20

kfunk accepted D6477: KDevelop --help: document the possibility to open files at a specific cursor position.
In D6477#156498, @rjvbb wrote:
In D6477#147064, @kfunk wrote:

i18n("Files to load, or directories to load as projects"), "[FILE[:line[:column]] | DIRECTORY]..."?

I could live with that.

Will do.

Bonus points for adding two example usages at the bottom of the help text in a new Examples section(?)

What help text, the one printed by kdevelop --help?

Fri, Oct 20, 8:16 AM · KDevelop