kfunk (Kevin Funk)
Software Engineer

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Jun 12 2015, 1:04 PM (244 w, 5 d)
Availability
Available

Recent Activity

Fri, Feb 14

kfunk accepted D27387: Re-enable auto-reconnect, after fixing logout..

Looks good to me, but didn't test.

Fri, Feb 14, 7:45 AM

Wed, Feb 12

kfunk committed R865:7929384beb80: Do not create User class on heap (authored by kfunk).
Do not create User class on heap
Wed, Feb 12, 9:15 PM
kfunk closed D27349: Do not create User class on heap.
Wed, Feb 12, 9:15 PM
kfunk requested review of D27349: Do not create User class on heap.
Wed, Feb 12, 3:28 PM
kfunk committed R865:d598cc543659: Minor: Fix a few -Wunused-lambda-capture (authored by kfunk).
Minor: Fix a few -Wunused-lambda-capture
Wed, Feb 12, 3:28 PM
kfunk committed R865:5032df9a6c81: message: Never turn an Image into NormalText (authored by kfunk).
message: Never turn an Image into NormalText
Wed, Feb 12, 11:43 AM
kfunk closed D27341: message: Never turn an Image into NormalText.
Wed, Feb 12, 11:43 AM
kfunk committed R865:ac8aa3f5ca11: Fix memory leak (authored by kfunk).
Fix memory leak
Wed, Feb 12, 9:56 AM
kfunk added a reviewer for D27341: message: Never turn an Image into NormalText: dfaure.

Note: This seems to fix the Gify previews in both ruqola + ruqolaqml.

Wed, Feb 12, 9:29 AM
kfunk committed R865:7498bf03e011: reaction: Fix tenses (authored by kfunk).
reaction: Fix tenses
Wed, Feb 12, 8:58 AM
kfunk updated the diff for D27341: message: Never turn an Image into NormalText.

Fix tests

Wed, Feb 12, 8:51 AM
kfunk added a reviewer for D27341: message: Never turn an Image into NormalText: mlaurent.
Wed, Feb 12, 8:44 AM
kfunk committed R865:93968a0f1cf8: qml: Fix missing negation (authored by kfunk).
qml: Fix missing negation
Wed, Feb 12, 8:44 AM
kfunk requested review of D27341: message: Never turn an Image into NormalText.
Wed, Feb 12, 8:43 AM
kfunk committed R865:500c8e32892e: RocketChatAccount: Try to reduce delegating funcs (authored by kfunk).
RocketChatAccount: Try to reduce delegating funcs
Wed, Feb 12, 7:26 AM
kfunk closed D27317: RocketChatAccount: Try to reduce delegating funcs.
Wed, Feb 12, 7:26 AM

Tue, Feb 11

kfunk committed R865:a4d140a85569: qml: Remove unused PersonsListView (authored by kfunk).
qml: Remove unused PersonsListView
Tue, Feb 11, 2:01 PM
kfunk committed R865:fc201826cf02: qml: Greatly simplify MessageMenu (authored by kfunk).
qml: Greatly simplify MessageMenu
Tue, Feb 11, 2:01 PM
kfunk committed R865:299c18a2c690: qml: Fix a few typos in file names, ids (authored by kfunk).
qml: Fix a few typos in file names, ids
Tue, Feb 11, 2:01 PM
kfunk committed R865:5a55d811049b: qml: Use ClickableLabel more (authored by kfunk).
qml: Use ClickableLabel more
Tue, Feb 11, 2:01 PM
kfunk committed R865:1c6e26504d0f: qml: Introduce Button.qml (authored by kfunk).
qml: Introduce Button.qml
Tue, Feb 11, 2:01 PM
kfunk committed R865:6027172a24b7: Minor: Fix redundant init of member (authored by kfunk).
Minor: Fix redundant init of member
Tue, Feb 11, 11:44 AM
kfunk committed R865:a62aae06ed54: Modernize code: Use override where possible (authored by kfunk).
Modernize code: Use override where possible
Tue, Feb 11, 11:44 AM
kfunk committed R865:1d7c00c876b7: qml: Fix warning about anchors in layouts (authored by kfunk).
qml: Fix warning about anchors in layouts
Tue, Feb 11, 11:44 AM
kfunk requested review of D27317: RocketChatAccount: Try to reduce delegating funcs.
Tue, Feb 11, 11:44 AM
kfunk committed R865:ba76b1b27af0: qml: Use disabledTextColor instead of opacity 0.5 (authored by kfunk).
qml: Use disabledTextColor instead of opacity 0.5
Tue, Feb 11, 8:22 AM
kfunk committed R865:d2f8a9eeb868: Change message background on mouse hover (authored by alessandro).
Change message background on mouse hover
Tue, Feb 11, 8:04 AM
kfunk closed D27248: Change message background on mouse hover.
Tue, Feb 11, 8:04 AM
kfunk accepted D27248: Change message background on mouse hover.
Tue, Feb 11, 8:02 AM

Mon, Feb 10

kfunk committed R865:1bcf8e0cbdbf: qml: Introduce ClickableLabel (authored by kfunk).
qml: Introduce ClickableLabel
Mon, Feb 10, 8:34 PM
kfunk committed R865:5cea60083604: qml: UserMessage: Improve look of username/alias (authored by kfunk).
qml: UserMessage: Improve look of username/alias
Mon, Feb 10, 8:34 PM
kfunk committed R865:40897806c7c1: cmake: Use find_package(... CONFIG) more (authored by kfunk).
cmake: Use find_package(... CONFIG) more
Mon, Feb 10, 8:34 PM
kfunk added a comment to D27248: Change message background on mouse hover.

Okay, could you please rebase that patch? No longer applies.

Mon, Feb 10, 7:27 PM
kfunk committed R865:f305535cb004: cmake: Prefer using #cmakedefine01 (authored by kfunk).
cmake: Prefer using #cmakedefine01
Mon, Feb 10, 7:15 PM
kfunk committed R865:b7cb605efe27: cmake: Simplify CMake code a bit (authored by kfunk).
cmake: Simplify CMake code a bit
Mon, Feb 10, 7:15 PM
kfunk committed R865:648065164873: Minor: Fix warning about redundant 'static' (authored by kfunk).
Minor: Fix warning about redundant 'static'
Mon, Feb 10, 7:15 PM
kfunk committed R865:ccde003a3e83: Improve markdownToRichText (authored by kfunk).
Improve markdownToRichText
Mon, Feb 10, 3:10 PM
kfunk closed D27286: Improve markdownToRichText.
Mon, Feb 10, 3:10 PM
kfunk committed R865:4d85cfe2ca66: Update .gitignore (authored by kfunk).
Update .gitignore
Mon, Feb 10, 2:45 PM
kfunk updated the diff for D27286: Improve markdownToRichText.

Fix another typo...

Mon, Feb 10, 2:44 PM
kfunk updated the diff for D27286: Improve markdownToRichText.

Improve naming in test

Mon, Feb 10, 2:34 PM
kfunk updated the diff for D27286: Improve markdownToRichText.

Typo fix

Mon, Feb 10, 2:32 PM
kfunk added a reviewer for D27286: Improve markdownToRichText: dfaure.
Mon, Feb 10, 2:29 PM
kfunk added a reviewer for D27286: Improve markdownToRichText: mlaurent.

Not sure I like this change myself but it fixes support for [](). Other ideas welcome.

Mon, Feb 10, 2:27 PM
kfunk requested review of D27286: Improve markdownToRichText.
Mon, Feb 10, 2:26 PM
kfunk committed R865:af1ae039d2f3: qml: RoomsView: Dont always follow highlight (authored by kfunk).
qml: RoomsView: Dont always follow highlight
Mon, Feb 10, 9:48 AM
kfunk committed R865:e18f3457a59b: Remove extra vertical space from FancyMessageDelegate, message items include… (authored by alessandro).
Remove extra vertical space from FancyMessageDelegate, message items include…
Mon, Feb 10, 7:53 AM
kfunk closed D27256: Remove extra vertical space from FancyMessageDelegate, message items include their own margins now.
Mon, Feb 10, 7:53 AM
kfunk accepted D27256: Remove extra vertical space from FancyMessageDelegate, message items include their own margins now.
Mon, Feb 10, 7:53 AM
kfunk committed R865:8357b7c85ce8: Adjust message layout (authored by alessandro).
Adjust message layout
Mon, Feb 10, 7:49 AM
kfunk closed D27254: Adjust message layout.
Mon, Feb 10, 7:49 AM
kfunk accepted D27254: Adjust message layout.
Mon, Feb 10, 7:48 AM
kfunk committed R865:89192d6b942d: Remove Layout/anchor properties from AvatarImage definition and use as needed… (authored by alessandro).
Remove Layout/anchor properties from AvatarImage definition and use as needed…
Mon, Feb 10, 7:44 AM
kfunk closed D27253: Remove Layout/anchor properties from AvatarImage definition and use as needed on instances instead.
Mon, Feb 10, 7:44 AM
kfunk accepted D27253: Remove Layout/anchor properties from AvatarImage definition and use as needed on instances instead.
Mon, Feb 10, 7:44 AM
kfunk committed R865:44d570888415: Make reaction popup transparent when necessary instead of hiding it so the… (authored by alessandro).
Make reaction popup transparent when necessary instead of hiding it so the…
Mon, Feb 10, 7:42 AM
kfunk closed D27249: Make reaction popup transparent when necessary instead of hiding it so the layout doesn't change when it's shown.
Mon, Feb 10, 7:42 AM
kfunk accepted D27249: Make reaction popup transparent when necessary instead of hiding it so the layout doesn't change when it's shown.
Mon, Feb 10, 7:42 AM
kfunk added a comment to D27229: Update message items.

One issue: When hovering through the the chat window the width of the message text is altered, looks a bit cumbersome. maybe it makes sense to just overlay the icon over the message text like RC does?

Mon, Feb 10, 7:42 AM
kfunk requested changes to D27248: Change message background on mouse hover.
Mon, Feb 10, 7:38 AM
kfunk added a comment to D27244: Make MessageBase an Item instead of a ColumnLayout.

See https://phabricator.kde.org/D27229 (duplicate) for further comments.

Mon, Feb 10, 7:31 AM
kfunk committed R865:2176d37b1dd9: Make MessageBase an Item instead of a ColumnLayout (authored by alessandro).
Make MessageBase an Item instead of a ColumnLayout
Mon, Feb 10, 7:30 AM
kfunk closed D27244: Make MessageBase an Item instead of a ColumnLayout.
Mon, Feb 10, 7:30 AM
kfunk added a comment to D27229: Update message items.

Superseded by https://phabricator.kde.org/D27229 -- could one of you close this?

Mon, Feb 10, 7:30 AM
kfunk added a comment to D27229: Update message items.

Show reaction button only when hovering on a message

Mon, Feb 10, 7:28 AM

Fri, Feb 7

kfunk committed R865:9dd0a0a4dd14: qml: MessageLine: Try harder catch key events (authored by kfunk).
qml: MessageLine: Try harder catch key events
Fri, Feb 7, 12:04 PM
kfunk committed R240:fafbc8cec665: ECMGeneratePriFile: Fix static configurations (authored by kfunk).
ECMGeneratePriFile: Fix static configurations
Fri, Feb 7, 11:03 AM
kfunk closed D26394: ECMGeneratePriFile: Fix static configurations.
Fri, Feb 7, 11:03 AM · Build System, Frameworks
kfunk committed R865:4e45b6cca56c: qml: MessageLine: Set text format to plain text (authored by kfunk).
qml: MessageLine: Set text format to plain text
Fri, Feb 7, 10:46 AM
kfunk committed R865:9560713e822d: Make compile with Qt 5.12 (authored by kfunk).
Make compile with Qt 5.12
Fri, Feb 7, 7:53 AM

Thu, Feb 6

kfunk committed R865:416fde8f5b45: Modernize code: Use auto where useful (authored by kfunk).
Modernize code: Use auto where useful
Thu, Feb 6, 6:40 PM
kfunk committed R865:6d54e4f9b2ba: qml: MessageLine: Fix pos when completing names (authored by kfunk).
qml: MessageLine: Fix pos when completing names
Thu, Feb 6, 4:14 PM
kfunk committed R865:9c9ea959656b: qml: MessageLine: Accept up+down in text area (authored by kfunk).
qml: MessageLine: Accept up+down in text area
Thu, Feb 6, 4:14 PM
kfunk committed R865:099591dc39f0: qml: MessageLine: Remove debug code (authored by kfunk).
qml: MessageLine: Remove debug code
Thu, Feb 6, 3:59 PM
kfunk committed R865:eef104fd5813: qml: MessageLine: Multi-line input implemented (authored by kfunk).
qml: MessageLine: Multi-line input implemented
Thu, Feb 6, 3:52 PM
kfunk committed R865:9414d77dc9bb: qml: MessageLine: Refactor a little (authored by kfunk).
qml: MessageLine: Refactor a little
Thu, Feb 6, 3:52 PM
kfunk committed R865:e25bba5d4663: qml: Fix i18n warning (authored by kfunk).
qml: Fix i18n warning
Thu, Feb 6, 3:12 PM
kfunk committed R865:4f9edafd40c1: qml: Handle negative inputs in JS' module op (authored by kfunk).
qml: Handle negative inputs in JS' module op
Thu, Feb 6, 12:37 PM
kfunk committed R865:fd167c9f2e6c: qml: Select prev/next channel with Alt+Down/Up (authored by kfunk).
qml: Select prev/next channel with Alt+Down/Up
Thu, Feb 6, 12:26 PM
kfunk committed R865:45e9ed1b4a37: qml: Use correct currentIndex in RoomsView (authored by kfunk).
qml: Use correct currentIndex in RoomsView
Thu, Feb 6, 12:08 PM
kfunk committed R865:b853dac2b889: qml: MessageLine: Fix height for completion popup (authored by kfunk).
qml: MessageLine: Fix height for completion popup
Thu, Feb 6, 11:06 AM
kfunk committed R865:1fe6e9d4f4b4: qml: Login: Listen to new socketError signal (authored by kfunk).
qml: Login: Listen to new socketError signal
Thu, Feb 6, 10:56 AM
kfunk committed R865:842438e1c586: qml: Login: Accept when return is pressed (authored by kfunk).
qml: Login: Accept when return is pressed
Thu, Feb 6, 10:56 AM

Fri, Jan 31

kfunk committed R865:c1de865033f1: Fix avatar cache storage (authored by alessandro).
Fix avatar cache storage
Fri, Jan 31, 8:04 AM
kfunk closed D27042: Fix avatar cache storage.
Fri, Jan 31, 8:04 AM
kfunk committed R865:69b7dbdff789: Fix compilation on Windows (authored by alessandro).
Fix compilation on Windows
Fri, Jan 31, 8:04 AM
kfunk closed D27043: Fix compilation on Windows.
Fri, Jan 31, 8:04 AM
kfunk committed R865:faeadc3a5713: widgets: Restore compat with Qt 5.12 (authored by kfunk).
widgets: Restore compat with Qt 5.12
Fri, Jan 31, 7:58 AM

Thu, Jan 30

kfunk committed R865:fb24aefbaf3d: qml: UserMessage: edited-by icon should be last (authored by kfunk).
qml: UserMessage: edited-by icon should be last
Thu, Jan 30, 10:35 PM
kfunk accepted D27042: Fix avatar cache storage.
Thu, Jan 30, 10:15 PM
kfunk committed R865:c2fd03336e33: qml: Base messages more on UserMessage (authored by kfunk).
qml: Base messages more on UserMessage
Thu, Jan 30, 10:07 PM
kfunk committed R865:d5e4406979eb: qml: This time with margins (authored by kfunk).
qml: This time with margins
Thu, Jan 30, 3:05 PM
kfunk committed R865:a3d0d1d5dca7: qml: Resolve binding loop (authored by kfunk).
qml: Resolve binding loop
Thu, Jan 30, 2:52 PM
kfunk committed R865:ac211d596929: qml: Fix normal view mode (authored by kfunk).
qml: Fix normal view mode
Thu, Jan 30, 2:20 PM
kfunk committed R865:dd62ab3af10c: qml: Fix binding overwrite warning (authored by kfunk).
qml: Fix binding overwrite warning
Thu, Jan 30, 2:20 PM
kfunk committed R865:482b2e362a65: qml: UserMessage: Better looking author label (authored by kfunk).
qml: UserMessage: Better looking author label
Thu, Jan 30, 12:17 PM
kfunk committed R865:62530d391c12: qml: ReactionsPopup: Less visibility for icon (authored by kfunk).
qml: ReactionsPopup: Less visibility for icon
Thu, Jan 30, 11:18 AM
kfunk committed R865:5cf2f9ed7f4d: qml: UserMessage: Fix alignment of username+icons (authored by kfunk).
qml: UserMessage: Fix alignment of username+icons
Thu, Jan 30, 10:32 AM
kfunk committed R865:b692fd025a84: qml: UserMessage: Show edited-by as icon (authored by kfunk).
qml: UserMessage: Show edited-by as icon
Thu, Jan 30, 10:26 AM
kfunk committed R865:c2c8384ab0bd: qml: Fix roles info icon position (authored by kfunk).
qml: Fix roles info icon position
Thu, Jan 30, 10:08 AM