kfunk (Kevin Funk)
Software Engineer

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jun 12 2015, 1:04 PM (227 w, 1 d)
Availability
Available

Recent Activity

Fri, Oct 4

kfunk committed R32:ad0cbbb82d8d: cmake: FindClang: Detect llvm-project.git checkout (authored by kfunk).
cmake: FindClang: Detect llvm-project.git checkout
Fri, Oct 4, 7:33 PM

Mon, Sep 30

kfunk added a comment to T9594: Publish Filelight in the Microsoft Store.

This keeps getting better! Great work to all involved!

Mon, Sep 30, 2:53 PM · Windows

Sep 16 2019

kfunk committed R120:49676fe2cca6: ASAN: Fix leak in KAStatsFavoritesModel (authored by kfunk).
ASAN: Fix leak in KAStatsFavoritesModel
Sep 16 2019, 12:17 PM
kfunk committed R120:35ac6472c39b: Minor: Fix -Wextra-semi warning (authored by kfunk).
Minor: Fix -Wextra-semi warning
Sep 16 2019, 12:17 PM
kfunk committed R120:429b2ef43b0a: clang-tidy: use-modernize-nullptr run (authored by kfunk).
clang-tidy: use-modernize-nullptr run
Sep 16 2019, 12:17 PM
kfunk committed R120:8c70a2cbbb53: clang-tidy: use-modernize-override run (authored by kfunk).
clang-tidy: use-modernize-override run
Sep 16 2019, 12:17 PM
kfunk committed R120:61101cf7c983: Make compile with Qt 5.4 (authored by kfunk).
Make compile with Qt 5.4
Sep 16 2019, 12:14 PM

Sep 5 2019

kfunk committed R32:a92975200461: Merge remote-tracking branch 'origin/5.4' (authored by kfunk).
Merge remote-tracking branch 'origin/5.4'
Sep 5 2019, 8:39 AM

Aug 14 2019

kfunk added a comment to D23035: Simplify ctors with default member initializer.

I think Dominik is right and = would be nicer.

Aug 14 2019, 2:03 PM · Kate

Aug 5 2019

kfunk committed R487:7ef2e5d39b54: clang-tidy: use-modernize-nullptr run (authored by kfunk).
clang-tidy: use-modernize-nullptr run
Aug 5 2019, 12:12 PM

Jul 19 2019

kfunk accepted D22559: Bump min dep versions of Qt & KF to 5.9 & 5.44.

Sorry for my conservative thinking again: Debian Buster (10) is still /very/ fresh; it was just released a couple days ago. The former "oldest" supported distro was Debian Stretch (9) with Qt 5.7 and KF 5.28. That'll stick around for some time.

Jul 19 2019, 3:12 PM · KDevelop

Jul 18 2019

kfunk committed R32:125259eab4dd: Add missing include (authored by tcanabrava).
Add missing include
Jul 18 2019, 5:22 PM

Jun 26 2019

kfunk added a comment to D21156: Fix browse mode not disabled after Ctrl is released.

Oh, I usually squash my changes into the original commit before uploading the change (i.e. via arc diff). I do not use an extra branch either.

Jun 26 2019, 12:07 PM · Documentation, KDevelop
kfunk added a comment to D21156: Fix browse mode not disabled after Ctrl is released.

Huh? It's easier than that:

Jun 26 2019, 11:08 AM · Documentation, KDevelop
kfunk added a comment to D21156: Fix browse mode not disabled after Ctrl is released.

If you're not using arc you should have included the "Differential Revision" line in the commit so it would close automatically as stated in https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages

I'll close this manually for you :)

In the phabricator guide it is suggested to push manually when the target branch in not master:

https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22

Wouldn't make more sense to do arc land --onto 5.3 (and then merge 5.3 into master)? In this way the Differential Revision would be closed automatically.

Jun 26 2019, 8:33 AM · Documentation, KDevelop

Jun 24 2019

kfunk committed R32:58adfaab7af9: Attempt to fix a crash on shutdown (authored by thomassc).
Attempt to fix a crash on shutdown
Jun 24 2019, 8:28 AM

Jun 3 2019

kfunk committed R32:6be8e8aeafa6: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
Jun 3 2019, 5:39 PM

May 29 2019

kfunk committed R32:eb840b27f780: clang: fix test bench_codecompletion compilation (authored by kfunk).
clang: fix test bench_codecompletion compilation
May 29 2019, 8:52 AM
kfunk closed D21458: clang: fix test bench_codecompletion compilation.
May 29 2019, 8:52 AM · KDevelop

May 27 2019

kfunk committed R53:6aba6119c8f4: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
May 27 2019, 9:30 AM
kfunk committed R53:efe486755865: cmake: Manage version through project() function (authored by kfunk).
cmake: Manage version through project() function
May 27 2019, 9:30 AM
kfunk committed R52:2cdc0a7b040d: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
May 27 2019, 9:30 AM
kfunk committed R52:340c5f32500f: Minor: Remove unused file (authored by kfunk).
Minor: Remove unused file
May 27 2019, 9:28 AM
kfunk committed R52:ac06034667cd: cmake: Manage version through project() function (authored by kfunk).
cmake: Manage version through project() function
May 27 2019, 9:28 AM
kfunk committed R32:c9df8b5791f1: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
May 27 2019, 9:21 AM
kfunk committed R32:8d28b61084c6: Minor: Remove whitespace before EOL (authored by kfunk).
Minor: Remove whitespace before EOL
May 27 2019, 8:17 AM
kfunk committed R32:29796b7dd3c7: bash-completions: Make sure install dir is found (authored by kfunk).
bash-completions: Make sure install dir is found
May 27 2019, 6:52 AM
kfunk committed R32:b2d202225cdb: astyle: support the system astyle library (authored by pino).
astyle: support the system astyle library
May 27 2019, 6:43 AM
kfunk closed D17760: astyle: support the system astyle library.
May 27 2019, 6:43 AM · KDevelop
kfunk committed R32:4987b64db834: Renovate kdevelop bash completion file (authored by kfunk).
Renovate kdevelop bash completion file
May 27 2019, 6:42 AM
kfunk accepted D17760: astyle: support the system astyle library.

Works fine for me on Ubuntu 19.04 -- lgtm!

May 27 2019, 6:36 AM · KDevelop

May 23 2019

kfunk committed R247:d9d8d65e3159: kdevelop-pg-qt: Set stable branch to 2.2 (authored by kfunk).
kdevelop-pg-qt: Set stable branch to 2.2
May 23 2019, 7:42 PM
kfunk committed R499:db0433a9edee: kdevelop-pg-qt: Set stable branch to 2.2 (authored by kfunk).
kdevelop-pg-qt: Set stable branch to 2.2
May 23 2019, 7:31 PM
kfunk committed R51:ab1fcf86ac7b: Set version to 2.2.0 (authored by kfunk).
Set version to 2.2.0
May 23 2019, 7:25 PM
kfunk committed R32:3903e400f0f8: cmakebuilddirchooser: Set a minimum size (authored by kfunk).
cmakebuilddirchooser: Set a minimum size
May 23 2019, 7:17 PM
kfunk committed R32:56c41656029d: Fix memory leaks reported by ASAN (authored by kfunk).
Fix memory leaks reported by ASAN
May 23 2019, 7:17 PM

May 15 2019

kfunk added a comment to R32:bbd5d4812d87: Merge remote-tracking branch 'origin/5.3'.

It has been failing before: https://invent.kde.org/kde/kdevelop/-/jobs -- The error output suggests it's a different issue.

May 15 2019, 5:16 AM

May 12 2019

kfunk committed R32:bbd5d4812d87: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
May 12 2019, 8:49 AM

May 10 2019

kfunk committed R32:f543df17fe44: qmake: Move builder plugin to correct category (authored by kfunk).
qmake: Move builder plugin to correct category
May 10 2019, 6:43 PM

Apr 30 2019

kfunk accepted D20920: Add DesktopEntry to notifyrc.

Feel free to push it into the 5.3 branch then.

Apr 30 2019, 2:03 PM · KDevelop

Apr 26 2019

kfunk committed R174:3e481822ec8d: Perf: VCardParser: Minor optimization (authored by kfunk).
Perf: VCardParser: Minor optimization
Apr 26 2019, 11:18 AM
kfunk committed R92:6739d2ee9d2a: snippets: Add icon for 'insert snippet' action (authored by kfunk).
snippets: Add icon for 'insert snippet' action
Apr 26 2019, 9:03 AM

Apr 25 2019

kfunk committed R124:e3528f473993: Minor: CMake: Use CONFIG search mode more (authored by kfunk).
Minor: CMake: Use CONFIG search mode more
Apr 25 2019, 7:12 AM

Apr 24 2019

kfunk committed R499:5fac47995089: kdevelop no longer needs kdevplatform (authored by kfunk).
kdevelop no longer needs kdevplatform
Apr 24 2019, 9:28 AM
kfunk committed R51:2514874d3018: Remove explicit use of ECM_KDE_MODULE_DIR, is part of ECM_MODULE_PATH (authored by kossebau).
Remove explicit use of ECM_KDE_MODULE_DIR, is part of ECM_MODULE_PATH
Apr 24 2019, 6:47 AM
kfunk committed R51:7378b686ffcc: Move KDECMakeSettings & KDEInstallDirs before other cmake includes (authored by kossebau).
Move KDECMakeSettings & KDEInstallDirs before other cmake includes
Apr 24 2019, 6:47 AM
kfunk committed R51:d6339b91f6e1: Generate code that uses nullptr & override (authored by kossebau).
Generate code that uses nullptr & override
Apr 24 2019, 6:47 AM
kfunk committed R51:defb4cc5a23d: Use consistently CamelCase Qt includes (authored by kossebau).
Use consistently CamelCase Qt includes
Apr 24 2019, 6:47 AM
kfunk committed R51:cd49369d5779: Remove module prefixes from Qt includes, in own code and generated (authored by kossebau).
Remove module prefixes from Qt includes, in own code and generated
Apr 24 2019, 6:47 AM
kfunk committed R51:4fc69f68f025: Support BUILD_TESTING (authored by kossebau).
Support BUILD_TESTING
Apr 24 2019, 6:47 AM
kfunk committed R51:da4b4ba97165: Enforce more modern Qt (authored by kossebau).
Enforce more modern Qt
Apr 24 2019, 6:47 AM
kfunk committed R51:791a13c7a9c4: Use cmake project version logic (authored by kossebau).
Use cmake project version logic
Apr 24 2019, 6:47 AM
kfunk committed R51:b59260121e7c: Bump Qt & ECM min version to those of kdevelop 5.2 (authored by kossebau).
Bump Qt & ECM min version to those of kdevelop 5.2
Apr 24 2019, 6:47 AM
kfunk committed R51:5bdcbdab632e: Use Q_SLOTS (authored by kossebau).
Use Q_SLOTS
Apr 24 2019, 6:47 AM
kfunk committed R51:8353ea9de663: Bump min cmake version to 3.0, switch to CMakePackageConfigHelpers (authored by kossebau).
Bump min cmake version to 3.0, switch to CMakePackageConfigHelpers
Apr 24 2019, 6:47 AM
kfunk committed R51:bb9584f059eb: Remove enable_testing(), covered by KDECMakeSettings (authored by kossebau).
Remove enable_testing(), covered by KDECMakeSettings
Apr 24 2019, 6:47 AM
kfunk committed R32:ab962476559e: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
Apr 24 2019, 5:45 AM

Apr 15 2019

kfunk added a comment to D20560: Incidence Dialog: don't show an empty message widget initially..

Thanks for fixing!

Apr 15 2019, 5:26 AM · KDE PIM

Apr 1 2019

kfunk added a comment to D18758: Make Project::open() method use async KIO methods..

As long as it integrates well with the rest of the KDevelop build I'm fine. Would probably just copy the QtPromise source tree into maybe kdevelop.git:3rdparty/ and create a CMakeLists.txt which creates a STATIC or OBJECT library for it? QtPromise looks easy enough to build.

Apr 1 2019, 5:44 PM · KDevelop
kfunk committed R459:2f552ac57377: Fix windows build (authored by kfunk).
Fix windows build
Apr 1 2019, 8:27 AM
kfunk closed D18523: Fix windows build.
Apr 1 2019, 8:27 AM · KDE PIM
kfunk added a comment to D18523: Fix windows build.

This works, yes, I don't see how that change could break it.

Apr 1 2019, 8:10 AM · KDE PIM
kfunk added inline comments to D20142: DVCS Branch Manager with filtering and sorting proposal.
Apr 1 2019, 6:39 AM · KDevelop, VDG

Mar 13 2019

kfunk added a comment to D19673: Discovered unit-tests using bracket arguments and/or listed in files other than CTestTestFile.cmake.

Note: It's Thibault North <thibault.north@gmail.com>

Mar 13 2019, 4:13 PM · KDevelop

Mar 12 2019

kfunk committed R79:73792f82cdbd: Turn nullptr into {} when initializing flags (authored by kfunk).
Turn nullptr into {} when initializing flags
Mar 12 2019, 6:48 PM
kfunk committed R79:607f676fa72b: Use more nullptr (authored by kfunk).
Use more nullptr
Mar 12 2019, 12:00 PM

Mar 7 2019

kfunk committed R53:74f29df58bc1: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
Mar 7 2019, 11:00 AM
kfunk committed R52:54ffaa49f9da: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
Mar 7 2019, 10:59 AM
kfunk committed R32:75c3f4a979f6: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
Mar 7 2019, 10:59 AM
kfunk closed D19578: tagme: Do not use git push --tags.
Mar 7 2019, 10:23 AM
kfunk committed R572:1ac3decab112: tagme: Do not use git push --tags (authored by kfunk).
tagme: Do not use git push --tags
Mar 7 2019, 10:23 AM
kfunk added a comment to D19584: Put python3 from the system before python3 from dev-utils/bin in the PATH.

FTR: I think I experienced the same or a similar issue.

Mar 7 2019, 10:23 AM
kfunk committed R877:6512ae49617f: kdevelop: Default to 5.3.2 (authored by kfunk).
kdevelop: Default to 5.3.2
Mar 7 2019, 8:07 AM
kfunk added a comment to D19578: tagme: Do not use git push --tags.

By the way, also see: https://stackoverflow.com/a/5195913 wrt why it is dangerous.

Mar 7 2019, 7:33 AM
kfunk added reviewers for D19578: tagme: Do not use git push --tags: sitter, bcooksley.
Mar 7 2019, 7:27 AM
kfunk requested review of D19578: tagme: Do not use git push --tags.
Mar 7 2019, 7:26 AM
kfunk committed R52:bbf26294f50b: Set version number to 5.3.2 (authored by kfunk).
Set version number to 5.3.2
Mar 7 2019, 6:57 AM
kfunk committed R53:0092020c2d71: Set version number to 5.3.2 (authored by kfunk).
Set version number to 5.3.2
Mar 7 2019, 6:55 AM
kfunk committed R32:48bdc10109ca: Set version number to 5.3.2 (authored by kfunk).
Set version number to 5.3.2
Mar 7 2019, 6:42 AM

Mar 6 2019

kfunk accepted D19457: Resurrect kdev-java.

Only had a brief look, but this looks good to me! Well, better than letting it bit-rot.

Mar 6 2019, 7:52 AM · KDevelop

Feb 19 2019

kfunk committed R32:3c2725a67d3a: [Sessions Runner] Use icon name (authored by kfunk).
[Sessions Runner] Use icon name
Feb 19 2019, 3:42 PM
kfunk closed D19159: [Sessions Runner] Use icon name.
Feb 19 2019, 3:42 PM · KDevelop
kfunk accepted D19159: [Sessions Runner] Use icon name.
Feb 19 2019, 3:22 PM · KDevelop
kfunk committed R32:d96d759a925d: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
Feb 19 2019, 8:53 AM

Feb 8 2019

kfunk committed R32:8bae72e6096b: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
Feb 8 2019, 10:55 AM
kfunk committed R32:af5696392493: Workaround the bug found by ASan, which can be seen on FreeBSD CI. (authored by arrowd).
Workaround the bug found by ASan, which can be seen on FreeBSD CI.
Feb 8 2019, 10:54 AM

Feb 5 2019

kfunk added a comment to D18463: Workaround the bug found by ASan, which can be seen on FreeBSD CI..

Commit message ideally. Truncate the report where applicable.

Feb 5 2019, 9:29 AM · KDevelop

Jan 25 2019

kfunk added a reviewer for D18523: Fix windows build: mlaurent.
Jan 25 2019, 12:45 PM · KDE PIM
kfunk added a reviewer for D18523: Fix windows build: sengels.
Jan 25 2019, 12:45 PM · KDE PIM
kfunk requested review of D18523: Fix windows build.
Jan 25 2019, 12:44 PM · KDE PIM

Jan 14 2019

kfunk committed R32:5cf8981ae53c: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
Jan 14 2019, 4:32 AM

Jan 12 2019

kfunk accepted D10115: Fix unused parameters warnings.

LGTM

Jan 12 2019, 12:21 PM

Jan 11 2019

kfunk committed R32:71c65a65917a: Clang plugin: Handle CUDA files better (authored by thomassc).
Clang plugin: Handle CUDA files better
Jan 11 2019, 8:49 AM
kfunk closed D17909: Clang plugin: Handle CUDA files better.
Jan 11 2019, 8:49 AM · KDevelop
kfunk accepted D18175: appimage: skip unneeded cp of cmake, removed later again.
Jan 11 2019, 8:47 AM · KDevelop

Jan 9 2019

kfunk added a comment to D17909: Clang plugin: Handle CUDA files better.

Could you give me your full name + email for attribution in the commit?

Jan 9 2019, 12:51 PM · KDevelop
kfunk accepted D17569: Allow configuring shortcut for Run Scratch action and add to Run menu.

I think that looks fine. Didn't test though.

Jan 9 2019, 11:22 AM · KDevelop
kfunk accepted D17888: appimage: add okteta libs, as used by the debugger memory view.

Why not.

Jan 9 2019, 10:34 AM · KDevelop
kfunk committed R32:7055e9d58af2: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
Jan 9 2019, 9:23 AM
kfunk committed R32:1dbebbab5f34: grewpview: Fix potential crash in "Find in Files" (authored by kfunk).
grewpview: Fix potential crash in "Find in Files"
Jan 9 2019, 9:17 AM