kfunk (Kevin Funk)
Software Engineer

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jun 12 2015, 1:04 PM (201 w, 6 d)
Availability
Available

Recent Activity

Yesterday

kfunk committed R124:e3528f473993: Minor: CMake: Use CONFIG search mode more (authored by kfunk).
Minor: CMake: Use CONFIG search mode more
Thu, Apr 25, 7:12 AM

Wed, Apr 24

kfunk committed R499:5fac47995089: kdevelop no longer needs kdevplatform (authored by kfunk).
kdevelop no longer needs kdevplatform
Wed, Apr 24, 9:28 AM
kfunk committed R51:2514874d3018: Remove explicit use of ECM_KDE_MODULE_DIR, is part of ECM_MODULE_PATH (authored by kossebau).
Remove explicit use of ECM_KDE_MODULE_DIR, is part of ECM_MODULE_PATH
Wed, Apr 24, 6:47 AM
kfunk committed R51:7378b686ffcc: Move KDECMakeSettings & KDEInstallDirs before other cmake includes (authored by kossebau).
Move KDECMakeSettings & KDEInstallDirs before other cmake includes
Wed, Apr 24, 6:47 AM
kfunk committed R51:d6339b91f6e1: Generate code that uses nullptr & override (authored by kossebau).
Generate code that uses nullptr & override
Wed, Apr 24, 6:47 AM
kfunk committed R51:defb4cc5a23d: Use consistently CamelCase Qt includes (authored by kossebau).
Use consistently CamelCase Qt includes
Wed, Apr 24, 6:47 AM
kfunk committed R51:cd49369d5779: Remove module prefixes from Qt includes, in own code and generated (authored by kossebau).
Remove module prefixes from Qt includes, in own code and generated
Wed, Apr 24, 6:47 AM
kfunk committed R51:4fc69f68f025: Support BUILD_TESTING (authored by kossebau).
Support BUILD_TESTING
Wed, Apr 24, 6:47 AM
kfunk committed R51:da4b4ba97165: Enforce more modern Qt (authored by kossebau).
Enforce more modern Qt
Wed, Apr 24, 6:47 AM
kfunk committed R51:791a13c7a9c4: Use cmake project version logic (authored by kossebau).
Use cmake project version logic
Wed, Apr 24, 6:47 AM
kfunk committed R51:b59260121e7c: Bump Qt & ECM min version to those of kdevelop 5.2 (authored by kossebau).
Bump Qt & ECM min version to those of kdevelop 5.2
Wed, Apr 24, 6:47 AM
kfunk committed R51:5bdcbdab632e: Use Q_SLOTS (authored by kossebau).
Use Q_SLOTS
Wed, Apr 24, 6:47 AM
kfunk committed R51:8353ea9de663: Bump min cmake version to 3.0, switch to CMakePackageConfigHelpers (authored by kossebau).
Bump min cmake version to 3.0, switch to CMakePackageConfigHelpers
Wed, Apr 24, 6:47 AM
kfunk committed R51:bb9584f059eb: Remove enable_testing(), covered by KDECMakeSettings (authored by kossebau).
Remove enable_testing(), covered by KDECMakeSettings
Wed, Apr 24, 6:47 AM
kfunk committed R32:ab962476559e: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
Wed, Apr 24, 5:45 AM

Mon, Apr 15

kfunk added a comment to D20560: Incidence Dialog: don't show an empty message widget initially..

Thanks for fixing!

Mon, Apr 15, 5:26 AM · KDE PIM

Mon, Apr 1

kfunk added a comment to D18758: Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted..

As long as it integrates well with the rest of the KDevelop build I'm fine. Would probably just copy the QtPromise source tree into maybe kdevelop.git:3rdparty/ and create a CMakeLists.txt which creates a STATIC or OBJECT library for it? QtPromise looks easy enough to build.

Mon, Apr 1, 5:44 PM · KDevelop
kfunk committed R459:2f552ac57377: Fix windows build (authored by kfunk).
Fix windows build
Mon, Apr 1, 8:27 AM
kfunk closed D18523: Fix windows build.
Mon, Apr 1, 8:27 AM · KDE PIM
kfunk added a comment to D18523: Fix windows build.

This works, yes, I don't see how that change could break it.

Mon, Apr 1, 8:10 AM · KDE PIM
kfunk added inline comments to D20142: DVCS Branch Manager with filtering and sorting proposal.
Mon, Apr 1, 6:39 AM · KDevelop, VDG

Mar 13 2019

kfunk added a comment to D19673: Discovered unit-tests using bracket arguments and/or listed in files other than CTestTestFile.cmake.

Note: It's Thibault North <thibault.north@gmail.com>

Mar 13 2019, 4:13 PM · KDevelop

Mar 12 2019

kfunk committed R79:73792f82cdbd: Turn nullptr into {} when initializing flags (authored by kfunk).
Turn nullptr into {} when initializing flags
Mar 12 2019, 6:48 PM
kfunk committed R79:607f676fa72b: Use more nullptr (authored by kfunk).
Use more nullptr
Mar 12 2019, 12:00 PM

Mar 7 2019

kfunk committed R53:74f29df58bc1: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
Mar 7 2019, 11:00 AM
kfunk committed R52:54ffaa49f9da: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
Mar 7 2019, 10:59 AM
kfunk committed R32:75c3f4a979f6: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
Mar 7 2019, 10:59 AM
kfunk closed D19578: tagme: Do not use git push --tags.
Mar 7 2019, 10:23 AM
kfunk committed R572:1ac3decab112: tagme: Do not use git push --tags (authored by kfunk).
tagme: Do not use git push --tags
Mar 7 2019, 10:23 AM
kfunk added a comment to D19584: Put python3 from the system before python3 from dev-utils/bin in the PATH.

FTR: I think I experienced the same or a similar issue.

Mar 7 2019, 10:23 AM
kfunk committed R877:6512ae49617f: kdevelop: Default to 5.3.2 (authored by kfunk).
kdevelop: Default to 5.3.2
Mar 7 2019, 8:07 AM
kfunk added a comment to D19578: tagme: Do not use git push --tags.

By the way, also see: https://stackoverflow.com/a/5195913 wrt why it is dangerous.

Mar 7 2019, 7:33 AM
kfunk added reviewers for D19578: tagme: Do not use git push --tags: sitter, bcooksley.
Mar 7 2019, 7:27 AM
kfunk requested review of D19578: tagme: Do not use git push --tags.
Mar 7 2019, 7:26 AM
kfunk committed R52:bbf26294f50b: Set version number to 5.3.2 (authored by kfunk).
Set version number to 5.3.2
Mar 7 2019, 6:57 AM
kfunk committed R53:0092020c2d71: Set version number to 5.3.2 (authored by kfunk).
Set version number to 5.3.2
Mar 7 2019, 6:55 AM
kfunk committed R32:48bdc10109ca: Set version number to 5.3.2 (authored by kfunk).
Set version number to 5.3.2
Mar 7 2019, 6:42 AM

Mar 6 2019

kfunk accepted D19457: Resurrect kdev-java.

Only had a brief look, but this looks good to me! Well, better than letting it bit-rot.

Mar 6 2019, 7:52 AM · KDevelop

Feb 19 2019

kfunk committed R32:3c2725a67d3a: [Sessions Runner] Use icon name (authored by kfunk).
[Sessions Runner] Use icon name
Feb 19 2019, 3:42 PM
kfunk closed D19159: [Sessions Runner] Use icon name.
Feb 19 2019, 3:42 PM · KDevelop
kfunk accepted D19159: [Sessions Runner] Use icon name.
Feb 19 2019, 3:22 PM · KDevelop
kfunk committed R32:d96d759a925d: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
Feb 19 2019, 8:53 AM

Feb 8 2019

kfunk committed R32:8bae72e6096b: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
Feb 8 2019, 10:55 AM
kfunk committed R32:af5696392493: Workaround the bug found by ASan, which can be seen on FreeBSD CI. (authored by arrowd).
Workaround the bug found by ASan, which can be seen on FreeBSD CI.
Feb 8 2019, 10:54 AM

Feb 5 2019

kfunk added a comment to D18463: Workaround the bug found by ASan, which can be seen on FreeBSD CI..

Commit message ideally. Truncate the report where applicable.

Feb 5 2019, 9:29 AM · KDevelop

Jan 25 2019

kfunk added a reviewer for D18523: Fix windows build: mlaurent.
Jan 25 2019, 12:45 PM · KDE PIM
kfunk added a reviewer for D18523: Fix windows build: sengels.
Jan 25 2019, 12:45 PM · KDE PIM
kfunk requested review of D18523: Fix windows build.
Jan 25 2019, 12:44 PM · KDE PIM

Jan 14 2019

kfunk committed R32:5cf8981ae53c: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
Jan 14 2019, 4:32 AM

Jan 12 2019

kfunk accepted D10115: Fix unused parameters warnings.

LGTM

Jan 12 2019, 12:21 PM

Jan 11 2019

kfunk committed R32:71c65a65917a: Clang plugin: Handle CUDA files better (authored by thomassc).
Clang plugin: Handle CUDA files better
Jan 11 2019, 8:49 AM
kfunk closed D17909: Clang plugin: Handle CUDA files better.
Jan 11 2019, 8:49 AM · KDevelop
kfunk accepted D18175: appimage: skip unneeded cp of cmake, removed later again.
Jan 11 2019, 8:47 AM · KDevelop

Jan 9 2019

kfunk added a comment to D17909: Clang plugin: Handle CUDA files better.

Could you give me your full name + email for attribution in the commit?

Jan 9 2019, 12:51 PM · KDevelop
kfunk accepted D17569: Allow configuring shortcut for Run Scratch action and add to Run menu.

I think that looks fine. Didn't test though.

Jan 9 2019, 11:22 AM · KDevelop
kfunk accepted D17888: appimage: add okteta libs, as used by the debugger memory view.

Why not.

Jan 9 2019, 10:34 AM · KDevelop
kfunk committed R32:7055e9d58af2: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
Jan 9 2019, 9:23 AM
kfunk committed R32:1dbebbab5f34: grewpview: Fix potential crash in "Find in Files" (authored by kfunk).
grewpview: Fix potential crash in "Find in Files"
Jan 9 2019, 9:17 AM
kfunk accepted D17909: Clang plugin: Handle CUDA files better.

Looks good to me. Can you push to 5.3 branch yourself?

Jan 9 2019, 8:59 AM · KDevelop
kfunk resigned from D5447: Only add auto-detected compilers to model if they actually exist.

@apol Something for you.

Jan 9 2019, 8:44 AM
kfunk added a comment to D18021: Add All Top-Level Targets to the Menu.

5.3 only please. Someone else (or even you) can merge it into master afterwards.

Jan 9 2019, 8:42 AM · KDevelop
kfunk committed R32:831daf9b42ce: meson: Build with KIO older than 5.33 (authored by kfunk).
meson: Build with KIO older than 5.33
Jan 9 2019, 8:29 AM
kfunk committed R32:96cb4100619b: Fix typo, sorry (authored by kfunk).
Fix typo, sorry
Jan 9 2019, 8:12 AM
kfunk committed R32:ce65a58df9b4: meson: Attempt to make compile with Qt 5.7 (authored by kfunk).
meson: Attempt to make compile with Qt 5.7
Jan 9 2019, 8:09 AM

Jan 8 2019

kfunk added a comment to R858:e1ec36138c99: Minor: Use nullptr.

Fixed with dcd5886fd949042765b905b3c67f9f20b18fb028

Jan 8 2019, 7:52 AM
kfunk committed R858:dcd5886fd949: Minor: Use {} for initializing flags (authored by kfunk).
Minor: Use {} for initializing flags
Jan 8 2019, 7:52 AM
kfunk committed R858:e1ec36138c99: Minor: Use nullptr (authored by kfunk).
Minor: Use nullptr
Jan 8 2019, 7:15 AM

Jan 7 2019

kfunk committed R52:49abff40a353: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
Jan 7 2019, 9:18 AM

Jan 6 2019

kfunk committed R53:1277a3a4853e: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
Jan 6 2019, 7:58 PM
kfunk committed R32:b51458d642db: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
Jan 6 2019, 7:52 PM

Dec 20 2018

kfunk committed R32:31e662eceff1: appimage: Strip libfreetype & libz (authored by kfunk).
appimage: Strip libfreetype & libz
Dec 20 2018, 10:19 PM

Dec 15 2018

kfunk committed R877:750a98bb81c1: grantlee: Add qtscript dep (authored by kfunk).
grantlee: Add qtscript dep
Dec 15 2018, 8:56 AM
kfunk added a comment to D17563: Don't crash with Qt 5.11+.

FYI: Patch looks good to me now, but I cannot judge whether it fixed the crash. So cannot give a +1.

Dec 15 2018, 8:48 AM · KDE PIM

Dec 14 2018

kfunk accepted D17575: Remove reliance on Qt 5.11+ QIODevice::NewOnly in the Scratchpad plugin.
Dec 14 2018, 10:30 AM · KDevelop
kfunk added inline comments to D17563: Don't crash with Qt 5.11+.
Dec 14 2018, 8:26 AM · KDE PIM

Dec 13 2018

kfunk added inline comments to D17563: Don't crash with Qt 5.11+.
Dec 13 2018, 4:49 PM · KDE PIM

Dec 11 2018

kfunk added inline comments to D16484: Add scratchpad plugin.
Dec 11 2018, 8:51 AM · KDevelop

Dec 10 2018

kfunk added a comment to D16484: Add scratchpad plugin.

Yep. please go for it.

Dec 10 2018, 9:53 AM · KDevelop
kfunk committed R32:2bd71e5f79ac: Revert "patchreview: Allow to translate string" (authored by kfunk).
Revert "patchreview: Allow to translate string"
Dec 10 2018, 8:48 AM
kfunk added a reverting change for R32:d91e22649ab1: patchreview: Allow to translate string: R32:2bd71e5f79ac: Revert "patchreview: Allow to translate string".
Dec 10 2018, 8:48 AM
kfunk added a comment to R32:d91e22649ab1: patchreview: Allow to translate string.

@pino I actually thought about the same, but was unsure since Aleix asked to have it translated. I agree with your explanation, it makes sense to have this not translated at all. Will revert.

Dec 10 2018, 8:46 AM
kfunk added inline comments to D16484: Add scratchpad plugin.
Dec 10 2018, 8:45 AM · KDevelop
kfunk committed R877:d2b848fbe24c: Remove dead quanta project (authored by kfunk).
Remove dead quanta project
Dec 10 2018, 8:31 AM
kfunk committed R877:3920ee0e97c2: kdevplatform as extra package is no more (authored by kfunk).
kdevplatform as extra package is no more
Dec 10 2018, 8:30 AM
kfunk committed R32:d91e22649ab1: patchreview: Allow to translate string (authored by kfunk).
patchreview: Allow to translate string
Dec 10 2018, 8:14 AM
kfunk committed R32:a41f7c00535a: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
Dec 10 2018, 8:14 AM
kfunk committed R32:18c0c9681068: patchreview: Fix string (authored by kfunk).
patchreview: Fix string
Dec 10 2018, 8:11 AM

Dec 7 2018

kfunk added a comment to T10154: Craft Qt5.12.0.

Nothing from my side.

Dec 7 2018, 3:50 PM

Dec 3 2018

kfunk accepted D16484: Add scratchpad plugin.
Dec 3 2018, 8:11 PM · KDevelop
kfunk updated the diff for D17325: Fix leak in kemoticons.

Use QSharedPointer

Dec 3 2018, 2:13 PM · Frameworks
kfunk added a comment to D17314: Projects Plugin: Add ShellCheck analyzer.

Just my 2 cent when I saw this review, didn't look further :)

Dec 3 2018, 1:59 PM · Kate
kfunk abandoned D17328: Fix leak in AkonadiCollectionView.

Running into a crash with that patch, need to revisit:

Dec 3 2018, 12:16 PM · KDE PIM
kfunk committed R79:07cdf05be7c3: Minor: Use more nullptr (authored by kfunk).
Minor: Use more nullptr
Dec 3 2018, 11:16 AM
kfunk committed R32:27cca2f34f40: Don't add 'override' specifier for non-modern project settings (authored by amhndu).
Don't add 'override' specifier for non-modern project settings
Dec 3 2018, 11:01 AM
kfunk requested review of D17328: Fix leak in AkonadiCollectionView.
Dec 3 2018, 10:51 AM · KDE PIM
kfunk committed R210:d8a802b14587: Minor: Add icon for "Purge" action (authored by kfunk).
Minor: Add icon for "Purge" action
Dec 3 2018, 10:51 AM
kfunk added inline comments to D16484: Add scratchpad plugin.
Dec 3 2018, 10:18 AM · KDevelop
kfunk accepted D16484: Add scratchpad plugin.

I think this is a great addition and I see myself using this a lot. So far I've done these things through a set of .cpp files lying around in my $HOME and compiled/ran them using some command-line alias :)

Dec 3 2018, 10:07 AM · KDevelop
kfunk accepted D16773: Don't add 'override' specifier for non-modern project settings.

LGTM in general. If you prefer your version (instead of the one proposed by me) feel free to push directly.

Dec 3 2018, 8:48 AM · KDevelop
kfunk added a comment to D17325: Fix leak in kemoticons.

Not entirely sure about whether this is the right fix for this. Can someone check why this was commented before?

Dec 3 2018, 7:29 AM · Frameworks