- User Since
- Jun 12 2015, 1:04 PM (102 w, 3 d)
+1, but please add the other asserts, too
Can't go in as-is, as it breaks compilation on MSVC 2015.
There are a couple of uses of supportsClang in craft.git, wondering if we should just try to get rid off them. Opinions?
Sat, May 27
Wed, May 24
That seems to work on my machine, it'll actually use the Breeze style automatically.
Conditionally link to librt
Alright, I now see why this is no longer required under Linux: https://stackoverflow.com/a/32649327/592636
Tue, May 23
Mon, May 22
NullsoftInstallerPackager is not the right place either. This should be done for every packager.
Mon, May 15
LGTM in general. I'll hope to find some time to test on Window, wouldn't want this to be merged before that.
Fri, May 12
Thu, May 11
Wed, May 10
+1 on the incentive. I had that somewhere on my TODO list...
Tue, May 9
Allow 0, but otherwise keep the lower bound of 200
This is so trivial, yet I saw the demand for being able to disable the blinking cursor several times...
Any other places I need to update?
Okay, then maybe support for the current FreeBSD version is not implemented? I have no idea about FreeBSD, to be honest. But it looks like using this API, and implementing the proper support in QStorageInfo internals would be the appropriate place.
Mon, May 8
Well, for me that looks good now
Please use one of the static methods to construct the QUrl, e.g. QUrl::fromUserInput. More explicit.
LGTM to me in general.
Tue, May 2
Phew, complex. But looks fine.
Phew, and I still don't like the new string substitution syntax (f-strings?). Will have to get used to it I guess... :)
LGTM in general. One issue I can see: Won't work with Right-To-Left languages. Any idea how to properly support them without putting the whole HTML table into i18n(...)...?
Apr 28 2017
Uh, careful here. This suggests those binaries are *required* at runtime.
Apr 27 2017
Waiting for tests for GCC
In the meantime, https://phabricator.kde.org/R33:76765692538d3af40374b0c9ae63eb6eb41c53c0 has been reverted. Good to go now?