- User Since
- Jun 12 2015, 1:04 PM (201 w, 6 d)
Wed, Apr 24
Mon, Apr 15
Thanks for fixing!
Mon, Apr 1
As long as it integrates well with the rest of the KDevelop build I'm fine. Would probably just copy the QtPromise source tree into maybe kdevelop.git:3rdparty/ and create a CMakeLists.txt which creates a STATIC or OBJECT library for it? QtPromise looks easy enough to build.
This works, yes, I don't see how that change could break it.
Mar 13 2019
Note: It's Thibault North <firstname.lastname@example.org>
Mar 12 2019
Mar 7 2019
FTR: I think I experienced the same or a similar issue.
By the way, also see: https://stackoverflow.com/a/5195913 wrt why it is dangerous.
Mar 6 2019
Only had a brief look, but this looks good to me! Well, better than letting it bit-rot.
Feb 19 2019
Feb 8 2019
Feb 5 2019
Commit message ideally. Truncate the report where applicable.
Jan 25 2019
Jan 14 2019
Jan 12 2019
Jan 11 2019
Jan 9 2019
Could you give me your full name + email for attribution in the commit?
I think that looks fine. Didn't test though.
Looks good to me. Can you push to 5.3 branch yourself?
@apol Something for you.
5.3 only please. Someone else (or even you) can merge it into master afterwards.
Jan 8 2019
Fixed with dcd5886fd949042765b905b3c67f9f20b18fb028
Jan 7 2019
Jan 6 2019
Dec 20 2018
Dec 15 2018
FYI: Patch looks good to me now, but I cannot judge whether it fixed the crash. So cannot give a +1.
Dec 14 2018
Dec 13 2018
Dec 11 2018
Dec 10 2018
Yep. please go for it.
@pino I actually thought about the same, but was unsure since Aleix asked to have it translated. I agree with your explanation, it makes sense to have this not translated at all. Will revert.
Dec 7 2018
Dec 3 2018
Just my 2 cent when I saw this review, didn't look further :)
Running into a crash with that patch, need to revisit:
I think this is a great addition and I see myself using this a lot. So far I've done these things through a set of .cpp files lying around in my $HOME and compiled/ran them using some command-line alias :)
LGTM in general. If you prefer your version (instead of the one proposed by me) feel free to push directly.