- User Since
- Jun 12 2015, 1:04 PM (136 w, 2 d)
Fri, Jan 19
Well, at least keep the same Markdown style in the file (## vs. ---...)
Thu, Jan 18
Closing, as this Diff got pushed already. See https://commits.kde.org/kate/749fa3b25f0b26c61e0c15004d490d77ce21dea0
Whoops. Sorry for accidentally reopening it to begin with.
Wed, Jan 17
Tue, Jan 16
Just a had a quick look at the appearance of the popup before vs. after the patch when doing code completion inside the a function call parameter list. Looks more consisten now, thanks!
I like the idea in general, but not really the string representation of the size.
Mon, Jan 15
Thu, Jan 11
Wed, Jan 10
To 5.2 branch please.
Whoop.s My code. Sorry.
Tue, Jan 9
src/solid-networkstatus/DESIGN also still references org.kde.kded. Please update, too.
Abandoning as this is clearly not the right way to fix the issue at hand.
LGTM, but I'll let someone else approve.
Dec 22 2017
Dec 20 2017
Please let's discuss on https://phabricator.kde.org/D9423 exclusively. This is basically fixing the same issue in a different repository.
And I agree. There shouldn't be a need to use two different input files. That's the whole point of configure_file(...): the interpolation of values happens *inside* the input files.
Could you please squash the commits and just keep this review for all the changes in KIO? Doesn't make sense to have different Phab Diffs for that (makes it harder to review, harder to revert in case, etc.).
Dec 19 2017
Whatever. Go for it.
Dec 18 2017
Dec 15 2017
Sorry for being late, but I didn't have time to follow up on this one.