kfunk (Kevin Funk)
Software Engineer

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Jun 12 2015, 1:04 PM (182 w, 4 d)
Availability
Available

Recent Activity

Yesterday

kfunk added inline comments to D16484: Add scratchpad plugin.
Tue, Dec 11, 8:51 AM · KDevelop

Mon, Dec 10

kfunk added a comment to D16484: Add scratchpad plugin.

Yep. please go for it.

Mon, Dec 10, 9:53 AM · KDevelop
kfunk committed R32:2bd71e5f79ac: Revert "patchreview: Allow to translate string" (authored by kfunk).
Revert "patchreview: Allow to translate string"
Mon, Dec 10, 8:48 AM
kfunk added a reverting change for R32:d91e22649ab1: patchreview: Allow to translate string: R32:2bd71e5f79ac: Revert "patchreview: Allow to translate string".
Mon, Dec 10, 8:48 AM
kfunk added a comment to R32:d91e22649ab1: patchreview: Allow to translate string.

@pino I actually thought about the same, but was unsure since Aleix asked to have it translated. I agree with your explanation, it makes sense to have this not translated at all. Will revert.

Mon, Dec 10, 8:46 AM
kfunk added inline comments to D16484: Add scratchpad plugin.
Mon, Dec 10, 8:45 AM · KDevelop
kfunk committed R877:d2b848fbe24c: Remove dead quanta project (authored by kfunk).
Remove dead quanta project
Mon, Dec 10, 8:31 AM
kfunk committed R877:3920ee0e97c2: kdevplatform as extra package is no more (authored by kfunk).
kdevplatform as extra package is no more
Mon, Dec 10, 8:30 AM
kfunk committed R32:d91e22649ab1: patchreview: Allow to translate string (authored by kfunk).
patchreview: Allow to translate string
Mon, Dec 10, 8:14 AM
kfunk committed R32:a41f7c00535a: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
Mon, Dec 10, 8:14 AM
kfunk committed R32:18c0c9681068: patchreview: Fix string (authored by kfunk).
patchreview: Fix string
Mon, Dec 10, 8:11 AM

Fri, Dec 7

kfunk added a comment to T10154: Craft Qt5.12.0.

Nothing from my side.

Fri, Dec 7, 3:50 PM

Mon, Dec 3

kfunk accepted D16484: Add scratchpad plugin.
Mon, Dec 3, 8:11 PM · KDevelop
kfunk updated the diff for D17325: Fix leak in kemoticons.

Use QSharedPointer

Mon, Dec 3, 2:13 PM · Frameworks
kfunk added a comment to D17314: Projects Plugin: Add ShellCheck analyzer.

Just my 2 cent when I saw this review, didn't look further :)

Mon, Dec 3, 1:59 PM · Kate
kfunk abandoned D17328: Fix leak in AkonadiCollectionView.

Running into a crash with that patch, need to revisit:

Mon, Dec 3, 12:16 PM · KDE PIM
kfunk committed R79:07cdf05be7c3: Minor: Use more nullptr (authored by kfunk).
Minor: Use more nullptr
Mon, Dec 3, 11:16 AM
kfunk committed R32:27cca2f34f40: Don't add 'override' specifier for non-modern project settings (authored by amhndu).
Don't add 'override' specifier for non-modern project settings
Mon, Dec 3, 11:01 AM
kfunk requested review of D17328: Fix leak in AkonadiCollectionView.
Mon, Dec 3, 10:51 AM · KDE PIM
kfunk committed R210:d8a802b14587: Minor: Add icon for "Purge" action (authored by kfunk).
Minor: Add icon for "Purge" action
Mon, Dec 3, 10:51 AM
kfunk added inline comments to D16484: Add scratchpad plugin.
Mon, Dec 3, 10:18 AM · KDevelop
kfunk accepted D16484: Add scratchpad plugin.

I think this is a great addition and I see myself using this a lot. So far I've done these things through a set of .cpp files lying around in my $HOME and compiled/ran them using some command-line alias :)

Mon, Dec 3, 10:07 AM · KDevelop
kfunk accepted D16773: Don't add 'override' specifier for non-modern project settings.

LGTM in general. If you prefer your version (instead of the one proposed by me) feel free to push directly.

Mon, Dec 3, 8:48 AM · KDevelop
kfunk added a comment to D17325: Fix leak in kemoticons.

Not entirely sure about whether this is the right fix for this. Can someone check why this was commented before?

Mon, Dec 3, 7:29 AM · Frameworks
kfunk requested review of D17325: Fix leak in kemoticons.
Mon, Dec 3, 7:28 AM · Frameworks
kfunk committed R94:3728ca387d29: Minor: Fix -Wmismatched-tags warning (authored by kfunk).
Minor: Fix -Wmismatched-tags warning
Mon, Dec 3, 7:27 AM
kfunk committed R94:b203c17e8324: Fix potential leak in nodehelper (authored by kfunk).
Fix potential leak in nodehelper
Mon, Dec 3, 7:27 AM
kfunk committed R94:b84973019648: Fix leak in messagepartrendererfactory (authored by kfunk).
Fix leak in messagepartrendererfactory
Mon, Dec 3, 7:27 AM
kfunk committed R94:0161e0bbba2f: Fix leak in templateparserjob (authored by kfunk).
Fix leak in templateparserjob
Mon, Dec 3, 7:27 AM
kfunk added a comment to D17289: KDevelop/Shell: set dedicated TMPDIR.

Okay, trying to keep this short.

Mon, Dec 3, 6:01 AM · KDevelop

Sun, Dec 2

kfunk committed R180:941233a241c1: Fix leak in KMime::Content::decodedContent() (authored by kfunk).
Fix leak in KMime::Content::decodedContent()
Sun, Dec 2, 10:05 AM
kfunk committed R210:b0c5a3945b68: searchdialog: Add more icons (authored by kfunk).
searchdialog: Add more icons
Sun, Dec 2, 9:33 AM
kfunk added a comment to D17255: KDevelop: support for installing into a non-standard parallel prefix.

Just some general remarks: Storing the application's install prefix inside the binary itself almost always smells like bad design. Thus the concerns here. You rather want to do this dependent on the kdevelop binary's application path (cf. http://doc.qt.io/qt-5/qcoreapplication.html#applicationDirPath)

Sun, Dec 2, 9:28 AM · KDevelop
kfunk updated subscribers of D17255: KDevelop: support for installing into a non-standard parallel prefix.

I've tested the idea of NOT specifying an install prefix default when none has been configured. To the best I can see this does not lead to invalid cmake invocations (aka -DCMAKE_INSTALL_PREFIX=). Instead, this does exactly what you'd expect: cmake will use whatever is its default for the current platform. The result will be obtained from the CMakeCache later on.
In other words, there doesn't appear to be any reason to hardcode assumptions about CMake's defaults, and not doing that should be a suitable compromise for everyone. It also removes the need for conditional code.

Sun, Dec 2, 9:25 AM · KDevelop
kfunk added a comment to D17289: KDevelop/Shell: set dedicated TMPDIR.

Forgot: Also needs documentation *in* source code why were are doing this. Noone can figure out that the temp dir is changed due to issues with the Clang backend here...

Sun, Dec 2, 9:23 AM · KDevelop
kfunk requested changes to D17289: KDevelop/Shell: set dedicated TMPDIR.

Not usable as-is.

Sun, Dec 2, 9:16 AM · KDevelop

Fri, Nov 30

kfunk committed R206:7dda54910cb9: snippetwidget: Make 'insert snippet' the default (authored by kfunk).
snippetwidget: Make 'insert snippet' the default
Fri, Nov 30, 3:50 PM
kfunk committed R92:36ab29633831: snippets: Add more icons (authored by kfunk).
snippets: Add more icons
Fri, Nov 30, 2:50 PM
kfunk added inline comments to D17255: KDevelop: support for installing into a non-standard parallel prefix.
Fri, Nov 30, 2:20 PM · KDevelop
kfunk added inline comments to D17255: KDevelop: support for installing into a non-standard parallel prefix.
Fri, Nov 30, 12:10 PM · KDevelop
kfunk requested changes to D17255: KDevelop: support for installing into a non-standard parallel prefix.
Fri, Nov 30, 12:04 PM · KDevelop

Wed, Nov 28

kfunk committed R165:3e7ef8f3f285: Minor: Fix string according to KDE HIG (authored by kfunk).
Minor: Fix string according to KDE HIG
Wed, Nov 28, 2:32 PM
kfunk committed R459:267fc2a7de0c: Minor: Fix string according to KDE HIG (authored by kfunk).
Minor: Fix string according to KDE HIG
Wed, Nov 28, 1:55 PM
kfunk committed R78:d802a134a6b3: Minor: Respect HIG for button title (authored by kfunk).
Minor: Respect HIG for button title
Wed, Nov 28, 1:45 PM
kfunk committed R78:6b8797144d3b: dialogdesktop: Add a lot more icons, fix layouts (authored by kfunk).
dialogdesktop: Add a lot more icons, fix layouts
Wed, Nov 28, 1:45 PM
kfunk committed R180:c5e56a4262e4: parsedatetimetest: Fix -Wunused-result warning (authored by kfunk).
parsedatetimetest: Fix -Wunused-result warning
Wed, Nov 28, 1:35 PM
kfunk committed R180:6bc93af8fd63: parsedatetimetest: Reformat code (authored by kfunk).
parsedatetimetest: Reformat code
Wed, Nov 28, 1:35 PM
kfunk committed R180:61189bfaeabc: Use nullptr (authored by kfunk).
Use nullptr
Wed, Nov 28, 1:11 PM

Tue, Nov 27

kfunk committed R32:e1a51bd35926: appimage: Use Python 3.6.7, simplify code (authored by kfunk).
appimage: Use Python 3.6.7, simplify code
Tue, Nov 27, 8:55 AM
kfunk committed R32:843d27de54f1: appimage: Instal xz-devel (authored by kfunk).
appimage: Instal xz-devel
Tue, Nov 27, 8:55 AM
kfunk committed R32:617594478296: appimage: Base on CentOS 6.10 (authored by kfunk).
appimage: Base on CentOS 6.10
Tue, Nov 27, 8:55 AM

Mon, Nov 26

kfunk accepted D17174: Use qCWarning in path.cpp..

Okay, but you could have pushed this directly ;)

Mon, Nov 26, 3:51 PM · KDevelop
kfunk added inline comments to D17130: Fix projectmodel unittest to work on Windows..
Mon, Nov 26, 12:18 PM · KDevelop
kfunk added a comment to D17130: Fix projectmodel unittest to work on Windows..

Yes, please.

Mon, Nov 26, 11:44 AM · KDevelop
kfunk committed R32:d1e8575645c2: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
Mon, Nov 26, 9:38 AM
kfunk committed R32:d46ed7014365: Make the filteringstrategy test work on Windows as well. (authored by volden).
Make the filteringstrategy test work on Windows as well.
Mon, Nov 26, 9:28 AM
kfunk committed R119:00eda23e92aa: Minor: Fix -Wextra-semi warning (authored by kfunk).
Minor: Fix -Wextra-semi warning
Mon, Nov 26, 9:27 AM
kfunk committed R119:7f83492a654c: ASAN: Fix leak in KAStatsFavoritesModel (authored by kfunk).
ASAN: Fix leak in KAStatsFavoritesModel
Mon, Nov 26, 9:24 AM
kfunk closed D17039: ASAN: Fix leak in KAStatsFavoritesModel.
Mon, Nov 26, 9:24 AM · Plasma
kfunk accepted D17158: Fix qmakeproject unittest to work on Windows..
Mon, Nov 26, 9:19 AM · KDevelop
kfunk accepted D17156: Fix defines and includes test to run on Windows..
Mon, Nov 26, 9:18 AM · KDevelop
kfunk accepted D17130: Fix projectmodel unittest to work on Windows..
Mon, Nov 26, 9:18 AM · KDevelop

Thu, Nov 22

kfunk committed R877:3e2c05162c09: kdevelop: Only call scriptt on recent versions (authored by kfunk).
kdevelop: Only call scriptt on recent versions
Thu, Nov 22, 3:07 PM
kfunk accepted D17098: Make the filteringstrategy test work on Windows as well..
Thu, Nov 22, 12:21 PM · KDevelop
kfunk committed R877:afc07fbb43e3: kdevelop: Install color schemes (authored by kfunk).
kdevelop: Install color schemes
Thu, Nov 22, 11:55 AM
kfunk committed R32:50bd42017163: install_colorscheme: Remove unwanted files (authored by kfunk).
install_colorscheme: Remove unwanted files
Thu, Nov 22, 11:52 AM
kfunk committed R32:46c31ddf31a6: install_colorschemes: Rework script (authored by kfunk).
install_colorschemes: Rework script
Thu, Nov 22, 11:45 AM

Wed, Nov 21

kfunk committed R32:2bee917b8104: okteta: Enough to search for CMake config files (authored by kfunk).
okteta: Enough to search for CMake config files
Wed, Nov 21, 8:45 PM
kfunk committed R32:6d97a1f80fd7: Minor: Fix typo (authored by kfunk).
Minor: Fix typo
Wed, Nov 21, 8:41 PM
kfunk committed R32:52348239c29c: install_colorschemes: Port to Python-based script (authored by kfunk).
install_colorschemes: Port to Python-based script
Wed, Nov 21, 8:34 PM
kfunk committed R138:fc54b76f609f: Minor: Fix typo (authored by kfunk).
Minor: Fix typo
Wed, Nov 21, 7:30 PM
kfunk added a comment to D17039: ASAN: Fix leak in KAStatsFavoritesModel.

I think the QSharedPointer overhead is very much negligible in this case here. And doesn't require refactoring of the original code. This is not performance sensitive code (compared to the costs of the QAIM-modifications), no?

Wed, Nov 21, 6:01 PM · Plasma
kfunk added a comment to D17077: Make test outputmodel pass on windows..

To 5.3 branch, please

Wed, Nov 21, 4:24 PM · KDevelop
kfunk accepted D17077: Make test outputmodel pass on windows..
Wed, Nov 21, 4:24 PM · KDevelop

Tue, Nov 20

kfunk added reviewers for D17039: ASAN: Fix leak in KAStatsFavoritesModel: davidedmundson, ivan.
Tue, Nov 20, 3:43 PM · Plasma
kfunk added a comment to D17031: Fix a few memory leaks ASAN: Fix leak in AppletQuickItem.

Yep, those are in fact separate commits.

Tue, Nov 20, 2:16 PM · Frameworks
kfunk committed R242:421e1c01266e: ASAN: Fix memory leak in CalendarPlugin (authored by kfunk).
ASAN: Fix memory leak in CalendarPlugin
Tue, Nov 20, 2:16 PM
kfunk closed D17031: Fix a few memory leaks ASAN: Fix leak in AppletQuickItem.
Tue, Nov 20, 2:16 PM · Frameworks
kfunk committed R242:fbfc9bdebb79: ASAN: Fix memory leak in DataSource (authored by kfunk).
ASAN: Fix memory leak in DataSource
Tue, Nov 20, 2:16 PM
kfunk committed R242:d13f9e6f8538: ASAN: Fix memory leak in Corona (authored by kfunk).
ASAN: Fix memory leak in Corona
Tue, Nov 20, 2:16 PM
kfunk committed R242:e3eafabd5587: ASAN: Fix leak in AppletQuickItem (authored by kfunk).
ASAN: Fix leak in AppletQuickItem
Tue, Nov 20, 2:16 PM
kfunk requested review of D17039: ASAN: Fix leak in KAStatsFavoritesModel.
Tue, Nov 20, 9:13 AM · Plasma
kfunk accepted D17027: appimage: use original app desktop file as base for appimage one.

LGTM. @brauch?

Tue, Nov 20, 8:57 AM · KDevelop
kfunk committed R120:a46179d9497a: Perf: Do expensive regexp construction earlier (authored by kfunk).
Perf: Do expensive regexp construction earlier
Tue, Nov 20, 8:53 AM
kfunk closed D17025: Perf: Do expensive regexp construction earlier.
Tue, Nov 20, 8:53 AM · Plasma
kfunk added inline comments to D17025: Perf: Do expensive regexp construction earlier.
Tue, Nov 20, 8:52 AM · Plasma

Mon, Nov 19

kfunk added a comment to D16915: Disable plugin project config if project without a IBuildSystemManager dep.

I'm late to this party, but what about projects where the user generates the missing compile_commands.json file manually, e.g. via the compiledb utility? Does this change mean clazy analysis is now possible only for projects where you do NOT need to generate that json file by hand?

Mon, Nov 19, 11:21 PM · KDevelop
kfunk committed R120:e2ba40a4912a: Fix a few memory leaks (authored by kfunk).
Fix a few memory leaks
Mon, Nov 19, 10:54 PM
kfunk closed D17032: Fix a few memory leaks ASAN: Fix leak in XWindowTasksModel.
Mon, Nov 19, 10:54 PM · Plasma
kfunk committed R120:38a50ce7c657: ASAN: Fix leak in XWindowTasksModel (authored by kfunk).
ASAN: Fix leak in XWindowTasksModel
Mon, Nov 19, 10:54 PM
kfunk added a reviewer for D17025: Perf: Do expensive regexp construction earlier: davidedmundson.
Mon, Nov 19, 10:52 PM · Plasma
kfunk committed R32:e2d5023e5225: patchreview: Restore libkomparediff2 5.0 support (authored by kfunk).
patchreview: Restore libkomparediff2 5.0 support
Mon, Nov 19, 10:40 PM
kfunk committed R32:6b645175138e: Increase timeout for duchain gcc compatibility test (authored by kfunk).
Increase timeout for duchain gcc compatibility test
Mon, Nov 19, 10:39 PM
kfunk closed D16541: Increase timeout for duchain gcc compatibility test.
Mon, Nov 19, 10:39 PM · KDevelop
kfunk added a comment to D16541: Increase timeout for duchain gcc compatibility test.

Will change to 60s (looks better) and then push. Thanks!

Mon, Nov 19, 10:37 PM · KDevelop
kfunk requested review of D17032: Fix a few memory leaks ASAN: Fix leak in XWindowTasksModel.
Mon, Nov 19, 10:35 PM · Plasma
kfunk requested review of D17031: Fix a few memory leaks ASAN: Fix leak in AppletQuickItem.
Mon, Nov 19, 10:35 PM · Frameworks
kfunk committed R32:b03b30c2ffb6: patchreview: Restore libkomparediff2 5.0 support (authored by kfunk).
patchreview: Restore libkomparediff2 5.0 support
Mon, Nov 19, 9:02 PM
kfunk updated the test plan for D17025: Perf: Do expensive regexp construction earlier.
Mon, Nov 19, 8:32 PM · Plasma
kfunk requested review of D17025: Perf: Do expensive regexp construction earlier.
Mon, Nov 19, 8:32 PM · Plasma