kfunk (Kevin Funk)
Software Engineer

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jun 12 2015, 1:04 PM (174 w, 3 d)
Availability
Available

Recent Activity

Yesterday

kfunk added a comment to D16218: [KDevelop/Core]: safe signal-handler implementation (WIP).
If there is no solution which does not require two different code paths for handling this problem, I'm against merging this, non-conformant old behaviour or not, sorry.

So to repeat myself: if signal handling should work on MS Windows (and safely so) then the QSocketNotifier approach is off the table, in principle. I cannot (and do not want to) be judge of whether MS Windows should be supported here.

The semaphore-based implementation should be more direct as it doesn't go over the Qt event loop and signal/slot mechanism. That makes me inclined to prefer it.

Mon, Oct 15, 11:33 AM · KDevelop
kfunk added a comment to D16218: [KDevelop/Core]: safe signal-handler implementation (WIP).

Probably because it's a patch against existing code, which needs changes due to the fact that I thought I'd had to avoid static globals.

Mon, Oct 15, 11:20 AM · KDevelop
kfunk committed R32:27eaf33c3c52: Prevent QWebEngine from overriding signal handlers (authored by croick).
Prevent QWebEngine from overriding signal handlers
Mon, Oct 15, 10:39 AM
kfunk added a comment to D16188: Prevent QWebEngine from overriding signal handlers.

Nice find! Will cherry-pick to 5.3 branch.

Mon, Oct 15, 10:30 AM · KDevelop
kfunk requested changes to D16218: [KDevelop/Core]: safe signal-handler implementation (WIP).
Mon, Oct 15, 10:26 AM · KDevelop
kfunk added a comment to D16218: [KDevelop/Core]: safe signal-handler implementation (WIP).

Sorry, but this is yet another unmergeable WIP patch of yours. Just a quick review, I'm not diving into your code (which is difficult to parse, esp. the changes in CorePrivate::initialize...) right now.

Mon, Oct 15, 10:26 AM · KDevelop

Fri, Oct 12

kfunk committed R32:ea3d601f7882: windows: Detect VS2017 compiler and tools (authored by kfunk).
windows: Detect VS2017 compiler and tools
Fri, Oct 12, 11:32 AM
kfunk closed D16123: windows: Detect VS2017 compiler and tools.
Fri, Oct 12, 11:32 AM · KDevelop
kfunk added a comment to D16123: windows: Detect VS2017 compiler and tools.

@Petross404 Hmm, true. Let me push my patch anyway, for now.

Fri, Oct 12, 11:31 AM · KDevelop
kfunk committed R32:099eb61029c0: Minor: Remove unneeded include path (authored by kfunk).
Minor: Remove unneeded include path
Fri, Oct 12, 10:31 AM

Thu, Oct 11

kfunk updated the diff for D16123: windows: Detect VS2017 compiler and tools.

Check whether base is defined at another place

Thu, Oct 11, 6:52 AM · KDevelop
kfunk added a reviewer for D16123: windows: Detect VS2017 compiler and tools: Petross404.
Thu, Oct 11, 6:46 AM · KDevelop
kfunk added a comment to D16123: windows: Detect VS2017 compiler and tools.

Note: This is alternative approach to https://phabricator.kde.org/D15976

Thu, Oct 11, 6:44 AM · KDevelop
kfunk requested changes to D15976: Fix KDevelop's detection for Visual Studio 2017 compiler and tools..

Hey @Petross404 -- the other day I reworked that script a bit, here's the result: https://phabricator.kde.org/D16123 -- I refactored it this way before seeing the new revision of yours. I do think my version is a little bit easier to grasp, since it does not have that many branches compared to yours.

Thu, Oct 11, 6:44 AM · KDevelop
kfunk requested review of D16123: windows: Detect VS2017 compiler and tools.
Thu, Oct 11, 6:43 AM · KDevelop
kfunk committed R32:9c46acfe07c7: windows: Do not print commands from batch file (authored by kfunk).
windows: Do not print commands from batch file
Thu, Oct 11, 6:39 AM
kfunk committed R32:e48d85385673: windows: Silence some errors from batch file (authored by kfunk).
windows: Silence some errors from batch file
Thu, Oct 11, 6:38 AM
kfunk committed R32:1600eabfc3da: windows: Streamline batch file a bit (authored by kfunk).
windows: Streamline batch file a bit
Thu, Oct 11, 6:37 AM
kfunk added a comment to D16032: Generate all kdebugsettings .categories files automatically.

I'm torn about this review; I'm with Aleix in the sense that this adds lots and lots of extra CMake code to maintain without a /lot/ of gain.

Thu, Oct 11, 5:28 AM · KDevelop

Tue, Oct 9

kfunk accepted D16070: Build qt docs.

Rest LGTM

Tue, Oct 9, 1:17 PM
kfunk committed R32:ed4992ec6dfd: Add missing include (authored by kfunk).
Add missing include
Tue, Oct 9, 12:59 PM
kfunk committed R32:c68bc80d27d8: Minor: Fix message() call in CMake (authored by kfunk).
Minor: Fix message() call in CMake
Tue, Oct 9, 12:59 PM
kfunk committed R32:01b6d8119be0: Include array header where needed (authored by kfunk).
Include array header where needed
Tue, Oct 9, 12:54 PM
kfunk committed R32:583d0c24bcbf: Fix -Wdocumentation warnings (authored by kfunk).
Fix -Wdocumentation warnings
Tue, Oct 9, 12:54 PM
kfunk committed R32:4dd25978726b: Add missing include (authored by parolanilsson).
Add missing include
Tue, Oct 9, 12:54 PM
kfunk committed R32:8306ee894ba8: Include KDECompilerSettings with NO_POLICY_SCOPE (authored by kfunk).
Include KDECompilerSettings with NO_POLICY_SCOPE
Tue, Oct 9, 12:54 PM
kfunk committed R32:0c518250b100: Fix segfault when analyzing source code (authored by kfunk).
Fix segfault when analyzing source code
Tue, Oct 9, 12:53 PM
kfunk committed R32:e9f77ae82c74: Add config files for source formatting (authored by kfunk).
Add config files for source formatting
Tue, Oct 9, 12:53 PM
kfunk committed R32:894a6ddb1df5: Add .arcconfig (authored by kfunk).
Add .arcconfig
Tue, Oct 9, 12:53 PM
kfunk committed R32:6160a26ebbf0: json: Streamline description (authored by kfunk).
json: Streamline description
Tue, Oct 9, 12:53 PM
kfunk committed R32:343f5e607183: json: Fix GenericName (authored by kfunk).
json: Fix GenericName
Tue, Oct 9, 12:53 PM
kfunk committed R32:647bc5bfd2bf: Fix strings, improve layout of settings page (authored by kfunk).
Fix strings, improve layout of settings page
Tue, Oct 9, 12:53 PM
kfunk committed R32:d522cacbfcdc: Fix path to .json file (authored by kfunk).
Fix path to .json file
Tue, Oct 9, 12:53 PM
kfunk committed R32:50aebee86dc9: Better error message in case clang-tidy not found (authored by kfunk).
Better error message in case clang-tidy not found
Tue, Oct 9, 12:53 PM
kfunk committed R32:b9722cce1df0: Dissolve ui/ directory, streamline file names (authored by kfunk).
Dissolve ui/ directory, streamline file names
Tue, Oct 9, 12:53 PM
kfunk committed R32:e707961ecca9: Fix window title (authored by kfunk).
Fix window title
Tue, Oct 9, 12:53 PM
kfunk committed R32:adef843e4c33: More renames: Clangtidy -> ClangTidy (authored by kfunk).
More renames: Clangtidy -> ClangTidy
Tue, Oct 9, 12:53 PM
kfunk committed R32:db624d3906c9: Dissolve res/ directory, move filest (authored by kfunk).
Dissolve res/ directory, move filest
Tue, Oct 9, 12:53 PM
kfunk committed R32:bfdf92fd356a: More human-readable string fixes (authored by kfunk).
More human-readable string fixes
Tue, Oct 9, 12:53 PM
kfunk committed R32:708c198906c2: Add context-menu action, more string fixes (authored by kfunk).
Add context-menu action, more string fixes
Tue, Oct 9, 12:53 PM
kfunk committed R32:dbde13f249f8: Rename classes ClangtidyFoo -> ClangTidyFoo (authored by kfunk).
Rename classes ClangtidyFoo -> ClangTidyFoo
Tue, Oct 9, 12:53 PM
kfunk committed R32:670221aea53f: HIG: Fix capitalization issues (authored by kfunk).
HIG: Fix capitalization issues
Tue, Oct 9, 12:53 PM
kfunk committed R32:9f7242e67829: Move actions to Analyzer category (authored by kfunk).
Move actions to Analyzer category
Tue, Oct 9, 12:53 PM
kfunk committed R32:32c24c390630: Don't hardcode path to clang-tidy (authored by kfunk).
Don't hardcode path to clang-tidy
Tue, Oct 9, 12:53 PM
kfunk committed R32:43b3d7c17ad6: Fix translated string (authored by kfunk).
Fix translated string
Tue, Oct 9, 12:53 PM
kfunk committed R32:74da34922eeb: Implement runtime detection of clang-tidy (authored by kfunk).
Implement runtime detection of clang-tidy
Tue, Oct 9, 12:53 PM
kfunk committed R32:f30510f87e7d: Streamline logging category (authored by kfunk).
Streamline logging category
Tue, Oct 9, 12:53 PM
kfunk committed R32:c9b42c36fefd: Simplify project structure a bit (authored by kfunk).
Simplify project structure a bit
Tue, Oct 9, 12:53 PM
kfunk committed R32:52a02282c7c2: Fix some translated strings (authored by kfunk).
Fix some translated strings
Tue, Oct 9, 12:53 PM
kfunk committed R32:9b18a9940ee4: Refactorings and improvements on nomenclature done. (authored by coliveira).
Refactorings and improvements on nomenclature done.
Tue, Oct 9, 12:53 PM
kfunk committed R32:e83fbe4f555e: Improved parsers to avoid generating exception while processing strings. Also… (authored by coliveira).
Improved parsers to avoid generating exception while processing strings. Also…
Tue, Oct 9, 12:53 PM
kfunk committed R32:a66d3fd5dab9: Trying to sabotage the tests with a bad plugin.cpp.yaml file. (authored by coliveira).
Trying to sabotage the tests with a bad plugin.cpp.yaml file.
Tue, Oct 9, 12:53 PM
kfunk committed R32:5c49f13082a0: Broken code. Shouldn't be used for nothing. (authored by coliveira).
Broken code. Shouldn't be used for nothing.
Tue, Oct 9, 12:53 PM
kfunk committed R32:5ee3a4f81573: Corrected issue 1 <https://github.com/CarlosNihelton/kdev-clang-tidy/issues/1>. (authored by coliveira).
Corrected issue 1 <https://github.com/CarlosNihelton/kdev-clang-tidy/issues/1>.
Tue, Oct 9, 12:52 PM
kfunk committed R32:e4d55f4ca569: Found a way to put clang-tidy configuration inside the Analizers page created… (authored by coliveira).
Found a way to put clang-tidy configuration inside the Analizers page created…
Tue, Oct 9, 12:52 PM
kfunk committed R32:6fb230c24f6e: Implemented a parser for the yaml output containing the suggested replacements. (authored by coliveira).
Implemented a parser for the yaml output containing the suggested replacements.
Tue, Oct 9, 12:52 PM
kfunk committed R32:0cb8bd07ec98: Fixed .clang-tidy file generation. (authored by coliveira).
Fixed .clang-tidy file generation.
Tue, Oct 9, 12:52 PM
kfunk committed R32:42ddb3853bf4: Cleaned the code a bit and added unit tests. (authored by coliveira).
Cleaned the code a bit and added unit tests.
Tue, Oct 9, 12:52 PM
kfunk committed R32:208c3189668f: Refined documentation and excluded some unnecessary message boxes. (authored by coliveira).
Refined documentation and excluded some unnecessary message boxes.
Tue, Oct 9, 12:52 PM
kfunk committed R32:f583acee4574: Reviewed README.md file. (authored by coliveira).
Reviewed README.md file.
Tue, Oct 9, 12:52 PM
kfunk committed R32:bff97559c228: Sent the third picture to github. (authored by coliveira).
Sent the third picture to github.
Tue, Oct 9, 12:52 PM
kfunk committed R32:78db0d2dd815: Added a little documentation on the README file. (authored by coliveira).
Added a little documentation on the README file.
Tue, Oct 9, 12:52 PM
kfunk committed R32:cc82821736e8: Parser branch already working. TODO: implement interactive fix. (authored by coliveira).
Parser branch already working. TODO: implement interactive fix.
Tue, Oct 9, 12:52 PM
kfunk committed R32:83578f563a35: Enhanced type system to avoid using strings directly to control configuration… (authored by coliveira).
Enhanced type system to avoid using strings directly to control configuration…
Tue, Oct 9, 12:52 PM
kfunk committed R32:52d5976d27c8: Type system enforced and reoarganized folders and files. Its compiling and… (authored by coliveira).
Type system enforced and reoarganized folders and files. Its compiling and…
Tue, Oct 9, 12:52 PM
kfunk committed R32:0db455366e55: Update .gitignore (authored by coliveira).
Update .gitignore
Tue, Oct 9, 12:52 PM
kfunk committed R32:1b1d52482cc3: first commit (authored by coliveira).
first commit
Tue, Oct 9, 12:52 PM
kfunk committed R32:c1c288a64490: initial project import from KDevelop (authored by coliveira).
initial project import from KDevelop
Tue, Oct 9, 12:52 PM
kfunk committed R39:fd38a62e373f: Minor: Cleanup some code (authored by kfunk).
Minor: Cleanup some code
Tue, Oct 9, 9:25 AM
kfunk added a comment to D16061: Fix the compilation of kiten on Windows.

Thanks, perfect!

Tue, Oct 9, 9:18 AM · Windows, KDE Edu
kfunk accepted D16064: Fix memleaks in unittests.

Can be committed this way as well, but I'd research using QScopedPoiner in some places instead.

Tue, Oct 9, 9:11 AM · KDevelop
kfunk added a comment to D16062: Add a blueprint for mman-win32 and dependency in kiten.

Hm but Qt doesn't do mmap? When a rcc is loaded it reads the whole file to ram?

Tue, Oct 9, 9:08 AM · Craft, Windows
kfunk accepted D16061: Fix the compilation of kiten on Windows.

Feel free to push after fixing the last remark.

Tue, Oct 9, 8:54 AM · Windows, KDE Edu
kfunk added inline comments to D16062: Add a blueprint for mman-win32 and dependency in kiten.
Tue, Oct 9, 8:43 AM · Craft, Windows
kfunk requested changes to D16061: Fix the compilation of kiten on Windows.

Rest LGTM!

Tue, Oct 9, 8:39 AM · Windows, KDE Edu
kfunk added a comment to D16061: Fix the compilation of kiten on Windows.

ecm_mark_nongui_executable(kitengen) in CMake code has the same effect I think (and is the cleaner version)

Tue, Oct 9, 8:39 AM · Windows, KDE Edu
kfunk requested changes to D15976: Fix KDevelop's detection for Visual Studio 2017 compiler and tools..
Tue, Oct 9, 8:29 AM · KDevelop
kfunk added a comment to D16056: Fix windows compilation of gwenview.

Just hijacking this Diff b/c I see several places where this can be improved :)

Tue, Oct 9, 8:00 AM · Windows, Gwenview

Mon, Oct 8

kfunk committed R32:7fe88f5122f7: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
Mon, Oct 8, 6:53 PM
kfunk requested changes to D15976: Fix KDevelop's detection for Visual Studio 2017 compiler and tools..

Ah, right, I missed that part. The problem is that VS2017 by default doesn't set VS150COMNTOOLS as system-wide env variable.

Mon, Oct 8, 6:49 PM · KDevelop
kfunk accepted D15976: Fix KDevelop's detection for Visual Studio 2017 compiler and tools..

Looks good to me, please push to 5.3 branch.

Mon, Oct 8, 1:58 PM · KDevelop
kfunk committed R52:c1c551568397: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
Mon, Oct 8, 12:02 PM
kfunk added a comment to D16012: Make Qt5Test optional.

(there are also some missing deps that are implicitly linked, but that is for another review)

Mon, Oct 8, 11:52 AM · KDevelop
kfunk added a comment to D16012: Make Qt5Test optional.

Pushed this for you. To 5.3 branch.

Mon, Oct 8, 11:51 AM · KDevelop
kfunk committed R52:967551db23fb: Make Qt5Test optional (authored by asturmlechner).
Make Qt5Test optional
Mon, Oct 8, 11:51 AM
kfunk closed D16012: Make Qt5Test optional.
Mon, Oct 8, 11:50 AM · KDevelop
kfunk committed R52:b9f4bb3f54bd: Remove unneeded dep on KF5::Archive (authored by kfunk).
Remove unneeded dep on KF5::Archive
Mon, Oct 8, 11:50 AM

Sun, Oct 7

kfunk accepted D16012: Make Qt5Test optional.

To 5.3 branch, please.

Sun, Oct 7, 5:11 PM · KDevelop
kfunk accepted D15977: Generate kdebugsettings .categories file automatically.

Looks good to me in general, feel free to push to master.

Sun, Oct 7, 12:12 PM · KDevelop
kfunk accepted D16003: Sort Project Targets in Launch configuration.

I don't see why not.

Sun, Oct 7, 11:57 AM · KDevelop
kfunk accepted D15998: Fix discovery of clang builtin directory with clang svn versions.
Sun, Oct 7, 11:51 AM · KDevelop

Fri, Oct 5

kfunk committed R32:ec5477f351b6: clang: Also detect Clang builtin dirs at runtime (authored by kfunk).
clang: Also detect Clang builtin dirs at runtime
Fri, Oct 5, 12:40 PM
kfunk closed D15955: clang: Also detect Clang builtin dirs at runtime.
Fri, Oct 5, 12:40 PM · KDevelop
kfunk committed R877:7134a3ec22ba: llvm: Default to 6.0.1 (authored by kfunk).
llvm: Default to 6.0.1
Fri, Oct 5, 9:14 AM
kfunk added a comment to D15955: clang: Also detect Clang builtin dirs at runtime.

You're right. For the Windows case, we wouldn't actually need to query the Clang version at runtime, since we control the version of Clang/LLVM ourselves.

Fri, Oct 5, 6:46 AM · KDevelop

Thu, Oct 4

kfunk added a comment to D15955: clang: Also detect Clang builtin dirs at runtime.

Otoh, Clang 7 "fixes" this since they no longer use "X.Y.Z/include" but just "X/include" -- so we do not have to worry about this any longer anyway.

Thu, Oct 4, 10:13 PM · KDevelop
kfunk added a comment to D15955: clang: Also detect Clang builtin dirs at runtime.

Note: Doing the retrieval at runtime would also allow distro packages to upgrade the libclang version under-the-hood; without having the need to recompile KDevelop. I.e. going from Clang/LLVM 6.0.0 to 6.0.1 (and keeping ABI), KDevelop would keep working just fine (which it currently wouldn't...).

Thu, Oct 4, 10:11 PM · KDevelop
kfunk added reviewers for D15955: clang: Also detect Clang builtin dirs at runtime: kossebau, aaronpuchert.
Thu, Oct 4, 10:07 PM · KDevelop
kfunk requested review of D15955: clang: Also detect Clang builtin dirs at runtime.
Thu, Oct 4, 10:07 PM · KDevelop
kfunk committed R32:feba4b8a7692: Move clangBuiltinIncludePath() to different ns (authored by kfunk).
Move clangBuiltinIncludePath() to different ns
Thu, Oct 4, 10:05 PM