kfunk (Kevin Funk)
Software Engineer

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jun 12 2015, 1:04 PM (192 w, 6 d)
Availability
Available

Recent Activity

Tue, Feb 19

kfunk committed R32:3c2725a67d3a: [Sessions Runner] Use icon name (authored by kfunk).
[Sessions Runner] Use icon name
Tue, Feb 19, 3:42 PM
kfunk closed D19159: [Sessions Runner] Use icon name.
Tue, Feb 19, 3:42 PM · KDevelop
kfunk accepted D19159: [Sessions Runner] Use icon name.
Tue, Feb 19, 3:22 PM · KDevelop
kfunk committed R32:d96d759a925d: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
Tue, Feb 19, 8:53 AM

Fri, Feb 8

kfunk committed R32:8bae72e6096b: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
Fri, Feb 8, 10:55 AM
kfunk committed R32:af5696392493: Workaround the bug found by ASan, which can be seen on FreeBSD CI. (authored by arrowd).
Workaround the bug found by ASan, which can be seen on FreeBSD CI.
Fri, Feb 8, 10:54 AM

Tue, Feb 5

kfunk added a comment to D18463: Workaround the bug found by ASan, which can be seen on FreeBSD CI..

Commit message ideally. Truncate the report where applicable.

Tue, Feb 5, 9:29 AM · KDevelop

Fri, Jan 25

kfunk added a reviewer for D18523: Fix windows build: mlaurent.
Fri, Jan 25, 12:45 PM · KDE PIM
kfunk added a reviewer for D18523: Fix windows build: sengels.
Fri, Jan 25, 12:45 PM · KDE PIM
kfunk requested review of D18523: Fix windows build.
Fri, Jan 25, 12:44 PM · KDE PIM

Jan 14 2019

kfunk committed R32:5cf8981ae53c: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
Jan 14 2019, 4:32 AM

Jan 12 2019

kfunk accepted D10115: Fix unused parameters warnings.

LGTM

Jan 12 2019, 12:21 PM

Jan 11 2019

kfunk committed R32:71c65a65917a: Clang plugin: Handle CUDA files better (authored by thomassc).
Clang plugin: Handle CUDA files better
Jan 11 2019, 8:49 AM
kfunk closed D17909: Clang plugin: Handle CUDA files better.
Jan 11 2019, 8:49 AM · KDevelop
kfunk accepted D18175: appimage: skip unneeded cp of cmake, removed later again.
Jan 11 2019, 8:47 AM · KDevelop

Jan 9 2019

kfunk added a comment to D17909: Clang plugin: Handle CUDA files better.

Could you give me your full name + email for attribution in the commit?

Jan 9 2019, 12:51 PM · KDevelop
kfunk accepted D17569: Allow configuring shortcut for Run Scratch action and add to Run menu.

I think that looks fine. Didn't test though.

Jan 9 2019, 11:22 AM · KDevelop
kfunk accepted D17888: appimage: add okteta libs, as used by the debugger memory view.

Why not.

Jan 9 2019, 10:34 AM · KDevelop
kfunk committed R32:7055e9d58af2: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
Jan 9 2019, 9:23 AM
kfunk committed R32:1dbebbab5f34: grewpview: Fix potential crash in "Find in Files" (authored by kfunk).
grewpview: Fix potential crash in "Find in Files"
Jan 9 2019, 9:17 AM
kfunk accepted D17909: Clang plugin: Handle CUDA files better.

Looks good to me. Can you push to 5.3 branch yourself?

Jan 9 2019, 8:59 AM · KDevelop
kfunk resigned from D5447: Only add auto-detected compilers to model if they actually exist.

@apol Something for you.

Jan 9 2019, 8:44 AM
kfunk added a comment to D18021: Add All Top-Level Targets to the Menu.

5.3 only please. Someone else (or even you) can merge it into master afterwards.

Jan 9 2019, 8:42 AM · KDevelop
kfunk committed R32:831daf9b42ce: meson: Build with KIO older than 5.33 (authored by kfunk).
meson: Build with KIO older than 5.33
Jan 9 2019, 8:29 AM
kfunk committed R32:96cb4100619b: Fix typo, sorry (authored by kfunk).
Fix typo, sorry
Jan 9 2019, 8:12 AM
kfunk committed R32:ce65a58df9b4: meson: Attempt to make compile with Qt 5.7 (authored by kfunk).
meson: Attempt to make compile with Qt 5.7
Jan 9 2019, 8:09 AM

Jan 8 2019

kfunk added a comment to R858:e1ec36138c99: Minor: Use nullptr.

Fixed with dcd5886fd949042765b905b3c67f9f20b18fb028

Jan 8 2019, 7:52 AM
kfunk committed R858:dcd5886fd949: Minor: Use {} for initializing flags (authored by kfunk).
Minor: Use {} for initializing flags
Jan 8 2019, 7:52 AM
kfunk committed R858:e1ec36138c99: Minor: Use nullptr (authored by kfunk).
Minor: Use nullptr
Jan 8 2019, 7:15 AM

Jan 7 2019

kfunk committed R52:49abff40a353: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
Jan 7 2019, 9:18 AM

Jan 6 2019

kfunk committed R53:1277a3a4853e: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
Jan 6 2019, 7:58 PM
kfunk committed R32:b51458d642db: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
Jan 6 2019, 7:52 PM

Dec 20 2018

kfunk committed R32:31e662eceff1: appimage: Strip libfreetype & libz (authored by kfunk).
appimage: Strip libfreetype & libz
Dec 20 2018, 10:19 PM

Dec 15 2018

kfunk committed R877:750a98bb81c1: grantlee: Add qtscript dep (authored by kfunk).
grantlee: Add qtscript dep
Dec 15 2018, 8:56 AM
kfunk added a comment to D17563: Don't crash with Qt 5.11+.

FYI: Patch looks good to me now, but I cannot judge whether it fixed the crash. So cannot give a +1.

Dec 15 2018, 8:48 AM · KDE PIM

Dec 14 2018

kfunk accepted D17575: Remove reliance on Qt 5.11+ QIODevice::NewOnly in the Scratchpad plugin.
Dec 14 2018, 10:30 AM · KDevelop
kfunk added inline comments to D17563: Don't crash with Qt 5.11+.
Dec 14 2018, 8:26 AM · KDE PIM

Dec 13 2018

kfunk added inline comments to D17563: Don't crash with Qt 5.11+.
Dec 13 2018, 4:49 PM · KDE PIM

Dec 11 2018

kfunk added inline comments to D16484: Add scratchpad plugin.
Dec 11 2018, 8:51 AM · KDevelop

Dec 10 2018

kfunk added a comment to D16484: Add scratchpad plugin.

Yep. please go for it.

Dec 10 2018, 9:53 AM · KDevelop
kfunk committed R32:2bd71e5f79ac: Revert "patchreview: Allow to translate string" (authored by kfunk).
Revert "patchreview: Allow to translate string"
Dec 10 2018, 8:48 AM
kfunk added a reverting change for R32:d91e22649ab1: patchreview: Allow to translate string: R32:2bd71e5f79ac: Revert "patchreview: Allow to translate string".
Dec 10 2018, 8:48 AM
kfunk added a comment to R32:d91e22649ab1: patchreview: Allow to translate string.

@pino I actually thought about the same, but was unsure since Aleix asked to have it translated. I agree with your explanation, it makes sense to have this not translated at all. Will revert.

Dec 10 2018, 8:46 AM
kfunk added inline comments to D16484: Add scratchpad plugin.
Dec 10 2018, 8:45 AM · KDevelop
kfunk committed R877:d2b848fbe24c: Remove dead quanta project (authored by kfunk).
Remove dead quanta project
Dec 10 2018, 8:31 AM
kfunk committed R877:3920ee0e97c2: kdevplatform as extra package is no more (authored by kfunk).
kdevplatform as extra package is no more
Dec 10 2018, 8:30 AM
kfunk committed R32:d91e22649ab1: patchreview: Allow to translate string (authored by kfunk).
patchreview: Allow to translate string
Dec 10 2018, 8:14 AM
kfunk committed R32:a41f7c00535a: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
Dec 10 2018, 8:14 AM
kfunk committed R32:18c0c9681068: patchreview: Fix string (authored by kfunk).
patchreview: Fix string
Dec 10 2018, 8:11 AM

Dec 7 2018

kfunk added a comment to T10154: Craft Qt5.12.0.

Nothing from my side.

Dec 7 2018, 3:50 PM

Dec 3 2018

kfunk accepted D16484: Add scratchpad plugin.
Dec 3 2018, 8:11 PM · KDevelop
kfunk updated the diff for D17325: Fix leak in kemoticons.

Use QSharedPointer

Dec 3 2018, 2:13 PM · Frameworks
kfunk added a comment to D17314: Projects Plugin: Add ShellCheck analyzer.

Just my 2 cent when I saw this review, didn't look further :)

Dec 3 2018, 1:59 PM · Kate
kfunk abandoned D17328: Fix leak in AkonadiCollectionView.

Running into a crash with that patch, need to revisit:

Dec 3 2018, 12:16 PM · KDE PIM
kfunk committed R79:07cdf05be7c3: Minor: Use more nullptr (authored by kfunk).
Minor: Use more nullptr
Dec 3 2018, 11:16 AM
kfunk committed R32:27cca2f34f40: Don't add 'override' specifier for non-modern project settings (authored by amhndu).
Don't add 'override' specifier for non-modern project settings
Dec 3 2018, 11:01 AM
kfunk requested review of D17328: Fix leak in AkonadiCollectionView.
Dec 3 2018, 10:51 AM · KDE PIM
kfunk committed R210:d8a802b14587: Minor: Add icon for "Purge" action (authored by kfunk).
Minor: Add icon for "Purge" action
Dec 3 2018, 10:51 AM
kfunk added inline comments to D16484: Add scratchpad plugin.
Dec 3 2018, 10:18 AM · KDevelop
kfunk accepted D16484: Add scratchpad plugin.

I think this is a great addition and I see myself using this a lot. So far I've done these things through a set of .cpp files lying around in my $HOME and compiled/ran them using some command-line alias :)

Dec 3 2018, 10:07 AM · KDevelop
kfunk accepted D16773: Don't add 'override' specifier for non-modern project settings.

LGTM in general. If you prefer your version (instead of the one proposed by me) feel free to push directly.

Dec 3 2018, 8:48 AM · KDevelop
kfunk added a comment to D17325: Fix leak in kemoticons.

Not entirely sure about whether this is the right fix for this. Can someone check why this was commented before?

Dec 3 2018, 7:29 AM · Frameworks
kfunk requested review of D17325: Fix leak in kemoticons.
Dec 3 2018, 7:28 AM · Frameworks
kfunk committed R94:3728ca387d29: Minor: Fix -Wmismatched-tags warning (authored by kfunk).
Minor: Fix -Wmismatched-tags warning
Dec 3 2018, 7:27 AM
kfunk committed R94:b203c17e8324: Fix potential leak in nodehelper (authored by kfunk).
Fix potential leak in nodehelper
Dec 3 2018, 7:27 AM
kfunk committed R94:b84973019648: Fix leak in messagepartrendererfactory (authored by kfunk).
Fix leak in messagepartrendererfactory
Dec 3 2018, 7:27 AM
kfunk committed R94:0161e0bbba2f: Fix leak in templateparserjob (authored by kfunk).
Fix leak in templateparserjob
Dec 3 2018, 7:27 AM
kfunk added a comment to D17289: KDevelop/Shell: set dedicated TMPDIR.

Okay, trying to keep this short.

Dec 3 2018, 6:01 AM · KDevelop

Dec 2 2018

kfunk committed R180:941233a241c1: Fix leak in KMime::Content::decodedContent() (authored by kfunk).
Fix leak in KMime::Content::decodedContent()
Dec 2 2018, 10:05 AM
kfunk committed R210:b0c5a3945b68: searchdialog: Add more icons (authored by kfunk).
searchdialog: Add more icons
Dec 2 2018, 9:33 AM
kfunk added a comment to D17255: KDevelop: support for installing into a non-standard parallel prefix.

Just some general remarks: Storing the application's install prefix inside the binary itself almost always smells like bad design. Thus the concerns here. You rather want to do this dependent on the kdevelop binary's application path (cf. http://doc.qt.io/qt-5/qcoreapplication.html#applicationDirPath)

Dec 2 2018, 9:28 AM · KDevelop
kfunk updated subscribers of D17255: KDevelop: support for installing into a non-standard parallel prefix.

I've tested the idea of NOT specifying an install prefix default when none has been configured. To the best I can see this does not lead to invalid cmake invocations (aka -DCMAKE_INSTALL_PREFIX=). Instead, this does exactly what you'd expect: cmake will use whatever is its default for the current platform. The result will be obtained from the CMakeCache later on.
In other words, there doesn't appear to be any reason to hardcode assumptions about CMake's defaults, and not doing that should be a suitable compromise for everyone. It also removes the need for conditional code.

Dec 2 2018, 9:25 AM · KDevelop
kfunk added a comment to D17289: KDevelop/Shell: set dedicated TMPDIR.

Forgot: Also needs documentation *in* source code why were are doing this. Noone can figure out that the temp dir is changed due to issues with the Clang backend here...

Dec 2 2018, 9:23 AM · KDevelop
kfunk requested changes to D17289: KDevelop/Shell: set dedicated TMPDIR.

Not usable as-is.

Dec 2 2018, 9:16 AM · KDevelop

Nov 30 2018

kfunk committed R206:7dda54910cb9: snippetwidget: Make 'insert snippet' the default (authored by kfunk).
snippetwidget: Make 'insert snippet' the default
Nov 30 2018, 3:50 PM
kfunk committed R92:36ab29633831: snippets: Add more icons (authored by kfunk).
snippets: Add more icons
Nov 30 2018, 2:50 PM
kfunk added inline comments to D17255: KDevelop: support for installing into a non-standard parallel prefix.
Nov 30 2018, 2:20 PM · KDevelop
kfunk added inline comments to D17255: KDevelop: support for installing into a non-standard parallel prefix.
Nov 30 2018, 12:10 PM · KDevelop
kfunk requested changes to D17255: KDevelop: support for installing into a non-standard parallel prefix.
Nov 30 2018, 12:04 PM · KDevelop

Nov 28 2018

kfunk committed R165:3e7ef8f3f285: Minor: Fix string according to KDE HIG (authored by kfunk).
Minor: Fix string according to KDE HIG
Nov 28 2018, 2:32 PM
kfunk committed R459:267fc2a7de0c: Minor: Fix string according to KDE HIG (authored by kfunk).
Minor: Fix string according to KDE HIG
Nov 28 2018, 1:55 PM
kfunk committed R78:d802a134a6b3: Minor: Respect HIG for button title (authored by kfunk).
Minor: Respect HIG for button title
Nov 28 2018, 1:45 PM
kfunk committed R78:6b8797144d3b: dialogdesktop: Add a lot more icons, fix layouts (authored by kfunk).
dialogdesktop: Add a lot more icons, fix layouts
Nov 28 2018, 1:45 PM
kfunk committed R180:c5e56a4262e4: parsedatetimetest: Fix -Wunused-result warning (authored by kfunk).
parsedatetimetest: Fix -Wunused-result warning
Nov 28 2018, 1:35 PM
kfunk committed R180:6bc93af8fd63: parsedatetimetest: Reformat code (authored by kfunk).
parsedatetimetest: Reformat code
Nov 28 2018, 1:35 PM
kfunk committed R180:61189bfaeabc: Use nullptr (authored by kfunk).
Use nullptr
Nov 28 2018, 1:11 PM

Nov 27 2018

kfunk committed R32:e1a51bd35926: appimage: Use Python 3.6.7, simplify code (authored by kfunk).
appimage: Use Python 3.6.7, simplify code
Nov 27 2018, 8:55 AM
kfunk committed R32:843d27de54f1: appimage: Instal xz-devel (authored by kfunk).
appimage: Instal xz-devel
Nov 27 2018, 8:55 AM
kfunk committed R32:617594478296: appimage: Base on CentOS 6.10 (authored by kfunk).
appimage: Base on CentOS 6.10
Nov 27 2018, 8:55 AM

Nov 26 2018

kfunk accepted D17174: Use qCWarning in path.cpp..

Okay, but you could have pushed this directly ;)

Nov 26 2018, 3:51 PM · KDevelop
kfunk added inline comments to D17130: Fix projectmodel unittest to work on Windows..
Nov 26 2018, 12:18 PM · KDevelop
kfunk added a comment to D17130: Fix projectmodel unittest to work on Windows..

Yes, please.

Nov 26 2018, 11:44 AM · KDevelop
kfunk committed R32:d1e8575645c2: Merge remote-tracking branch 'origin/5.3' (authored by kfunk).
Merge remote-tracking branch 'origin/5.3'
Nov 26 2018, 9:38 AM
kfunk committed R32:d46ed7014365: Make the filteringstrategy test work on Windows as well. (authored by volden).
Make the filteringstrategy test work on Windows as well.
Nov 26 2018, 9:28 AM
kfunk committed R119:00eda23e92aa: Minor: Fix -Wextra-semi warning (authored by kfunk).
Minor: Fix -Wextra-semi warning
Nov 26 2018, 9:27 AM
kfunk committed R119:7f83492a654c: ASAN: Fix leak in KAStatsFavoritesModel (authored by kfunk).
ASAN: Fix leak in KAStatsFavoritesModel
Nov 26 2018, 9:24 AM
kfunk closed D17039: ASAN: Fix leak in KAStatsFavoritesModel.
Nov 26 2018, 9:24 AM · Plasma
kfunk accepted D17158: Fix qmakeproject unittest to work on Windows..
Nov 26 2018, 9:19 AM · KDevelop
kfunk accepted D17156: Fix defines and includes test to run on Windows..
Nov 26 2018, 9:18 AM · KDevelop
kfunk accepted D17130: Fix projectmodel unittest to work on Windows..
Nov 26 2018, 9:18 AM · KDevelop