Fix building against exiv2-0.27
ClosedPublic

Authored by asturmlechner on Dec 25 2018, 5:39 PM.

Details

Summary

Copied FindLibExiv2.cmake from ECM 5.53.0 until we raise min version.

Upstream advises to include single exiv2/exiv2.hpp over separate headers
that are in the process of being refactored.

BUG: 402644

Test Plan

Tested build with exiv2-0.26 and 0.27

Diff Detail

Repository
R378 KExiv2 Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
asturmlechner requested review of this revision.Dec 25 2018, 5:39 PM
asturmlechner created this revision.

Missed updating .pc

Upstream advises to include exiv2/exiv2.hpp over exiv2/version.hpp

Simplify version check to keep cmake at 3.0.0

asturmlechner edited the summary of this revision. (Show Details)Dec 27 2018, 12:25 AM

Also, maybe now it is time to raise minimum exiv2 to (at least) 0.25? This was reverted in 6c196e4 three years ago.

bruns added a subscriber: bruns.Dec 28 2018, 3:21 PM

Build tested on openSUSE, looks fine.

+1

Looking at https://repology.org/metapackage/exiv2/badges i'd sa requiring 0.25 is more than ok at this point if it simplifies stuff

Does this fix https://bugs.kde.org/show_bug.cgi?id=402644? If so, please add BUG: 402644 to the summary section.

bruns added a comment.Dec 29 2018, 2:17 PM

Does this fix https://bugs.kde.org/show_bug.cgi?id=402644? If so, please add BUG: 402644 to the summary section.

Yes, this is fixed by the last hunk in src/kexiv2exif.cpp.

Drop obsolete includes and macro

asturmlechner edited the summary of this revision. (Show Details)Dec 30 2018, 1:17 PM
bruns accepted this revision.Dec 30 2018, 3:32 PM
This revision is now accepted and ready to land.Dec 30 2018, 3:32 PM
This revision was automatically updated to reflect the committed changes.