Feed Advanced Search

Sep 4 2021

asturmlechner added a comment to T11613: Port lokalize away from Kross.

See also https://invent.kde.org/libraries/kross-interpreters/-/issues/1

Sep 4 2021, 2:56 PM · KF6
asturmlechner added a comment to T11553: Port KDE Frameworks away from deprecated methods in Qt.

Phonon is an optional dependency of knotifications and knotifyconfig (they use libcanberra by default IIUC).

Sep 4 2021, 2:35 PM · Frameworks, KF6

May 29 2021

asturmlechner added a comment to D8705: Remove Qt5::Widgets as a dependency.

https://invent.kde.org/frameworks/kwindowsystem/-/commit/5cc5734b46cd3bcc2a35402718731cdae5000803
and
https://invent.kde.org/frameworks/kwindowsystem/-/commit/374a29075694f530d2d0673e33a166c836d02a84

May 29 2021, 4:19 PM · Frameworks

Feb 16 2021

asturmlechner added a comment to D14967: Disable loading of translations for kformattest, which was not designed with translations.

Hm, I find myself disabling ever more tests because I get a report like kformattest when someone has translations installed. How does CI get over that?

Feb 16 2021, 4:11 PM · Frameworks

Feb 12 2021

asturmlechner added a parent task for T14117: Port KGet away from kdelibs4support: T11552: Remove kdelibs4support.
Feb 12 2021, 4:59 PM
asturmlechner added a subtask for T11552: Remove kdelibs4support: T14117: Port KGet away from kdelibs4support.
Feb 12 2021, 4:59 PM · KF6
asturmlechner created T14117: Port KGet away from kdelibs4support.
Feb 12 2021, 4:58 PM

Jan 7 2021

asturmlechner removed a parent task for T10389: Port from webkit to webengine in KEXI and KReport: T11588: Remove KDEWebKit.
Jan 7 2021, 10:50 AM · KReport, KEXI
asturmlechner removed a subtask for T11588: Remove KDEWebKit: T10389: Port from webkit to webengine in KEXI and KReport.
Jan 7 2021, 10:50 AM · KF6
asturmlechner added a parent task for T10389: Port from webkit to webengine in KEXI and KReport: T11588: Remove KDEWebKit.
Jan 7 2021, 10:49 AM · KReport, KEXI
asturmlechner added a subtask for T11588: Remove KDEWebKit: T10389: Port from webkit to webengine in KEXI and KReport.
Jan 7 2021, 10:49 AM · KF6

Jan 1 2021

asturmlechner added a comment to T11603: Port Krusader away from kjsembed.

From what I can see, krusader/KrJS subdir is not used since at least kdelibs4-based version. The includes are ifdef'd out behind __KJSEMBED__ which is set nowhere, maybe even since the switch to cmake. I built both 2.4.0_beta3 and 2.7.2 just fine with the subdir removed (and no kjsembed around, it is already gone from packaging).

Jan 1 2021, 3:47 PM · KF6

Dec 27 2020

asturmlechner added a comment to T13968: Port KTechlab away from KHTML.

Done in https://invent.kde.org/sdk/ktechlab/-/commit/062e29d9ca4bb5ece9fcf18e9682a480ce3448d0

Dec 27 2020, 1:02 AM
asturmlechner assigned T13968: Port KTechlab away from KHTML to sandsmark.
Dec 27 2020, 1:02 AM

Dec 18 2020

asturmlechner added a project to T13967: Port Kopete away from KHTML: Kopete.
Dec 18 2020, 1:51 PM · Kopete

Dec 17 2020

asturmlechner added a parent task for T13968: Port KTechlab away from KHTML: T11542: Remove KHTML.
Dec 17 2020, 11:36 PM
asturmlechner added a subtask for T11542: Remove KHTML: T13968: Port KTechlab away from KHTML.
Dec 17 2020, 11:36 PM · KF6
asturmlechner created T13968: Port KTechlab away from KHTML.
Dec 17 2020, 11:35 PM
asturmlechner added a parent task for T13967: Port Kopete away from KHTML: T11542: Remove KHTML.
Dec 17 2020, 11:20 PM · Kopete
asturmlechner added a subtask for T11542: Remove KHTML: T13967: Port Kopete away from KHTML.
Dec 17 2020, 11:20 PM · KF6
asturmlechner created T13967: Port Kopete away from KHTML.
Dec 17 2020, 11:19 PM · Kopete

Oct 30 2020

asturmlechner added a comment to D19338: New location for KNSRC files.

Hm, why was this new variable KDE_INSTALL_KNSRCDIR not put into KDEInstallDirs?

On the other hand it makes sense that module-specific variables are provided by the CMake config file of the respective module. Which allows projects to use the module without having to use KDEInstallDirs, but e.g. GnuInstallDirs.

Oct 30 2020, 11:03 PM · Frameworks, KNewStuff
asturmlechner added a comment to D19338: New location for KNSRC files.

Hm, why was this new variable KDE_INSTALL_KNSRCDIR not put into KDEInstallDirs?

Oct 30 2020, 10:38 PM · Frameworks, KNewStuff

Oct 26 2020

asturmlechner added a comment to T11612: Port libkvkontakte away from WebKit.

Through the wonders of git rename detection: https://invent.kde.org/libraries/libkvkontakte/-/merge_requests/1

Oct 26 2020, 10:57 PM · KF6

Oct 24 2020

asturmlechner added a comment to T11539: Port Okular away from KHTML.
Oct 24 2020, 12:40 PM · Okular

Sep 29 2020

asturmlechner closed D28284: Add FindMariaDB.cmake module and use it if MySQL is not found.

Thanks for testing! This was pushed with final changes addressing @wbauer's comments in commits 4337b3ef, 03ef605c and 822eddec.

Sep 29 2020, 8:05 PM · Amarok

Sep 17 2020

asturmlechner added a comment to T13631: Consolidate using addons/extras/plugins repos.
In T13631#240328, @alex wrote:

dolphin plugins that solely target developers

That also has mountiso and dropbox plugins, these are not just for developers

Sep 17 2020, 9:14 AM · Frameworks, Dolphin, Plasma
asturmlechner added a comment to T13631: Consolidate using addons/extras/plugins repos.

I don't try to nanny our users into accepting all those extra dependencies.

You're a Gentoo packager, right? My concern here is for users who want things to just work out of the box, not users of distros geared towards technical experts. That's a different problem space. :)

By far not everyone of our users is an expert, and I don't see the numbers to back this up as a huge problem yet. There sure has been the odd forum thread about missing stuff, but through our KDE Wiki it is common knowledge that users are supposed to use the plasma-meta package and that settles it real quick. Is it really beginners who randomly install the minimal plasma-desktop package (if they do, why?) rather than following the distro's Wiki, or is it the tinkerer who doesn't own up to hunting for features manually after going the minimal route? How many distros get it actually wrong, can it be improved by adding RUNTIME infos to cmake? Where are those bug reports you see coming from? Those are the questions before establishing this as a problem we need to fix by lumping repositories together. And that would change it for something like Arch where binary packages are not often being split, but not for others like Debian where the amount of binary packages may not even change except where they pull their sources from.

Sep 17 2020, 9:01 AM · Frameworks, Dolphin, Plasma

Sep 16 2020

asturmlechner added a comment to D23883: libkworkspace: Install sessionmanagementbackend.h with other headers.

It only exists as a hack around some Qt5.9(?) bug to allow plasma stuff to be in wayland without needing us to force an environment variable.
Personally I want to kill it, but AFAIK SuSE still uses it. Worst case we can just copy the 5 lines into kcmshell.

Sep 16 2020, 7:11 PM · Plasma
asturmlechner added a comment to T13631: Consolidate using addons/extras/plugins repos.

I have seen many bug reports and user frustrations whose root cause was not having these packages installed--whether due to bad distro defaults or not knowing about them when using Arch or Debian. We can bug distros to have better defaults and write better documentation and such, but merging their functionality into other repos eliminates the whole class of bug altogether. That's a win IMO.

Sep 16 2020, 6:17 PM · Frameworks, Dolphin, Plasma

Sep 9 2020

asturmlechner added a comment to T11612: Port libkvkontakte away from WebKit.

It was merged into digikam and ported to qtwebengine there.

Sep 9 2020, 5:34 PM · KF6

Jun 28 2020

asturmlechner committed R37:3f3c524bfd44: Merge branch 'work/build_testing' into 'master' (authored by asturmlechner).
Merge branch 'work/build_testing' into 'master'
Jun 28 2020, 11:46 PM

Jun 19 2020

asturmlechner committed R37:fafbb6711f8e: Merge branch 'work/build_testing' into 'master' (authored by asturmlechner).
Merge branch 'work/build_testing' into 'master'
Jun 19 2020, 9:44 AM

Jun 18 2020

asturmlechner committed R37:4aa9d675e52d: Merge branch 'work/build_testing' into 'master' (authored by asturmlechner).
Merge branch 'work/build_testing' into 'master'
Jun 18 2020, 7:35 AM
asturmlechner committed R37:49f795651311: Merge branch 'work/build_testing' into 'master' (authored by asturmlechner).
Merge branch 'work/build_testing' into 'master'
Jun 18 2020, 12:18 AM

Jun 17 2020

asturmlechner committed R37:e77f33f8b1c5: Merge branch 'work/build_testing' into 'master' (authored by asturmlechner).
Merge branch 'work/build_testing' into 'master'
Jun 17 2020, 7:32 PM
asturmlechner committed R37:1014fb6c8cab: Don't build tests when testing not requested (authored by asturmlechner).
Don't build tests when testing not requested
Jun 17 2020, 7:31 PM

Jun 8 2020

asturmlechner added a comment to T12096: Trim down KIO (API and dependencies).

Even if not split up, it would be neat if possible to build the core and non-core part independently (see current KIOCORE_ONLY variable)

Jun 8 2020, 1:09 PM · KF6

May 31 2020

asturmlechner committed R626:44e2a35ebb16: Fix build with Qt 5.15 (missing QPainterPath include) (authored by asturmlechner).
Fix build with Qt 5.15 (missing QPainterPath include)
May 31 2020, 9:39 PM

May 24 2020

asturmlechner added a comment to T12157: KXmlRpcClient deprecation + removal.

It probably makes no sense to be part of Release Service any longer then.

May 24 2020, 10:57 PM · KF6
asturmlechner added a comment to T11539: Port Okular away from KHTML.
May 24 2020, 10:54 PM · Okular

May 7 2020

asturmlechner added a comment to D29514: Add FindXorgServer.cmake and use it for touchpad KCM.

Hmm, on my system, the file is located at /usr/src/xserver/include/xserver-properties.h, and this doesn't seen to find it:

Where is synaptics-properties.h located on your system, if you even have been building touchpad kcm so far?

It's in /usr/include/xorg.

I must confess I've never actually been able to build it, so I appreciate your efforts here to fix that.

In that case yes it must have failed so far during build, now cmake will warn you already. It is now the same as with Evdev, Libinput and Synaptics, if you don't have them in system paths you would have to somehow feed the alternative paths to cmake.

May 7 2020, 8:17 PM · Plasma
asturmlechner added a comment to D29514: Add FindXorgServer.cmake and use it for touchpad KCM.

Hmm, on my system, the file is located at /usr/src/xserver/include/xserver-properties.h, and this doesn't seen to find it:

May 7 2020, 8:05 PM · Plasma
asturmlechner committed R119:82e7a6b68d81: Add FindXorgServer.cmake and use it for touchpad KCM (authored by asturmlechner).
Add FindXorgServer.cmake and use it for touchpad KCM
May 7 2020, 7:19 PM
asturmlechner closed D29514: Add FindXorgServer.cmake and use it for touchpad KCM.
May 7 2020, 7:19 PM · Plasma
asturmlechner requested review of D29514: Add FindXorgServer.cmake and use it for touchpad KCM.
May 7 2020, 6:25 PM · Plasma

Apr 28 2020

asturmlechner added a reverting change for R871:064c400c4400: Make it compile with qt5.15: R871:9b0ced51506c: Revert "Make it compile with qt5.15".
Apr 28 2020, 9:29 PM
asturmlechner committed R871:9b0ced51506c: Revert "Make it compile with qt5.15" (authored by asturmlechner).
Revert "Make it compile with qt5.15"
Apr 28 2020, 9:29 PM

Apr 26 2020

asturmlechner added a comment to D29119: Dolphin: Implement package kit for deb/rpm/pacman service packages.

Does PackageKit work on Windows/MacOS? I don't think so. We should probably run this code only on Unix, no?

Apr 26 2020, 11:45 PM · Dolphin
asturmlechner committed R119:2e8a98a51107: synapticstouchpad.cpp: Drop synaptics-properties.h parent dir from include (authored by asturmlechner).
synapticstouchpad.cpp: Drop synaptics-properties.h parent dir from include
Apr 26 2020, 9:34 PM
asturmlechner closed D29215: synapticstouchpad.cpp: Drop synaptics-properties.h parent dir from include.
Apr 26 2020, 9:34 PM · Plasma
asturmlechner requested review of D29215: synapticstouchpad.cpp: Drop synaptics-properties.h parent dir from include.
Apr 26 2020, 8:45 PM · Plasma
asturmlechner committed R108:1e70f0809323: kwinscreenedges: Fix build (missing main.ui in… (authored by asturmlechner).
kwinscreenedges: Fix build (missing main.ui in…
Apr 26 2020, 6:22 PM
asturmlechner closed D29212: kwinscreenedges: Fix build (missing main.ui in kcm_kwintouchscreenedges_PART_SRCS).
Apr 26 2020, 6:17 PM · KWin
asturmlechner requested review of D29212: kwinscreenedges: Fix build (missing main.ui in kcm_kwintouchscreenedges_PART_SRCS).
Apr 26 2020, 6:06 PM · KWin

Apr 23 2020

asturmlechner added a comment to D28789: Fix crash due to changes in KBookmarkMenu.

This commit is missing in release/20.04 branch.

Apr 23 2020, 1:37 PM
asturmlechner added a comment to D28775: [KJots] Fix bookmarks actions.

Without ifdefs this is effectively raising minimum KF5 dependency to >=5.69:

Apr 23 2020, 10:44 AM · KDE PIM

Apr 21 2020

asturmlechner committed R440:b2c4b841937e: Fix build with Qt-5.15 (missing header) (authored by asturmlechner).
Fix build with Qt-5.15 (missing header)
Apr 21 2020, 6:17 PM
asturmlechner closed D29039: Fix build with Qt-5.15 (missing header).
Apr 21 2020, 6:17 PM
asturmlechner committed R7:f88c73cf278d: Fix build with Qt 5.15 (missing header) (authored by asturmlechner).
Fix build with Qt 5.15 (missing header)
Apr 21 2020, 8:58 AM
asturmlechner closed D29038: Fix build with Qt 5.15 (missing header).
Apr 21 2020, 8:58 AM
asturmlechner requested review of D29039: Fix build with Qt-5.15 (missing header).
Apr 21 2020, 8:43 AM
asturmlechner requested review of D29038: Fix build with Qt 5.15 (missing header).
Apr 21 2020, 8:40 AM

Apr 17 2020

asturmlechner added a comment to D28911: Adapt the code to KBookmarkMenu-5.69 changes.

This should also go to 1.7.

Apr 17 2020, 7:23 PM
asturmlechner added a comment to D28920: Adapt to changes in KBookmarks >= 5.69.

This should be in release/20.04 branch as well *imo*.

Apr 17 2020, 7:15 PM

Apr 14 2020

asturmlechner added a comment to D28242: Fix 'Audio Setup'.

In downstream I've simply removed that menu item for now.

Apr 14 2020, 1:39 PM

Apr 12 2020

asturmlechner added a comment to D28677: Make PipeWire, GBM and Epoxy libs as required dependencies.

Thanks for keeping pipewire optional, this is in line with how we have been packaging xdg-desktop-portal-kde in Gentoo so far, we had just been conditionally disabling the cmake finding of these 3 libraries to do it, and will switch over to using the new option then.

Apr 12 2020, 3:11 PM · Plasma

Mar 25 2020

asturmlechner updated the diff for D28284: Add FindMariaDB.cmake module and use it if MySQL is not found.

re-add accidentally removed required includes to FindMySQLe.cmake

Mar 25 2020, 8:06 PM · Amarok
asturmlechner updated the summary of D28284: Add FindMariaDB.cmake module and use it if MySQL is not found.
Mar 25 2020, 6:39 PM · Amarok
asturmlechner updated the diff for D28284: Add FindMariaDB.cmake module and use it if MySQL is not found.

updated for the case when mysqle is shipped with mariadb

Mar 25 2020, 6:36 PM · Amarok
asturmlechner accepted D27330: Fix DESTDIR usage.

Works for me!

Mar 25 2020, 6:25 PM
asturmlechner committed R540:4d59b59d9cee: Switch from UsePkgConfig to FindPkgConfig (authored by asturmlechner).
Switch from UsePkgConfig to FindPkgConfig
Mar 25 2020, 6:16 PM
asturmlechner closed D19521: Switch from UsePkgConfig to FindPkgConfig.
Mar 25 2020, 6:16 PM
asturmlechner committed R540:737d407a90cf: Set minimum Qt5 and KF5 versions and cleanup ifdefs (authored by asturmlechner).
Set minimum Qt5 and KF5 versions and cleanup ifdefs
Mar 25 2020, 6:12 PM
asturmlechner closed D19522: Set minimum Qt5 and KF5 versions and cleanup ifdefs.
Mar 25 2020, 6:12 PM
Restricted Application added a project to D24817: Restore scripting functionalities and Qt bindings.: Amarok.
Mar 25 2020, 6:05 PM · Amarok
asturmlechner added a comment to D27949: Conclude porting of Last.fm to Amarok KF5.

scrobble it does 👍

Mar 25 2020, 4:34 PM · Amarok
asturmlechner requested review of D28284: Add FindMariaDB.cmake module and use it if MySQL is not found.
Mar 25 2020, 3:43 PM · Amarok
asturmlechner added a comment to D28165: Fix compatibility with modern MySQL.

Waiting for @wbauer to confirm it works as well - btw, does openSUSE still provide mysqle to test -DWITH_MYSQL_EMBEDDED=on?

Mar 25 2020, 3:19 PM · Amarok
asturmlechner accepted D28165: Fix compatibility with modern MySQL.

Please test again, and thanks a lot for the review so far.

Mar 25 2020, 11:52 AM · Amarok
asturmlechner added a comment to D28165: Fix compatibility with modern MySQL.

The content of my /usr/include/mysql/mysql_version.h (which is just a symlink to mariadb_version.h):

Mar 25 2020, 1:15 AM · Amarok

Mar 24 2020

asturmlechner added a comment to D24805: Revert "CMakeLists.txt: use ccache if present".

Is there really any reason to fully revert? Why not just make it not the default per the above comment.

Mar 24 2020, 4:28 PM · Konsole
asturmlechner added a comment to D28242: Fix 'Audio Setup'.

Same check should imo also be added for phononsettings. This is shipped with phonon package, but kmix only indirectly pulls in that via knotifications, where it is optional.

Mar 24 2020, 4:06 PM
asturmlechner added a comment to D28165: Fix compatibility with modern MySQL.

Confirming successful build here as well.

Mar 24 2020, 2:48 PM · Amarok
asturmlechner added a reverting change for R319:007c2a085238: CMakeLists.txt: use ccache if present: D24805: Revert "CMakeLists.txt: use ccache if present".
Mar 24 2020, 10:59 AM
asturmlechner added a reverted change for D24805: Revert "CMakeLists.txt: use ccache if present": R319:007c2a085238: CMakeLists.txt: use ccache if present.
Mar 24 2020, 10:59 AM · Konsole
asturmlechner added a comment to D28165: Fix compatibility with modern MySQL.

That diff now looks like a diff in top of your previous diff.

Mar 24 2020, 12:27 AM · Amarok

Mar 23 2020

asturmlechner updated the summary of D24805: Revert "CMakeLists.txt: use ccache if present".
Mar 23 2020, 11:59 PM · Konsole
asturmlechner updated the diff for D24805: Revert "CMakeLists.txt: use ccache if present".

reverting after the original change did not go through review anyway.

Mar 23 2020, 11:45 PM · Konsole
asturmlechner added a comment to D24805: Revert "CMakeLists.txt: use ccache if present".

And here we have a sandbox error: https://forums.gentoo.org/viewtopic-t-1110252.html

Mar 23 2020, 10:53 PM · Konsole
asturmlechner added a comment to D27656: Adapt to new KAccounts plugin system.

This change should have raised minimum KACCOUNTS_MIN_VERSION as it breaks with 19.12.3 and below.

Mar 23 2020, 9:33 PM

Mar 12 2020

asturmlechner committed R1050:61d9d7eb0f0d: Fix install basket.xml to XDG_MIME_INSTALL_DIR (authored by asturmlechner).
Fix install basket.xml to XDG_MIME_INSTALL_DIR
Mar 12 2020, 2:21 PM
asturmlechner closed D27991: Fix install basket.xml to XDG_MIME_INSTALL_DIR.
Mar 12 2020, 2:20 PM

Mar 11 2020

asturmlechner requested review of D27991: Fix install basket.xml to XDG_MIME_INSTALL_DIR.
Mar 11 2020, 6:15 PM

Mar 5 2020

asturmlechner committed R320:1029148d9ca7: Build kio_nfs against standalone libtirpc (authored by asturmlechner).
Build kio_nfs against standalone libtirpc
Mar 5 2020, 12:07 AM
asturmlechner committed R320:9f1b9eb8b302: Add FindTIRPC.cmake (authored by krop).
Add FindTIRPC.cmake
Mar 5 2020, 12:07 AM
asturmlechner closed D17205: Build kio_nfs against standalone libtirpc.
Mar 5 2020, 12:07 AM · Frameworks, Dolphin

Jan 19 2020

asturmlechner added a comment to D26306: Define more documentation search paths (also custom).

Thanks for that, works for me!

Jan 19 2020, 7:24 PM · Documentation, Frameworks
asturmlechner added a comment to D26558: Port to fluidsynth 2.0.0 API.

What consequence is there for using minuet with fluidsynth-2 without this patch? So far it had built and linked to it without issues.

Jan 19 2020, 6:57 PM · Minuet, KDE Edu

Jan 12 2020

asturmlechner committed R252:08b1eabe3f54: Drop unused dependency (authored by asturmlechner).
Drop unused dependency
Jan 12 2020, 12:44 AM