Details
Details
- Reviewers
markey yurchor heikobecker - Group Reviewers
Amarok - Commits
- R181:c84422b41f6d: Add missing QStandardPaths to fix build
Diff Detail
Diff Detail
- Repository
- R181 Amarok
- Branch
- buildfix
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 7784 Build 7802: arc lint + arc unit
Comment Actions
Is it really needed?
It seems that build factory can build Amarok even without this include.
https://build.kde.org/job/Extragear/job/amarok/
Thanks in advance for your answer.
Comment Actions
-c /var/tmp/portage/media-sound/amarok-9999/work/amarok-9999/src/main.cpp /var/tmp/portage/media-sound/amarok-9999/work/amarok-9999/src/main.cpp:101:162: warning: macro "__DATE__" might prevent reproducible builds [-Wdate-time] ki18n( "IRC:\nirc.freenode.net - #amarok, #amarok.de, #amarok.es, #amarok.fr\n\nFeedback:\namarok@kde.org\n\n(Build Date: %1)" ).subs( __DATE__ ).toString(), ^~~~~~~~ /var/tmp/portage/media-sound/amarok-9999/work/amarok-9999/src/main.cpp: In function ‘int main(int, char**)’: /var/tmp/portage/media-sound/amarok-9999/work/amarok-9999/src/main.cpp:74:40: error: ‘QStandardPaths’ has not been declared const QString targetBasePath = QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation) + QStringLiteral("/amarok/"); ^~~~~~~~~~~~~~ /var/tmp/portage/media-sound/amarok-9999/work/amarok-9999/src/main.cpp:74:73: error: ‘QStandardPaths’ has not been declared const QString targetBasePath = QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation) + QStringLiteral("/amarok/"); ^~~~~~~~~~~~~~ /var/tmp/portage/media-sound/amarok-9999/work/amarok-9999/src/main.cpp:361:82: note: #pragma message: PORT KF5: This *if* should be moved to activateRequested() slot #pragma message("PORT KF5: This *if* should be moved to activateRequested() slot") ^
Comment Actions
This occurred after switching to ninja by default, maybe related. But I hadn't built amarok before that in a while.