hetzenecker (Lukas Hetzenecker)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 18 2017, 1:11 AM (126 w, 6 d)
Availability
Available

Recent Activity

Apr 7 2019

hetzenecker added a comment to D7581: HiDPI Support for Gwenview.

Wow, it's so great to see this finally merged.
@volkov - a huge thank you that you took over this patch and for all the work you put in to finally resolve this.

Apr 7 2019, 9:36 PM · Gwenview

Aug 7 2018

hetzenecker added a comment to D7581: HiDPI Support for Gwenview.

Unfortunately I was also busy with other work recently, so I could not persue this any further.
Perhaps it would be a good idea to get together and discuss this at Akademy (e.g. how to handle the freedesktop.org thumbnail caching spec). Will you join Akademy this year?

Aug 7 2018, 5:03 AM · Gwenview

Jul 12 2018

hetzenecker added a comment to T9189: derStandard/Web.

sorry, please delete :(

Jul 12 2018, 2:35 AM · Akademy (Akademy 2018)
hetzenecker added a comment to T7838: Akademy 2018: Promotion in local media.

DONE:
derStandard/Web
futurezone
heise

Jul 12 2018, 2:34 AM · Akademy (Akademy 2018)
hetzenecker updated the task description for T7838: Akademy 2018: Promotion in local media.
Jul 12 2018, 2:33 AM · Akademy (Akademy 2018)
hetzenecker merged task T9189: derStandard/Web into T7838: Akademy 2018: Promotion in local media.
Jul 12 2018, 2:32 AM · Akademy (Akademy 2018)
hetzenecker merged T9189: derStandard/Web into T7838: Akademy 2018: Promotion in local media.
Jul 12 2018, 2:32 AM · Akademy (Akademy 2018)
hetzenecker triaged T9189: derStandard/Web as Normal priority.
Jul 12 2018, 2:30 AM · Akademy (Akademy 2018)
hetzenecker moved T7838: Akademy 2018: Promotion in local media from Waiting to In Progress on the Akademy (Akademy 2018) board.
Jul 12 2018, 1:47 AM · Akademy (Akademy 2018)
hetzenecker moved T7838: Akademy 2018: Promotion in local media from Backlog to Waiting on the Akademy (Akademy 2018) board.
Jul 12 2018, 1:47 AM · Akademy (Akademy 2018)

Dec 6 2017

hetzenecker added a comment to T7464: Akademy 2018 Sponsorship Brochure.

If we mention them at all (ping @derkits ), we just want to use the sentence "Akademy 2018 is being organized together with Fachschaft Informatik (FSINF), which supports the local team at the location."

Dec 6 2017, 8:42 PM · Akademy (Akademy 2018), KDE Promo
hetzenecker added a comment to T7464: Akademy 2018 Sponsorship Brochure.

Here is a suggestion what you could write for Vienna:

Dec 6 2017, 8:36 PM · Akademy (Akademy 2018), KDE Promo

Nov 27 2017

hetzenecker added a comment to D8918: General HiDPI enablement for Gwenview's importer.

Don't know if I have the permission to officially review changes, but I can confirm this improves things. :-)

Nov 27 2017, 5:19 PM
hetzenecker accepted D8918: General HiDPI enablement for Gwenview's importer.
Nov 27 2017, 5:11 PM

Nov 24 2017

hetzenecker added a comment to T7464: Akademy 2018 Sponsorship Brochure.

In case it isn't clear, the order in the logo is Karlskirche, Stephansdom, ferris wheel ;-)

Nov 24 2017, 6:58 PM · Akademy (Akademy 2018), KDE Promo
hetzenecker added a comment to T7464: Akademy 2018 Sponsorship Brochure.
In T7464#118847, @paulb wrote:

that would be very helpful. I'm going to revise and update the texts that would be the same, but, of course the texts about the location would change a lot. If you could look at the ODT file in the shared folder, you can work on a draft for the location bits. Is that possible?

Nov 24 2017, 6:56 PM · Akademy (Akademy 2018), KDE Promo
hetzenecker added a comment to T7464: Akademy 2018 Sponsorship Brochure.

Okay, I'll leave this task to you for the moment.

Nov 24 2017, 4:45 PM · Akademy (Akademy 2018), KDE Promo

Nov 15 2017

hetzenecker updated the diff for D7581: HiDPI Support for Gwenview.

Yes, this definitely still needs some work.

Nov 15 2017, 9:22 PM · Gwenview
hetzenecker added inline comments to D7581: HiDPI Support for Gwenview.
Nov 15 2017, 9:20 PM · Gwenview
hetzenecker added a comment to D7581: HiDPI Support for Gwenview.

@rkflx just wanted to give you a quick update so you know I haven't abandoned this.
I've made some helper functions for shrinking and enlarging QRect(F)s in PaintUtils.
Those were really useful and also simplified the zoom scaling quite a bit. Now the only thing left to do is finding out how the heck this simple change completely broke the rendering - again. ;)
But I expect to have this ready in soon™.

Nov 15 2017, 4:46 PM · Gwenview

Nov 3 2017

hetzenecker added a comment to D7581: HiDPI Support for Gwenview.

@rkflx wow, thanks for your thorough review - this provides a really nice roadmap :)
I agree that this patch is essential for todays displays.

Nov 3 2017, 4:52 PM · Gwenview
hetzenecker committed R260:0dac9cac5996: Squashed commit of the following: (authored by hetzenecker).
Squashed commit of the following:
Nov 3 2017, 4:41 PM
hetzenecker added a reverting change for R260:da4775b78635: test: R260:0dac9cac5996: Squashed commit of the following:.
Nov 3 2017, 4:41 PM
hetzenecker committed R260:6c9b10af9859: first try of thumbnail scaling (authored by hetzenecker).
first try of thumbnail scaling
Nov 3 2017, 4:41 PM
hetzenecker added a reverting change for R260:2bc22082d2bf: Revert "test": R260:0dac9cac5996: Squashed commit of the following:.
Nov 3 2017, 4:41 PM

Oct 24 2017

hetzenecker added a comment to D7581: HiDPI Support for Gwenview.

@ngraham unfortunately not yet, but still plan on getting back to it sooner than later..

Oct 24 2017, 11:44 PM · Gwenview

Oct 16 2017

hetzenecker abandoned D6268: HiDPI Support for Okular.
Oct 16 2017, 8:35 PM · Okular
hetzenecker reclaimed D6268: HiDPI Support for Okular.
Oct 16 2017, 8:35 PM · Okular
hetzenecker abandoned D6268: HiDPI Support for Okular.

Thanks for all your comments!

Oct 16 2017, 12:12 PM · Okular

Oct 14 2017

rkflx awarded D6268: HiDPI Support for Okular a Like token.
Oct 14 2017, 7:50 PM · Okular
hetzenecker committed R223:ecc1141e0293: HiDPI Support for Okular (authored by hetzenecker).
HiDPI Support for Okular
Oct 14 2017, 12:54 PM

Sep 1 2017

hetzenecker added a comment to D6268: HiDPI Support for Okular.

I just had a look at it.. and no, sorry, I didn't have enough time to spot the error. Guess you are on your own :/

Sep 1 2017, 10:26 AM · Okular
hetzenecker added a comment to D6268: HiDPI Support for Okular.

I am going on a journey this month - this unfortunately means I also won't have access to the internet.
It'd pick up work on this patch after I return though, if nobody else already has ;)

Sep 1 2017, 9:35 AM · Okular
hetzenecker added a comment to D7581: HiDPI Support for Gwenview.

I am going on a journey this month - this unfortunately means I also won't have access to the internet.
It'd pick up work on this patch after I return though, if nobody else already has ;)

Sep 1 2017, 9:32 AM · Gwenview

Aug 30 2017

hetzenecker added a comment to D7581: HiDPI Support for Gwenview.
In D7581#141489, @cfeck wrote:

With Wayland, we can have different scaling factors per screen. Is it better to use QScreen::devicePixelRatio() or QWindow::devicePixelRatio() instead of QApplication::devicePixelRatio()?

Aug 30 2017, 5:22 PM · Gwenview

Aug 28 2017

hetzenecker committed R260:9b44fe7e9b95: cleanup (authored by hetzenecker).
cleanup
Aug 28 2017, 6:50 AM
hetzenecker committed R260:2635770404cb: fix BirdEyeView (authored by hetzenecker).
fix BirdEyeView
Aug 28 2017, 6:50 AM
hetzenecker committed R260:ef6a4a9867ab: small cleanup (authored by hetzenecker).
small cleanup
Aug 28 2017, 6:50 AM
hetzenecker committed R260:72edb44e19e6: fix topleft corner (authored by hetzenecker).
fix topleft corner
Aug 28 2017, 6:50 AM
hetzenecker committed R260:26addd25bde3: finally seems to work (authored by hetzenecker).
finally seems to work
Aug 28 2017, 6:50 AM
hetzenecker committed R260:8b83a0660868: Revert "Revert "test"" (authored by hetzenecker).
Revert "Revert "test""
Aug 28 2017, 6:50 AM
hetzenecker added a reverting change for R260:2bc22082d2bf: Revert "test": R260:8b83a0660868: Revert "Revert "test"".
Aug 28 2017, 6:50 AM
hetzenecker committed R260:1808ae8c76a4: test (authored by hetzenecker).
test
Aug 28 2017, 6:50 AM
hetzenecker added a reverting change for R260:da4775b78635: test: R260:2bc22082d2bf: Revert "test".
Aug 28 2017, 6:50 AM
hetzenecker committed R260:2bc22082d2bf: Revert "test" (authored by hetzenecker).
Revert "test"
Aug 28 2017, 6:50 AM
hetzenecker committed R260:083d60c4917f: test (authored by hetzenecker).
test
Aug 28 2017, 6:50 AM
hetzenecker committed R260:da4775b78635: test (authored by hetzenecker).
test
Aug 28 2017, 6:50 AM
hetzenecker committed R260:1452122b8253: initial hidpi scaling (authored by hetzenecker).
initial hidpi scaling
Aug 28 2017, 6:50 AM
hetzenecker added inline comments to D6268: HiDPI Support for Okular.
Aug 28 2017, 6:27 AM · Okular
hetzenecker added a comment to D6268: HiDPI Support for Okular.

Oh, and before I forget:
TIFF files are generally broken, there is a bug report for that: https://bugs.kde.org/show_bug.cgi?id=371828 (noticed that after endless hours of debugging ;) )

Aug 28 2017, 6:25 AM · Okular
hetzenecker updated the diff for D6268: HiDPI Support for Okular.

Adressed raised problems by sander and David:

  • fix annotation icon size in settings dialog (i don't know how this could have ever worked ;) )
  • removed redundant else branch
Aug 28 2017, 6:22 AM · Okular
hetzenecker committed R223:14984493d841: fix icon size in settings (authored by hetzenecker).
fix icon size in settings
Aug 28 2017, 6:19 AM
hetzenecker committed R223:af36bc6e9c6d: redundant else branch, as pointed out by d_ed (authored by hetzenecker).
redundant else branch, as pointed out by d_ed
Aug 28 2017, 6:19 AM
hetzenecker created D7581: HiDPI Support for Gwenview.
Aug 28 2017, 5:57 AM · Gwenview

Aug 23 2017

hetzenecker updated the diff for D6268: HiDPI Support for Okular.

Addressed the previous comments, change includes in particular:

Aug 23 2017, 9:00 AM · Okular
hetzenecker added a reverting change for R223:5363324df911: fix other potential errors: R223:eee7ba60ff6d: Revert "fix other potential errors".
Aug 23 2017, 8:56 AM
hetzenecker committed R223:eee7ba60ff6d: Revert "fix other potential errors" (authored by hetzenecker).
Revert "fix other potential errors"
Aug 23 2017, 8:56 AM
hetzenecker committed R223:f9d3093853bd: fix presentations... again (authored by hetzenecker).
fix presentations... again
Aug 23 2017, 8:56 AM
hetzenecker committed R223:5363324df911: fix other potential errors (authored by hetzenecker).
fix other potential errors
Aug 23 2017, 8:56 AM
hetzenecker committed R223:a41dc662ca68: style (authored by hetzenecker).
style
Aug 23 2017, 8:31 AM
hetzenecker committed R223:ea4a8c3e471c: do not copy tilePixmap (authored by hetzenecker).
do not copy tilePixmap
Aug 23 2017, 8:31 AM
hetzenecker committed R223:6bb2eef4c9c6: do not copy tilePixmap (authored by hetzenecker).
do not copy tilePixmap
Aug 23 2017, 8:31 AM
hetzenecker committed R223:b3683d4e39dd: cleanup (authored by hetzenecker).
cleanup
Aug 23 2017, 8:31 AM
hetzenecker committed R223:95f80481efeb: fix annotation pixmaps (authored by hetzenecker).
fix annotation pixmaps
Aug 23 2017, 8:31 AM
hetzenecker committed R223:9729578176fd: Revert "[WIP] try to fix annotation pixmaps" (authored by hetzenecker).
Revert "[WIP] try to fix annotation pixmaps"
Aug 23 2017, 8:31 AM
hetzenecker added a reverting change for R223:c7f70a43cd9a: [WIP] try to fix annotation pixmaps: R223:9729578176fd: Revert "[WIP] try to fix annotation pixmaps".
Aug 23 2017, 8:30 AM
hetzenecker committed R223:c7f70a43cd9a: [WIP] try to fix annotation pixmaps (authored by hetzenecker).
[WIP] try to fix annotation pixmaps
Aug 23 2017, 6:13 AM
hetzenecker committed R223:0ae3331cebb9: Hopefully fix remaining problems caused by floating point rounding errors (authored by hetzenecker).
Hopefully fix remaining problems caused by floating point rounding errors
Aug 23 2017, 12:13 AM

Aug 22 2017

hetzenecker committed R223:0ddf7898c966: Partially fix annotations drawing (see https://phabricator.kde.org/D6268#136221) (authored by hetzenecker).
Partially fix annotations drawing (see https://phabricator.kde.org/D6268#136221)
Aug 22 2017, 10:51 PM

Aug 17 2017

hetzenecker committed R223:24246266f179: combine checks (authored by hetzenecker).
combine checks
Aug 17 2017, 8:46 PM
hetzenecker committed R223:0b25dfcd320d: check for null pointer (authored by hetzenecker).
check for null pointer
Aug 17 2017, 8:43 PM
hetzenecker committed R223:da32ebf7fc05: pixmap = *p (authored by hetzenecker).
pixmap = *p
Aug 17 2017, 8:43 PM
hetzenecker committed R223:52c39db52c22: use const cast, address other issues (authored by hetzenecker).
use const cast, address other issues
Aug 17 2017, 8:43 PM

Aug 16 2017

hetzenecker updated the diff for D6268: HiDPI Support for Okular.

Fixed presentation mode
Fixed scaling using TileManager

Aug 16 2017, 5:26 AM · Okular
hetzenecker committed R223:5c08d3f829ca: cleanup (authored by hetzenecker).
cleanup
Aug 16 2017, 5:19 AM
hetzenecker committed R223:aa20c90c7dc9: Merge branch 'master' into gsoc2017_hidpi_support (authored by hetzenecker).
Merge branch 'master' into gsoc2017_hidpi_support
Aug 16 2017, 5:18 AM
hetzenecker committed R223:3f3742dab670: Fix presentation loading (authored by hetzenecker).
Fix presentation loading
Aug 16 2017, 5:18 AM
hetzenecker committed R223:91fc9bb23326: PRES (authored by hetzenecker).
PRES
Aug 16 2017, 5:18 AM
hetzenecker committed R223:f94bf0876af5: debug (authored by hetzenecker).
debug
Aug 16 2017, 5:18 AM

Jul 31 2017

hetzenecker committed R223:2cc52af0c7ed: Merge branch 'try-dpr-only-when-painting' into gsoc2017_hidpi_support (authored by hetzenecker).
Merge branch 'try-dpr-only-when-painting' into gsoc2017_hidpi_support
Jul 31 2017, 6:01 AM
hetzenecker committed R223:f30cbbf9ac6c: up (authored by hetzenecker).
up
Jul 31 2017, 6:01 AM
hetzenecker committed R223:f985fc1d0721: HiDPI: All pixmaps get cached with the highest DPR of all screens Simplify code… (authored by hetzenecker).
HiDPI: All pixmaps get cached with the highest DPR of all screens Simplify code…
Jul 31 2017, 6:01 AM
hetzenecker committed R223:9db06e449404: HiDPI: Fix scaling when using the tilemanager (authored by hetzenecker).
HiDPI: Fix scaling when using the tilemanager
Jul 31 2017, 6:01 AM

Jul 17 2017

hetzenecker committed R223:ac7d0687ced3: Overlay widget finalized (authored by hetzenecker).
Overlay widget finalized
Jul 17 2017, 12:31 PM
hetzenecker committed R223:a38d369a5ae5: Fix scaling in presentation mode TODO: HiDPI rendering of progress overlay (authored by hetzenecker).
Fix scaling in presentation mode TODO: HiDPI rendering of progress overlay
Jul 17 2017, 12:31 PM
hetzenecker committed R223:a1fcadb41f8c: WIP: Overlay widget (authored by hetzenecker).
WIP: Overlay widget
Jul 17 2017, 12:31 PM
hetzenecker committed R223:8c1037c27038: HiDPI: Fixed another bug, this time in the 'BUFFERED FLOW/with tilemanager/non… (authored by hetzenecker).
HiDPI: Fixed another bug, this time in the 'BUFFERED FLOW/with tilemanager/non…
Jul 17 2017, 12:31 PM
hetzenecker committed R223:f5f7571b6133: HiDPI: Fix untiled page painting while zooming (authored by hetzenecker).
HiDPI: Fix untiled page painting while zooming
Jul 17 2017, 12:31 PM
hetzenecker committed R223:a6c50d011bbc: HiDPI Support: This is my initial draft that enables HiDPI throught the… (authored by hetzenecker).
HiDPI Support: This is my initial draft that enables HiDPI throught the…
Jul 17 2017, 12:31 PM
hetzenecker committed R223:62d3ab74ff8d: First work towards HiDPI support, enable correct scaling of icons by setting Qt… (authored by hetzenecker).
First work towards HiDPI support, enable correct scaling of icons by setting Qt…
Jul 17 2017, 12:31 PM

Jul 10 2017

hetzenecker committed R223:6a3af6c26e98: Overlay widget finalized (authored by hetzenecker).
Overlay widget finalized
Jul 10 2017, 3:39 PM
hetzenecker committed R223:147ce40bc19c: WIP: Overlay widget (authored by hetzenecker).
WIP: Overlay widget
Jul 10 2017, 3:39 PM
hetzenecker committed R223:d37f0b60b967: Fix scaling in presentation mode TODO: HiDPI rendering of progress overlay (authored by hetzenecker).
Fix scaling in presentation mode TODO: HiDPI rendering of progress overlay
Jul 10 2017, 2:01 PM

Jul 6 2017

hetzenecker committed R223:9a816c4ab104: HiDPI: Fixed another bug, this time in the 'BUFFERED FLOW/with tilemanager/non… (authored by hetzenecker).
HiDPI: Fixed another bug, this time in the 'BUFFERED FLOW/with tilemanager/non…
Jul 6 2017, 9:34 AM

Jul 5 2017

hetzenecker committed R223:1a3f9a8c94bb: HiDPI: Fix untiled page painting while zooming (authored by hetzenecker).
HiDPI: Fix untiled page painting while zooming
Jul 5 2017, 4:28 AM
hetzenecker committed R223:c69bed79078b: HiDPI Support: This is my initial draft that enables HiDPI throught the… (authored by hetzenecker).
HiDPI Support: This is my initial draft that enables HiDPI throught the…
Jul 5 2017, 4:28 AM
hetzenecker committed R223:305d46037302: First work towards HiDPI support, enable correct scaling of icons by setting Qt… (authored by hetzenecker).
First work towards HiDPI support, enable correct scaling of icons by setting Qt…
Jul 5 2017, 4:28 AM

Jul 3 2017

hetzenecker added a comment to D6268: HiDPI Support for Okular.

Thanks for your feedback.

Jul 3 2017, 3:06 PM · Okular

Jul 1 2017

hetzenecker added a comment to D6268: HiDPI Support for Okular.

I've defined my test cases here (sorry for using an external service, i wanted to show the test cases in a matrix/spreadsheet; you don't need an account for viewing)
and will look into fixing presentation mode and some remaining zooming issues for the next revision

Jul 1 2017, 8:22 PM · Okular
hetzenecker updated the test plan for D6268: HiDPI Support for Okular.
Jul 1 2017, 8:18 PM · Okular