Differential D16012

Make Qt5Test optional
ClosedPublic
Actions

Authored by asturmlechner on Oct 7 2018, 12:46 PM.

Details

Reviewers
kfunk
Group Reviewers
KDevelop
Commits
R52:967551db23fb: Make Qt5Test optional
Test Plan

Builds fine w/o Qt5Test present.

Diff Detail

Repository
R52 KDevelop: PHP Support
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
asturmlechner created this revision.Oct 7 2018, 12:46 PM
Restricted Application added a project: KDevelop. · View Herald TranscriptOct 7 2018, 12:46 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald Transcript
asturmlechner requested review of this revision.Oct 7 2018, 12:46 PM
kfunk accepted this revision.Oct 7 2018, 5:11 PM
kfunk added a subscriber: kfunk.

To 5.3 branch, please.

This revision is now accepted and ready to land.Oct 7 2018, 5:11 PM
asturmlechner added a comment.Oct 7 2018, 7:46 PM
In D16012#338544, @kfunk wrote:

To 5.3 branch, please.

sure, instead/in addition?

asturmlechner updated this revision to Diff 43090.Oct 7 2018, 10:29 PM

Make KF5Archive exclusive to BUILD_TESTING as well

asturmlechner added a comment.Oct 8 2018, 6:37 AM

(there are also some missing deps that are implicitly linked, but that is for another review)

Closed by commit R52:967551db23fb: Make Qt5Test optional (authored by asturmlechner, committed by kfunk). · Explain WhyOct 8 2018, 11:50 AM
This revision was automatically updated to reflect the committed changes.
kfunk added a comment.Oct 8 2018, 11:51 AM

Pushed this for you. To 5.3 branch.

Note that the KF5::Archive dep wasn't necessary to begin with. Removed the dep in an earlier commit.

kfunk added a comment.Oct 8 2018, 11:52 AM
In D16012#338924, @asturmlechner wrote:

(there are also some missing deps that are implicitly linked, but that is for another review)

Not sure what you mean with that; if we don't directly link to those deps, then we don't need to find_package(...) them either.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (5 lines)

Diff 43128

View Options

CMakeLists.txt

Loading...