Qt5OpenGL is only required with optional AvogadroLibs support
ClosedPublic

Authored by asturmlechner on Jan 17 2019, 10:27 AM.

Details

Summary

Add missing search for Qt5Xml
Add missing Qt5Widgets to compoundviewer target_link_libraries
Remove Qt5OpenGL from libscience target_link_libraries, not used

Test Plan

Built fine with multiple cmake option combinations.

Diff Detail

Repository
R326 Kalzium
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7207
Build 7225: arc lint + arc unit
asturmlechner created this revision.Jan 17 2019, 10:27 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptJan 17 2019, 10:27 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
asturmlechner requested review of this revision.Jan 17 2019, 10:27 AM
aacid added a subscriber: aacid.Jan 19 2019, 12:26 AM

Are you sure about this?

tools/moleculeview.cpp seems to use some QGL stuff

Also there's a Qt5::OpenGL in src/ so it means it should also search for it, no?

tools/moleculeview.cpp seems to use some QGL stuff

Also there's a Qt5::OpenGL in src/ so it means it should also search for it, no?

Both are if'd away already behind EIGEN3_FOUND AND AvogadroLibs_FOUND (so my git summary is not precise enough but the cmake changes work).

aacid accepted this revision.Jan 19 2019, 9:11 PM

ok, guess so

This revision is now accepted and ready to land.Jan 19 2019, 9:11 PM
asturmlechner retitled this revision from Qt5OpenGL is only required in optional compoundviewer to Qt5OpenGL is only required with optional AvogadroLibs support.Jan 24 2019, 5:35 PM
asturmlechner closed this revision.Jan 24 2019, 5:41 PM