Latest glibc versions deprecate its rpc implementation and don't build it by default. This patch allows building the nfs kioslave against libtirpc instead.
Details
Details
- Reviewers
dfaure rdieter asturmlechner krop fvogt
Build with libtirpc installed: kio-nfs is built and links to libtirpc
Remove /usr/include/tirpc/rpc/rpc.h, use glibc with enabled rpc: kio-nfs is built and doesn't link to libtirpc
Remove /usr/include/tirpc/rpc/rpc.h, use glibc with disabled rpc: kio-nfs is not built
Diff Detail
Diff Detail
- Repository
- R320 KIO Extras
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
IIRC @cgiboudeaux wrote this exact patch for kio-nfs from KDE 4 as well, but we opted to disable support downstream instead.
Comment Actions
https://paste.kde.org/pscug8tik ← the patch I created for our kdebase4-runtime package, maybe you can pick useful things :)
| nfs/CMakeLists.txt | ||
|---|---|---|
| 4 | This won't work for openSUSE: the tirpc headers are installed in /usr/include directly. | |
| CMakeLists.txt | ||
|---|---|---|
| 175 | I would prefer a real build option instead of automagic here, and the detection below that conditional. I'm aware that's more than what we have right now. | |
| nfs/CMakeLists.txt | ||
| 4 | Could you suggest an alternative? Gentoo shares a similarity with Arch there, because otherwise libtirpc could collide with older versions of glibc. | |
| nfs/CMakeLists.txt | ||
|---|---|---|
| 4 | I added the solution we use in openSUSE: https://paste.kde.org/pscug8tik | |
| nfs/CMakeLists.txt | ||
|---|---|---|
| 4 | Any solution is fine however, we now patched ours kdebase4-runtime package to disable kio-nfs completely. Pick the solution you prefer. | |
| nfs/CMakeLists.txt | ||
|---|---|---|
| 4 | Thanks, your FindTIRPC works for me. This is what I came up with using it: https://paste.pound-python.org/show/zgu3uRLCJzKqXj97mL5b/ | |