Move required KF5KDELibs4Support dependency to conditional kolab resource
AbandonedPublic

Authored by asturmlechner on Nov 13 2018, 7:56 PM.

Details

Reviewers
mlaurent
Group Reviewers
KDE PIM
Summary

Fix definitions required for build when not provided by KF5KDELibs4Support.

BUG: 400934

Test Plan

Builds fine without KF5KDELibs4Support again (w/o kolab resource)

Diff Detail

Repository
R44 KDE PIM Runtime
Branch
Applications/18.12
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4916
Build 4934: arc lint + arc unit
asturmlechner created this revision.Nov 13 2018, 7:56 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptNov 13 2018, 7:56 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
asturmlechner requested review of this revision.Nov 13 2018, 7:56 PM
asturmlechner added a subscriber: vkrause.
mlaurent requested changes to this revision.Nov 13 2018, 10:26 PM
mlaurent added inline comments.
CMakeLists.txt
153

Why ?

This revision now requires changes to proceed.Nov 13 2018, 10:26 PM
asturmlechner added inline comments.Nov 14 2018, 12:28 AM
CMakeLists.txt
153

this is taken from KDELibs4Support, build would still fail without it:

.../resources/ews/ewsclient/auth/ewspkeyauthjob.cpp: In member function ‘virtual void EwsPKeyAuthJob::start()’:
.../resources/ews/ewsclient/auth/ewspkeyauthjob.cpp:72:35: error: variable ‘const QUrlQuery query’ has initializer but incomplete type
     const QUrlQuery query(mPKeyUri);
                                   ^
.../resources/ews/ewsclient/auth/ewspkeyauthjob.cpp: In member function ‘void EwsPKeyAuthJob::sendAuthRequest(const QByteArray&, const QUrl&, const QString&)’:
.../resources/ews/ewsclient/auth/ewspkeyauthjob.cpp:102:108: error: ‘class QString’ has no member named ‘toAscii’
         QStringLiteral("PKeyAuth AuthToken=\"%1\",Context=\"%2\",Version=\"1.0\"").arg(respToken, context).toAscii());
                                                                                                            ^~~~~~~
dvratil added inline comments.
CMakeLists.txt
153

The resource should be fixed instead, then.

asturmlechner abandoned this revision.Nov 16 2018, 10:33 PM

This needs much more work unfortunately. The existing changeset also appears to be broken with oauth support, so I'm going to pull it.