Differential D16073

openconnect: add missing dependency Qt5Xml
ClosedPublic
Actions

Authored by asturmlechner on Oct 9 2018, 2:12 PM.

Details

Reviewers
alexeymin
Group Reviewers
Plasma
Commits
R116:6919a84c70d8: openconnect: add missing dependency Qt5Xml
Summary

QDomDocument is imported from vpn/openconnect/openconnectauth.cpp

Test Plan

Build succeeds now.

Diff Detail

Repository
R116 Plasma Network Management Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
asturmlechner created this revision.Oct 9 2018, 2:12 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 9 2018, 2:12 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
asturmlechner requested review of this revision.Oct 9 2018, 2:12 PM
asturmlechner updated this revision to Diff 43221.Oct 9 2018, 2:18 PM

Only pull in Qt5Xml if OpenConnect is requested.

alexeymin accepted this revision.Oct 9 2018, 4:29 PM
alexeymin added a subscriber: alexeymin.

https://cgit.kde.org/plasma-nm.git/diff/vpn/openconnect/CMakeLists.txt?id=a44b7f38c548d756b6cb822c047ef71cf67645f5
Probably this commit could remove dependency on QtXml (I'm not sure, QtDbus probably depends on QtXml and QtDbus was removed)
If it fixes build error .../vpn/openconnect/openconnectauth.cpp:38:10: fatal error: QDomDocument: No such file or directory then fine...

This revision is now accepted and ready to land.Oct 9 2018, 4:29 PM
asturmlechner added a comment.Oct 9 2018, 7:30 PM
In D16073#340107, @alexeymin wrote:

If it fixes build error .../vpn/openconnect/openconnectauth.cpp:38:10: fatal error: QDomDocument: No such file or directory then fine...

Yes, it was exactly that: https://bugs.gentoo.org/668166

Closed by commit R116:6919a84c70d8: openconnect: add missing dependency Qt5Xml (authored by asturmlechner). · Explain WhyOct 9 2018, 7:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mvpn/openconnect/CMakeLists.txt (4 lines)

Diff 43247

View Options

vpn/openconnect/CMakeLists.txt

Loading...