Create Task
Maniphest T12285

KTextWidgets usage in KIO
Open, Needs TriagePublic
Actions

Description

The only place we use KTextWidgets in KIO directly is in the Connection Preferences KCM for KPluralHandlingSpinbox. To get rid of this dependency multiple approaches are thinkable:

  • Move KPluralHandlingSpinbox down in tierness. It just depends on KI18n, but that rules out KWidgetAddons as a target
  • Don't use KPluralHandlingSpinbox by putting a label next to the spinbox
  • Drop the timeout settings. IMHO they are not very useful
  • Move the KCMs to kio-extras. IMO makes sense since the KCMs are more "desktop integration" than library functions. Would possibly allow to get rid of the dep to whatever will provide KCModule

Related Objects

dfaure added a subscriber: dfaure.Dec 1 2019, 9:26 PM

I like the idea of moving the KCMs to kio-extras. They are indeed extra functionality.

The timeout settings are probably useful in places with extra bad connection. Africa? But also 4G in a train, hehe, that happens to me (though akonadi wouldn't use those settings and doesn't have a similar setting AFAIK)...

nicolasfella added a comment.Dec 1 2019, 9:33 PM

Would such a move be possible in KF5? Technically it wouldn't be an API break, but it would break something for people that don't have kio-extras installed

dfaure added a comment.Dec 1 2019, 9:45 PM

In my opinion it could be done, yes. The common plasma use case (linux distro desktop) installs everything and the specialized setups probably don't need the KCM, or can install it. On the other hand there's a ton of stuff we can do before branching for KF6, so we could also wait until after the branching for the move. We can't really change KIO's dependencies before that anyway.

nicolasfella added a comment.Dec 3 2019, 8:20 PM

This would allow us to get rid of the KTextWidgets dependency immediately, so there would be a gain in doing it now

ervin moved this task from Needs Input to Backlog on the KF6 board.Mar 27 2021, 3:49 PM
ervin moved this task from Backlog to Waiting on KF6 Branching on the KF6 board.