fabiank (Fabian Kosmale)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Feb 27 2018, 2:16 PM (86 w, 1 d)
Availability
Available

Recent Activity

Sep 7 2019

fabiank committed R410:d7fcc9a0c79f: FcSolveSolver: cleanup ressources (authored by fabiank).
FcSolveSolver: cleanup ressources
Sep 7 2019, 6:49 PM
fabiank committed R410:6a13f0366cbc: FcSolveSolver: cleanup ressources (authored by fabiank).
FcSolveSolver: cleanup ressources
Sep 7 2019, 6:49 PM
fabiank closed D23570: FcSolveSolver: cleanup ressources.
Sep 7 2019, 6:49 PM
fabiank updated the diff for D23570: FcSolveSolver: cleanup ressources.

(include BUG line)

Sep 7 2019, 6:48 PM

Aug 29 2019

fabiank added reviewers for D23570: FcSolveSolver: cleanup ressources: shlomif, wbauer, aacid.

This is hopefully already a minimal fix for the crash issues, and it does not depend on Qt 5.12 features. @wbauer It would be most helpful if you could test whether the original bug is indeed no longer occurring after this patch.

Aug 29 2019, 4:38 PM
fabiank requested review of D23570: FcSolveSolver: cleanup ressources.
Aug 29 2019, 4:34 PM

Aug 28 2019

fabiank added a comment to D23404: Revamp solver memory management.

And this might have been the source of all problems (and adding it to the original code is probably sufficient, though I still think that the revamped memory management is a good idea): The FcSolveSolver did not call free, which left the MemoryManager in an unideal state, and would probably lead to (non-graciously handled) out-of-memory situations. This too should be fixed now.

Aug 28 2019, 7:55 PM
fabiank updated the diff for D23404: Revamp solver memory management.
  • add missing call to free in FcSolveSolver::patsolve
Aug 28 2019, 7:50 PM
fabiank added a comment to D23404: Revamp solver memory management.

The issue with the previous version was that the memory accounting code was wrong, and the allocation would fail at some point. The most recent version fixes this, and I could successfully complete a game of Grandfather's Clock again.

Aug 28 2019, 6:15 PM
fabiank updated the diff for D23404: Revamp solver memory management.
  • fix memory accounting
Aug 28 2019, 6:12 PM
fabiank added a comment to D23404: Revamp solver memory management.

Ah, I managed to reproduce the crash, and the interesting line of my backtrace is
#7 0x0000555a64cb306d in MemoryManager<19>::BLOCK<POSITION<19> >::getItem (this=0x0) at /home/fabian/projects/kpat/patsolve/memory.h:90

Aug 28 2019, 4:07 PM
fabiank added a comment to D23404: Revamp solver memory management.

Thank you very much for testing the patch. Could you maybe compile kpat with
cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address,leak,undefined' ..
and report back any backtrace you get from playing Grandfather's Clock? I again cannot reproduce the crash :-(

Aug 28 2019, 3:04 PM
fabiank committed R166:b1a56cdb5d24: PlatformXcb.cpp: Use custom deleter for xcb types (authored by fabiank).
PlatformXcb.cpp: Use custom deleter for xcb types
Aug 28 2019, 1:56 PM
fabiank committed R166:9d56e73df060: PlatformXcb.cpp: Use custom deleter for xcb types (authored by fabiank).
PlatformXcb.cpp: Use custom deleter for xcb types
Aug 28 2019, 1:56 PM
fabiank closed D23474: PlatformXcb.cpp: Use custom deleter for xcb types.
Aug 28 2019, 1:56 PM · Spectacle

Aug 27 2019

fabiank added reviewers for D23507: Replace custom single threaded merge sort with std::stable_sort: Dolphin, elvisangelaccio.

Using the new benchmark, we can see some improvement, mostly in the single threaded case:

Aug 27 2019, 7:53 PM · Dolphin
fabiank added reviewers for D23505: added sorting benchmark: Dolphin, elvisangelaccio.

The micro benchmark is rather simplistic, but I hope still better than nothing (and I want it to show that D23507 makes sense)

Aug 27 2019, 7:50 PM · Dolphin
fabiank requested review of D23507: Replace custom single threaded merge sort with std::stable_sort.
Aug 27 2019, 7:47 PM · Dolphin
fabiank requested review of D23505: added sorting benchmark.
Aug 27 2019, 7:46 PM · Dolphin

Aug 26 2019

fabiank added a reviewer for D23474: PlatformXcb.cpp: Use custom deleter for xcb types: Spectacle.
Aug 26 2019, 7:38 PM · Spectacle
fabiank requested review of D23474: PlatformXcb.cpp: Use custom deleter for xcb types.
Aug 26 2019, 7:35 PM · Spectacle

Aug 24 2019

fabiank added a comment to D23404: Revamp solver memory management.

The reflow in Phabricator's UI breks my ASCII diagrams, the git commit message should hopefully still be readable.

Aug 24 2019, 4:33 PM
fabiank added reviewers for D23404: Revamp solver memory management: aacid, shlomif.
Aug 24 2019, 4:31 PM
fabiank requested review of D23404: Revamp solver memory management.
Aug 24 2019, 4:29 PM

Oct 13 2018

fabiank committed R410:e09b5c7fba07: Add Shlomi Fish to the credits (authored by shlomif).
Add Shlomi Fish to the credits
Oct 13 2018, 4:03 PM
fabiank closed D13809: Add Shlomi Fish to the credits.
Oct 13 2018, 4:03 PM

Oct 12 2018

fabiank accepted D16121: Make sure the card we're trying to automove is the top of the pile.
Oct 12 2018, 9:11 AM

Oct 10 2018

fabiank accepted D13809: Add Shlomi Fish to the credits.
Oct 10 2018, 12:05 PM
fabiank added a comment to D15716: Suspicious use of signed arithmetic leads to negative index crash.

Unfortunately, there are no unit tests at all, as there is a rather tight coupling of UI code and game logic. The RNG could however be tested in isolation. Though I'm not sure how one could test whether it behaves the same as Microsoft ones.

Oct 10 2018, 9:35 AM
fabiank accepted D15716: Suspicious use of signed arithmetic leads to negative index crash.

Thanks for the patch. I can't reproduce the crash, but I agree with you that this is UB and should be fixed. I don't think that this changes how the RNG works, but even if it would, not crashing is more important.

Oct 10 2018, 6:36 AM

Sep 20 2018

fabiank accepted D15534: Reduce wasted space for Klondike and Grandfather.

Well, considering that it does look better now, and I'm not aware how to derive any better values, I'll say ship it. Do you have commit access?

Sep 20 2018, 5:58 PM
fabiank added a comment to D15534: Reduce wasted space for Klondike and Grandfather.

This does indeed look better, and I didn't saw issues at screen resolutions I could test.

Sep 20 2018, 6:38 AM

Aug 29 2018

fabiank added a comment to D13815: cleaned up MemoryManager code.

Yikes, your reply went victim of an overzealous spam filter rule, sorry for the late reply. Considering that there are a few outstanding bugs like bko 397817, I think I will delay merging this for a little longer. I think I probably should first attempt to write some integration/unit tests, to ensure that it really works.

Aug 29 2018, 1:34 PM

Jul 2 2018

fabiank added a comment to D13809: Add Shlomi Fish to the credits.

@aacid : Ouch, I wasn't aware of that, and hoped that phabricator would do the right thing. I know how to do this correctly using git, but I have no clue how I get arcanist to preserve the author. Could you point me to the appropriate documentation, so that this mistake doesn't happen again?

Jul 2 2018, 9:41 PM

Jun 30 2018

fabiank requested review of D13815: cleaned up MemoryManager code.
Jun 30 2018, 4:49 PM

Jun 28 2018

fabiank added a comment to R410:fc1d54ced6a7: Use Freecell Solver for FreeCell and Simple Simon.

Thanks for the heads-up Christoph, I'll look into the bug report. For reference, I'm simply “Fabian” on bko.

Jun 28 2018, 9:16 AM

Jun 6 2018

fabiank committed R410:59608c8ad21d: Apply Jonathan's suggested change, let's see if it still builds on BSD (authored by fabiank).
Apply Jonathan's suggested change, let's see if it still builds on BSD
Jun 6 2018, 2:27 PM

May 31 2018

fabiank added a comment to T8802: New dependency for kpat (required for CI).

Well, thanks everyone for adding the required libraries, and sorry @bcooksley for not giving notice in advance.

May 31 2018, 12:02 PM · build.kde.org

May 27 2018

fabiank added a comment to D11875: Revive the KLook patch for dolphin.

Oh my, I probably should have closed this. This was more intended to make testing https://phabricator.kde.org/D11844 possible, and the changes from there landed on KLook's qt5 branch. I deem the current Dolphin code not suited for upstream. KLook should probably changed so that it can be DBus activated and QProcess can be avoided, and applying this patch caused a few runtime warnings when using Dolphin if I recall correctly.

May 27 2018, 4:06 PM · Dolphin

May 23 2018

fabiank accepted D13057: Fix linking on FreeBSD.

I currently don't have any *BSD to test, but it still works on Linux, and the change seems sensible, so +2.

May 23 2018, 5:35 PM

May 22 2018

fabiank created T8802: New dependency for kpat (required for CI).
May 22 2018, 7:47 PM · build.kde.org
fabiank added a comment to D12415: Use Freecell Solver for FreeCell and Simple Simon.

Sigh, could have thought of this. Yeah, I'll open a ticket.

May 22 2018, 7:37 PM · KDE Games
fabiank committed R410:fc1d54ced6a7: Use Freecell Solver for FreeCell and Simple Simon (authored by fabiank).
Use Freecell Solver for FreeCell and Simple Simon
May 22 2018, 6:50 PM
fabiank committed R410:ed0e53e0888d: Use Freecell Solver for FreeCell and Simple Simon (authored by fabiank).
Use Freecell Solver for FreeCell and Simple Simon
May 22 2018, 6:50 PM
fabiank closed D12415: Use Freecell Solver for FreeCell and Simple Simon.
May 22 2018, 6:50 PM · KDE Games
fabiank accepted D12415: Use Freecell Solver for FreeCell and Simple Simon.
May 22 2018, 6:50 PM · KDE Games
fabiank added a comment to D12415: Use Freecell Solver for FreeCell and Simple Simon.

Oh well, time to get this merged. I didn't get *too* strong objection from the mailing list, so I intend to merge this as is. Thank you very much @shlomif for your patience and your code contribution.

May 22 2018, 6:49 PM · KDE Games

May 16 2018

fabiank committed R302:419e7ab659c1: Check if group < LastGroup, as KIconEffect doesn't handle UserGroup anyway (authored by fabiank).
Check if group < LastGroup, as KIconEffect doesn't handle UserGroup anyway
May 16 2018, 5:14 PM
fabiank committed R302:49f871844632: Check if group < LastGroup, as KIconEffect doesn't handle UserGroup anyway (authored by fabiank).
Check if group < LastGroup, as KIconEffect doesn't handle UserGroup anyway
May 16 2018, 5:14 PM
fabiank closed D12002: Check if group < LastGroup, as KIconEffect doesn't handle UserGroup anyway.
May 16 2018, 5:14 PM · Frameworks
fabiank added a comment to D12415: Use Freecell Solver for FreeCell and Simple Simon.

Yeah, sure, I'll send the mail.

May 16 2018, 5:10 PM · KDE Games

May 14 2018

fabiank added a comment to D12415: Use Freecell Solver for FreeCell and Simple Simon.

Sorry, I technically reviewed it already, but forgot to hit submit :-(. I'm happy with the current state of the code (sans that one copyright line), and the solver does a better job than the current one.

May 14 2018, 9:14 AM · KDE Games

Apr 23 2018

fabiank added a comment to D12415: Use Freecell Solver for FreeCell and Simple Simon.

Considering that currently no one (including me, the de-facto maintainer) really knows what the solver is doing exactly and how the numbers for the search in it were derived, I appreciate outsourcing the logic to a library. However, like @aacid said, it would be nice to have either some numbers how the solver compares.

Apr 23 2018, 9:22 PM · KDE Games

Apr 8 2018

fabiank committed R318:3a028d9db0ee: use the same bound check as setCurrentItem when setting m_currentItem manually (authored by fabiank).
use the same bound check as setCurrentItem when setting m_currentItem manually
Apr 8 2018, 9:44 AM
fabiank closed D11990: use the same bound check as setCurrentItem when setting m_currentItem manually.
Apr 8 2018, 9:44 AM
fabiank added a comment to D11990: use the same bound check as setCurrentItem when setting m_currentItem manually.

Yes, I have commit access. This should (arc) land in master?

Apr 8 2018, 9:41 AM

Apr 7 2018

fabiank committed R241:d7a6ee3d73e7: Ensure that the model is set when resetResizing is called (authored by fabiank).
Ensure that the model is set when resetResizing is called
Apr 7 2018, 10:35 AM
fabiank committed R241:bff960d67162: Ensure that the model is set when resetResizing is called (authored by fabiank).
Ensure that the model is set when resetResizing is called
Apr 7 2018, 10:35 AM
fabiank closed D11998: Ensure that the model is set when resetResizing is called.
Apr 7 2018, 10:35 AM · Frameworks

Apr 6 2018

fabiank added a comment to D11993: Tweak column widths in tree view of file open/save dialogs.

I'm to tired to test this myself, but could you please test this with the edge case where some file names are so long that they don't fit in the view? Also, Stretch disables manual resizing, right?' If that is also deemed useful, we could adapt the solution from https://centaurialpha.github.io/resize-qheaderview-to-contents-and-interactive. That's pyqt, but the same idea applies to C++. The resize event handling code is even already there, just needs to be adjusted.

Apr 6 2018, 11:38 PM · Frameworks
fabiank added reviewers for D12002: Check if group < LastGroup, as KIconEffect doesn't handle UserGroup anyway: mart, dfaure, mlaurent.
Apr 6 2018, 11:28 PM · Frameworks
fabiank committed R223:b25979121fd3: use correct filepath (authored by fabiank).
use correct filepath
Apr 6 2018, 11:16 PM
fabiank committed R223:f8f7a77fedc0: use correct filepath (authored by fabiank).
use correct filepath
Apr 6 2018, 11:16 PM
fabiank closed D12001: use correct filepath.
Apr 6 2018, 11:16 PM · Okular
fabiank requested review of D12002: Check if group < LastGroup, as KIconEffect doesn't handle UserGroup anyway.
Apr 6 2018, 11:15 PM · Frameworks
fabiank added reviewers for D12001: use correct filepath: Okular, hetzenecker.
Apr 6 2018, 10:48 PM · Okular
fabiank requested review of D12001: use correct filepath.
Apr 6 2018, 10:47 PM · Okular
fabiank added a reviewer for D11998: Ensure that the model is set when resetResizing is called: dfaure.
Apr 6 2018, 9:06 PM · Frameworks
fabiank requested review of D11998: Ensure that the model is set when resetResizing is called.
Apr 6 2018, 9:05 PM · Frameworks
fabiank added a reviewer for D11990: use the same bound check as setCurrentItem when setting m_currentItem manually: Dolphin.
Apr 6 2018, 7:31 PM
fabiank added a reviewer for D11990: use the same bound check as setCurrentItem when setting m_currentItem manually: elvisangelaccio.
Apr 6 2018, 4:11 PM
fabiank requested review of D11990: use the same bound check as setCurrentItem when setting m_currentItem manually.
Apr 6 2018, 4:10 PM

Apr 3 2018

ngraham awarded D11844: RFC: An initial, lazy port of KLook towards Qt5 a Party Time token.
Apr 3 2018, 3:41 PM
fabiank committed R604:5e4eb694ac07: remove old connect (authored by fabiank).
remove old connect
Apr 3 2018, 2:34 PM
fabiank committed R604:5ddcf1982746: support directories again (authored by fabiank).
support directories again
Apr 3 2018, 2:34 PM
fabiank committed R604:146aca8e3d31: directly conect to mimetype signal, which appears to be emitted significantly… (authored by fabiank).
directly conect to mimetype signal, which appears to be emitted significantly…
Apr 3 2018, 2:34 PM
fabiank committed R604:a249ecec2352: do not depend on phonon to detect if we support a video format (authored by fabiank).
do not depend on phonon to detect if we support a video format
Apr 3 2018, 2:34 PM
fabiank committed R604:57fe8de051a9: Text preview allows scrolling again (authored by fabiank).
Text preview allows scrolling again
Apr 3 2018, 2:34 PM
fabiank committed R604:3ba4fa7e5df5: video preview resizes correctly now (for some reason videos take very long to… (authored by fabiank).
video preview resizes correctly now (for some reason videos take very long to…
Apr 3 2018, 2:34 PM
fabiank committed R604:5ec596c8d771: fix initial image selection (authored by fabiank).
fix initial image selection
Apr 3 2018, 2:34 PM
fabiank committed R604:e0904678265a: start porting away for KDE4LibsSupport to ease fixing some bugs (authored by fabiank).
start porting away for KDE4LibsSupport to ease fixing some bugs
Apr 3 2018, 2:34 PM
fabiank committed R604:eb876c0c3b63: updated dolphin patch again (authored by fabiank).
updated dolphin patch again
Apr 3 2018, 2:34 PM
fabiank committed R604:cb8e565a631c: dolphin patch applies again against dolphin master… (authored by fabiank).
dolphin patch applies again against dolphin master…
Apr 3 2018, 2:34 PM
fabiank committed R604:ff9fa3009f8b: reduce CMake version requirement (authored by fabiank).
reduce CMake version requirement
Apr 3 2018, 2:34 PM
fabiank committed R604:46a580884a34: split monolithic dolphin patch, currently doe only partially apply (authored by fabiank).
split monolithic dolphin patch, currently doe only partially apply
Apr 3 2018, 2:34 PM
fabiank committed R604:87f7fd353fe8: add .arcconfig file (authored by fabiank).
add .arcconfig file
Apr 3 2018, 2:34 PM
fabiank committed R604:1009306c43f6: actually show application (authored by fabiank).
actually show application
Apr 3 2018, 2:34 PM
fabiank committed R604:633e08d45f34: some work on porting video to QtMultiMedia (authored by fabiank).
some work on porting video to QtMultiMedia
Apr 3 2018, 2:34 PM
fabiank committed R604:f37f390b61df: make text preview usable again (authored by fabiank).
make text preview usable again
Apr 3 2018, 2:34 PM
fabiank committed R604:c05688c67558: qml fixes (authored by fabiank).
qml fixes
Apr 3 2018, 2:34 PM
fabiank committed R604:840809622970: Initial porting to Qt5/KDE Frameworks, only compiles, doesn't work (authored by fabiank).
Initial porting to Qt5/KDE Frameworks, only compiles, doesn't work
Apr 3 2018, 2:34 PM
fabiank closed D11844: RFC: An initial, lazy port of KLook towards Qt5.
Apr 3 2018, 2:34 PM
fabiank updated the diff for D11844: RFC: An initial, lazy port of KLook towards Qt5.
  • remove old connect
  • support directories again
Apr 3 2018, 2:33 PM

Apr 2 2018

fabiank added a comment to D11844: RFC: An initial, lazy port of KLook towards Qt5.
  • TODO: new mimetype detection breaks the directory case, as it is considered an error (though we still get inode/directory as the result). Add special detection for dirs.
Apr 2 2018, 10:04 PM
fabiank updated the diff for D11844: RFC: An initial, lazy port of KLook towards Qt5.
  • do not depend on phonon to detect if we support a video format
  • directly conect to mimetype signal, which appears to be emitted significantly earlier than result
Apr 2 2018, 9:41 PM
fabiank updated the diff for D11844: RFC: An initial, lazy port of KLook towards Qt5.
  • video preview resizes correctly now (for some reason videos take very long to play though)
Apr 2 2018, 6:17 PM
fabiank updated the diff for D11844: RFC: An initial, lazy port of KLook towards Qt5.
  • Text preview allows scrolling again
Apr 2 2018, 4:17 PM
fabiank updated subscribers of D11844: RFC: An initial, lazy port of KLook towards Qt5.

@bcooksley Would it be possible to set up a project page for KLook? Having all the todos as actionable tasks in a Workboard and being able to prioritize them would be more helpful than having half of them as a list in a text document, and the other half merely existing in my head. Also, when @ngraham decides to list all the usability and design improvements that are needed (which isn't really my area of expertise), he could put them there, too.

Apr 2 2018, 3:23 PM
fabiank updated the diff for D11844: RFC: An initial, lazy port of KLook towards Qt5.
  • fix initial image selection
Apr 2 2018, 2:26 PM
fabiank updated the diff for D11844: RFC: An initial, lazy port of KLook towards Qt5.
  • start porting away for KDE4LibsSupport to ease fixing some bugs
Apr 2 2018, 12:32 PM