- User Since
- May 8 2020, 9:39 AM (19 w, 6 d)
May 15 2020
I had another thought on it and think having all the functionality for both cases in one class is probably a bit too big and both use cases are actually too different. The common part that can be shared between both cases is the selectable rectangle + the magnifier. I think all other functionality / logic should go into QuickEditor and KSImageWidget respectively. I am wondering if that is an option, i.e. refactor a selection primitive to select a rectangular area (possibly implemented as QGraphicsObject). I assume that's what you need as well, right? i.e. you want a rectangular selection rather than a region? We could make this new selection class customizable with an isValidSelection hook / lambda so that in your case you can reject selections that are invalid. (correct me if you need something different, I am still not 100% sure if I understood your problem right, if you have a screenshot of a distorted / problematic screen that would be great!)
May 13 2020
Do you see fundamental problems combining both patches? e.g. in the KSImageWidget the mScreenRegion could simply be a single rectangle of the size of the screenshot pixmap?
May 11 2020
- Fix KSImageWidget cursor when there is no selection
- Send out a selectionChanged event when selection is cleared
Yes thats correct. That makes it possible to save multiple different selections from the same screenshot... Maybe I should make it more clear that only the selection is saved, or is that clear? However, when dragging the selection only the selected part is visible in the drag image.
There should be a 'Select' button on the right side of the window (see below). Once you click it you can start a selection. During the time of the first selection the button is disabled. Happy to get feedback for the button location, label or better position.