It works! Very nice. I'll let other folks do the code review, but I have one behavioral request: could this feature be implemented for Icons view as well? Right now it only appears to work in Compact and Details views. Or would that be too thorny?

Also, if you make the up and down arrow keys do the same when in Compact and Details views, it'll also fix https://bugs.kde.org/show_bug.cgi?id=269987.

but I have one behavioral request: could this feature be implemented for Icons view as well? Right now it only appears to work in Compact and Details views.

It works for me in all 3 views. Renaming last element and pressing tab doesn't go to first element. Maybe that was a case for you in Icons view?

Also, if you make the up and down arrow keys do the same when in Compact and Details views, it'll also fix https://bugs.kde.org/show_bug.cgi?id=269987.

This one is a little bit more tricky because KItemListRoleEditor needs information about view type but is doable.

Copy of talking points that I see from summary:

• name of EditResult structure, declaration place, exporting of EditResult stucture
• maybe better solution is DolphinView listening to KItemListRoleEditor keys. This way implementation of bug 269987 would be simple and everything would be in better place?

what does it means? is it done already?

@msciubidlo See https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages

Sorry for the delay, I'll try to have a look at the patch in the next days.

Thanks for the patch. I like the feature but there is something missing: if the next file is out of the visible view, the view doesn't scroll and the rename operation gets canceled.

I will try to modify it to show next element and continue renaming if possible.

Even worse, in details view mode it actually tries to rename the invisible file by rendering it above the view header.

That behaviour is currently present in Dolphin. This patch doesn't introduce it or tries to change it.

Ping! Any word on making the requested changes?

@msciubidlo Ping!

In D20427#453547, @elvisangelaccio wrote:

Thanks for the patch. I like the feature but there is something missing: if the next file is out of the visible view, the view doesn't scroll and the rename operation gets canceled.

I tried a simple thing with adding:

m_view->scrollToItem(index)

It scrolls the view to the next item, but renaming gets disabled.
Looks like it's something 'bigger'. Choose any file, hit F2, scroll up or down (with mouse wheel, so you don't click on anything else), renaming stops.
I hopped over to Windows to check how it works there - same thing, as soon as you scroll while renaming is active, the renaming stops.

This is a nice patch with just a few rough edges to polish.
I encourage @msciubidlo to have a look again.

@msciubidlo if you don't have the time anymore, would you be okay with someone else taking over the patch and finishing it off?

would you be okay with someone else taking over the patch and finishing it off?

Yes!

Wanna do the honors, @meven? :)

up

@elvisangelaccio what do you think we should do with this old but very nice 95% completed patch?