svuorela (Sune Vuorela)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Sep 4 2015, 8:08 PM (170 w, 4 d)
Availability
Available

Recent Activity

Mon, Nov 26

svuorela updated subscribers of D17152: Hide the badge if number too big.

Let's try poke @mlaurent and see if he has any comments.

Mon, Nov 26, 8:33 PM · Plasma
svuorela added a comment to D17152: Hide the badge if number too big.

What I'm saying is that I think it makes more sense to communicate your preferred email workflow to KMail rather then to Plasma. I'm open to being convinced out of this point of view, of course. :)

Mon, Nov 26, 7:57 PM · Plasma
svuorela added a comment to D17152: Hide the badge if number too big.
Mon, Nov 26, 7:47 PM · Plasma
svuorela added a comment to D17152: Hide the badge if number too big.

So i like second one, it can still be fixed to 10K+ because it does not matter above.

Mon, Nov 26, 7:32 PM · Plasma
svuorela added a comment to D17152: Hide the badge if number too big.

I'll try with + for a couple of days.

Mon, Nov 26, 5:38 PM · Plasma
svuorela added a comment to D17152: Hide the badge if number too big.

@ngraham I use kmail ... but I have hundreds of thousands unread emails without counting my spam folders. (commit lists, bug lists, ...)

Mon, Nov 26, 5:33 PM · Plasma

Sun, Nov 25

svuorela added a comment to D17152: Hide the badge if number too big.

@ngraham It might be that many notifications != no notifications in some cases, but at least in the case of emails, with many unread emails basically doesn't make a difference.

Sun, Nov 25, 6:00 PM · Plasma
svuorela requested review of D17152: Hide the badge if number too big.
Sun, Nov 25, 11:16 AM · Plasma

Nov 2 2018

svuorela accepted D16561: Remove unused variable.
Nov 2 2018, 6:43 AM · Frameworks
svuorela accepted D16567: Remove unused variable.
Nov 2 2018, 6:43 AM · Baloo, Frameworks
svuorela accepted D16568: Remove unused variables.
Nov 2 2018, 6:42 AM · Frameworks
svuorela accepted D16569: Remove unused variable.
Nov 2 2018, 6:42 AM · Frameworks
svuorela accepted D16571: Remove unused variable.
Nov 2 2018, 6:41 AM · Frameworks
svuorela accepted D16572: don't assign variable to itself.
Nov 2 2018, 6:41 AM · Frameworks
svuorela accepted D16573: Remove unused variables.
Nov 2 2018, 6:41 AM · Frameworks
svuorela accepted D16574: Remove unused variable.
Nov 2 2018, 6:40 AM · Frameworks
svuorela accepted D16565: Remove unused variable.
Nov 2 2018, 6:38 AM · Frameworks

Oct 28 2018

svuorela accepted D16476: Rewrite the PhoneNumber find module to be component-based.
Oct 28 2018, 10:54 AM
svuorela accepted D16348: Properly look for the libphonenumber dependency.
Oct 28 2018, 10:53 AM

Oct 21 2018

svuorela requested changes to D16348: Properly look for the libphonenumber dependency.

Very much an improvement. But we need a license file.

Oct 21 2018, 9:57 AM

Oct 14 2018

svuorela added a comment to D16137: Add an option to KConfigDialog to fit page contents horizontally.

Did you imagine something like what I changed in D16137#343060 (the latest change) ?

Oct 14 2018, 7:45 PM · Frameworks
svuorela added a comment to D16137: Add an option to KConfigDialog to fit page contents horizontally.

from a source & binary compatibility point of view, this looks great.

Oct 14 2018, 12:45 PM · Frameworks

Sep 29 2018

svuorela added a comment to D15833: extend test coverage to all supported mimetypes for taglibextractor.

What's the origin/license of these files ? How are they created ?

Sep 29 2018, 6:01 PM · Baloo, Frameworks

Sep 23 2018

svuorela added inline comments to D15714: add a string suffix to test data and use for unicode testing of taglibwriter.
Sep 23 2018, 7:25 PM · Baloo, Frameworks
svuorela added a comment to D15715: remove own implementation of QString to TString conversion for taglibwriter.

since I'm still unsure about those things: the q2t function was not declared static, but was never exported. It is still safe to remove, right?

Sep 23 2018, 7:23 PM · Baloo, Frameworks
svuorela added inline comments to D15714: add a string suffix to test data and use for unicode testing of taglibwriter.
Sep 23 2018, 6:56 PM · Baloo, Frameworks
svuorela added inline comments to D15714: add a string suffix to test data and use for unicode testing of taglibwriter.
Sep 23 2018, 5:52 PM · Baloo, Frameworks
svuorela added a comment to D15704: increase test coverage of taglibwriter.

Looks good to me. A nice and simple way to drastically increase test coverage.

Sep 23 2018, 5:49 PM · Baloo, Frameworks

Sep 22 2018

svuorela accepted D15615: bump required taglib version to 1.11.1.
Sep 22 2018, 8:44 PM · Baloo, Frameworks
svuorela accepted D15614: remove usage of own TString to QString conversion function.
Sep 22 2018, 8:43 PM · Baloo, Frameworks
svuorela added a comment to D15426: Avoid QByteArray::remove in AccessManagerReply::readData.

@fvogt mostly a unit test that ensures that all these 3 codepaths in slotData works. I'm not sure that the current unit tests ensures that. I might be wrong though.

Sep 22 2018, 4:35 PM · Frameworks
svuorela accepted D15426: Avoid QByteArray::remove in AccessManagerReply::readData.

Though unit tests would be nice. It looks like something that quite easy could break if next author is not careful.

Sep 22 2018, 4:19 PM · Frameworks

Sep 15 2018

svuorela accepted D15526: Fix rendering glitches caused by rounding errors in Code 128.
Sep 15 2018, 8:35 PM · Frameworks
svuorela accepted D15527: Remove assumption about the barcode aspect ratio from the QML integration.
Sep 15 2018, 8:35 PM · Frameworks

Sep 14 2018

svuorela accepted D15511: Add support for Code 128 barcodes.
Sep 14 2018, 5:42 PM · Frameworks
svuorela added inline comments to D15511: Add support for Code 128 barcodes.
Sep 14 2018, 5:30 PM · Frameworks

Sep 9 2018

svuorela added a comment to D15364: Plasma style: Remove hardcoded textFormat.

I think it is undesireable to change the default, because all users are now used to having it PlainText, so they are now dumping things-that-looks-like-html into it and expecting it to be plaintext.

Sep 9 2018, 7:16 AM · Frameworks

Aug 30 2018

svuorela added a comment to D15173: Add a new ISO 3166 code to country name mapping table.

Looks good to me. I haven't tested that the tool and the generated output matches, but I trust volker in that.

Aug 30 2018, 6:53 PM · KDE PIM

Aug 20 2018

svuorela closed D14953: registering QList<int> is not needed since forever.
Aug 20 2018, 7:05 PM · KDE PIM
svuorela committed R92:398265234410: registering QList<int> is not needed since forever (authored by svuorela).
registering QList<int> is not needed since forever
Aug 20 2018, 7:05 PM
svuorela added reviewers for D14953: registering QList<int> is not needed since forever: mlaurent, smartins, cgiboudeaux, rikmills.
Aug 20 2018, 4:40 PM · KDE PIM
svuorela requested review of D14953: registering QList<int> is not needed since forever.
Aug 20 2018, 4:38 PM · KDE PIM

Aug 19 2018

svuorela committed R87:9113d2aec762: Optional argument never provided. Cleanup. (authored by svuorela).
Optional argument never provided. Cleanup.
Aug 19 2018, 5:24 PM
svuorela committed R87:31283b16d616: Add a couple of alternative keys (authored by svuorela).
Add a couple of alternative keys
Aug 19 2018, 5:24 PM
svuorela committed R87:515d2a7e8da5: Add a backup start/end time, and don't use strings as transport for some dates (authored by svuorela).
Add a backup start/end time, and don't use strings as transport for some dates
Aug 19 2018, 5:24 PM
svuorela committed R87:512378c71cd7: Fix porting bug. fromSecsSinceEpoch is a static method (authored by svuorela).
Fix porting bug. fromSecsSinceEpoch is a static method
Aug 19 2018, 5:24 PM
svuorela committed R87:865c3a237cf0: Fix Allow already open devices for parsing devices (authored by svuorela).
Fix Allow already open devices for parsing devices
Aug 19 2018, 5:24 PM
svuorela committed R87:f336fcf04b54: Let QDateTime convert to local time (authored by svuorela).
Let QDateTime convert to local time
Aug 19 2018, 5:24 PM
svuorela committed R87:7be57c4f3025: Optional argument never provided. Cleanup. (authored by svuorela).
Optional argument never provided. Cleanup.
Aug 19 2018, 5:24 PM
svuorela closed D14885: Optional argument never provided. Cleanup..
Aug 19 2018, 5:24 PM · KDE PIM

Aug 17 2018

svuorela added a comment to D14529: Android: Make sure Qm translations get loaded.

Ok, second option, we are actually installing these files ourselves, right?

Aug 17 2018, 10:10 AM · Build System, Frameworks
svuorela accepted D14896: Fix bzip main page.

yesplease.

Aug 17 2018, 8:53 AM · Frameworks
svuorela added a comment to D14885: Optional argument never provided. Cleanup..

+2 for me too
but "Add a couple of alternative keys" where do you find theses infos ?
Could you add it in a readme for example ?

Aug 17 2018, 8:23 AM · KDE PIM

Aug 16 2018

svuorela requested review of D14885: Optional argument never provided. Cleanup..
Aug 16 2018, 3:55 PM · KDE PIM

Aug 15 2018

svuorela committed R95:1870fa5d9275: It shouldn't be needed to Q_DECLARE_METATYPE with QList<int> any longer (authored by svuorela).
It shouldn't be needed to Q_DECLARE_METATYPE with QList<int> any longer
Aug 15 2018, 9:02 AM
svuorela closed D14832: It shouldn't be needed to Q_DECLARE_METATYPE with QList<int> any longer.
Aug 15 2018, 9:02 AM · KDE PIM
svuorela added a comment to D14832: It shouldn't be needed to Q_DECLARE_METATYPE with QList<int> any longer.

+2 assuming this isn't still included by any depending modules

Aug 15 2018, 8:36 AM · KDE PIM

Aug 14 2018

svuorela requested review of D14832: It shouldn't be needed to Q_DECLARE_METATYPE with QList<int> any longer.
Aug 14 2018, 1:28 PM · KDE PIM
svuorela committed R1003:7aef658c4c30: Add QRCode decode support. (authored by svuorela).
Add QRCode decode support.
Aug 14 2018, 7:04 AM
svuorela closed D14797: Add QRCode decode support..
Aug 14 2018, 7:04 AM · KDE PIM

Aug 13 2018

svuorela requested review of D14798: Scope the glib hack to older Qt versions.
Aug 13 2018, 4:24 PM · Konsole
svuorela requested review of D14797: Add QRCode decode support..
Aug 13 2018, 3:50 PM · KDE PIM
svuorela committed R276:f5fef035e5a2: Deprecate KFilterProxySearchLine (authored by svuorela).
Deprecate KFilterProxySearchLine
Aug 13 2018, 11:18 AM
svuorela closed D14772: Deprecate KFilterProxySearchLine.
Aug 13 2018, 11:17 AM · Frameworks
svuorela updated the diff for D14772: Deprecate KFilterProxySearchLine.

Improve deprecation documentation

Aug 13 2018, 11:08 AM · Frameworks
svuorela committed R338:7678d92ebcc6: Add arcconfig file (authored by svuorela).
Add arcconfig file
Aug 13 2018, 7:53 AM
svuorela closed D14768: Add arcconfig file.
Aug 13 2018, 7:53 AM · KDE Edu
svuorela committed R338:e56fdadad975: phonon is actually required. mark it as such. (authored by svuorela).
phonon is actually required. mark it as such.
Aug 13 2018, 7:52 AM
svuorela closed D14767: phonon is actually required. mark it as such..
Aug 13 2018, 7:52 AM · KDE Edu

Aug 12 2018

svuorela requested review of D14772: Deprecate KFilterProxySearchLine.
Aug 12 2018, 3:20 PM · Frameworks
svuorela added reviewers for D14768: Add arcconfig file: ltoscano, mlaurent.
Aug 12 2018, 1:43 PM · KDE Edu
svuorela requested review of D14768: Add arcconfig file.
Aug 12 2018, 1:22 PM · KDE Edu
svuorela requested review of D14767: phonon is actually required. mark it as such..
Aug 12 2018, 1:20 PM · KDE Edu

Aug 3 2018

svuorela committed R244:ea2779611800: Fix overflow in rounding code (authored by svuorela).
Fix overflow in rounding code
Aug 3 2018, 4:01 PM
svuorela closed D14565: Fix overflow in rounding code.
Aug 3 2018, 4:01 PM · Frameworks
svuorela added a comment to D14565: Fix overflow in rounding code.

Maybe you should use largeValue instead of largevalue.

Yes, that would be consistent with what we do elsewhere.

Aug 3 2018, 3:44 PM · Frameworks
svuorela updated the diff for D14565: Fix overflow in rounding code.

s/largevalue/largeValue/

Aug 3 2018, 3:43 PM · Frameworks

Aug 2 2018

svuorela requested review of D14565: Fix overflow in rounding code.
Aug 2 2018, 8:12 PM · Frameworks
svuorela added inline comments to D14563: Add CLDR-based country to ISO code mapping.
Aug 2 2018, 7:39 PM · KDE PIM
svuorela added inline comments to D14563: Add CLDR-based country to ISO code mapping.
Aug 2 2018, 7:23 PM · KDE PIM
svuorela accepted D14400: Fix Mixed to Upper mode latching in Aztec code generation.
Aug 2 2018, 7:13 PM · Frameworks

Jun 17 2018

svuorela added a comment to T8855: Rework country name <-> ISO code mapping KContacts.

After reading my kcontacts code, the file and the file generated from countrieslistcldr.git's generate app, besides the fact that the file is 10 times bigger because 10 times as much data, there might be an issue that in the "original" file, it seems to be english first, then other languages, for each country. I haven't reproduced that part of it.

Jun 17 2018, 8:35 PM · KDE Itinerary
svuorela accepted D13545: Fix build with Qt 5.11.0_beta3 (no more qt5_use_modules).
Jun 17 2018, 7:15 PM
svuorela requested changes to D13546: Raise to KF5 >= 5.37 and drop Boost fallback.

Note that I'm not a maintainer, so feel free to ignore.

Jun 17 2018, 7:15 PM

May 25 2018

svuorela committed R1003:80fdc6ff26b9: handle reciepts from sas (authored by svuorela).
handle reciepts from sas
May 25 2018, 7:04 PM
svuorela closed D13121: handle reciepts from sas.
May 25 2018, 7:04 PM · KDE PIM
svuorela requested review of D13121: handle reciepts from sas.
May 25 2018, 6:56 PM · KDE PIM

May 24 2018

svuorela added a comment to T8864: Consider transformation matrix when extracting PDF images.
  • a/src/extractorengine.cpp

+++ b/src/extractorengine.cpp
@@ -145,7 +145,11 @@ QString BarcodeJsApi::decodePdf417(const QVariant &img) const

      tf.rotate(-90);
     image = image.transformed(tf);
}
  • return BarcodeDecoder::decodePdf417(image);

+ QString value = BarcodeDecoder::decodePdf417(image);
+ if (!value.isEmpty()) {
+ return value;
+ }
+ return BarcodeDecoder::decodePdf417(image.mirrored(false,true));

}
return {};

}

May 24 2018, 6:55 PM · KDE Itinerary

May 22 2018

svuorela committed R1003:fb9577d5e9bb: Communicate better if no tests are found in test dir (authored by svuorela).
Communicate better if no tests are found in test dir
May 22 2018, 5:27 AM
svuorela committed R1003:8333538b46d9: Initial work on some sas boarding passes (authored by svuorela).
Initial work on some sas boarding passes
May 22 2018, 5:26 AM
svuorela closed D13025: Initial work on some sas boarding passes.
May 22 2018, 5:26 AM · KDE PIM

May 21 2018

svuorela requested review of D13025: Initial work on some sas boarding passes.
May 21 2018, 7:27 PM · KDE PIM
svuorela committed R1003:5c70204a2a92: Provide a way to rotate images 90 degrees before passing them on to barcode… (authored by svuorela).
Provide a way to rotate images 90 degrees before passing them on to barcode…
May 21 2018, 6:36 PM
svuorela closed D13017: Provide a way to rotate images 90 degrees before passing them on to barcode decoder.
May 21 2018, 6:36 PM · KDE PIM
svuorela updated the diff for D13017: Provide a way to rotate images 90 degrees before passing them on to barcode decoder.

Check width/height for rotating rather than having the user do it.

May 21 2018, 1:54 PM · KDE PIM
svuorela requested review of D13017: Provide a way to rotate images 90 degrees before passing them on to barcode decoder.
May 21 2018, 1:07 PM · KDE PIM

May 20 2018

svuorela requested review of D12994: Provide access to actions in part.
May 20 2018, 11:39 AM

May 11 2018

svuorela requested review of D12828: blueprints for kookbook.
May 11 2018, 3:18 PM
svuorela abandoned D12764: Inital work on discount markdown library.

duplicate.

May 11 2018, 9:45 AM
svuorela committed R877:540905a4f94b: Inital work on discount markdown library (authored by svuorela).
Inital work on discount markdown library
May 11 2018, 9:44 AM