svuorela (Sune Vuorela)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Sep 4 2015, 8:08 PM (263 w, 1 d)
Availability
Available

Recent Activity

May 14 2020

svuorela added a comment to D29747: Deprecate AbstractBarcode::minimumSize() also for the compiler.

I think we should wait a bit with formally deprecating. I like add the new, wait a bit, then deprecate.

May 14 2020, 6:09 PM · Frameworks

May 10 2020

svuorela accepted D28760: KSettings::Dialog: avoid duplicate entries due cascading $XDG_DATA_DIRS.
May 10 2020, 7:03 PM · Frameworks

May 3 2020

svuorela added a comment to D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun.

I've been looking at it for a while, and after trying to decipher the long lambdas, which might have been better as named functions, I think it is, beside Kossebau's comments, fine.

May 3 2020, 5:46 PM · Frameworks

Apr 24 2020

svuorela accepted D28765: KSettings::Dialog: add support for KPluginInfos without a KService.
Apr 24 2020, 6:07 PM · Frameworks

Apr 12 2020

svuorela accepted D28768: Sort bencoded dictionary in extension protocol handshake.

Though maybe give the maintainer a day or two to react as well.

Apr 12 2020, 8:07 AM

Mar 14 2020

svuorela accepted D28030: Also expose the true minimum size to QML.
Mar 14 2020, 10:09 AM · Frameworks

Mar 11 2020

svuorela accepted D27952: Simplify minimum size handling.
Mar 11 2020, 6:48 PM · Frameworks
svuorela accepted D27989: Add a new set of barcode size functions.
Mar 11 2020, 6:48 PM · Frameworks

Mar 8 2020

svuorela accepted D27909: Move barcode image scaling logic to AbstractBarcode.
Mar 8 2020, 4:26 PM · Frameworks

Mar 6 2020

svuorela accepted D27730: Add API to check whether a barcode is one- or two-dimensional.

thanks.

Mar 6 2020, 6:30 PM · Frameworks

Mar 4 2020

svuorela added a comment to D26340: touch: Remove deprecated ApplicationHeader.

@z3ntu - do you have push access to push this?

Mar 4 2020, 6:42 PM
svuorela accepted D27727: Remove empty/unused private classes on internal types.

These are leftovers from when all constructor was public.

Mar 4 2020, 6:37 PM · Frameworks
svuorela requested changes to D27730: Add API to check whether a barcode is one- or two-dimensional.

I'm not sure I like the implementation. The current AbstractBarcode can also be implemented, at least theoretically, by software providing other barcodes that forever reason isn't available here. I have at least done that for some PoC ports of other things.

Mar 4 2020, 6:37 PM · Frameworks

Feb 17 2020

svuorela accepted D26353: touch: bug fixes and general improvements.
Feb 17 2020, 7:30 PM

Jan 5 2020

svuorela requested changes to D26353: touch: bug fixes and general improvements.
Jan 5 2020, 3:51 PM

Jan 1 2020

svuorela accepted D26353: touch: bug fixes and general improvements.
Jan 1 2020, 7:57 PM
svuorela accepted D26315: Add basic Android support.

Regarding discount. I think the bettetr path moving forward is to port to newer Qt that has markdown handling stuff in QTextDocument

Jan 1 2020, 2:16 PM
svuorela accepted D26340: touch: Remove deprecated ApplicationHeader.
Jan 1 2020, 2:12 PM

Nov 2 2019

svuorela added a comment to D23866: Port from KHTML to QtWebEngine.

Ping ? What is the status ?:)

Nov 2 2019, 12:36 PM · Documentation

Oct 27 2019

svuorela committed R280:66d9d627a79a: Fix memory handling in datamatrix (authored by svuorela).
Fix memory handling in datamatrix
Oct 27 2019, 4:37 PM

Oct 15 2019

svuorela accepted D24447: Fix compatibility of build_theme.sh with Dash.
Oct 15 2019, 6:48 PM · Plasma

Sep 21 2019

svuorela added a comment to D23866: Port from KHTML to QtWebEngine.

So what is the status of this patch ?

Sep 21 2019, 6:49 PM · Documentation

Sep 11 2019

svuorela added a comment to D23866: Port from KHTML to QtWebEngine.

Thanks, you have been fast. Would it be possible to use the QWebEngine-based KPart currently in konqueror.git?

Sep 11 2019, 9:24 AM · Documentation
svuorela added a reviewer for D23866: Port from KHTML to QtWebEngine: mlaurent.

Adding Montel because he has experience with locking QtWE down for e.g. mail usage.

Sep 11 2019, 9:23 AM · Documentation
svuorela updated the diff for D23866: Port from KHTML to QtWebEngine.

Forgot some removed files

Sep 11 2019, 8:54 AM · Documentation
svuorela requested review of D23866: Port from KHTML to QtWebEngine.
Sep 11 2019, 8:51 AM · Documentation
svuorela added a revision to T11541: Port KHelpCenter away from khtml: D23866: Port from KHTML to QtWebEngine.
Sep 11 2019, 8:51 AM · KF6

Sep 10 2019

svuorela committed R124:03892b3b0dc7: Get rid of khtml usage (kill classic mode) (authored by svuorela).
Get rid of khtml usage (kill classic mode)
Sep 10 2019, 10:59 AM
svuorela closed D23799: Get rid of khtml usage (kill classic mode).
Sep 10 2019, 10:59 AM · Plasma
svuorela added a comment to T11541: Port KHelpCenter away from khtml.

Seems to rely quite a bit on the khtml/kio integration and custom url handlers. Maybe there is a way for QtWe to have custom url handling and content serving.

Sep 10 2019, 9:35 AM · KF6
svuorela added a reviewer for D23799: Get rid of khtml usage (kill classic mode): bcooksley.
Sep 10 2019, 8:39 AM · Plasma
svuorela accepted R320:f9f2ef104fa7: Remove the man KPart, and thus the last KHtml user in kio-extras.
Sep 10 2019, 8:33 AM
svuorela added a comment to R320:f9f2ef104fa7: Remove the man KPart, and thus the last KHtml user in kio-extras.

Is the manslave still usefull without the manpart ?

Sep 10 2019, 8:22 AM
svuorela added a comment to T11539: Port Okular away from KHTML.

there is a kchmviewer that uses qtwebengine directly for rendering. I don't know how that fits in the okular way of doing things.

Sep 10 2019, 8:18 AM · Okular, KF6
svuorela updated subscribers of T11539: Port Okular away from KHTML.
Sep 10 2019, 8:14 AM · Okular, KF6
svuorela added a comment to T11539: Port Okular away from KHTML.

Okular uses KHTML for the chm backend.

Sep 10 2019, 8:13 AM · Okular, KF6

Sep 9 2019

svuorela requested review of D23799: Get rid of khtml usage (kill classic mode).
Sep 9 2019, 2:13 PM · Plasma
svuorela committed R443:bd175136c350: Move xmlgui files into qrc files to be able to run without installing (authored by svuorela).
Move xmlgui files into qrc files to be able to run without installing
Sep 9 2019, 12:24 PM
svuorela committed R443:fd3f8881da2c: Move preview from khtml to qwebengine (authored by svuorela).
Move preview from khtml to qwebengine
Sep 9 2019, 12:24 PM
svuorela closed D23796: Modernize kimagemapeditor a bit.
Sep 9 2019, 12:24 PM
svuorela requested review of D23796: Modernize kimagemapeditor a bit.
Sep 9 2019, 10:45 AM
svuorela committed R443:f8765815f411: remove unused code (authored by svuorela).
remove unused code
Sep 9 2019, 8:47 AM

Jul 15 2019

svuorela added a comment to D22419: Fix can't enter directory error on some FTP servers with Turkish locale.

According to the RFC, the server should ignore case:

Jul 15 2019, 8:36 PM · Frameworks

May 1 2019

svuorela added a comment to D20938: Add Mounts Backend.

After reading the code a bit, I wonder

  • can't some of the parsing code be made testable (and tests added)
    • This likely also requires to get rid of the global static.
  • rather than poll /proc/mounts every second, I was wondering if one of the filesystem notification things (QFileSystemWatcher, KDirWatch) could tell when to re-parse it
May 1 2019, 6:58 PM · Frameworks
svuorela accepted D20939: Aztec: Fix padding if the last partial codeword is all one bits.
May 1 2019, 6:51 PM · Frameworks

Apr 9 2019

svuorela added a comment to D20312: get username from full name usernameFromFullname(QString fullname) -> QString.
Apr 9 2019, 6:13 PM · Frameworks

Apr 6 2019

svuorela requested changes to D20312: get username from full name usernameFromFullname(QString fullname) -> QString.

I think unit tests would be nice. Including unit tests documenting the behavior for multiple users with the same full name.

Apr 6 2019, 7:56 PM · Frameworks

Mar 31 2019

svuorela accepted D20149: Fix compilation.
Mar 31 2019, 8:11 PM · Frameworks
svuorela accepted D20143: ora:kra: qstrcmp -> qstrncmp.
Mar 31 2019, 7:29 PM · Frameworks
svuorela accepted D20145: Fix RGBHandler::canRead.

I'm not sure why it as such is needed, but it isn't wrong.

Mar 31 2019, 5:38 PM · Frameworks

Feb 10 2019

svuorela added a comment to D18909: Add Wayland support.

Coding style: it looks like most places in this file uses {} also around one line ifs.

Feb 10 2019, 7:48 PM

Feb 9 2019

svuorela accepted D18369: Create tel: links for phone numbers.
Feb 9 2019, 6:19 PM · Frameworks

Jan 27 2019

svuorela added a comment to D18568: Don't die when finding an unknown email.

This is the limit of my perl knowledge.

Jan 27 2019, 8:17 PM

Jan 20 2019

svuorela added inline comments to D18369: Create tel: links for phone numbers.
Jan 20 2019, 7:04 PM · Frameworks

Jan 18 2019

svuorela committed R1029:dab053f57bec: Fix categories in desktop files (authored by svuorela).
Fix categories in desktop files
Jan 18 2019, 9:25 PM
svuorela committed R1029:4fd813affa6d: Install the KRecipe converter as documentation (authored by svuorela).
Install the KRecipe converter as documentation
Jan 18 2019, 9:25 PM
svuorela committed R1029:3e42b1a4eb78: Remove unused code (authored by svuorela).
Remove unused code
Jan 18 2019, 9:13 PM
svuorela committed R1029:00dae4f4dff6: Reset currentIndex in FileOpen when search receives focus (authored by svuorela).
Reset currentIndex in FileOpen when search receives focus
Jan 18 2019, 9:13 PM
svuorela committed R1029:921a611d05d8: Allow selecting hidden folders in the folder dialog (authored by svuorela).
Allow selecting hidden folders in the folder dialog
Jan 18 2019, 9:13 PM
svuorela committed R1029:f8ba5fdeddfc: Fix typo in headerPositioning (authored by svuorela).
Fix typo in headerPositioning
Jan 18 2019, 9:13 PM
svuorela committed R1029:1d15a626cd76: Use kookbook icon rather than wine icon (authored by svuorela).
Use kookbook icon rather than wine icon
Jan 18 2019, 9:13 PM
svuorela committed R1029:0ab4a98afc96: Fix install of kookbooktouch (authored by svuorela).
Fix install of kookbooktouch
Jan 18 2019, 9:13 PM

Jan 15 2019

svuorela committed R1029:4aad5b4f8600: Clear search string on folder change in filedialog (authored by svuorela).
Clear search string on folder change in filedialog
Jan 15 2019, 7:53 PM
svuorela committed R1029:c2a2531349b9: Ensure images in recipes work in kookbooktouch (authored by svuorela).
Ensure images in recipes work in kookbooktouch
Jan 15 2019, 7:53 PM
svuorela committed R1029:688912519d74: Fix indentation (authored by svuorela).
Fix indentation
Jan 15 2019, 7:53 PM

Jan 14 2019

svuorela committed R1029:8965937a9b5d: Converter from krecipes database (authored by svuorela).
Converter from krecipes database
Jan 14 2019, 7:54 PM

Dec 21 2018

svuorela committed R1029:a6de6903289e: Prevent the toolbar from hiding, and save the poor souls who have hidden it so… (authored by svuorela).
Prevent the toolbar from hiding, and save the poor souls who have hidden it so…
Dec 21 2018, 8:25 PM

Dec 18 2018

svuorela accepted D17633: Make libpanes a static library.
Dec 18 2018, 8:34 PM

Dec 17 2018

svuorela added a comment to D17633: Make libpanes a static library.

Who sets BUILD_SHARED_LIBS ? I don't see anything in this cmake stuff doing it.

Dec 17 2018, 8:09 PM

Dec 16 2018

svuorela added a comment to D17633: Make libpanes a static library.

doesn't add_library default to STATIC if not specified? Else we should add that keyword there rather than install the libs. They are just a convenience bundling of related bits in the source tree, not actual libraries.

Dec 16 2018, 7:45 PM
svuorela committed R1029:cf3c940cd538: Ensure image references are found in recipes (authored by svuorela).
Ensure image references are found in recipes
Dec 16 2018, 11:30 AM
svuorela committed R1029:1490996611e9: Clean up Qt warnings (authored by svuorela).
Clean up Qt warnings
Dec 16 2018, 11:30 AM

Nov 26 2018

svuorela updated subscribers of D17152: Hide the badge if number too big.

Let's try poke @mlaurent and see if he has any comments.

Nov 26 2018, 8:33 PM · Plasma
svuorela added a comment to D17152: Hide the badge if number too big.

What I'm saying is that I think it makes more sense to communicate your preferred email workflow to KMail rather then to Plasma. I'm open to being convinced out of this point of view, of course. :)

Nov 26 2018, 7:57 PM · Plasma
svuorela added a comment to D17152: Hide the badge if number too big.
Nov 26 2018, 7:47 PM · Plasma
svuorela added a comment to D17152: Hide the badge if number too big.

So i like second one, it can still be fixed to 10K+ because it does not matter above.

Nov 26 2018, 7:32 PM · Plasma
svuorela added a comment to D17152: Hide the badge if number too big.

I'll try with + for a couple of days.

Nov 26 2018, 5:38 PM · Plasma
svuorela added a comment to D17152: Hide the badge if number too big.

@ngraham I use kmail ... but I have hundreds of thousands unread emails without counting my spam folders. (commit lists, bug lists, ...)

Nov 26 2018, 5:33 PM · Plasma

Nov 25 2018

svuorela added a comment to D17152: Hide the badge if number too big.

@ngraham It might be that many notifications != no notifications in some cases, but at least in the case of emails, with many unread emails basically doesn't make a difference.

Nov 25 2018, 6:00 PM · Plasma
svuorela requested review of D17152: Hide the badge if number too big.
Nov 25 2018, 11:16 AM · Plasma

Nov 2 2018

svuorela accepted D16561: Remove unused variable.
Nov 2 2018, 6:43 AM · Frameworks
svuorela accepted D16567: Remove unused variable.
Nov 2 2018, 6:43 AM · Baloo, Frameworks
svuorela accepted D16568: Remove unused variables.
Nov 2 2018, 6:42 AM · Frameworks
svuorela accepted D16569: Remove unused variable.
Nov 2 2018, 6:42 AM · Frameworks
svuorela accepted D16571: Remove unused variable.
Nov 2 2018, 6:41 AM · Frameworks
svuorela accepted D16572: don't assign variable to itself.
Nov 2 2018, 6:41 AM · Frameworks
svuorela accepted D16573: Remove unused variables.
Nov 2 2018, 6:41 AM · Frameworks
svuorela accepted D16574: Remove unused variable.
Nov 2 2018, 6:40 AM · Frameworks
svuorela accepted D16565: Remove unused variable.
Nov 2 2018, 6:38 AM · Frameworks

Oct 28 2018

svuorela accepted D16476: Rewrite the PhoneNumber find module to be component-based.
Oct 28 2018, 10:54 AM
svuorela accepted D16348: Properly look for the libphonenumber dependency.
Oct 28 2018, 10:53 AM

Oct 21 2018

svuorela requested changes to D16348: Properly look for the libphonenumber dependency.

Very much an improvement. But we need a license file.

Oct 21 2018, 9:57 AM

Oct 14 2018

svuorela added a comment to D16137: Add an option to KConfigDialog to fit page contents horizontally.

Did you imagine something like what I changed in D16137#343060 (the latest change) ?

Oct 14 2018, 7:45 PM · Frameworks
svuorela added a comment to D16137: Add an option to KConfigDialog to fit page contents horizontally.

from a source & binary compatibility point of view, this looks great.

Oct 14 2018, 12:45 PM · Frameworks

Sep 29 2018

svuorela added a comment to D15833: extend test coverage to all supported mimetypes for taglibextractor.

What's the origin/license of these files ? How are they created ?

Sep 29 2018, 6:01 PM · Baloo, Frameworks

Sep 23 2018

svuorela added inline comments to D15714: add a string suffix to test data and use for unicode testing of taglibwriter.
Sep 23 2018, 7:25 PM · Baloo, Frameworks
svuorela added a comment to D15715: remove own implementation of QString to TString conversion for taglibwriter.

since I'm still unsure about those things: the q2t function was not declared static, but was never exported. It is still safe to remove, right?

Sep 23 2018, 7:23 PM · Baloo, Frameworks
svuorela added inline comments to D15714: add a string suffix to test data and use for unicode testing of taglibwriter.
Sep 23 2018, 6:56 PM · Baloo, Frameworks
svuorela added inline comments to D15714: add a string suffix to test data and use for unicode testing of taglibwriter.
Sep 23 2018, 5:52 PM · Baloo, Frameworks
svuorela added a comment to D15704: increase test coverage of taglibwriter.

Looks good to me. A nice and simple way to drastically increase test coverage.

Sep 23 2018, 5:49 PM · Baloo, Frameworks