Differential D22764

Stabilize test KFileWidgetTest::testDropFile
ClosedPublic
Actions

Authored by meven on Jul 26 2019, 2:38 PM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks
Commits
R241:bbe3e6edfd63: Stabilize test KFileWidgetTest::testDropFile
Summary

The test introduced in D20838 was not completely stable.
It causes failures on CI :

https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.12/job/kio/job/kf5-qt5%20SUSEQt5.12/139/testReport/junit/projectroot/autotests/kiofilewidgets_kfilewidgettest/
https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.13/job/kio/job/kf5-qt5%20SUSEQt5.13/7/testReport/projectroot/autotests/kiofilewidgets_kfilewidgettest/

This patch replaces a wait by an appropriate QSignalSpy.

Test Plan

LANG ctest -R kiofilewidgets

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven created this revision.Jul 26 2019, 2:38 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 26 2019, 2:38 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
meven requested review of this revision.Jul 26 2019, 2:38 PM
dfaure accepted this revision.Jul 26 2019, 3:24 PM

Excellent, thanks.

This revision is now accepted and ready to land.Jul 26 2019, 3:24 PM
Closed by commit R241:bbe3e6edfd63: Stabilize test KFileWidgetTest::testDropFile (authored by meven). · Explain WhyJul 26 2019, 3:28 PM
This revision was automatically updated to reflect the committed changes.
dfaure added inline comments.Oct 18 2020, 9:28 PM
autotests/kfilewidgettest.cpp
481

For the record, this is broken, it should have been completed(QUrl). Specifying argument names is incorrect in SIGNAL() and SLOT() macros.

It makes the wait() below fail every time, but after 5s, so the 100ms became 5s :-)

I'm working on fixing this.

meven added inline comments.Nov 30 2020, 9:03 AM
autotests/kfilewidgettest.cpp
481

Let me know if I should relay you.

dfaure added inline comments.Nov 30 2020, 9:12 AM
autotests/kfilewidgettest.cpp
481

I thought I did that in commit eb18397fe525d2e4bd9 ?

Revision Contents
Changeset List

PathPackages
Mautotests/kfilewidgettest.cpp (8 lines)

Diff 62615

View Options

autotests/kfilewidgettest.cpp

Loading...