- User Since
- Apr 23 2016, 4:37 PM (142 w, 4 d)
Aug 29 2018
Oke, right. Go for it :)
@ngraham could you chime in from a usability point of view?
This will give an inconsistency with the thumbnailes that are enabled in Dolphin's settings and the preview tooltip.
The preview tooltip would now always show a generated thumbnail regardless of the dolphin settings.
Aug 25 2018
(repost from D15069)
What's going on in here?
Aug 22 2018
Aug 19 2018
It "looks" oke to me, but i don't know this code one bit.
Aug 12 2018
Aug 11 2018
Oke, that is quite a bit of layers to figure out...
DolphinView::rootItem, which you can access in DolphinViewContainer::getCaption as m_view->rootItem(); is what you want to use.
Aug 10 2018
Aug 9 2018
Jul 28 2018
That looks much more sensible to me :)
Removing the -1.
It's good to have that!
Also note that you "can" do that in a one-liner with C++14 with a little known library feature.
delete std::exchange(object, nullptr);
I think the logic you've chosen is wrong.
Lets take this fruit store analogy. You have a fruit store with an owner and fruit.
The fruit is dumb and can't do anything outside itself (this would be a tab in dolphin).
The owner (dolphinmainwindow) can look at fruit en change whatever it wants to change in the store (whole of dolphin).
Jul 11 2018
Jul 8 2018
Somehow i'm inclined to think that m_collator is wrong.
But inspecting the code shows no issue as far as i can tell. It's a normal class member that lives as long as the KFileItemModel instance lives.
Jul 7 2018
Jul 2 2018
This looks great!
But i don't get how it is magically included in Dolphin.. Perhaps someone could explain?
I get that it's a fileitemaction plugin and that it's being loaded by dolphin (somehow), i take that for granted.
But even so, if i look in the dolphin code that builds up the context menu for an item: https://cgit.kde.org/dolphin.git/tree/src/dolphincontextmenu.cpp#n307 i see absolutely nothing that can be loading this plugin.
And as this plugin isn't touching that code at all, how does it do that?
Jul 1 2018
I don't know if that's still an issue or if your patch re-introduces whatever the problem was (race conditions?). You could look back in the commit log when that was added to figure out more about it.
Great! :) Back to the good old fast performance it once had!
Please do get rid of the underscore before the name. Nothing (afaict) does that in Dolphin, lets not introduce it. Just lessThan is fine.
Jun 13 2018
While this works, there is a newer en better way for it.
It's new in C++14 and called "transparent compare".
In "this" case it won't change the resulting code of how you compare, but it might be worth checking that out.
Jun 5 2018
This basically is the equivalent of the C++ range iterator (https://github.com/ryanhaining/cppitertools#range, but more libraries have a "range" iterator like that).
Jun 3 2018
May 31 2018
May 28 2018
I like this :)
Thanks a lot for working on it!
May 27 2018
May 26 2018
May 22 2018
May 20 2018
May 17 2018
I think this one has been open for long enough for people to catch it if they want to voice their opinion.
@elvisangelaccio still needs to make his red light green but after that i'd just ship it.
May 14 2018
Just curious, am i right in assuming that this "run as root" is ultimately going to ge gone as soon as KAuth is in place?
And if so, how would Dolphin - as root - then work on non-plasma environments?
May 11 2018
May 10 2018
Log in as the root user and run `sudo dolphin; you can do it.
May 9 2018
Please do note that you have more protocols with shared folders that likely deserve a name change in the same fashion.
I missed this reply so responding on it now.
May 8 2018
I prefer with groupboxes, but not the breeze and oxygen groupbox style.
The styles with the groupbox title embedded within the top horizontal line strikes me as really fancy.
For reference: http://www.beginning-kdevelop-programming.co.uk/Chapter%20Four/BKPChapterFour_html_46b5f46a.png
May 7 2018
Hahaha, that screenshot made me laugh (new actions in the trash, i never noticed that but it's a nice bug).
I wonder if the check is accurate.
Apr 30 2018
I guess it's time for me to resign from this one.
Good luck folks :)
Apr 25 2018
Apr 23 2018
I agree but not for a button that the user controls.
It should either be a tri-state or a "auto preview" button.
Ha, awesome :)
That looks really fancy! :)
Yet i have to give it a -1..
Apr 22 2018
(writing it in this revision as well ;))
Blocking it any longer seems rude to me :)
Apr 20 2018
Apr 19 2018
I like it :)
Sort already is "right in front" of the user. They merely have to click the column headers.
These column headers used to (before the breeze theme, i think the air theme had it) show arrows indicating if something was sorted in ascending or descending.
I don't know why that's gone but that was the universal way to immediately know which column was sorted and in which order. No need to add a button for that.
Apr 16 2018
Refresh on the other hand is something i use relatively often, more then any of the other buttons.
Curious to know: What do you need Refresh for? Maybe there's need for some changes so you won't have to hit that button manually so often?
I personally find the reload button much more useful to have there.
Which change is the leading one now btw?
This or D12162?
I have a small request before i review and test it.
The code has some commented code in it, a redundant QTimer include (in the header where it also forward declares it) and a commented todo. I'm guessing you still need to do some cleanup?
Apr 11 2018
Apr 3 2018
The only reason i can think of (but it's not that since it's not in the code) is to only do this for local drives, not network mounted drives.
But as that's not it, +1 :)
Mar 29 2018
I don't know why, but i already have this by default in my Dolphin... (ArchLinux user here, i don't think they add it explicitly as they try to stay as true to upstream as possible).
So, err, don't know why.
Mar 28 2018
It makes sense to me now. Thank you for elaborating on the timer.