- User Since
- Nov 30 2017, 10:21 PM (58 w, 6 d)
Fri, Jan 4
Sat, Dec 22
- Add comments to i18n strings
Tue, Dec 18
Oh, I see, I'll just move them into the constructor
Dec 17 2018
- Change constexpr to const
Dec 16 2018
Dec 14 2018
- Fix leak and warning
- Add my name to copyright
@ngraham sorry the past two weeks were quite busy for me, I've been travelling. I finally got some time to fix the help text. No more hacks like
- Fix help text
Dec 3 2018
Nov 30 2018
Looks good! We can probably merge this before my D12626
Nov 29 2018
- I don't think WA_TranslucentBackground is necessary
- Change newline handling
- Fix window flags
No nevermind that did the trick, Qt::Popup is the way to go 👍 thanks @kpiwowarski!
Hmph it was working properly with multiple screens, but with a single screen, it dodges the panels for me regardless of Qt::WindowStayOnTopHint. There should be a way to tell Qt to not do this.
Well, with WindowStaysOnTop, what about 374009?
- Make bottom text static
- Fix multi-screen situation
Well, Qt::BypassWindowManagerHint is not really an option since the window manager is what's responsible for Alt-Tab and things like that. We'll have to make the widget extend across multiple screens some other way.
- Microoptimize some arithmetic
- Update help text
- Rename variable
- Reorder includes
- Don't stay on top
- Don't hardcode font size
- Use KLocalizedString
Nov 28 2018
Sorry @ngraham my bad, accidentally left some things uncommitted. It should now compile.
- My bad
- Add back keyboard controls
- Merge in lost changes and fix compiler warnings
Nov 27 2018
Now merged into D12626
- Merge branch 'qpainter-magnifier' into performance-enhancements-new-features
- Realized parent is a QObject, which won't work with QWidget superclass
- Now compiles
- Add more const
- If braces
- Color instead of colour
- Better name: mouseLocation
- Call super constructor
- Fix reference counting
- Delet "delete this"
- Forward declare
- Simplify using bitwise operators
- Change to Q_SIGNALS
Since then I've fixed the camera on my phone, so I think it's about time I record new videos for the description.
- Remove unnecessary change
- Correct diff
Oct 20 2018
I think most it is in there. I'll have a quick look just in case and let
you know. If anything it might have to be with HiDPI
Oct 9 2018
- Remove unnecessary newline
- Tidy up diff
Oct 8 2018
Hey @ngraham, as you can see I just added scrolling to two list views in the configure menu. Apart from that, there's just one minor issue in the information panel that I'm working on right now: when you touch a clickable thing like a link or a ratings star, then touch scroll, then release the touch point at the same spot on top of the clickable thing, it gets activated. I'm in the process of fixing this. But otherwise, a code review would be appreciated.
- Add scrolling to item lists in Configure menu
Oct 5 2018
@davidedmundson awesome! I've been running around in circles trying to find this, glad that you fixed it! Although in the future we should support this properly.
Sep 23 2018
Sep 21 2018
Hey everyone, I can make some time for myself during this weekend to work on this, feel free to leave comments
Sep 20 2018
Aug 6 2018
@ngraham I can resume next week, having my exams right now
Jul 18 2018
@fvogt I haven't worked on it for quite a while. I can resume working on this in a few weeks, after my exams are done.
Hi @rkflx sorry if me adding the arrow keys here threw you off, I personally thought it's trivial enough to have here, but I can move it into a new patch if that makes testing and review easier.
Jul 1 2018
Thanks @steffenh, I've fixed the issues with the scroll bars.
- Fix issues with scroll bar on touch
Jun 27 2018
A few thing tho @sharvey, it looks like currently the resize functionality only moves the bottom right corner, and I've preserved that. But was wondering if we can add in Ctrl or something to control that. Maybe something like:
Alright everyone, I just ported over the arrow key functionality over at D12626.
Remove unused code
- Implement arrow keys to move and resize rectangle
Jun 26 2018
! In D13450#283442, @sharvey wrote:
My intent behind this patch remains geared toward incremental adjustments to the original mouse-drawn rectangle, not a full-blown replacement for drawing a rectangle entirely from the keyboard and having to make dramatic changes.
We discussed starting a rectangle with a keypress (maybe Space), but that idea was set aside for a separate patch. Perhaps we can revisit and further optimize the arrow keys then.
So, currently the arrow functionality depends on repeated Keys.onPressed events, which depend on keyboard repeat delay and rate (system settings -> input devices -> keyboard). This means we will always have an initial stutter followed by an arbitrary speed. This also disallows us to move in two directions at the same time, top and right for instance, since Qt only seems to generate repeated events for the last key pressed. Instead, this should be handled in a different way: have flags keeping track of pressed keys, which get set on Keys.onPressed and unset on Keys.onReleased, and requestPaint in the key press handler if one or more keys are set. Then onPaint repeatedly requestsPaint to keep calling itself if one or more of the keys remain pressed.
Jun 22 2018
Jun 12 2018
Hey @ngraham sorry I've been missing this whole time. I'm back in school and flooded with assignments atm :-(. If you're super interested in this, then I can work on this over the weekend. So at the moment, here's what's working on my config at least:
Jun 8 2018
Jun 1 2018
- Remove unwanted changes
Hey everyone, sorry I've been missing from the scene for so long, glad to be back!
- Fix border issues and rectangle selection bugs
May 4 2018
- Remove inline keywords
- Unfuzz borders and text
- Restore old help box functionality
- Fix magnifier border