[recentdocuments:/] Filter out files that can't be browsed with a file manager

Authored by ngraham on Aug 16 2018, 10:30 PM.



This is a more appropriate version of D13797: Only add actual documents to Recent Documents. Basically we filter out anything that can't be browsed with a file manager, such as web linkns, appstream:// urls, etc.

This ensures that the contents of the recentdocuments:/ ioslave is relevant to the user.

Test Plan

Opened a link from Spectacle in my web browser. Without the patch, it shows up in recentdocuments:/. With the patch, it does not.

Diff Detail

R320 KIO Extras
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
ngraham requested review of this revision.Aug 16 2018, 10:30 PM
ngraham created this revision.
markg added a subscriber: markg.Aug 19 2018, 11:07 AM

It "looks" oke to me, but i don't know this code one bit.


Comments inside a multi-line if statement! Unheard of!
Please move that to a more appropriate place.

ngraham marked an inline comment as done.Aug 20 2018, 1:56 PM
ngraham updated this revision to Diff 40054.Aug 20 2018, 1:56 PM

Move comment

It "looks" oke to me, but i don't know this code one bit.

Give it a try, it's pretty easy to test with the test plan.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 20 2018, 7:12 PM
This revision was automatically updated to reflect the committed changes.
Restricted Application added projects: Dolphin, Frameworks. · View Herald TranscriptSep 25 2018, 2:41 AM
Restricted Application added subscribers: kfm-devel, kde-frameworks-devel. · View Herald Transcript