ctest; all tests pass.
- Group Reviewers
- R318:316e476b3793: Fix the test that broke after recent changes to the default Places items
Thanks! I'll wait for someone from Dolphin to give the patch a thumbs-up too before landing it. Once it's in, I also plan to replace a lot of these hardcoded integers with some more intelligence so that fewer of these tests will pointlessly break when we jigger around the Places items again.
I don't think that is much of a problem.
Just increase the version Dolphin depends on.
Quite a bit of work is going into dolphin anyhow so i would be surprised if it even compiles right now with Frameworks 5.43 (that is the current dependency in it's main cmake file).
And if it does the KIO version dependency likely goes up for whatever reason in the near future. No, i don't have a change ready for that but it's just how things work in a active alive project :)
It's only for 2 more patch releases (18.04.2 and 18.04.3). Then we get 18.10.0 i think (there is no schedule yet).
Just leave it as is for the stable branch and fix the master branch.
The stable branch is not build that often (last one right now is 13 days ago).
The master branch is build much more often as most development happens in there and each build for that one gives us a jenkins mail telling us the build is still unstable.
So, i'd say: go for it in master (leave stable as is) and be done with it.
It's only till the tagging of the next stable from master anyhow (3 months or so i guess?).