Set lock color on Breeze version to #eff0f1 (light2dark script compatibility) and the lock on the Breeze Dark version to #31363b.
Details
- Reviewers
ngraham - Group Reviewers
VDG - Commits
- R266:f729894087c6: Make lock on plasmavault icon visible with breeze-dark
Diff Detail
- Repository
- R266 Breeze Icons
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Can you provide steps to reproduce the problem so I can test it? In my naive testing, the plasmavault icon looks like a lock and shows up fine on both Breeze Light and Breeze Dark. I'm also confused by the images you posted (which should be in the Test Plan{ section, BTW that depict different icons. Can you help a brotha out?
Here's one way to reproduce the bug that this change fixes:
- Switch to the Breeze Dark icon theme
- Use the plasmavault icon for a favorite place in Dolphin. In this case, it's the ~/Vaults folder.
Here's a close-up of the problem.
I'm also confused by the images you posted (which should be in the Test Plan{ section, BTW that depict different icons. Can you help a brotha out?
The pictures are just showing how the icon looks after the change. I suppose I should have shown the old version for comparison. I don't actually know what the test plan section is for and I don't know where I would find that information.
Ah thanks. For some reason Cuttlefish was not displaying the icon properly. :/
Can confirm the problem and that this fixes it! Will land the patch shortly.
Thanks, I really like that series. It gives a real feeling of forward momentum for KDE.