- User Since
- Mar 5 2016, 6:26 AM (119 w, 4 d)
Mon, Jun 18
Sun, Jun 17
Sat, Jun 16
I will make the requested changes and commit. I still have to get used to auto :-)
Fri, Jun 15
Can you provide a screen shot of the enhanced dialog?
Wed, Jun 13
Tue, Jun 12
@ostroffjh you answered the Windows part yourself already. In fact, I am thinking we should stabilize 5.1 and release it next. It has some improvements regarding the plugins so that is probably worth it. Nevertheless, I planned to cherry-pick onto the 5.0 branch once it landed. @ocoole Do you have write access to the repo or shall I land it?
Mon, Jun 11
- Simplified solution as per review
Sun, Jun 10
I have done some more testing and I think this is now good to go into the repo. The remaining issues I found are not related to this patch and can be fixed on the fly.
Said behavior of MS-Windows based operating systems is a PITA and known for many moons. Nevertheless, we always get caught by it. I added habackeras subscriber so that he may check if this also needs to be backported to the 4.8 branch.
Sat, Jun 9
Here's another weirdness: Start KMyMoney which opens the last selected file. Select the categories view and select one category (anyone should do). Close the file with Ctrl-W. Accounts/Update all accounts is still enabled and crashes. Transaction/Select allis also enabled when file is closed.
Then it might be a leftover from one of your recent changes. Anyway, it needs to be fixed. Otherwise you will not be able to create the first category ever in a new file (except loading templates). And this is new user experience.
We'll see if we might have to add them at a later point in time for specific environments. So far, we don't know and don't see a necessity.
I stated, that you need to open a recent file and then close it. Activate all plugins (the iCalendar one is causing the crash) and also make sure to compile with ENABLE_UNFINISHEDFEATURES set to ON and you will be able to reproduce this and maybe find others.
- When KMyMoney is started with the -n command line option
- File export/Schedules to iCalendar is still available (you need to have this plugin enabled)
Fri, Jun 8
Here are my findings:
What about the target_compile_features in kmyoney/settings/CMakeLists.txt? Why were those instructions added in the first place? Are they possibly required on some platform? Did you check all of them?
Thu, Jun 7
Wed, Jun 6
Tue, Jun 5
Looks ok to me besides that one question. It looks like the original code does add an extra separator as well, but is this correct?
Mon, Jun 4
Sun, Jun 3
Sat, Jun 2
In general looks OK to me. Did some casual testing (saving/loading).
Works for me so far. Here's what I have tested:
Wed, May 30
Looks OK to me.
Mon, May 28
Sure, I use stock openSUSE Leap 42.3 atm, which shows as
Sun, May 27
So far, I have not seen any problem while working with an XML based file. I don't use the DB backend. For me this looks OK. Maybe, you can take care of those two comments areas before you land this change.
After fixing some DB related bugs in master, I applied this patch again. Saving a DB to SQLITE still fails, but now I get a different error on the console:
I found the problem with the not-empty database and just fixed it with 9267f93c4d0b5.
Apologies that my previous patch screws up on *nix. (I've always suspected that I was not doing a proper fix last time, and ya... it broke.)
I tested this on on top of c5a3c44b2a341d6 and was able to compile and install it successfully. I was unable to do any further tests, because creating a database from an existing file fails consistently (which may not be related to this change - I did not check). So here's what I do