- User Since
- Mar 5 2016, 6:26 AM (203 w, 1 d)
Fri, Jan 24
Thu, Jan 23
Tue, Jan 21
Works now here on Qt 5.9.7, have not tested it on Qt >= 5.10
Mon, Jan 20
Sun, Jan 19
Unfortunately, the number of items per page is fix for all pages in jekyll. Since the announcements on the first page are somewhat indistinguishable from the rest, how about having a News section between KMyMoney and Support in the top header. Creating a news subdir allows us to have another index.html (the pagination only works on index.html) but I have not tested that at all, just ideas
Sat, Jan 18
I raise my hand for beautiful code
It just crosses my mind, that it would be a lot safer if we add
to the end of the header files and enclose all the source code in the affected cpp files also with
#if QT_VERSION < QT_VERSION_CHECK(5,10,0) #define QSortFilterProxyModel KRecursiveFilterProxyModel #endif : : : #undef QSortFilterProxyModel
This way, the redefinition of QSFP cannot escape this context which would otherwise happen if the header file is included in another source file and that one references the real QSFP.
Almost. It works on Qt < 5.10 only with the patch below on top of your change. Do you have write access to the KDE repo?
Fri, Jan 17
Thu, Jan 16
Wed, Jan 15
Tue, Jan 14
I'll take care of it
Mon, Jan 13
If I see this right, you can make all changes in the .cpp files so that they don't have to be changed in the future and only the #if / #endif in the .h files have to cleaned up.
Sat, Jan 11
Basically, this is the correct thing to do but not all (including my development) distros have Qt 5.10 as a base but rely older Qt versions (5.9.7 in my case). Therefore, we should simply postpone this patch or amend it to support both worlds. I know, this would involve a bit of #ifdef logic, but we have that in other places as well.
Thu, Jan 9
Tue, Jan 7
Sun, Jan 5
Added to web-site
Sat, Jan 4
Thu, Jan 2
Mon, Dec 30
Dec 26 2019
Dec 25 2019
Dec 22 2019
Dec 21 2019
Please cherry pick onto master branch also.
Looks OK to me. Please cherry-pick onto master branch after commit to 5.0