tbaumgart (Thomas Baumgart)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Mar 5 2016, 6:26 AM (119 w, 4 d)
Availability
Available

Recent Activity

Mon, Jun 18

tbaumgart committed R261:3d640881b17f: Keep Home view enabled all the time (authored by tbaumgart).
Keep Home view enabled all the time
Mon, Jun 18, 12:53 PM
tbaumgart committed R261:05ce669ed209: Enable Q_ASSERT in debug builds (authored by tbaumgart).
Enable Q_ASSERT in debug builds
Mon, Jun 18, 12:53 PM

Sun, Jun 17

tbaumgart committed R261:722630047609: Fix detection of clientuid support (authored by tbaumgart).
Fix detection of clientuid support
Sun, Jun 17, 3:20 PM

Sat, Jun 16

tbaumgart committed R261:1b0a620291af: Simplify signal handling between engine and models (authored by tbaumgart).
Simplify signal handling between engine and models
Sat, Jun 16, 2:18 PM
tbaumgart closed D13519: Simplify signal handling between engine and models.
Sat, Jun 16, 2:18 PM
tbaumgart added a comment to D13519: Simplify signal handling between engine and models.

I will make the requested changes and commit. I still have to get used to auto :-)

Sat, Jun 16, 2:17 PM
tbaumgart requested changes to D13558: Add support for checking a selected online quote in related settings dialog.
Sat, Jun 16, 9:49 AM

Fri, Jun 15

tbaumgart requested changes to D13558: Add support for checking a selected online quote in related settings dialog.

Can you provide a screen shot of the enhanced dialog?

Fri, Jun 15, 12:20 PM

Wed, Jun 13

tbaumgart added a reviewer for D13519: Simplify signal handling between engine and models: wojnilowicz.
Wed, Jun 13, 4:20 PM
tbaumgart requested review of D13519: Simplify signal handling between engine and models.
Wed, Jun 13, 4:19 PM
tbaumgart committed R261:7601079e3197: Reduce vertical spacing of form elements (authored by tbaumgart).
Reduce vertical spacing of form elements
Wed, Jun 13, 4:19 PM
tbaumgart committed R261:a4e991f8174a: Prevent mouseMoveEvents in new ledger view (authored by tbaumgart).
Prevent mouseMoveEvents in new ledger view
Wed, Jun 13, 4:19 PM
tbaumgart committed R261:457d0ff6dba8: Modernize WidgetHintFrame object (authored by tbaumgart).
Modernize WidgetHintFrame object
Wed, Jun 13, 10:35 AM
tbaumgart committed R261:b20464b87c96: Revert "Try to find problem with exceptions on FreeBSD" (authored by tbaumgart).
Revert "Try to find problem with exceptions on FreeBSD"
Wed, Jun 13, 8:07 AM
tbaumgart added a reverting change for R261:176986e37ebb: Try to find problem with exceptions on FreeBSD: R261:b20464b87c96: Revert "Try to find problem with exceptions on FreeBSD".
Wed, Jun 13, 8:07 AM
tbaumgart committed R261:176986e37ebb: Try to find problem with exceptions on FreeBSD (authored by tbaumgart).
Try to find problem with exceptions on FreeBSD
Wed, Jun 13, 7:55 AM
tbaumgart committed R261:ab29f08a258b: Adjust cmake module to setup LibOFX build vars for FreeBSD (authored by tbaumgart).
Adjust cmake module to setup LibOFX build vars for FreeBSD
Wed, Jun 13, 6:24 AM

Tue, Jun 12

tbaumgart committed R261:f16004d5b3ac: Replace for with foreach for loop over list (authored by tbaumgart).
Replace for with foreach for loop over list
Tue, Jun 12, 9:16 PM
tbaumgart committed R261:68a686716680: Provide timezone offset for OFX import (authored by tbaumgart).
Provide timezone offset for OFX import
Tue, Jun 12, 6:14 PM
tbaumgart closed D13293: Provide timezone offset for OFX import.
Tue, Jun 12, 6:14 PM
tbaumgart retitled D13293: Provide timezone offset for OFX import from Provide timestamp offset for OFX import to Provide timezone offset for OFX import.
Tue, Jun 12, 6:07 PM
tbaumgart added a comment to D13465: Fix xml file saving on Windows.

@ostroffjh you answered the Windows part yourself already. In fact, I am thinking we should stabilize 5.1 and release it next. It has some improvements regarding the plugins so that is probably worth it. Nevertheless, I planned to cherry-pick onto the 5.0 branch once it landed. @ocoole Do you have write access to the repo or shall I land it?

Tue, Jun 12, 7:47 AM · KMyMoney

Mon, Jun 11

tbaumgart committed R261:0b87da170a5b: Keep current scroll position when reloading page (authored by tbaumgart).
Keep current scroll position when reloading page
Mon, Jun 11, 1:00 PM
tbaumgart closed D11450: Keep current scroll position when reloading page.
Mon, Jun 11, 1:00 PM
tbaumgart committed R261:5ca438e09437: Improve save as storage type selection dialog (authored by tbaumgart).
Improve save as storage type selection dialog
Mon, Jun 11, 12:43 PM
tbaumgart updated the diff for D11450: Keep current scroll position when reloading page.
  • Simplified solution as per review
Mon, Jun 11, 5:56 AM

Sun, Jun 10

tbaumgart committed R261:217ba253c2f7: Fix state of edit/delete transaction buttons (authored by tbaumgart).
Fix state of edit/delete transaction buttons
Sun, Jun 10, 6:38 PM
tbaumgart accepted D13408: Refactor file menu.

I have done some more testing and I think this is now good to go into the repo. The remaining issues I found are not related to this patch and can be fixed on the fly.

Sun, Jun 10, 3:03 PM · KMyMoney
tbaumgart committed R261:8361512c2264: Prevent crash on destruction of KTagContainer (authored by tbaumgart).
Prevent crash on destruction of KTagContainer
Sun, Jun 10, 2:24 PM
tbaumgart accepted D13465: Fix xml file saving on Windows.

Said behavior of MS-Windows based operating systems is a PITA and known for many moons. Nevertheless, we always get caught by it. I added habackeras subscriber so that he may check if this also needs to be backported to the 4.8 branch.

Sun, Jun 10, 1:53 PM · KMyMoney
tbaumgart updated subscribers of D13465: Fix xml file saving on Windows.
Sun, Jun 10, 1:37 PM · KMyMoney
tbaumgart committed R261:f2e799fadcfd: Make sure 'new category' is always available (authored by tbaumgart).
Make sure 'new category' is always available
Sun, Jun 10, 9:57 AM
tbaumgart requested changes to D13408: Refactor file menu.
Sun, Jun 10, 8:43 AM · KMyMoney

Sat, Jun 9

tbaumgart committed R261:6e85b7431198: Resolve more compiler warnings (authored by tbaumgart).
Resolve more compiler warnings
Sat, Jun 9, 8:48 PM
tbaumgart committed R261:a5e60b597f6c: Make sure 'new category' is available when storage is open (authored by tbaumgart).
Make sure 'new category' is available when storage is open
Sat, Jun 9, 8:09 PM
tbaumgart committed R261:0940d36be66b: Resolve compiler warning (authored by tbaumgart).
Resolve compiler warning
Sat, Jun 9, 8:09 PM
tbaumgart added a comment to D13408: Refactor file menu.

Here's another weirdness: Start KMyMoney which opens the last selected file. Select the categories view and select one category (anyone should do). Close the file with Ctrl-W. Accounts/Update all accounts is still enabled and crashes. Transaction/Select allis also enabled when file is closed.

Sat, Jun 9, 7:53 PM · KMyMoney
tbaumgart requested changes to D13408: Refactor file menu.
  • Category/New Category is never enabled

I did not change this behaviour. Category/New Category activates on categories view if you select one of the categories.

Then it might be a leftover from one of your recent changes. Anyway, it needs to be fixed. Otherwise you will not be able to create the first category ever in a new file (except loading templates). And this is new user experience.

Sat, Jun 9, 3:34 PM · KMyMoney
tbaumgart accepted D13409: Remove redundant CMake statements.

We'll see if we might have to add them at a later point in time for specific environments. So far, we don't know and don't see a necessity.

Sat, Jun 9, 2:45 PM · KMyMoney
tbaumgart added a comment to D13408: Refactor file menu.
  • When KMyMoney is started without options to open the last loaded storage
    • File/Close or Ctrl+W don't work anymore. They show an error (see also message on CLI)

I cannot reproduce this. If you open KMM without a file, then Ctrl+W shouldn't be available.

I stated, that you need to open a recent file and then close it. Activate all plugins (the iCalendar one is causing the crash) and also make sure to compile with ENABLE_UNFINISHEDFEATURES set to ON and you will be able to reproduce this and maybe find others.

Sat, Jun 9, 2:41 PM · KMyMoney
tbaumgart added a comment to D13408: Refactor file menu.
  • When KMyMoney is started with the -n command line option
    • File export/Schedules to iCalendar is still available (you need to have this plugin enabled)
Sat, Jun 9, 8:18 AM · KMyMoney

Fri, Jun 8

tbaumgart requested changes to D13408: Refactor file menu.

Here are my findings:

Fri, Jun 8, 3:08 PM · KMyMoney
tbaumgart added a comment to D13409: Remove redundant CMake statements.

What about the target_compile_features in kmyoney/settings/CMakeLists.txt? Why were those instructions added in the first place? Are they possibly required on some platform? Did you check all of them?

Fri, Jun 8, 1:34 PM · KMyMoney
tbaumgart updated the summary of D13414: Format reports headers according to the KDE guidelines.
Fri, Jun 8, 8:03 AM · KMyMoney
tbaumgart updated the summary of D13413: Format widget headers according to the KDE guidelines.
Fri, Jun 8, 8:00 AM · KMyMoney

Thu, Jun 7

tbaumgart committed R261:380e9d60f381: Don't change last selected view during application exit (authored by tbaumgart).
Don't change last selected view during application exit
Thu, Jun 7, 11:49 AM
tbaumgart committed R261:c88f41f13b20: Make settings are synced to disk on app quit (authored by tbaumgart).
Make settings are synced to disk on app quit
Thu, Jun 7, 11:05 AM
tbaumgart committed R261:eb44ed0dfeb2: Update last selected view in settings (authored by tbaumgart).
Update last selected view in settings
Thu, Jun 7, 11:05 AM
tbaumgart committed R261:2f823a4603f1: Improve deletion of unused widgets in transaction editor (authored by tbaumgart).
Improve deletion of unused widgets in transaction editor
Thu, Jun 7, 7:43 AM

Wed, Jun 6

tbaumgart committed R261:65c4882148eb: Remove unused comments (authored by tbaumgart).
Remove unused comments
Wed, Jun 6, 6:41 AM
tbaumgart committed R261:35e6212fed44: Simplify libofx clientuid support detection (authored by tbaumgart).
Simplify libofx clientuid support detection
Wed, Jun 6, 6:41 AM

Tue, Jun 5

tbaumgart committed R261:3c5c5070b037: Write correct number of columns for investment transactions to csv file (authored by tbaumgart).
Write correct number of columns for investment transactions to csv file
Tue, Jun 5, 3:40 PM
tbaumgart committed R261:9d53da8867d4: Remove extra column at end of non investment lines in csv export (authored by tbaumgart).
Remove extra column at end of non investment lines in csv export
Tue, Jun 5, 3:40 PM
tbaumgart committed R261:638b0eacfdcc: Allow field delimiter as character in CSV exports (authored by tbaumgart).
Allow field delimiter as character in CSV exports
Tue, Jun 5, 3:40 PM
tbaumgart committed R261:11fa00ff2b8a: Try to fix build on arm (authored by tbaumgart).
Try to fix build on arm
Tue, Jun 5, 11:23 AM
tbaumgart committed R261:6c39704b37ab: Fix another int conversion warning (authored by tbaumgart).
Fix another int conversion warning
Tue, Jun 5, 11:23 AM
tbaumgart accepted D13330: Fix 'csv writer generates invalid file in case field delimiter is used in any field'.

Looks ok to me besides that one question. It looks like the original code does add an extra separator as well, but is this correct?

Tue, Jun 5, 8:58 AM
tbaumgart committed R261:47788f07de12: Fix some more integer conversion warnings (authored by tbaumgart).
Fix some more integer conversion warnings
Tue, Jun 5, 8:02 AM
tbaumgart committed R261:f84f2b4b7859: Fix CSV Export of Investment Accounts (authored by tbaumgart).
Fix CSV Export of Investment Accounts
Tue, Jun 5, 7:41 AM
tbaumgart committed R261:c1548db16361: Display correct name of closed account (authored by tbaumgart).
Display correct name of closed account
Tue, Jun 5, 5:15 AM

Mon, Jun 4

tbaumgart committed R261:ab5d1d1253c2: Try to fix MSVC error C2276 (authored by tbaumgart).
Try to fix MSVC error C2276
Mon, Jun 4, 6:18 PM
tbaumgart committed R261:12b53c99fb61: Fix a bunch of integer conversion warnings (authored by tbaumgart).
Fix a bunch of integer conversion warnings
Mon, Jun 4, 6:18 PM
tbaumgart committed R261:dd77e1f94f1d: Correctly version libkmm_payeeidentifier_loader (authored by tbaumgart).
Correctly version libkmm_payeeidentifier_loader
Mon, Jun 4, 5:58 PM
tbaumgart committed R261:77c89b8bd73b: Fix macro expansion which causes trouble on MSVC (authored by tbaumgart).
Fix macro expansion which causes trouble on MSVC
Mon, Jun 4, 5:58 PM
tbaumgart committed R261:53f1785233ab: Resolve warnings about unused variables (authored by tbaumgart).
Resolve warnings about unused variables
Mon, Jun 4, 2:45 PM
tbaumgart committed R261:ca2290dc5cbd: Add warning about unused const variables (authored by tbaumgart).
Add warning about unused const variables
Mon, Jun 4, 2:45 PM
tbaumgart committed R261:c8b202f550a0: Reload widget to use newly created security (authored by tbaumgart).
Reload widget to use newly created security
Mon, Jun 4, 2:20 PM
tbaumgart committed R261:87d3c4ef0cbe: Reload widget to use newly created security (authored by tbaumgart).
Reload widget to use newly created security
Mon, Jun 4, 2:15 PM
tbaumgart requested changes to D13330: Fix 'csv writer generates invalid file in case field delimiter is used in any field'.
Mon, Jun 4, 1:26 PM
tbaumgart committed R261:8bdae55854dd: Correctly version libkmm_models.so (authored by tbaumgart).
Correctly version libkmm_models.so
Mon, Jun 4, 1:16 PM
tbaumgart committed R261:0e75cd0973d7: Adjust usage of thousands separator (authored by tbaumgart).
Adjust usage of thousands separator
Mon, Jun 4, 9:39 AM

Sun, Jun 3

tbaumgart accepted D13298: Fix some build warnings.

Looks OK to me.

Sun, Jun 3, 3:35 PM · KMyMoney
tbaumgart accepted D13296: Use unsigned int for denominator in MyMoneyMoney.
Sun, Jun 3, 11:39 AM · KMyMoney
tbaumgart committed R261:258ac558b1c8: Added testcases for MyMoneyMoney ctors (authored by tbaumgart).
Added testcases for MyMoneyMoney ctors
Sun, Jun 3, 11:38 AM
tbaumgart added inline comments to D13296: Use unsigned int for denominator in MyMoneyMoney.
Sun, Jun 3, 11:15 AM · KMyMoney
tbaumgart added inline comments to D13296: Use unsigned int for denominator in MyMoneyMoney.
Sun, Jun 3, 10:39 AM · KMyMoney
tbaumgart added a reviewer for D13295: Enable foreign keys support in SQLite: christiand.
Sun, Jun 3, 9:12 AM · KMyMoney
tbaumgart updated the summary of D13293: Provide timezone offset for OFX import.
Sun, Jun 3, 8:17 AM
tbaumgart requested review of D13293: Provide timezone offset for OFX import.
Sun, Jun 3, 8:11 AM

Sat, Jun 2

tbaumgart requested changes to D13279: Pluginize XML Storage.

In general looks OK to me. Did some casual testing (saving/loading).

Sat, Jun 2, 1:15 PM · KMyMoney
tbaumgart requested changes to D13242: Move ibanbicdata to a plugin.

Works for me so far. Here's what I have tested:

Sat, Jun 2, 12:54 PM · KMyMoney
tbaumgart committed R261:216b3ad7d0e4: Fix 'User is asked to create a new category in splits table if change is… (authored by tbaumgart).
Fix 'User is asked to create a new category in splits table if change is…
Sat, Jun 2, 8:28 AM

Wed, May 30

tbaumgart accepted D12917: Make sure that all code uses MyMoneySplit::Action... variables instead of duplicated strings.

Looks OK to me.

Wed, May 30, 7:47 AM

Mon, May 28

tbaumgart added a comment to R261:c5a3c44b2a34: Fix construction of file based DB name on *NIX systems.

Sure, I use stock openSUSE Leap 42.3 atm, which shows as

Mon, May 28, 7:14 AM

Sun, May 27

tbaumgart accepted D13020: Get rid of databaseStoreableObject.

So far, I have not seen any problem while working with an XML based file. I don't use the DB backend. For me this looks OK. Maybe, you can take care of those two comments areas before you land this change.

Sun, May 27, 4:54 PM · KMyMoney
tbaumgart added a comment to D13020: Get rid of databaseStoreableObject.

After fixing some DB related bugs in master, I applied this patch again. Saving a DB to SQLITE still fails, but now I get a different error on the console:

Failed to save onlineJob "O000001" Reson: Could not load sqlStoragePlugin 'org.kmymoney.creditTransfer.sepa.sqlStoragePlugin', (error: No service matching the requirements was found) /home/thb/devel/kmymoney/kmymoney/plugins/sql/mymoneystoragesql_p.h:2662

One line for each one of them, and I have a few.

I've fixed

No service matching the requirements was found

but saving still fails and it's not part of this patch, as it has failed before in the same spot as before the patch.

Sun, May 27, 4:43 PM · KMyMoney
tbaumgart added a comment to D13020: Get rid of databaseStoreableObject.

After fixing some DB related bugs in master, I applied this patch again. Saving a DB to SQLITE still fails, but now I get a different error on the console:

Sun, May 27, 3:07 PM · KMyMoney
tbaumgart added a comment to R261:c5a3c44b2a34: Fix construction of file based DB name on *NIX systems.

I found the problem with the not-empty database and just fixed it with 9267f93c4d0b5.

Sun, May 27, 2:40 PM
tbaumgart committed R261:9267f93c4d0b: Fix check for empty database (authored by tbaumgart).
Fix check for empty database
Sun, May 27, 2:39 PM
tbaumgart added a comment to R261:c5a3c44b2a34: Fix construction of file based DB name on *NIX systems.

Apologies that my previous patch screws up on *nix. (I've always suspected that I was not doing a proper fix last time, and ya... it broke.)

Sun, May 27, 12:16 PM
tbaumgart added a comment to D13020: Get rid of databaseStoreableObject.

I tested this on on top of c5a3c44b2a341d6 and was able to compile and install it successfully. I was unable to do any further tests, because creating a database from an existing file fails consistently (which may not be related to this change - I did not check). So here's what I do

Sun, May 27, 7:50 AM · KMyMoney
tbaumgart committed R261:c5a3c44b2a34: Fix construction of file based DB name on *NIX systems (authored by tbaumgart).
Fix construction of file based DB name on *NIX systems
Sun, May 27, 7:16 AM
tbaumgart committed R261:e9b4420650c0: Avoid duplicate deletion (authored by tbaumgart).
Avoid duplicate deletion
Sun, May 27, 7:16 AM

May 20 2018

tbaumgart committed R261:06f063417796: Added testcase to check exception handling (authored by tbaumgart).
Added testcase to check exception handling
May 20 2018, 5:02 PM

May 19 2018

tbaumgart committed R261:dea9c55f32d5: Resolve compiler warning (authored by tbaumgart).
Resolve compiler warning
May 19 2018, 6:33 AM

May 18 2018

tbaumgart committed R261:7b7679912dfb: Fix compiler warnings (authored by tbaumgart).
Fix compiler warnings
May 18 2018, 7:28 PM

May 15 2018

tbaumgart committed R261:34b9b705eac1: Fix another corner case with the new online balance marker (authored by tbaumgart).
Fix another corner case with the new online balance marker
May 15 2018, 12:43 PM

May 13 2018

tbaumgart committed R261:c9caff4ca48a: Correct display of online balance marker (authored by tbaumgart).
Correct display of online balance marker
May 13 2018, 4:26 PM
tbaumgart committed R261:33f9e1f6ec9b: Prevent edit via double-click for online transactions (authored by tbaumgart).
Prevent edit via double-click for online transactions
May 13 2018, 2:00 PM
tbaumgart committed R261:f1942f1957f0: Fix setup for for multi profile build generators (authored by tbaumgart).
Fix setup for for multi profile build generators
May 13 2018, 10:36 AM