- User Since
- Mar 5 2016, 6:26 AM (106 w, 2 d)
Please land asap since we're in the process of crafting a release.
Sat, Mar 17
Looks good to me.
Looks good to me. I'll take care of adding it to the repo.
I added a knowledgeable reviewer. Maybe, he can share some of his wisdom.
Fri, Mar 16
Thu, Mar 15
Once you do it right, it works immediately.
Tue, Mar 13
Unless I am doing something completely wrong here, it fails for me:
Works for me.
Can you then please take care of either
Ok, that is true. Looks like I need to play a lot more with this CMake magic to fully understand what's going on.
I get the following warning when I apply this patch:
Mon, Mar 12
Can't we close this patch? I think we have all we need in the repo already. Or am I missing something?
Sun, Mar 11
- Remove a leftover from last commit
- Pass on the includedir of the MP library to the user of Alkimia
Sat, Mar 10
- Only reference the used MP library
Support both MPIR and GM
Made more enums type safe
This does not work as you expect it. You cannot seek on a KGPGFile object. This is never gonna work. Just because you see the base object's seek() method does not mean it will work. Did you ever try it? It crashes with a segmentation fault. This change needs to be abandoned.
Thu, Mar 8
Looks good to me
Wed, Mar 7
I did not test it myself against a Qt4 installation, but it looks OK to me.
Tue, Mar 6
You are right, but there is no mention that this is for the alkimia repo (try Ctrl-F and look for alimia). I thought it would be a pathc for KMyMoney. That is a different story then and everything is OK.
Is this to be meant to end up in master? Master is not meant to be used for Qt4. Or am I missing an important detail here?
Mon, Mar 5
Looks OK to me as well.
Looks good to me. It certainly makes sense to get the compiler to check certain things. I still have to try this against the master/5.0 branch to benefit from it as well.
Sun, Mar 4
Sat, Mar 3
Fri, Mar 2
Thu, Mar 1
Tue, Feb 27
Mon, Feb 26
I have not yet tested to compile or run the patch but still have to do that before I can give a judgment.