sander (Oliver Sander)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jun 19 2017, 12:29 PM (92 w, 11 h)
Availability
Available

Recent Activity

Sun, Mar 24

sander added a comment to D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet.

I do use my stylus for drawing on slides in presentation mode. I am not particularly happy with the quality of that, but compressing tablet events doesn't seem to make it worse. So no objections from my side.

Sun, Mar 24, 5:21 PM · Okular
sander added a comment to D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet.

I tried this on my ThinkPad Yoga 12, which comes with a stylus to write on the screen with. I confirm that this patch noticeably improves the scrolling behavior when using the stylus for scrolling.

Sun, Mar 24, 4:03 PM · Okular

Sat, Mar 16

sander added a comment to D13901: Touch support for Gwenview.

Thanks for the patch. How is the gesture code going to get into KWidgetAddons now?

Sat, Mar 16, 2:44 PM · Gwenview

Fri, Mar 15

sander updated the diff for D19702: Page changes triggered by mouse clicks should all happen on button release.

Updated the comment

Fri, Mar 15, 1:53 PM · Okular
sander updated the diff for D19539: Replace some iterator loops by range-based for.

Removed those four aAsConst again.

Fri, Mar 15, 8:53 AM · Okular

Tue, Mar 12

sander requested review of D19702: Page changes triggered by mouse clicks should all happen on button release.
Tue, Mar 12, 10:08 AM · Okular
sander added a comment to D19539: Replace some iterator loops by range-based for.

Albert, is this okay now?

Tue, Mar 12, 9:28 AM · Okular

Mon, Mar 11

sander committed R223:50bfd9fe8645: Presentation: optionally go to prev. page when touching left half of the page (authored by sander).
Presentation: optionally go to prev. page when touching left half of the page
Mon, Mar 11, 8:13 PM
sander closed D18118: Presentation mode: go to previous page when left-clicking on left half of the page.
Mon, Mar 11, 8:13 PM · Okular
sander updated the diff for D18118: Presentation mode: go to previous page when left-clicking on left half of the page.
  • 'sides' --> 'side'
  • updated old comment
Mon, Mar 11, 8:11 PM · Okular
sander updated the test plan for D18118: Presentation mode: go to previous page when left-clicking on left half of the page.
Mon, Mar 11, 8:01 PM · Okular

Thu, Mar 7

sander added a comment to D18118: Presentation mode: go to previous page when left-clicking on left half of the page.

Albert, is this okay for you now?

Thu, Mar 7, 7:07 PM · Okular
sander updated the diff for D19539: Replace some iterator loops by range-based for.

Ugly; didn't know about 'hidden detaches'.

Thu, Mar 7, 6:23 PM · Okular

Wed, Mar 6

sander updated the diff for D18118: Presentation mode: go to previous page when left-clicking on left half of the page.

UI reworded following Nate's suggestions

Wed, Mar 6, 4:30 PM · Okular
sander updated the diff for D19539: Replace some iterator loops by range-based for.
  • Do not use auto in range-based for
  • Use qDeleteAll where appropriate
Wed, Mar 6, 4:27 PM · Okular
sander added a comment to D18118: Presentation mode: go to previous page when left-clicking on left half of the page.

What is the behavior of the mouse buttons? In other words can the left mouse button make it go forward without being anywhere on the screen, and the right button make if go backwards.

Wed, Mar 6, 5:22 AM · Okular

Tue, Mar 5

sander added a comment to D18118: Presentation mode: go to previous page when left-clicking on left half of the page.

That's the current behavior, ...

Tue, Mar 5, 8:21 PM · Okular
sander added a comment to D18118: Presentation mode: go to previous page when left-clicking on left half of the page.

That's the current behavior, only with different UI text, right? That's fine with me. I will provide an updated patch within the next few days.

Tue, Mar 5, 8:17 PM · Okular
sander added a comment to D18118: Presentation mode: go to previous page when left-clicking on left half of the page.

If I understand Albert correctly he wants to have the current behavior as an option. Your proposal does not offer that, does it?

Tue, Mar 5, 8:04 PM · Okular
sander added a comment to D19539: Replace some iterator loops by range-based for.

Fine with me, too. If somebody is in favour of auto, please say so now. Otherwise I will remove the autos from the patch.

Tue, Mar 5, 7:38 PM · Okular
sander added a comment to D18118: Presentation mode: go to previous page when left-clicking on left half of the page.

Not sure I fully understand your proposal. What happens if I uncheck the first option, check the second one, and then tap on the left half of the screen?

Tue, Mar 5, 7:36 PM · Okular
sander added a comment to D19539: Replace some iterator loops by range-based for.

You may want to read up on range-based for; it is very helpful. In such a for-loop, auto always means "the type of a container entry".

Tue, Mar 5, 1:23 PM · Okular
sander updated the diff for D18118: Presentation mode: go to previous page when left-clicking on left half of the page.

Make the new touch screen behavior optional. There are three choices now in 'preferences->presentation':

Tue, Mar 5, 11:37 AM · Okular
sander requested review of D19539: Replace some iterator loops by range-based for.
Tue, Mar 5, 11:03 AM · Okular

Jan 12 2019

sander added a comment to D18118: Presentation mode: go to previous page when left-clicking on left half of the page.

Guys, stop fighting. I'll make it optional in the next patch upload, all I need is a bit of time.

Jan 12 2019, 6:13 PM · Okular

Jan 11 2019

sander updated the diff for D18118: Presentation mode: go to previous page when left-clicking on left half of the page.

New patch version:

  • You can go back by touching on the left half of a touchscreen, touching the right half will go forward
  • Mouse behavior is unchanged---left-clicking anywhere on the screen will go forward.
Jan 11 2019, 8:04 PM · Okular
sander added a comment to D18118: Presentation mode: go to previous page when left-clicking on left half of the page.
It's interesting that swiping down from the top with a single finger brings out the menu' so there does seem to be the potential of single finger swiping.
Jan 11 2019, 7:59 PM · Okular
sander added a comment to D18118: Presentation mode: go to previous page when left-clicking on left half of the page.

I think that swiping is a separate issue. One-finger swipes should actually be easy to implement as the difficult part already exists in the Gwenview patch mentioned above. And we probably all agree that one-finger swipes are better than three-finger ones.

Jan 11 2019, 9:04 AM · Okular
sander added a comment to D18118: Presentation mode: go to previous page when left-clicking on left half of the page.

I'd also prefer to leave the current behaviour of a left-click as it is

Jan 11 2019, 8:22 AM · Okular

Jan 9 2019

sander added a comment to D13901: Touch support for Gwenview.

Some of these gesture recognizers would be very helpful in other KDE programs as well (Okular is what I have in mind). Can they be moved to some central place where both Gwenview and Okular can use them?

Jan 9 2019, 10:34 AM · Gwenview
sander added a comment to D7949: Allow to print pdf doc directly into a QPrinter.

There's a GitHub project at https://github.com/giddie/poppler-cairo-backend , but from how I read the related bug report, upstream integration is very unlikely.

Jan 9 2019, 10:00 AM · Okular
sander added a comment to D18118: Presentation mode: go to previous page when left-clicking on left half of the page.

Actually, the necessary gesture recognizer exists, as part of a GwenView patch: https://phabricator.kde.org/D13901 . If that code was accessible from Okular, moving to one-finger swipes would be trivial.

Jan 9 2019, 5:38 AM · Okular

Jan 8 2019

sander added a comment to D18118: Presentation mode: go to previous page when left-clicking on left half of the page.

That's the standard Qt swipe gesture. Anything else would require writing your own gesture recognizer.

Jan 8 2019, 10:02 PM · Okular
sander added a comment to D18118: Presentation mode: go to previous page when left-clicking on left half of the page.

Changing pages by swiping on a touchscreen works already (Qt requires you to swipe with three(!) fingers, though). But if I were a piano player using Okular to show me the music sheets I'd rather not swipe for fear of smashing the entire screen off the piano.

Jan 8 2019, 9:42 PM · Okular
sander added a comment to D18118: Presentation mode: go to previous page when left-clicking on left half of the page.

How about we let the new behavior apply only to touch events, and leave the mouse handling as it is?

Jan 8 2019, 9:24 PM · Okular
sander updated the summary of D18118: Presentation mode: go to previous page when left-clicking on left half of the page.
Jan 8 2019, 9:19 PM · Okular
sander requested review of D18118: Presentation mode: go to previous page when left-clicking on left half of the page.
Jan 8 2019, 8:40 PM · Okular

Jan 7 2019

sander added a comment to D7949: Allow to print pdf doc directly into a QPrinter.

The quality of the Arthur backend really depends on what you use it for. For example, I personally mostly use Okular for scientific articles and presentations, and Arthur works almost perfectly for that. But for other types of documents, however, the situation may be different. Only Albert and his test suite know. :-)

Jan 7 2019, 11:21 AM · Okular

Jan 4 2019

sander added a comment to D17929: Hide cursor when tablet stylus leaves proximity of the screen.

Didn't we have this discussion millions of years ago?

Jan 4 2019, 11:01 AM · Okular

Jan 3 2019

sander updated the diff for D17929: Hide cursor when tablet stylus leaves proximity of the screen.

Whitespace fixes

Jan 3 2019, 10:30 AM · Okular
sander added inline comments to D17929: Hide cursor when tablet stylus leaves proximity of the screen.
Jan 3 2019, 10:26 AM · Okular

Jan 2 2019

sander added a comment to D17929: Hide cursor when tablet stylus leaves proximity of the screen.

Coding style: Opening curly braces go on the same line of the if statement.

Jan 2 2019, 8:45 PM · Okular
sander requested review of D17929: Hide cursor when tablet stylus leaves proximity of the screen.
Jan 2 2019, 8:33 PM · Okular

Dec 30 2018

sander added a comment to D7949: Allow to print pdf doc directly into a QPrinter.

Where are we at with this? What are the blockers to landing it?

Dec 30 2018, 4:08 PM · Okular
sander updated the diff for D7949: Allow to print pdf doc directly into a QPrinter.

Rebased to current master, and connected the code to the new print scaling modes.

Dec 30 2018, 4:02 PM · Okular
sander committed R223:a4735e428a33: Use more std::unique_ptr (authored by sander).
Use more std::unique_ptr
Dec 30 2018, 3:55 PM

Dec 23 2018

sander added a comment to D7962: Implement several new print scaling options.

Thanks for testing!

Dec 23 2018, 1:27 AM · Okular
sander committed R223:2e97d587508d: Implement several new print scaling options (authored by sander).
Implement several new print scaling options
Dec 23 2018, 1:26 AM
sander closed D7962: Implement several new print scaling options.
Dec 23 2018, 1:26 AM · Okular

Dec 22 2018

sander added a comment to D7962: Implement several new print scaling options.

The patch here does not depend on D7949 anymore. It should fit directly onto the current master. D7949 does indeed need rebasing, which I will do as soon as this patch here has its final form.

Dec 22 2018, 5:45 AM · Okular
sander updated the summary of D7962: Implement several new print scaling options.
Dec 22 2018, 5:44 AM · Okular

Dec 21 2018

sander updated the diff for D7962: Implement several new print scaling options.

Changed the GUI as suggested by Nathan.

Dec 21 2018, 8:16 PM · Okular
sander added a comment to D16171: Move "erase drawing" action to last position and change its icon.

Thanks, fixed!

Dec 21 2018, 6:11 PM · Okular
sander committed R223:677fc767603b: Fix 'Erase Drawing' tooltip text (authored by sander).
Fix 'Erase Drawing' tooltip text
Dec 21 2018, 6:10 PM
sander added a comment to D16171: Move "erase drawing" action to last position and change its icon.

Thanks! And apologies for not actually merging this much earlier.

Dec 21 2018, 11:48 AM · Okular
sander committed R223:1547c7834029: Move "erase drawings" action to last position and change its icon (authored by simgunz).
Move "erase drawings" action to last position and change its icon
Dec 21 2018, 11:45 AM
sander closed D16171: Move "erase drawing" action to last position and change its icon.
Dec 21 2018, 11:45 AM · Okular

Dec 18 2018

sander added a comment to D7962: Implement several new print scaling options.

Yes and no. :-) I was ready to implement whatever you wish without any further arguments, but then I got sidetracked with other things. It is still in the back of my head, though. Let me see if I get around to implementing your GUI before the weekend.

Dec 18 2018, 2:52 PM · Okular

Nov 28 2018

sander accepted D16941: Fix inconsistent viewport positioning in PageView.
Nov 28 2018, 8:23 PM · Okular

Nov 26 2018

sander added a comment to D16941: Fix inconsistent viewport positioning in PageView.

Has anybody found some time yet to try the jump-to-page test?

Nov 26 2018, 11:56 AM · Okular

Nov 17 2018

sander added a comment to D16941: Fix inconsistent viewport positioning in PageView.

This looks like a definite improvement. It is still not perfect -- see my description at https://bugs.kde.org/show_bug.cgi?id=400890#c3 .

Nov 17 2018, 8:18 PM · Okular

Oct 19 2018

sander updated the diff for D7962: Implement several new print scaling options.

This new version of the diff adds tooltips to the new combo boxes. When the boxes are enabled, the tooltips hint at what they are good for. When the boxes are disabled, the tooltips tell how to enable them.

Oct 19 2018, 7:58 PM · Okular
sander added a comment to D7962: Implement several new print scaling options.

This is accurate.

Oct 19 2018, 7:54 PM · Okular

Oct 9 2018

sander added a comment to D7962: Implement several new print scaling options.

ScaleMode:

  • None: Do not apply scaling at all
  • FitToPage: Scale the page to be printed such that it fits the target area as good as possible, without changing the aspect ratio
  • ShrinkToPage: Like FitToPage, but only scale down.
Oct 9 2018, 3:27 AM · Okular

Oct 8 2018

sander added a comment to D7962: Implement several new print scaling options.

Is there a good UI reason to force users to manually click "force rasterization", or is it just technical difficulty?

Oct 8 2018, 8:16 PM · Okular

Oct 7 2018

sander added a comment to D15205: Support setting text color for typewriter annotations.

I think so.

Oct 7 2018, 8:02 PM · Documentation, Okular

Oct 3 2018

sander accepted D15205: Support setting text color for typewriter annotations.
Oct 3 2018, 8:55 AM · Documentation, Okular
sander added a comment to D15205: Support setting text color for typewriter annotations.

I now actually tested and it works very nicely. I'll approve the diff, because I don't have a strong opinion on the whitespace issue.

Oct 3 2018, 8:54 AM · Documentation, Okular

Oct 2 2018

sander added inline comments to D15205: Support setting text color for typewriter annotations.
Oct 2 2018, 7:14 PM · Documentation, Okular

Oct 1 2018

sander added a comment to D12098: Resize content area to correct dimensions after zooming to Auto Fit.

I can indeed get the UI to freeze by zooming in a lot and then enabling Auto Fit. The patch fixes this for me, but to be honest I don't understand the code well enough whether the diff fixes the problem in the most appropriate way.

Oct 1 2018, 9:28 AM · Okular
sander added a comment to D15205: Support setting text color for typewriter annotations.

Are you sure you rebased this on the current master? The diff still seems to contain D15204 , which has already been pushed.

Oct 1 2018, 9:02 AM · Documentation, Okular

Sep 25 2018

sander added a comment to D15204: Add typewriter annotation tool.

AFAIK for the manual you simply have to update doc/index.docbook.

Sep 25 2018, 3:03 PM · Okular
sander accepted D15204: Add typewriter annotation tool.
Sep 25 2018, 2:22 PM · Okular

Sep 24 2018

sander added a comment to D7962: Implement several new print scaling options.

because gating these scaling options behind Force rasterization is not very user friendly

Sep 24 2018, 4:23 AM · Okular

Sep 23 2018

sander updated the diff for D7962: Implement several new print scaling options.

I updated the diff. Apologies for the last version---it was really messed up.

Sep 23 2018, 1:42 PM · Okular

Sep 21 2018

sander added a comment to D9336: Change default mouse mode to TextSelect.

Doesn't this make Okular much less touch-friendly by default?

Sep 21 2018, 9:02 AM · Okular

Sep 20 2018

sander added a comment to D7962: Implement several new print scaling options.

Sorry for the delay, I have been wanting to fix this for quite a while now. Now that you nudge me about it I'll promise to update the patch before the end of the weekend.

Sep 20 2018, 8:56 PM · Okular

Sep 18 2018

sander added a comment to D15204: Add typewriter annotation tool.

Code is looking good to me. I tested it and couldn't find any problems.

Sep 18 2018, 4:02 PM · Okular

Sep 12 2018

sander committed R223:b763bdba7aae: Simplify memory management of two private data members (authored by sander).
Simplify memory management of two private data members
Sep 12 2018, 12:18 PM
sander closed D15301: Use std::unique_ptr for two private data members.
Sep 12 2018, 12:18 PM · Okular

Sep 10 2018

sander added inline comments to D15301: Use std::unique_ptr for two private data members.
Sep 10 2018, 7:44 PM · Okular

Sep 7 2018

sander accepted D15279: Store all annotation color attributes as ARGB string.

Okay, my difficulties in reproducing the described behavior are explained now: I had an old file okularpartrc in .kde/share/config/, and the Kdelibs4ConfigMigrator kept migrating from that old file every time is started Okular without an okularpartrc. With that old file removed everything works as intended.

Sep 7 2018, 10:45 AM · Okular

Sep 6 2018

sander added a comment to D15279: Store all annotation color attributes as ARGB string.

It really does take the file tools.xml from my development installation (tested with strace). Indeed, I deliberately purged my distro's okular from my computer a while ago, to avoid confusions like this.

Sep 6 2018, 8:12 PM · Okular
sander added a comment to D15279: Store all annotation color attributes as ARGB string.

When is your new okularpartrc created exactly? Afaikt, it should not be created right on startup, but only when you modify some tool in the config dialog.

Sep 6 2018, 4:02 PM · Okular
sander updated the diff for D15301: Use std::unique_ptr for two private data members.

You are right about QPixmap. The updated diff now uses a QPixmap object directly.

Sep 6 2018, 3:37 PM · Okular

Sep 5 2018

sander requested review of D15301: Use std::unique_ptr for two private data members.
Sep 5 2018, 7:19 PM · Okular
sander added a comment to D15279: Store all annotation color attributes as ARGB string.

I cannot reproduce Part 1 of your test plan. When I delete my okularpartrc and start Okular (with the patch), then the freshly created okularpartrc file contains all colors as RGB, not ARGB. This doesn't seem to have any negative consequences, however.

Sep 5 2018, 7:05 PM · Okular

Sep 4 2018

sander added inline comments to D15205: Support setting text color for typewriter annotations.
Sep 4 2018, 1:35 PM · Documentation, Okular
sander added a comment to D15204: Add typewriter annotation tool.

Would it a good idea to split those changes that deal with the color alpha channel into a separate patch? That would make reviewing easier, and lead to more legible git history.

Sep 4 2018, 1:32 PM · Okular

Aug 30 2018

sander committed R223:81ac73fcf5ce: Show tooltips when hovering over links in mouse selection modes as well. (authored by sander).
Show tooltips when hovering over links in mouse selection modes as well.
Aug 30 2018, 12:21 PM
sander closed D15123: Show tooltips when hovering over links regardless of which mouse tool is currently selected.
Aug 30 2018, 12:21 PM · Okular

Aug 29 2018

sander updated the diff for D15123: Show tooltips when hovering over links regardless of which mouse tool is currently selected.

The updates diff makes the tooltips appear in the modes "Browse", "Selection", "Text selection", "Trim selection". These are the ones where the cursor changes to a hand when hovering over a link.

Aug 29 2018, 11:36 AM · Okular

Aug 28 2018

sander requested review of D15123: Show tooltips when hovering over links regardless of which mouse tool is currently selected.
Aug 28 2018, 1:20 PM · Okular

Aug 27 2018

sander abandoned D15027: Show tooltips for links only if "Show hints..." is enabled in the preferences.
I see. So there is simply no option to disable the tooltips?

No, why would you want to disable them?

Aug 27 2018, 7:14 AM · Okular

Aug 26 2018

sander committed R223:61c2c2ceddc0: TOC: Add collapse/expand options (authored by Lekensteyn).
TOC: Add collapse/expand options
Aug 26 2018, 1:00 PM
sander closed D14904: TOC: Add collapse/expand options.
Aug 26 2018, 1:00 PM · Okular

Aug 24 2018

sander added a comment to D13203: Add Typewriter annotation tool in Okular.

Sounds like a good idea to me.

Aug 24 2018, 7:55 AM · Okular
sander added a comment to D15027: Show tooltips for links only if "Show hints..." is enabled in the preferences.

Wow, I have never noticed that tiny 'welcome' window until now...

Aug 24 2018, 3:43 AM · Okular
sander added a comment to D15027: Show tooltips for links only if "Show hints..." is enabled in the preferences.

I see. So there is simply no option to disable the tooltips? And what does OSD mean anyway?

Aug 24 2018, 3:39 AM · Okular

Aug 23 2018

sander requested review of D15027: Show tooltips for links only if "Show hints..." is enabled in the preferences.
Aug 23 2018, 7:49 PM · Okular