sander (Oliver Sander)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Jun 19 2017, 12:29 PM (100 w, 6 d)
Availability
Available

Recent Activity

Thu, May 23

sander added a comment to D21320: Fix build with poppler < 0.51.

My error. Apologies!

Thu, May 23, 4:42 AM · Okular

Wed, May 22

sander accepted D21320: Fix build with poppler < 0.51.
Wed, May 22, 8:37 AM · Okular

Tue, May 21

sander added inline comments to D21248: Add line annotation ending arrows for non PDF documents.
Tue, May 21, 8:25 AM · Okular

Fri, May 17

sander added a comment to D21248: Add line annotation ending arrows for non PDF documents.

Is there an existing class for affien matrix operations?

Fri, May 17, 4:39 AM · Okular

Thu, May 16

sander added inline comments to D21202: [WIP] Support animated PDF.
Thu, May 16, 12:50 PM · Okular
sander added inline comments to D21202: [WIP] Support animated PDF.
Thu, May 16, 4:53 AM · Okular

Tue, May 14

sander added a comment to D21092: Okular Annotation: use the new signal-slot connect syntax.

I'm afraid we'll have similar objections to the endStyle, though, specifically “PDF only” — would that be okay?

Tue, May 14, 11:25 AM · Okular
sander accepted D21136: Fix line annotation leader line angle.
Tue, May 14, 10:02 AM · Okular
sander added inline comments to D21202: [WIP] Support animated PDF.
Tue, May 14, 3:56 AM · Okular

Thu, May 9

sander committed R223:9791d2591689: Improve documentation of Document::setPageTextSelection() (authored by davidhurka).
Improve documentation of Document::setPageTextSelection()
Thu, May 9, 8:50 AM
sander closed D21069: [RFC] Improve documentation of Document::setPageTextSelection().
Thu, May 9, 8:50 AM · Okular

Tue, May 7

sander added a comment to D20760: Okular Annotation: add support for line ending style for Straight Line tool.

I committed the patch, but without any icons at all. Even without them I think the patch is very helpful. The icons can now be added at ease in a separate patch.

Tue, May 7, 9:10 AM · Okular
sander committed R223:db2dcdade399: Okular Annotation: add support for line ending style for Straight Line tool (authored by knambiar).
Okular Annotation: add support for line ending style for Straight Line tool
Tue, May 7, 9:07 AM
sander closed D20760: Okular Annotation: add support for line ending style for Straight Line tool.
Tue, May 7, 9:07 AM · Okular

Mon, May 6

sander added a comment to D20760: Okular Annotation: add support for line ending style for Straight Line tool.

I think it should. But not in this patch.

Mon, May 6, 4:24 AM · Okular

Sun, May 5

sander added a comment to D20760: Okular Annotation: add support for line ending style for Straight Line tool.

At least squares and diamonds are incorrect, too.

Sun, May 5, 8:54 PM · Okular
sander added a comment to D20760: Okular Annotation: add support for line ending style for Straight Line tool.

I tried the circle line endings and they look a bit strange to me:

Sun, May 5, 7:45 PM · Okular

Sat, May 4

sander accepted D20760: Okular Annotation: add support for line ending style for Straight Line tool.
Sat, May 4, 7:43 PM · Okular
sander added a comment to D20760: Okular Annotation: add support for line ending style for Straight Line tool.

Thanks! Will commit on tuesday, if nowbody objects.

Sat, May 4, 7:43 PM · Okular

Thu, May 2

sander added a comment to D20760: Okular Annotation: add support for line ending style for Straight Line tool.

I'd advocate to implement drawing the lines by code, i.e. QPainter::drawLine and friends. Then reuse the same code to draw icons.

Thu, May 2, 8:49 PM · Okular

Apr 11 2019

sander accepted D20437: Make selection scrolling go at 60 fps.
Apr 11 2019, 3:12 PM · Okular
sander added a comment to D20437: Make selection scrolling go at 60 fps.

Thanks! I am happy with these comments (except maybe that people may read the "/ 60 fps" in line 3770 as a division).

Apr 11 2019, 3:11 PM · Okular
sander added a comment to D20437: Make selection scrolling go at 60 fps.

Hi Kezi, I don't have a good answer to all that, I am just a bit distrustful regarding hard-coded constants like '6'. But I acknowledge that there are situations where they cannot be avoided.

Apr 11 2019, 2:49 PM · Okular
sander added a comment to D20437: Make selection scrolling go at 60 fps.

How did you determine the value of the damping variable? You write

Apr 11 2019, 2:28 PM · Okular

Apr 9 2019

sander added a comment to D20351: Improve Legibility of preview of rectangle annotation.

Consider splitting the color change into a separate patch. That part seems to be uncontroversial.

Apr 9 2019, 12:53 PM · Okular
sander added a comment to D20351: Improve Legibility of preview of rectangle annotation.

I like the color part of this patch.

Apr 9 2019, 8:22 AM · Okular

Apr 2 2019

sander updated the diff for D20194: Fix a typo.

Changed Mac OS X to macOS everywhere.

Apr 2 2019, 7:29 PM · Okular
sander requested review of D20194: Fix a typo.
Apr 2 2019, 4:22 AM · Okular

Apr 1 2019

sander added a comment to D20165: Mention Windows nightly builds at binary-factory.kde.org.

It seems that I cannot write to this repository (I could only clone the anonymous git). Do I need extra rights? Can somebody push the patch for me?

Apr 1 2019, 2:41 PM · Okular
sander requested review of D20165: Mention Windows nightly builds at binary-factory.kde.org.
Apr 1 2019, 12:26 PM · Okular

Mar 26 2019

sander added a comment to D19702: Page changes triggered by mouse clicks should all happen on button release.

Is this okay now?

Mar 26 2019, 5:45 AM · Okular

Mar 24 2019

sander added a comment to D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet.

I do use my stylus for drawing on slides in presentation mode. I am not particularly happy with the quality of that, but compressing tablet events doesn't seem to make it worse. So no objections from my side.

Mar 24 2019, 5:21 PM · Okular
sander added a comment to D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet.

I tried this on my ThinkPad Yoga 12, which comes with a stylus to write on the screen with. I confirm that this patch noticeably improves the scrolling behavior when using the stylus for scrolling.

Mar 24 2019, 4:03 PM · Okular

Mar 16 2019

sander added a comment to D13901: Touch support for Gwenview.

Thanks for the patch. How is the gesture code going to get into KWidgetAddons now?

Mar 16 2019, 2:44 PM · Gwenview

Mar 15 2019

sander updated the diff for D19702: Page changes triggered by mouse clicks should all happen on button release.

Updated the comment

Mar 15 2019, 1:53 PM · Okular
sander updated the diff for D19539: Replace some iterator loops by range-based for.

Removed those four aAsConst again.

Mar 15 2019, 8:53 AM · Okular

Mar 12 2019

sander requested review of D19702: Page changes triggered by mouse clicks should all happen on button release.
Mar 12 2019, 10:08 AM · Okular
sander added a comment to D19539: Replace some iterator loops by range-based for.

Albert, is this okay now?

Mar 12 2019, 9:28 AM · Okular

Mar 11 2019

sander committed R223:50bfd9fe8645: Presentation: optionally go to prev. page when touching left half of the page (authored by sander).
Presentation: optionally go to prev. page when touching left half of the page
Mar 11 2019, 8:13 PM
sander closed D18118: Presentation mode: go to previous page when left-clicking on left half of the page.
Mar 11 2019, 8:13 PM · Okular
sander updated the diff for D18118: Presentation mode: go to previous page when left-clicking on left half of the page.
  • 'sides' --> 'side'
  • updated old comment
Mar 11 2019, 8:11 PM · Okular
sander updated the test plan for D18118: Presentation mode: go to previous page when left-clicking on left half of the page.
Mar 11 2019, 8:01 PM · Okular

Mar 7 2019

sander added a comment to D18118: Presentation mode: go to previous page when left-clicking on left half of the page.

Albert, is this okay for you now?

Mar 7 2019, 7:07 PM · Okular
sander updated the diff for D19539: Replace some iterator loops by range-based for.

Ugly; didn't know about 'hidden detaches'.

Mar 7 2019, 6:23 PM · Okular

Mar 6 2019

sander updated the diff for D18118: Presentation mode: go to previous page when left-clicking on left half of the page.

UI reworded following Nate's suggestions

Mar 6 2019, 4:30 PM · Okular
sander updated the diff for D19539: Replace some iterator loops by range-based for.
  • Do not use auto in range-based for
  • Use qDeleteAll where appropriate
Mar 6 2019, 4:27 PM · Okular
sander added a comment to D18118: Presentation mode: go to previous page when left-clicking on left half of the page.

What is the behavior of the mouse buttons? In other words can the left mouse button make it go forward without being anywhere on the screen, and the right button make if go backwards.

Mar 6 2019, 5:22 AM · Okular

Mar 5 2019

sander added a comment to D18118: Presentation mode: go to previous page when left-clicking on left half of the page.

That's the current behavior, ...

Mar 5 2019, 8:21 PM · Okular
sander added a comment to D18118: Presentation mode: go to previous page when left-clicking on left half of the page.

That's the current behavior, only with different UI text, right? That's fine with me. I will provide an updated patch within the next few days.

Mar 5 2019, 8:17 PM · Okular
sander added a comment to D18118: Presentation mode: go to previous page when left-clicking on left half of the page.

If I understand Albert correctly he wants to have the current behavior as an option. Your proposal does not offer that, does it?

Mar 5 2019, 8:04 PM · Okular
sander added a comment to D19539: Replace some iterator loops by range-based for.

Fine with me, too. If somebody is in favour of auto, please say so now. Otherwise I will remove the autos from the patch.

Mar 5 2019, 7:38 PM · Okular
sander added a comment to D18118: Presentation mode: go to previous page when left-clicking on left half of the page.

Not sure I fully understand your proposal. What happens if I uncheck the first option, check the second one, and then tap on the left half of the screen?

Mar 5 2019, 7:36 PM · Okular
sander added a comment to D19539: Replace some iterator loops by range-based for.

You may want to read up on range-based for; it is very helpful. In such a for-loop, auto always means "the type of a container entry".

Mar 5 2019, 1:23 PM · Okular
sander updated the diff for D18118: Presentation mode: go to previous page when left-clicking on left half of the page.

Make the new touch screen behavior optional. There are three choices now in 'preferences->presentation':

Mar 5 2019, 11:37 AM · Okular
sander requested review of D19539: Replace some iterator loops by range-based for.
Mar 5 2019, 11:03 AM · Okular

Jan 12 2019

sander added a comment to D18118: Presentation mode: go to previous page when left-clicking on left half of the page.

Guys, stop fighting. I'll make it optional in the next patch upload, all I need is a bit of time.

Jan 12 2019, 6:13 PM · Okular

Jan 11 2019

sander updated the diff for D18118: Presentation mode: go to previous page when left-clicking on left half of the page.

New patch version:

  • You can go back by touching on the left half of a touchscreen, touching the right half will go forward
  • Mouse behavior is unchanged---left-clicking anywhere on the screen will go forward.
Jan 11 2019, 8:04 PM · Okular
sander added a comment to D18118: Presentation mode: go to previous page when left-clicking on left half of the page.
It's interesting that swiping down from the top with a single finger brings out the menu' so there does seem to be the potential of single finger swiping.
Jan 11 2019, 7:59 PM · Okular
sander added a comment to D18118: Presentation mode: go to previous page when left-clicking on left half of the page.

I think that swiping is a separate issue. One-finger swipes should actually be easy to implement as the difficult part already exists in the Gwenview patch mentioned above. And we probably all agree that one-finger swipes are better than three-finger ones.

Jan 11 2019, 9:04 AM · Okular
sander added a comment to D18118: Presentation mode: go to previous page when left-clicking on left half of the page.

I'd also prefer to leave the current behaviour of a left-click as it is

Jan 11 2019, 8:22 AM · Okular

Jan 9 2019

sander added a comment to D13901: Touch support for Gwenview.

Some of these gesture recognizers would be very helpful in other KDE programs as well (Okular is what I have in mind). Can they be moved to some central place where both Gwenview and Okular can use them?

Jan 9 2019, 10:34 AM · Gwenview
sander added a comment to D7949: Allow to print pdf doc directly into a QPrinter.

There's a GitHub project at https://github.com/giddie/poppler-cairo-backend , but from how I read the related bug report, upstream integration is very unlikely.

Jan 9 2019, 10:00 AM · Okular
sander added a comment to D18118: Presentation mode: go to previous page when left-clicking on left half of the page.

Actually, the necessary gesture recognizer exists, as part of a GwenView patch: https://phabricator.kde.org/D13901 . If that code was accessible from Okular, moving to one-finger swipes would be trivial.

Jan 9 2019, 5:38 AM · Okular

Jan 8 2019

sander added a comment to D18118: Presentation mode: go to previous page when left-clicking on left half of the page.

That's the standard Qt swipe gesture. Anything else would require writing your own gesture recognizer.

Jan 8 2019, 10:02 PM · Okular
sander added a comment to D18118: Presentation mode: go to previous page when left-clicking on left half of the page.

Changing pages by swiping on a touchscreen works already (Qt requires you to swipe with three(!) fingers, though). But if I were a piano player using Okular to show me the music sheets I'd rather not swipe for fear of smashing the entire screen off the piano.

Jan 8 2019, 9:42 PM · Okular
sander added a comment to D18118: Presentation mode: go to previous page when left-clicking on left half of the page.

How about we let the new behavior apply only to touch events, and leave the mouse handling as it is?

Jan 8 2019, 9:24 PM · Okular
sander updated the summary of D18118: Presentation mode: go to previous page when left-clicking on left half of the page.
Jan 8 2019, 9:19 PM · Okular
sander requested review of D18118: Presentation mode: go to previous page when left-clicking on left half of the page.
Jan 8 2019, 8:40 PM · Okular

Jan 7 2019

sander added a comment to D7949: Allow to print pdf doc directly into a QPrinter.

The quality of the Arthur backend really depends on what you use it for. For example, I personally mostly use Okular for scientific articles and presentations, and Arthur works almost perfectly for that. But for other types of documents, however, the situation may be different. Only Albert and his test suite know. :-)

Jan 7 2019, 11:21 AM · Okular

Jan 4 2019

sander added a comment to D17929: Hide cursor when tablet stylus leaves proximity of the screen.

Didn't we have this discussion millions of years ago?

Jan 4 2019, 11:01 AM · Okular

Jan 3 2019

sander updated the diff for D17929: Hide cursor when tablet stylus leaves proximity of the screen.

Whitespace fixes

Jan 3 2019, 10:30 AM · Okular
sander added inline comments to D17929: Hide cursor when tablet stylus leaves proximity of the screen.
Jan 3 2019, 10:26 AM · Okular

Jan 2 2019

sander added a comment to D17929: Hide cursor when tablet stylus leaves proximity of the screen.

Coding style: Opening curly braces go on the same line of the if statement.

Jan 2 2019, 8:45 PM · Okular
sander requested review of D17929: Hide cursor when tablet stylus leaves proximity of the screen.
Jan 2 2019, 8:33 PM · Okular

Dec 30 2018

sander added a comment to D7949: Allow to print pdf doc directly into a QPrinter.

Where are we at with this? What are the blockers to landing it?

Dec 30 2018, 4:08 PM · Okular
sander updated the diff for D7949: Allow to print pdf doc directly into a QPrinter.

Rebased to current master, and connected the code to the new print scaling modes.

Dec 30 2018, 4:02 PM · Okular
sander committed R223:a4735e428a33: Use more std::unique_ptr (authored by sander).
Use more std::unique_ptr
Dec 30 2018, 3:55 PM

Dec 23 2018

sander added a comment to D7962: Implement several new print scaling options.

Thanks for testing!

Dec 23 2018, 1:27 AM · Okular
sander committed R223:2e97d587508d: Implement several new print scaling options (authored by sander).
Implement several new print scaling options
Dec 23 2018, 1:26 AM
sander closed D7962: Implement several new print scaling options.
Dec 23 2018, 1:26 AM · Okular

Dec 22 2018

sander added a comment to D7962: Implement several new print scaling options.

The patch here does not depend on D7949 anymore. It should fit directly onto the current master. D7949 does indeed need rebasing, which I will do as soon as this patch here has its final form.

Dec 22 2018, 5:45 AM · Okular
sander updated the summary of D7962: Implement several new print scaling options.
Dec 22 2018, 5:44 AM · Okular

Dec 21 2018

sander updated the diff for D7962: Implement several new print scaling options.

Changed the GUI as suggested by Nathan.

Dec 21 2018, 8:16 PM · Okular
sander added a comment to D16171: Move "erase drawing" action to last position and change its icon.

Thanks, fixed!

Dec 21 2018, 6:11 PM · Okular
sander committed R223:677fc767603b: Fix 'Erase Drawing' tooltip text (authored by sander).
Fix 'Erase Drawing' tooltip text
Dec 21 2018, 6:10 PM
sander added a comment to D16171: Move "erase drawing" action to last position and change its icon.

Thanks! And apologies for not actually merging this much earlier.

Dec 21 2018, 11:48 AM · Okular
sander committed R223:1547c7834029: Move "erase drawings" action to last position and change its icon (authored by simgunz).
Move "erase drawings" action to last position and change its icon
Dec 21 2018, 11:45 AM
sander closed D16171: Move "erase drawing" action to last position and change its icon.
Dec 21 2018, 11:45 AM · Okular

Dec 18 2018

sander added a comment to D7962: Implement several new print scaling options.

Yes and no. :-) I was ready to implement whatever you wish without any further arguments, but then I got sidetracked with other things. It is still in the back of my head, though. Let me see if I get around to implementing your GUI before the weekend.

Dec 18 2018, 2:52 PM · Okular

Nov 28 2018

sander accepted D16941: Fix inconsistent viewport positioning in PageView.
Nov 28 2018, 8:23 PM · Okular

Nov 26 2018

sander added a comment to D16941: Fix inconsistent viewport positioning in PageView.

Has anybody found some time yet to try the jump-to-page test?

Nov 26 2018, 11:56 AM · Okular

Nov 17 2018

sander added a comment to D16941: Fix inconsistent viewport positioning in PageView.

This looks like a definite improvement. It is still not perfect -- see my description at https://bugs.kde.org/show_bug.cgi?id=400890#c3 .

Nov 17 2018, 8:18 PM · Okular

Oct 19 2018

sander updated the diff for D7962: Implement several new print scaling options.

This new version of the diff adds tooltips to the new combo boxes. When the boxes are enabled, the tooltips hint at what they are good for. When the boxes are disabled, the tooltips tell how to enable them.

Oct 19 2018, 7:58 PM · Okular
sander added a comment to D7962: Implement several new print scaling options.

This is accurate.

Oct 19 2018, 7:54 PM · Okular

Oct 9 2018

sander added a comment to D7962: Implement several new print scaling options.

ScaleMode:

  • None: Do not apply scaling at all
  • FitToPage: Scale the page to be printed such that it fits the target area as good as possible, without changing the aspect ratio
  • ShrinkToPage: Like FitToPage, but only scale down.
Oct 9 2018, 3:27 AM · Okular

Oct 8 2018

sander added a comment to D7962: Implement several new print scaling options.

Is there a good UI reason to force users to manually click "force rasterization", or is it just technical difficulty?

Oct 8 2018, 8:16 PM · Okular

Oct 7 2018

sander added a comment to D15205: Support setting text color for typewriter annotations.

I think so.

Oct 7 2018, 8:02 PM · Documentation, Okular

Oct 3 2018

sander accepted D15205: Support setting text color for typewriter annotations.
Oct 3 2018, 8:55 AM · Documentation, Okular
sander added a comment to D15205: Support setting text color for typewriter annotations.

I now actually tested and it works very nicely. I'll approve the diff, because I don't have a strong opinion on the whitespace issue.

Oct 3 2018, 8:54 AM · Documentation, Okular

Oct 2 2018

sander added inline comments to D15205: Support setting text color for typewriter annotations.
Oct 2 2018, 7:14 PM · Documentation, Okular