sander (Oliver Sander)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jun 19 2017, 12:29 PM (129 w, 2 d)
Availability
Available

Recent Activity

Wed, Dec 4

sander committed R223:30e5a492edd6: Use more 'nullptr' instead of '0' (authored by sander).
Use more 'nullptr' instead of '0'
Wed, Dec 4, 9:47 AM
sander committed R223:3b7bfb2e17ae: Use std::unique_ptr for several FormField objects (authored by sander).
Use std::unique_ptr for several FormField objects
Wed, Dec 4, 9:47 AM
sander committed R223:dc7f2dffc130: Fix a typo (authored by sander).
Fix a typo
Wed, Dec 4, 9:47 AM

Sun, Nov 17

sander committed R223:8d6c16e2a302: Remove unused include (authored by nicolasfella).
Remove unused include
Sun, Nov 17, 7:14 PM

Fri, Nov 15

sander committed R223:51b90ecd73e3: Add kinetic scrolling & smooth navigation with cursor keys (authored by kezik).
Add kinetic scrolling & smooth navigation with cursor keys
Fri, Nov 15, 4:08 PM

Nov 1 2019

sander committed R223:92b7703292ab: AnnotWindow: Always show creation time in local time (authored by sander).
AnnotWindow: Always show creation time in local time
Nov 1 2019, 1:24 PM

Oct 29 2019

sander committed R223:2a8721c221b2: Add typewriter autotests (authored by tobiasdeiminger).
Add typewriter autotests
Oct 29 2019, 8:13 PM

Oct 28 2019

sander added a comment to D13588: Add test for field number formatting.

@aacid , do you have the power to close this?

Oct 28 2019, 8:12 PM · Okular
sander committed R223:45fd8d5dddd8: Merge branch 'arcpatch-D15348' of invent.kde.org:sander/okular into arcpatch… (authored by sander).
Merge branch 'arcpatch-D15348' of invent.kde.org:sander/okular into arcpatch…
Oct 28 2019, 4:34 PM
sander committed R223:9bdecc94e4c5: Fix testTypewriterAnnotTool (authored by sander).
Fix testTypewriterAnnotTool
Oct 28 2019, 4:34 PM
sander committed R223:32feef1046a5: Add typewriter autotests (authored by tobiasdeiminger).
Add typewriter autotests
Oct 28 2019, 4:34 PM
sander committed R223:c3f5d4a50200: Remove unneeded mouseMove (authored by sander).
Remove unneeded mouseMove
Oct 28 2019, 4:34 PM
sander committed R223:614866115812: Fix testTypewriterAnnotTool (authored by sander).
Fix testTypewriterAnnotTool
Oct 28 2019, 4:34 PM
sander committed R223:e41688a538b2: Add typewriter autotests (authored by tobiasdeiminger).
Add typewriter autotests
Oct 28 2019, 4:34 PM
sander committed R223:49c5840e209a: Remove unneeded mouseMove (authored by sander).
Remove unneeded mouseMove
Oct 28 2019, 4:22 PM
sander committed R223:9271fb1d41dd: Fix testTypewriterAnnotTool (authored by sander).
Fix testTypewriterAnnotTool
Oct 28 2019, 4:22 PM
sander committed R223:8315b72d2735: Add typewriter autotests (authored by tobiasdeiminger).
Add typewriter autotests
Oct 28 2019, 4:22 PM
sander closed D15348: Add typewriter autotests.
Oct 28 2019, 4:22 PM · Okular

Oct 16 2019

sander added a comment to D13588: Add test for field number formatting.

Just to be sure: you are recommending to discard this diff, and to discard also https://invent.kde.org/kde/okular/merge_requests/47 ?

Oct 16 2019, 8:09 AM · Okular

Oct 9 2019

sander committed R223:ef52350f7db3: When tts engine is changed via okular settings recreate tts object. (authored by whiting).
When tts engine is changed via okular settings recreate tts object.
Oct 9 2019, 7:48 AM
sander committed R223:67e7dc8f4cca: Fix building okular without QTextToSpeech by adding ifdefs. (authored by whiting).
Fix building okular without QTextToSpeech by adding ifdefs.
Oct 9 2019, 7:48 AM
sander committed R223:3b9e9fb695b8: Only enable Pause or Resume when speaking or paused. (authored by whiting).
Only enable Pause or Resume when speaking or paused.
Oct 9 2019, 7:48 AM
sander committed R223:1b3bb0147861: Add user okular user setting for which QtSpeech engine to use. (authored by whiting).
Add user okular user setting for which QtSpeech engine to use.
Oct 9 2019, 7:48 AM
sander committed R223:48633374a94e: Add Pause/Resume action for pausing and resuming speech synthesis. (authored by whiting).
Add Pause/Resume action for pausing and resuming speech synthesis.
Oct 9 2019, 7:48 AM

Oct 8 2019

sander added a comment to D13588: Add test for field number formatting.

The tests do not pass. @aheinecke , do you have an idea? Could you abandon this revision and we continue discussion on gitlab?

Oct 8 2019, 8:06 AM · Okular

Oct 4 2019

sander added a comment to D13588: Add test for field number formatting.

Let's see what the CI says:

Oct 4 2019, 9:33 AM · Okular

Oct 2 2019

sander committed R223:2bd6f736c4d4: Test whether 'continuous' view mode is saved per file (authored by sander).
Test whether 'continuous' view mode is saved per file
Oct 2 2019, 1:35 PM
sander committed R223:8611cd775a22: Add @since markers for the new ViewCapability values (authored by sander).
Add @since markers for the new ViewCapability values
Oct 2 2019, 1:35 PM
sander committed R223:425a6aa4130c: Simplify a loop (authored by sander).
Simplify a loop
Oct 2 2019, 1:35 PM
sander committed R223:8839ea1088ca: Fix return value of PageView::capabilityFlags (authored by sander).
Fix return value of PageView::capabilityFlags
Oct 2 2019, 1:35 PM
sander committed R223:bd25d17e704e: Save view information per file (authored by Felix Mauch <felix_mauch@web.de>).
Save view information per file
Oct 2 2019, 1:34 PM
sander added a comment to D13588: Add test for field number formatting.

Any reason not to commit this now that https://phabricator.kde.org/D13171 is in?

Oct 2 2019, 1:31 PM · Okular

Sep 30 2019

sander added a comment to D24102: Add Pause/Resume action for pausing and resuming speech synthesis..

Sorry for being a pain, but your patch contains lots of whitespace changes again (in conf/dlgaccessibilitybase.ui). I agree that you probably do want them changed, but please do so in a separate patch.

Sep 30 2019, 3:17 PM · Okular

Sep 20 2019

sander added inline comments to D24102: Add Pause/Resume action for pausing and resuming speech synthesis..
Sep 20 2019, 6:51 AM · Okular

Sep 12 2019

sander added a comment to D23911: Port SearchLineWidget to use KBusyIndicatorWidget.

The code looks promising, but I cannot test it because that kbusyindicatorwidget.h is so new it's not in my Debian yet. I am not sure we want to unconditionally depend on something so new.

Sep 12 2019, 6:27 PM · Okular

Jul 16 2019

sander added inline comments to D15347: Modify CloseDialogHelper in parttest.
Jul 16 2019, 10:50 AM · Okular
sander added a comment to D15347: Modify CloseDialogHelper in parttest.

Could you put a qInfo() << *e in PageViewAnnotator::routeMouseEvent while reproducing bug 409638, so that we're sure what kind of events cause the trouble?

Jul 16 2019, 8:13 AM · Okular
sander added a comment to D15347: Modify CloseDialogHelper in parttest.

In bug 409638 it's probably a TabletEnterProximity event instead.

Jul 16 2019, 4:07 AM · Okular

Jul 14 2019

sander added a comment to D15347: Modify CloseDialogHelper in parttest.

Agreed. I think the first step should be to write a unit test that triggers https://bugs.kde.org/show_bug.cgi?id=409638. That way we get a reproducible way to trigger the problem even for people without a stylus.

Jul 14 2019, 5:31 PM · Okular
sander added a comment to D15347: Modify CloseDialogHelper in parttest.

@tobiasdeiminger , that hidden bug you mention, could it be the cause of https://bugs.kde.org/show_bug.cgi?id=409638 ?

Jul 14 2019, 8:29 AM · Okular

Jul 5 2019

sander added a comment to D17929: Hide cursor when tablet stylus leaves proximity of the screen.

With the help of Tobias (thanks!) I wrote a unit test. You can find it at https://invent.kde.org/kde/okular/merge_requests/9 .

Jul 5 2019, 3:16 PM · Okular

Jul 1 2019

sander committed R223:dec6923c56a9: Make page boundary rendering more robust (authored by sander).
Make page boundary rendering more robust
Jul 1 2019, 12:16 PM
sander committed R223:d4a9eb92e836: Use range-based for to iterate over a QRegion (authored by sander).
Use range-based for to iterate over a QRegion
Jul 1 2019, 12:16 PM
sander committed R223:c73de7e6a193: Make page boundary rendering more robust (authored by sander).
Make page boundary rendering more robust
Jul 1 2019, 12:10 PM
sander committed R223:f350827e9d9e: Use range-based for to iterate over a QRegion (authored by sander).
Use range-based for to iterate over a QRegion
Jul 1 2019, 12:10 PM
sander committed R223:257fb879dd2f: WIP: Cross-hair cursor when stylus approaches screen (authored by sander).
WIP: Cross-hair cursor when stylus approaches screen
Jul 1 2019, 12:09 PM
sander committed R223:93178044ec45: WIP: Allow selecting drawing input devices (authored by sander).
WIP: Allow selecting drawing input devices
Jul 1 2019, 12:09 PM

Jun 25 2019

sander added a comment to D17929: Hide cursor when tablet stylus leaves proximity of the screen.

Albert, how much would a suitable pen cost you? I offer to give you one as donation if that would help you finish this patch.

Jun 25 2019, 7:52 AM · Okular

Jun 23 2019

sander added a comment to D17929: Hide cursor when tablet stylus leaves proximity of the screen.

I've been wondering whether it would be possible to write a unit test that sends out all the necessary events. That would allow to debug the problem without actually having the required hardware. Is that possible in principle?

Jun 23 2019, 7:58 PM · Okular
sander added a comment to D10859: Improve layout of annotation configuration dialogs.

I had the same problem yesterday and got around it by moving to https://invent.kde.org/kde/okular .

Jun 23 2019, 7:25 PM · Okular
sander added a comment to D17929: Hide cursor when tablet stylus leaves proximity of the screen.

Albert, David, thanks for looking into this -- the problem seems to be a beyond my skill level. My hardware is a Lenovo Thinkpad Yoga, as in http://www.notebookreview.com/notebookreview/lenovo-thinkpad-yoga-12-review/ . I am not a stylus expert, said review calls it a "Wacom active pen stylus". I didn't have to do anything special to get it detected.

Jun 23 2019, 6:57 PM · Okular

Jun 22 2019

sander closed D21836: Mind the devicePixelRatio when drawing on-screen in presentation mode.
Jun 22 2019, 7:56 PM · Okular
sander committed R223:19f22098e67d: Mind the devicePixelRatio when drawing on-screen in presentation mode (authored by sander).
Mind the devicePixelRatio when drawing on-screen in presentation mode
Jun 22 2019, 7:56 PM

Jun 20 2019

sander updated the diff for D21836: Mind the devicePixelRatio when drawing on-screen in presentation mode.
  • Use localPos instead of screenPos
  • Factor out intermediate Pixmap size computations
  • Use QPainterPath for smoother paths
Jun 20 2019, 4:30 PM · Okular
sander added inline comments to D21836: Mind the devicePixelRatio when drawing on-screen in presentation mode.
Jun 20 2019, 4:29 PM · Okular
sander added a comment to D21836: Mind the devicePixelRatio when drawing on-screen in presentation mode.

Path quality gets even better (slightly) if I replace the sequence of lines drawn by SmoothPathEngine with a QPainterPath. Do you prefer this change right here or in a separate patch on top?

Jun 20 2019, 8:20 AM · Okular
sander added reviewers for D21836: Mind the devicePixelRatio when drawing on-screen in presentation mode: ngraham, tobiasdeiminger.

Ping?

Jun 20 2019, 7:57 AM · Okular

Jun 15 2019

sander updated the summary of D21836: Mind the devicePixelRatio when drawing on-screen in presentation mode.
Jun 15 2019, 9:55 PM · Okular
sander requested review of D21836: Mind the devicePixelRatio when drawing on-screen in presentation mode.
Jun 15 2019, 9:54 PM · Okular

Jun 2 2019

sander added a comment to D21416: Add icons for line annotation arrow styles to combo box.

Does https://phabricator.kde.org/D21543 help?

Jun 2 2019, 7:49 PM · Okular

Jun 1 2019

sander accepted D21248: Add line annotation ending arrows for non PDF documents.
Jun 1 2019, 2:55 PM · Okular
sander accepted D21416: Add icons for line annotation arrow styles to combo box.
Jun 1 2019, 2:54 PM · Okular

May 23 2019

sander added a comment to D21320: Fix build with poppler < 0.51.

My error. Apologies!

May 23 2019, 4:42 AM · Okular

May 22 2019

sander accepted D21320: Fix build with poppler < 0.51.
May 22 2019, 8:37 AM · Okular

May 21 2019

sander added inline comments to D21248: Add line annotation ending arrows for non PDF documents.
May 21 2019, 8:25 AM · Okular

May 17 2019

sander added a comment to D21248: Add line annotation ending arrows for non PDF documents.

Is there an existing class for affien matrix operations?

May 17 2019, 4:39 AM · Okular

May 16 2019

sander added inline comments to D21202: [WIP] Support animated PDF.
May 16 2019, 12:50 PM · Okular
sander added inline comments to D21202: [WIP] Support animated PDF.
May 16 2019, 4:53 AM · Okular

May 14 2019

sander added a comment to D21092: Okular Annotation: use the new signal-slot connect syntax.

I'm afraid we'll have similar objections to the endStyle, though, specifically “PDF only” — would that be okay?

May 14 2019, 11:25 AM · Okular
sander accepted D21136: Fix line annotation leader line angle.
May 14 2019, 10:02 AM · Okular
sander added inline comments to D21202: [WIP] Support animated PDF.
May 14 2019, 3:56 AM · Okular

May 9 2019

sander committed R223:9791d2591689: Improve documentation of Document::setPageTextSelection() (authored by davidhurka).
Improve documentation of Document::setPageTextSelection()
May 9 2019, 8:50 AM
sander closed D21069: [RFC] Improve documentation of Document::setPageTextSelection().
May 9 2019, 8:50 AM · Okular

May 7 2019

sander added a comment to D20760: Okular Annotation: add support for line ending style for Straight Line tool.

I committed the patch, but without any icons at all. Even without them I think the patch is very helpful. The icons can now be added at ease in a separate patch.

May 7 2019, 9:10 AM · Okular
sander committed R223:db2dcdade399: Okular Annotation: add support for line ending style for Straight Line tool (authored by knambiar).
Okular Annotation: add support for line ending style for Straight Line tool
May 7 2019, 9:07 AM
sander closed D20760: Okular Annotation: add support for line ending style for Straight Line tool.
May 7 2019, 9:07 AM · Okular

May 6 2019

sander added a comment to D20760: Okular Annotation: add support for line ending style for Straight Line tool.

I think it should. But not in this patch.

May 6 2019, 4:24 AM · Okular

May 5 2019

sander added a comment to D20760: Okular Annotation: add support for line ending style for Straight Line tool.

At least squares and diamonds are incorrect, too.

May 5 2019, 8:54 PM · Okular
sander added a comment to D20760: Okular Annotation: add support for line ending style for Straight Line tool.

I tried the circle line endings and they look a bit strange to me:

May 5 2019, 7:45 PM · Okular

May 4 2019

sander accepted D20760: Okular Annotation: add support for line ending style for Straight Line tool.
May 4 2019, 7:43 PM · Okular
sander added a comment to D20760: Okular Annotation: add support for line ending style for Straight Line tool.

Thanks! Will commit on tuesday, if nowbody objects.

May 4 2019, 7:43 PM · Okular

May 2 2019

sander added a comment to D20760: Okular Annotation: add support for line ending style for Straight Line tool.

I'd advocate to implement drawing the lines by code, i.e. QPainter::drawLine and friends. Then reuse the same code to draw icons.

May 2 2019, 8:49 PM · Okular

Apr 11 2019

sander accepted D20437: Make selection scrolling go at 60 fps.
Apr 11 2019, 3:12 PM · Okular
sander added a comment to D20437: Make selection scrolling go at 60 fps.

Thanks! I am happy with these comments (except maybe that people may read the "/ 60 fps" in line 3770 as a division).

Apr 11 2019, 3:11 PM · Okular
sander added a comment to D20437: Make selection scrolling go at 60 fps.

Hi Kezi, I don't have a good answer to all that, I am just a bit distrustful regarding hard-coded constants like '6'. But I acknowledge that there are situations where they cannot be avoided.

Apr 11 2019, 2:49 PM · Okular
sander added a comment to D20437: Make selection scrolling go at 60 fps.

How did you determine the value of the damping variable? You write

Apr 11 2019, 2:28 PM · Okular

Apr 9 2019

sander added a comment to D20351: Improve Legibility of preview of rectangle annotation.

Consider splitting the color change into a separate patch. That part seems to be uncontroversial.

Apr 9 2019, 12:53 PM · Okular
sander added a comment to D20351: Improve Legibility of preview of rectangle annotation.

I like the color part of this patch.

Apr 9 2019, 8:22 AM · Okular

Apr 2 2019

sander updated the diff for D20194: Fix a typo.

Changed Mac OS X to macOS everywhere.

Apr 2 2019, 7:29 PM · Okular
sander requested review of D20194: Fix a typo.
Apr 2 2019, 4:22 AM · Okular

Apr 1 2019

sander added a comment to D20165: Mention Windows nightly builds at binary-factory.kde.org.

It seems that I cannot write to this repository (I could only clone the anonymous git). Do I need extra rights? Can somebody push the patch for me?

Apr 1 2019, 2:41 PM · Okular
sander requested review of D20165: Mention Windows nightly builds at binary-factory.kde.org.
Apr 1 2019, 12:26 PM · Okular

Mar 26 2019

sander added a comment to D19702: Page changes triggered by mouse clicks should all happen on button release.

Is this okay now?

Mar 26 2019, 5:45 AM · Okular

Mar 24 2019

sander added a comment to D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet.

I do use my stylus for drawing on slides in presentation mode. I am not particularly happy with the quality of that, but compressing tablet events doesn't seem to make it worse. So no objections from my side.

Mar 24 2019, 5:21 PM · Okular
sander added a comment to D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet.

I tried this on my ThinkPad Yoga 12, which comes with a stylus to write on the screen with. I confirm that this patch noticeably improves the scrolling behavior when using the stylus for scrolling.

Mar 24 2019, 4:03 PM · Okular

Mar 16 2019

sander added a comment to D13901: Touch support for Gwenview.

Thanks for the patch. How is the gesture code going to get into KWidgetAddons now?

Mar 16 2019, 2:44 PM · Gwenview

Mar 15 2019

sander updated the diff for D19702: Page changes triggered by mouse clicks should all happen on button release.

Updated the comment

Mar 15 2019, 1:53 PM · Okular
sander updated the diff for D19539: Replace some iterator loops by range-based for.

Removed those four aAsConst again.

Mar 15 2019, 8:53 AM · Okular

Mar 12 2019

sander requested review of D19702: Page changes triggered by mouse clicks should all happen on button release.
Mar 12 2019, 10:08 AM · Okular
sander added a comment to D19539: Replace some iterator loops by range-based for.

Albert, is this okay now?

Mar 12 2019, 9:28 AM · Okular