whiting (Jeremy Whiting)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Dec 19 2014, 7:32 PM (252 w, 3 h)
Availability
Available

Recent Activity

Wed, Oct 16

whiting added a comment to D24276: Add text to speech functionality to klipper..
In D24276#548330, @mart wrote:

this only affects the old standalone executable, right?

Wed, Oct 16, 4:50 PM · Plasma

Thu, Oct 10

whiting updated the diff for D24276: Add text to speech functionality to klipper..
  • Add speech synthesis engine selection combobox to general klipper settings page.
Thu, Oct 10, 1:46 AM · Plasma

Mon, Oct 7

whiting abandoned D24102: Add Pause/Resume action for pausing and resuming speech synthesis..

Yep, Abandoning.

Mon, Oct 7, 6:09 PM · Okular
whiting added a comment to D24102: Add Pause/Resume action for pausing and resuming speech synthesis..

Sorry for being a pain, but your patch contains lots of whitespace changes again (in conf/dlgaccessibilitybase.ui). I agree that you probably do want them changed, but please do so in a separate patch.

Besides, can you please post your patch as a merge request on https://invent.kde.org/kde/okular/ ? That is not purely cosmetic -- invent.kde.org has a CI system.

Besides that: I like the patch!

Ok, I'll fix the whitespace and move it to the other review tool, no problem.

Mon, Oct 7, 5:00 PM · Okular

Thu, Oct 3

whiting added a comment to D24102: Add Pause/Resume action for pausing and resuming speech synthesis..

Sorry for being a pain, but your patch contains lots of whitespace changes again (in conf/dlgaccessibilitybase.ui). I agree that you probably do want them changed, but please do so in a separate patch.

Besides, can you please post your patch as a merge request on https://invent.kde.org/kde/okular/ ? That is not purely cosmetic -- invent.kde.org has a CI system.

Besides that: I like the patch!

Thu, Oct 3, 3:24 PM · Okular
whiting updated the summary of D24102: Add Pause/Resume action for pausing and resuming speech synthesis..
Thu, Oct 3, 3:22 PM · Okular
whiting added a comment to D24276: Add text to speech functionality to klipper..

Does anyone have any opinion on this change?

Thu, Oct 3, 3:21 PM · Plasma

Sat, Sep 28

whiting updated the summary of D24276: Add text to speech functionality to klipper..
Sat, Sep 28, 4:57 AM · Plasma
whiting updated the diff for D24276: Add text to speech functionality to klipper..
  • Add speech synthesis engine selection combobox to general klipper settings page.
Sat, Sep 28, 4:55 AM · Plasma
whiting updated the diff for D24102: Add Pause/Resume action for pausing and resuming speech synthesis..
  • Fix building okular without QTextToSpeech by adding ifdefs.
Sat, Sep 28, 4:55 AM · Okular
Restricted Application edited projects for D24276: Add text to speech functionality to klipper., added: Plasma; removed Plasma Accessibility.
Sat, Sep 28, 4:42 AM · Plasma
whiting requested review of D24276: Add text to speech functionality to klipper..
Sat, Sep 28, 4:40 AM · Plasma

Thu, Sep 26

whiting added a comment to D24102: Add Pause/Resume action for pausing and resuming speech synthesis..

Sounds sensible, what about the TODO you have on the top?

Thu, Sep 26, 9:53 PM · Okular
whiting updated the diff for D24102: Add Pause/Resume action for pausing and resuming speech synthesis..
  • When tts engine is changed via okular settings recreate tts object.
Thu, Sep 26, 6:10 AM · Okular
whiting updated the diff for D24102: Add Pause/Resume action for pausing and resuming speech synthesis..
  • Only enable Pause or Resume when speaking or paused.
Thu, Sep 26, 5:48 AM · Okular

Wed, Sep 25

whiting updated the diff for D24102: Add Pause/Resume action for pausing and resuming speech synthesis..

Changed engines stringlist to const and use for instead of foreach.

Wed, Sep 25, 10:30 PM · Okular
whiting added a comment to D24224: Start of the accessibility KCM.

Thanks for taking this on Tomaz, Just throwing some ideas out but if it would help to have less tabs it might be useful to put all the keyboard features on one tab called Keyboard instead of the 3 it has now (Modifier Keys, Keyboard Filters and Activation Gestures) The top groupbox of Activation Gestures items could be moved to their respective groupboxes also so there are less groupboxes on the Keyboard tab than before on these 3 tabs.

Wed, Sep 25, 3:24 PM · Plasma
whiting updated the test plan for D24102: Add Pause/Resume action for pausing and resuming speech synthesis..
Wed, Sep 25, 1:28 AM · Okular
whiting updated the diff for D24102: Add Pause/Resume action for pausing and resuming speech synthesis..
  • Add user okular user setting for which QtSpeech engine to use.
Wed, Sep 25, 1:25 AM · Okular

Fri, Sep 20

whiting updated the diff for D24102: Add Pause/Resume action for pausing and resuming speech synthesis..

Removed whitespace changes.

Fri, Sep 20, 5:08 PM · Okular

Thu, Sep 19

whiting added a reviewer for D24102: Add Pause/Resume action for pausing and resuming speech synthesis.: aacid.
Thu, Sep 19, 10:57 PM · Okular
whiting requested review of D24102: Add Pause/Resume action for pausing and resuming speech synthesis..
Thu, Sep 19, 10:56 PM · Okular

Jul 22 2019

whiting committed R327:e724f3994498: Move qml files and icons/images into a resource. (authored by whiting).
Move qml files and icons/images into a resource.
Jul 22 2019, 5:10 AM
whiting committed R454:006f36d3628b: Fix browse for files/folders doesn't enable "Compare" button. (authored by whiting).
Fix browse for files/folders doesn't enable "Compare" button.
Jul 22 2019, 4:45 AM

Jun 18 2019

whiting closed D21850: Add "Hide Liabilities with zero balance" option to home view.
Jun 18 2019, 5:22 PM
whiting committed R261:686945965a6f: Add option to hide liability accounts with zero balance from home. (authored by whiting).
Add option to hide liability accounts with zero balance from home.
Jun 18 2019, 5:22 PM
whiting added a comment to D21850: Add "Hide Liabilities with zero balance" option to home view.

Awesome, k, I nuked my branch when I modified it. I'll just push the commit on the 5.0 branch and close this revision, makes sense.

Jun 18 2019, 5:20 PM
whiting added a comment to D21850: Add "Hide Liabilities with zero balance" option to home view.

Wow, so looking forward to gitlab. So after a revision has been accepted what's the preferred way to land it? merge? cherry-pick? just rebase on the 5.0 branch and push?

Jun 18 2019, 3:07 PM

Jun 16 2019

whiting updated the diff for D21850: Add "Hide Liabilities with zero balance" option to home view.

Changed logic to match review comments.

Jun 16 2019, 7:17 PM
whiting added a comment to D21850: Add "Hide Liabilities with zero balance" option to home view.

I'm open to having this option also hide asset accounts with zero balance, though that might be better as a separate option. Personally I'd like to continue to see my zero balance assets to be reminded I need to put something in them at some point (or close them if they are not being useful, etc.)

Jun 16 2019, 3:35 PM
whiting requested review of D21850: Add "Hide Liabilities with zero balance" option to home view.
Jun 16 2019, 3:33 PM
whiting committed R261:b84eee965971: Add option to hide liability accounts with zero balance from home. (authored by whiting).
Add option to hide liability accounts with zero balance from home.
Jun 16 2019, 3:02 AM

Apr 11 2019

whiting committed R237:84e4b53a909d: Fix typo in KConfig documentation. (authored by whiting).
Fix typo in KConfig documentation.
Apr 11 2019, 1:05 AM

Mar 26 2019

whiting committed R237:6df6abe2897b: Fix typo in KConfig documentation. (authored by whiting).
Fix typo in KConfig documentation.
Mar 26 2019, 4:48 PM

Mar 20 2019

whiting committed R417:3ecebabf44eb: Don't use KIO copy and QTemporaryFile to load xml definition files. (authored by whiting).
Don't use KIO copy and QTemporaryFile to load xml definition files.
Mar 20 2019, 4:04 PM
whiting committed R417:40e80d738666: Don't use KIO copy and QTemporaryFile to load xml definition files. (authored by whiting).
Don't use KIO copy and QTemporaryFile to load xml definition files.
Mar 20 2019, 2:30 AM

Sep 13 2018

whiting accepted D15481: Fix 'Impossible to use knsrc file for uploads from non standard location'.

Looks good to me. Thanks for doing that fix.

Sep 13 2018, 2:58 PM · Frameworks

Feb 14 2018

whiting added a comment to D7968: Forward QComboBox signals instead of QComboBox lineedit signals.

Hey all, this change breaks Kompare https://bugs.kde.org/show_bug.cgi?id=390024 which watches a KUrlRequester's textChanged signal to update a button's enabled state. We are not seeing the textChanged signal on the KUrlRequester anymore when programatically setting the url with the KUrlComboBox we give to the KUrlRequester via it's setUrl method. Looking at KUrlComboBox::setUrl it's blocking signals in the body of setUrl and since we are not connecting to the QLineEdit anymore we never get that signal.

Feb 14 2018, 11:47 PM · Frameworks

Jan 7 2018

whiting accepted D9667: Update KMouth docbook to kf5.

Looks good to me. thanks again.

Jan 7 2018, 7:24 PM

Jan 5 2018

whiting requested changes to D9667: Update KMouth docbook to kf5.

Looks good to me except for the flite bits. I'll go remind my self how to tell QtSpeech to use the flite backend/plugin, but it's definitely optional.

Jan 5 2018, 2:53 PM
whiting accepted D9667: Update KMouth docbook to kf5.

Looks good to me. Thank you for taking this on.

Jan 5 2018, 12:24 AM

Oct 24 2017

whiting committed R304:c32c8d002e12: Don't detach shared pointers to private data when setting previews. (authored by whiting).
Don't detach shared pointers to private data when setting previews.
Oct 24 2017, 9:21 PM

Aug 8 2017

whiting committed R32:0a60a60e29b3: Added toggle targets to project view to show/hide targets from the view. (authored by whiting).
Added toggle targets to project view to show/hide targets from the view.
Aug 8 2017, 4:55 PM

Jul 5 2017

whiting accepted D5630: Use Qt to create the autostart entry instead of system calls.
Jul 5 2017, 10:39 PM

Jun 25 2017

whiting added a comment to D5630: Use Qt to create the autostart entry instead of system calls.

Yes, this should go in the frameworks branch, I'll see if I can get the frameworks branch merged to master this week.

Jun 25 2017, 2:10 AM

May 12 2017

whiting added a comment to R428:e410d659592c: Fix runtime warning about using QPixmap::grabWindow. Not perfect, but not worse..

Hmm QScreen::grabWindow is already grabbing pixmap data from both screens here. I wonder why it needs the QScreen object at all. At any rate it seems to work fine.

May 12 2017, 8:53 PM
whiting accepted R428:e410d659592c: Fix runtime warning about using QPixmap::grabWindow. Not perfect, but not worse..

Looks like this is already in kmag master. I'll see if I can sort out how to decide which screen to grab from.

May 12 2017, 8:37 PM

May 2 2017

whiting closed T684: KMag: Mode isn't saved as Resolved.
May 2 2017, 12:43 AM · Qt 5 Porting
whiting moved T684: KMag: Mode isn't saved from Backlog to Done on the Qt 5 Porting board.
May 2 2017, 12:20 AM · Qt 5 Porting
whiting committed R428:4419029b6767: Use mode reading code for now to fix saving/loading the chosen mode. (authored by whiting).
Use mode reading code for now to fix saving/loading the chosen mode.
May 2 2017, 12:18 AM

May 1 2017

whiting committed R428:6daa4bcf2d10: Properly initialize the localization in the KF5 world (authored by ltoscano).
Properly initialize the localization in the KF5 world
May 1 2017, 10:32 PM
whiting committed R428:965a2ae3ed01: Remove outdated kmag.kdevprj (authored by kossebau).
Remove outdated kmag.kdevprj
May 1 2017, 10:32 PM
whiting committed R428:75743f9cdea3: doc: use the new ECM variables to set the destination (authored by ltoscano).
doc: use the new ECM variables to set the destination
May 1 2017, 10:32 PM
whiting committed R428:0ed41fcc0651: KDE includes -> KF5 includes (authored by kossebau).
KDE includes -> KF5 includes
May 1 2017, 10:32 PM
whiting committed R428:a5af397b30b6: Fix runtime warning about using QPixmap::grabWindow. Not perfect, but not worse. (authored by dfaure).
Fix runtime warning about using QPixmap::grabWindow. Not perfect, but not worse.
May 1 2017, 10:32 PM
whiting committed R428:651db14fa65a: Let KDE*CompilerSettings change the policies in the project (authored by kossebau).
Let KDE*CompilerSettings change the policies in the project
May 1 2017, 10:32 PM
whiting committed R428:8cd3da710e66: Make const arrays const (authored by kossebau).
Make const arrays const
May 1 2017, 10:32 PM
whiting committed R428:030631189114: Use QStringLiteral + new connect api (authored by mlaurent).
Use QStringLiteral + new connect api
May 1 2017, 10:32 PM
whiting committed R428:e45f16a25341: Remove not necessary old include path (authored by mlaurent).
Remove not necessary old include path
May 1 2017, 10:32 PM
whiting committed R428:832671e12c70: Reverse dnd desktop (authored by mlaurent).
Reverse dnd desktop
May 1 2017, 10:32 PM
whiting committed R428:a855ebe1bcfa: Enable building with QAccessibilityClient (authored by cfeck).
Enable building with QAccessibilityClient
May 1 2017, 10:32 PM
whiting committed R428:a74754f9fc2c: Update to recent docbook DTD (authored by cfeck).
Update to recent docbook DTD
May 1 2017, 10:32 PM
whiting committed R428:218d155a0b9e: Remove command line arguments from .desktop file (authored by cfeck).
Remove command line arguments from .desktop file
May 1 2017, 10:32 PM
whiting committed R428:4e697c4bf4fb: Improve file saving dialog (authored by cfeck).
Improve file saving dialog
May 1 2017, 10:32 PM
whiting committed R428:d429f85d126c: Add dummy QCommandLineParser so that --version works (authored by cfeck).
Add dummy QCommandLineParser so that --version works
May 1 2017, 10:32 PM
whiting committed R428:4879c210c79f: cleanup includes (authored by cfeck).
cleanup includes
May 1 2017, 10:32 PM
whiting committed R428:9456722c08ac: KF5 port: only link to required frameworks (authored by cfeck).
KF5 port: only link to required frameworks
May 1 2017, 10:32 PM
whiting committed R428:b3139cb54ba0: KF5 port: KImageIO -> QImageReader / KFileDialog -> QFileDialog (authored by cfeck).
KF5 port: KImageIO -> QImageReader / KFileDialog -> QFileDialog
May 1 2017, 10:31 PM
whiting committed R428:f22ff29a7686: KF5 port: KIO::NetAccess::upload -> KIO::file_copy (authored by cfeck).
KF5 port: KIO::NetAccess::upload -> KIO::file_copy
May 1 2017, 10:31 PM
whiting committed R428:085bd8eb8a33: remove unused member (authored by cfeck).
remove unused member
May 1 2017, 10:31 PM
whiting committed R428:2d8b3c660cd9: KF5 port: K4AboutData -> KAboutData (authored by cfeck).
KF5 port: K4AboutData -> KAboutData
May 1 2017, 10:31 PM
whiting committed R428:05a45d01890b: KF5 port: QAction::setShortcut -> KActionCollection::setDefaultShortcut (authored by cfeck).
KF5 port: QAction::setShortcut -> KActionCollection::setDefaultShortcut
May 1 2017, 10:31 PM
whiting committed R428:f6b84433b2d7: KF5 port: KApplication -> QApplication (authored by cfeck).
KF5 port: KApplication -> QApplication
May 1 2017, 10:31 PM
whiting committed R428:95a70118bae4: remove Qt::WFlags usage (authored by cfeck).
remove Qt::WFlags usage
May 1 2017, 10:31 PM
whiting committed R428:e5a2f927dbde: KF5 port: KGlobal::config -> KSharedConfig::openConfig (authored by cfeck).
KF5 port: KGlobal::config -> KSharedConfig::openConfig
May 1 2017, 10:31 PM
whiting committed R428:1fc015e3085d: KF5 port: KdePrintDialog -> QPrintDialog (authored by cfeck).
KF5 port: KdePrintDialog -> QPrintDialog
May 1 2017, 10:31 PM
whiting committed R428:21924f2e54ac: KF5 port: KTemporaryFile -> QTemporaryFile (authored by cfeck).
KF5 port: KTemporaryFile -> QTemporaryFile
May 1 2017, 10:31 PM
whiting committed R428:6c342f9c3d0d: KF5 port: kWarning -> qDebug (authored by cfeck).
KF5 port: kWarning -> qDebug
May 1 2017, 10:31 PM
whiting committed R428:08e4a3281cf0: KF5 port: kde4_install_icons -> ecm_install_icons (authored by cfeck).
KF5 port: kde4_install_icons -> ecm_install_icons
May 1 2017, 10:31 PM
whiting committed R428:b9075d8912b3: KF5 port: KIcon -> QIcon::fromTheme (authored by cfeck).
KF5 port: KIcon -> QIcon::fromTheme
May 1 2017, 10:31 PM
whiting committed R428:b8efa5c8de10: Initial port to KF5 (authored by cfeck).
Initial port to KF5
May 1 2017, 10:31 PM
whiting committed R499:e1e2bebd7a73: Adjust kmag branches as we merge frameworks into master for 17.08 (authored by whiting).
Adjust kmag branches as we merge frameworks into master for 17.08
May 1 2017, 10:31 PM

Apr 19 2017

whiting committed R304:d9890894b9ef: Fix i18n puzzle again. (authored by whiting).
Fix i18n puzzle again.
Apr 19 2017, 7:14 PM
whiting committed R304:622f99342dc3: KNewStuff: Show file's size information in grid delegate. (authored by whiting).
KNewStuff: Show file's size information in grid delegate.
Apr 19 2017, 7:12 PM

Apr 18 2017

whiting committed R304:e3626a831668: If an entry's size is known, show it in the list view. (authored by whiting).
If an entry's size is known, show it in the list view.
Apr 18 2017, 8:34 PM
whiting committed R430:97a272cfb3c5: Fix build by using right i18n call. (authored by whiting).
Fix build by using right i18n call.
Apr 18 2017, 7:34 PM

Sep 10 2016

whiting committed R108:72f3a9e2a30f: fix build error (authored by whiting).
fix build error
Sep 10 2016, 5:36 AM
whiting committed R108:03a41d417489: those of us on kubuntu need this include (authored by whiting).
those of us on kubuntu need this include
Sep 10 2016, 5:34 AM
whiting committed R108:f5e7a77da10c: added missing ifdefs for those of us without XDAMAGE (authored by whiting).
added missing ifdefs for those of us without XDAMAGE
Sep 10 2016, 5:34 AM
whiting committed R165:1504b91aca81: Fix whitespace. (authored by whiting).
Fix whitespace.
Sep 10 2016, 4:03 AM
whiting committed R165:89871192ffb5: Wrap QByteArray + operator use so it will build with qt 4.8 (authored by whiting).
Wrap QByteArray + operator use so it will build with qt 4.8
Sep 10 2016, 4:03 AM
whiting committed R22:fe5f9c5d7e1b: Add FindQtMobility.cmake to find QtMobility libraries and paths. Create… (authored by whiting).
Add FindQtMobility.cmake to find QtMobility libraries and paths. Create…
Sep 10 2016, 3:48 AM

Sep 2 2016

whiting added a comment to T3556: Remove password prompt from store.kde.org.

Seems to be gone. Can we close this?

Sep 2 2016, 9:24 PM · KDE Store

Aug 11 2016

whiting added a comment to D2409: Update Color KCM.

I like it. Nice work. I agree I would change Config Scheme to Edit Scheme.

Aug 11 2016, 10:59 PM · Plasma

May 31 2016

whiting accepted D1719: Provide QDebug helpers for some Attica classes.

Looks good to me.

May 31 2016, 7:28 PM

Apr 16 2016

whiting added a comment to T513: Compile/Install Qt5TextToSpeech.

Qt 5.6 actually doesn't include QtTextToSpeech, it will be in Qt 5.7 instead as tech preview apparently :/

Apr 16 2016, 12:11 AM · build.kde.org

Jan 5 2016

whiting committed R135:614128fe3386: Add verbose ecm message when ECM isn't found. (authored by whiting).
Add verbose ecm message when ECM isn't found.
Jan 5 2016, 8:45 AM

Dec 14 2015

whiting added a comment to T513: Compile/Install Qt5TextToSpeech.

QtTextToSpeech hasn't been released yet, but will be part of Qt 5.6 when it comes out.

Dec 14 2015, 3:16 AM · build.kde.org

Sep 17 2015

whiting closed T842: KRfb port away from KDELibs4support as Resolved.
Sep 17 2015, 2:58 AM · Qt 5 Porting
whiting moved T842: KRfb port away from KDELibs4support from Backlog to Done on the Qt 5 Porting board.
Sep 17 2015, 2:58 AM · Qt 5 Porting