ElisaProject
ActivePublic

Recent Activity

Today

astippich added a comment to D22576: Mimic Kirigami InlineMessage for TrackImportNotification.


We cannot use the InlineMessage directly due to the BusyIndicator

Sat, Jul 20, 7:53 AM · Elisa
astippich requested review of D22576: Mimic Kirigami InlineMessage for TrackImportNotification.
Sat, Jul 20, 7:51 AM · Elisa
astippich closed D21911: Remove PassiveNotification in favor of Kirigami.InlineMessage.
Sat, Jul 20, 7:51 AM · Elisa
ngraham accepted D21911: Remove PassiveNotification in favor of Kirigami.InlineMessage.

LGTM!

Sat, Jul 20, 2:37 AM · Elisa

Thu, Jul 18

astippich added a reviewer for D22442: Remove datatype: ngraham.
Thu, Jul 18, 6:56 PM · Elisa
astippich added a reviewer for D22441: Speed up search of album covers: ngraham.
Thu, Jul 18, 6:56 PM · Elisa
astippich added a reviewer for D22440: Test searching for album covers: ngraham.
Thu, Jul 18, 6:56 PM · Elisa
astippich added a reviewer for D22439: Consolidate cover scanning into file scanner: ngraham.
Thu, Jul 18, 6:55 PM · Elisa
astippich added a comment to D21911: Remove PassiveNotification in favor of Kirigami.InlineMessage.

That's probably worth a Kirigami bug report.

Thu, Jul 18, 6:48 PM · Elisa
astippich updated the diff for D21911: Remove PassiveNotification in favor of Kirigami.InlineMessage.
  • add actions
Thu, Jul 18, 6:47 PM · Elisa

Mon, Jul 15

lshoravi added a comment to D12992: New elisa icon.

I believe we'll need @abetts .svg file- I can't seem to find it.

Mon, Jul 15, 9:32 AM · Frameworks, Elisa
mfraser added a watcher for Elisa: mfraser.
Mon, Jul 15, 7:43 AM
ngraham added a comment to D21911: Remove PassiveNotification in favor of Kirigami.InlineMessage.

That's probably worth a Kirigami bug report.

Mon, Jul 15, 1:14 AM · Elisa

Sun, Jul 14

astippich updated the diff for D22454: Cleanup file browser implementation.
  • wrap main label in case no secondary text is displayed
Sun, Jul 14, 1:57 PM · Elisa
astippich added a comment to D22454: Cleanup file browser implementation.

sorry!

Sun, Jul 14, 1:39 PM · Elisa
astippich updated the diff for D22454: Cleanup file browser implementation.
  • completely remove signal
Sun, Jul 14, 1:39 PM · Elisa
ngraham added a comment to D22454: Cleanup file browser implementation.
$ (arcpatch-D22454) kb && elisa
Total of 'trivial' dependency cycles detected & eliminated: 2
Sun, Jul 14, 1:23 PM · Elisa
astippich added a comment to D21911: Remove PassiveNotification in favor of Kirigami.InlineMessage.

I tried to implement the actions for load and save playlist. However, InlineMessage seems only to be compatible with Kirigami Actions and not with the qqc2 ones, which is unfortunate

Sun, Jul 14, 1:10 PM · Elisa
astippich updated the diff for D21911: Remove PassiveNotification in favor of Kirigami.InlineMessage.
  • fixup type
Sun, Jul 14, 1:09 PM · Elisa
astippich requested review of D22454: Cleanup file browser implementation.
Sun, Jul 14, 12:57 PM · Elisa

Sat, Jul 13

ngraham added a comment to D22432: Adjust visuals of metadata view.

Yes, the Kirigami SearchField should be a drop-in replacement. I actually tried to do it as a part of my patch to redo the main view's toolbar but got conflicting shortcut errors and dropped it for the moment.

Sat, Jul 13, 8:40 PM · Elisa
astippich closed D22432: Adjust visuals of metadata view.
Sat, Jul 13, 5:26 PM · Elisa
astippich closed D22433: Improvements to file browser.
Sat, Jul 13, 5:26 PM · Elisa
astippich added a comment to D22432: Adjust visuals of metadata view.

I haven't looked that much into leveraging Kirigami yet and did not know about the FormLayout, so thanks. When the consolidation of the existing qml code and the full port to qqc2 is done, I will have a look at it.
There is also the search bar etc. which could be replaced by Kirigami components, I think.
Btw, there still is D21911 :)

Sat, Jul 13, 5:25 PM · Elisa
ngraham accepted D22433: Improvements to file browser.

Makes sense. :) LGTM!

Sat, Jul 13, 5:16 PM · Elisa
astippich added a comment to D22433: Improvements to file browser.

Definitely, but I wanted to get it fully working before I break it again :)

Sat, Jul 13, 5:09 PM · Elisa
ngraham accepted D22432: Adjust visuals of metadata view.

Sensible improvement. A nice next step would be to make the whole metadata view into a standalone Kirigami FormLayout instead of each user making its own ListView or ColumnLayout, and each item being a RowLayout full of custom sizing and alignment code.

Sat, Jul 13, 5:07 PM · Elisa
ngraham added a comment to D22433: Improvements to file browser.

Should use the same grid and list browser delegates used by the other views IMO.

Sat, Jul 13, 4:05 PM · Elisa
astippich updated the diff for D22442: Remove datatype.
  • fixup
Sat, Jul 13, 3:58 PM · Elisa
astippich requested review of D22442: Remove datatype.
Sat, Jul 13, 3:54 PM · Elisa
astippich requested review of D22441: Speed up search of album covers.
Sat, Jul 13, 2:37 PM · Elisa
astippich added a dependent revision for D22440: Test searching for album covers: D22441: Speed up search of album covers.
Sat, Jul 13, 2:37 PM · Elisa
astippich requested review of D22440: Test searching for album covers.
Sat, Jul 13, 2:35 PM · Elisa
astippich added a dependent revision for D22439: Consolidate cover scanning into file scanner: D22440: Test searching for album covers.
Sat, Jul 13, 2:35 PM · Elisa
astippich requested review of D22439: Consolidate cover scanning into file scanner.
Sat, Jul 13, 2:32 PM · Elisa
astippich requested review of D22433: Improvements to file browser.
Sat, Jul 13, 10:51 AM · Elisa
astippich added a comment to D22432: Adjust visuals of metadata view.

before


after

Sat, Jul 13, 9:47 AM · Elisa
astippich requested review of D22432: Adjust visuals of metadata view.
Sat, Jul 13, 9:46 AM · Elisa

Fri, Jul 12

astippich closed D22410: Cleanup list delegate.
Fri, Jul 12, 2:50 PM · Elisa
ngraham accepted D22410: Cleanup list delegate.
Fri, Jul 12, 1:27 PM · Elisa
ngraham added a comment to D22410: Cleanup list delegate.

+1, this consolidation makes sense.

Fri, Jul 12, 1:27 PM · Elisa

Thu, Jul 11

astippich updated the diff for D22410: Cleanup list delegate.
  • actually add new file
Thu, Jul 11, 8:11 PM · Elisa
astippich requested review of D22410: Cleanup list delegate.
Thu, Jul 11, 8:10 PM · Elisa

Wed, Jul 10

astippich updated the diff for D21911: Remove PassiveNotification in favor of Kirigami.InlineMessage.
  • fix text and apply error type
Wed, Jul 10, 6:29 PM · Elisa
mgallien added a comment to D21911: Remove PassiveNotification in favor of Kirigami.InlineMessage.

Please see my comment and other comments

Wed, Jul 10, 6:05 AM · Elisa

Tue, Jul 9

astippich closed D22345: Unify simple and normal playlist entry.
Tue, Jul 9, 8:22 PM · Elisa
astippich closed D22310: Port navigation bar to qqc2.
Tue, Jul 9, 8:21 PM · Elisa
astippich added a comment to D22310: Port navigation bar to qqc2.

How about only setting the width and height explicitly for the back and sort buttons, and adding TODO or FIXME comments so that we know why it's set?

Tue, Jul 9, 8:21 PM · Elisa
ngraham accepted D22310: Port navigation bar to qqc2.

How about only setting the width and height explicitly for the back and sort buttons, and adding TODO or FIXME comments so that we know why it's set?

Tue, Jul 9, 7:14 PM · Elisa
ngraham accepted D22345: Unify simple and normal playlist entry.
Tue, Jul 9, 7:09 PM · Elisa