We cannot use the InlineMessage directly due to the BusyIndicator
Thu, Jul 18
- add actions
Mon, Jul 15
I believe we'll need @abetts .svg file- I can't seem to find it.
That's probably worth a Kirigami bug report.
Sun, Jul 14
- wrap main label in case no secondary text is displayed
- completely remove signal
$ (arcpatch-D22454) kb && elisa Total of 'trivial' dependency cycles detected & eliminated: 2
I tried to implement the actions for load and save playlist. However, InlineMessage seems only to be compatible with Kirigami Actions and not with the qqc2 ones, which is unfortunate
- fixup type
Sat, Jul 13
Yes, the Kirigami SearchField should be a drop-in replacement. I actually tried to do it as a part of my patch to redo the main view's toolbar but got conflicting shortcut errors and dropped it for the moment.
I haven't looked that much into leveraging Kirigami yet and did not know about the FormLayout, so thanks. When the consolidation of the existing qml code and the full port to qqc2 is done, I will have a look at it.
There is also the search bar etc. which could be replaced by Kirigami components, I think.
Btw, there still is D21911 :)
Makes sense. :) LGTM!
Definitely, but I wanted to get it fully working before I break it again :)
Sensible improvement. A nice next step would be to make the whole metadata view into a standalone Kirigami FormLayout instead of each user making its own ListView or ColumnLayout, and each item being a RowLayout full of custom sizing and alignment code.
Should use the same grid and list browser delegates used by the other views IMO.
Fri, Jul 12
+1, this consolidation makes sense.
Thu, Jul 11
- actually add new file
Wed, Jul 10
- fix text and apply error type
Please see my comment and other comments
Tue, Jul 9
How about only setting the width and height explicitly for the back and sort buttons, and adding TODO or FIXME comments so that we know why it's set?