ElisaProject
ActivePublic

Recent Activity

Yesterday

astippich updated the diff for D10210: implement a trackdata helper to display more detailed track information.
  • Merge branch 'master' into trackdatahelper
Sat, Feb 24, 2:35 PM · Elisa
astippich accepted D10451: improve adding tracks or albums from the proxy models (fast and not blocking).

working fine now

Sat, Feb 24, 2:16 PM · Elisa
astippich moved T7530: High DPI support from Backlog to In Progress on the Elisa board.
Sat, Feb 24, 2:08 PM · Elisa

Thu, Feb 22

mgallien updated the diff for D10451: improve adding tracks or albums from the proxy models (fast and not blocking).
  • improve replace for the playlist to not show the empty playlist state
  • maybe solve the compilation problem
Thu, Feb 22, 10:54 PM · Elisa
mgallien added a comment to D10451: improve adding tracks or albums from the proxy models (fast and not blocking).

does not compile here

What is your compile error ?
Is it only the problem related to QtCreator ?

The error is
elisa/src/main.cpp:-1: error: undefined reference to `ElisaUtils::staticMetaObject'

I've cleaned and completely rebuilt the source.

Thanks I will work on a solution. Sorry for the inconvenience, on my laptop I do not reproduce this situation.

Thu, Feb 22, 10:44 PM · Elisa
mgallien added a comment to D10365: New icon for Elisa music player.

can we get it now to master?

@paullesur is hopefully interested in other icon's too.

@paullesur do you have a KDE contributor account ? If not, I cannot push due to life events pushing me away from keyboard.

Thu, Feb 22, 8:57 PM · Elisa, Frameworks
mgallien closed D10402: lazy initialize as much as possible.
Thu, Feb 22, 8:14 PM · Elisa
mykolak added a comment to D10460: To make theme size depend on DPI.

@astippich sure: Mykola Krachkovsky <w01dnick@gmail.com>

Thu, Feb 22, 8:30 AM · Elisa
mgallien added a comment to D10451: improve adding tracks or albums from the proxy models (fast and not blocking).

does not compile here

What is your compile error ?
Is it only the problem related to QtCreator ?

The error is
elisa/src/main.cpp:-1: error: undefined reference to `ElisaUtils::staticMetaObject'

I've cleaned and completely rebuilt the source.

Thu, Feb 22, 7:34 AM · Elisa
astippich accepted D10402: lazy initialize as much as possible.
Thu, Feb 22, 6:57 AM · Elisa
astippich added a comment to D10451: improve adding tracks or albums from the proxy models (fast and not blocking).

does not compile here

What is your compile error ?
Is it only the problem related to QtCreator ?

Thu, Feb 22, 6:51 AM · Elisa
astippich added a comment to D10460: To make theme size depend on DPI.

@mykolak could you provide me an email address so that I can add a proper author to the commit?

Thu, Feb 22, 6:50 AM · Elisa
asn added a comment to T7530: High DPI support.

We already have this working more or less. Here is a screenshot of the work.

Thu, Feb 22, 6:32 AM · Elisa
acrouthamel added a comment to T7530: High DPI support.

I also have a HiDPI system, I'd be glad to test. Just give me an @ mention and let me know if you need me.

Thu, Feb 22, 1:32 AM · Elisa

Wed, Feb 21

mgallien added a comment to D10451: improve adding tracks or albums from the proxy models (fast and not blocking).

does not compile here

Wed, Feb 21, 9:56 PM · Elisa
mgallien added a comment to D10402: lazy initialize as much as possible.

Thanks for the review. I have fixed all three issues.

Wed, Feb 21, 9:26 PM · Elisa
mgallien updated the diff for D10402: lazy initialize as much as possible.
  • lazy initialize MediaPlayList
  • finish modifications for everything
  • small remaining change
  • last fixes
  • another small number of fixes
  • access to the media play list through the elisa variable
  • use std::unique_ptr to avoid memory leaks
Wed, Feb 21, 9:24 PM · Elisa
mgallien added a comment to D10460: To make theme size depend on DPI.

The solution I had applied when I saw the same situation is the following:

  1. git revert <hash of the commit>

git revert 157c9f04f4f99b5591980fe97052682a3ca6963b

Wed, Feb 21, 8:44 PM · Elisa
astippich added a comment to D10460: To make theme size depend on DPI.

For some reason the author in the git log is wrong here. @mgallien what did you do last time or can you fix it?

Wed, Feb 21, 7:18 PM · Elisa
astippich closed D10460: To make theme size depend on DPI.
Wed, Feb 21, 7:16 PM · Elisa
astippich closed D10144: Various general and RTL fixes.
Wed, Feb 21, 7:14 PM · Elisa
astippich retitled D10144: Various general and RTL fixes from WIP: Various general and RTL fixes to Various general and RTL fixes.
Wed, Feb 21, 7:08 PM · Elisa
astippich added a comment to D10451: improve adding tracks or albums from the proxy models (fast and not blocking).

does not compile here

Wed, Feb 21, 6:48 PM · Elisa
astippich moved T7576: port to controls2 from Backlog to In Progress on the Elisa board.
Wed, Feb 21, 6:29 PM · Elisa
astippich moved T6255: Add support for cover images embedded in tracks from Backlog to In Progress on the Elisa board.
Wed, Feb 21, 6:29 PM · Elisa
astippich claimed T6255: Add support for cover images embedded in tracks.
Wed, Feb 21, 6:29 PM · Elisa
astippich requested changes to D10402: lazy initialize as much as possible.

Some comments inline

Wed, Feb 21, 6:25 PM · Elisa
mgallien added a comment to D10460: To make theme size depend on DPI.

Nope. I cannot test but if it is improving things, let's go.

Wed, Feb 21, 6:24 PM · Elisa
astippich accepted D10460: To make theme size depend on DPI.

Any objections for merging?

Wed, Feb 21, 6:09 PM · Elisa
astippich accepted D10144: Various general and RTL fixes.

Sorry for the delay, I will land this on the weekend

Wed, Feb 21, 6:06 PM · Elisa
mgallien updated the diff for D10451: improve adding tracks or albums from the proxy models (fast and not blocking).
  • improve replace for the playlist to not show the empty playlist state
Wed, Feb 21, 6:53 AM · Elisa

Mon, Feb 19

mgallien retitled D10402: lazy initialize as much as possible from [WIP] lazy initialize as much as possible to lazy initialize as much as possible.
Mon, Feb 19, 10:46 PM · Elisa
mgallien updated the diff for D10402: lazy initialize as much as possible.
  • lazy initialize MediaPlayList
  • finish modifications for everything
  • small remaining change
  • last fixes
  • another small number of fixes
Mon, Feb 19, 10:46 PM · Elisa

Sun, Feb 18

astippich updated the diff for D10643: pipe loading of album data through proxy model.
  • remove unused qml function
Sun, Feb 18, 7:08 PM · Elisa
astippich requested review of D10643: pipe loading of album data through proxy model.
Sun, Feb 18, 6:40 PM · Elisa
astippich closed D10271: move MediaPlaylist to C++.
Sun, Feb 18, 6:26 PM · Elisa
mgallien accepted D10271: move MediaPlaylist to C++.
Sun, Feb 18, 4:56 PM · Elisa
astippich updated the diff for D10271: move MediaPlaylist to C++.
  • fix missing Q_EMIT
  • do not emit ensurePlay signal twice
  • merge master
Sun, Feb 18, 12:00 PM · Elisa
astippich added a comment to D10271: move MediaPlaylist to C++.

I will put this on hold until D10402 and D10451 have landed

Sorry for the delay. I had thought about doing it the other way. D10271 before D10402. It is your call.

Sun, Feb 18, 11:59 AM · Elisa
mgallien added a comment to D10271: move MediaPlaylist to C++.

I will put this on hold until D10402 and D10451 have landed

Sun, Feb 18, 11:19 AM · Elisa

Sat, Feb 17

astippich added a comment to D10460: To make theme size depend on DPI.

Yes, buttons are still controls v1.

Sat, Feb 17, 4:33 PM · Elisa
mgallien added a comment to D10460: To make theme size depend on DPI.
In D10460#207155, @asn wrote:

Are you on IRC or Matrix?

Sadly, not yet. Several times tried to check what that Matrix is, but still...

Sorry for silence. Was busy with work.

I've pushed a branch called "controls2_port" (not "controls2", that is an old one). It would be great if you could test this branch with the changes from this diff if it also works for you. At least the metadata view for the tracks does not scale correctly right now.
Also, for a future version with a full port to controls2, it would be good to know if we can rely on Qt's built-in scaling, so could you please test your port to 2.3 with the setting of "QApplication::setAttribute(Qt::AA_EnableHighDpiScaling);" in the main.cpp file, but without the changes from this diff?

This branch has fine font even with fractional scaling. But still it has the same clipping of text/buttons without this patch in my case when scaling set to 1 and DPI to 144.

PS: how controls2_port looks without this patch: https://photos.app.goo.gl/8ZEFwZA23Lhb61Lk1

Sat, Feb 17, 11:21 AM · Elisa
mykolak added a comment to D10460: To make theme size depend on DPI.
In D10460#207155, @asn wrote:

Are you on IRC or Matrix?

Sat, Feb 17, 10:47 AM · Elisa

Fri, Feb 16

progwolff removed a watcher for Elisa: progwolff.
Fri, Feb 16, 6:41 PM
asn added a comment to D10460: To make theme size depend on DPI.

Alexander, I think you should also cherr-pick the two patches from my repo which set pixmap hidpi and use pointSize instead of pixelSize for fonts.

Fri, Feb 16, 6:27 PM · Elisa
astippich added a comment to D10460: To make theme size depend on DPI.

Great, thanks a lot for testing. +1 from me for this patch then

Fri, Feb 16, 6:23 PM · Elisa

Thu, Feb 15

asn added a comment to D10460: To make theme size depend on DPI.

I would say this looks pretty good!

Thu, Feb 15, 10:29 PM · Elisa
astippich added a comment to D10460: To make theme size depend on DPI.
In D10460#207217, @asn wrote:

Alexander, wit the elisa-hidpi-qtquickcontrols2.3.patch everything seems to work. So I think the first step is to move to qt quick controls 2. If you can point me to your patch, I can test it with my changes.

Thu, Feb 15, 8:20 PM · Elisa
asn added a comment to D10460: To make theme size depend on DPI.

Alexander, wit the elisa-hidpi-qtquickcontrols2.3.patch everything seems to work. So I think the first step is to move to qt quick controls 2. If you can point me to your patch, I can test it with my changes.

Thu, Feb 15, 6:54 PM · Elisa
astippich added a comment to D10144: Various general and RTL fixes.

Please also rebase/merge with current master

Would you please do that instead? I'm not really that much into git :(

Thu, Feb 15, 6:29 PM · Elisa