ElisaProject
ActivePublic

Recent Activity

Yesterday

januz closed D14015: New header style for playlist.
Sun, Jul 15, 11:35 PM · Elisa
januz added a comment to T7884: file browser.
  • Names in both dolphin and elisa are aligned to the center

Do you mean this as a wish? They are left aligned, which is also consistent with the other views.

Sun, Jul 15, 11:34 PM · Elisa
astippich requested review of D14126: add ability to load playlists from file browser.
Sun, Jul 15, 9:11 AM · Elisa
astippich added a comment to T7884: file browser.

sorry for the late response, I lost track when I was busy with work.

Sun, Jul 15, 8:48 AM · Elisa
astippich claimed T7576: port to controls2.
Sun, Jul 15, 8:08 AM · Elisa
astippich moved T7576: port to controls2 from Backlog to In Progress on the Elisa board.
Sun, Jul 15, 8:07 AM · Elisa
astippich moved T6255: Add support for cover images embedded in tracks from In Progress to Backlog on the Elisa board.
Sun, Jul 15, 8:07 AM · Elisa
astippich requested changes to D14120: Tweak inital state for playlist.
Sun, Jul 15, 8:00 AM · Elisa
astippich accepted D14015: New header style for playlist.

looking great!

Sun, Jul 15, 7:17 AM · Elisa
astippich updated the summary of D13872: introduce ElisaToolButton and use it in MediaPlayerControl.
Sun, Jul 15, 7:03 AM · Elisa
astippich added a reviewer for D13872: introduce ElisaToolButton and use it in MediaPlayerControl: januz.
Sun, Jul 15, 7:02 AM · Elisa

Sat, Jul 14

januz added a project to D14120: Tweak inital state for playlist: Elisa.
Sat, Jul 14, 11:07 PM · Elisa
januz updated the diff for D14015: New header style for playlist.
  • Reverse clear list icon
  • Add ellipsis on load/save texts (for tooltips)
Sat, Jul 14, 9:37 PM · Elisa
mgallien added a comment to D14015: New header style for playlist.

Looks like ToolButtons ignore text. I managed to hack this by shoving a Text object inside them but it really messes up the layout and only the icon is clickable.

I think having icons only would be fine, that's what tooltips are for anyways :)

@mgallien, @astippich What do you think about the clear icon? Should we revert back to the line (current one) or bump KF to 5.48 to use the new broom icon?

Sat, Jul 14, 9:19 PM · Elisa
astippich added a comment to D14015: New header style for playlist.

imho only toolbuttons is fine.
I would suggest to keep the old icon for now, since it is also somewhat unrelated to the rest. You can change it afterwards when Elisa requires KF 5.48. Since it was just released, it is probably a little bit too early.

Sat, Jul 14, 1:14 PM · Elisa
astippich added a comment to D13685: allow metadata of tracks without album and tracknumber in database.

I've significantly reduced the scope of this revision by only allowing empty albums and track numbers in the database. After this, I would like to work on empty artists, and then finally empty titles

Sat, Jul 14, 1:10 PM · Elisa
astippich updated the test plan for D13685: allow metadata of tracks without album and tracknumber in database.
Sat, Jul 14, 1:09 PM · Elisa
astippich updated the diff for D13685: allow metadata of tracks without album and tracknumber in database.
  • rebase
  • only allow tracks without album for now
  • enhance tests for removing tracks with incomplete metadata
Sat, Jul 14, 1:08 PM · Elisa
januz added a comment to D14015: New header style for playlist.

Looks like ToolButtons ignore text. I managed to hack this by shoving a Text object inside them but it really messes up the layout and only the icon is clickable.

Sat, Jul 14, 12:34 AM · Elisa

Fri, Jul 13

ngraham added a comment to D14015: New header style for playlist.

I mean they could be buttons with:

  • no visible borders (the borders appear on hover)
  • the icon on top, rather than on the side
Fri, Jul 13, 9:30 PM · Elisa
januz added a comment to D14015: New header style for playlist.

How about putting the icons on top and making them toolbuttons without a visible button-looking border? There's plenty of unused vertical space there, and square buttons might fit well in the available space.

Fri, Jul 13, 2:31 PM · Elisa
ngraham added a comment to D14015: New header style for playlist.

How about putting the icons on top and making them toolbuttons without a visible button-looking border? There's plenty of unused vertical space there, and square buttons might fit well in the available space.

Fri, Jul 13, 2:21 PM · Elisa
januz added a comment to D14015: New header style for playlist.

There is some room, but it ends up looking more cramped.

Fri, Jul 13, 2:19 PM · Elisa
januz updated the diff for D14015: New header style for playlist.

Replace menu with buttons

Fri, Jul 13, 2:17 PM · Elisa
ngraham added a comment to D14015: New header style for playlist.

Might there even be room for buttons with text?

Fri, Jul 13, 2:08 PM · Elisa
januz added a comment to D14015: New header style for playlist.

Hey guys, yeah there's room for the 4 buttons up there. The main pro for the dropdown was having text for the buttons that modified the playlist, but having the buttons could also simplify things. Sorry I keep forgetting about reversed mode

Fri, Jul 13, 2:00 PM · Elisa
ngraham added a comment to D14015: New header style for playlist.

Yeah, it looks like there's room for some buttons up on top without needing a drop-down menu.

Fri, Jul 13, 12:55 PM · Elisa

Thu, Jul 12

astippich added a comment to D14015: New header style for playlist.

I like the idea of removing the bar at the bottom, but imho the actions should either be all accessible through the menu or still have dedicated buttons, for consistency. Isn't there enough space to add 4 actions instead?

Thu, Jul 12, 7:46 PM · Elisa
januz added a comment to D14018: [WIP] Make labels in header bar clickeable.

@mgallien Thanks!

Thu, Jul 12, 1:22 AM · Elisa
januz closed D13834: Allow playlist to be hidden.
Thu, Jul 12, 1:21 AM · Elisa

Wed, Jul 11

mgallien accepted D13834: Allow playlist to be hidden.

Thanks

Wed, Jul 11, 6:58 PM · Elisa
januz added inline comments to D13834: Allow playlist to be hidden.
Wed, Jul 11, 5:41 PM · Elisa
januz updated the diff for D13834: Allow playlist to be hidden.

Bring back goBack action

Wed, Jul 11, 5:41 PM · Elisa
mgallien added a comment to D14018: [WIP] Make labels in header bar clickeable.

This patch isn't finished yet. I've come across a problem with the album view: the openOneAlbum() function requires a databaseID to get the album data but I have no way of getting that in the header bar. I looked around the headerbarmanager code for a bit but I have no idea how we could fetch that. Everything else works.

Wed, Jul 11, 5:09 PM · Elisa
mgallien requested changes to D13834: Allow playlist to be hidden.
Wed, Jul 11, 3:54 PM · Elisa
januz added a comment to D13834: Allow playlist to be hidden.

I don't quite understand what you guys mean by a different workflow.

I downloaded Lollypop to try it out, but the workflow is almost the same as Elisa for me. There's a global playlist (in a popup), if you click the play button the playlist is cleared and replaced, and you can click the + button to enqueue.

(offtopic: I'm really digging those giant cover images)

I do not know Lolypop very well. I meant players in general where you do not see an explicit global playlist but where you just play the music currently shown.
Some people kept asking for an iTunes like behavior. I also do not know it but I understood that it was optimized to work well without a global playlist.

Wed, Jul 11, 3:46 PM · Elisa
mgallien added a comment to D13834: Allow playlist to be hidden.

Thanks for your work.

Wed, Jul 11, 3:46 PM · Elisa
hantzv claimed T6293: Fix HeaderBar for missing animations.

I have played a bit with QML, I expect to do okay. But if the team already have something in mind, I'll be glad to implement it.

Wed, Jul 11, 6:07 AM · Elisa
mgallien updated subscribers of T6293: Fix HeaderBar for missing animations.

I will mostly be away from keyboard for the next three weeks. If you have questions do not hesitate to also ask in the mailing list. @januz and @ngraham can also help the design of a working solution.
Welcome to the Elisa project

Wed, Jul 11, 6:02 AM · Elisa
hantzv added a comment to T6293: Fix HeaderBar for missing animations.

What type of animation should be there? I'm thinking a sliding of the whole background followed by the information (title, album name, etc) fading in.

Wed, Jul 11, 5:57 AM · Elisa
mgallien added a comment to D13834: Allow playlist to be hidden.

I don't quite understand what you guys mean by a different workflow.

I downloaded Lollypop to try it out, but the workflow is almost the same as Elisa for me. There's a global playlist (in a popup), if you click the play button the playlist is cleared and replaced, and you can click the + button to enqueue.

(offtopic: I'm really digging those giant cover images)

Wed, Jul 11, 5:56 AM · Elisa
mgallien closed T8953: Improve detection of different albums as Resolved.
Wed, Jul 11, 5:54 AM · Elisa
mgallien moved T8953: Improve detection of different albums from In Progress to Done on the Elisa board.
Wed, Jul 11, 5:53 AM · Elisa
mgallien moved T9181: Fix enqueue of genre from Junior Jobs to In Progress on the Elisa board.
Wed, Jul 11, 5:53 AM · Elisa
mgallien claimed T9181: Fix enqueue of genre.
Wed, Jul 11, 5:53 AM · Elisa
mgallien triaged T9181: Fix enqueue of genre as Unbreak Now! priority.
Wed, Jul 11, 5:53 AM · Elisa
mgallien created T9181: Fix enqueue of genre.
Wed, Jul 11, 5:53 AM · Elisa
mgallien requested changes to D14015: New header style for playlist.

Thanks for your work.
I have two remarks.

Wed, Jul 11, 5:44 AM · Elisa
mgallien raised the priority of T6293: Fix HeaderBar for missing animations from Normal to Unbreak Now!.

Hi, can you elaborate a bit more on what needs to be done on this?

What needs to be fixed?

Wed, Jul 11, 5:30 AM · Elisa
hantzv added a comment to T6293: Fix HeaderBar for missing animations.

Hi, can you elaborate a bit more on what needs to be done on this?

Wed, Jul 11, 4:18 AM · Elisa