ElisaProject
ActivePublic

Recent Activity

Fri, May 17

ngraham added a comment to D21081: fix focus rectangle not visible in single album view mode.

This is functionally much better! Now I can tell where the keyboard focus is. Visually I think it's a small improvement but we can do even better for the list and grid items and also be more consistent with how other apps generally handle this.

Fri, May 17, 10:00 PM · Elisa
mgallien updated the diff for D21081: fix focus rectangle not visible in single album view mode.
  • use a rectangle around the current item with focus in view selector
  • use rectangle borders to show the active focus in most elements
Fri, May 17, 6:42 PM · Elisa

Mon, May 13

ngraham added a member for Elisa: ngraham.
Mon, May 13, 9:33 PM
ngraham removed a watcher for Elisa: ngraham.
Mon, May 13, 9:33 PM
mgallien closed D21039: avoid sending wrong or empty metadata to mpris2 interface.
Mon, May 13, 8:11 PM · Elisa
ngraham accepted D21039: avoid sending wrong or empty metadata to mpris2 interface.

Works for me, thanks.

Mon, May 13, 6:01 PM · Elisa

Sun, May 12

mgallien added a comment to D21039: avoid sending wrong or empty metadata to mpris2 interface.

Ping.
I would like if possible to get this in before end of next week to have in the 0.4.0 release.

Sun, May 12, 8:07 PM · Elisa

Wed, May 8

ngraham added a comment to D21080: fix some layouts to look correct when reversed (typical for RTL locale).

Looks good now! BTW it's unrelated to this patch, but I notice that song length display in the playlist has regressed in the last day or two:

Wed, May 8, 3:36 PM · Elisa
mgallien added a comment to D21081: fix focus rectangle not visible in single album view mode.

This works, but to be honest I really dislike this focus rectangle in every view where it appears in Elisa. I don't think it matches Elisa's visual style at all. See how the blue rectangle touches the vertical line on the left, but it's a few pixels away from the line on the right? And it also isn't actually framing anything since Elisa's views don't use gray frames. So it appears "out of the blue", so to speak.

I feel like a cleaner focus indication style for a modern app like Elisa is to highlight the particular control or list itemthat currently has focus, rather than drawing a colored frame around an entire view. For example in your screenshots, instead of drawing a blue frame to indicate that the view has focus, I would make the song highlight blue rather than gray. This actually communicates more information: not only does it tell you that the view has focus, but you also clearly see which exact element within the view has focus.

Wed, May 8, 2:41 PM · Elisa
mgallien closed D21080: fix some layouts to look correct when reversed (typical for RTL locale).
Wed, May 8, 2:33 PM · Elisa
ngraham accepted D21080: fix some layouts to look correct when reversed (typical for RTL locale).

Looks good now! BTW it's unrelated to this patch, but I notice that song length display in the playlist has regressed in the last day or two:

Wed, May 8, 2:17 PM · Elisa
safaalfulaij accepted D21080: fix some layouts to look correct when reversed (typical for RTL locale).

Can't test, but seems fine.
Thanks for informing! :)

Wed, May 8, 2:12 PM · Elisa
mgallien closed D21043: do not extend mouse areas in header bar longer than the text.
Wed, May 8, 2:12 PM · Elisa
ngraham added a comment to D21081: fix focus rectangle not visible in single album view mode.

This works, but to be honest I really dislike this focus rectangle in every view where it appears in Elisa. I don't think it matches Elisa's visual style at all. See how the blue rectangle touches the vertical line on the left, but it's a few pixels away from the line on the right? And it also isn't actually framing anything since Elisa's views don't use gray frames. So it appears "out of the blue", so to speak.

Wed, May 8, 2:11 PM · Elisa
ngraham accepted D21043: do not extend mouse areas in header bar longer than the text.

This looks much better, thanks. It makes sense that font.pointSize should be rounded to an integer value.

Wed, May 8, 1:58 PM · Elisa
mgallien retitled D21081: fix focus rectangle not visible in single album view mode from GIT_SILENT made messages (after extraction) to fix focus rectangle not visible in single album view mode.
Wed, May 8, 1:29 PM · Elisa
mgallien updated the diff for D21081: fix focus rectangle not visible in single album view mode.

try to include only the correct commit

Wed, May 8, 1:28 PM · Elisa
mgallien updated the diff for D21081: fix focus rectangle not visible in single album view mode.

an extra commit from 0.4 is included

Wed, May 8, 1:27 PM · Elisa
mgallien added a project to D21081: fix focus rectangle not visible in single album view mode: Elisa.
Wed, May 8, 1:26 PM · Elisa
mgallien added a comment to D21043: do not extend mouse areas in header bar longer than the text.

This now works!

However I'm left to wonder why all this rigamarole with TextMetrics is even necessary at all. I notice that if I remove all the TextMetrics components, and let the labels auto-size themselves by removing Layout.fillWidth and Layout.maximumWidth, everything works fine except for the artist label, which gets elided. But I notice that it only gets elided when the point size is set to elisaTheme.defaultFontPointSize * 1.5. If I change the multiplier to 1, 1.4 or 2, it works. However a multiplier of 1.5, 1.75, or any other odd value triggers the bug. This is reproducible for all fonts and sizes that I tried.

I don't understand this bug, but a less invasive workaround might be simply to change the multiplier a bit rather than do all this stuff with TextMetrics.

Wed, May 8, 12:47 PM · Elisa
mgallien added a project to D21080: fix some layouts to look correct when reversed (typical for RTL locale): Elisa.
Wed, May 8, 12:46 PM · Elisa
mgallien added reviewers for D21039: avoid sending wrong or empty metadata to mpris2 interface: astippich, ngraham.
Wed, May 8, 9:08 AM · Elisa
mgallien updated the diff for D21043: do not extend mouse areas in header bar longer than the text.
  • use Math.round to avoid having a font.pointSize being decimal
Wed, May 8, 9:07 AM · Elisa

Tue, May 7

ngraham accepted D21043: do not extend mouse areas in header bar longer than the text.

This now works!

Tue, May 7, 6:43 PM · Elisa
mgallien updated the diff for D21043: do not extend mouse areas in header bar longer than the text.
  • fix corner cases by adding an extra length
Tue, May 7, 5:58 PM · Elisa

Mon, May 6

ngraham added a comment to D21043: do not extend mouse areas in header bar longer than the text.

I'm afraid even with this latest update to the patch, I still see elided text. :(

Mon, May 6, 8:55 PM · Elisa
mgallien added a comment to D21043: do not extend mouse areas in header bar longer than the text.

11 pt Ubuntu font. I see the same thing with default 10 pt Noto Sans though:

As you can see, it's even worse with default settings since the four-letter album name gets elided too.

Mon, May 6, 8:50 PM · Elisa
mgallien updated the diff for D21043: do not extend mouse areas in header bar longer than the text.
  • use the correct way to get the width of the text
Mon, May 6, 8:49 PM · Elisa
ngraham added a comment to D21043: do not extend mouse areas in header bar longer than the text.

11 pt Ubuntu font. I see the same thing with default 10 pt Noto Sans though:

Mon, May 6, 8:41 PM · Elisa
mgallien added a comment to D21043: do not extend mouse areas in header bar longer than the text.

For me this patch re-introduces the original bug (https://bugs.kde.org/show_bug.cgi?id=406483).

Mon, May 6, 7:53 PM · Elisa
James added a comment to T6356: Integrate visualization branch.

Would this be for music visualizations, by chance? As in spectrum analyzers, etc?

Mon, May 6, 5:45 PM · Elisa
ngraham requested changes to D21043: do not extend mouse areas in header bar longer than the text.

For me this patch re-introduces the original bug (https://bugs.kde.org/show_bug.cgi?id=406483).

Mon, May 6, 3:30 PM · Elisa
mgallien added a project to D21043: do not extend mouse areas in header bar longer than the text: Elisa.
Mon, May 6, 5:29 AM · Elisa
mgallien added a comment to D21039: avoid sending wrong or empty metadata to mpris2 interface.

Does Plasma crash because of this or Elisa?

Mon, May 6, 5:10 AM · Elisa

Sun, May 5

broulik added a comment to D21039: avoid sending wrong or empty metadata to mpris2 interface.

Does Plasma crash because of this or Elisa?

Sun, May 5, 9:29 PM · Elisa
mgallien added a project to D21039: avoid sending wrong or empty metadata to mpris2 interface: Elisa.
Sun, May 5, 8:58 PM · Elisa
trmdi added a comment to D21006: Add global menu by using qml native menu components.

Currently, Elisa is not really an application built around the idea of having a big and complex application menu bar.
This is the reason why you see only one menu.

Sun, May 5, 8:52 AM · Elisa

Sat, May 4

mgallien added a comment to D21006: Add global menu by using qml native menu components.

Why is it like this:

instead of this?

I mean, can we have some more Menu instead of only Elisa ?

Sat, May 4, 7:50 PM · Elisa
mgallien added a comment to D21006: Add global menu by using qml native menu components.

Seems to work perfectly. My only UI suggestion is to hide the hamburger button in the window when exporting the menu like this.

Sat, May 4, 7:49 PM · Elisa
trmdi added a comment to D21006: Add global menu by using qml native menu components.

Why is it like this:

Sat, May 4, 8:08 AM · Elisa
ngraham added a comment to D21006: Add global menu by using qml native menu components.

Seems to work perfectly. My only UI suggestion is to hide the hamburger button in the window when exporting the menu like this.

Sat, May 4, 3:27 AM · Elisa

Fri, May 3

mgallien added a project to D21006: Add global menu by using qml native menu components: Elisa.
Fri, May 3, 8:25 PM · Elisa
ngraham added a comment to D20879: do not forget the album cover when using embedded cover images.

So much better now!

Fri, May 3, 1:43 PM · Elisa
mgallien closed D20944: fix upgrades from 0.3 stable version.
Fri, May 3, 5:06 AM · Elisa
mgallien closed D20879: do not forget the album cover when using embedded cover images.
Fri, May 3, 5:06 AM · Elisa

Thu, May 2

ngraham accepted D20879: do not forget the album cover when using embedded cover images.
Thu, May 2, 9:56 PM · Elisa
ngraham accepted D20944: fix upgrades from 0.3 stable version.

Yep, a cleanup of my Baloo database fixed it, so that looks like a Baloo bug rather than an Elisa bug. Upgrade works now.

Thu, May 2, 9:56 PM · Elisa
mgallien added a comment to D20944: fix upgrades from 0.3 stable version.

I'm not sure whether it's related to this or not, but now I get stuck on a particular song again. I can paste the full log, but the last item seems revelant:

org.kde.elisa.baloo: LocalBalooFileListing::triggerRefreshOfContent "/home/nate/Music/Franz Ferdinand/Franz Ferdinand/10 Come On Home.mp3" file does not exists

Sure enough, I deleted that song a few days ago.

Thu, May 2, 8:35 PM · Elisa
ngraham added a comment to D20944: fix upgrades from 0.3 stable version.

I'm not sure whether it's related to this or not, but now I get stuck on a particular song again. I can paste the full log, but the last item seems revelant:

Thu, May 2, 7:00 PM · Elisa

Wed, May 1

mgallien added a project to D20944: fix upgrades from 0.3 stable version: Elisa.
Wed, May 1, 8:33 PM · Elisa