ElisaProject
ActivePublic

Recent Activity

Fri, Apr 20

ngraham added a comment to D12317: implement and enable sorting in the views.

I sticked to the current icon until we get a better one. An arrow alone is also not very meaningful

Fri, Apr 20, 1:40 PM · Elisa
astippich added a comment to D12317: implement and enable sorting in the views.

unsorted would be the order in which the tracks were added to the library, which is not useful in my opinion. I would chose to default to ascending.

Fri, Apr 20, 1:33 PM · Elisa
astippich updated the diff for D12317: implement and enable sorting in the views.
  • implement a toggle button for sorting
Fri, Apr 20, 1:25 PM · Elisa
mgallien claimed T8562: Upgrade KPackage API usage to remove warning at CMake time.
Fri, Apr 20, 7:52 AM · Elisa
mgallien moved T8562: Upgrade KPackage API usage to remove warning at CMake time from Backlog to In Progress on the Elisa board.
Fri, Apr 20, 7:52 AM · Elisa
mgallien triaged T8562: Upgrade KPackage API usage to remove warning at CMake time as High priority.
Fri, Apr 20, 7:51 AM · Elisa

Wed, Apr 18

ngraham added a comment to D12317: implement and enable sorting in the views.

Could you try to have one single button with three states ?

  • first state: no sort
  • second state: sorted in ascending order
  • third state: sorted in descending order
Wed, Apr 18, 9:59 PM · Elisa
mgallien added a comment to D12317: implement and enable sorting in the views.

Thanks Alex for your work.

Wed, Apr 18, 9:57 PM · Elisa
ngraham added a comment to D12317: implement and enable sorting in the views.

Also, ascending and descending sorting are mutually exclusive, and one is always used. So I would recommend making the buttons into toggles rather than pushbuttons, and have one always be visually in the checked state.

Wed, Apr 18, 7:03 PM · Elisa
ngraham added a comment to D12317: implement and enable sorting in the views.

FWIW, Here are my votes for sensible defaults for the other views

  • Artist: sort artists alphabetically, then sort their albums by year
  • Album: sort alphabetically
Wed, Apr 18, 7:00 PM · Elisa
astippich added a comment to D12317: implement and enable sorting in the views.

There are alphabetically sorted, it's just in the all tracks view that the track number is additionally taken into account. But yes, localization is a valid point. I could just use an arrow up and down instead

Wed, Apr 18, 5:58 PM · Elisa
ngraham added a comment to D12317: implement and enable sorting in the views.

Looks like we'll ideally need more icons, because that one currently implies alphabetical sorting with the A and the Z in it. Also those icons don't exactly localize well...

Wed, Apr 18, 5:50 PM · Elisa
astippich requested review of D12319: implement a generic listview.
Wed, Apr 18, 5:33 PM · Elisa
astippich added a comment to D12317: implement and enable sorting in the views.

Screenshot of the all tracks view:

Wed, Apr 18, 5:30 PM · Elisa
astippich requested review of D12317: implement and enable sorting in the views.
Wed, Apr 18, 5:29 PM · Elisa

Tue, Apr 17

ngraham added a watcher for Elisa: ngraham.
Tue, Apr 17, 6:43 PM
Aiix removed a commit from T8175: Mycroft AI - Elisa official control skill: R846:8f804a11d0fc: Add pulleyitem for quick fav feature.
Tue, Apr 17, 10:37 AM · MyCroft Integration, Elisa
Aiix added a commit to T8175: Mycroft AI - Elisa official control skill: R846:8f804a11d0fc: Add pulleyitem for quick fav feature.
Tue, Apr 17, 10:32 AM · MyCroft Integration, Elisa
Aiix added a revision to T8175: Mycroft AI - Elisa official control skill: D12274: Add pulleyitem for quick fav feature.
Tue, Apr 17, 10:31 AM · MyCroft Integration, Elisa

Mon, Apr 16

astippich closed D11673: implement shortcut to toggle filter view.
Mon, Apr 16, 5:31 PM · Elisa

Sun, Apr 15

astippich abandoned D11819: don't display tracknumber in the main label for all tracks view.

Ok, let's drop this. The issue with the numbers in the first screenshot is that we do not have proper sorting implemented, which I'm working on.

Sun, Apr 15, 4:06 PM · Elisa
ngraham requested changes to D11819: don't display tracknumber in the main label for all tracks view.

Hmm, not sure I like this. Having the tracks in the header seems more user-friendly than shunting them off to the album line, with which which they have no visual or logical connection.

Sun, Apr 15, 1:04 PM · Elisa
mgallien accepted D11673: implement shortcut to toggle filter view.

Thanks. Unfortunately, I will have very few available time the next few days.

Sun, Apr 15, 10:38 AM · Elisa
astippich added a comment to D11673: implement shortcut to toggle filter view.

ping

Sun, Apr 15, 9:36 AM · Elisa
astippich added inline comments to D11678: move manageaudio to c++.
Sun, Apr 15, 9:34 AM · Elisa
astippich added a reviewer for D11819: don't display tracknumber in the main label for all tracks view: VDG.

The initial reasoning was that I've added sorting to each view, and decided to sort by title for the all tracks view (no option to choose different sort "columns" currently) and then it just looked weird, because the numbers were totally scattered.
Since then I found this sorting option not to be very intuitive at all and implemented sorting that takes more information into account, where it looks just fine.
One could still argue that for an all tracks view the title is the most important aspect and not its position in an album, but I'm also not super convinced about this one anymore. So I'm fine with dropping this patch entirely or wait until we get feedback from the VDG.
@VDG any opinions?

Sun, Apr 15, 9:31 AM · Elisa

Sat, Apr 14

ssteffen added a watcher for Elisa: ssteffen.
Sat, Apr 14, 8:13 AM

Fri, Apr 13

mgallien added a comment to D11819: don't display tracknumber in the main label for all tracks view.

Well, I find the look to be very strange. It looks different from the playlist even if both can be seen at the same time.

Fri, Apr 13, 9:16 PM · Elisa
mgallien added a comment to D11678: move manageaudio to c++.

Thanks.
I am reviewing it.
I have one question.

Fri, Apr 13, 9:13 PM · Elisa
lcmscheid added a watcher for Elisa: lcmscheid.
Fri, Apr 13, 3:33 PM

Thu, Apr 12

astippich closed D11674: use shared code for searching for cover.
Thu, Apr 12, 5:05 PM · Elisa
mgallien accepted D11674: use shared code for searching for cover.

Sorry

Thu, Apr 12, 4:16 PM · Elisa
mgallien added a comment to D11674: use shared code for searching for cover.

Sorry for the delay. I was pretty sure that I had accepted it. This may be frustrating for you.

Thu, Apr 12, 4:16 PM · Elisa
mgallien requested changes to D11674: use shared code for searching for cover.
Thu, Apr 12, 4:16 PM · Elisa
mgallien added a comment to D11674: use shared code for searching for cover.

Sorry for the delay. I was pretty sure that I had accepted it. This may be frustrating for you.

Thu, Apr 12, 4:16 PM · Elisa

Sun, Apr 8

raddison added a watcher for Elisa: raddison.
Sun, Apr 8, 11:05 PM

Sat, Apr 7

astippich claimed T7884: file browser.
Sat, Apr 7, 6:35 PM · Elisa
0x64c removed a member for Elisa: 0x64c.
Sat, Apr 7, 2:11 AM
0x64c added a member for Elisa: 0x64c.
Sat, Apr 7, 2:09 AM

Fri, Mar 30

astippich added a comment to D11819: don't display tracknumber in the main label for all tracks view.

Before

Fri, Mar 30, 8:10 PM · Elisa
astippich requested review of D11819: don't display tracknumber in the main label for all tracks view.
Fri, Mar 30, 8:08 PM · Elisa
mgallien renamed T6700: Improve Baloo Support and Add Automatic Tests from Monitor Baloo Status and Notify User to Improve Baloo Support and Add Automatic Tests.
Fri, Mar 30, 3:25 PM · Elisa
mgallien moved T6700: Improve Baloo Support and Add Automatic Tests from Backlog to In Progress on the Elisa board.
Fri, Mar 30, 3:25 PM · Elisa
mgallien closed T8345: Fix shadows of first line elements i grid views as Resolved.
Fri, Mar 30, 3:24 PM · Elisa
mgallien moved T8345: Fix shadows of first line elements i grid views from In Progress to Done on the Elisa board.
Fri, Mar 30, 3:24 PM · Elisa
michaelh added a comment to T8196: KFileMetadata: String lists. How do clients cope?.

With this multi-value-map pattern in https://phabricator.kde.org/D10694?id=30858 baloo-widgets is having trouble and displays only the first subject.
I'm trying to adapt baloo-widgets, but it is quite difficult and takes a lot of (ugly) code or a major re-write.
In contrast: If kfilemetadata would return string lists the adaption could be done with 2 lines of code. I'll have to look, but my guess is adapting baloo to handle string lists is easier.
Preliminary conclusion: I very much prefer the string list version.

Fri, Mar 30, 11:10 AM · Dolphin, Elisa, Frameworks, Baloo

Wed, Mar 28

astippich retitled D11673: implement shortcut to toggle filter view from implememt shortcut to toggle filter view to implement shortcut to toggle filter view.
Wed, Mar 28, 5:30 PM · Elisa
astippich added a comment to D11673: implement shortcut to toggle filter view.

The state of the view is only controlled by a property binding to an external variable. This is already tested with the tests. The code for setting this variable via a shortcut is in the main qml file and cannot be tested here.

Wed, Mar 28, 5:30 PM · Elisa
astippich closed D11755: increase min width of Elisa window.
Wed, Mar 28, 5:27 PM · Elisa

Tue, Mar 27

nicolasfella added a watcher for Elisa: nicolasfella.
Tue, Mar 27, 9:23 PM