I removed the override.
- remove function override
As an example, I did try this:
I have spent some more time looking at your patch and fail to see the rationale behind the way tooltips are added. Did you try the ToolTip attached property ? That would be the "good" way to do it.
I do not understand your intent with this patch. Especially the way you provide a special ToolButton with a lot of things in it.
Please explain better why each element in ElisaToolButton is here ?
Mon, Sep 17
I cannot really comment on the technical side of things as I am unfamiliar with it, so only tested as usual. Also a small reduction in memory usage here, and works fine.
You have again some changes for the theme file included which should not be here after rebase.
In order to avoid polluting the mediaplaylist with a QMimeDataBase, I decided to move the handling to the proxy model. Let me know what you think.
- rename enums, handle loading of playlist differently
I forgot for a second that you don't need video support. Well I'm not entirely sure if QtAV supports many audio formats, but it depends on ffmpeg which I believe support many. I have very little knowledge here and just wanted to add some info about the existence of QtAV :)
Sun, Sep 16
Digikam switched to QtAV once and they said it's better for cross-platform. It also has a QML interface and a similar API to Qt Multimedia. I think you should check that first before VLC.
Fri, Sep 14
Thu, Sep 13
- restore previous behavior of album cover margins again
okay, wiped everything and retried, works now and this patch fixes the bug
The different titles are no longer aligned. Please fix that. It is important that the album title is aligned with tracks title.
yes, elisa does not show any tracks first, but if baloo is enabled they start to appear
rebase on top of 0.3 branch
I already did that, and in both cases tracks showed up. will try once more
ping. would be a shame to let this one go to waste so close to merging
I can't reproduce. What's the exact test plan?
Wed, Sep 12
Tue, Sep 11