ElisaProject
ActivePublic

Recent Activity

Yesterday

mgallien accepted D15486: disable sorting for single album view.
Wed, Sep 19, 8:17 PM · Elisa
mgallien added a project to D15607: Gives immediate focus to the search entry control after pressing the shortcut to show it: Elisa.
Wed, Sep 19, 8:16 PM · Elisa
astippich added a comment to D15486: disable sorting for single album view.

I removed the override.

Wed, Sep 19, 7:56 PM · Elisa
astippich updated the diff for D15486: disable sorting for single album view.
  • remove function override
Wed, Sep 19, 7:55 PM · Elisa
astippich added a comment to D13872: introduce ElisaToolButton and use it in MediaPlayerControl.

I do not understand your intent with this patch. Especially the way you provide a special ToolButton with a lot of things in it.
Please explain better why each element in ElisaToolButton is here ?

Wed, Sep 19, 7:53 PM · Elisa
aureliencouderc added a watcher for Elisa: aureliencouderc.
Wed, Sep 19, 7:39 PM
shustinm added a member for Elisa: shustinm.
Wed, Sep 19, 6:30 PM
shustinm added a watcher for Elisa: shustinm.
Wed, Sep 19, 5:47 PM
mgallien added a comment to D13872: introduce ElisaToolButton and use it in MediaPlayerControl.

As an example, I did try this:

Wed, Sep 19, 3:44 PM · Elisa
mgallien added a comment to D13872: introduce ElisaToolButton and use it in MediaPlayerControl.

I have spent some more time looking at your patch and fail to see the rationale behind the way tooltips are added. Did you try the ToolTip attached property ? That would be the "good" way to do it.

Wed, Sep 19, 3:32 PM · Elisa
mgallien added a comment to D13872: introduce ElisaToolButton and use it in MediaPlayerControl.

I do not understand your intent with this patch. Especially the way you provide a special ToolButton with a lot of things in it.
Please explain better why each element in ElisaToolButton is here ?

Wed, Sep 19, 5:41 AM · Elisa
mgallien requested changes to D15486: disable sorting for single album view.
Wed, Sep 19, 5:35 AM · Elisa

Mon, Sep 17

mgallien closed D15456: makes data classes be implicitely shared: decrease memory usage.
Mon, Sep 17, 8:43 PM · Elisa
astippich accepted D15456: makes data classes be implicitely shared: decrease memory usage.

I cannot really comment on the technical side of things as I am unfamiliar with it, so only tested as usual. Also a small reduction in memory usage here, and works fine.
You have again some changes for the theme file included which should not be here after rebase.

Mon, Sep 17, 8:03 PM · Elisa
astippich added a comment to D14126: add ability to load playlists from file browser.

In order to avoid polluting the mediaplaylist with a QMimeDataBase, I decided to move the handling to the proxy model. Let me know what you think.

Mon, Sep 17, 5:51 PM · Elisa
astippich updated the diff for D14126: add ability to load playlists from file browser.
  • rename enums, handle loading of playlist differently
Mon, Sep 17, 5:50 PM · Elisa
astippich closed D15484: add margins for playing indicator.
Mon, Sep 17, 5:09 PM · Elisa
safaalfulaij added a comment to T7184: Explore using VLC as an alternative to Qt Multimedia on desktop targets.

I forgot for a second that you don't need video support. Well I'm not entirely sure if QtAV supports many audio formats, but it depends on ffmpeg which I believe support many. I have very little knowledge here and just wanted to add some info about the existence of QtAV :)

Mon, Sep 17, 6:25 AM · Elisa

Sun, Sep 16

mgallien added a comment to T7184: Explore using VLC as an alternative to Qt Multimedia on desktop targets.

Digikam switched to QtAV once and they said it's better for cross-platform. It also has a QML interface and a similar API to Qt Multimedia. I think you should check that first before VLC.

Sun, Sep 16, 7:47 PM · Elisa
safaalfulaij added a comment to T7184: Explore using VLC as an alternative to Qt Multimedia on desktop targets.

Digikam switched to QtAV once and they said it's better for cross-platform. It also has a QML interface and a similar API to Qt Multimedia. I think you should check that first before VLC.

Sun, Sep 16, 6:46 PM · Elisa
mgallien renamed T7184: Explore using VLC as an alternative to Qt Multimedia on desktop targets from Explore switching to Phonon on desktop targets to Explore using VLC as an alternative to Qt Multimedia on desktop targets.
Sun, Sep 16, 10:06 AM · Elisa
mgallien updated the task description for T9641: Publish Elisa in the Microsoft Store.
Sun, Sep 16, 10:01 AM · Elisa, Windows

Fri, Sep 14

mgallien accepted D15484: add margins for playing indicator.
Fri, Sep 14, 5:18 AM · Elisa

Thu, Sep 13

astippich added a comment to D15484: add margins for playing indicator.

The different titles are no longer aligned. Please fix that. It is important that the album title is aligned with tracks title.

Thu, Sep 13, 8:14 PM · Elisa
astippich updated the summary of D15484: add margins for playing indicator.
Thu, Sep 13, 8:13 PM · Elisa
astippich updated the diff for D15484: add margins for playing indicator.
  • restore previous behavior of album cover margins again
Thu, Sep 13, 8:12 PM · Elisa
astippich abandoned D15200: fix margins and size for playlist entry.
Thu, Sep 13, 8:03 PM · Elisa
mgallien closed D15298: fix handling of baloo starting after elisa.
Thu, Sep 13, 7:50 PM · Elisa
astippich accepted D15298: fix handling of baloo starting after elisa.

okay, wiped everything and retried, works now and this patch fixes the bug

Thu, Sep 13, 7:44 PM · Elisa
mgallien requested changes to D15484: add margins for playing indicator.

The different titles are no longer aligned. Please fix that. It is important that the album title is aligned with tracks title.

Thu, Sep 13, 7:35 PM · Elisa
astippich added a comment to D15298: fix handling of baloo starting after elisa.

yes, elisa does not show any tracks first, but if baloo is enabled they start to appear

Thu, Sep 13, 7:33 PM · Elisa
astippich requested review of D15486: disable sorting for single album view.
Thu, Sep 13, 7:31 PM · Elisa
mgallien updated the diff for D15456: makes data classes be implicitely shared: decrease memory usage.

rebase on top of 0.3 branch

Thu, Sep 13, 7:10 PM · Elisa
mgallien added a comment to D15298: fix handling of baloo starting after elisa.

I already did that, and in both cases tracks showed up. will try once more

Thu, Sep 13, 7:09 PM · Elisa
astippich added a comment to D15298: fix handling of baloo starting after elisa.

I already did that, and in both cases tracks showed up. will try once more

Thu, Sep 13, 6:55 PM · Elisa
mgallien added a comment to D15298: fix handling of baloo starting after elisa.

I can't reproduce. What's the exact test plan?

Thu, Sep 13, 6:06 PM · Elisa
astippich added a comment to D15484: add margins for playing indicator.

Before

Thu, Sep 13, 5:55 PM · Elisa
astippich requested review of D15484: add margins for playing indicator.
Thu, Sep 13, 5:54 PM · Elisa
astippich updated the summary of D13685: allow metadata of tracks without album and tracknumber in database.
Thu, Sep 13, 5:16 PM · Elisa
astippich added a comment to D14120: Tweak inital state for playlist.

ping. would be a shame to let this one go to waste so close to merging

Thu, Sep 13, 5:14 PM · Elisa
astippich added a comment to D15298: fix handling of baloo starting after elisa.

I can't reproduce. What's the exact test plan?

Thu, Sep 13, 5:12 PM · Elisa
astippich closed D15434: remove brightness contrast in favor of opacity.
Thu, Sep 13, 5:11 PM · Elisa

Wed, Sep 12

mgallien added reviewers for D15456: makes data classes be implicitely shared: decrease memory usage: astippich, januz, ognarb.
Wed, Sep 12, 3:46 PM · Elisa
mgallien added a project to D15456: makes data classes be implicitely shared: decrease memory usage: Elisa.
Wed, Sep 12, 3:45 PM · Elisa

Tue, Sep 11

mgallien added a comment to D15200: fix margins and size for playlist entry.

Yes, this is supposed to fix the issue with the album header. The removal of the brightness contrast is actually unrelated to this, but it seemed unnecessary while looking at it.

Imho if adding a simple margin setting to an item in an unrelated qml row leads to these bugs, this code is quite fragile. I also don't know what all the math is about for a simple layout margin of an image for the main icon.

I have created D15322 with a proper fix for the album header bad handling of different font sizes.
This is a general problem in many layout in Elisa, they do not play nicely with different font sizes.
I fail to see how this review deal with this.

Now I am a bit confused. Is this the root cause? Can 0d5fbd5474eb now be applied again? Because I think it looks more polished and consistent if the indicator has some margin like everything else.
I factored out the changes with the BrightnessContrast into D15434 since they are unrelated

Tue, Sep 11, 8:06 PM · Elisa
mgallien accepted D15434: remove brightness contrast in favor of opacity.

Thanks

Tue, Sep 11, 8:04 PM · Elisa
astippich added a comment to D15200: fix margins and size for playlist entry.

Yes, this is supposed to fix the issue with the album header. The removal of the brightness contrast is actually unrelated to this, but it seemed unnecessary while looking at it.

Imho if adding a simple margin setting to an item in an unrelated qml row leads to these bugs, this code is quite fragile. I also don't know what all the math is about for a simple layout margin of an image for the main icon.

I have created D15322 with a proper fix for the album header bad handling of different font sizes.
This is a general problem in many layout in Elisa, they do not play nicely with different font sizes.
I fail to see how this review deal with this.

Tue, Sep 11, 6:55 PM · Elisa
astippich updated the summary of D15434: remove brightness contrast in favor of opacity.
Tue, Sep 11, 6:54 PM · Elisa
astippich added a comment to D15434: remove brightness contrast in favor of opacity.

Before

Tue, Sep 11, 6:54 PM · Elisa
astippich requested review of D15434: remove brightness contrast in favor of opacity.
Tue, Sep 11, 6:52 PM · Elisa