ElisaProject
ActivePublic

Recent Activity

Wed, Nov 22

mgallien placed T5375: Add Management of Ratings for Tracks from Local Files up for grabs.
Wed, Nov 22, 9:52 PM · Elisa
mgallien placed T6293: Fix HeaderBar for missing animations up for grabs.
Wed, Nov 22, 9:52 PM · Elisa
mgallien placed T6294: In all views, provide play now and enqueue buttons up for grabs.
Wed, Nov 22, 9:52 PM · Elisa
mgallien placed T6255: Add support for cover images embedded in tracks up for grabs.
Wed, Nov 22, 9:52 PM · Elisa
mgallien placed T6345: Add a detail view of a track metadata up for grabs.
Wed, Nov 22, 9:52 PM · Elisa
mgallien added inline comments to D8895: enhance content view navigation.
Wed, Nov 22, 9:32 PM · Elisa
mgallien added a comment to D8895: enhance content view navigation.

It was not working for me until I have added a method pointer to the creation of the standard action. I have added a private empty slot.

Wed, Nov 22, 9:23 PM · Elisa
astippich closed D8876: reset stackview to initial item when selected via ViewSelector.
Wed, Nov 22, 6:48 PM · Elisa

Tue, Nov 21

mgallien added a comment to D8876: reset stackview to initial item when selected via ViewSelector.

No, please go.
Do not worry.
In the full play list view, there is an artist name with an icon. I had the idea to allow to use that to navigate to the artist view. The idea is maybe worth using everywhere.

Tue, Nov 21, 9:12 PM · Elisa
astippich added a comment to D8876: reset stackview to initial item when selected via ViewSelector.

I don't want to break your workflow. Maybe we should wait and commit once an alternative is in place?

Tue, Nov 21, 9:08 PM · Elisa
astippich closed D8875: change icons in playlist entry.
Tue, Nov 21, 9:06 PM · Elisa
astippich closed D8877: make text vertically aligned to center for NavigationActionBar.
Tue, Nov 21, 9:04 PM · Elisa
mgallien accepted D8876: reset stackview to initial item when selected via ViewSelector.

OK, let's go for that.
I will miss the ability to explore both an album and the associated artist. I will add a task to phabricator for that but with a dedicated UI (or buttons).

Tue, Nov 21, 8:50 PM · Elisa
astippich added a comment to D8876: reset stackview to initial item when selected via ViewSelector.

To be honest, I think that would be worse. The user will not know which view will be opened without any visual feedback. This would look random and maybe even like a bug to someone not knowing the internals. The existing behavior is better than a time-dependent button, I think.

Tue, Nov 21, 8:23 PM · Elisa
astippich added a comment to D8895: enhance content view navigation.

I made the button configurable. I am unsure if this is the right way to use KStandardAction with QML so please check carefully. The back action in MediaBrowser gets triggered via a signal. This has the nice effect that forcing the focus becomes unnecessary.

Tue, Nov 21, 8:20 PM · Elisa
astippich updated the diff for D8895: enhance content view navigation.
  • make go back action configurable
Tue, Nov 21, 8:17 PM · Elisa

Sun, Nov 19

mgallien added a comment to D8895: enhance content view navigation.

Thanks for that.

Sun, Nov 19, 8:26 PM · Elisa
mgallien added a comment to D8876: reset stackview to initial item when selected via ViewSelector.

Thanks for that.
I give some thoughts to your proposed change.
I think that it would work for you and for me if you would add a timer to only do the move after some time (in the order of seconds).
Sometime, I am switching between two view mode quite fast. In this case, I would prefer to keep the current state. At the same time, I agree with your rationale.
What do you think ?

Sun, Nov 19, 8:02 PM · Elisa
astippich added a comment to D8875: change icons in playlist entry.

I will commit once (and if) I get commit access (applied yesterday). The opacity is animated (already was before) , but with a very short duration (50ms) which is barely noticable but is consistent with MediaTracksDelegate, for example.

Sun, Nov 19, 11:33 AM · Elisa
astippich added a comment to D8895: enhance content view navigation.

This makes navigating the content much nicer for me, but I'm not entirely sure if the focus changes are the right way to go. Please let me know if there are any side effects with this for you.

Sun, Nov 19, 11:23 AM · Elisa
astippich created D8895: enhance content view navigation.
Sun, Nov 19, 11:19 AM · Elisa
astippich updated the diff for D8876: reset stackview to initial item when selected via ViewSelector.

reset to the original changes

Sun, Nov 19, 10:53 AM · Elisa
astippich added a comment to D8876: reset stackview to initial item when selected via ViewSelector.

something went wrong here, arcanist somehow thought that it should update this revision, but it should have created a new one

Sun, Nov 19, 10:49 AM · Elisa
astippich updated the diff for D8876: reset stackview to initial item when selected via ViewSelector.
  • accept backspace key for backwards navigation
  • remove unnecessary names for StateChangeScript
  • Merge branch 'mouse_clicks' into content_view_navigation
  • force active focus upon opening so that key navigation works
  • add backward navigation with mouse
  • revert selecting initial item, for separate bracnh
  • Merge branch 'master' into content_view_navigation
  • Merge branch 'master' into content_view_navigation
Sun, Nov 19, 10:47 AM · Elisa

Sat, Nov 18

mgallien added a comment to D8877: make text vertically aligned to center for NavigationActionBar.

Thanks for your work.
OK, please push it. I am a bit distracted by the size difference from the title font and the album artist font.

Sat, Nov 18, 9:46 PM · Elisa
mgallien accepted D8875: change icons in playlist entry.

Thanks for your work.
Please land it via arcanist. I do remember when I did push my first contributions myself some years ago.
As a later step, would you mind adding animations on the opacity of the buttons ?

Sat, Nov 18, 9:42 PM · Elisa
astippich added a comment to D8877: make text vertically aligned to center for NavigationActionBar.

I like it the way it is. It is the same as for the album delegates, e.g. compare the margin for the delegates in picture 3 and for picture 4. But I can add some more margin if you prefer.

Sat, Nov 18, 5:06 PM · Elisa
astippich updated the diff for D8875: change icons in playlist entry.

Sorry for the bug, somehow an inverted condition slipped through. I thought I tested it thoroughly, but obviously not enough.
Also shortened the animation duration.

Sat, Nov 18, 5:00 PM · Elisa
mgallien added a comment to D8875: change icons in playlist entry.

Thanks for this change.
I tested it and it is nice.
I noticed that when in pause, the button stay visible behind the clear button. When playing, you only see the button on top of the play indicator. Could you try to improve that ?

Sat, Nov 18, 4:23 PM · Elisa
mgallien accepted D8877: make text vertically aligned to center for NavigationActionBar.

Thanks for this. What do you think about improving a little bit the margin between Album title and album artist ?

Sat, Nov 18, 3:34 PM · Elisa
astippich added a comment to D8877: make text vertically aligned to center for NavigationActionBar.

Before:

Sat, Nov 18, 9:57 AM · Elisa
astippich created D8877: make text vertically aligned to center for NavigationActionBar.
Sat, Nov 18, 9:56 AM · Elisa
astippich added a comment to D8876: reset stackview to initial item when selected via ViewSelector.

Personally I expect this behavior (same button always has same effect). If you disagree, feel free to just close this revision.

Sat, Nov 18, 9:26 AM · Elisa
astippich created D8876: reset stackview to initial item when selected via ViewSelector.
Sat, Nov 18, 9:25 AM · Elisa
astippich added a comment to D8875: change icons in playlist entry.

Feedback would be welcome on the animation duration, I set it to the same value as the entry color is changed. Just while writing this I thought that it is probably best to set it to the same duration as the icons appear, i.e. 50 ms, and not 200ms.

Sat, Nov 18, 9:12 AM · Elisa
astippich created D8875: change icons in playlist entry.
Sat, Nov 18, 9:07 AM · Elisa

Fri, Nov 17

mgallien added a watcher for Elisa: mgallien.
Fri, Nov 17, 9:39 PM

Fri, Nov 10

astippich added a member for Elisa: astippich.
Fri, Nov 10, 6:36 PM

Wed, Nov 8

mgallien closed D8729: fix mouse interaction and dragging while LabelWithTooltip is truncated.
Wed, Nov 8, 8:14 PM · Elisa
mgallien accepted D8729: fix mouse interaction and dragging while LabelWithTooltip is truncated.

It would probably be a good idea that you add yourself to the elisa group.
I also would like to recommend you for a kde developer account. Could you have a look at the following page: https://community.kde.org/Infrastructure/Get_a_Developer_Account#How_to_get_read-write_access_to_git.2Fsvn .
I will push this one and the next should be done by you.

Wed, Nov 8, 8:09 PM · Elisa
astippich updated the summary of D8729: fix mouse interaction and dragging while LabelWithTooltip is truncated.
Wed, Nov 8, 8:06 PM · Elisa
astippich updated the diff for D8729: fix mouse interaction and dragging while LabelWithTooltip is truncated.
  • use Qt.NoButton as a cleaner fix
Wed, Nov 8, 8:05 PM · Elisa
astippich added inline comments to D8729: fix mouse interaction and dragging while LabelWithTooltip is truncated.
Wed, Nov 8, 8:03 PM · Elisa
mgallien added inline comments to D8729: fix mouse interaction and dragging while LabelWithTooltip is truncated.
Wed, Nov 8, 7:50 PM · Elisa
mgallien added a comment to D8729: fix mouse interaction and dragging while LabelWithTooltip is truncated.

Thanks for your work. This is really appreciated especially because I lack time to care as much as you for those little details that are very important.
I have one question/comment .

Wed, Nov 8, 7:48 PM · Elisa
astippich created D8729: fix mouse interaction and dragging while LabelWithTooltip is truncated.
Wed, Nov 8, 6:49 PM · Elisa

Sun, Nov 5

mgallien closed D8393: Improvements to playListEntry.
Sun, Nov 5, 8:14 PM · Elisa
mgallien added a comment to D8393: Improvements to playListEntry.

Your idea is what I had in mind but achieved through some blur effect combined with some opacity to guarantee the visibility of the two buttons.
I will let you do that since I am working on bugs related to the music import and the music database.
I will push this revision and will review the next one. Keep doing your contributions, I am very happy to have such a good help.

Sun, Nov 5, 8:01 PM · Elisa
malbx removed a watcher for Elisa: malbx.
Sun, Nov 5, 5:08 PM
astippich added a comment to D8393: Improvements to playListEntry.

I can give it a try again when I find some time. But could you elaborate a little bit on what you have in mind? I don't fully understand.

Sun, Nov 5, 5:04 PM · Elisa