ElisaProject
ActivePublic

Recent Activity

Yesterday

ssteffen removed a watcher for Elisa: ssteffen.
Sun, Nov 18, 12:23 PM
astippich added a project to D16953: Port notification to qqc2: Elisa.
Sun, Nov 18, 11:39 AM · Elisa
astippich added a project to D16952: Port browsing delegates to qqc2: Elisa.
Sun, Nov 18, 11:39 AM · Elisa
astippich added a project to D16950: Port navigation bar to qqc2: Elisa.
Sun, Nov 18, 11:39 AM · Elisa
astippich added a project to D16948: Port qml media playlist entirely to qqc2: Elisa.
Sun, Nov 18, 11:38 AM · Elisa
astippich added a project to D16944: Port application menu to qqc2: Elisa.
Sun, Nov 18, 11:38 AM · Elisa
astippich requested review of D16975: Move all platform-agnostic files related to scanning into one folder.
Sun, Nov 18, 11:37 AM · Elisa

Sat, Nov 17

mgallien added a comment to D16302: improve database performance and reliability.

Since this revision is quite large, it's probably difficult to review it properly. I'm going to let it run a little and report back in case I find any issues.

Sat, Nov 17, 8:48 PM · Elisa
astippich updated the diff for D16194: move metadata scanning to trackslistener.
  • rebase
  • cleanup
Sat, Nov 17, 4:13 PM · Elisa
astippich added a comment to D16302: improve database performance and reliability.

Since this revision is quite large, it's probably difficult to review it properly. I'm going to let it run a little and report back in case I find any issues.

Sat, Nov 17, 3:17 PM · Elisa
mgallien updated the diff for D16302: improve database performance and reliability.
  • allow tracks without artist
Sat, Nov 17, 3:14 PM · Elisa
mgallien updated the diff for D16302: improve database performance and reliability.
  • reduce overhead from AllTracksModel
  • reduce overhead of AllAlbumsModel and make it synchronous
  • do not list files too early from Baloo
  • keep all files discovered from a source and fix a minor related issue
  • add a test for DatabaseInterface::askRestoredTracks
  • add albums and artists cache and improve cache usage
  • improve management of files not modified since last scan of music files
Sat, Nov 17, 2:14 PM · Elisa
astippich added a comment to D15195: consolidate handling of title fallback into MusicAudioTrack.

ping

Sat, Nov 17, 9:12 AM · Elisa
astippich closed D16193: add a test for tracks with empty artist tag in database.
Sat, Nov 17, 9:11 AM · Elisa
astippich closed D13872: create a FlatButtonWithToolTip component for MediaPlayerControl.
Sat, Nov 17, 9:11 AM · Elisa
astippich closed D16362: use rating and comment stored in metadata tags.
Sat, Nov 17, 9:10 AM · Elisa
astippich added a comment to D16362: use rating and comment stored in metadata tags.

thanks

Sat, Nov 17, 9:10 AM · Elisa
mgallien accepted D13872: create a FlatButtonWithToolTip component for MediaPlayerControl.
Sat, Nov 17, 8:38 AM · Elisa
mgallien accepted D16362: use rating and comment stored in metadata tags.

Sorry for the delay

Sat, Nov 17, 8:36 AM · Elisa
astippich claimed T6255: Add support for cover images embedded in tracks.
Sat, Nov 17, 8:31 AM · Elisa

Tue, Nov 13

mgallien updated the summary of D16302: improve database performance and reliability.
Tue, Nov 13, 6:39 AM · Elisa
mgallien retitled D16302: improve database performance and reliability from [WIP] improve database performance and reliability to improve database performance and reliability.
Tue, Nov 13, 6:38 AM · Elisa
mgallien updated the diff for D16302: improve database performance and reliability.
  • reduce overhead from AllTracksModel
  • reduce overhead of AllAlbumsModel and make it synchronous
  • do not list files too early from Baloo
  • keep all files discovered from a source and fix a minor related issue
  • add a test for DatabaseInterface::askRestoredTracks
  • add albums and artists cache and improve cache usage
  • improve management of files not modified since last scan of music files
Tue, Nov 13, 6:38 AM · Elisa

Sun, Nov 4

astippich retitled D13872: create a FlatButtonWithToolTip component for MediaPlayerControl from create a ButtonWithToolTip component for MediaPlayerControl to create a FlatButtonWithToolTip component for MediaPlayerControl.
Sun, Nov 4, 10:50 AM · Elisa
astippich added a comment to D13872: create a FlatButtonWithToolTip component for MediaPlayerControl.

D16659 and its dependent revision will allow to remove custom styling in the future

Sun, Nov 4, 10:48 AM · Elisa
astippich updated the diff for D13872: create a FlatButtonWithToolTip component for MediaPlayerControl.
  • rename to FlatButtonWithToolTip
Sun, Nov 4, 10:47 AM · Elisa

Fri, Nov 2

astippich added inline comments to D16362: use rating and comment stored in metadata tags.
Fri, Nov 2, 8:06 PM · Elisa
astippich added a comment to D13872: create a FlatButtonWithToolTip component for MediaPlayerControl.

I lack time until next week for a proper review.

Fri, Nov 2, 8:01 PM · Elisa
mgallien added a comment to D13872: create a FlatButtonWithToolTip component for MediaPlayerControl.

see D16284

I have been working on this subject to help come this diff come to a conclusion. Thanks for your work on this as it is important.

I believe that we have been overusing ToolButton at places just to get a flat look instead of doing the proper job (i.e. customizing the look of a Button component).

I also better understand (thanks to D16284) why we get icon+text. I believe that this will not change as it is done on purpose to maximize compatibility with QWidget equivalent of ToolButton. We are the guilty ones here given we had used ToolButton components in places where we expected a custom behavior (i.e. no text).

I have a private (at the moment) branch with no QQCv1 components. There are several regressions. I had kept overusing ToolButton like in master branch.

I would like to try to come up with a long term and maintainable solution for each of our button cases:

  • flat button with text and icon ;
  • flat button with tooltip and icon ;
  • flat round button with icon ;

    The result should be fully usable with keyboard only, mouse+keyboard and touch screens. That means that ToolButton as is is not the solution because the focus behavior is not going to work for keyboard only usage. Our solution should work with org.kde.desktop and Fusion style (at least).

I've gone ahead and factored out the current button code that was copied all over in MediaPlayerControl. As it is now, it's mostly a refactoring only with the exception that actions are now used.
Imho we don't need a round button anymore.
If you agree on the implementation, I will roll this out to all qqc1 toolbuttons in the views and playlist.

Fri, Nov 2, 9:37 AM · Elisa
mgallien added inline comments to D16362: use rating and comment stored in metadata tags.
Fri, Nov 2, 9:14 AM · Elisa

Thu, Nov 1

astippich added a comment to D13872: create a FlatButtonWithToolTip component for MediaPlayerControl.

see D16284

I have been working on this subject to help come this diff come to a conclusion. Thanks for your work on this as it is important.

I believe that we have been overusing ToolButton at places just to get a flat look instead of doing the proper job (i.e. customizing the look of a Button component).

I also better understand (thanks to D16284) why we get icon+text. I believe that this will not change as it is done on purpose to maximize compatibility with QWidget equivalent of ToolButton. We are the guilty ones here given we had used ToolButton components in places where we expected a custom behavior (i.e. no text).

I have a private (at the moment) branch with no QQCv1 components. There are several regressions. I had kept overusing ToolButton like in master branch.

I would like to try to come up with a long term and maintainable solution for each of our button cases:

  • flat button with text and icon ;
  • flat button with tooltip and icon ;
  • flat round button with icon ;

    The result should be fully usable with keyboard only, mouse+keyboard and touch screens. That means that ToolButton as is is not the solution because the focus behavior is not going to work for keyboard only usage. Our solution should work with org.kde.desktop and Fusion style (at least).
Thu, Nov 1, 7:43 PM · Elisa
astippich updated the summary of D13872: create a FlatButtonWithToolTip component for MediaPlayerControl.
Thu, Nov 1, 7:39 PM · Elisa
astippich updated the diff for D13872: create a FlatButtonWithToolTip component for MediaPlayerControl.
  • do not use toolbutton
Thu, Nov 1, 7:37 PM · Elisa
astippich added a comment to D14018: [WIP] Make labels in header bar clickeable.

I think you need to install the Qt5CorePrivate development files

Thu, Nov 1, 3:38 PM · Elisa

Wed, Oct 31

astippich added a comment to D13872: create a FlatButtonWithToolTip component for MediaPlayerControl.

see D16284

I have been working on this subject to help come this diff come to a conclusion. Thanks for your work on this as it is important.

I believe that we have been overusing ToolButton at places just to get a flat look instead of doing the proper job (i.e. customizing the look of a Button component).

I also better understand (thanks to D16284) why we get icon+text. I believe that this will not change as it is done on purpose to maximize compatibility with QWidget equivalent of ToolButton. We are the guilty ones here given we had used ToolButton components in places where we expected a custom behavior (i.e. no text).

Wed, Oct 31, 9:38 PM · Elisa
astippich added inline comments to D16362: use rating and comment stored in metadata tags.
Wed, Oct 31, 9:32 PM · Elisa
shustinm removed a watcher for Elisa: shustinm.
Wed, Oct 31, 9:21 PM
astippich updated the diff for D16193: add a test for tracks with empty artist tag in database.
  • additional fix for the test
Wed, Oct 31, 8:27 PM · Elisa

Tue, Oct 30

mgallien added a comment to D13872: create a FlatButtonWithToolTip component for MediaPlayerControl.

see D16284

Tue, Oct 30, 11:09 AM · Elisa

Sat, Oct 27

januz added a comment to D14018: [WIP] Make labels in header bar clickeable.

I tried to take another look at this, but after rebasing on master I started getting an error when building:

Sat, Oct 27, 10:28 PM · Elisa

Fri, Oct 26

mgallien added inline comments to D16362: use rating and comment stored in metadata tags.
Fri, Oct 26, 5:03 AM · Elisa

Tue, Oct 23

astippich added a comment to D16193: add a test for tracks with empty artist tag in database.

Since this test is currently failing, shall I land it and it will be fixed afterwards?

Tue, Oct 23, 6:25 PM · Elisa
mgallien accepted D16193: add a test for tracks with empty artist tag in database.

Nice, thanks

Tue, Oct 23, 3:26 PM · Elisa

Mon, Oct 22

astippich added a comment to D15015: initial support for android music indexer and a very small kirigami2 UI.

Thanks. I have two more comments inline.

Mon, Oct 22, 4:46 PM · Elisa

Sun, Oct 21

astippich added a project to D16362: use rating and comment stored in metadata tags: Elisa.
Sun, Oct 21, 7:18 PM · Elisa

Oct 19 2018

astippich planned changes to D16194: move metadata scanning to trackslistener.
Oct 19 2018, 7:01 AM · Elisa

Oct 18 2018

astippich added a comment to D13872: create a FlatButtonWithToolTip component for MediaPlayerControl.

see D16284

Oct 18 2018, 6:01 PM · Elisa
mgallien updated the diff for D15015: initial support for android music indexer and a very small kirigami2 UI.
  • let kirigami be required only on Android
Oct 18 2018, 4:50 PM · Elisa
mgallien triaged T9896: Add support for music indexing on Android as High priority.
Oct 18 2018, 4:40 PM · Elisa
mgallien added a project to D15015: initial support for android music indexer and a very small kirigami2 UI: Elisa.
Oct 18 2018, 4:40 PM · Elisa