Add photographic user avatars
ClosedPublic

Authored by filipf on May 3 2020, 10:58 PM.

Details

Summary

This patch adds 20 photographic avatars in order to finish work on T9910.

Sylistically they are simple and with only a single topic in focus.

Sizes are 512x512, the formats .png. They've been tested with our circular avatar template and cropped to fit it well.

All are crops of strictly CC0 licensed images from Pexels. License information has also been supplied.

Closes T9910

Test Plan

Diff Detail

Repository
R128 User Manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
filipf created this revision.May 3 2020, 10:58 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 3 2020, 10:58 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.May 3 2020, 10:58 PM
ngraham edited the summary of this revision. (Show Details)May 3 2020, 11:02 PM

Love the images! Do they actually show up for you in the KCM though? They don't for me.

The permissions are wrong if we do sudo make install (the photos folder ends up being root owned). But it doesn't show up with make install either. Will investigate more in the morning.

filipf added a comment.May 4 2020, 6:49 AM

Alright, I believe the issue is with the fact that the avatar gallery is coded to always look for avatars in the system /usr/share dir as opposed to adjusting to testing conditions and using the local /usr/share dir.

sudo cp -r kde/usr/share/user-manager/avatars/photos/ /usr/share/user-manager/avatars/

And now they show up, despite using the locally installed user-manager. If we used the workflow where kdesrc-build installs directly to system the patch should work and consequently IRL as well.

filipf updated this revision to Diff 81838.May 4 2020, 6:52 AM

Better file naming

filipf updated this revision to Diff 81839.May 4 2020, 6:53 AM

probably don't want to include the .directory file

ognarb added a subscriber: ognarb.EditedMay 4 2020, 10:14 AM

Photo using the Unsplash license can't be included in our repositories. The license is not considered open-source :( We should contact the artists if they are willing to license their photographies under a creative commons license (not the noncommercial and the no edit one)

Photo using the Unsplash license can't be included in our repositories. The license is not considered open-source :( We should contact the artists if they are willing to license their photographies under a creative commons license (not the noncommercial and the no edit one)

T9910#229073

ngraham added a subscriber: cblack.May 4 2020, 2:18 PM

Great, that works. I suppose there's no point in fixing that bug since this KCM is being re-done anyway in D28154. Once this lands, @cblack can grab these and add them to that patch.

However I see duplicates for the space shuttle, hot air balloon, and Rubik's cube.


In terms of the actual images themselves:

This is an improvement, for sure. But what happened to the noodle bowl? I loved that one!

I can't help but notice that a lot of these images are sort of de-saturated or sepia-toned. I feel like a bit more saturation would make them pop better.

The gamepad image is quite dark and low contrast. It's kind of hard to see the gamepad itself:

The Leopard image is great, but maybe it could be zoomed in a bit so the leopard takes up more of the frame? It's kinda tiny:

filipf added a comment.May 4 2020, 3:49 PM

Great, that works. I suppose there's no point in fixing that bug since this KCM is being re-done anyway in D28154. Once this lands, @cblack can grab these and add them to that patch.

Yeah I would agree. The user gallery in the current KCM is also something that should be improved (bigger previews, two lines of text) but no point in fiddling with it.

However I see duplicates for the space shuttle, hot air balloon, and Rubik's cube.

Yeah I renamed those after the first revision so they're leftovers.

This is an improvement, for sure. But what happened to the noodle bowl? I loved that one!

Which one in T9910? We can still add some more avatars IMO.

I can't help but notice that a lot of these images are sort of de-saturated or sepia-toned. I feel like a bit more saturation would make them pop better.

I definitely have to replace the air baloon pic, it's the worst one saturation-wise.

The gamepad image is quite dark and low contrast. It's kind of hard to see the gamepad itself:

Indeed, the problem with gamepads was finding a pic that doesn't have a logo. It's possible the Rubik's cube and the keyboard suffice for nerds, but I'll try to find something else related to gaming.

The Leopard image is great, but maybe it could be zoomed in a bit so the leopard takes up more of the frame? It's kinda tiny:

Will do in the next revision.

This is an improvement, for sure. But what happened to the noodle bowl? I loved that one!

Which one in T9910? We can still add some more avatars IMO.

Pho 2

I also liked Greek Architecture and Colorful Chalk. Including those would increase the overall colorfulness and saturation of the new images. I also really like Snail both because I think it's adorable, and also because I think it would be really ballsy to include. :)

...Or maybe I'm just a weirdo who likes snails a lot.

filipf updated this revision to Diff 81955.EditedMay 4 2020, 10:42 PM

Drop:

  • Air Balloon
  • Gamepad

Add:

  • Architecture
  • Food
  • Chalk
  • Snail

Change:

  • Embiggen the leopard
ngraham accepted this revision.May 4 2020, 11:11 PM

Everything looks great to me!

Now go ask for re-licensing, I suppose.

This revision is now accepted and ready to land.May 4 2020, 11:11 PM

After additional consideration, I'm not too happy with the car avatar but I did find this:

Speaking of licences, I assume I can leave the CC0 ones at CC0, while the rest should be CC-BY-SA 4.0 as per KDE licencing policy for images?

We can't use anything under that Pexels licence, it's non-free.

Unsplash and CC0 are good to use. They both explicitly don't need attribution (which is pretty generous), but it's nice to do so and helps clarity in future.

Preferably use this format https://reuse.software/tutorial/ making a LICENCE/ directory with the licence text in it and cat.jpg.license with the SPDX header

CC-0 or any license compatible with CC-BY-SA-4.0 are fine.

The Unsplash license is non-free too: "This license does not include the right to compile photos from Unsplash to replicate a similar or competing service. ".

filipf added a comment.Thu, May 7, 6:21 PM

IANAL but the Pexels and Unsplash licence look the same to me: free to distribute, free to modify, no attribution needed, but don't use it to make a Pexels/Unsplash clone. Someone once noted that neither exists in some FOSS licence database. I'll just ask everyone to do CC0 but we'll still credit them. Thanks @ognarb and @jriddell.

Oh yes I made the rookie error of not reading to the end, Unsplash is not free and we can't use it.

filipf updated this revision to Diff 82662.Tue, May 12, 2:08 PM
  • Remove all Unsplash and Pexels licensed photos to avoid complications.
  • Use CC0 pictures from Pexels instead
  • Licence files to be added

Some pictures I didn't include in case people like them:


(yes the Leopard is nice but the circular cropping eats too much into it)

With these licensing issues no longer being a problem, we can now finalize this today and tomorrow to avoid doing it during the feature freeze.

ngraham accepted this revision.Tue, May 12, 5:54 PM

Awesome. Love the pancakes, the gecko, and the new gaming controller. Much nicer.

I really like Doggo, AirBalloon, Pencils, and Sushi, and think those might be worth including as well. I also kind of like Fish too!

Chip seems like it might be a bit hard to distinguish what's going on.

Overall very nice. I'd like to get these in for 5.19 so I'm accepting now despite the request to include a few more. If you don't want to add those or it becomes controversial, we can just land the patch in its current form.

filipf updated this revision to Diff 82693.Tue, May 12, 7:55 PM
  • rename Gecko to Chameleon because that wasn't a gecko
  • remove Chip
  • add Air Balloon, Dog, Fish, Owl, Pencils, Sushi
  • WIP: licence files
filipf updated this revision to Diff 82694.Tue, May 12, 7:58 PM

actually remove Chip and Gecko(due to rename)

ngraham accepted this revision.Tue, May 12, 8:16 PM

Perfecto.

filipf updated this revision to Diff 82697.Tue, May 12, 9:03 PM

Use this format https://reuse.software/tutorial/ making a LICENCE/ directory with the licence text in it and cat.jpg.license with the SPDX header

filipf edited the summary of this revision. (Show Details)Tue, May 12, 9:08 PM

@jriddell, does this licensing situation look sane?

filipf updated this revision to Diff 82732.Wed, May 13, 1:12 PM

rework licensing stucture due to a flaw in user_manager (it shows every single file in the avatar gallery and the .license files break it)

filipf edited the test plan for this revision. (Show Details)Wed, May 13, 1:17 PM

Looks good for licence freedom

Could you make the licence info in format specified at https://reuse.software/tutorial/ ? It's what we want to use from now on in KDE.

So add cat.jpg.license files with SPDX header lines saying CC0 and add /LICENSES/CC0-1.0.txt

Looks good for licence freedom

Could you make the licence info in format specified at https://reuse.software/tutorial/ ? It's what we want to use from now on in KDE.

So add cat.jpg.license files with SPDX header lines saying CC0 and add /LICENSES/CC0-1.0.txt

I want to go for that format and have tried it but unfortunately the avatar gallery has issues with .license files being present

It tries to show them even if they're not images.

We should have a new and improved users kcm for 5.20 so I was thinking of reworking the licensing structure then.

The .license files could live in another folder. Maybe src/pics_sources?

The .license files could live in another folder. Maybe src/pics_sources?

Yeah I can do that as well

filipf updated this revision to Diff 82746.Wed, May 13, 2:31 PM

Make as REUSE compliant as possible

filipf updated this revision to Diff 82748.Wed, May 13, 2:32 PM

don't delete user_manager.kdev4

ngraham accepted this revision.Wed, May 13, 3:43 PM

Shipit!

This revision was automatically updated to reflect the committed changes.