Differential D29802

Require out-of-source builds
ClosedPublic
Actions

Authored by ngraham on May 16 2020, 7:47 PM.

Details

Reviewers
ognarb
davidre
apol
nicolasfella
ndavis
tfella
filipf
cblack
Group Reviewers
Frameworks
VDG
Commits
R266:7abe60d96609: Require in-source build
Summary

In addition to just being a good idea in general, the dynamic icon
generation bit doesn't work properly with in-source builds. Let's
formally require out-of-source builds.

BUG: 421637
FIXED-IN: 5.71

Test Plan

Try out of source build, get yelled at

Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.May 16 2020, 7:47 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 16 2020, 7:47 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.May 16 2020, 7:47 PM
ognarb accepted this revision.May 16 2020, 7:50 PM
This revision is now accepted and ready to land.May 16 2020, 7:50 PM
davidre requested changes to this revision.May 16 2020, 7:55 PM
davidre added a subscriber: davidre.

I don't think we want to require in source builds

This revision now requires changes to proceed.May 16 2020, 7:55 PM
ltoscano added a subscriber: ltoscano.May 16 2020, 8:03 PM

I believe a few sentences in the the commit message contradicts each other.

ngraham retitled this revision from Require in-source build to Require out-of-source builds.May 16 2020, 8:09 PM
davidre accepted this revision.May 16 2020, 8:18 PM
This revision is now accepted and ready to land.May 16 2020, 8:18 PM
apol accepted this revision.May 17 2020, 12:31 PM
nicolasfella accepted this revision.May 17 2020, 1:09 PM
ndavis accepted this revision.May 17 2020, 2:00 PM
tfella accepted this revision.May 17 2020, 2:05 PM
filipf accepted this revision.May 17 2020, 2:17 PM
cblack accepted this revision.May 17 2020, 4:45 PM
ngraham added a comment.May 17 2020, 5:11 PM

I think this patch meets the world record for number of acceptances!

Closed by commit R266:7abe60d96609: Require in-source build (authored by ngraham). · Explain WhyMay 17 2020, 5:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (5 lines)

Diff 83021

View Options

CMakeLists.txt

Loading...