Differential D27688

Set minimum window size
ClosedPublic
Actions

Authored by filipf on Feb 26 2020, 11:35 PM.

Details

Reviewers
apol
ngraham
Group Reviewers
VDG
Plasma
Commits
R474:e924691dd15b: Set minimum window size
Summary

Kamoso currently doesn't have a minimum window size set so it can be resized into a short vertical line.

This patch sets a minimum window size that matches the 240p webcam resolution (320x240) when the toolbar is subtracted.

Test Plan

Before:
At its smallest

After:
At its smallest

Diff Detail

Repository
R474 Kamoso
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
filipf requested review of this revision.Feb 26 2020, 11:35 PM
filipf created this revision.
filipf edited the summary of this revision. (Show Details)Feb 26 2020, 11:36 PM
filipf edited the test plan for this revision. (Show Details)
filipf added reviewers: apol, VDG, Plasma.
filipf added a comment.Apr 19 2020, 7:02 PM

friendly ping

ngraham accepted this revision.Apr 19 2020, 10:27 PM
ngraham added a subscriber: ngraham.

Whoops! Sorry this got missed.

This revision is now accepted and ready to land.Apr 19 2020, 10:27 PM
filipf added a comment.May 2 2020, 8:17 AM

I can't land this at all, do I have to clone from Invent?

ngraham added a comment.May 3 2020, 2:01 AM

Ah, I didn't realize that Kamoso had moved to invent. You need to change the remote to point to the new gitlab URL: git remote set-url origin git@invent.kde.org:kde/kamoso.git

Then arc land should work as normal.

Closed by commit R474:e924691dd15b: Set minimum window size (authored by filipf). · Explain WhyMay 3 2020, 8:59 AM
This revision was automatically updated to reflect the committed changes.
filipf added a comment.May 3 2020, 9:00 AM
In D27688#661903, @ngraham wrote:

Ah, I didn't realize that Kamoso had moved to invent. You need to change the remote to point to the new gitlab URL: git remote set-url origin git@invent.kde.org:kde/kamoso.git

Then arc land should work as normal.

Thanks :)

Revision Contents
Changeset List

PathPackages
Msrc/qml/Main.qml (2 lines)

Diff 81781

View Options

src/qml/Main.qml

Loading...