[plasma-workspace-wallpapers] Improve wallpaper selection
Needs ReviewPublic

Authored by filipf on Mon, Jan 7, 9:59 PM.

Details

Summary

This patch improves the plasma-workspace-wallpapers package by offering cleaner, more modern photographic wallpapers. It also reintroduces the legacy wallpaper Elarun.

Test Plan

Before:

After:

Diff Detail

Repository
R131 Plasma Wallpapers
Branch
new-wallpapers (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6817
Build 6835: arc lint + arc unit
filipf created this revision.Mon, Jan 7, 9:59 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMon, Jan 7, 9:59 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Mon, Jan 7, 9:59 PM
rooty added a subscriber: rooty.Mon, Jan 7, 10:17 PM

Still not sure if we should have also included the grassland

Lovely. Good call including all size and aspect ratio variants for now in case we don't opt to go with D18005: Include only the largest size for each wallpaper.

Dare I ask how big all of this on disk? You can find out with du -ch /usr/share/wallpapers/ | grep total

My only worry is that if the size is too huge, distros won't want to ship it by default and the whole exercise will have been fairly pointless. :(

filipf added a comment.Tue, Jan 8, 1:47 AM

Ah we only ship the biggest size for our additions now. It's the only thing that makes sense for this package IMO, among other things distros will really think twice about shipping it if it's big, like you said.

Heck, if someone asked me if they could put 100-200 MiB of wallpapers on my disk I'd probably make a sour face!

Without D18005 size is at 138 MiB. You remove all the extra sizes for the added Plasma wallpapers and it drops to about 70 MiB.

filipf added a comment.Tue, Jan 8, 2:08 AM

Here's some raw numbers listed:

  • plasma-workspace-wallpapers prior to D17780: about 42 MB
  • plasma-workspace-wallpapers after D17780: about 152 MB
  • plasma-workspace-wallpapers after this diff: about 138 MB
  • plasma-workspace-wallpapers after this diff + D18005: about 70 MB

Main competitors' package sizes:

  • Deepin: 26 MB (main) + 16 MB (community) + 8 MB (private) = 50 MB
  • GNOME: 31 MB
  • Elementary: 35 MB

All three ship only the largest wallpaper size.

mart added a subscriber: mart.Tue, Jan 8, 9:34 AM

+100
(and we should push more on distros to have this installed by default, they often don't to save space on the iso :/

Thanks :)

Trying to have more distros include the package is the plan.

+ I have some good news, by scaling down the really big wallpapers added here to 5K we save 10 MiB. @rooty, that okay?

rooty added a comment.EditedTue, Jan 8, 12:36 PM

wow scrolling down took a while haha
sure fine by me, crop em (except for Lake Bled? might be useful in ultra wide screen instances)

filipf updated this revision to Diff 48962.Tue, Jan 8, 1:35 PM

Scale oversized wallpapers to 5K; crop the NASA wallpaper in order to remove a visual annoyance

filipf added a comment.EditedTue, Jan 8, 1:45 PM

Note: scaling Almond Blossom and Two Labrador Retriever Puppies made no sense, these pics have great compression & turned out bigger when shrunk.

As a further step I suggest to remove the yellow tulips (Blooming Flowers) wallpaper because we have enough flowers. That wallpaper is also somewhat busy in the bottom part.

abetts added a subscriber: abetts.Tue, Jan 8, 3:33 PM

+1

I like the selection so far. Just ping me when you need an official approval.

Thank you for your work!

+100
(and we should push more on distros to have this installed by default

Indeed! Manjaro already does. See also:

In D18078#388874, @mart wrote:

they often don't to save space on the iso :/

I agree, and this is a concern. We're trying to solve that in D18005: Include only the largest size for each wallpaper. Would you mind offering a technical perspective there to make sure we're on the right track?

As a further step I suggest to remove the yellow tulips (Blooming Flowers) wallpaper because we have enough flowers. That wallpaper is also somewhat busy in the bottom part.

Yeah that's a lot of flowers. :) Let's replace it with one of the other contenders.