- User Since
- Jul 26 2019, 6:30 PM (35 w, 21 h)
Wed, Mar 25
Someone mentioned this property here:
But he tried to create new specification. What we need is to update existing one to reflect all the changes...
Tue, Mar 24
Some of the icons are not rendering now, for example:
Discord - iconName: chrome_app_indicator2_83406baa15c6e4f2766a6e3714fbee20
Skype1 - iconName: chrome_app_indicator2_01cdeaaa54803d9c9c158a5cdcb1fbfb
I'm pretty sure I saw a workaround for that somewhere, but I can't recall where...
Found it! You need to handle IconThemePath, which can be difficult... :/
Mon, Mar 23
Sun, Mar 22
Sat, Mar 21
Yes, this code looks smelly, but I don't have better idea now.
I knew there had to be a catch, it would be too easy...
Without this effectiveStatus never changes. Right now it works by happy coincidence - Item is simple destroyed and created in a different, as a side effect new value of effectiveStatus is used.
This change tries to fix my mistake introduced in D26992. I used QML Loader incorrectly... :(
Anyway, I changed it a little bin, please check now.
Bind model as well
In theory QTRY_VERIFY should wait up to 5 seconds until condition is met. qWait(250) shouldn't change much...
Thu, Mar 19
Tue, Mar 17
Yep, icons in SNI are a mess...
Icons are processed in StatusNotifierItemSource, including overlay - that's were this should be fixed. From you comment I see it won't be easy...
This is a workaround, it works, but makes the code even more messy.
Oh you're right. It was not wokring for me on 5.18 so I changed this and it worked. But matter of fact it worked on master all allong :)
5.18 is not using this data model, in 5.18 it is used only in configuration page. In 5.19 this model is everywhere.
The qml checks the value against the enum but updateItemData inserts the string.
Sun, Mar 15
Sat, Mar 14
Tue, Mar 10
Mon, Mar 9
Fix for narrow panel in D27958
I don't like how icon size and item size (container = icon + padding) are calculated and used... Firstly best icons size is calculated, but then padding are added. This combined size is used as item size (container size):
- SNI icons are rounded to nearest icon size (implicitly, because PlasmaCore.IconItem is used)
- Plasmoids are scaled to the size of the container, I don't know exactly how it work, probably because default compact representation is just an icon.
By happy coincident it is (?) working correctly for all sizes.
Sat, Mar 7
Thu, Mar 5
Should System Tray icons be larger then?
Mon, Mar 2
Feb 20 2020
Feb 19 2020
Second (and last) change extracted from this one is in master. Rebased, ready for review.
Feb 16 2020
There is already a margin added around icons, "units.smallSpacing / 2" if I remember correctly.
IMO it is OK without additional spacing (maybe because I'm used to it?). Anyway, VDG should decide what is the best and what is consistent with other elements of Plasma.
Feb 15 2020
Feb 14 2020
Feb 6 2020
Rebase, only D27088 left
Feb 4 2020
Feb 3 2020
Updated the code. This time I was not event able to reproduce race condition. Is something like this OK?
It is hard to reproduce, but with enough tries you should get empty items in "hidden" area of system tray. I used this script:
for i in `seq 1 100`; do echo $i telegram-desktop & sleep 2 killall telegram-desktop done
Feb 1 2020
Extracted from D26992 to make review easier
... and second one: D27088. It contains model refactoring and sorting.
First revision: D27085. In contains some random improvements
Unrelated changes extracted from D26992 to make review easier
Jan 31 2020
I will split it into smaller changes, this one is too big for a review. I'll keep it here as a backup.
Jan 29 2020
This change is very big. I can try to split in into two (maybe more) if that's required. If yes, should I connect revisions somehow? Create task, add parent/child revision?