kmaterka (Konrad Materka)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jul 26 2019, 6:30 PM (7 w, 6 d)
Availability
Available

Recent Activity

Tue, Sep 17

kmaterka added a comment to D11352: Use consistent ordering for System Tray items.

Sorry for interrupting this late in the review. I like the idea of consistent ordering very much, I even planned to implement this myself :) I have few comments:

  • [...] remove the onParentChanged hook (not sure why it was needed in the first place...)

Due to a bug in Repeater it is needed sometimes. Repeater randomly changes the parent item after it was created and re-parented (race condition?). I had big troubles with Repeater, especially combining with Loader, DelegateModel.Package etc. Repeater is very buggy, in other words, it works by happy coincidence. :)

Tue, Sep 17, 2:03 PM · Plasma

Tue, Aug 27

kmaterka added a comment to D22176: Rework system tray settings.

I think QQC1 TableView and the new TableView are quite different things. I had some issues with the QQC1 TableView and my new Model, so I decided to use something else, but I can revisit this

Tue, Aug 27, 8:01 AM · Plasma

Mon, Aug 26

kmaterka added a comment to D22176: Rework system tray settings.

@nicolasfella I updated D23413, now it can be used in configuration entries. Can you check if you can use this?

Mon, Aug 26, 2:59 PM · Plasma
kmaterka updated the diff for D23413: [System Tray] Unified data model for System Tray items.

Now the same model is used for:

  • rendering all items, both Plasmoids and StatusNotifications
  • "Entries" configuration page
Mon, Aug 26, 2:26 PM · Plasma

Sat, Aug 24

kmaterka added a comment to D22176: Rework system tray settings.

@nicolasfella Please correct me if I'm wrong. EntryModel is created on the first use and it is populated in the constructor. If user runs application that uses StatusNotifier (for example Skype, Dropbox, Electron apps, any Windows app via Wine, etc) later, it won't be added to configuration list.

Sat, Aug 24, 11:00 PM · Plasma
kmaterka added a comment to D23413: [System Tray] Unified data model for System Tray items.

I spent some time testing it and I hope it is now bug free. I understand it is a big change that brings little value (now), but I'm working on further improvements and wanted to slip work into smaller patches.

Sat, Aug 24, 10:38 PM · Plasma
kmaterka requested review of D23413: [System Tray] Unified data model for System Tray items.
Sat, Aug 24, 10:32 PM · Plasma

Aug 6 2019

kmaterka set the repository for D22767: Calculate first clickable point, from the top-left to R120 Plasma Workspace.
Aug 6 2019, 8:13 PM · Plasma

Aug 5 2019

kmaterka removed a reviewer for D22767: Calculate first clickable point, from the top-left: Plasma: Workspaces.
Aug 5 2019, 9:45 AM · Plasma

Jul 29 2019

kmaterka updated the diff for D22804: [System Tray] Do not send ContextMenu signal twice.

I simplified the patch. It moves handling of onPressed to PlasmoidItem. This way we can have context menu when mouse is pressed for plasmoids and on click for SNI.

Jul 29 2019, 2:11 PM · Plasma
kmaterka added a comment to D22804: [System Tray] Do not send ContextMenu signal twice.

Yes, probably onPressed should be handled in PasmoidItem, not in the AbstractItem to avoid this kind of problems.

Indeed, that would be the best solution.

Should this be done together with this change? I shouldn't be hard, I can move onPressed to PlasmoidItem, which will simplify the fix also?

Jul 29 2019, 1:46 PM · Plasma
kmaterka added a comment to D22804: [System Tray] Do not send ContextMenu signal twice.

@apol SNI applications (including XembedSniProxy) are using StatusNotifierItem.qml, which already has onClick handled for right button. That why we had ContextMenu event's duplicated.
@broulik Yes, probably onPressed should be handled in PasmoidItem, not in the AbstractItem to avoid this kind of problems. I would personally opt for consistency, though. As far as I know GTK is showing context menu on mouse click, not pressed. The same is for MS Windows (this does not mean we must follow this or reimplement Windows, no). What is your opinion?

Jul 29 2019, 12:23 PM · Plasma
kmaterka added a comment to D22804: [System Tray] Do not send ContextMenu signal twice.

This fixes 27b1030756002e91b60ba51483efe9c2c477d16e, which reverts b9af99140365c8c8cf4e3744af7e13b35c35fa18, but not fully.

Jul 29 2019, 11:41 AM · Plasma
kmaterka requested review of D22804: [System Tray] Do not send ContextMenu signal twice.
Jul 29 2019, 11:39 AM · Plasma
kmaterka updated the diff for D22767: Calculate first clickable point, from the top-left.

Review changes. Call to the calculateClickPoint is local and on only on mouse click, not on every icon update.

Jul 29 2019, 10:38 AM · Plasma
Restricted Application edited projects for D22767: Calculate first clickable point, from the top-left, added: Plasma; removed Plasma: Workspaces.
Jul 29 2019, 9:32 AM · Plasma

Jul 26 2019

kmaterka requested review of D22767: Calculate first clickable point, from the top-left.
Jul 26 2019, 7:19 PM · Plasma