kmaterka (Konrad Materka)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jul 26 2019, 6:30 PM (35 w, 21 h)
Availability
Available

Recent Activity

Wed, Mar 25

kmaterka added a comment to D28208: Move sni icon handling logic from data engine to applet.

Do you know if IconThemePath is specified somewhere?

Initial commit:
https://github.com/KDE/kde-workspace/commit/4c553dbf39f4189290387bba35589200ca051084
Someone mentioned this property here:
https://lists.freedesktop.org/archives/xdg/2015-December/013620.html
https://mail.kde.org/pipermail/plasma-devel/2015-December/047019.html
But he tried to create new specification. What we need is to update existing one to reflect all the changes...

Wed, Mar 25, 6:11 PM · Plasma
kmaterka added a comment to D28208: Move sni icon handling logic from data engine to applet.
Wed, Mar 25, 5:46 PM · Plasma

Tue, Mar 24

kmaterka added a comment to D28208: Move sni icon handling logic from data engine to applet.

Some of the icons are not rendering now, for example:
Discord - iconName: chrome_app_indicator2_83406baa15c6e4f2766a6e3714fbee20
Skype1 - iconName: chrome_app_indicator2_01cdeaaa54803d9c9c158a5cdcb1fbfb
I'm pretty sure I saw a workaround for that somewhere, but I can't recall where...

Found it! You need to handle IconThemePath, which can be difficult... :/

Tue, Mar 24, 9:22 PM · Plasma
kmaterka committed R120:5b99315f75f9: [applets/systemtray] Default value for ItemLoader.source (authored by kmaterka).
[applets/systemtray] Default value for ItemLoader.source
Tue, Mar 24, 9:12 PM
kmaterka closed D28259: [applets/systemtray] Default value for ItemLoader.source.
Tue, Mar 24, 9:12 PM · Plasma
kmaterka added a comment to D28208: Move sni icon handling logic from data engine to applet.

Two problems:

Tue, Mar 24, 9:09 PM · Plasma
kmaterka requested review of D28259: [applets/systemtray] Default value for ItemLoader.source.
Tue, Mar 24, 8:44 PM · Plasma
kmaterka committed R120:a9d941b38e05: [applets/systemtray] Simplify icon size logic (authored by kmaterka).
[applets/systemtray] Simplify icon size logic
Tue, Mar 24, 6:06 PM
kmaterka closed D28109: [applets/systemtray] Simplify icon size logic.
Tue, Mar 24, 6:06 PM · Plasma

Mon, Mar 23

kmaterka added reviewers for D28109: [applets/systemtray] Simplify icon size logic: davidedmundson, apol.
Mon, Mar 23, 8:47 PM · Plasma
kmaterka added inline comments to D28208: Move sni icon handling logic from data engine to applet.
Mon, Mar 23, 8:45 PM · Plasma

Sun, Mar 22

kmaterka added inline comments to D28208: Move sni icon handling logic from data engine to applet.
Sun, Mar 22, 9:49 PM · Plasma
kmaterka accepted D28197: [KSortFilterProxyModel QML] Make invalidateFilter public.
Sun, Mar 22, 10:54 AM · Frameworks

Sat, Mar 21

kmaterka added a comment to D28180: [applets/systemtray] Hide/show expander arrow - regression fix.

This works, but I wonder if there's a conceptually cleaner way to do it. Not that I know of one, so I'll wait for a Plasma person to comment.

Yes, this code looks smelly, but I don't have better idea now.

Sat, Mar 21, 6:38 PM · Plasma
kmaterka accepted D28183: [kioslave/desktop] Attempt at making test more robust.

That won't work as is because I would need to re-run

const KFileItem fileItem = lister->findByUrl(destUrl);

I knew there had to be a catch, it would be too easy...

Sat, Mar 21, 6:37 PM · Plasma
kmaterka updated the diff for D28109: [applets/systemtray] Simplify icon size logic.

Rebase

Sat, Mar 21, 6:16 PM · Plasma
kmaterka updated the diff for D28109: [applets/systemtray] Simplify icon size logic.

Rebase

Sat, Mar 21, 6:14 PM · Plasma
kmaterka committed R120:17153c4ae204: [applet/systemtray] Use model binding instead of copy (authored by kmaterka).
[applet/systemtray] Use model binding instead of copy
Sat, Mar 21, 6:12 PM
kmaterka closed D28185: [applet/systemtray] Use model binding instead of copy.
Sat, Mar 21, 6:12 PM · Plasma
kmaterka added inline comments to D28185: [applet/systemtray] Use model binding instead of copy.
Sat, Mar 21, 5:45 PM · Plasma
kmaterka updated the diff for D28185: [applet/systemtray] Use model binding instead of copy.

Simplify JS

Sat, Mar 21, 5:44 PM · Plasma
kmaterka added a reviewer for D28185: [applet/systemtray] Use model binding instead of copy: apol.
Sat, Mar 21, 4:59 PM · Plasma
kmaterka added a comment to D28185: [applet/systemtray] Use model binding instead of copy.
In D28185#631972, @apol wrote:

I'm not convinced this is all that better.

Without this effectiveStatus never changes. Right now it works by happy coincidence - Item is simple destroyed and created in a different, as a side effect new value of effectiveStatus is used.
This change tries to fix my mistake introduced in D26992. I used QML Loader incorrectly... :(
Anyway, I changed it a little bin, please check now.

Sat, Mar 21, 4:51 PM · Plasma
kmaterka updated the diff for D28185: [applet/systemtray] Use model binding instead of copy.

Bind model as well

Sat, Mar 21, 4:51 PM · Plasma
kmaterka added a comment to D28183: [kioslave/desktop] Attempt at making test more robust.

The failure was always on this line:

QCOMPARE(fileItem.targetUrl(), QUrl::fromLocalFile(destFilePath));
Sat, Mar 21, 4:19 PM · Plasma
kmaterka added a comment to D28183: [kioslave/desktop] Attempt at making test more robust.

In theory QTRY_VERIFY should wait up to 5 seconds until condition is met. qWait(250) shouldn't change much...

Sat, Mar 21, 4:01 PM · Plasma
kmaterka requested review of D28185: [applet/systemtray] Use model binding instead of copy.
Sat, Mar 21, 3:53 PM · Plasma
kmaterka added a comment to D28107: Fix overlayIcon sometimes not visible.

It seems it is possible to do this (removing stuff from the data engine) after all. I will try to work on this in the next time

Sat, Mar 21, 11:52 AM · Plasma
kmaterka added inline comments to D28180: [applets/systemtray] Hide/show expander arrow - regression fix.
Sat, Mar 21, 11:02 AM · Plasma
kmaterka requested review of D28180: [applets/systemtray] Hide/show expander arrow - regression fix.
Sat, Mar 21, 11:01 AM · Plasma

Thu, Mar 19

kmaterka added a comment to D28109: [applets/systemtray] Simplify icon size logic.

This looks like a sensible refactor to me, and it solves the issue that I was having with icon size changing based on the expanded popup visibility. I can't detect any regressions in sizing with horizontal or vertical panels of various sizes. However please wait to land this until somebody else possessing greater familiarity with this codebase such as @broulik, @mart, or @davidedmundson reviews it too.

Thu, Mar 19, 5:00 PM · Plasma

Tue, Mar 17

kmaterka requested changes to D28107: Fix overlayIcon sometimes not visible.

Yep, icons in SNI are a mess...
Icons are processed in StatusNotifierItemSource, including overlay - that's were this should be fixed. From you comment I see it won't be easy...
This is a workaround, it works, but makes the code even more messy.

Tue, Mar 17, 10:14 PM · Plasma
kmaterka added a comment to D28096: Don't overwrite status.

Oh you're right. It was not wokring for me on 5.18 so I changed this and it worked. But matter of fact it worked on master all allong :)

5.18 is not using this data model, in 5.18 it is used only in configuration page. In 5.19 this model is everywhere.

Tue, Mar 17, 10:12 PM · Plasma
kmaterka requested changes to D28096: Don't overwrite status.

The qml checks the value against the enum but updateItemData inserts the string.

Tue, Mar 17, 9:54 PM · Plasma
kmaterka added inline comments to D28109: [applets/systemtray] Simplify icon size logic.
Tue, Mar 17, 9:43 PM · Plasma
kmaterka requested review of D28109: [applets/systemtray] Simplify icon size logic.
Tue, Mar 17, 9:37 PM · Plasma

Sun, Mar 15

kmaterka added inline comments to D27160: [applets/mediacontroller] Visually refresh media controller plasmoid.
Sun, Mar 15, 9:49 PM · Plasma
kmaterka added a comment to D27958: [SystemTray] Fix item size for very narrow panel.

After a few days of living with it, I've found that this patch causes the following issue with semi-random tray items getting smaller when a pop-up is opened:

Could you investigate?

Sun, Mar 15, 9:42 PM · Plasma

Sat, Mar 14

kmaterka added inline comments to D27160: [applets/mediacontroller] Visually refresh media controller plasmoid.
Sat, Mar 14, 9:04 PM · Plasma
kmaterka added inline comments to D27160: [applets/mediacontroller] Visually refresh media controller plasmoid.
Sat, Mar 14, 8:52 PM · Plasma
kmaterka added inline comments to D27160: [applets/mediacontroller] Visually refresh media controller plasmoid.
Sat, Mar 14, 8:48 PM · Plasma

Tue, Mar 10

kmaterka committed R120:85f646eb5649: [SystemTray] Fix item size for very narrow panel (authored by kmaterka).
[SystemTray] Fix item size for very narrow panel
Tue, Mar 10, 6:19 PM
kmaterka closed D27958: [SystemTray] Fix item size for very narrow panel.
Tue, Mar 10, 6:19 PM · Plasma
kmaterka added a comment to D27958: [SystemTray] Fix item size for very narrow panel.

Not sure if it is just me but the vertical alignment looks slightly off


Or maybe that's the random different sizes

Tue, Mar 10, 6:16 PM · Plasma

Mon, Mar 9

kmaterka added a comment to D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid.

Fix for narrow panel in D27958

Mon, Mar 9, 9:47 PM · Plasma
kmaterka added a comment to D27958: [SystemTray] Fix item size for very narrow panel.

I don't like how icon size and item size (container = icon + padding) are calculated and used... Firstly best icons size is calculated, but then padding are added. This combined size is used as item size (container size):

  • SNI icons are rounded to nearest icon size (implicitly, because PlasmaCore.IconItem is used)
  • Plasmoids are scaled to the size of the container, I don't know exactly how it work, probably because default compact representation is just an icon.

By happy coincident it is (?) working correctly for all sizes.

Mon, Mar 9, 9:44 PM · Plasma
kmaterka updated the summary of D27958: [SystemTray] Fix item size for very narrow panel.
Mon, Mar 9, 9:21 PM · Plasma
kmaterka requested review of D27958: [SystemTray] Fix item size for very narrow panel.
Mon, Mar 9, 9:17 PM · Plasma
kmaterka added a comment to D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid.

I believe that D26992, moves the icons down.

It looks like with that patch the icon sizes differ between plasmoids and SNIs

Mon, Mar 9, 12:43 PM · Plasma
kmaterka added a comment to D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid.

This causes layouting issues in narrow panels:


The icons are also too far apart

Mon, Mar 9, 10:17 AM · Plasma

Sat, Mar 7

kmaterka committed R120:39975673cb6a: [SystemTray] Use unified data model everywhere (authored by kmaterka).
[SystemTray] Use unified data model everywhere
Sat, Mar 7, 10:20 AM
kmaterka closed D26992: [SystemTray] Use unified data model everywhere.
Sat, Mar 7, 10:20 AM · Plasma
kmaterka added inline comments to D26992: [SystemTray] Use unified data model everywhere.
Sat, Mar 7, 10:19 AM · Plasma

Thu, Mar 5

kmaterka added a comment to D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it.

Should System Tray icons be larger then?

Thu, Mar 5, 5:35 PM · Plasma

Mon, Mar 2

kmaterka added a comment to D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid.

IMO this is the wrong way to do these changes.

  1. I don't see "itemSize" to be used anywhere else(didn't check) than "tasksRow" where we already add a smallSpacing. It would be best to increase the size in one place.
  2. For tablets already allow to use bigger size icons. There is no need to artificially increase the size this way, if they need bigger size can increase the panel height.
  3. Can expose plasmoid.configuration.iconSize to the user. Otherwise can be removed.
Mon, Mar 2, 8:49 AM · Plasma

Feb 20 2020

kmaterka added a comment to D26992: [SystemTray] Use unified data model everywhere.

UI looks good except for one thing: the changes to show a highlight effect on hover in the popup are unrelated and should be done in a separate patch (preferably in coordination with VDG folks since we're moving towards the idea of using this in other places too).

Feb 20 2020, 3:00 PM · Plasma

Feb 19 2020

kmaterka updated the diff for D26992: [SystemTray] Use unified data model everywhere.

Second (and last) change extracted from this one is in master. Rebased, ready for review.

Feb 19 2020, 9:36 PM · Plasma
kmaterka committed R120:6d86c690d133: [applets/SystemTray] Implement sorting in the model (authored by kmaterka).
[applets/SystemTray] Implement sorting in the model
Feb 19 2020, 9:09 PM
kmaterka closed D27088: [applets/SystemTray] Implement sorting in the model.
Feb 19 2020, 9:09 PM · Plasma
kmaterka updated the diff for D27088: [applets/SystemTray] Implement sorting in the model.

Review fixes

Feb 19 2020, 9:04 PM · Plasma
kmaterka added inline comments to D27088: [applets/SystemTray] Implement sorting in the model.
Feb 19 2020, 5:34 PM · Plasma

Feb 16 2020

kmaterka added a comment to D27438: Increase System Tray Plasmoid spacing value slightly.

There is already a margin added around icons, "units.smallSpacing / 2" if I remember correctly.
IMO it is OK without additional spacing (maybe because I'm used to it?). Anyway, VDG should decide what is the best and what is consistent with other elements of Plasma.

Feb 16 2020, 10:52 PM · Plasma

Feb 15 2020

kmaterka added a comment to D27088: [applets/SystemTray] Implement sorting in the model.

OK, I will wait for second review from @davidedmundson, @broulik or @mart.

Feb 15 2020, 2:29 PM · Plasma

Feb 14 2020

kmaterka retitled D27088: [applets/SystemTray] Implement sorting in the model from [SystemTray] Implement sorting in the model to [applets/SystemTray] Implement sorting in the model.
Feb 14 2020, 7:05 PM · Plasma
kmaterka committed R120:ccd4536a6ce8: [applets/SystemTray] Fix crash on shutdown (authored by kmaterka).
[applets/SystemTray] Fix crash on shutdown
Feb 14 2020, 6:25 PM
kmaterka closed D27401: [applets/SystemTray] Fix crash on shutdown.
Feb 14 2020, 6:25 PM · Plasma
kmaterka updated the summary of D27401: [applets/SystemTray] Fix crash on shutdown.
Feb 14 2020, 1:18 PM · Plasma
kmaterka requested review of D27401: [applets/SystemTray] Fix crash on shutdown.
Feb 14 2020, 1:17 PM · Plasma

Feb 6 2020

kmaterka updated the diff for D26992: [SystemTray] Use unified data model everywhere.

Rebase, only D27088 left

Feb 6 2020, 7:44 PM · Plasma
kmaterka updated the diff for D27088: [applets/SystemTray] Implement sorting in the model.

Rebase

Feb 6 2020, 4:49 PM · Plasma
kmaterka committed R120:a79f80ed79ae: [SystemTray] Bunch of fixes and improvements in QML (authored by kmaterka).
[SystemTray] Bunch of fixes and improvements in QML
Feb 6 2020, 4:49 PM
kmaterka closed D27085: [SystemTray] Bunch of fixes and improvements in QML.
Feb 6 2020, 4:49 PM · Plasma

Feb 4 2020

kmaterka added reviewers for D27085: [SystemTray] Bunch of fixes and improvements in QML: davidedmundson, ngraham, broulik.
Feb 4 2020, 8:05 PM · Plasma
kmaterka added reviewers for D27088: [applets/SystemTray] Implement sorting in the model: davidedmundson, ngraham, broulik.
Feb 4 2020, 8:04 PM · Plasma

Feb 3 2020

kmaterka committed R120:7a0114695d76: Merge branch 'Plasma/5.18' (authored by kmaterka).
Merge branch 'Plasma/5.18'
Feb 3 2020, 3:58 PM
kmaterka committed R120:31303ad3542b: [SNI] Fix race condition in item registration (authored by kmaterka).
[SNI] Fix race condition in item registration
Feb 3 2020, 3:58 PM
kmaterka closed D27126: [SNI] Fix race condition in item registration.
Feb 3 2020, 3:58 PM · Plasma
kmaterka added inline comments to D27126: [SNI] Fix race condition in item registration.
Feb 3 2020, 3:49 PM · Plasma
kmaterka updated the diff for D27126: [SNI] Fix race condition in item registration.

Updated the code. This time I was not event able to reproduce race condition. Is something like this OK?

Feb 3 2020, 3:48 PM · Plasma
kmaterka added a comment to D27126: [SNI] Fix race condition in item registration.

It is hard to reproduce, but with enough tries you should get empty items in "hidden" area of system tray. I used this script:

for i in `seq 1 100`; do
        echo $i
        telegram-desktop &
        sleep 2
        killall telegram-desktop
done
Feb 3 2020, 1:12 PM · Plasma
kmaterka requested review of D27126: [SNI] Fix race condition in item registration.
Feb 3 2020, 1:09 PM · Plasma

Feb 1 2020

kmaterka added a comment to D27088: [applets/SystemTray] Implement sorting in the model.

Extracted from D26992 to make review easier

Feb 1 2020, 4:09 PM · Plasma
kmaterka added a comment to D26992: [SystemTray] Use unified data model everywhere.

... and second one: D27088. It contains model refactoring and sorting.

Feb 1 2020, 4:08 PM · Plasma
kmaterka added a dependency for D27088: [applets/SystemTray] Implement sorting in the model: D26992: [SystemTray] Use unified data model everywhere.
Feb 1 2020, 4:06 PM · Plasma
kmaterka added a dependent revision for D26992: [SystemTray] Use unified data model everywhere: D27088: [applets/SystemTray] Implement sorting in the model.
Feb 1 2020, 4:06 PM · Plasma
kmaterka requested review of D27088: [applets/SystemTray] Implement sorting in the model.
Feb 1 2020, 4:04 PM · Plasma
kmaterka added a comment to D26992: [SystemTray] Use unified data model everywhere.

First revision: D27085. In contains some random improvements

Feb 1 2020, 2:52 PM · Plasma
kmaterka added a comment to D27085: [SystemTray] Bunch of fixes and improvements in QML.

Unrelated changes extracted from D26992 to make review easier

Feb 1 2020, 2:50 PM · Plasma
kmaterka added a dependency for D27085: [SystemTray] Bunch of fixes and improvements in QML: D26992: [SystemTray] Use unified data model everywhere.
Feb 1 2020, 2:48 PM · Plasma
kmaterka added a dependent revision for D26992: [SystemTray] Use unified data model everywhere: D27085: [SystemTray] Bunch of fixes and improvements in QML.
Feb 1 2020, 2:48 PM · Plasma
kmaterka requested review of D27085: [SystemTray] Bunch of fixes and improvements in QML.
Feb 1 2020, 2:48 PM · Plasma

Jan 31 2020

kmaterka updated the diff for D26992: [SystemTray] Use unified data model everywhere.

I will split it into smaller changes, this one is too big for a review. I'll keep it here as a backup.

Jan 31 2020, 3:39 PM · Plasma
kmaterka updated the diff for D26992: [SystemTray] Use unified data model everywhere.

Rebase2

Jan 31 2020, 3:24 PM · Plasma
kmaterka updated the diff for D26992: [SystemTray] Use unified data model everywhere.

Rebase

Jan 31 2020, 3:18 PM · Plasma
kmaterka accepted D27068: [System Tray] Initially set correct category for plasmoids.

I definitely need to split D26992 into smaller chunks :) I had it fixed, but obviously D26992 can't be merged for 5.18.

Jan 31 2020, 3:06 PM · Plasma

Jan 29 2020

kmaterka added a comment to D26992: [SystemTray] Use unified data model everywhere.

This change is very big. I can try to split in into two (maybe more) if that's required. If yes, should I connect revisions somehow? Create task, add parent/child revision?

Jan 29 2020, 3:36 PM · Plasma
kmaterka requested review of D26992: [SystemTray] Use unified data model everywhere.
Jan 29 2020, 3:33 PM · Plasma
kmaterka added inline comments to D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin.
Jan 29 2020, 1:19 PM · Frameworks

Jan 26 2020

kmaterka committed R120:af97cded4f4b: Merge branch 'Plasma/5.18' (authored by kmaterka).
Merge branch 'Plasma/5.18'
Jan 26 2020, 10:19 PM
kmaterka closed D26850: [SystemTray] Fix model update in settings (missing icon).
Jan 26 2020, 10:18 PM · Plasma