Add a blurless SDDM theme
AbandonedPublic

Authored by filipf on Thu, May 14, 10:09 PM.

Details

Reviewers
None
Group Reviewers
VDG
Plasma
Summary

This patch adds a blurless SDDM Breeze theme.

The non-default theme is added in order to accommodate users who wish to have their wallpaper not obfuscated.

Most of the default theme is just symlinked, while the changes include everything necessary to ensure legibility.

As a another feat, dropping blur also enables this theme to drop using complementary color schemes, which means it can be fully light or dark as opposed to mixing light and dark elements.

Test Plan

Diff Detail

Repository
R120 Plasma Workspace
Branch
add-blurless-sddm-theme (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26924
Build 26942: arc lint + arc unit
filipf created this revision.Thu, May 14, 10:09 PM
Restricted Application added a project: Plasma. · View Herald TranscriptThu, May 14, 10:09 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Thu, May 14, 10:09 PM
filipf edited the summary of this revision. (Show Details)Thu, May 14, 10:11 PM
filipf edited the test plan for this revision. (Show Details)
filipf added reviewers: VDG, Plasma.

Can we perhaps add infrastructure so that a theme can provide options?
For instance, the look and feel package can add options to the lock screen KCM which we use for e.g. "always show clock" and "show media controls".
I'm not keen on duplicating the entire theme for a single option.

Can we perhaps add infrastructure so that a theme can provide options?
For instance, the look and feel package can add options to the lock screen KCM which we use for e.g. "always show clock" and "show media controls".
I'm not keen on duplicating the entire theme for a single option.

I would also prefer to just have it as an option, but turning off blur requires several workarounds to ensure legibility. That means there would be a bunch of conditionals in the theme. It's unfortunate there's no context here comparing the changes, but there's too many of them IMO. I'll add comments instead.

sddm-theme-blurless/Main.qml
39

Changed from Complementary because with complementary you get a white password box and dark action button and footer backgrounds.

114

Disabled now, visually.

120

Dont mess with the clock do mess with the new footer bg.

456

New stuff

sddm-theme-blurless/components/ActionButton.qml
45

Changed to ensure legibility.

60

Changef to ensure legibility.

98

Added.

118

Cant use black shadows with dark text

sddm-theme-blurless/components/Clock.qml
30

We cannot use black shadows with dark text.

sddm-theme-blurless/components/UserDelegate.qml
47

Increased to ensure legibility

63

Increased to ensure legibilty.

120

Changed from textColor to better fit in.

163

Didn't exist before.

184

We cannot use black shadows with dark text.

sddm-theme-blurless/components/WallpaperFader.qml
35

WallpaperFader no longer deals with the clock since it always needs a shadow. It does now have to deal with footer bg.

mart added a subscriber: mart.Fri, May 15, 12:08 PM

I'm not keen on duplicating the entire theme for a single option.

I would also prefer to just have it as an option, but turning off blur requires several workarounds to ensure legibility.

perhaps one thing that can be given a shot is that since i just merged into kirigami a component to analyze image colors and extract palettes, the text color when not blurred could be based on the wallpaper colors (probably colors of a shader item that takes a copy of the wallpaper in just the area behind the text to be accurate) so that the text could try to always have a decent level of contrast even on really noisy wallpapers

I agree, I think we need to come up with some infrastructure to allow SDDM themes to display user-visible settings. Even though this new theme is mostly symlinks, duplicating main.qml is uglier and less nice maintenance-wise then putting conditions in it. Also shipping two themes seems less elegant than just making this an option in the default theme, which is what users have been requesting.

+1 on the appearance though. It looks lovely!

filipf abandoned this revision.Fri, May 15, 6:27 PM

Yeah on second thought this is ugly from a maintenance POV. We'd need a GUI sheet that exposes theme.conf and then blur would be one option.