Differential D29352

[Plasmoid Heading] Draw the heading only when there is an SVG in the theme
ClosedPublic
Actions

Authored by filipf on May 1 2020, 9:49 PM.

Details

Reviewers
niccolove
ngraham
Group Reviewers
VDG
Plasma
Commits
R242:29404ef10bd0: [Plasmoid Heading] Draw the heading only when there is an SVG in the theme
R242:1b1018e68703: [Plasmoid Heading] Draw the heading only when there is an SVG in the theme
Summary

We're the only theme with the appropriate heading svgs that make the headers and footers look as they should.

All the other themes fall back to Breeze, which is not a good look for some of them:

  • the heading is too jarring compared to applet background
  • the heading does not extend all the way vertically and horizontally

To solve this, to avoid degrading unmaintained themes and to give themes a chance to adjust on their own terms, this patch makes the heading visible only when the needed SVG exists in the theme.

Test Plan

Avoids this:

Breeze still works as it should.

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
filipf created this revision.May 1 2020, 9:49 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 1 2020, 9:49 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
filipf requested review of this revision.May 1 2020, 9:49 PM
filipf edited the test plan for this revision. (Show Details)May 1 2020, 9:50 PM
filipf added reviewers: VDG, Plasma.
niccolove accepted this revision as: niccolove.May 2 2020, 9:48 AM
niccolove added a subscriber: niccolove.

LGTM

This revision is now accepted and ready to land.May 2 2020, 9:48 AM
ngraham accepted this revision.May 3 2020, 4:11 PM
ngraham added a subscriber: ngraham.

If this doesn't land in Frameworks 5.70, Plasma 5.19 users run the risk of being hit by it, as 5.70 is the frameworks dependency for that Plasma release.

Frameworks 5.70 just got tagged, so once this lands, it will need to be manually added to the tag to ensure it's released with 5.70. Can you email the frameworks mailing list and dfaure about it?

Closed by commit R242:1b1018e68703: [Plasmoid Heading] Draw the heading only when there is an SVG in the theme (authored by filipf). · Explain WhyMay 3 2020, 4:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 81808

View Options

src/declarativeimports/plasmaextracomponents/qml/PlasmoidHeading.qml

Loading...