In D13444#281056, @sagnikchaudhuri wrote:

Can I get an instance when chopping off the last 3 letters won't work? Like, shouldn't the last 3 letters always be ": "
Or will it change if the name of the session's too big or something?

Can I get an instance when chopping off the last 3 letters won't work? Like, shouldn't the last 3 letters always be ": "
Or will it change if the name of the session's too big or something?

The article for the dot has been ready for some days now. When do you want to publish this?

Good catch! Looks good to me. Could you commit?

In T9042#148230, @abetts wrote:

In T9042#148228, @rooty wrote:

Regarding the recents section being in open view like this, I don't think this is a very good idea. Because not only would I, the user, be presented with most of the files I just used and don't need to use again (very few of them do I need access to again, and a "favorites" (as opposed to recent) files section would serve this function much better), I would also be presented with lots of them (this section takes up most of the space in the menu), and not only would I be exposed to these files, so would anyone looking over my shoulder while using the computer (my friends, my mom etc.) letting them see the tawdriest contents of my hard drive in their full glory, if you know what I mean.

That is an interesting point you raise. What would be the difference between that and the current state where the History tab is present? Isn't this "risk" the same? I mean, if you think about it, anything that you do on the computer is subject to having someone looking over you shoulder. Once you open the computer, it is open for others to see. It is the same with any other devices really. So I wonder. Is this point or high relevancy?

KDE only uses github as a read-only mirror. You will get a notification when it is submitted.

Wow! That's some difference!

Otherwise looks good, I can submit this later.

I would have clang-tidy & Co handy to do some simple common modernization, if you like (done already a few time elsewhere this year). Just tell me "Go" and I would run nullptr & override at least and commit to master (after manual check) :)

Implementation BenchMark results

thanks a lot for your contribution!
From my point of view, this is all ok now.

Done

In T9042#148228, @rooty wrote:

Regarding the recents section being in open view like this, I don't think this is a very good idea. Because not only would I, the user, be presented with most of the files I just used and don't need to use again (very few of them do I need access to again, and a "favorites" (as opposed to recent) files section would serve this function much better), I would also be presented with lots of them (this section takes up most of the space in the menu), and not only would I be exposed to these files, so would anyone looking over my shoulder while using the computer (my friends, my mom etc.) letting them see the tawdriest contents of my hard drive in their full glory, if you know what I mean.

• rebase

Const ref layout

Fixes made into:
https://phabricator.kde.org/D13644

• Rebase

• rebase

Looks much better now.