Differential D13645

Make icons larger for log widget
ClosedPublic
Actions

Authored by rizzitello on Jun 21 2018, 4:00 AM.

Details

Reviewers
tcanabrava
Group Reviewers
Atelier: AtCore
Commits
R232:d5fc42fef008: Make icons larger for log widget
R232:9213950bb70c: Make icons larger , use a toolbox for info button
Summary

Up icon size
use a tool button for the info button
Before

Lo Dpi, After


Hi Dpi After.

Diff Detail

Repository
R232 AtCore
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rizzitello requested review of this revision.Jun 21 2018, 4:00 AM
rizzitello created this revision.
rizzitello edited the summary of this revision. (Show Details)Jun 21 2018, 4:03 AM
rizzitello added a reviewer: Atelier: AtCore.
rizzitello added a project: Atelier: AtCore.
rizzitello added a subscriber: Atelier: AtCore.
rizzitello edited the summary of this revision. (Show Details)Jun 21 2018, 10:31 AM
tcanabrava added a subscriber: tcanabrava.Jun 21 2018, 11:17 AM
tcanabrava added inline comments.
src/widgets/logwidget.cpp
32

I don't think that using fontMetrics will give us a good icon size.
Icon sizes are usually 22x22, 32x32, 48x48, 64x64 and such, the fontMetrics can use a wrong size.

tcanabrava accepted this revision.Jun 21 2018, 11:18 AM

But it appears to work, well.

This revision is now accepted and ready to land.Jun 21 2018, 11:18 AM
Closed by commit R232:9213950bb70c: Make icons larger , use a toolbox for info button (authored by rizzitello). · Explain WhyJun 21 2018, 1:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/widgets/logwidget.cpp (10 lines)

Diff 36453

View Options

src/widgets/logwidget.cpp

Loading...