Scale icons in laterial area based on dpi
ClosedPublic

Authored by rizzitello on Jun 15 2018, 12:55 PM.

Details

Summary

Before all icons in this area were set to 48px. This looked really good on Hidpi displays but on low dpi displays the icons were to large. We now check dpi so they are correctly sized.

iconSize = 16 + (scale *16);

this would give us a minimum size of 16 (if scale is 0) then
32,48,64,80,96...

HiDpi: 48px

LoDpi: 32px

Diff Detail

Branch
scaleLaterialIcons
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 175
Build 175: arc lint + arc unit
rizzitello requested review of this revision.Jun 15 2018, 12:55 PM
rizzitello created this revision.
rizzitello updated this revision to Diff 36204.Jun 15 2018, 1:12 PM
  • remove debug call
rizzitello edited the summary of this revision. (Show Details)Jun 15 2018, 1:13 PM
rizzitello edited the test plan for this revision. (Show Details)Jun 15 2018, 1:18 PM
rizzitello updated this revision to Diff 36205.Jun 15 2018, 1:26 PM
  • Update formula to work with anyscale
rizzitello edited the summary of this revision. (Show Details)Jun 15 2018, 1:26 PM
rizzitello edited the test plan for this revision. (Show Details)
  • Fix button size to icon size (as before just scaled)
patrickelectric added inline comments.
src/mainwindow.cpp
191

can you explain the magic numbers in the comment ?

rizzitello updated this revision to Diff 36263.Jun 18 2018, 3:00 AM
  • Comment on magic numbers
rizzitello marked an inline comment as done.Jun 18 2018, 3:00 AM
laysrodrigues accepted this revision.Jun 21 2018, 3:20 AM
This revision is now accepted and ready to land.Jun 21 2018, 3:20 AM
rizzitello closed this revision.Jun 21 2018, 4:05 AM