fix for BUG 395424
Needs RevisionPublic

Authored by anmolgautam on Jun 21 2018, 7:43 AM.

Details

Reviewers
drosca

Diff Detail

Repository
R875 Falkon
Branch
BUG395424
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 181
Build 181: arc lint + arc unit
anmolgautam created this revision.Jun 21 2018, 7:43 AM
Restricted Application added a project: Falkon. · View Herald TranscriptJun 21 2018, 7:43 AM
Restricted Application added a subscriber: falkon. · View Herald Transcript
anmolgautam requested review of this revision.Jun 21 2018, 7:43 AM

There was a reason it was like that, because QtWebEngine did in some version set QWebEngineDownloadItem::path() as percent encoded string. I'm not sure in which version it was fixed (if it was?), but in any case this patch seems wrong. If the path() is no longer percent encoded, QUrl::fromPercentEncoded can be just removed, instead of percent encoding the string and then decoding it again.

drosca requested changes to this revision.Jun 21 2018, 10:28 AM
This revision now requires changes to proceed.Jun 21 2018, 10:28 AM