Remove empty lines

Rebase

• Remove a fixme.

• Re-write the the file index scheduler.
• Update the balooctl tool with the changed suspend/resume behaviour.

Consolidate file indexer close changes into a single review.

Run a full check for unindexed files when the watches are installed.

But test_problems test doesn't use this analyzing the code. Maybe the code for the test itself should be changed?

Regarding the recents section being in open view like this, I don't think this is a very good idea. Because not only would I, the user, be presented with most of the files I just used and don't need to use again (very few of them do I need access to again, and a "favorites" (as opposed to recent) files section would serve this function much better), I would also be presented with lots of them (this section takes up most of the space in the menu), and not only would I be exposed to these files, so would anyone looking over my shoulder while using the computer (my friends, my mom etc.) letting them see the tawdriest contents of my hard drive in their full glory, if you know what I mean.

+1 I've been using borderless windows all the time since I came back to KDE Plasma and haven't had any workflow issues.

A couple more things:

• I think a bit of marginBottom in the title row would be good too, to separate the artist name from the first song name
• The track being played gets a bold font, but only for the title. I think it'd be more consistent to have bold text in the whole row
• Looks like the "-1" for songs without a track number came back
• RTL has some issues (though it's probably not done yet)

In D13450#280849, @rkflx wrote:

Could someone look at other screenshot apps with the keyboard feature and report on the movement speed?

I might be biased but I absolutely love this :D

In D12975#276525, @astippich wrote:

Unfortunately still a while. KFileMetaData has currently not the ability to write these tags, and Elisa itself also has no infrastructure yet to actually edit the metadata

Thanks for investigating!

Probably makes sense, but currently your arguments are a bit one-sided. I'd like to think that Spectacle's users will appreciate if the consequences of changes for existing workflows were also considered. Quoting from the manual:

In D13450#280408, @ngraham wrote:

Unmodified arrow keys: move/resize by single pixel

To clarify for anyone coming here via git blame:

• e9218fddfabd only provided MessageDuration::Persistent on an infrastructure level
• 4e9720789e0f was the actual change for shared image URLs
• The change in this patch will affect every message (and most importantly those with MessageDuration::Persistent), not only shared image URLs

Perhaps I can go into the UserManager KCM, let it change the avatar like always, then run a brief timer (250ms?), and then ‘touch’ the face file so the KDirWatch runs a second time.

In D13481#280767, @romangg wrote:

What I thought of as a solution back when it happened was to check if it's a single click on the dead zone without mouse movement, then activate the window below. Since if you want to use the virtual border, you would move the mouse after press to drag. Not sure if it's worth it since as said, never disturbed my work flow afterwards again.

Discard unrelated change

An enormous improvement!!!

• remove useless i18nc calls

It is heavily inspired by https://diegogangl.github.io/

Don't feel bad. I'm not even sure what this patch will do. I guess KRename has some renaming rules where you can use extracted information.

Works fine thanks.
Sorry for the delay due to me being sick

It is still not resizable even if kwin adds a resize handle.
There is also problems with the close button being partially covered and the track path being partially hidden.

Tell me if you think this should have more test vectors.

You can run touch $HOME/.face.icon to make the system believe the file changed, then it goes through KDirWatch etc.

@hein : Thanks for the time spent investigating. The User Manager KCM appears to write out proper (non-corrupt) files, at least in my testing. I know there's a KDirWatch in one of the included Frameworks (KCoreAddons, I think), but that seems to work properly. It does indeed copy the file to the other places where it belongs. I'm still at a loss as to why it goes blank, but works when plasmashell is restarted. So Kickoff is picking up on the fact that there's been a change, but the operation doesn't complete.

I had a look at this today, and I wasn't able to reproduce the problem so far.

sorry for the caused inconvenience

Apart from that I do not see any bugs, just differences in taste which I commented on and you can take as you see fit.

I added a comment that was apparently lost in my first review.

Please anybody push this patchs D13636 & D13637 ... i'm lost SSH-key :(

Fix crash on Qt <5.11

Thanks for sorting that out.

Ok!