rahn (Torsten Rahn)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Sep 8 2015, 2:26 PM (210 w, 5 d)
Availability
Available

Recent Activity

Thu, Sep 12

rahn committed R34:77e47155f186: - Consider MARBLE_DATA_PATH and MARBLE_PLUGIN_PATH on Windows as well. (authored by rahn).
- Consider MARBLE_DATA_PATH and MARBLE_PLUGIN_PATH on Windows as well.
Thu, Sep 12, 11:26 AM
rahn committed R34:d76373dfdd5f: Remove superfluous extra lineWidth Q_PROPERTY. (authored by rahn).
Remove superfluous extra lineWidth Q_PROPERTY.
Thu, Sep 12, 9:05 AM

Tue, Sep 3

rahn committed R34:5f64e5edc225: - Exporting the MarbleDeclarativePlugin. - Adding QML GeoItem and QML… (authored by rahn).
- Exporting the MarbleDeclarativePlugin. - Adding QML GeoItem and QML…
Tue, Sep 3, 4:49 PM
rahn closed D23673: Allow for using Marble with QML Items in external QML files .
Tue, Sep 3, 4:49 PM · KDE Edu, Marble

Mon, Sep 2

rahn closed D23531: Add a test for the GeoJSON file parser.
Mon, Sep 2, 2:17 PM · KDE Edu, Marble
rahn accepted D23531: Add a test for the GeoJSON file parser.
Mon, Sep 2, 2:17 PM · KDE Edu, Marble
rahn added a comment to D23531: Add a test for the GeoJSON file parser.

Submitted with 6b8cc37af9a567c1f8c87a2e0f00fc17981b3f2c. Thanks a lot!

Mon, Sep 2, 2:17 PM · KDE Edu, Marble
rahn committed R34:1eae0a397a3c: Initialise default styles just once; display an icon for points. Previously… (authored by zaitseff).
Initialise default styles just once; display an icon for points. Previously…
Mon, Sep 2, 2:14 PM
rahn closed D23533: Initialise default styles just once; display an icon for points.
Mon, Sep 2, 2:14 PM · KDE Edu, Marble
rahn committed R34:efe8875e111a: Add the svgs/solid/dot-circle.svg icon from FontAwesome (authored by zaitseff).
Add the svgs/solid/dot-circle.svg icon from FontAwesome
Mon, Sep 2, 2:09 PM
rahn closed D23532: Add the svgs/solid/dot-circle.svg icon from FontAwesome.
Mon, Sep 2, 2:09 PM · KDE Edu, Marble
rahn committed R34:6b8cc37af9a5: Add a test for the GeoJSON file parser. (authored by zaitseff).
Add a test for the GeoJSON file parser.
Mon, Sep 2, 2:06 PM
rahn committed R34:49e35634cee0: Minor code cleanup of GeoJSON plugin, adding the new author and date (authored by zaitseff).
Minor code cleanup of GeoJSON plugin, adding the new author and date
Mon, Sep 2, 2:05 PM
rahn closed D23530: Minor code cleanup of GeoJSON plugin, adding the new author and date.
Mon, Sep 2, 2:05 PM · KDE Edu, Marble
rahn committed R34:058ea2c44452: Update the MIME type for GeoJSON files to be RFC7946-compliant. (authored by zaitseff).
Update the MIME type for GeoJSON files to be RFC7946-compliant.
Mon, Sep 2, 2:03 PM
rahn closed D23529: Update the MIME type for GeoJSON files to be RFC7946-compliant.
Mon, Sep 2, 2:03 PM · KDE Edu, Marble
rahn committed R34:5cb91148bce7: Implement most of the GeoJSON Simplestyle specification. (authored by zaitseff).
Implement most of the GeoJSON Simplestyle specification.
Mon, Sep 2, 2:00 PM
rahn closed D23528: Implement most of the GeoJSON Simplestyle specification.
Mon, Sep 2, 2:00 PM · KDE Edu, Marble
rahn added a comment to D23528: Implement most of the GeoJSON Simplestyle specification.

Neato. :-) There is by the way "mDebug". But I'm not sure whether we use it consistently.

Mon, Sep 2, 1:57 PM · KDE Edu, Marble
rahn committed R34:d08729a77e55: Completely rewrite the GeoJSON runner plugin for RFC7946 compliance. (authored by zaitseff).
Completely rewrite the GeoJSON runner plugin for RFC7946 compliance.
Mon, Sep 2, 1:53 PM
rahn closed D23527: Completely rewrite the GeoJSON runner plugin for RFC7946 compliance.
Mon, Sep 2, 1:53 PM · KDE Edu, Marble
rahn committed R34:f4c223bc682a: - Adding GeoJSON Marble writing example - Add valid GeoJSON examples from… (authored by rahn).
- Adding GeoJSON Marble writing example - Add valid GeoJSON examples from…
Mon, Sep 2, 1:42 PM
rahn closed D23524: Add the Marble writing example in GeoJSON format.
Mon, Sep 2, 1:42 PM · KDE Edu, Marble
rahn accepted D23525: Add valid GeoJSON examples from RFC7946.

Looks good.

Mon, Sep 2, 1:38 PM · KDE Edu, Marble
rahn accepted D23524: Add the Marble writing example in GeoJSON format.

Looks good

Mon, Sep 2, 1:36 PM · KDE Edu, Marble
rahn committed R943:53ef35cd13cb: basysKom Logo update. (authored by rahn).
basysKom Logo update.
Mon, Sep 2, 12:54 PM
rahn committed R943:7384afc86f9b: Correct basysKom Urls. (authored by rahn).
Correct basysKom Urls.
Mon, Sep 2, 12:54 PM
rahn committed R943:de4267f6cd01: Update OSGeo project logo. (authored by rahn).
Update OSGeo project logo.
Mon, Sep 2, 12:54 PM
rahn requested review of D23673: Allow for using Marble with QML Items in external QML files .
Mon, Sep 2, 11:16 AM · KDE Edu, Marble

Tue, Aug 27

rahn accepted D19341: avoid lots of "Unknown feature GeoDataRelationType" warnings when loading an OSM file.
Tue, Aug 27, 7:08 PM · KDE Edu, Marble

Feb 26 2019

rahn added a comment to D11969: [WIP] Earth Globe Plasma wallpaper plugin.

Looks nice to me.

Feb 26 2019, 11:03 AM · Marble, KDE Edu
rahn accepted D11853: Fix Bug 371010: Position Marker is gone/invisible.

sorry for noticing this late

Feb 26 2019, 11:00 AM · KDE Edu, Marble
rahn accepted D18141: Avoid overwriting Qt5_FOUND with Qt5DBus or Qt5WebEngine disabled.

looks good

Feb 26 2019, 10:58 AM · KDE Edu, Marble
rahn accepted D18143: Try to fix build with MARBLE_NO_WEBKITWIDGETS.
Feb 26 2019, 10:57 AM · KDE Edu, Marble
rahn accepted D15879: Eliminate Qt message "QFileSystemEngine::fillMetaData: Empty filename passed to function".
Feb 26 2019, 10:56 AM · KDE Edu, Marble
rahn added a comment to D18124: Implement touch input handling in MarbleWidgetInputHandler.

nice patch!

Feb 26 2019, 10:53 AM · KDE Edu, Marble
rahn added a comment to D19329: allow GeoDataCoordinates::toString() to create an ISO 6709 conforming string.

apart from the Boolean issue this looks good to me and can be submitted.

Feb 26 2019, 10:50 AM · KDE Edu, Marble

Oct 17 2018

rahn committed R34:c751d38cc434: Example update. (authored by rahn).
Example update.
Oct 17 2018, 7:12 PM
rahn committed R34:a0c79ddfeb30: - Fix another CMake CMP0071 warning - Supress Qt5SerialPort warning for… (authored by rahn).
- Fix another CMake CMP0071 warning - Supress Qt5SerialPort warning for…
Oct 17 2018, 5:55 PM
rahn committed R34:b42ee5c83d77: Differential Revision: https://phabricator.kde.org/D698 (authored by rahn).
Differential Revision: https://phabricator.kde.org/D698
Oct 17 2018, 3:11 PM
rahn committed R34:f01bf4732e4a: Adjust the Tropics position. (authored by rahn).
Adjust the Tropics position.
Oct 17 2018, 3:11 PM
rahn requested changes to D698: Port from WebKit to WebEngine..

Thanks a lot guys!

Oct 17 2018, 2:29 PM · KDE Edu, Marble

Sep 21 2018

rahn committed R34:c70d0c97fdf5: BUG: 394517 Changing nominatim to https. (authored by rahn).
BUG: 394517 Changing nominatim to https.
Sep 21 2018, 8:29 AM
rahn committed R34:aa402b91e8a8: BUG: 394517 Changing nominatim to https. (authored by rahn).
BUG: 394517 Changing nominatim to https.
Sep 21 2018, 8:29 AM
rahn committed R34:3e3528530794: BUG: 394517 Changing nominatim to https. (authored by rahn).
BUG: 394517 Changing nominatim to https.
Sep 21 2018, 8:28 AM
rahn committed R34:244217fb70df: BUG: 394517 Changing nominatim to https. (authored by rahn).
BUG: 394517 Changing nominatim to https.
Sep 21 2018, 8:27 AM
rahn committed R34:132ca62cf54b: BUG: 394517 Changing nominatim to https. (authored by rahn).
BUG: 394517 Changing nominatim to https.
Sep 21 2018, 8:27 AM
rahn committed R34:38290278f7d3: BUG: 394517 Changing nominatim to https. (authored by rahn).
BUG: 394517 Changing nominatim to https.
Sep 21 2018, 8:26 AM
rahn committed R34:016b072716ed: BUG: 394517 Changing nominatim to https. (authored by rahn).
BUG: 394517 Changing nominatim to https.
Sep 21 2018, 8:25 AM
rahn committed R34:fc7166eeef78: BUG: 394517 Changing nominatim to https. (authored by rahn).
BUG: 394517 Changing nominatim to https.
Sep 21 2018, 8:25 AM
rahn committed R34:14526cb36608: BUG: 394517 Changing nominatim to https. (authored by rahn).
BUG: 394517 Changing nominatim to https.
Sep 21 2018, 8:23 AM
rahn committed R34:37fdb5c85beb: BUG: 394517 Changing nominatim to https. (authored by rahn).
BUG: 394517 Changing nominatim to https.
Sep 21 2018, 8:23 AM
rahn committed R34:25d873a1f6cb: BUG: 394517 Changing nominatim to https. (authored by rahn).
BUG: 394517 Changing nominatim to https.
Sep 21 2018, 8:21 AM
rahn committed R34:4476573c29bd: BUG: 394517 Changing nominatim to https. (authored by rahn).
BUG: 394517 Changing nominatim to https.
Sep 21 2018, 8:19 AM

Aug 31 2018

rahn added a comment to D15182: ensure "make install" on windows also installs development header files.

Have you tested creating a new deployable Windows package? Or did you just test whether compilation on the platform works? :-)

Aug 31 2018, 11:05 AM · KDE Edu, Marble
rahn added a comment to D15182: ensure "make install" on windows also installs development header files.

Looks good to me!

Aug 31 2018, 11:04 AM · KDE Edu, Marble

Jul 11 2018

rahn accepted D14053: avoid runtime error about unknown signal when compiled without WebKit.

Looks good (should we switch to the new connect syntax?).

Jul 11 2018, 5:59 PM · KDE Edu, Marble
rahn accepted D14054: No version number for the libs on Android.

Sounds good. I'm not exactly familiar with this issue but it looks reasonable. Thanks a lot! :-)

Jul 11 2018, 5:57 PM · KDE Edu, Marble

Jun 21 2018

rahn accepted D13640: stop InertialEarthRotation when a new coordinate is set or keyboard interaction.

Good catch! Looks good to me. Could you commit?

Jun 21 2018, 8:21 AM · KDE Edu, Marble

Nov 6 2017

rahn accepted D8685: Added 2017 GSoC Contributors in Authors List.

Looks good :)

Nov 6 2017, 8:15 PM · KDE Edu

Sep 16 2017

rahn added a comment to D7805: Add a splash screen to Marble Maps.

To me it looks like the 256x256 version got scaled down to 100x100 and then got scaled up again.

Sep 16 2017, 8:48 AM · Marble
rahn added a comment to D7805: Add a splash screen to Marble Maps.

The 256x256 version surely looks better than that:

Sep 16 2017, 8:35 AM · Marble
rahn committed R34:5db029953fe6: Do away with the crashes that were triggered by the m_lastPlacemarkAt-Pointer's… (authored by rahn).
Do away with the crashes that were triggered by the m_lastPlacemarkAt-Pointer's…
Sep 16 2017, 8:24 AM
rahn committed R34:065b4d499e2c: Do away with the crashes that were triggered by the m_lastPlacemarkAt-Pointer's… (authored by rahn).
Do away with the crashes that were triggered by the m_lastPlacemarkAt-Pointer's…
Sep 16 2017, 8:24 AM

Sep 15 2017

rahn committed R34:08cb69b70fe7: Make m_lastPlacemarkAt a QPointer to avoid crashes. (authored by rahn).
Make m_lastPlacemarkAt a QPointer to avoid crashes.
Sep 15 2017, 7:49 PM
rahn committed R34:598dee257a88: Make m_lastPlacemarkAt a QPointer to avoid crashes. (authored by rahn).
Make m_lastPlacemarkAt a QPointer to avoid crashes.
Sep 15 2017, 7:47 PM
rahn accepted D7818: Fix issue of pressing back-button always leading to closing the app instead of handling the event depending on different scenarios.

Please commit.

Sep 15 2017, 4:32 PM · Marble
rahn added a comment to D7805: Add a splash screen to Marble Maps.

... or use the SVG - whatever works better technically (I guess the PNG would be loaded faster on slower devices).

Sep 15 2017, 4:28 PM · Marble
rahn added a comment to D7805: Add a splash screen to Marble Maps.

I've just submitted the 256x256 version of the png to master ...

Sep 15 2017, 4:27 PM · Marble
rahn committed R34:c4e30984a671: Adding 256x256 version for the splash screen. (authored by rahn).
Adding 256x256 version for the splash screen.
Sep 15 2017, 4:26 PM
rahn added a comment to D7805: Add a splash screen to Marble Maps.

Guys, we DO have an SVG as a source file. That's why I asked for the preferred resolution in the first place!

Sep 15 2017, 4:23 PM · Marble

Sep 14 2017

rahn added a comment to D7625: Some countries are invisible on the political map .

And backported to 17.08 branch. Does this patch require any more action?

Sep 14 2017, 5:21 PM · Marble
rahn accepted D7779: Make the bookmarks dialog responsive to touch everywhere in Marble Maps.

Looks good to me. Feel free to commit. It would be great if Judit could verify this. :-)

Sep 14 2017, 5:18 PM · Marble
rahn updated subscribers of D7779: Make the bookmarks dialog responsive to touch everywhere in Marble Maps.
Sep 14 2017, 5:17 PM · Marble
rahn added a reviewer for D7779: Make the bookmarks dialog responsive to touch everywhere in Marble Maps: juditbartha.
Sep 14 2017, 5:17 PM · Marble
rahn committed R34:7a20f244b235: CHANGELOG: Fix for "Some countries are invisible on the political map" BUG… (authored by McPain).
CHANGELOG: Fix for "Some countries are invisible on the political map" BUG…
Sep 14 2017, 5:10 PM
rahn added a comment to D7818: Fix issue of pressing back-button always leading to closing the app instead of handling the event depending on different scenarios.

Looks fine to me. Maybe Judit can confirm this patch?

Sep 14 2017, 5:07 PM · Marble
rahn updated subscribers of D7818: Fix issue of pressing back-button always leading to closing the app instead of handling the event depending on different scenarios.
Sep 14 2017, 5:06 PM · Marble
rahn added a comment to D7805: Add a splash screen to Marble Maps.

Looks nice indeed - but the logo should be bigger.

Sep 14 2017, 5:04 PM · Marble
rahn added a comment to D7805: Add a splash screen to Marble Maps.

I think that displaying the Marble logo is fine - which version are you using currently? 128x128? What would be suitable for most devices? 256x256?

Sep 14 2017, 5:03 PM · Marble
rahn accepted D7625: Some countries are invisible on the political map .

Submitted to master.

Sep 14 2017, 4:57 PM · Marble
rahn committed R34:456266eb31a8: CHANGELOG: Fix for "Some countries are invisible on the political map" BUG… (authored by McPain).
CHANGELOG: Fix for "Some countries are invisible on the political map" BUG…
Sep 14 2017, 4:50 PM

Sep 13 2017

rahn added a comment to D7625: Some countries are invisible on the political map .

I looked a bit deeper into the code and indeed it sounds sensible that a feature could possibly mapped to multiple items. So unless there are any concerns from other developers I will commit this later today.

Sep 13 2017, 6:48 AM · Marble
rahn added a comment to D7625: Some countries are invisible on the political map .

Thanks for keeping the ball rolling regarding this very important issue.

Sep 13 2017, 5:39 AM · Marble

Aug 31 2017

rahn added a comment to D7623: Remove the visual category "building".

Looks good to me!

Aug 31 2017, 6:58 PM
rahn added a comment to D7625: Some countries are invisible on the political map .

Now the only other similar regression is see is the initial lack of colorization for the atlas map theme. Might be a nice follow-up issue to look into if you feel like it ;)

Aug 31 2017, 6:14 PM · Marble
rahn added a comment to D7625: Some countries are invisible on the political map .

Thanks a lot! I've just tested it and it works nicely indeed (also for the other vector-based maps).

Aug 31 2017, 6:12 PM · Marble
rahn added inline comments to D7622: Render indoor walls, rooms and doors.
Aug 31 2017, 5:59 PM

Aug 28 2017

rahn added inline comments to D7490: Marble Maps combined revisions.
Aug 28 2017, 3:47 PM · Marble
rahn added inline comments to D7493: Behaim Globe revisions.
Aug 28 2017, 3:42 PM · Marble: Material Maps
rahn added a comment to D7493: Behaim Globe revisions.

Looks very good to me.

Aug 28 2017, 3:41 PM · Marble: Material Maps

Aug 21 2017

rahn added a comment to D7453: Marble Maps design revisions.

Looks nice to me in general.

Aug 21 2017, 6:28 PM · Marble
rahn committed R34:bc692ab6f3b1: Plain SVG (authored by rahn).
Plain SVG
Aug 21 2017, 5:56 PM
rahn committed R34:ca668ebf10ab: Alternative icon for door (authored by rahn).
Alternative icon for door
Aug 21 2017, 5:54 PM
rahn added a comment to D7453: Marble Maps design revisions.

Looks nice to me in general.

Aug 21 2017, 5:19 PM · Marble

Aug 20 2017

rahn committed R34:9a0e6f47e387: First suggestion for a door icon. (authored by rahn).
First suggestion for a door icon.
Aug 20 2017, 8:55 AM
rahn committed R34:5740b95e3fb0: First suggestion for a wall icon. (authored by rahn).
First suggestion for a wall icon.
Aug 20 2017, 8:19 AM
rahn added inline comments to D7353: Marble Maps design revisions using Kirigami.
Aug 20 2017, 7:24 AM · Kirigami, Marble: Material Maps
rahn added a comment to D7353: Marble Maps design revisions using Kirigami.

Any further updates? :)

Aug 20 2017, 7:21 AM · Kirigami, Marble: Material Maps

Aug 14 2017

rahn added a comment to D7252: WIP: Add UI to change levels in a building/area.

Looks good to me in general. I guess the only other consideration that we can postpone for now is binary compatibility.

Aug 14 2017, 6:39 PM