rahn (Torsten Rahn)
User

Projects

Badges

User does not have any badges.
User Since
Sep 8 2015, 2:26 PM (75 w, 6 d)

Recent Activity

Dec 17 2016

rahn added a comment to T4911: Invert landmass.

I don't see the big advantage of this approach. Both approaches have their advantages and disadvantages: For the inverted approach you have flicker for coast- and sea areas (which looks equally bad and odd to me). Implementing the inverted approach will have a slight performance advantage if we don't manage the background color in a more sophisticated way. Implementing the inverted approach means on the other side that we have to develop a special dedicated plugin that will paint the pole caps blue - to avoid landmass-white circular polecaps beyond +/-85 degs latitude.

Dec 17 2016, 9:19 AM · Marble

Dec 11 2016

rahn added a reverting commit for R34:7d0e1583707d: Call update right from the initialization.: R34:08d83c42c4c9: Something isn't quite right with regard to this. Pulling it back until the….
Dec 11 2016, 6:39 PM
rahn committed R34:08d83c42c4c9: Something isn't quite right with regard to this. Pulling it back until the… (authored by rahn).
Something isn't quite right with regard to this. Pulling it back until the…
Dec 11 2016, 6:39 PM
rahn committed R34:7d0e1583707d: Call update right from the initialization. (authored by rahn).
Call update right from the initialization.
Dec 11 2016, 5:59 PM
rahn committed R34:2c08c033fa5c: Fixes for wrong linestring styling (e.g. trams). (authored by rahn).
Fixes for wrong linestring styling (e.g. trams).
Dec 11 2016, 3:06 PM
rahn accepted D3642: Show wheelchair information.
Dec 11 2016, 12:22 PM
rahn added inline comments to D3642: Show wheelchair information.
Dec 11 2016, 12:08 PM
rahn committed R34:6ce34abed1ef: Adding adminlevel 2 capital icon for GCI task. (authored by rahn).
Adding adminlevel 2 capital icon for GCI task.
Dec 11 2016, 10:00 AM
rahn committed R34:c099e92e7974: Life is short. http://meaningdefined.com/what-is-the-meaning-of/okdbg/acronym… (authored by rahn).
Life is short. http://meaningdefined.com/what-is-the-meaning-of/okdbg/acronym…
Dec 11 2016, 12:32 AM
rahn committed R34:0389cac041e4: Minor improvements to the visual debug modes (authored by rahn).
Minor improvements to the visual debug modes
Dec 11 2016, 12:29 AM

Dec 10 2016

rahn committed R34:221f153ce665: Cache GeoGraphicsScene::items() as much as possible. (authored by rahn).
Cache GeoGraphicsScene::items() as much as possible.
Dec 10 2016, 9:12 PM
rahn committed R34:7e68a2f81c0c: Introducing (authored by rahn).
Introducing
Dec 10 2016, 7:25 PM

Dec 9 2016

rahn committed R34:bf88fdd2bae4: Batch rendering for roads, Admin boundaries, rivers and non-special cased… (authored by rahn).
Batch rendering for roads, Admin boundaries, rivers and non-special cased…
Dec 9 2016, 3:19 PM
rahn committed R34:6b0cf92c229f: Partial fix for building number regression. (authored by rahn).
Partial fix for building number regression.
Dec 9 2016, 12:25 AM

Dec 8 2016

rahn committed R34:b76b9ecefb91: Fix position provider performance issue: Don't always query the actual position… (authored by rahn).
Fix position provider performance issue: Don't always query the actual position…
Dec 8 2016, 10:18 PM
rahn committed R34:3364bf6d358d: Performance: Only perform painter configuration if there is really… (authored by rahn).
Performance: Only perform painter configuration if there is really…
Dec 8 2016, 4:48 PM
rahn committed R34:0409e2691c72: AbstractGeoPolygonGraphicsItem refactoring to avoid painter state changes… (authored by rahn).
AbstractGeoPolygonGraphicsItem refactoring to avoid painter state changes…
Dec 8 2016, 4:48 PM
rahn committed R34:47418575d4f5: Add icons for further GCI tasks. (authored by rahn).
Add icons for further GCI tasks.
Dec 8 2016, 6:52 AM

Dec 7 2016

rahn committed R34:72e1772eece5: Adding the header as well .. (authored by rahn).
Adding the header as well ..
Dec 7 2016, 8:52 PM
rahn committed R34:d31a23be1ef4: Fix the build by adding BatchedPlacemarkRenderer.cpp (authored by rahn).
Fix the build by adding BatchedPlacemarkRenderer.cpp
Dec 7 2016, 7:56 PM
rahn committed R34:f3783637baa0: Separate house numbers rendering to be actually drawn after drawing the… (authored by rahn).
Separate house numbers rendering to be actually drawn after drawing the…
Dec 7 2016, 6:13 PM

Dec 5 2016

rahn committed R34:3f33818442b8: - Fix "dancing rivers" introduced by omitting the mandatory outline layer. (authored by rahn).
- Fix "dancing rivers" introduced by omitting the mandatory outline layer.
Dec 5 2016, 11:26 PM
rahn committed R34:f2635ad69bc4: try harder to avoid QImage. (authored by rahn).
try harder to avoid QImage.
Dec 5 2016, 9:21 PM
rahn committed R34:f5419eaaf0b8: Let's avoid the roundtrip around QImage when creating the brush texture. (authored by rahn).
Let's avoid the roundtrip around QImage when creating the brush texture.
Dec 5 2016, 8:38 PM
rahn committed R34:bf7b5e150564: Add reserve call to GeoDataLineString and to the OSM file runner. (authored by rahn).
Add reserve call to GeoDataLineString and to the OSM file runner.
Dec 5 2016, 6:44 AM

Dec 4 2016

rahn committed R34:373230c94a40: Use QPolygon::reserve where possible. (authored by rahn).
Use QPolygon::reserve where possible.
Dec 4 2016, 11:40 PM
rahn committed R34:2777cef9944b: Performance: At level 17 render buildings flat. (authored by rahn).
Performance: At level 17 render buildings flat.
Dec 4 2016, 8:52 PM

Dec 3 2016

rahn committed R34:456bb981173a: Lots of new osmcarto icons! (authored by rahn).
Lots of new osmcarto icons!
Dec 3 2016, 12:52 PM

Dec 2 2016

rahn committed R34:e4e70ad127e6: Render Raceway Highways https://phabricator.kde.org/D3570 (authored by xdizzaster).
Render Raceway Highways https://phabricator.kde.org/D3570
Dec 2 2016, 9:38 PM
rahn accepted D3570: Render raceways highways.

Excellent!

Dec 2 2016, 9:19 PM
rahn added a comment to D3570: Render raceways highways.

I've tested you patch and the only thing left to complete this task seems to be the compilation warning above. Apart from that it looks great.

Dec 2 2016, 8:53 PM
rahn added a comment to D3570: Render raceways highways.

Sorry, still a nitpick: during compilation I get this:

Dec 2 2016, 8:48 PM
rahn added a comment to D3570: Render raceways highways.

Nice, still some minor nitpicks.

Dec 2 2016, 7:32 PM
rahn added reviewers for D3570: Render raceways highways: nienhueser, rahn, Marble.
Dec 2 2016, 5:25 PM
rahn added a member for Marble: xdizzaster.
Dec 2 2016, 5:13 PM

Dec 1 2016

rahn added a comment to D3563: Added a warning when no plugins could be loaded, see T2114 for more details..

Didn't know about isEmpty(), but should have, I feel bad now...
If by OSD you mean the notifications from KDE, I don't think it is necessary: Unix users can always look at the debug output, just Windows users would have to debug the application to get those messages, so that's why a QMessageBox is better for them I figure.

Dec 1 2016, 9:02 PM
rahn added inline comments to D3563: Added a warning when no plugins could be loaded, see T2114 for more details..
Dec 1 2016, 8:16 PM
rahn added a comment to D3563: Added a warning when no plugins could be loaded, see T2114 for more details..

Nice start :-) I guess that's a successful liftoff for our rocket!

Dec 1 2016, 8:13 PM
rahn edited the description of T4788: Show speed cameras.
Dec 1 2016, 2:08 PM · Marble
rahn edited the description of T4788: Show speed cameras.
Dec 1 2016, 2:08 PM · Marble
rahn committed R34:019e508ac999: Speed camera icon. (authored by rahn).
Speed camera icon.
Dec 1 2016, 2:07 PM

Nov 30 2016

rahn committed R34:f4befe7d9dd8: Enter the Animation viewcontext on touch/press . Prevent repainting the screen… (authored by rahn).
Enter the Animation viewcontext on touch/press . Prevent repainting the screen…
Nov 30 2016, 11:27 PM
rahn committed R34:373c872ce567: drawPolygon -> drawPolyline (authored by rahn).
drawPolygon -> drawPolyline
Nov 30 2016, 10:08 PM
rahn committed R34:6f1487806c6e: drawPolygon -> drawPolyLine (authored by rahn).
drawPolygon -> drawPolyLine
Nov 30 2016, 9:40 PM
rahn committed R34:c409e6b674fe: Always keep the search query in the same position. (authored by rahn).
Always keep the search query in the same position.
Nov 30 2016, 7:22 AM

Nov 29 2016

rahn committed R34:e95ecfcb1d43: Performance: Don't calculate the roof points twice ... (authored by rahn).
Performance: Don't calculate the roof points twice ...
Nov 29 2016, 9:22 PM
rahn committed R34:02645ed73443: Add backface culling for buildings. This improves speed by about 20% for areas… (authored by rahn).
Add backface culling for buildings. This improves speed by about 20% for areas…
Nov 29 2016, 5:26 PM

Nov 28 2016

rahn committed R34:37eb1ba4ae55: Make the dialog animation perfectly smooth and quick. (authored by rahn).
Make the dialog animation perfectly smooth and quick.
Nov 28 2016, 6:11 PM
rahn committed R34:d229d75da601: Revert "Don't show the navigation button if there is" (authored by rahn).
Revert "Don't show the navigation button if there is"
Nov 28 2016, 4:50 PM
rahn added a reverting commit for R34:0b89bc458527: Don't show the navigation button if there is: R34:d229d75da601: Revert "Don't show the navigation button if there is".
Nov 28 2016, 4:50 PM
rahn committed R34:9f9df45cd260: Previously we disregarded the focusPoint when doing a pinch gesture - while we… (authored by rahn).
Previously we disregarded the focusPoint when doing a pinch gesture - while we…
Nov 28 2016, 4:39 PM
rahn committed R34:0b89bc458527: Don't show the navigation button if there is (authored by rahn).
Don't show the navigation button if there is
Nov 28 2016, 4:39 PM

Nov 27 2016

rahn committed R34:42fdfed5d6e0: QML refactoring: Clean up general design so that there are less cross… (authored by rahn).
QML refactoring: Clean up general design so that there are less cross…
Nov 27 2016, 4:21 PM

Nov 26 2016

rahn committed R34:d67cd94bad67: Add comments to GeoGraphicsScene. (authored by rahn).
Add comments to GeoGraphicsScene.
Nov 26 2016, 4:42 PM

Nov 23 2016

rahn committed R34:ed9b03c4908f: Don't display stars with a magnitude > 5. (authored by rahn).
Don't display stars with a magnitude > 5.
Nov 23 2016, 7:31 PM
rahn lowered the priority of T4562: Optimize Render Performance of Stars Plugin from "Normal" to "Low".
Nov 23 2016, 7:13 PM · Marble
rahn added a comment to T4562: Optimize Render Performance of Stars Plugin.

I've taken the low-hanging fruit:

Nov 23 2016, 7:13 PM · Marble
rahn updated subscribers of T4599: Revisit Performance of Mercator Projection.
Nov 23 2016, 5:22 PM · Marble
rahn added a comment to T4599: Revisit Performance of Mercator Projection.

So I benchmarked the Mercator projection on my desktop PC. AbstractProjection::geoCoordinates() uses MarbleMath::gd() while AbstractProjection::screenCoordinates() uses its inverse MarbleMath::gdInv().
Since screenCoordinates is used by far most of the time we put our focus on gdInv:

Nov 23 2016, 5:22 PM · Marble
rahn edited the description of T4599: Revisit Performance of Mercator Projection.
Nov 23 2016, 4:54 PM · Marble
rahn added a project to T4599: Revisit Performance of Mercator Projection: Marble.
Nov 23 2016, 4:53 PM · Marble
rahn committed R34:372195b5e6f8: Remove qDebug (authored by rahn).
Remove qDebug
Nov 23 2016, 4:16 PM
rahn committed R34:2dd4ef69892d: Fix crash in BuildingGeoPolygonGraphicsItem. (authored by rahn).
Fix crash in BuildingGeoPolygonGraphicsItem.
Nov 23 2016, 4:03 PM

Nov 22 2016

rahn committed R34:a85a82044d14: Better approach: Refactor GeoPainter::drawPolygon to take a more generic (and… (authored by rahn).
Better approach: Refactor GeoPainter::drawPolygon to take a more generic (and…
Nov 22 2016, 5:00 PM
rahn created T4599: Revisit Performance of Mercator Projection.
Nov 22 2016, 2:52 AM · Marble
rahn closed T4564: Fix Performance issues with Polygons with holes as "Resolved".

Implemented and merged.

Nov 22 2016, 2:47 AM · Marble
rahn committed R34:a2462ca3ab8c: Polygon hole refactoring for buildings. (authored by rahn).
Polygon hole refactoring for buildings.
Nov 22 2016, 2:31 AM

Nov 21 2016

rahn committed R34:7f744da4ad22: Don't calculate extra screencoordinates for a transparent outline of polygons… (authored by rahn).
Don't calculate extra screencoordinates for a transparent outline of polygons…
Nov 21 2016, 11:05 PM
rahn committed R34:376a900cdd69: Changing the way holes get rendered in generic polygons (not yet in buildings). (authored by rahn).
Changing the way holes get rendered in generic polygons (not yet in buildings).
Nov 21 2016, 7:28 PM

Nov 19 2016

rahn added a comment to T4590: Batch Rendering of House Numbers.

Currently the house numbers are drawn as part of the building rendering. This results in expensive pen/brush/state changes and should be avoided.

Nov 19 2016, 4:57 PM · Marble

Nov 15 2016

rahn claimed T4562: Optimize Render Performance of Stars Plugin.
Nov 15 2016, 6:37 PM · Marble
rahn created T4564: Fix Performance issues with Polygons with holes.
Nov 15 2016, 6:36 PM · Marble
rahn added a comment to T4562: Optimize Render Performance of Stars Plugin.
  • Stars should be sorted on Startup by Magnitude
  • Stars should be painted in batches by magnitude (and color).
  • There should be a cut-off magnitude that is lower on mobile devices than on the desktop where the whole magnitude range is displayed.
Nov 15 2016, 6:12 PM · Marble

Nov 14 2016

rahn committed R34:6c4dc2ff09e9: When e.g. calling createWayStyle then NEVER do this: (authored by rahn).
When e.g. calling createWayStyle then NEVER do this:
Nov 14 2016, 1:17 PM
rahn committed R34:34b666e1b756: Minor tweaks to the position marker. (authored by rahn).
Minor tweaks to the position marker.
Nov 14 2016, 12:32 AM
rahn committed R34:f1a7db2fa7e6: Display a circle instead of an arrow for the position marker is speed is less… (authored by rahn).
Display a circle instead of an arrow for the position marker is speed is less…
Nov 14 2016, 12:32 AM

Nov 13 2016

rahn committed R34:859d12735508: - Clean up position marker code - Animate position marker rotation, position… (authored by rahn).
- Clean up position marker code - Animate position marker rotation, position…
Nov 13 2016, 9:18 PM

Nov 12 2016

rahn committed R34:9e11b578f18e: configurePainter refactoring: The intent of the previous implementation had… (authored by rahn).
configurePainter refactoring: The intent of the previous implementation had…
Nov 12 2016, 10:50 PM
rahn committed R34:a6f946ed2ea3: Take an average of the currently available screen sizes into account when… (authored by rahn).
Take an average of the currently available screen sizes into account when…
Nov 12 2016, 1:50 PM

Nov 11 2016

rahn committed R34:841628cb8873: Minor fixes in the Marble Maps UI qml code. (authored by rahn).
Minor fixes in the Marble Maps UI qml code.
Nov 11 2016, 6:51 PM
rahn committed R34:9d90adc92799: Refactoring of the Routing element: QQuickPaintedItem -> QQuickItem This… (authored by rahn).
Refactoring of the Routing element: QQuickPaintedItem -> QQuickItem This…
Nov 11 2016, 6:20 PM
rahn committed R34:e2091b15cebe: This commit brings performance on my tablet from 3fps to about 30 fps at level… (authored by rahn).
This commit brings performance on my tablet from 3fps to about 30 fps at level…
Nov 11 2016, 1:45 PM

Nov 10 2016

rahn committed R34:73b95db97f7a: Re-add qDeleteAll + clear to get proper rendering again. (authored by rahn).
Re-add qDeleteAll + clear to get proper rendering again.
Nov 10 2016, 7:09 PM
rahn committed R34:4f89f8ea3c72: Minor building rendering optimization: (authored by rahn).
Minor building rendering optimization:
Nov 10 2016, 6:59 PM
rahn committed R34:73dcb3cb8cfc: Remove superfluous parameter. (authored by rahn).
Remove superfluous parameter.
Nov 10 2016, 6:59 PM
rahn accepted D3316: Remove implicit sharing from GeoDataFeature & subclasses.

Looks good to me in general :) I trust you on the details :)

Nov 10 2016, 4:11 PM
rahn committed R34:620499fdb830: More efficient street rendering: (authored by rahn).
More efficient street rendering:
Nov 10 2016, 3:28 PM
rahn committed R34:070c60b5d990: Add batch rendering visualization for the desktop: This debug mode can be… (authored by rahn).
Add batch rendering visualization for the desktop: This debug mode can be…
Nov 10 2016, 12:13 AM

Nov 9 2016

rahn committed R34:0db4edeb1116: Preliminary rough fix for the graticule: Show the graticule on top of the… (authored by rahn).
Preliminary rough fix for the graticule: Show the graticule on top of the…
Nov 9 2016, 9:08 PM
rahn committed R34:83f32cd936f3: keep the color for displaying batch rendering of placemarks constant. (authored by rahn).
keep the color for displaying batch rendering of placemarks constant.
Nov 9 2016, 8:09 PM
rahn committed R34:0d3aedbb8a37: Batch Rendering for placemark symbol pixmaps: - Actually share identical… (authored by rahn).
Batch Rendering for placemark symbol pixmaps: - Actually share identical…
Nov 9 2016, 6:07 PM

Oct 28 2016

rahn committed R34:036a4bdcaede: Set the QQuickPaintedItem opaque and don't render the application background… (authored by rahn).
Set the QQuickPaintedItem opaque and don't render the application background…
Oct 28 2016, 1:13 PM
rahn committed R34:0457cc7a20ef: Change the render target for Marble's QQuickPaintedItem to FBO. (authored by rahn).
Change the render target for Marble's QQuickPaintedItem to FBO.
Oct 28 2016, 11:48 AM

Oct 27 2016

rahn added a member for Marble: lgronning.
Oct 27 2016, 11:15 AM

Oct 6 2016

rahn accepted D2780: Introducing GeoSceneAbstractTileProjection for tile x/y <-> lonlat.
Oct 6 2016, 2:13 PM

Oct 5 2016

rahn committed R34:fa8ed7041dd3: Initial fix for webpopup appearance. (authored by rahn).
Initial fix for webpopup appearance.
Oct 5 2016, 2:47 PM

Oct 2 2016

rahn added a comment to D2828: Split GeoPolygonGraphicsItem class into subtypes Building & Normal.

Right now we seem to instantiate three relatively expensive texture-related objects

Oct 2 2016, 7:50 PM

Sep 15 2016

rahn added a comment to D2780: Introducing GeoSceneAbstractTileProjection for tile x/y <-> lonlat.

Q1: Error/out-of-bounds handling?
Where to handle bad input data, like out-of-bound values?

Sep 15 2016, 11:17 AM
rahn requested changes to D2780: Introducing GeoSceneAbstractTileProjection for tile x/y <-> lonlat.
Sep 15 2016, 11:10 AM
rahn added a comment to D2780: Introducing GeoSceneAbstractTileProjection for tile x/y <-> lonlat.

Q3: Always use Gudermannian function?

Sep 15 2016, 10:55 AM