rahn (Torsten Rahn)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Sep 8 2015, 2:26 PM (200 w, 6 d)
Availability
Available

Recent Activity

Feb 26 2019

rahn added a comment to D11969: [WIP] Earth Globe Plasma wallpaper plugin.

Looks nice to me.

Feb 26 2019, 11:03 AM · Marble, KDE Edu
rahn accepted D11853: Fix Bug 371010: Position Marker is gone/invisible.

sorry for noticing this late

Feb 26 2019, 11:00 AM · Marble, KDE Edu
rahn accepted D18141: Avoid overwriting Qt5_FOUND with Qt5DBus or Qt5WebEngine disabled.

looks good

Feb 26 2019, 10:58 AM · KDE Edu, Marble
rahn accepted D18143: Try to fix build with MARBLE_NO_WEBKITWIDGETS.
Feb 26 2019, 10:57 AM · KDE Edu, Marble
rahn accepted D15879: Eliminate Qt message "QFileSystemEngine::fillMetaData: Empty filename passed to function".
Feb 26 2019, 10:56 AM · KDE Edu, Marble
rahn added a comment to D18124: Implement touch input handling in MarbleWidgetInputHandler.

nice patch!

Feb 26 2019, 10:53 AM · KDE Edu, Marble
rahn added a comment to D19329: allow GeoDataCoordinates::toString() to create an ISO 6709 conforming string.

apart from the Boolean issue this looks good to me and can be submitted.

Feb 26 2019, 10:50 AM · KDE Edu, Marble

Oct 17 2018

rahn committed R34:c751d38cc434: Example update. (authored by rahn).
Example update.
Oct 17 2018, 7:12 PM
rahn committed R34:a0c79ddfeb30: - Fix another CMake CMP0071 warning - Supress Qt5SerialPort warning for… (authored by rahn).
- Fix another CMake CMP0071 warning - Supress Qt5SerialPort warning for…
Oct 17 2018, 5:55 PM
rahn committed R34:b42ee5c83d77: Differential Revision: https://phabricator.kde.org/D698 (authored by rahn).
Differential Revision: https://phabricator.kde.org/D698
Oct 17 2018, 3:11 PM
rahn committed R34:f01bf4732e4a: Adjust the Tropics position. (authored by rahn).
Adjust the Tropics position.
Oct 17 2018, 3:11 PM
rahn requested changes to D698: Port from WebKit to WebEngine..

Thanks a lot guys!

Oct 17 2018, 2:29 PM · KDE Edu, Marble

Sep 21 2018

rahn committed R34:c70d0c97fdf5: BUG: 394517 Changing nominatim to https. (authored by rahn).
BUG: 394517 Changing nominatim to https.
Sep 21 2018, 8:29 AM
rahn committed R34:aa402b91e8a8: BUG: 394517 Changing nominatim to https. (authored by rahn).
BUG: 394517 Changing nominatim to https.
Sep 21 2018, 8:29 AM
rahn committed R34:3e3528530794: BUG: 394517 Changing nominatim to https. (authored by rahn).
BUG: 394517 Changing nominatim to https.
Sep 21 2018, 8:28 AM
rahn committed R34:244217fb70df: BUG: 394517 Changing nominatim to https. (authored by rahn).
BUG: 394517 Changing nominatim to https.
Sep 21 2018, 8:27 AM
rahn committed R34:132ca62cf54b: BUG: 394517 Changing nominatim to https. (authored by rahn).
BUG: 394517 Changing nominatim to https.
Sep 21 2018, 8:27 AM
rahn committed R34:38290278f7d3: BUG: 394517 Changing nominatim to https. (authored by rahn).
BUG: 394517 Changing nominatim to https.
Sep 21 2018, 8:26 AM
rahn committed R34:016b072716ed: BUG: 394517 Changing nominatim to https. (authored by rahn).
BUG: 394517 Changing nominatim to https.
Sep 21 2018, 8:25 AM
rahn committed R34:fc7166eeef78: BUG: 394517 Changing nominatim to https. (authored by rahn).
BUG: 394517 Changing nominatim to https.
Sep 21 2018, 8:25 AM
rahn committed R34:14526cb36608: BUG: 394517 Changing nominatim to https. (authored by rahn).
BUG: 394517 Changing nominatim to https.
Sep 21 2018, 8:23 AM
rahn committed R34:37fdb5c85beb: BUG: 394517 Changing nominatim to https. (authored by rahn).
BUG: 394517 Changing nominatim to https.
Sep 21 2018, 8:23 AM
rahn committed R34:25d873a1f6cb: BUG: 394517 Changing nominatim to https. (authored by rahn).
BUG: 394517 Changing nominatim to https.
Sep 21 2018, 8:21 AM
rahn committed R34:4476573c29bd: BUG: 394517 Changing nominatim to https. (authored by rahn).
BUG: 394517 Changing nominatim to https.
Sep 21 2018, 8:19 AM

Aug 31 2018

rahn added a comment to D15182: ensure "make install" on windows also installs development header files.

Have you tested creating a new deployable Windows package? Or did you just test whether compilation on the platform works? :-)

Aug 31 2018, 11:05 AM · KDE Edu, Marble
rahn added a comment to D15182: ensure "make install" on windows also installs development header files.

Looks good to me!

Aug 31 2018, 11:04 AM · KDE Edu, Marble

Jul 11 2018

rahn accepted D14053: avoid runtime error about unknown signal when compiled without WebKit.

Looks good (should we switch to the new connect syntax?).

Jul 11 2018, 5:59 PM · KDE Edu, Marble
rahn accepted D14054: No version number for the libs on Android.

Sounds good. I'm not exactly familiar with this issue but it looks reasonable. Thanks a lot! :-)

Jul 11 2018, 5:57 PM · KDE Edu, Marble

Jun 21 2018

rahn accepted D13640: stop InertialEarthRotation when a new coordinate is set or keyboard interaction.

Good catch! Looks good to me. Could you commit?

Jun 21 2018, 8:21 AM · KDE Edu, Marble

Nov 6 2017

rahn accepted D8685: Added 2017 GSoC Contributors in Authors List.

Looks good :)

Nov 6 2017, 8:15 PM · KDE Edu

Sep 16 2017

rahn added a comment to D7805: Add a splash screen to Marble Maps.

To me it looks like the 256x256 version got scaled down to 100x100 and then got scaled up again.

Sep 16 2017, 8:48 AM · Marble
rahn added a comment to D7805: Add a splash screen to Marble Maps.

The 256x256 version surely looks better than that:

Sep 16 2017, 8:35 AM · Marble
rahn committed R34:5db029953fe6: Do away with the crashes that were triggered by the m_lastPlacemarkAt-Pointer's… (authored by rahn).
Do away with the crashes that were triggered by the m_lastPlacemarkAt-Pointer's…
Sep 16 2017, 8:24 AM
rahn committed R34:065b4d499e2c: Do away with the crashes that were triggered by the m_lastPlacemarkAt-Pointer's… (authored by rahn).
Do away with the crashes that were triggered by the m_lastPlacemarkAt-Pointer's…
Sep 16 2017, 8:24 AM

Sep 15 2017

rahn committed R34:08cb69b70fe7: Make m_lastPlacemarkAt a QPointer to avoid crashes. (authored by rahn).
Make m_lastPlacemarkAt a QPointer to avoid crashes.
Sep 15 2017, 7:49 PM
rahn committed R34:598dee257a88: Make m_lastPlacemarkAt a QPointer to avoid crashes. (authored by rahn).
Make m_lastPlacemarkAt a QPointer to avoid crashes.
Sep 15 2017, 7:47 PM
rahn accepted D7818: Fix issue of pressing back-button always leading to closing the app instead of handling the event depending on different scenarios.

Please commit.

Sep 15 2017, 4:32 PM · Marble
rahn added a comment to D7805: Add a splash screen to Marble Maps.

... or use the SVG - whatever works better technically (I guess the PNG would be loaded faster on slower devices).

Sep 15 2017, 4:28 PM · Marble
rahn added a comment to D7805: Add a splash screen to Marble Maps.

I've just submitted the 256x256 version of the png to master ...

Sep 15 2017, 4:27 PM · Marble
rahn committed R34:c4e30984a671: Adding 256x256 version for the splash screen. (authored by rahn).
Adding 256x256 version for the splash screen.
Sep 15 2017, 4:26 PM
rahn added a comment to D7805: Add a splash screen to Marble Maps.

Guys, we DO have an SVG as a source file. That's why I asked for the preferred resolution in the first place!

Sep 15 2017, 4:23 PM · Marble

Sep 14 2017

rahn added a comment to D7625: Some countries are invisible on the political map .

And backported to 17.08 branch. Does this patch require any more action?

Sep 14 2017, 5:21 PM · Marble
rahn accepted D7779: Make the bookmarks dialog responsive to touch everywhere in Marble Maps.

Looks good to me. Feel free to commit. It would be great if Judit could verify this. :-)

Sep 14 2017, 5:18 PM · Marble
rahn updated subscribers of D7779: Make the bookmarks dialog responsive to touch everywhere in Marble Maps.
Sep 14 2017, 5:17 PM · Marble
rahn added a reviewer for D7779: Make the bookmarks dialog responsive to touch everywhere in Marble Maps: juditbartha.
Sep 14 2017, 5:17 PM · Marble
rahn committed R34:7a20f244b235: CHANGELOG: Fix for "Some countries are invisible on the political map" BUG… (authored by McPain).
CHANGELOG: Fix for "Some countries are invisible on the political map" BUG…
Sep 14 2017, 5:10 PM
rahn added a comment to D7818: Fix issue of pressing back-button always leading to closing the app instead of handling the event depending on different scenarios.

Looks fine to me. Maybe Judit can confirm this patch?

Sep 14 2017, 5:07 PM · Marble
rahn updated subscribers of D7818: Fix issue of pressing back-button always leading to closing the app instead of handling the event depending on different scenarios.
Sep 14 2017, 5:06 PM · Marble
rahn added a comment to D7805: Add a splash screen to Marble Maps.

Looks nice indeed - but the logo should be bigger.

Sep 14 2017, 5:04 PM · Marble
rahn added a comment to D7805: Add a splash screen to Marble Maps.

I think that displaying the Marble logo is fine - which version are you using currently? 128x128? What would be suitable for most devices? 256x256?

Sep 14 2017, 5:03 PM · Marble
rahn accepted D7625: Some countries are invisible on the political map .

Submitted to master.

Sep 14 2017, 4:57 PM · Marble
rahn committed R34:456266eb31a8: CHANGELOG: Fix for "Some countries are invisible on the political map" BUG… (authored by McPain).
CHANGELOG: Fix for "Some countries are invisible on the political map" BUG…
Sep 14 2017, 4:50 PM

Sep 13 2017

rahn added a comment to D7625: Some countries are invisible on the political map .

I looked a bit deeper into the code and indeed it sounds sensible that a feature could possibly mapped to multiple items. So unless there are any concerns from other developers I will commit this later today.

Sep 13 2017, 6:48 AM · Marble
rahn added a comment to D7625: Some countries are invisible on the political map .

Thanks for keeping the ball rolling regarding this very important issue.

Sep 13 2017, 5:39 AM · Marble

Aug 31 2017

rahn added a comment to D7623: Remove the visual category "building".

Looks good to me!

Aug 31 2017, 6:58 PM
rahn added a comment to D7625: Some countries are invisible on the political map .

Now the only other similar regression is see is the initial lack of colorization for the atlas map theme. Might be a nice follow-up issue to look into if you feel like it ;)

Aug 31 2017, 6:14 PM · Marble
rahn added a comment to D7625: Some countries are invisible on the political map .

Thanks a lot! I've just tested it and it works nicely indeed (also for the other vector-based maps).

Aug 31 2017, 6:12 PM · Marble
rahn added inline comments to D7622: Render indoor walls, rooms and doors.
Aug 31 2017, 5:59 PM

Aug 28 2017

rahn added inline comments to D7490: Marble Maps combined revisions.
Aug 28 2017, 3:47 PM · Marble
rahn added inline comments to D7493: Behaim Globe revisions.
Aug 28 2017, 3:42 PM · Marble: Material Maps
rahn added a comment to D7493: Behaim Globe revisions.

Looks very good to me.

Aug 28 2017, 3:41 PM · Marble: Material Maps

Aug 21 2017

rahn added a comment to D7453: Marble Maps design revisions.

Looks nice to me in general.

Aug 21 2017, 6:28 PM · Marble
rahn committed R34:bc692ab6f3b1: Plain SVG (authored by rahn).
Plain SVG
Aug 21 2017, 5:56 PM
rahn committed R34:ca668ebf10ab: Alternative icon for door (authored by rahn).
Alternative icon for door
Aug 21 2017, 5:54 PM
rahn added a comment to D7453: Marble Maps design revisions.

Looks nice to me in general.

Aug 21 2017, 5:19 PM · Marble

Aug 20 2017

rahn committed R34:9a0e6f47e387: First suggestion for a door icon. (authored by rahn).
First suggestion for a door icon.
Aug 20 2017, 8:55 AM
rahn committed R34:5740b95e3fb0: First suggestion for a wall icon. (authored by rahn).
First suggestion for a wall icon.
Aug 20 2017, 8:19 AM
rahn added inline comments to D7353: Marble Maps design revisions using Kirigami.
Aug 20 2017, 7:24 AM · Kirigami, Marble: Material Maps
rahn added a comment to D7353: Marble Maps design revisions using Kirigami.

Any further updates? :)

Aug 20 2017, 7:21 AM · Kirigami, Marble: Material Maps

Aug 14 2017

rahn added a comment to D7252: WIP: Add UI to change levels in a building/area.

Looks good to me in general. I guess the only other consideration that we can postpone for now is binary compatibility.

Aug 14 2017, 6:39 PM

Jul 2 2017

rahn added inline comments to D6303: Initial integration of the GeoDataBuilding into the parser and renderer.
Jul 2 2017, 7:50 PM

Jun 12 2017

rahn assigned T6326: Add a debug mode that filters level tag values to mnafees.
Jun 12 2017, 7:28 PM · Marble: Indoor Maps
rahn updated the task description for T6326: Add a debug mode that filters level tag values.
Jun 12 2017, 7:23 PM · Marble: Indoor Maps
rahn created T6326: Add a debug mode that filters level tag values.
Jun 12 2017, 7:21 PM · Marble: Indoor Maps
rahn created T6325: Highlight buildings on selection.
Jun 12 2017, 7:19 PM · Marble: Indoor Maps
rahn updated the task description for T6324: Remove the visual category "building".
Jun 12 2017, 7:16 PM · Marble: Indoor Maps
rahn created T6324: Remove the visual category "building".
Jun 12 2017, 7:15 PM · Marble: Indoor Maps
rahn updated the task description for T6323: Include the concept of the building relation into parser and renderer .
Jun 12 2017, 7:12 PM · Marble: Indoor Maps
rahn updated the task description for T6322: Initial integration of the GeoDataBuilding into the parser and renderer.
Jun 12 2017, 7:12 PM · Marble: Indoor Maps
rahn updated the task description for T6322: Initial integration of the GeoDataBuilding into the parser and renderer.
Jun 12 2017, 7:11 PM · Marble: Indoor Maps
rahn created T6323: Include the concept of the building relation into parser and renderer .
Jun 12 2017, 7:09 PM · Marble: Indoor Maps
rahn created T6322: Initial integration of the GeoDataBuilding into the parser and renderer.
Jun 12 2017, 7:01 PM · Marble: Indoor Maps
rahn updated the task description for T6300: Introduce the GeoDataBuilding class.
Jun 12 2017, 6:54 PM · Marble: Indoor Maps

May 15 2017

rahn renamed T6136: Preparation: Set up the Android environment from Set up the Android environment to Preparation: Set up the Android environment .
May 15 2017, 7:53 PM · Android, Marble: Material Maps
rahn created T6141: Training: Read a tutorial about QML basics.
May 15 2017, 7:51 PM · Marble: Material Maps
rahn created T6140: Blog Entry: Describe the results of the first Milestone (June) .
May 15 2017, 7:43 PM · Marble: Material Maps
rahn updated the task description for T6139: Research: Perform a User Interface Evaluation.
May 15 2017, 7:36 PM · Marble: Material Maps
rahn updated the task description for T6139: Research: Perform a User Interface Evaluation.
May 15 2017, 7:35 PM · Marble: Material Maps
rahn renamed T6139: Research: Perform a User Interface Evaluation from Perform a User Interface Evaluation to Research: Perform a User Interface Evaluation.
May 15 2017, 7:35 PM · Marble: Material Maps
rahn created T6139: Research: Perform a User Interface Evaluation.
May 15 2017, 7:34 PM · Marble: Material Maps
rahn updated the task description for T6137: Initial coding task: Phone number in the info panel.
May 15 2017, 7:07 PM · Marble: Material Maps
rahn updated the task description for T6137: Initial coding task: Phone number in the info panel.
May 15 2017, 7:06 PM · Marble: Material Maps
rahn created T6137: Initial coding task: Phone number in the info panel.
May 15 2017, 7:05 PM · Marble: Material Maps

Dec 17 2016

rahn added a comment to T4911: Invert landmass.

I don't see the big advantage of this approach. Both approaches have their advantages and disadvantages: For the inverted approach you have flicker for coast- and sea areas (which looks equally bad and odd to me). Implementing the inverted approach will have a slight performance advantage if we don't manage the background color in a more sophisticated way. Implementing the inverted approach means on the other side that we have to develop a special dedicated plugin that will paint the pole caps blue - to avoid landmass-white circular polecaps beyond +/-85 degs latitude.

Dec 17 2016, 9:19 AM · Marble

Dec 11 2016

rahn added a reverting change for R34:7d0e1583707d: Call update right from the initialization.: R34:08d83c42c4c9: Something isn't quite right with regard to this. Pulling it back until the….
Dec 11 2016, 6:39 PM
rahn committed R34:08d83c42c4c9: Something isn't quite right with regard to this. Pulling it back until the… (authored by rahn).
Something isn't quite right with regard to this. Pulling it back until the…
Dec 11 2016, 6:39 PM
rahn committed R34:7d0e1583707d: Call update right from the initialization. (authored by rahn).
Call update right from the initialization.
Dec 11 2016, 5:59 PM
rahn committed R34:2c08c033fa5c: Fixes for wrong linestring styling (e.g. trams). (authored by rahn).
Fixes for wrong linestring styling (e.g. trams).
Dec 11 2016, 3:06 PM
rahn accepted D3642: Show wheelchair information.
Dec 11 2016, 12:22 PM
rahn added inline comments to D3642: Show wheelchair information.
Dec 11 2016, 12:08 PM