rahn (Torsten Rahn)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Sep 8 2015, 2:26 PM (114 w, 4 d)
Availability
Available

Recent Activity

Mon, Nov 6

rahn accepted D8685: Added 2017 GSoC Contributors in Authors List.

Looks good :)

Mon, Nov 6, 8:15 PM · KDE Edu

Sep 16 2017

rahn added a comment to D7805: Add a splash screen to Marble Maps.

To me it looks like the 256x256 version got scaled down to 100x100 and then got scaled up again.

Sep 16 2017, 8:48 AM · Marble
rahn added a comment to D7805: Add a splash screen to Marble Maps.

The 256x256 version surely looks better than that:

Sep 16 2017, 8:35 AM · Marble
rahn committed R34:5db029953fe6: Do away with the crashes that were triggered by the m_lastPlacemarkAt-Pointer's… (authored by rahn).
Do away with the crashes that were triggered by the m_lastPlacemarkAt-Pointer's…
Sep 16 2017, 8:24 AM
rahn committed R34:065b4d499e2c: Do away with the crashes that were triggered by the m_lastPlacemarkAt-Pointer's… (authored by rahn).
Do away with the crashes that were triggered by the m_lastPlacemarkAt-Pointer's…
Sep 16 2017, 8:24 AM

Sep 15 2017

rahn committed R34:08cb69b70fe7: Make m_lastPlacemarkAt a QPointer to avoid crashes. (authored by rahn).
Make m_lastPlacemarkAt a QPointer to avoid crashes.
Sep 15 2017, 7:49 PM
rahn committed R34:598dee257a88: Make m_lastPlacemarkAt a QPointer to avoid crashes. (authored by rahn).
Make m_lastPlacemarkAt a QPointer to avoid crashes.
Sep 15 2017, 7:47 PM
rahn accepted D7818: Fix issue of pressing back-button always leading to closing the app instead of handling the event depending on different scenarios.

Please commit.

Sep 15 2017, 4:32 PM · Marble
rahn added a comment to D7805: Add a splash screen to Marble Maps.

... or use the SVG - whatever works better technically (I guess the PNG would be loaded faster on slower devices).

Sep 15 2017, 4:28 PM · Marble
rahn added a comment to D7805: Add a splash screen to Marble Maps.

I've just submitted the 256x256 version of the png to master ...

Sep 15 2017, 4:27 PM · Marble
rahn committed R34:c4e30984a671: Adding 256x256 version for the splash screen. (authored by rahn).
Adding 256x256 version for the splash screen.
Sep 15 2017, 4:26 PM
rahn added a comment to D7805: Add a splash screen to Marble Maps.

Guys, we DO have an SVG as a source file. That's why I asked for the preferred resolution in the first place!

Sep 15 2017, 4:23 PM · Marble

Sep 14 2017

rahn added a comment to D7625: Some countries are invisible on the political map .

And backported to 17.08 branch. Does this patch require any more action?

Sep 14 2017, 5:21 PM · Marble
rahn accepted D7779: Make the bookmarks dialog responsive to touch everywhere in Marble Maps.

Looks good to me. Feel free to commit. It would be great if Judit could verify this. :-)

Sep 14 2017, 5:18 PM · Marble
rahn updated subscribers of D7779: Make the bookmarks dialog responsive to touch everywhere in Marble Maps.
Sep 14 2017, 5:17 PM · Marble
rahn added a reviewer for D7779: Make the bookmarks dialog responsive to touch everywhere in Marble Maps: juditbartha.
Sep 14 2017, 5:17 PM · Marble
rahn committed R34:7a20f244b235: CHANGELOG: Fix for "Some countries are invisible on the political map" BUG… (authored by McPain).
CHANGELOG: Fix for "Some countries are invisible on the political map" BUG…
Sep 14 2017, 5:10 PM
rahn added a comment to D7818: Fix issue of pressing back-button always leading to closing the app instead of handling the event depending on different scenarios.

Looks fine to me. Maybe Judit can confirm this patch?

Sep 14 2017, 5:07 PM · Marble
rahn updated subscribers of D7818: Fix issue of pressing back-button always leading to closing the app instead of handling the event depending on different scenarios.
Sep 14 2017, 5:06 PM · Marble
rahn added a comment to D7805: Add a splash screen to Marble Maps.

Looks nice indeed - but the logo should be bigger.

Sep 14 2017, 5:04 PM · Marble
rahn added a comment to D7805: Add a splash screen to Marble Maps.

I think that displaying the Marble logo is fine - which version are you using currently? 128x128? What would be suitable for most devices? 256x256?

Sep 14 2017, 5:03 PM · Marble
rahn accepted D7625: Some countries are invisible on the political map .

Submitted to master.

Sep 14 2017, 4:57 PM · Marble
rahn committed R34:456266eb31a8: CHANGELOG: Fix for "Some countries are invisible on the political map" BUG… (authored by McPain).
CHANGELOG: Fix for "Some countries are invisible on the political map" BUG…
Sep 14 2017, 4:50 PM

Sep 13 2017

rahn added a comment to D7625: Some countries are invisible on the political map .

I looked a bit deeper into the code and indeed it sounds sensible that a feature could possibly mapped to multiple items. So unless there are any concerns from other developers I will commit this later today.

Sep 13 2017, 6:48 AM · Marble
rahn added a comment to D7625: Some countries are invisible on the political map .

Thanks for keeping the ball rolling regarding this very important issue.

Sep 13 2017, 5:39 AM · Marble

Aug 31 2017

rahn added a comment to D7623: Remove the visual category "building".

Looks good to me!

Aug 31 2017, 6:58 PM
rahn added a comment to D7625: Some countries are invisible on the political map .

Now the only other similar regression is see is the initial lack of colorization for the atlas map theme. Might be a nice follow-up issue to look into if you feel like it ;)

Aug 31 2017, 6:14 PM · Marble
rahn added a comment to D7625: Some countries are invisible on the political map .

Thanks a lot! I've just tested it and it works nicely indeed (also for the other vector-based maps).

Aug 31 2017, 6:12 PM · Marble
rahn added inline comments to D7622: Render indoor walls, rooms and doors.
Aug 31 2017, 5:59 PM

Aug 28 2017

rahn added inline comments to D7490: Marble Maps combined revisions.
Aug 28 2017, 3:47 PM · Marble
rahn added inline comments to D7493: Behaim Globe revisions.
Aug 28 2017, 3:42 PM · Marble: Material Maps
rahn added a comment to D7493: Behaim Globe revisions.

Looks very good to me.

Aug 28 2017, 3:41 PM · Marble: Material Maps

Aug 21 2017

rahn added a comment to D7453: Marble Maps design revisions.

Looks nice to me in general.

Aug 21 2017, 6:28 PM · Marble
rahn committed R34:bc692ab6f3b1: Plain SVG (authored by rahn).
Plain SVG
Aug 21 2017, 5:56 PM
rahn committed R34:ca668ebf10ab: Alternative icon for door (authored by rahn).
Alternative icon for door
Aug 21 2017, 5:54 PM
rahn added a comment to D7453: Marble Maps design revisions.

Looks nice to me in general.

Aug 21 2017, 5:19 PM · Marble

Aug 20 2017

rahn committed R34:9a0e6f47e387: First suggestion for a door icon. (authored by rahn).
First suggestion for a door icon.
Aug 20 2017, 8:55 AM
rahn committed R34:5740b95e3fb0: First suggestion for a wall icon. (authored by rahn).
First suggestion for a wall icon.
Aug 20 2017, 8:19 AM
rahn added inline comments to D7353: Marble Maps design revisions using Kirigami.
Aug 20 2017, 7:24 AM · Kirigami, Marble: Material Maps
rahn added a comment to D7353: Marble Maps design revisions using Kirigami.

Any further updates? :)

Aug 20 2017, 7:21 AM · Kirigami, Marble: Material Maps

Aug 14 2017

rahn added a comment to D7252: WIP: Add UI to change levels in a building/area.

Looks good to me in general. I guess the only other consideration that we can postpone for now is binary compatibility.

Aug 14 2017, 6:39 PM

Jul 2 2017

rahn added inline comments to D6303: Initial integration of the GeoDataBuilding into the parser and renderer.
Jul 2 2017, 7:50 PM

Jun 12 2017

rahn assigned T6326: Add a debug mode that filters level tag values to mnafees.
Jun 12 2017, 7:28 PM · Marble: Indoor Maps
rahn updated the task description for T6326: Add a debug mode that filters level tag values.
Jun 12 2017, 7:23 PM · Marble: Indoor Maps
rahn created T6326: Add a debug mode that filters level tag values.
Jun 12 2017, 7:21 PM · Marble: Indoor Maps
rahn created T6325: Highlight buildings on selection.
Jun 12 2017, 7:19 PM · Marble: Indoor Maps
rahn updated the task description for T6324: Remove the visual category "building".
Jun 12 2017, 7:16 PM · Marble: Indoor Maps
rahn created T6324: Remove the visual category "building".
Jun 12 2017, 7:15 PM · Marble: Indoor Maps
rahn updated the task description for T6323: Include the concept of the building relation into parser and renderer .
Jun 12 2017, 7:12 PM · Marble: Indoor Maps
rahn updated the task description for T6322: Initial integration of the GeoDataBuilding into the parser and renderer.
Jun 12 2017, 7:12 PM · Marble: Indoor Maps
rahn updated the task description for T6322: Initial integration of the GeoDataBuilding into the parser and renderer.
Jun 12 2017, 7:11 PM · Marble: Indoor Maps
rahn created T6323: Include the concept of the building relation into parser and renderer .
Jun 12 2017, 7:09 PM · Marble: Indoor Maps
rahn created T6322: Initial integration of the GeoDataBuilding into the parser and renderer.
Jun 12 2017, 7:01 PM · Marble: Indoor Maps
rahn updated the task description for T6300: Introduce the GeoDataBuilding class.
Jun 12 2017, 6:54 PM · Marble: Indoor Maps

May 15 2017

rahn renamed T6136: Preparation: Set up the Android environment from Set up the Android environment to Preparation: Set up the Android environment .
May 15 2017, 7:53 PM · Android, Marble: Material Maps
rahn created T6141: Training: Read a tutorial about QML basics.
May 15 2017, 7:51 PM · Marble: Material Maps
rahn created T6140: Blog Entry: Describe the results of the first Milestone (June) .
May 15 2017, 7:43 PM · Marble: Material Maps
rahn updated the task description for T6139: Research: Perform a User Interface Evaluation.
May 15 2017, 7:36 PM · Marble: Material Maps
rahn updated the task description for T6139: Research: Perform a User Interface Evaluation.
May 15 2017, 7:35 PM · Marble: Material Maps
rahn renamed T6139: Research: Perform a User Interface Evaluation from Perform a User Interface Evaluation to Research: Perform a User Interface Evaluation.
May 15 2017, 7:35 PM · Marble: Material Maps
rahn created T6139: Research: Perform a User Interface Evaluation.
May 15 2017, 7:34 PM · Marble: Material Maps
rahn updated the task description for T6137: Initial coding task: Phone number in the info panel.
May 15 2017, 7:07 PM · Marble: Material Maps
rahn updated the task description for T6137: Initial coding task: Phone number in the info panel.
May 15 2017, 7:06 PM · Marble: Material Maps
rahn created T6137: Initial coding task: Phone number in the info panel.
May 15 2017, 7:05 PM · Marble: Material Maps

Dec 17 2016

rahn added a comment to T4911: Invert landmass.

I don't see the big advantage of this approach. Both approaches have their advantages and disadvantages: For the inverted approach you have flicker for coast- and sea areas (which looks equally bad and odd to me). Implementing the inverted approach will have a slight performance advantage if we don't manage the background color in a more sophisticated way. Implementing the inverted approach means on the other side that we have to develop a special dedicated plugin that will paint the pole caps blue - to avoid landmass-white circular polecaps beyond +/-85 degs latitude.

Dec 17 2016, 9:19 AM · Marble

Dec 11 2016

rahn added a reverting commit for R34:7d0e1583707d: Call update right from the initialization.: R34:08d83c42c4c9: Something isn't quite right with regard to this. Pulling it back until the….
Dec 11 2016, 6:39 PM
rahn committed R34:08d83c42c4c9: Something isn't quite right with regard to this. Pulling it back until the… (authored by rahn).
Something isn't quite right with regard to this. Pulling it back until the…
Dec 11 2016, 6:39 PM
rahn committed R34:7d0e1583707d: Call update right from the initialization. (authored by rahn).
Call update right from the initialization.
Dec 11 2016, 5:59 PM
rahn committed R34:2c08c033fa5c: Fixes for wrong linestring styling (e.g. trams). (authored by rahn).
Fixes for wrong linestring styling (e.g. trams).
Dec 11 2016, 3:06 PM
rahn accepted D3642: Show wheelchair information.
Dec 11 2016, 12:22 PM
rahn added inline comments to D3642: Show wheelchair information.
Dec 11 2016, 12:08 PM
rahn committed R34:6ce34abed1ef: Adding adminlevel 2 capital icon for GCI task. (authored by rahn).
Adding adminlevel 2 capital icon for GCI task.
Dec 11 2016, 10:00 AM
rahn committed R34:c099e92e7974: Life is short. http://meaningdefined.com/what-is-the-meaning-of/okdbg/acronym… (authored by rahn).
Life is short. http://meaningdefined.com/what-is-the-meaning-of/okdbg/acronym…
Dec 11 2016, 12:32 AM
rahn committed R34:0389cac041e4: Minor improvements to the visual debug modes (authored by rahn).
Minor improvements to the visual debug modes
Dec 11 2016, 12:29 AM

Dec 10 2016

rahn committed R34:221f153ce665: Cache GeoGraphicsScene::items() as much as possible. (authored by rahn).
Cache GeoGraphicsScene::items() as much as possible.
Dec 10 2016, 9:12 PM
rahn committed R34:7e68a2f81c0c: Introducing (authored by rahn).
Introducing
Dec 10 2016, 7:25 PM

Dec 9 2016

rahn committed R34:bf88fdd2bae4: Batch rendering for roads, Admin boundaries, rivers and non-special cased… (authored by rahn).
Batch rendering for roads, Admin boundaries, rivers and non-special cased…
Dec 9 2016, 3:19 PM
rahn committed R34:6b0cf92c229f: Partial fix for building number regression. (authored by rahn).
Partial fix for building number regression.
Dec 9 2016, 12:25 AM

Dec 8 2016

rahn committed R34:b76b9ecefb91: Fix position provider performance issue: Don't always query the actual position… (authored by rahn).
Fix position provider performance issue: Don't always query the actual position…
Dec 8 2016, 10:18 PM
rahn committed R34:3364bf6d358d: Performance: Only perform painter configuration if there is really… (authored by rahn).
Performance: Only perform painter configuration if there is really…
Dec 8 2016, 4:48 PM
rahn committed R34:0409e2691c72: AbstractGeoPolygonGraphicsItem refactoring to avoid painter state changes… (authored by rahn).
AbstractGeoPolygonGraphicsItem refactoring to avoid painter state changes…
Dec 8 2016, 4:48 PM
rahn committed R34:47418575d4f5: Add icons for further GCI tasks. (authored by rahn).
Add icons for further GCI tasks.
Dec 8 2016, 6:52 AM

Dec 7 2016

rahn committed R34:72e1772eece5: Adding the header as well .. (authored by rahn).
Adding the header as well ..
Dec 7 2016, 8:52 PM
rahn committed R34:d31a23be1ef4: Fix the build by adding BatchedPlacemarkRenderer.cpp (authored by rahn).
Fix the build by adding BatchedPlacemarkRenderer.cpp
Dec 7 2016, 7:56 PM
rahn committed R34:f3783637baa0: Separate house numbers rendering to be actually drawn after drawing the… (authored by rahn).
Separate house numbers rendering to be actually drawn after drawing the…
Dec 7 2016, 6:13 PM

Dec 5 2016

rahn committed R34:3f33818442b8: - Fix "dancing rivers" introduced by omitting the mandatory outline layer. (authored by rahn).
- Fix "dancing rivers" introduced by omitting the mandatory outline layer.
Dec 5 2016, 11:26 PM
rahn committed R34:f2635ad69bc4: try harder to avoid QImage. (authored by rahn).
try harder to avoid QImage.
Dec 5 2016, 9:21 PM
rahn committed R34:f5419eaaf0b8: Let's avoid the roundtrip around QImage when creating the brush texture. (authored by rahn).
Let's avoid the roundtrip around QImage when creating the brush texture.
Dec 5 2016, 8:38 PM
rahn committed R34:bf7b5e150564: Add reserve call to GeoDataLineString and to the OSM file runner. (authored by rahn).
Add reserve call to GeoDataLineString and to the OSM file runner.
Dec 5 2016, 6:44 AM

Dec 4 2016

rahn committed R34:373230c94a40: Use QPolygon::reserve where possible. (authored by rahn).
Use QPolygon::reserve where possible.
Dec 4 2016, 11:40 PM
rahn committed R34:2777cef9944b: Performance: At level 17 render buildings flat. (authored by rahn).
Performance: At level 17 render buildings flat.
Dec 4 2016, 8:52 PM

Dec 3 2016

rahn committed R34:456bb981173a: Lots of new osmcarto icons! (authored by rahn).
Lots of new osmcarto icons!
Dec 3 2016, 12:52 PM

Dec 2 2016

rahn committed R34:e4e70ad127e6: Render Raceway Highways https://phabricator.kde.org/D3570 (authored by xdizzaster).
Render Raceway Highways https://phabricator.kde.org/D3570
Dec 2 2016, 9:38 PM
rahn accepted D3570: Render raceways highways.

Excellent!

Dec 2 2016, 9:19 PM
rahn added a comment to D3570: Render raceways highways.

I've tested you patch and the only thing left to complete this task seems to be the compilation warning above. Apart from that it looks great.

Dec 2 2016, 8:53 PM
rahn added a comment to D3570: Render raceways highways.

Sorry, still a nitpick: during compilation I get this:

Dec 2 2016, 8:48 PM
rahn added a comment to D3570: Render raceways highways.

Nice, still some minor nitpicks.

Dec 2 2016, 7:32 PM
rahn added reviewers for D3570: Render raceways highways: nienhueser, rahn, Marble.
Dec 2 2016, 5:25 PM
rahn added a member for Marble: xdizzaster.
Dec 2 2016, 5:13 PM

Dec 1 2016

rahn added a comment to D3563: Added a warning when no plugins could be loaded, see T2114 for more details..

Didn't know about isEmpty(), but should have, I feel bad now...
If by OSD you mean the notifications from KDE, I don't think it is necessary: Unix users can always look at the debug output, just Windows users would have to debug the application to get those messages, so that's why a QMessageBox is better for them I figure.

Dec 1 2016, 9:02 PM