- User Since
- Sep 8 2015, 2:26 PM (145 w, 4 d)
Thu, Jun 21
Good catch! Looks good to me. Could you commit?
Nov 6 2017
Looks good :)
Sep 16 2017
To me it looks like the 256x256 version got scaled down to 100x100 and then got scaled up again.
The 256x256 version surely looks better than that:
Sep 15 2017
... or use the SVG - whatever works better technically (I guess the PNG would be loaded faster on slower devices).
I've just submitted the 256x256 version of the png to master ...
Guys, we DO have an SVG as a source file. That's why I asked for the preferred resolution in the first place!
Sep 14 2017
And backported to 17.08 branch. Does this patch require any more action?
Looks good to me. Feel free to commit. It would be great if Judit could verify this. :-)
Looks fine to me. Maybe Judit can confirm this patch?
Looks nice indeed - but the logo should be bigger.
I think that displaying the Marble logo is fine - which version are you using currently? 128x128? What would be suitable for most devices? 256x256?
Submitted to master.
Sep 13 2017
I looked a bit deeper into the code and indeed it sounds sensible that a feature could possibly mapped to multiple items. So unless there are any concerns from other developers I will commit this later today.
Thanks for keeping the ball rolling regarding this very important issue.
Aug 31 2017
Looks good to me!
Now the only other similar regression is see is the initial lack of colorization for the atlas map theme. Might be a nice follow-up issue to look into if you feel like it ;)
Thanks a lot! I've just tested it and it works nicely indeed (also for the other vector-based maps).
Aug 28 2017
Looks very good to me.
Aug 21 2017
Looks nice to me in general.
Looks nice to me in general.
Aug 20 2017
Any further updates? :)
Aug 14 2017
Looks good to me in general. I guess the only other consideration that we can postpone for now is binary compatibility.
Jul 2 2017
Jun 12 2017
May 15 2017
Dec 17 2016
I don't see the big advantage of this approach. Both approaches have their advantages and disadvantages: For the inverted approach you have flicker for coast- and sea areas (which looks equally bad and odd to me). Implementing the inverted approach will have a slight performance advantage if we don't manage the background color in a more sophisticated way. Implementing the inverted approach means on the other side that we have to develop a special dedicated plugin that will paint the pole caps blue - to avoid landmass-white circular polecaps beyond +/-85 degs latitude.
Dec 11 2016
Dec 10 2016
Dec 9 2016
Dec 8 2016
Dec 7 2016
Dec 5 2016
Dec 4 2016
Dec 3 2016
Dec 2 2016
I've tested you patch and the only thing left to complete this task seems to be the compilation warning above. Apart from that it looks great.
Sorry, still a nitpick: during compilation I get this:
Nice, still some minor nitpicks.