- User Since
- Sep 8 2015, 2:26 PM (252 w, 12 h)
Jan 15 2020
Jan 2 2020
Thanks for the patch - looks great :-)
Nov 12 2019
Sorry, I totally missed this patch. Looks very interesting.
Oct 31 2019
The root cause has been known since over 2 years and I had told you about it: The default route web service had changed its format from xml to json.
So fixing it requires rewriting the plugin. Feel free to send patches ...
Sep 12 2019
Sep 3 2019
Sep 2 2019
Submitted with 6b8cc37af9a567c1f8c87a2e0f00fc17981b3f2c. Thanks a lot!
Neato. :-) There is by the way "mDebug". But I'm not sure whether we use it consistently.
Aug 27 2019
Feb 26 2019
Looks nice to me.
sorry for noticing this late
apart from the Boolean issue this looks good to me and can be submitted.
Oct 17 2018
Thanks a lot guys!
Sep 21 2018
Aug 31 2018
Have you tested creating a new deployable Windows package? Or did you just test whether compilation on the platform works? :-)
Looks good to me!
Jul 11 2018
Looks good (should we switch to the new connect syntax?).
Sounds good. I'm not exactly familiar with this issue but it looks reasonable. Thanks a lot! :-)
Jun 21 2018
Good catch! Looks good to me. Could you commit?
Nov 6 2017
Looks good :)
Sep 16 2017
To me it looks like the 256x256 version got scaled down to 100x100 and then got scaled up again.
The 256x256 version surely looks better than that:
Sep 15 2017
... or use the SVG - whatever works better technically (I guess the PNG would be loaded faster on slower devices).
I've just submitted the 256x256 version of the png to master ...
Guys, we DO have an SVG as a source file. That's why I asked for the preferred resolution in the first place!
Sep 14 2017
And backported to 17.08 branch. Does this patch require any more action?
Looks good to me. Feel free to commit. It would be great if Judit could verify this. :-)
Looks fine to me. Maybe Judit can confirm this patch?
Looks nice indeed - but the logo should be bigger.
I think that displaying the Marble logo is fine - which version are you using currently? 128x128? What would be suitable for most devices? 256x256?
Submitted to master.
Sep 13 2017
I looked a bit deeper into the code and indeed it sounds sensible that a feature could possibly mapped to multiple items. So unless there are any concerns from other developers I will commit this later today.
Thanks for keeping the ball rolling regarding this very important issue.
Aug 31 2017
Looks good to me!
Now the only other similar regression is see is the initial lack of colorization for the atlas map theme. Might be a nice follow-up issue to look into if you feel like it ;)
Thanks a lot! I've just tested it and it works nicely indeed (also for the other vector-based maps).