Add some missing properties to Deleted
ClosedPublic

Authored by zzag on Jun 21 2018, 7:55 AM.

Details

Summary

keepAbove

Some effects(e.g. Dim Inactive) can take keep above state of a window
into account when they are making decision whether to operate on it.
Because Deleted doesn't expose keepAbove property, it will be always
true, which is wrong.

keepBelow

This property was added as a counterpart to keepAbove.

caption

That's mostly for debugging purposes, e.g.

void CoolEffect::windowClosed(EffectWindow *w)
{
    qDebug() << w->caption() << "has been closed";
    qDebug() << "keep above:" << w->keepAbove();
}
Test Plan

Manually.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Jun 21 2018, 7:55 AM
Restricted Application added a project: KWin. · View Herald TranscriptJun 21 2018, 7:55 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Jun 21 2018, 7:55 AM
zzag edited the summary of this revision. (Show Details)Jun 21 2018, 7:58 AM
davidedmundson accepted this revision.Jun 21 2018, 9:58 PM
This revision is now accepted and ready to land.Jun 21 2018, 9:58 PM
This revision was automatically updated to reflect the committed changes.